what-compiler 0.6.1 → 0.6.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "what-compiler",
-  "version": "0.6.1",
+  "version": "0.6.3",
   "description": "JSX compiler for What Framework - transforms JSX to optimized DOM operations",
   "main": "src/index.js",
   "type": "module",
@@ -38,7 +38,7 @@
   "license": "MIT",
   "peerDependencies": {
     "@babel/core": "^7.0.0",
-    "what-core": "^0.6.0"
+    "what-core": "^0.6.3"
   },
   "files": [
     "src",

package/src/babel-plugin.js

@@ -436,6 +436,7 @@ export default function whatBabelPlugin({ types: t }) {
     for (const attr of el.attributes) {
       if (t.isJSXSpreadAttribute(attr)) continue;
       const name = getAttrName(attr);
+      if (name === 'key') continue;
       if (name.startsWith('on') || name.startsWith('bind:') || name.includes('|')) continue;
 
       let domName = name;
@@ -642,6 +643,9 @@ export default function whatBabelPlugin({ types: t }) {
 
       const attrName = getAttrName(attr);
 
+      // Strip key prop — WhatFW has no virtual DOM, so key is meaningless (issue #6)
+      if (attrName === 'key') continue;
+
       // Ref handling — assign element to ref object/callback
       if (attrName === 'ref') {
         const refExpr = getAttributeValue(attr.value);
@@ -1076,10 +1080,12 @@ export default function whatBabelPlugin({ types: t }) {
         islandProps.push(t.objectProperty(t.identifier(attrName), value));
       }
 
-      return t.callExpression(
+      const islandCall = t.callExpression(
         t.identifier('_$createComponent'),
         [t.identifier('Island'), t.objectExpression(islandProps), t.arrayExpression([])]
       );
+      t.addComment(islandCall, 'leading', '#__PURE__');
+      return islandCall;
     }
 
     // Regular component — use _$createComponent to instantiate, component runs once
@@ -1098,6 +1104,9 @@ export default function whatBabelPlugin({ types: t }) {
 
       const attrName = getAttrName(attr);
 
+      // Strip key prop — WhatFW has no virtual DOM, so key is meaningless (issue #6)
+      if (attrName === 'key') continue;
+
       // Handle bind: attributes for components
       if (isBindingAttribute(attrName)) {
         const bindProp = getBindingProperty(attrName);
@@ -1203,7 +1212,11 @@ export default function whatBabelPlugin({ types: t }) {
       ? t.arrayExpression(transformedChildren)
       : t.arrayExpression([]);
 
-    return t.callExpression(t.identifier('_$createComponent'), [t.identifier(componentName), propsExpr, childrenArray]);
+    const call = t.callExpression(t.identifier('_$createComponent'), [t.identifier(componentName), propsExpr, childrenArray]);
+    // Mark component creation as pure for tree-shaking: if the result is unused,
+    // bundlers can safely eliminate the call.
+    t.addComment(call, 'leading', '#__PURE__');
+    return call;
   }
 
   function transformForFineGrained(path, state) {
@@ -1315,6 +1328,8 @@ export default function whatBabelPlugin({ types: t }) {
           state._varCounter = 0;
           state._pendingSetup = [];
           state.nextVarId = () => `_el$${state._varCounter++}`;
+          state.runtimePackage = 'what-framework';
+          state._sawFrameworkImport = false;
 
           // Collect signal names for smart reactivity detection
           state.signalNames = new Set();
@@ -1328,6 +1343,13 @@ export default function whatBabelPlugin({ types: t }) {
           for (const node of path.node.body) {
             if (t.isImportDeclaration(node)) {
               const source = node.source.value;
+              if (source === 'what-framework' || source.startsWith('what-framework/')) {
+                state.runtimePackage = 'what-framework';
+                state._sawFrameworkImport = true;
+              } else if (!state._sawFrameworkImport && (source === 'what-core' || source.startsWith('what-core/'))) {
+                state.runtimePackage = 'what-core';
+              }
+
               const isReactiveSource =
                 source === 'what-framework' ||
                 source.startsWith('what-framework/') ||
@@ -1393,11 +1415,15 @@ export default function whatBabelPlugin({ types: t }) {
         exit(path, state) {
           // Insert template declarations at top of program (hoisted to module scope)
           for (const tmpl of state.templates.reverse()) {
+            const templateCall = t.callExpression(t.identifier('_$template'), [t.stringLiteral(tmpl.html)]);
+            // Mark template creation as pure for tree-shaking: if the template
+            // variable is never referenced, bundlers can eliminate this call.
+            t.addComment(templateCall, 'leading', '#__PURE__');
             path.unshiftContainer('body',
               t.variableDeclaration('const', [
                 t.variableDeclarator(
                   t.identifier(tmpl.id),
-                  t.callExpression(t.identifier('_$template'), [t.stringLiteral(tmpl.html)])
+                  templateCall
                 )
               ])
             );
@@ -1468,6 +1494,8 @@ export default function whatBabelPlugin({ types: t }) {
             let existingRenderImport = null;
             for (const node of path.node.body) {
               if (t.isImportDeclaration(node) && (
+                node.source.value === 'what-framework/compiler' ||
+                node.source.value === 'what-core/compiler' ||
                 node.source.value === 'what-framework/render' ||
                 node.source.value === 'what-core/render'
               )) {
@@ -1489,13 +1517,13 @@ export default function whatBabelPlugin({ types: t }) {
               }
             } else {
               path.unshiftContainer('body',
-                t.importDeclaration(fgSpecifiers, t.stringLiteral('what-framework/render'))
+                t.importDeclaration(fgSpecifiers, t.stringLiteral(`${state.runtimePackage}/compiler`))
               );
             }
           }
 
           if (coreSpecifiers.length > 0) {
-            addCoreImports(path, t, coreSpecifiers);
+            addCoreImports(path, t, coreSpecifiers, state.runtimePackage);
           }
 
           // Emit event delegation setup call if any delegated events were used
@@ -1555,7 +1583,7 @@ export default function whatBabelPlugin({ types: t }) {
   };
 }
 
-function addCoreImports(path, t, coreSpecifiers) {
+function addCoreImports(path, t, coreSpecifiers, runtimePackage = 'what-framework') {
   let existingImport = null;
   for (const node of path.node.body) {
     if (t.isImportDeclaration(node) && (
@@ -1580,7 +1608,7 @@ function addCoreImports(path, t, coreSpecifiers) {
   } else {
     const importDecl = t.importDeclaration(
       coreSpecifiers,
-      t.stringLiteral('what-framework')
+      t.stringLiteral(runtimePackage)
     );
     path.unshiftContainer('body', importDecl);
   }