what-compiler 0.10.0 → 0.11.1

package/src/vite-plugin.js

@@ -17,6 +17,41 @@ import { setupErrorOverlay } from './error-overlay.js';
 const VIRTUAL_ROUTES_ID = 'virtual:what-routes';
 const RESOLVED_VIRTUAL_ID = '\0' + VIRTUAL_ROUTES_ID;
 
+/**
+ * Shape the "preserve JSX" transform config for the running Vite version.
+ *
+ * Vite ≤7 transforms with esbuild and takes `esbuild: { jsx: 'preserve' }`.
+ * Vite 8 (rolldown-based) transforms with oxc; the `esbuild` key still works
+ * but prints a deprecation warning on every dev/build run
+ * ("'esbuild' option ... is deprecated, please use 'oxc' instead"), so we
+ * emit `oxc: { jsx: 'preserve' }` there instead.
+ *
+ * Detection (either signal selects oxc):
+ *  - feature: rolldown-vite exposes `this.meta.rolldownVersion` to plugins —
+ *    the most reliable signal, also covers `rolldown-vite` aliased as vite 7.
+ *  - version: `import('vite')` exports `version`; major ≥ 8 means rolldown.
+ *
+ * Exported for unit tests.
+ */
+export function jsxPreserveConfig({ rolldownVersion, viteVersion } = {}) {
+  const major = parseInt(String(viteVersion ?? ''), 10);
+  const useOxc = Boolean(rolldownVersion) || (Number.isFinite(major) && major >= 8);
+  return useOxc
+    ? { oxc: { jsx: 'preserve' } }
+    : { esbuild: { jsx: 'preserve' } };
+}
+
+// Resolved once per process — the Vite version can't change mid-run.
+let viteVersionPromise = null;
+function detectViteVersion() {
+  if (!viteVersionPromise) {
+    viteVersionPromise = import('vite')
+      .then((vite) => vite.version || '')
+      .catch(() => ''); // vite not resolvable (tests) — esbuild fallback
+  }
+  return viteVersionPromise;
+}
+
 // Pattern: exported function starting with uppercase = component
 const COMPONENT_EXPORT_RE = /export\s+(?:default\s+)?function\s+([A-Z]\w*)/;
 // Pattern: files that are likely signal/store/utility files
@@ -36,6 +71,11 @@ export default function whatVitePlugin(options = {}) {
     pages = 'src/pages',
     // HMR: enabled by default in dev, disabled in production
     hot = !production,
+    // Resolve the `production` exports condition (dist/*.min.js — pre-minified,
+    // dev warnings compiled out) during `vite build`. Set to false to build
+    // against package sources instead — needed e.g. in a monorepo where
+    // workspace-linked dist/ output may be stale or absent. See config() below.
+    prodBundles = true,
   } = options;
 
   let rootDir = '';
@@ -105,6 +145,13 @@ export default function whatVitePlugin(options = {}) {
         const result = transformSync(code, {
           filename: id,
           sourceMaps,
+          // Hermetic transform (SPRINT v0.11 C7): never load the project's
+          // babel.config.js/.babelrc. A user's React preset or unrelated
+          // plugins corrupting What's JSX output is a debugging nightmare —
+          // and scanning the disk for config files on every transform is
+          // wasted I/O in dev.
+          configFile: false,
+          babelrc: false,
           plugins: [
             [whatBabelPlugin, { production }]
           ],
@@ -165,12 +212,35 @@ export default function whatVitePlugin(options = {}) {
     },
 
     // Configure for development
-    config(config, { mode }) {
+    async config(config, { mode, command }) {
+      // SPRINT v0.11 C7: make the `production` exports condition reachable.
+      // what-framework/what-core ship pre-minified production bundles behind
+      // the `production` condition in their exports maps, but Vite's default
+      // resolve conditions never include `production` — so production builds
+      // silently shipped the dev source (larger, with dev-only warnings).
+      //
+      // Guard rationale (documented choice):
+      //  - Only during `vite build` in production mode — dev always uses src
+      //    so the dev server, HMR, and devtools see un-minified modules.
+      //  - Opt-out via `what({ prodBundles: false })` — in a monorepo with
+      //    workspace-linked packages, dist/ can be stale (or missing before
+      //    the first `npm run build`), and resolving `production` there would
+      //    bundle outdated framework code. Apps installing from npm always
+      //    have dist/ in sync with the published package, so the default is on.
+      //  - `resolve.conditions` is ADDITIVE in Vite (extra conditions on top
+      //    of the defaults), so import/browser/default resolution for other
+      //    packages is unaffected.
+      const useProdCondition = command === 'build' && mode === 'production' && prodBundles;
+      // Preserve JSX so our babel plugin handles it — don't let the bundler's
+      // built-in transformer (esbuild on Vite ≤7, oxc on Vite 8+) touch it.
+      // jsxPreserveConfig picks the right option key for the running version.
+      const jsxPreserve = jsxPreserveConfig({
+        rolldownVersion: this?.meta?.rolldownVersion,
+        viteVersion: await detectViteVersion(),
+      });
       return {
-        esbuild: {
-          // Preserve JSX so our babel plugin handles it -- don't let esbuild transform it
-          jsx: 'preserve',
-        },
+        ...(useProdCondition ? { resolve: { conditions: ['production'] } } : {}),
+        ...jsxPreserve,
         optimizeDeps: {
           // Exclude framework packages from Vite's dependency pre-bundling.
           //