whalibmob 5.9.0 → 5.9.2

package/lib/noise.js

@@ -449,10 +449,9 @@ class NoiseSocket extends EventEmitter {
           // for a bug in the client; the credentials were rejected by the
           // server, which is a different thing and has different remedies.
           //
-          // The names and numbers are whatsmeow's ConnectFailureReason, which
-          // is the only place they are written down — WhatsApp publishes none
-          // of this. Codes marked "wipe" are the ones its IsLoggedOut() covers:
-          // the session is finished and retrying with it is pointless.
+          // WhatsApp publishes none of this, so the meanings below come from
+          // observing the server. Codes marked "wipe" mean the session is
+          // finished and retrying with it is pointless.
           const FAILURE = {
             '400': { wipe: false, text: 'generic failure.' },
             '401': { wipe: true,  text: 'logged out. The session was unpaired ' +

package/lib/proto/MessageProto.js

@@ -226,10 +226,10 @@ function encodePollOption(name) {
 // PollCreationMessage { encKey=1, name=2, options=3, selectableOptionsCount=4 }
 //
 // The 32-byte secret was being written to encKey, inside the poll itself.
-// whatsmeow's BuildPollCreation leaves encKey unset and puts the secret in
-// Message.messageContextInfo.messageSecret instead — which is the copy a voter
-// derives their vote key from. In the wrong place it reached nobody, so the
-// poll could not be voted on.
+// encKey has to stay unset; the secret belongs in
+// Message.messageContextInfo.messageSecret, which is the copy a voter derives
+// their vote key from. In the wrong place it reached nobody, so the poll could
+// not be voted on.
 function encodePollCreationMessage(opts) {
   const messageSecret = opts.messageSecret || opts.encKey ||
     require('crypto').randomBytes(32);
@@ -672,28 +672,38 @@ function decodeMessageContainer(buf) {
       try {
         const pm = _decodeFields(f[12]);
         const pmType = pm[2];
+        // ProtocolMessage.Type. These are not the field numbers the payloads
+        // live in and the two must not be confused: HISTORY_SYNC_NOTIFICATION
+        // is type 5 carried in field 6, APP_STATE_SYNC_KEY_SHARE is type 6
+        // carried in field 7. Having those two the wrong way round meant a key
+        // share was read as a history notification, looked in the field it does
+        // not use, found nothing, and was dropped — so app state could never be
+        // decrypted at all.
         const typeNames = {
           0:  'revoke',
           3:  'ephemeral',
-          5:  'app_state_sync_key_share',
-          6:  'history_sync',
-          10: 'app_state_sync'
+          4:  'ephemeral_sync_response',
+          5:  'history_sync',
+          6:  'app_state_sync_key_share',
+          7:  'app_state_sync_key_request',
+          9:  'initial_security_notification_setting_sync',
+          10: 'app_state_fatal_exception',
+          11: 'share_phone_number',
+          14: 'message_edit'
         };
         const subtype = typeNames[pmType] || String(pmType);
         msgResult = { type: 'protocol', subtype };
 
-        // ── HISTORY_SYNC_NOTIFICATION (pmType=6) ─────────────────────────────
-        // ProtocolMessage field 6 holds the HistorySyncNotification bytes.
-        if (pmType === 6 && pm[6] && Buffer.isBuffer(pm[6])) {
+        // The payloads are read by the field they occupy rather than by the
+        // type that announced them, so a type number this list does not know
+        // about still delivers what it carried.
+        if (pm[6] && Buffer.isBuffer(pm[6])) {
           try {
             const { decodeHistorySyncNotification } = require('../HistorySyncHandler');
             msgResult.historySyncNotification = decodeHistorySyncNotification(pm[6]);
           } catch (_hse) {}
         }
-
-        // ── APP_STATE_SYNC_KEY_SHARE (pmType=5) ──────────────────────────────
-        // ProtocolMessage field 7 holds the AppStateSyncKeyShare bytes.
-        if (pmType === 5 && pm[7] && Buffer.isBuffer(pm[7])) {
+        if (pm[7] && Buffer.isBuffer(pm[7])) {
           try {
             const { decodeAppStateSyncKeyShare } = require('../HistorySyncHandler');
             msgResult.appStateSyncKeyShare = decodeAppStateSyncKeyShare(pm[7]);

package/lib/signal/SignalProtocol.js

@@ -278,15 +278,15 @@ class SignalProtocol {
 
   // ─── SenderKey group encrypt / decrypt ────────────────────────────────────
   //
-  // Uses WaSignalGroup GroupCipher/GroupSessionBuilder (Baileys-compatible).
+  // Uses WaSignalGroup GroupCipher/GroupSessionBuilder.
   // SenderKeyName format: groupId::senderId::0 (device 0 for group identity).
 
   _senderKeyName(groupId, senderId) {
     // A SenderKey belongs to a device, not to an account. Every device that
     // posts to a group distributes its own key, so the name has to carry the
-    // device index the way Baileys and whatsmeow do — otherwise two devices of
-    // the same person share one slot and the second one to speak overwrites
-    // the first, leaving its messages undecryptable.
+    // device index — otherwise two devices of the same person share one slot
+    // and the second one to speak overwrites the first, leaving its messages
+    // undecryptable.
     //
     // Bare JIDs still resolve to device 0, so everything already on disk keeps
     // the exact same key string.

package/lib/signal/SignalStore.js

@@ -209,8 +209,8 @@ class SignalStore {
   // SessionCipher.encrypt — which throws "No open session". bulkEncryptForDevices
   // drops whatever it cannot encrypt, so the stanza went out with a <to> entry
   // missing for that device and the server nacked the whole send with ack 479.
-  // Baileys hit the same class of bug with its peerSessionsCache and fixed it by
-  // validating through haveOpenSession() on every check.
+  // The fix is to validate the record itself on every check rather than
+  // trusting that a cached entry still holds an open session.
   hasSession(encodedAddress) {
     if (!this._openSessionMemo) this._openSessionMemo = new Map();
     const data = this._sessions[encodedAddress];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "whalibmob",
-  "version": "5.9.0",
+  "version": "5.9.2",
   "description": "WhatsApp library for interaction with WhatsApp Mobile API no web",
   "author": "Kunboruto50",
   "main": "index.js",