webpack 5.93.0 → 5.95.0

package/lib/MainTemplate.js

@@ -10,6 +10,7 @@ const util = require("util");
 const RuntimeGlobals = require("./RuntimeGlobals");
 const memoize = require("./util/memoize");
 
+/** @typedef {import("tapable").Tap} Tap */
 /** @typedef {import("webpack-sources").ConcatSource} ConcatSource */
 /** @typedef {import("webpack-sources").Source} Source */
 /** @typedef {import("../declarations/WebpackOptions").Output} OutputOptions */
@@ -17,15 +18,24 @@ const memoize = require("./util/memoize");
 /** @typedef {import("./Chunk")} Chunk */
 /** @typedef {import("./Compilation")} Compilation */
 /** @typedef {import("./Compilation").AssetInfo} AssetInfo */
+/** @typedef {import("./Compilation").InterpolatedPathAndAssetInfo} InterpolatedPathAndAssetInfo */
 /** @typedef {import("./Module")} Module} */
 /** @typedef {import("./util/Hash")} Hash} */
 /** @typedef {import("./DependencyTemplates")} DependencyTemplates} */
 /** @typedef {import("./javascript/JavascriptModulesPlugin").RenderContext} RenderContext} */
+/** @typedef {import("./javascript/JavascriptModulesPlugin").RenderBootstrapContext} RenderBootstrapContext} */
+/** @typedef {import("./javascript/JavascriptModulesPlugin").ChunkHashContext} ChunkHashContext} */
 /** @typedef {import("./RuntimeTemplate")} RuntimeTemplate} */
 /** @typedef {import("./ModuleGraph")} ModuleGraph} */
 /** @typedef {import("./ChunkGraph")} ChunkGraph} */
 /** @typedef {import("./Template").RenderManifestOptions} RenderManifestOptions} */
 /** @typedef {import("./Template").RenderManifestEntry} RenderManifestEntry} */
+/** @typedef {import("./TemplatedPathPlugin").TemplatePath} TemplatePath} */
+/** @typedef {import("./TemplatedPathPlugin").PathData} PathData} */
+/**
+ * @template T
+ * @typedef {import("tapable").IfSet<T>} IfSet
+ */
 
 const getJavascriptModulesPlugin = memoize(() =>
 	require("./javascript/JavascriptModulesPlugin")
@@ -40,7 +50,6 @@ const getLoadScriptRuntimeModule = memoize(() =>
 // TODO webpack 6 remove this class
 class MainTemplate {
 	/**
-	 *
 	 * @param {OutputOptions} outputOptions output options for the MainTemplate
 	 * @param {Compilation} compilation the compilation
 	 */
@@ -50,6 +59,11 @@ class MainTemplate {
 		this.hooks = Object.freeze({
 			renderManifest: {
 				tap: util.deprecate(
+					/**
+					 * @template AdditionalOptions
+					 * @param {string | Tap & IfSet<AdditionalOptions>} options options
+					 * @param {function(RenderManifestEntry[], RenderManifestOptions): RenderManifestEntry[]} fn fn
+					 */
 					(options, fn) => {
 						compilation.hooks.renderManifest.tap(
 							options,
@@ -79,6 +93,11 @@ class MainTemplate {
 			},
 			require: {
 				tap: util.deprecate(
+					/**
+					 * @template AdditionalOptions
+					 * @param {string | Tap & IfSet<AdditionalOptions>} options options
+					 * @param {function(string, RenderBootstrapContext): string} fn fn
+					 */
 					(options, fn) => {
 						getJavascriptModulesPlugin()
 							.getCompilationHooks(compilation)
@@ -111,6 +130,11 @@ class MainTemplate {
 			},
 			render: {
 				tap: util.deprecate(
+					/**
+					 * @template AdditionalOptions
+					 * @param {string | Tap & IfSet<AdditionalOptions>} options options
+					 * @param {function(Source, Chunk, string | undefined, ModuleTemplate, DependencyTemplates): Source} fn fn
+					 */
 					(options, fn) => {
 						getJavascriptModulesPlugin()
 							.getCompilationHooks(compilation)
@@ -138,6 +162,11 @@ class MainTemplate {
 			},
 			renderWithEntry: {
 				tap: util.deprecate(
+					/**
+					 * @template AdditionalOptions
+					 * @param {string | Tap & IfSet<AdditionalOptions>} options options
+					 * @param {function(Source, Chunk, string | undefined): Source} fn fn
+					 */
 					(options, fn) => {
 						getJavascriptModulesPlugin()
 							.getCompilationHooks(compilation)
@@ -159,6 +188,11 @@ class MainTemplate {
 			},
 			assetPath: {
 				tap: util.deprecate(
+					/**
+					 * @template AdditionalOptions
+					 * @param {string | Tap & IfSet<AdditionalOptions>} options options
+					 * @param {function(string, object, AssetInfo | undefined): string} fn fn
+					 */
 					(options, fn) => {
 						compilation.hooks.assetPath.tap(options, fn);
 					},
@@ -166,15 +200,23 @@ class MainTemplate {
 					"DEP_WEBPACK_MAIN_TEMPLATE_ASSET_PATH"
 				),
 				call: util.deprecate(
-					(filename, options) => {
-						return compilation.getAssetPath(filename, options);
-					},
+					/**
+					 * @param {TemplatePath} filename used to get asset path with hash
+					 * @param {PathData} options context data
+					 * @returns {string} interpolated path
+					 */
+					(filename, options) => compilation.getAssetPath(filename, options),
 					"MainTemplate.hooks.assetPath is deprecated (use Compilation.hooks.assetPath instead)",
 					"DEP_WEBPACK_MAIN_TEMPLATE_ASSET_PATH"
 				)
 			},
 			hash: {
 				tap: util.deprecate(
+					/**
+					 * @template AdditionalOptions
+					 * @param {string | Tap & IfSet<AdditionalOptions>} options options
+					 * @param {function(Hash): void} fn fn
+					 */
 					(options, fn) => {
 						compilation.hooks.fullHash.tap(options, fn);
 					},
@@ -184,6 +226,11 @@ class MainTemplate {
 			},
 			hashForChunk: {
 				tap: util.deprecate(
+					/**
+					 * @template AdditionalOptions
+					 * @param {string | Tap & IfSet<AdditionalOptions>} options options
+					 * @param {function(Hash, Chunk): void} fn fn
+					 */
 					(options, fn) => {
 						getJavascriptModulesPlugin()
 							.getCompilationHooks(compilation)
@@ -259,7 +306,8 @@ class MainTemplate {
 			 * @param {string} hash the hash
 			 * @param {number=} length length of the hash
 			 * @returns {string} generated code
-			 */ (hash, length) => {
+			 */
+			(hash, length) => {
 				if (length) {
 					return `${RuntimeGlobals.getFullHash} ? ${
 						RuntimeGlobals.getFullHash
@@ -273,31 +321,36 @@ class MainTemplate {
 
 		this.getPublicPath = util.deprecate(
 			/**
-			 *
-			 * @param {object} options get public path options
-			 * @returns {string} hook call
-			 */ options => {
-				return compilation.getAssetPath(
-					compilation.outputOptions.publicPath,
+			 * @param {PathData} options context data
+			 * @returns {string} interpolated path
+			 */ options =>
+				compilation.getAssetPath(
+					/** @type {string} */
+					(compilation.outputOptions.publicPath),
 					options
-				);
-			},
+				),
 			"MainTemplate.getPublicPath is deprecated (use Compilation.getAssetPath(compilation.outputOptions.publicPath, options) instead)",
 			"DEP_WEBPACK_MAIN_TEMPLATE_GET_PUBLIC_PATH"
 		);
 
 		this.getAssetPath = util.deprecate(
-			(path, options) => {
-				return compilation.getAssetPath(path, options);
-			},
+			/**
+			 * @param {TemplatePath} path used to get asset path with hash
+			 * @param {PathData} options context data
+			 * @returns {string} interpolated path
+			 */
+			(path, options) => compilation.getAssetPath(path, options),
 			"MainTemplate.getAssetPath is deprecated (use Compilation.getAssetPath instead)",
 			"DEP_WEBPACK_MAIN_TEMPLATE_GET_ASSET_PATH"
 		);
 
 		this.getAssetPathWithInfo = util.deprecate(
-			(path, options) => {
-				return compilation.getAssetPathWithInfo(path, options);
-			},
+			/**
+			 * @param {TemplatePath} path used to get asset path with hash
+			 * @param {PathData} options context data
+			 * @returns {InterpolatedPathAndAssetInfo} interpolated path and asset info
+			 */
+			(path, options) => compilation.getAssetPathWithInfo(path, options),
 			"MainTemplate.getAssetPathWithInfo is deprecated (use Compilation.getAssetPath instead)",
 			"DEP_WEBPACK_MAIN_TEMPLATE_GET_ASSET_PATH_WITH_INFO"
 		);

package/lib/Module.js

@@ -18,10 +18,12 @@ const makeSerializable = require("./util/makeSerializable");
 /** @typedef {import("../declarations/WebpackOptions").ResolveOptions} ResolveOptions */
 /** @typedef {import("../declarations/WebpackOptions").WebpackOptionsNormalized} WebpackOptions */
 /** @typedef {import("./Chunk")} Chunk */
+/** @typedef {import("./ChunkGraph").ModuleId} ModuleId */
 /** @typedef {import("./ChunkGroup")} ChunkGroup */
 /** @typedef {import("./CodeGenerationResults")} CodeGenerationResults */
 /** @typedef {import("./Compilation")} Compilation */
 /** @typedef {import("./Compilation").AssetInfo} AssetInfo */
+/** @typedef {import("./Compilation").ValueCacheVersion} ValueCacheVersion */
 /** @typedef {import("./ConcatenationScope")} ConcatenationScope */
 /** @typedef {import("./Dependency")} Dependency */
 /** @typedef {import("./Dependency").UpdateHashContext} UpdateHashContext */
@@ -81,7 +83,7 @@ const makeSerializable = require("./util/makeSerializable");
  * @typedef {object} CodeGenerationResult
  * @property {Map<string, Source>} sources the resulting sources for all source types
  * @property {Map<string, any>=} data the resulting data for all source types
- * @property {ReadOnlyRuntimeRequirements} runtimeRequirements the runtime requirements
+ * @property {ReadOnlyRuntimeRequirements | null} runtimeRequirements the runtime requirements
  * @property {string=} hash a hash of the code generation result (will be automatically calculated from sources and runtimeRequirements if not provided)
  */
 
@@ -112,7 +114,7 @@ const makeSerializable = require("./util/makeSerializable");
  * @property {LazySet<string>=} contextDependencies
  * @property {LazySet<string>=} missingDependencies
  * @property {LazySet<string>=} buildDependencies
- * @property {(Map<string, string | Set<string>>)=} valueDependencies
+ * @property {(Map<string, ValueCacheVersion>)=} valueDependencies
  * @property {TODO=} hash
  * @property {Record<string, Source>=} assets
  * @property {Map<string, AssetInfo | undefined>=} assetsInfo
@@ -151,12 +153,11 @@ const deprecatedNeedRebuild = util.deprecate(
 	 * @param {NeedBuildContext} context context info
 	 * @returns {boolean} true, when rebuild is needed
 	 */
-	(module, context) => {
-		return module.needRebuild(
+	(module, context) =>
+		module.needRebuild(
 			context.fileSystemInfo.getDeprecatedFileTimestamps(),
 			context.fileSystemInfo.getDeprecatedContextTimestamps()
-		);
-	},
+		),
 	"Module.needRebuild is deprecated in favor of Module.needBuild",
 	"DEP_WEBPACK_MODULE_NEED_REBUILD"
 );
@@ -214,6 +215,9 @@ class Module extends DependenciesBlock {
 
 	// TODO remove in webpack 6
 	// BACKWARD-COMPAT START
+	/**
+	 * @returns {ModuleId | null} module id
+	 */
 	get id() {
 		return ChunkGraph.getChunkGraphForModule(
 			this,
@@ -222,6 +226,9 @@ class Module extends DependenciesBlock {
 		).getModuleId(this);
 	}
 
+	/**
+	 * @param {ModuleId} value value
+	 */
 	set id(value) {
 		if (value === "") {
 			this.needId = false;
@@ -865,9 +872,8 @@ class Module extends DependenciesBlock {
 		// Better override this method to return the correct types
 		if (this.source === Module.prototype.source) {
 			return DEFAULT_TYPES_UNKNOWN;
-		} else {
-			return DEFAULT_TYPES_JS;
 		}
+		return DEFAULT_TYPES_JS;
 	}
 
 	/**
@@ -899,7 +905,11 @@ class Module extends DependenciesBlock {
 		};
 		const sources = this.codeGeneration(codeGenContext).sources;
 
-		return type ? sources.get(type) : sources.get(first(this.getSourceTypes()));
+		return /** @type {Source} */ (
+			type
+				? sources.get(type)
+				: sources.get(/** @type {string} */ (first(this.getSourceTypes())))
+		);
 	}
 
 	/* istanbul ignore next */
@@ -1105,6 +1115,8 @@ class Module extends DependenciesBlock {
 makeSerializable(Module, "webpack/lib/Module");
 
 // TODO remove in webpack 6
+// eslint-disable-next-line no-warning-comments
+// @ts-ignore https://github.com/microsoft/TypeScript/issues/42919
 Object.defineProperty(Module.prototype, "hasEqualsChunks", {
 	get() {
 		throw new Error(
@@ -1114,6 +1126,8 @@ Object.defineProperty(Module.prototype, "hasEqualsChunks", {
 });
 
 // TODO remove in webpack 6
+// eslint-disable-next-line no-warning-comments
+// @ts-ignore https://github.com/microsoft/TypeScript/issues/42919
 Object.defineProperty(Module.prototype, "isUsed", {
 	get() {
 		throw new Error(
@@ -1159,6 +1173,8 @@ Object.defineProperty(Module.prototype, "warnings", {
 });
 
 // TODO remove in webpack 6
+// eslint-disable-next-line no-warning-comments
+// @ts-ignore https://github.com/microsoft/TypeScript/issues/42919
 Object.defineProperty(Module.prototype, "used", {
 	get() {
 		throw new Error(

package/lib/ModuleBuildError.js

@@ -19,13 +19,9 @@ class ModuleBuildError extends WebpackError {
 	 */
 	constructor(err, { from = null } = {}) {
 		let message = "Module build failed";
-		let details = undefined;
+		let details;
 
-		if (from) {
-			message += ` (from ${from}):\n`;
-		} else {
-			message += ": ";
-		}
+		message += from ? ` (from ${from}):\n` : ": ";
 
 		if (err !== null && typeof err === "object") {
 			if (typeof err.stack === "string" && err.stack) {
@@ -36,11 +32,8 @@ class ModuleBuildError extends WebpackError {
 				} else {
 					details = stack;
 
-					if (typeof err.message === "string" && err.message) {
-						message += err.message;
-					} else {
-						message += err;
-					}
+					message +=
+						typeof err.message === "string" && err.message ? err.message : err;
 				}
 			} else if (typeof err.message === "string" && err.message) {
 				message += err.message;

package/lib/ModuleDependencyError.js

@@ -30,11 +30,11 @@ class ModuleDependencyError extends WebpackError {
 		/** error is not (de)serialized, so it might be undefined after deserialization */
 		this.error = err;
 
-		if (err && /** @type {any} */ (err).hideStack) {
-			this.stack =
-				/** @type {string} */ (err.stack).split("\n").slice(1).join("\n") +
-				"\n\n" +
-				this.stack;
+		if (err && /** @type {any} */ (err).hideStack && err.stack) {
+			this.stack = /** @type {string} */ `${err.stack
+				.split("\n")
+				.slice(1)
+				.join("\n")}\n\n${this.stack}`;
 		}
 	}
 }

package/lib/ModuleDependencyWarning.js

@@ -30,11 +30,11 @@ class ModuleDependencyWarning extends WebpackError {
 		/** error is not (de)serialized, so it might be undefined after deserialization */
 		this.error = err;
 
-		if (err && /** @type {any} */ (err).hideStack) {
-			this.stack =
-				/** @type {string} */ (err.stack).split("\n").slice(1).join("\n") +
-				"\n\n" +
-				this.stack;
+		if (err && /** @type {any} */ (err).hideStack && err.stack) {
+			this.stack = /** @type {string} */ `${err.stack
+				.split("\n")
+				.slice(1)
+				.join("\n")}\n\n${this.stack}`;
 		}
 	}
 }

package/lib/ModuleError.js

@@ -20,11 +20,7 @@ class ModuleError extends WebpackError {
 	constructor(err, { from = null } = {}) {
 		let message = "Module Error";
 
-		if (from) {
-			message += ` (from ${from}):\n`;
-		} else {
-			message += ": ";
-		}
+		message += from ? ` (from ${from}):\n` : ": ";
 
 		if (err && typeof err === "object" && err.message) {
 			message += err.message;

package/lib/ModuleFilenameHelpers.js

@@ -17,7 +17,7 @@ const memoize = require("./util/memoize");
 /** @typedef {string | RegExp | (string | RegExp)[]} Matcher */
 /** @typedef {{test?: Matcher, include?: Matcher, exclude?: Matcher }} MatchObject */
 
-const ModuleFilenameHelpers = exports;
+const ModuleFilenameHelpers = module.exports;
 
 // TODO webpack 6: consider removing these
 ModuleFilenameHelpers.ALL_LOADERS_RESOURCE = "[all-loaders][resource]";
@@ -54,12 +54,10 @@ ModuleFilenameHelpers.REGEXP_NAMESPACE = /\[namespace\]/gi;
  * @param {string} token the token to search for
  * @returns {ReturnStringCallback} a function that returns the part of the string after the token
  */
-const getAfter = (strFn, token) => {
-	return () => {
-		const str = strFn();
-		const idx = str.indexOf(token);
-		return idx < 0 ? "" : str.slice(idx);
-	};
+const getAfter = (strFn, token) => () => {
+	const str = strFn();
+	const idx = str.indexOf(token);
+	return idx < 0 ? "" : str.slice(idx);
 };
 
 /**
@@ -68,12 +66,10 @@ const getAfter = (strFn, token) => {
  * @param {string} token the token to search for
  * @returns {ReturnStringCallback} a function that returns the part of the string before the token
  */
-const getBefore = (strFn, token) => {
-	return () => {
-		const str = strFn();
-		const idx = str.lastIndexOf(token);
-		return idx < 0 ? "" : str.slice(0, idx);
-	};
+const getBefore = (strFn, token) => () => {
+	const str = strFn();
+	const idx = str.lastIndexOf(token);
+	return idx < 0 ? "" : str.slice(0, idx);
 };
 
 /**
@@ -82,14 +78,14 @@ const getBefore = (strFn, token) => {
  * @param {string | Hash=} hashFunction the hash function to use
  * @returns {ReturnStringCallback} a function that returns the hash of the string
  */
-const getHash = (strFn, hashFunction = "md4") => {
-	return () => {
+const getHash =
+	(strFn, hashFunction = "md4") =>
+	() => {
 		const hash = createHash(hashFunction);
 		hash.update(strFn());
 		const digest = /** @type {string} */ (hash.digest("hex"));
 		return digest.slice(0, 4);
 	};
-};
 
 /**
  * Returns a function that returns the string with the token replaced with the replacement
@@ -108,7 +104,7 @@ const asRegExp = test => {
 	if (typeof test === "string") {
 		// Escape special characters in the string to prevent them from being interpreted as special characters in a regular expression. Do this by
 		// adding a backslash before each special character
-		test = new RegExp("^" + test.replace(/[-[\]{}()*+?.,\\^$|#\s]/g, "\\$&"));
+		test = new RegExp(`^${test.replace(/[-[\]{}()*+?.,\\^$|#\s]/g, "\\$&")}`);
 	}
 	return test;
 };
@@ -143,7 +139,6 @@ const lazyObject = obj => {
 const SQUARE_BRACKET_TAG_REGEXP = /\[\\*([\w-]+)\\*\]/gi;
 
 /**
- *
  * @param {Module | string} module the module
  * @param {TODO} options options
  * @param {object} contextInfo context info
@@ -153,6 +148,7 @@ const SQUARE_BRACKET_TAG_REGEXP = /\[\\*([\w-]+)\\*\]/gi;
  * @returns {string} the filename
  */
 ModuleFilenameHelpers.createFilename = (
+	// eslint-disable-next-line default-param-last
 	module = "",
 	options,
 	{ requestShortener, chunkGraph, hashFunction = "md4" }
@@ -213,9 +209,9 @@ ModuleFilenameHelpers.createFilename = (
 	if (typeof opts.moduleFilenameTemplate === "function") {
 		return opts.moduleFilenameTemplate(
 			lazyObject({
-				identifier: identifier,
-				shortIdentifier: shortIdentifier,
-				resource: resource,
+				identifier,
+				shortIdentifier,
+				resource,
 				resourcePath: memoize(resourcePath),
 				absoluteResourcePath: memoize(absoluteResourcePath),
 				loaders: memoize(loaders),
@@ -285,13 +281,11 @@ ModuleFilenameHelpers.createFilename = (
  * Replaces duplicate items in an array with new values generated by a callback function.
  * The callback function is called with the duplicate item, the index of the duplicate item, and the number of times the item has been replaced.
  * The callback function should return the new value for the duplicate item.
- *
  * @template T
  * @param {T[]} array the array with duplicates to be replaced
  * @param {(duplicateItem: T, duplicateItemIndex: number, numberOfTimesReplaced: number) => T} fn callback function to generate new values for the duplicate items
  * @param {(firstElement:T, nextElement:T) => -1 | 0 | 1} [comparator] optional comparator function to sort the duplicate items
  * @returns {T[]} the array with duplicates replaced
- *
  * @example
  * ```js
  * const array = ["a", "b", "c", "a", "b", "a"];
@@ -303,33 +297,30 @@ ModuleFilenameHelpers.replaceDuplicates = (array, fn, comparator) => {
 	const countMap = Object.create(null);
 	const posMap = Object.create(null);
 
-	array.forEach((item, idx) => {
+	for (const [idx, item] of array.entries()) {
 		countMap[item] = countMap[item] || [];
 		countMap[item].push(idx);
 		posMap[item] = 0;
-	});
+	}
 	if (comparator) {
-		Object.keys(countMap).forEach(item => {
+		for (const item of Object.keys(countMap)) {
 			countMap[item].sort(comparator);
-		});
+		}
 	}
 	return array.map((item, i) => {
 		if (countMap[item].length > 1) {
 			if (comparator && countMap[item][0] === i) return item;
 			return fn(item, i, posMap[item]++);
-		} else {
-			return item;
 		}
+		return item;
 	});
 };
 
 /**
  * Tests if a string matches a RegExp or an array of RegExp.
- *
  * @param {string} str string to test
  * @param {Matcher} test value which will be used to match against the string
  * @returns {boolean} true, when the RegExp matches
- *
  * @example
  * ```js
  * ModuleFilenameHelpers.matchPart("foo.js", "foo"); // true
@@ -349,9 +340,8 @@ ModuleFilenameHelpers.matchPart = (str, test) => {
 
 	if (Array.isArray(test)) {
 		return test.map(asRegExp).some(regExp => regExp.test(str));
-	} else {
-		return asRegExp(test).test(str);
 	}
+	return asRegExp(test).test(str);
 };
 
 /**
@@ -361,7 +351,6 @@ ModuleFilenameHelpers.matchPart = (str, test) => {
  * - `exclude`: a RegExp or an array of RegExp
  *
  * The `test` property is tested first, then `include` and then `exclude`.
- *
  * @param {MatchObject} obj a match object to test against the string
  * @param {string} str string to test against the matching object
  * @returns {boolean} true, when the object matches
@@ -381,20 +370,14 @@ ModuleFilenameHelpers.matchPart = (str, test) => {
  * ```
  */
 ModuleFilenameHelpers.matchObject = (obj, str) => {
-	if (obj.test) {
-		if (!ModuleFilenameHelpers.matchPart(str, obj.test)) {
-			return false;
-		}
+	if (obj.test && !ModuleFilenameHelpers.matchPart(str, obj.test)) {
+		return false;
 	}
-	if (obj.include) {
-		if (!ModuleFilenameHelpers.matchPart(str, obj.include)) {
-			return false;
-		}
+	if (obj.include && !ModuleFilenameHelpers.matchPart(str, obj.include)) {
+		return false;
 	}
-	if (obj.exclude) {
-		if (ModuleFilenameHelpers.matchPart(str, obj.exclude)) {
-			return false;
-		}
+	if (obj.exclude && ModuleFilenameHelpers.matchPart(str, obj.exclude)) {
+		return false;
 	}
 	return true;
 };

package/lib/ModuleGraph.js

@@ -36,7 +36,7 @@ const getConnectionsByOriginModule = set => {
 	/** @type {Module | 0} */
 	let lastModule = 0;
 	/** @type {ModuleGraphConnection[] | undefined} */
-	let lastList = undefined;
+	let lastList;
 	for (const connection of set) {
 		const { originModule } = connection;
 		if (lastModule === originModule) {
@@ -67,7 +67,7 @@ const getConnectionsByModule = set => {
 	/** @type {Module | 0} */
 	let lastModule = 0;
 	/** @type {ModuleGraphConnection[] | undefined} */
-	let lastList = undefined;
+	let lastList;
 	for (const connection of set) {
 		const { module } = connection;
 		if (lastModule === module) {
@@ -445,7 +445,7 @@ class ModuleGraph {
 				}
 			}
 			this._dependencyMap.set(dependency, null);
-			return undefined;
+			return;
 		}
 		return connection === null ? undefined : connection;
 	}
@@ -851,12 +851,13 @@ class ModuleGraph {
 				const moduleGraph = moduleGraphForModuleMap.get(module);
 				if (!moduleGraph)
 					throw new Error(
-						deprecateMessage +
-							"There was no ModuleGraph assigned to the Module for backward-compat (Use the new API)"
+						`${
+							deprecateMessage
+						}There was no ModuleGraph assigned to the Module for backward-compat (Use the new API)`
 					);
 				return moduleGraph;
 			},
-			deprecateMessage + ": Use new ModuleGraph API",
+			`${deprecateMessage}: Use new ModuleGraph API`,
 			deprecationCode
 		);
 		deprecateMap.set(deprecateMessage, newFn);

package/lib/ModuleGraphConnection.js

@@ -73,7 +73,7 @@ class ModuleGraphConnection {
 		this.resolvedModule = module;
 		this.module = module;
 		this.weak = weak;
-		this.conditional = !!condition;
+		this.conditional = Boolean(condition);
 		this._active = condition !== false;
 		/** @type {(function(ModuleGraphConnection, RuntimeSpec): ConnectionState) | undefined} */
 		this.condition = condition || undefined;
@@ -135,11 +135,6 @@ class ModuleGraphConnection {
 		return Array.from(this.explanations).join(" ");
 	}
 
-	// TODO webpack 5 remove
-	get active() {
-		throw new Error("Use getActiveState instead");
-	}
-
 	/**
 	 * @param {RuntimeSpec} runtime the runtime
 	 * @returns {boolean} true, if the connection is active
@@ -187,6 +182,11 @@ class ModuleGraphConnection {
 		this._active = value;
 	}
 
+	// TODO webpack 5 remove
+	get active() {
+		throw new Error("Use getActiveState instead");
+	}
+
 	set active(value) {
 		throw new Error("Use setActive instead");
 	}