webpack 5.93.0 → 5.94.0

package/README.md

@@ -8,9 +8,10 @@
 [![npm][npm]][npm-url]
 
 [![node][node]][node-url]
+[![builds1][builds1]][builds1-url]
 [![builds2][builds2]][builds2-url]
+[![dependency-review][dependency-review]][dependency-review-url]
 [![coverage][cover]][cover-url]
-[![licenses][licenses]][licenses-url]
 [![PR's welcome][prs]][prs-url]
 
   <br>
@@ -716,9 +717,11 @@ src="https://static.monei.net/monei-logo.svg" height="30" alt="MONEI"></a>
 [node-url]: https://nodejs.org
 [prs]: https://img.shields.io/badge/PRs-welcome-brightgreen.svg
 [prs-url]: https://webpack.js.org/contribute/
-[builds2]: https://dev.azure.com/webpack/webpack/_apis/build/status/webpack.webpack
-[builds2-url]: https://dev.azure.com/webpack/webpack/_build/latest?definitionId=3
-[licenses-url]: https://app.fossa.io/projects/git%2Bhttps%3A%2F%2Fgithub.com%2Fwebpack%2Fwebpack?ref=badge_shield
-[licenses]: https://app.fossa.io/api/projects/git%2Bhttps%3A%2F%2Fgithub.com%2Fwebpack%2Fwebpack.svg?type=shield
+[builds1]: https://github.com/webpack/webpack/actions/workflows/test.yml/badge.svg
+[builds1-url]: https://github.com/webpack/webpack/actions/workflows/test.yml
+[builds2]: https://dev.azure.com/webpack/webpack/_apis/build/status%2Fwebpack.webpack?branchName=main
+[builds2-url]: https://dev.azure.com/webpack/webpack/_build/latest?definitionId=3&branchName=main
+[dependency-review-url]: https://github.com/webpack/webpack/actions/workflows/dependency-review.yml
+[dependency-review]: https://github.com/webpack/webpack/actions/workflows/dependency-review.yml/badge.svg
 [cover]: https://codecov.io/gh/webpack/webpack/branch/master/graph/badge.svg?token=mDP3mQJNnn
 [cover-url]: https://codecov.io/gh/webpack/webpack

package/bin/webpack.js

@@ -80,8 +80,8 @@ const runCli = cli => {
 
 	if (pkg.type === "module" || /\.mjs/i.test(pkg.bin[cli.binName])) {
 		import(path.resolve(path.dirname(pkgPath), pkg.bin[cli.binName])).catch(
-			error => {
-				console.error(error);
+			err => {
+				console.error(err);
 				process.exitCode = 1;
 			}
 		);
@@ -113,8 +113,7 @@ if (!cli.installed) {
 	const fs = require("graceful-fs");
 	const readLine = require("readline");
 
-	const notify =
-		"CLI for webpack must be installed.\n" + `  ${cli.name} (${cli.url})\n`;
+	const notify = `CLI for webpack must be installed.\n  ${cli.name} (${cli.url})\n`;
 
 	console.error(notify);
 
@@ -137,7 +136,7 @@ if (!cli.installed) {
 		)} ${cli.package}".`
 	);
 
-	const question = `Do you want to install 'webpack-cli' (yes/no): `;
+	const question = "Do you want to install 'webpack-cli' (yes/no): ";
 
 	const questionInterface = readLine.createInterface({
 		input: process.stdin,
@@ -178,8 +177,8 @@ if (!cli.installed) {
 			.then(() => {
 				runCli(cli);
 			})
-			.catch(error => {
-				console.error(error);
+			.catch(err => {
+				console.error(err);
 				process.exitCode = 1;
 			});
 	});

package/hot/log.js

@@ -73,7 +73,6 @@ module.exports.formatError = function (err) {
 		return message;
 	} else if (stack.indexOf(message) < 0) {
 		return message + "\n" + stack;
-	} else {
-		return stack;
 	}
+	return stack;
 };

package/hot/only-dev-server.js

@@ -2,7 +2,7 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
-/*globals __webpack_hash__ */
+/* globals __webpack_hash__ */
 if (module.hot) {
 	/** @type {undefined|string} */
 	var lastHash;

package/hot/poll.js

@@ -2,7 +2,7 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
-/*globals __resourceQuery */
+/* globals __resourceQuery */
 if (module.hot) {
 	var hotPollInterval = +__resourceQuery.slice(1) || 10 * 60 * 1000;
 	var log = require("./log");

package/hot/signal.js

@@ -2,7 +2,7 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
-/*globals __resourceQuery */
+/* globals __resourceQuery */
 if (module.hot) {
 	var log = require("./log");
 

package/lib/APIPlugin.js

@@ -144,6 +144,7 @@ class APIPlugin {
 	constructor(options = {}) {
 		this.options = options;
 	}
+
 	/**
 	 * Apply the plugin
 	 * @param {Compiler} compiler the compiler instance
@@ -213,7 +214,7 @@ class APIPlugin {
 				 * @param {JavascriptParser} parser the parser
 				 */
 				const handler = parser => {
-					Object.keys(REPLACEMENTS).forEach(key => {
+					for (const key of Object.keys(REPLACEMENTS)) {
 						const info = REPLACEMENTS[key];
 						parser.hooks.expression.for(key).tap(PLUGIN_NAME, expression => {
 							const dep = toConstantDependency(parser, info.expr, info.req);
@@ -237,7 +238,7 @@ class APIPlugin {
 								.for(key)
 								.tap(PLUGIN_NAME, evaluateToString(info.type));
 						}
-					});
+					}
 
 					parser.hooks.expression
 						.for("__webpack_layer__")
@@ -277,7 +278,7 @@ class APIPlugin {
 							(parser.state.module.buildInfo).moduleConcatenationBailout =
 								"__webpack_module__.id";
 							const dep = new ConstDependency(
-								parser.state.module.moduleArgument + ".id",
+								`${parser.state.module.moduleArgument}.id`,
 								/** @type {Range} */ (expr.range),
 								[RuntimeGlobals.moduleId]
 							);

package/lib/AbstractMethodError.js

@@ -13,18 +13,22 @@ const CURRENT_METHOD_REGEXP = /at ([a-zA-Z0-9_.]*)/;
  * @returns {string} message
  */
 function createMessage(method) {
-	return `Abstract method${method ? " " + method : ""}. Must be overridden.`;
+	return `Abstract method${method ? ` ${method}` : ""}. Must be overridden.`;
 }
 
 /**
  * @constructor
  */
 function Message() {
-	/** @type {string} */
+	/** @type {string | undefined} */
 	this.stack = undefined;
 	Error.captureStackTrace(this);
-	/** @type {RegExpMatchArray} */
-	const match = this.stack.split("\n")[3].match(CURRENT_METHOD_REGEXP);
+	/** @type {RegExpMatchArray | null} */
+	const match =
+		/** @type {string} */
+		(/** @type {unknown} */ (this.stack))
+			.split("\n")[3]
+			.match(CURRENT_METHOD_REGEXP);
 
 	this.message = match && match[1] ? createMessage(match[1]) : createMessage();
 }
@@ -32,12 +36,13 @@ function Message() {
 /**
  * Error for abstract method
  * @example
+ * ```js
  * class FooClass {
  *     abstractMethod() {
  *         throw new AbstractMethodError(); // error message: Abstract method FooClass.abstractMethod. Must be overridden.
  *     }
  * }
- *
+ * ```
  */
 class AbstractMethodError extends WebpackError {
 	constructor() {

package/lib/AutomaticPrefetchPlugin.js

@@ -45,7 +45,7 @@ class AutomaticPrefetchPlugin {
 			"AutomaticPrefetchPlugin",
 			(compilation, callback) => {
 				if (!lastModules) return callback();
-				asyncLib.forEach(
+				asyncLib.each(
 					lastModules,
 					(m, callback) => {
 						compilation.addModuleChain(

package/lib/BannerPlugin.js

@@ -14,7 +14,9 @@ const createSchemaValidation = require("./util/create-schema-validation");
 /** @typedef {import("../declarations/plugins/BannerPlugin").BannerFunction} BannerFunction */
 /** @typedef {import("../declarations/plugins/BannerPlugin").BannerPluginArgument} BannerPluginArgument */
 /** @typedef {import("../declarations/plugins/BannerPlugin").BannerPluginOptions} BannerPluginOptions */
+/** @typedef {import("./Compilation").PathData} PathData */
 /** @typedef {import("./Compiler")} Compiler */
+/** @typedef {import("./TemplatedPathPlugin").TemplatePath} TemplatePath */
 
 const validate = createSchemaValidation(
 	require("../schemas/plugins/BannerPlugin.check.js"),
@@ -59,6 +61,7 @@ class BannerPlugin {
 		const bannerOption = options.banner;
 		if (typeof bannerOption === "function") {
 			const getBanner = bannerOption;
+			/** @type {BannerFunction} */
 			this.banner = this.options.raw
 				? getBanner
 				: /** @type {BannerFunction} */ data => wrapComment(getBanner(data));
@@ -66,6 +69,7 @@ class BannerPlugin {
 			const banner = this.options.raw
 				? bannerOption
 				: wrapComment(bannerOption);
+			/** @type {BannerFunction} */
 			this.banner = () => banner;
 		}
 	}
@@ -103,15 +107,17 @@ class BannerPlugin {
 								continue;
 							}
 
-							const data = {
-								chunk,
-								filename: file
-							};
+							/** @type {PathData} */
+							const data = { chunk, filename: file };
 
-							const comment = compilation.getPath(banner, data);
+							const comment = compilation.getPath(
+								/** @type {TemplatePath} */
+								(banner),
+								data
+							);
 
 							compilation.updateAsset(file, old => {
-								let cached = cache.get(old);
+								const cached = cache.get(old);
 								if (!cached || cached.comment !== comment) {
 									const source = options.footer
 										? new ConcatSource(old, "\n", comment)

package/lib/Cache.js

@@ -38,16 +38,14 @@ const {
  * @param {function(Error=): void} callback callback
  * @returns {function(Error=): void} callback
  */
-const needCalls = (times, callback) => {
-	return err => {
-		if (--times === 0) {
-			return callback(err);
-		}
-		if (err && times > 0) {
-			times = 0;
-			return callback(err);
-		}
-	};
+const needCalls = (times, callback) => err => {
+	if (--times === 0) {
+		return callback(err);
+	}
+	if (err && times > 0) {
+		times = 0;
+		return callback(err);
+	}
 };
 
 class Cache {

package/lib/CacheFacade.js

@@ -38,6 +38,7 @@ class MultiItemCache {
 	 */
 	constructor(items) {
 		this._items = items;
+		// eslint-disable-next-line no-constructor-return
 		if (items.length === 1) return /** @type {any} */ (items[0]);
 	}
 
@@ -59,12 +60,11 @@ class MultiItemCache {
 		 * @param {number} i index
 		 * @returns {Promise<T>} promise with the data
 		 */
-		const next = i => {
-			return this._items[i].getPromise().then(result => {
+		const next = i =>
+			this._items[i].getPromise().then(result => {
 				if (result !== undefined) return result;
 				if (++i < this._items.length) return next(i);
 			});
-		};
 		return next(0);
 	}
 

package/lib/CaseSensitiveModulesWarning.js

@@ -14,8 +14,8 @@ const WebpackError = require("./WebpackError");
  * @param {Module[]} modules the modules to be sorted
  * @returns {Module[]} sorted version of original modules
  */
-const sortModules = modules => {
-	return modules.sort((a, b) => {
+const sortModules = modules =>
+	modules.sort((a, b) => {
 		const aIdent = a.identifier();
 		const bIdent = b.identifier();
 		/* istanbul ignore next */
@@ -25,20 +25,19 @@ const sortModules = modules => {
 		/* istanbul ignore next */
 		return 0;
 	});
-};
 
 /**
  * @param {Module[]} modules each module from throw
  * @param {ModuleGraph} moduleGraph the module graph
  * @returns {string} each message from provided modules
  */
-const createModulesListMessage = (modules, moduleGraph) => {
-	return modules
+const createModulesListMessage = (modules, moduleGraph) =>
+	modules
 		.map(m => {
 			let message = `* ${m.identifier()}`;
 			const validReasons = Array.from(
 				moduleGraph.getIncomingConnectionsByOriginModule(m).keys()
-			).filter(x => x);
+			).filter(Boolean);
 
 			if (validReasons.length > 0) {
 				message += `\n    Used by ${validReasons.length} module(s), i. e.`;
@@ -49,7 +48,6 @@ const createModulesListMessage = (modules, moduleGraph) => {
 			return message;
 		})
 		.join("\n");
-};
 
 class CaseSensitiveModulesWarning extends WebpackError {
 	/**

package/lib/Chunk.js

@@ -22,14 +22,15 @@ const { mergeRuntime } = require("./util/runtime");
 /** @typedef {import("./ChunkGraph").ChunkFilterPredicate} ChunkFilterPredicate */
 /** @typedef {import("./ChunkGraph").ChunkSizeOptions} ChunkSizeOptions */
 /** @typedef {import("./ChunkGraph").ModuleFilterPredicate} ModuleFilterPredicate */
+/** @typedef {import("./ChunkGraph").ModuleId} ModuleId */
 /** @typedef {import("./ChunkGroup")} ChunkGroup */
 /** @typedef {import("./ChunkGroup").ChunkGroupOptions} ChunkGroupOptions */
 /** @typedef {import("./Compilation")} Compilation */
 /** @typedef {import("./Compilation").AssetInfo} AssetInfo */
-/** @typedef {import("./Compilation").PathData} PathData */
 /** @typedef {import("./Entrypoint").EntryOptions} EntryOptions */
 /** @typedef {import("./Module")} Module */
 /** @typedef {import("./ModuleGraph")} ModuleGraph */
+/** @typedef {import("./TemplatedPathPlugin").TemplatePath} TemplatePath */
 /** @typedef {import("./util/Hash")} Hash */
 /** @typedef {import("./util/runtime").RuntimeSpec} RuntimeSpec */
 
@@ -81,9 +82,9 @@ class Chunk {
 		this.idNameHints = new SortableSet();
 		/** @type {boolean} */
 		this.preventIntegration = false;
-		/** @type {(string | function(PathData, AssetInfo=): string) | undefined} */
+		/** @type {TemplatePath | undefined} */
 		this.filenameTemplate = undefined;
-		/** @type {(string | function(PathData, AssetInfo=): string) | undefined} */
+		/** @type {TemplatePath | undefined} */
 		this.cssFilenameTemplate = undefined;
 		/**
 		 * @private
@@ -124,11 +125,11 @@ class Chunk {
 			return undefined;
 		} else if (entryModules.length === 1) {
 			return entryModules[0];
-		} else {
-			throw new Error(
-				"Module.entryModule: Multiple entry modules are not supported by the deprecated API (Use the new ChunkGroup API)"
-			);
 		}
+
+		throw new Error(
+			"Module.entryModule: Multiple entry modules are not supported by the deprecated API (Use the new ChunkGroup API)"
+		);
 	}
 
 	/**
@@ -271,9 +272,9 @@ class Chunk {
 		if (chunkGraph.canChunksBeIntegrated(this, otherChunk)) {
 			chunkGraph.integrateChunks(this, otherChunk);
 			return true;
-		} else {
-			return false;
 		}
+
+		return false;
 	}
 
 	/**
@@ -367,7 +368,9 @@ class Chunk {
 						array = [];
 						chunkModuleIdMap[/** @type {ChunkId} */ (asyncChunk.id)] = array;
 					}
-					const moduleId = chunkGraph.getModuleId(module);
+					const moduleId =
+						/** @type {ModuleId} */
+						(chunkGraph.getModuleId(module));
 					array.push(moduleId);
 					chunkModuleHashMap[moduleId] = chunkGraph.getRenderedModuleHash(
 						module,
@@ -766,7 +769,7 @@ class Chunk {
 				});
 			}
 		}
-		if (list.length === 0) return undefined;
+		if (list.length === 0) return;
 		list.sort((a, b) => {
 			const cmp =
 				/** @type {number} */ (b.order) - /** @type {number} */ (a.order);