webpack 5.90.3 → 5.92.0

package/lib/dependencies/HarmonyExportImportedSpecifierDependency.js

@@ -24,19 +24,23 @@ const processExportInfo = require("./processExportInfo");
 /** @typedef {import("webpack-sources").ReplaceSource} ReplaceSource */
 /** @typedef {import("../ChunkGraph")} ChunkGraph */
 /** @typedef {import("../Dependency").ExportsSpec} ExportsSpec */
+/** @typedef {import("../Dependency").GetConditionFn} GetConditionFn */
 /** @typedef {import("../Dependency").ReferencedExport} ReferencedExport */
 /** @typedef {import("../Dependency").TRANSITIVE} TRANSITIVE */
 /** @typedef {import("../Dependency").UpdateHashContext} UpdateHashContext */
 /** @typedef {import("../DependencyTemplate").DependencyTemplateContext} DependencyTemplateContext */
 /** @typedef {import("../ExportsInfo")} ExportsInfo */
 /** @typedef {import("../ExportsInfo").ExportInfo} ExportInfo */
+/** @typedef {import("../Generator").GenerateContext} GenerateContext */
 /** @typedef {import("../Module")} Module */
+/** @typedef {import("../Module").BuildMeta} BuildMeta */
+/** @typedef {import("../Module").RuntimeRequirements} RuntimeRequirements */
 /** @typedef {import("../ModuleGraph")} ModuleGraph */
 /** @typedef {import("../ModuleGraphConnection")} ModuleGraphConnection */
 /** @typedef {import("../ModuleGraphConnection").ConnectionState} ConnectionState */
 /** @typedef {import("../RuntimeTemplate")} RuntimeTemplate */
 /** @typedef {import("../WebpackError")} WebpackError */
-/** @typedef {import("../javascript/JavascriptParser").Assertions} Assertions */
+/** @typedef {import("../javascript/JavascriptParser").ImportAttributes} ImportAttributes */
 /** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext} ObjectDeserializerContext */
 /** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext} ObjectSerializerContext */
 /** @typedef {import("../util/Hash")} Hash */
@@ -78,7 +82,7 @@ class ExportMode {
 		this.items = null;
 
 		// for "reexport-named-default" | "reexport-fake-namespace-object" | "reexport-namespace-object"
-		/** @type {string|null} */
+		/** @type {string | null} */
 		this.name = null;
 		/** @type {ExportInfo | null} */
 		this.partialNamespaceExportInfo = null;
@@ -176,7 +180,7 @@ const getMode = (moduleGraph, dep, runtimeKey) => {
 
 	const name = dep.name;
 	const runtime = keyToRuntime(runtimeKey);
-	const parentModule = moduleGraph.getParentModule(dep);
+	const parentModule = /** @type {Module} */ (moduleGraph.getParentModule(dep));
 	const exportsInfo = moduleGraph.getExportsInfo(parentModule);
 
 	if (
@@ -193,7 +197,7 @@ const getMode = (moduleGraph, dep, runtimeKey) => {
 
 	const importedExportsType = importedModule.getExportsType(
 		moduleGraph,
-		parentModule.buildMeta.strictHarmonyModule
+		/** @type {BuildMeta} */ (parentModule.buildMeta).strictHarmonyModule
 	);
 
 	const ids = dep.getIds(moduleGraph);
@@ -333,7 +337,7 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 	 * @param {ReadonlyArray<HarmonyExportImportedSpecifierDependency> | Iterable<HarmonyExportImportedSpecifierDependency> | null} otherStarExports other star exports in the module before this import
 	 * @param {number} exportPresenceMode mode of checking export names
 	 * @param {HarmonyStarExportsList | null} allStarExports all star exports in the module
-	 * @param {Assertions=} assertions import assertions
+	 * @param {ImportAttributes=} attributes import attributes
 	 */
 	constructor(
 		request,
@@ -344,9 +348,9 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 		otherStarExports,
 		exportPresenceMode,
 		allStarExports,
-		assertions
+		attributes
 	) {
-		super(request, sourceOrder, assertions);
+		super(request, sourceOrder, attributes);
 
 		this.ids = ids;
 		this.name = name;
@@ -422,11 +426,12 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 	getStarReexports(
 		moduleGraph,
 		runtime,
-		exportsInfo = moduleGraph.getExportsInfo(moduleGraph.getParentModule(this)),
-		importedModule = moduleGraph.getModule(this)
+		exportsInfo = moduleGraph.getExportsInfo(
+			/** @type {Module} */ (moduleGraph.getParentModule(this))
+		),
+		importedModule = /** @type {Module} */ (moduleGraph.getModule(this))
 	) {
 		const importedExportsInfo = moduleGraph.getExportsInfo(importedModule);
-
 		const noExtraExports =
 			importedExportsInfo.otherExportsInfo.provided === false;
 		const noExtraImports =
@@ -456,7 +461,7 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 		const exports = new Set();
 		/** @type {Set<string>} */
 		const checked = new Set();
-		/** @type {Set<string>} */
+		/** @type {Set<string> | undefined} */
 		const hidden = hiddenExports !== undefined ? new Set() : undefined;
 
 		if (noExtraImports) {
@@ -468,7 +473,8 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 					importedExportsInfo.getReadOnlyExportInfo(name);
 				if (importedExportInfo.provided === false) continue;
 				if (hiddenExports !== undefined && hiddenExports.has(name)) {
-					hidden.add(name);
+					/** @type {Set<string>} */
+					(hidden).add(name);
 					continue;
 				}
 				exports.add(name);
@@ -483,7 +489,8 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 				const exportInfo = exportsInfo.getReadOnlyExportInfo(name);
 				if (exportInfo.getUsed(runtime) === UsageState.Unused) continue;
 				if (hiddenExports !== undefined && hiddenExports.has(name)) {
-					hidden.add(name);
+					/** @type {Set<string>} */
+					(hidden).add(name);
 					continue;
 				}
 				exports.add(name);
@@ -497,7 +504,7 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 
 	/**
 	 * @param {ModuleGraph} moduleGraph module graph
-	 * @returns {null | false | function(ModuleGraphConnection, RuntimeSpec): ConnectionState} function to determine if the connection is active
+	 * @returns {null | false | GetConditionFn} function to determine if the connection is active
 	 */
 	getCondition(moduleGraph) {
 		return (connection, runtime) => {
@@ -633,7 +640,9 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 			case "missing":
 				return undefined;
 			case "dynamic-reexport": {
-				const from = moduleGraph.getConnection(this);
+				const from =
+					/** @type {ModuleGraphConnection} */
+					(moduleGraph.getConnection(this));
 				return {
 					exports: true,
 					from,
@@ -649,11 +658,13 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 				return {
 					exports: [],
 					hideExports: mode.hidden,
-					dependencies: [moduleGraph.getModule(this)]
+					dependencies: [/** @type {Module} */ (moduleGraph.getModule(this))]
 				};
 			// falls through
 			case "normal-reexport": {
-				const from = moduleGraph.getConnection(this);
+				const from =
+					/** @type {ModuleGraphConnection} */
+					(moduleGraph.getConnection(this));
 				return {
 					exports: Array.from(mode.items, item => ({
 						name: item.name,
@@ -667,11 +678,13 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 			}
 			case "reexport-dynamic-default": {
 				{
-					const from = moduleGraph.getConnection(this);
+					const from =
+						/** @type {ModuleGraphConnection} */
+						(moduleGraph.getConnection(this));
 					return {
 						exports: [
 							{
-								name: mode.name,
+								name: /** @type {string} */ (mode.name),
 								from,
 								export: ["default"]
 							}
@@ -683,15 +696,17 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 			}
 			case "reexport-undefined":
 				return {
-					exports: [mode.name],
-					dependencies: [moduleGraph.getModule(this)]
+					exports: [/** @type {string} */ (mode.name)],
+					dependencies: [/** @type {Module} */ (moduleGraph.getModule(this))]
 				};
 			case "reexport-fake-namespace-object": {
-				const from = moduleGraph.getConnection(this);
+				const from =
+					/** @type {ModuleGraphConnection} */
+					(moduleGraph.getConnection(this));
 				return {
 					exports: [
 						{
-							name: mode.name,
+							name: /** @type {string} */ (mode.name),
 							from,
 							export: null,
 							exports: [
@@ -709,11 +724,13 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 				};
 			}
 			case "reexport-namespace-object": {
-				const from = moduleGraph.getConnection(this);
+				const from =
+					/** @type {ModuleGraphConnection} */
+					(moduleGraph.getConnection(this));
 				return {
 					exports: [
 						{
-							name: mode.name,
+							name: /** @type {string} */ (mode.name),
 							from,
 							export: null
 						}
@@ -723,11 +740,13 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 				};
 			}
 			case "reexport-named-default": {
-				const from = moduleGraph.getConnection(this);
+				const from =
+					/** @type {ModuleGraphConnection} */
+					(moduleGraph.getConnection(this));
 				return {
 					exports: [
 						{
-							name: mode.name,
+							name: /** @type {string} */ (mode.name),
 							from,
 							export: ["default"]
 						}
@@ -748,7 +767,8 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 	_getEffectiveExportPresenceLevel(moduleGraph) {
 		if (this.exportPresenceMode !== ExportPresenceModes.AUTO)
 			return this.exportPresenceMode;
-		return moduleGraph.getParentModule(this).buildMeta.strictHarmonyModule
+		const module = /** @type {Module} */ (moduleGraph.getParentModule(this));
+		return /** @type {BuildMeta} */ (module.buildMeta).strictHarmonyModule
 			? ExportPresenceModes.ERROR
 			: ExportPresenceModes.WARN;
 	}
@@ -826,7 +846,7 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 						);
 						if (conflictingModule === importedModule) continue;
 						const conflictingExportInfo = moduleGraph.getExportInfo(
-							conflictingModule,
+							/** @type {Module} */ (conflictingModule),
 							exportInfo.name
 						);
 						const conflictingTarget =
@@ -948,14 +968,14 @@ HarmonyExportImportedSpecifierDependency.Template = class HarmonyExportImportedS
 	}
 
 	/**
-	 * @param {InitFragment[]} initFragments target array for init fragments
+	 * @param {InitFragment<GenerateContext>[]} initFragments target array for init fragments
 	 * @param {HarmonyExportImportedSpecifierDependency} dep dependency
 	 * @param {ExportMode} mode the export mode
 	 * @param {Module} module the current module
 	 * @param {ModuleGraph} moduleGraph the module graph
 	 * @param {RuntimeSpec} runtime the runtime
 	 * @param {RuntimeTemplate} runtimeTemplate the runtime template
-	 * @param {Set<string>} runtimeRequirements runtime requirements
+	 * @param {RuntimeRequirements} runtimeRequirements runtime requirements
 	 * @returns {void}
 	 */
 	_addExportFragments(
@@ -968,7 +988,7 @@ HarmonyExportImportedSpecifierDependency.Template = class HarmonyExportImportedS
 		runtimeTemplate,
 		runtimeRequirements
 	) {
-		const importedModule = moduleGraph.getModule(dep);
+		const importedModule = /** @type {Module} */ (moduleGraph.getModule(dep));
 		const importVar = dep.getImportVar(moduleGraph);
 
 		switch (mode.type) {
@@ -1169,6 +1189,14 @@ HarmonyExportImportedSpecifierDependency.Template = class HarmonyExportImportedS
 		return new HarmonyExportInitFragment(module.exportsArgument, map);
 	}
 
+	/**
+	 * @param {Module} module module
+	 * @param {string | string[] | false} key key
+	 * @param {string} name name
+	 * @param {number} fakeType fake type
+	 * @param {RuntimeRequirements} runtimeRequirements runtime requirements
+	 * @returns {[InitFragment<GenerateContext>, HarmonyExportInitFragment]} init fragments
+	 */
 	getReexportFakeNamespaceObjectFragments(
 		module,
 		key,
@@ -1199,6 +1227,14 @@ HarmonyExportImportedSpecifierDependency.Template = class HarmonyExportImportedS
 		];
 	}
 
+	/**
+	 * @param {Module} module module
+	 * @param {string} key key
+	 * @param {string} name name
+	 * @param {string | string[] | false} valueKey value key
+	 * @param {RuntimeRequirements} runtimeRequirements runtime requirements
+	 * @returns {string} result
+	 */
 	getConditionalReexportStatement(
 		module,
 		key,
@@ -1226,6 +1262,11 @@ HarmonyExportImportedSpecifierDependency.Template = class HarmonyExportImportedS
 		)}: function() { return ${returnValue}; } });\n`;
 	}
 
+	/**
+	 * @param {string} name name
+	 * @param {null | false | string | string[]} valueKey value key
+	 * @returns {string | undefined} value
+	 */
 	getReturnValue(name, valueKey) {
 		if (valueKey === null) {
 			return `${name}_default.a`;

package/lib/dependencies/HarmonyExportInitFragment.js

@@ -13,6 +13,10 @@ const { propertyName } = require("../util/propertyName");
 /** @typedef {import("webpack-sources").Source} Source */
 /** @typedef {import("../Generator").GenerateContext} GenerateContext */
 
+/**
+ * @param {Iterable<string>} iterable iterable strings
+ * @returns {string} result
+ */
 const joinIterableWithComma = iterable => {
 	// This is more performant than Array.from().join(", ")
 	// as it doesn't create an array
@@ -33,7 +37,7 @@ const EMPTY_MAP = new Map();
 const EMPTY_SET = new Set();
 
 /**
- * @typedef {GenerateContext} Context
+ * @extends {InitFragment<GenerateContext>} Context
  */
 class HarmonyExportInitFragment extends InitFragment {
 	/**
@@ -99,6 +103,10 @@ class HarmonyExportInitFragment extends InitFragment {
 		);
 	}
 
+	/**
+	 * @param {HarmonyExportInitFragment} other other
+	 * @returns {HarmonyExportInitFragment} merged result
+	 */
 	merge(other) {
 		let exportMap;
 		if (this.exportMap.size === 0) {
@@ -131,7 +139,7 @@ class HarmonyExportInitFragment extends InitFragment {
 
 	/**
 	 * @param {GenerateContext} context context
-	 * @returns {string | Source} the source code that will be included as initialization code
+	 * @returns {string | Source | undefined} the source code that will be included as initialization code
 	 */
 	getContent({ runtimeTemplate, runtimeRequirements }) {
 		runtimeRequirements.add(RuntimeGlobals.exports);

package/lib/dependencies/HarmonyImportDependency.js

@@ -20,11 +20,13 @@ const ModuleDependency = require("./ModuleDependency");
 /** @typedef {import("../Dependency").ReferencedExport} ReferencedExport */
 /** @typedef {import("../Dependency").UpdateHashContext} UpdateHashContext */
 /** @typedef {import("../DependencyTemplate").DependencyTemplateContext} DependencyTemplateContext */
+/** @typedef {import("../ExportsInfo")} ExportsInfo */
 /** @typedef {import("../Module")} Module */
+/** @typedef {import("../Module").BuildMeta} BuildMeta */
 /** @typedef {import("../ModuleGraph")} ModuleGraph */
 /** @typedef {import("../RuntimeTemplate")} RuntimeTemplate */
 /** @typedef {import("../WebpackError")} WebpackError */
-/** @typedef {import("../javascript/JavascriptParser").Assertions} Assertions */
+/** @typedef {import("../javascript/JavascriptParser").ImportAttributes} ImportAttributes */
 /** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext} ObjectDeserializerContext */
 /** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext} ObjectSerializerContext */
 /** @typedef {import("../util/Hash")} Hash */
@@ -35,6 +37,10 @@ const ExportPresenceModes = {
 	WARN: /** @type {1} */ (1),
 	AUTO: /** @type {2} */ (2),
 	ERROR: /** @type {3} */ (3),
+	/**
+	 * @param {string | false} str param
+	 * @returns {0 | 1 | 2 | 3} result
+	 */
 	fromUserOption(str) {
 		switch (str) {
 			case "error":
@@ -56,12 +62,12 @@ class HarmonyImportDependency extends ModuleDependency {
 	 *
 	 * @param {string} request request string
 	 * @param {number} sourceOrder source order
-	 * @param {Assertions=} assertions import assertions
+	 * @param {ImportAttributes=} attributes import attributes
 	 */
-	constructor(request, sourceOrder, assertions) {
+	constructor(request, sourceOrder, attributes) {
 		super(request);
 		this.sourceOrder = sourceOrder;
-		this.assertions = assertions;
+		this.assertions = attributes;
 	}
 
 	get category() {
@@ -84,15 +90,20 @@ class HarmonyImportDependency extends ModuleDependency {
 	 */
 	getImportVar(moduleGraph) {
 		const module = moduleGraph.getParentModule(this);
-		const meta = moduleGraph.getMeta(module);
+		const meta = /** @type {TODO} */ (moduleGraph.getMeta(module));
 		let importVarMap = meta.importVarMap;
 		if (!importVarMap) meta.importVarMap = importVarMap = new Map();
-		let importVar = importVarMap.get(moduleGraph.getModule(this));
+		let importVar = importVarMap.get(
+			/** @type {Module} */ (moduleGraph.getModule(this))
+		);
 		if (importVar) return importVar;
 		importVar = `${Template.toIdentifier(
 			`${this.userRequest}`
 		)}__WEBPACK_IMPORTED_MODULE_${importVarMap.size}__`;
-		importVarMap.set(moduleGraph.getModule(this), importVar);
+		importVarMap.set(
+			/** @type {Module} */ (moduleGraph.getModule(this)),
+			importVar
+		);
 		return importVar;
 	}
 
@@ -107,7 +118,7 @@ class HarmonyImportDependency extends ModuleDependency {
 	) {
 		return runtimeTemplate.importStatement({
 			update,
-			module: moduleGraph.getModule(this),
+			module: /** @type {Module} */ (moduleGraph.getModule(this)),
 			chunkGraph,
 			importVar: this.getImportVar(moduleGraph),
 			request: this.request,
@@ -129,10 +140,12 @@ class HarmonyImportDependency extends ModuleDependency {
 			return;
 		}
 
-		const parentModule = moduleGraph.getParentModule(this);
+		const parentModule =
+			/** @type {Module} */
+			(moduleGraph.getParentModule(this));
 		const exportsType = importedModule.getExportsType(
 			moduleGraph,
-			parentModule.buildMeta.strictHarmonyModule
+			/** @type {BuildMeta} */ (parentModule.buildMeta).strictHarmonyModule
 		);
 		if (exportsType === "namespace" || exportsType === "default-with-named") {
 			if (ids.length === 0) {
@@ -170,7 +183,9 @@ class HarmonyImportDependency extends ModuleDependency {
 							)
 						];
 					}
-					exportsInfo = exportInfo.getNestedExportsInfo();
+					exportsInfo =
+						/** @type {ExportsInfo} */
+						(exportInfo.getNestedExportsInfo());
 				}
 
 				// General error message
@@ -207,7 +222,8 @@ class HarmonyImportDependency extends ModuleDependency {
 				if (
 					ids.length > 0 &&
 					ids[0] !== "default" &&
-					importedModule.buildMeta.defaultObject === "redirect-warn"
+					/** @type {BuildMeta} */
+					(importedModule.buildMeta).defaultObject === "redirect-warn"
 				) {
 					// For these modules only the default export is supported
 					return [

package/lib/dependencies/HarmonyImportDependencyParserPlugin.js

@@ -21,11 +21,16 @@ const HarmonyImportSpecifierDependency = require("./HarmonyImportSpecifierDepend
 /** @typedef {import("estree").Identifier} Identifier */
 /** @typedef {import("estree").ImportDeclaration} ImportDeclaration */
 /** @typedef {import("estree").ImportExpression} ImportExpression */
+/** @typedef {import("estree").Literal} Literal */
 /** @typedef {import("estree").MemberExpression} MemberExpression */
+/** @typedef {import("estree").ObjectExpression} ObjectExpression */
+/** @typedef {import("estree").Property} Property */
 /** @typedef {import("../../declarations/WebpackOptions").JavascriptParserOptions} JavascriptParserOptions */
 /** @typedef {import("../Dependency").DependencyLocation} DependencyLocation */
 /** @typedef {import("../javascript/BasicEvaluatedExpression")} BasicEvaluatedExpression */
 /** @typedef {import("../javascript/JavascriptParser")} JavascriptParser */
+/** @typedef {import("../javascript/JavascriptParser").DestructuringAssignmentProperty} DestructuringAssignmentProperty */
+/** @typedef {import("../javascript/JavascriptParser").ImportAttributes} ImportAttributes */
 /** @typedef {import("../javascript/JavascriptParser").Range} Range */
 /** @typedef {import("../optimize/InnerGraph").InnerGraph} InnerGraph */
 /** @typedef {import("../optimize/InnerGraph").TopLevelSymbol} TopLevelSymbol */
@@ -34,7 +39,7 @@ const HarmonyImportSpecifierDependency = require("./HarmonyImportSpecifierDepend
 const harmonySpecifierTag = Symbol("harmony import");
 
 /**
- * @typedef {Object} HarmonySettings
+ * @typedef {object} HarmonySettings
  * @property {string[]} ids
  * @property {string} source
  * @property {number} sourceOrder
@@ -44,24 +49,68 @@ const harmonySpecifierTag = Symbol("harmony import");
  */
 
 /**
- * @param {ImportDeclaration | ExportNamedDeclaration | ExportAllDeclaration | ImportExpression} node node with assertions
- * @returns {Record<string, any> | undefined} assertions
+ * @param {ImportDeclaration | ExportNamedDeclaration | ExportAllDeclaration | (ImportExpression & { arguments?: ObjectExpression[] })} node node with assertions
+ * @returns {ImportAttributes} import attributes
  */
-function getAssertions(node) {
+function getAttributes(node) {
+	if (
+		node.type === "ImportExpression" &&
+		node.arguments &&
+		node.arguments[0] &&
+		node.arguments[0].type === "ObjectExpression" &&
+		node.arguments[0].properties[0] &&
+		node.arguments[0].properties[0].type === "Property" &&
+		node.arguments[0].properties[0].value.type === "ObjectExpression" &&
+		node.arguments[0].properties[0].value.properties
+	) {
+		const properties =
+			/** @type {Property[]} */
+			(node.arguments[0].properties[0].value.properties);
+		const result = /** @type {ImportAttributes} */ ({});
+		for (const property of properties) {
+			const key =
+				/** @type {string} */
+				(
+					property.key.type === "Identifier"
+						? property.key.name
+						: /** @type {Literal} */ (property.key).value
+				);
+			result[key] =
+				/** @type {string} */
+				(/** @type {Literal} */ (property.value).value);
+		}
+		const key =
+			node.arguments[0].properties[0].key.type === "Identifier"
+				? node.arguments[0].properties[0].key.name
+				: /** @type {Literal} */ (node.arguments[0].properties[0].key).value;
+		if (key === "assert") {
+			result._isLegacyAssert = true;
+		}
+		return result;
+	}
 	// TODO remove cast when @types/estree has been updated to import assertions
-	const assertions = /** @type {{ assertions?: ImportAttributeNode[] }} */ (
-		node
-	).assertions;
-	if (assertions === undefined) {
+	const isImportAssertion =
+		/** @type {{ assertions?: ImportAttributeNode[] }} */ (node).assertions !==
+		undefined;
+	const attributes = isImportAssertion
+		? /** @type {{ assertions?: ImportAttributeNode[] }} */ (node).assertions
+		: /** @type {{ attributes?: ImportAttributeNode[] }} */ (node).attributes;
+	if (attributes === undefined) {
 		return undefined;
 	}
-	const result = {};
-	for (const assertion of assertions) {
+	const result = /** @type {ImportAttributes} */ ({});
+	for (const attribute of attributes) {
 		const key =
-			assertion.key.type === "Identifier"
-				? assertion.key.name
-				: assertion.key.value;
-		result[key] = assertion.value.value;
+			/** @type {string} */
+			(
+				attribute.key.type === "Identifier"
+					? attribute.key.name
+					: attribute.key.value
+			);
+		result[key] = /** @type {string} */ (attribute.value.value);
+	}
+	if (isImportAssertion) {
+		result._isLegacyAssert = true;
 	}
 	return result;
 }
@@ -125,11 +174,11 @@ module.exports = class HarmonyImportDependencyParserPlugin {
 				clearDep.loc = /** @type {DependencyLocation} */ (statement.loc);
 				parser.state.module.addPresentationalDependency(clearDep);
 				parser.unsetAsiPosition(/** @type {Range} */ (statement.range)[1]);
-				const assertions = getAssertions(statement);
+				const attributes = getAttributes(statement);
 				const sideEffectDep = new HarmonyImportSideEffectDependency(
-					source,
+					/** @type {string} */ (source),
 					parser.state.lastHarmonyImportOrder,
-					assertions
+					attributes
 				);
 				sideEffectDep.loc = /** @type {DependencyLocation} */ (statement.loc);
 				parser.state.module.addDependency(sideEffectDep);
@@ -145,7 +194,7 @@ module.exports = class HarmonyImportDependencyParserPlugin {
 					source,
 					ids,
 					sourceOrder: parser.state.lastHarmonyImportOrder,
-					assertions: getAssertions(statement)
+					assertions: getAttributes(statement)
 				});
 				return true;
 			}
@@ -368,4 +417,6 @@ module.exports = class HarmonyImportDependencyParserPlugin {
 };
 
 module.exports.harmonySpecifierTag = harmonySpecifierTag;
-module.exports.getAssertions = getAssertions;
+// TODO remove it in webpack@6 in favor getAttributes
+module.exports.getAssertions = getAttributes;
+module.exports.getAttributes = getAttributes;

package/lib/dependencies/HarmonyImportSideEffectDependency.js

@@ -10,23 +10,24 @@ const HarmonyImportDependency = require("./HarmonyImportDependency");
 
 /** @typedef {import("webpack-sources").ReplaceSource} ReplaceSource */
 /** @typedef {import("../Dependency")} Dependency */
+/** @typedef {import("../Dependency").GetConditionFn} GetConditionFn */
 /** @typedef {import("../DependencyTemplate").DependencyTemplateContext} DependencyTemplateContext */
 /** @typedef {import("../Module")} Module */
 /** @typedef {import("../ModuleGraph")} ModuleGraph */
 /** @typedef {import("../ModuleGraphConnection")} ModuleGraphConnection */
 /** @typedef {import("../ModuleGraphConnection").ConnectionState} ConnectionState */
-/** @typedef {import("../javascript/JavascriptParser").Assertions} Assertions */
+/** @typedef {import("../javascript/JavascriptParser").ImportAttributes} ImportAttributes */
 /** @typedef {import("../util/Hash")} Hash */
 /** @typedef {import("../util/runtime").RuntimeSpec} RuntimeSpec */
 
 class HarmonyImportSideEffectDependency extends HarmonyImportDependency {
 	/**
-	 * @param {TODO} request the request string
+	 * @param {string} request the request string
 	 * @param {number} sourceOrder source order
-	 * @param {Assertions=} assertions assertions
+	 * @param {ImportAttributes=} attributes import attributes
 	 */
-	constructor(request, sourceOrder, assertions) {
-		super(request, sourceOrder, assertions);
+	constructor(request, sourceOrder, attributes) {
+		super(request, sourceOrder, attributes);
 	}
 
 	get type() {
@@ -35,7 +36,7 @@ class HarmonyImportSideEffectDependency extends HarmonyImportDependency {
 
 	/**
 	 * @param {ModuleGraph} moduleGraph module graph
-	 * @returns {null | false | function(ModuleGraphConnection, RuntimeSpec): ConnectionState} function to determine if the connection is active
+	 * @returns {null | false | GetConditionFn} function to determine if the connection is active
 	 */
 	getCondition(moduleGraph) {
 		return connection => {