webpack 5.90.3 → 5.91.0

package/README.md

@@ -315,7 +315,7 @@ a question to [StackOverflow with the webpack tag](https://stackoverflow.com/tag
 
 If you are twitter savvy you can tweet #webpack with your question and someone should be able to reach out and help also.
 
-If you have discovered a 🐜 or have a feature suggestion, feel free to create an issue on Github.
+If you have discovered a 🐜 or have a feature suggestion, feel free to create an issue on GitHub.
 
 ### License
 
@@ -405,7 +405,7 @@ src="https://static.monei.net/monei-logo.svg" height="30" alt="MONEI"></a>
 
 <h2 align="center">Gold Sponsors</h2>
 
-[Become a gold sponsor](https://opencollective.com/webpack#sponsor) and get your logo on our README on Github with a link to your site.
+[Become a gold sponsor](https://opencollective.com/webpack#sponsor) and get your logo on our README on GitHub with a link to your site.
 
 <div align="center">
 
@@ -444,7 +444,7 @@ src="https://static.monei.net/monei-logo.svg" height="30" alt="MONEI"></a>
 
 <h2 align="center">Silver Sponsors</h2>
 
-[Become a silver sponsor](https://opencollective.com/webpack#sponsor) and get your logo on our README on Github with a link to your site.
+[Become a silver sponsor](https://opencollective.com/webpack#sponsor) and get your logo on our README on GitHub with a link to your site.
 
 <div align="center">
 
@@ -483,7 +483,7 @@ src="https://static.monei.net/monei-logo.svg" height="30" alt="MONEI"></a>
 
 <h2 align="center">Bronze Sponsors</h2>
 
-[Become a bronze sponsor](https://opencollective.com/webpack#sponsor) and get your logo on our README on Github with a link to your site.
+[Become a bronze sponsor](https://opencollective.com/webpack#sponsor) and get your logo on our README on GitHub with a link to your site.
 
 <div align="center">
 
@@ -593,7 +593,7 @@ src="https://static.monei.net/monei-logo.svg" height="30" alt="MONEI"></a>
 
 <h2 align="center">Backers</h2>
 
-[Become a backer](https://opencollective.com/webpack#backer) and get your image on our README on Github with a link to your site.
+[Become a backer](https://opencollective.com/webpack#backer) and get your image on our README on GitHub with a link to your site.
 
 <a href="https://opencollective.com/webpack/backer/0/website?requireActive=false" target="_blank"><img src="https://opencollective.com/webpack/backer/0/avatar.svg?requireActive=false"></a>
 <a href="https://opencollective.com/webpack/backer/1/website?requireActive=false" target="_blank"><img src="https://opencollective.com/webpack/backer/1/avatar.svg?requireActive=false"></a>

package/bin/webpack.js

@@ -119,6 +119,7 @@ if (!cli.installed) {
 
 	console.error(notify);
 
+	/** @type {string | undefined} */
 	let packageManager;
 
 	if (fs.existsSync(path.resolve(process.cwd(), "yarn.lock"))) {
@@ -171,7 +172,10 @@ if (!cli.installed) {
 			}')...`
 		);
 
-		runCommand(packageManager, installOptions.concat(cli.package))
+		runCommand(
+			/** @type {string} */ (packageManager),
+			installOptions.concat(cli.package)
+		)
 			.then(() => {
 				runCli(cli);
 			})

package/lib/APIPlugin.js

@@ -25,6 +25,7 @@ const GetFullHashRuntimeModule = require("./runtime/GetFullHashRuntimeModule");
 
 /** @typedef {import("./Compiler")} Compiler */
 /** @typedef {import("./Dependency").DependencyLocation} DependencyLocation */
+/** @typedef {import("./Module").BuildInfo} BuildInfo */
 /** @typedef {import("./javascript/JavascriptParser")} JavascriptParser */
 /** @typedef {import("./javascript/JavascriptParser").Range} Range */
 
@@ -187,7 +188,7 @@ class APIPlugin {
 				hooks.renderModuleContent.tap(
 					PLUGIN_NAME,
 					(source, module, renderContext) => {
-						if (module.buildInfo.needCreateRequire) {
+						if (/** @type {BuildInfo} */ (module.buildInfo).needCreateRequire) {
 							const chunkInitFragments = [
 								new InitFragment(
 									'import { createRequire as __WEBPACK_EXTERNAL_createRequire } from "module";\n',
@@ -214,7 +215,8 @@ class APIPlugin {
 							const dep = toConstantDependency(parser, info.expr, info.req);
 
 							if (key === "__non_webpack_require__" && this.options.module) {
-								parser.state.module.buildInfo.needCreateRequire = true;
+								/** @type {BuildInfo} */
+								(parser.state.module.buildInfo).needCreateRequire = true;
 							}
 
 							return dep(expression);
@@ -267,7 +269,8 @@ class APIPlugin {
 					parser.hooks.expression
 						.for("__webpack_module__.id")
 						.tap(PLUGIN_NAME, expr => {
-							parser.state.module.buildInfo.moduleConcatenationBailout =
+							/** @type {BuildInfo} */
+							(parser.state.module.buildInfo).moduleConcatenationBailout =
 								"__webpack_module__.id";
 							const dep = new ConstDependency(
 								parser.state.module.moduleArgument + ".id",
@@ -282,7 +285,8 @@ class APIPlugin {
 					parser.hooks.expression
 						.for("__webpack_module__")
 						.tap(PLUGIN_NAME, expr => {
-							parser.state.module.buildInfo.moduleConcatenationBailout =
+							/** @type {BuildInfo} */
+							(parser.state.module.buildInfo).moduleConcatenationBailout =
 								"__webpack_module__";
 							const dep = new ConstDependency(
 								parser.state.module.moduleArgument,

package/lib/AutomaticPrefetchPlugin.js

@@ -27,7 +27,7 @@ class AutomaticPrefetchPlugin {
 				);
 			}
 		);
-		/** @type {{context: string, request: string}[] | null} */
+		/** @type {{context: string | null, request: string}[] | null} */
 		let lastModules = null;
 		compiler.hooks.afterCompile.tap("AutomaticPrefetchPlugin", compilation => {
 			lastModules = [];

package/lib/BannerPlugin.js

@@ -83,12 +83,14 @@ class BannerPlugin {
 			options
 		);
 		const cache = new WeakMap();
+		const stage =
+			this.options.stage || Compilation.PROCESS_ASSETS_STAGE_ADDITIONS;
 
 		compiler.hooks.compilation.tap("BannerPlugin", compilation => {
 			compilation.hooks.processAssets.tap(
 				{
 					name: "BannerPlugin",
-					stage: Compilation.PROCESS_ASSETS_STAGE_ADDITIONS
+					stage
 				},
 				() => {
 					for (const chunk of compilation.chunks) {

package/lib/Cache.js

@@ -21,7 +21,7 @@ const {
 /**
  * @template T
  * @callback CallbackCache
- * @param {(WebpackError | null)=} err
+ * @param {WebpackError | null} err
  * @param {T=} result
  * @returns {void}
  */
@@ -33,6 +33,11 @@ const {
  * @returns {void}
  */
 
+/**
+ * @param {number} times times
+ * @param {function(Error=): void} callback callback
+ * @returns {function(Error=): void} callback
+ */
 const needCalls = (times, callback) => {
 	return err => {
 		if (--times === 0) {
@@ -71,6 +76,7 @@ class Cache {
 	 * @returns {void}
 	 */
 	get(identifier, etag, callback) {
+		/** @type {GotHandler[]} */
 		const gotHandlers = [];
 		this.hooks.get.callAsync(identifier, etag, gotHandlers, (err, result) => {
 			if (err) {

package/lib/CacheFacade.js

@@ -19,8 +19,8 @@ const mergeEtags = require("./cache/mergeEtags");
 /**
  * @template T
  * @callback CallbackCache
- * @param {(WebpackError | null)=} err
- * @param {T=} result
+ * @param {(Error | null)=} err
+ * @param {(T | null)=} result
  * @returns {void}
  */
 
@@ -196,7 +196,7 @@ class CacheFacade {
 	/**
 	 * @param {Cache} cache the root cache
 	 * @param {string} name the child cache name
-	 * @param {string | HashConstructor} hashFunction the hash function to use
+	 * @param {(string | HashConstructor)=} hashFunction the hash function to use
 	 */
 	constructor(cache, name, hashFunction) {
 		this._cache = cache;

package/lib/ChunkGraph.js

@@ -33,6 +33,7 @@ const {
 /** @typedef {import("./ChunkGroup")} ChunkGroup */
 /** @typedef {import("./Module")} Module */
 /** @typedef {import("./ModuleGraph")} ModuleGraph */
+/** @typedef {import("./ModuleGraphConnection").ConnectionState} ConnectionState */
 /** @typedef {import("./RuntimeModule")} RuntimeModule */
 /** @typedef {typeof import("./util/Hash")} Hash */
 /** @typedef {import("./util/runtime").RuntimeSpec} RuntimeSpec */
@@ -55,6 +56,10 @@ const compareModuleIterables = compareIterables(compareModulesByIdentifier);
  */
 
 class ModuleHashInfo {
+	/**
+	 * @param {string} hash hash
+	 * @param {string} renderedHash  rendered hash
+	 */
 	constructor(hash, renderedHash) {
 		this.hash = hash;
 		this.renderedHash = renderedHash;
@@ -180,13 +185,16 @@ const isAvailableChunk = (a, b) => {
 	return true;
 };
 
+/** @typedef {Set<Chunk>} EntryInChunks */
+/** @typedef {Set<Chunk>} RuntimeInChunks */
+
 class ChunkGraphModule {
 	constructor() {
 		/** @type {SortableSet<Chunk>} */
 		this.chunks = new SortableSet();
-		/** @type {Set<Chunk> | undefined} */
+		/** @type {EntryInChunks | undefined} */
 		this.entryInChunks = undefined;
-		/** @type {Set<Chunk> | undefined} */
+		/** @type {RuntimeInChunks | undefined} */
 		this.runtimeInChunks = undefined;
 		/** @type {RuntimeSpecMap<ModuleHashInfo> | undefined} */
 		this.hashes = undefined;
@@ -194,9 +202,9 @@ class ChunkGraphModule {
 		this.id = null;
 		/** @type {RuntimeSpecMap<Set<string>> | undefined} */
 		this.runtimeRequirements = undefined;
-		/** @type {RuntimeSpecMap<string>} */
+		/** @type {RuntimeSpecMap<string> | undefined} */
 		this.graphHashes = undefined;
-		/** @type {RuntimeSpecMap<string>} */
+		/** @type {RuntimeSpecMap<string> | undefined} */
 		this.graphHashesWithConnections = undefined;
 	}
 }
@@ -284,6 +292,9 @@ class ChunkGraph {
 			findGraphRoots(set, module => {
 				/** @type {Set<Module>} */
 				const set = new Set();
+				/**
+				 * @param {Module} module module
+				 */
 				const addDependencies = module => {
 					for (const connection of moduleGraph.getOutgoingConnections(module)) {
 						if (!connection.module) continue;
@@ -417,7 +428,7 @@ class ChunkGraph {
 			}
 			for (const chunk of oldCgm.entryInChunks) {
 				const cgc = this._getChunkGraphChunk(chunk);
-				const old = cgc.entryModules.get(oldModule);
+				const old = /** @type {Entrypoint} */ (cgc.entryModules.get(oldModule));
 				/** @type {Map<Module, Entrypoint>} */
 				const newEntryModules = new Map();
 				for (const [m, cg] of cgc.entryModules) {
@@ -716,7 +727,7 @@ class ChunkGraph {
 		for (const asyncChunk of includeAllChunks
 			? chunk.getAllReferencedChunks()
 			: chunk.getAllAsyncChunks()) {
-			/** @type {(string|number)[]} */
+			/** @type {(string | number)[] | undefined} */
 			let array;
 			for (const module of this.getOrderedChunkModulesIterable(
 				asyncChunk,
@@ -755,7 +766,7 @@ class ChunkGraph {
 		for (const asyncChunk of includeAllChunks
 			? chunk.getAllReferencedChunks()
 			: chunk.getAllAsyncChunks()) {
-			/** @type {Record<string|number, string>} */
+			/** @type {Record<string|number, string> | undefined} */
 			let idToHashMap;
 			for (const module of this.getOrderedChunkModulesIterable(
 				asyncChunk,
@@ -1115,7 +1126,7 @@ class ChunkGraph {
 	 */
 	disconnectEntryModule(module) {
 		const cgm = this._getChunkGraphModule(module);
-		for (const chunk of cgm.entryInChunks) {
+		for (const chunk of /** @type {EntryInChunks} */ (cgm.entryInChunks)) {
 			const cgc = this._getChunkGraphChunk(chunk);
 			cgc.entryModules.delete(module);
 		}
@@ -1223,14 +1234,7 @@ class ChunkGraph {
 		const array = Array.from(cgc.runtimeModules);
 		array.sort(
 			concatComparators(
-				compareSelect(
-					/**
-					 * @param {RuntimeModule} r runtime module
-					 * @returns {number=} stage
-					 */
-					r => r.stage,
-					compareIds
-				),
+				compareSelect(r => /** @type {RuntimeModule} */ (r).stage, compareIds),
 				compareModulesByIdentifier
 			)
 		);
@@ -1275,7 +1279,7 @@ class ChunkGraph {
 
 	/**
 	 * @param {AsyncDependenciesBlock} depBlock the async block
-	 * @returns {ChunkGroup} the chunk group
+	 * @returns {ChunkGroup | undefined} the chunk group
 	 */
 	getBlockChunkGroup(depBlock) {
 		return this._blockChunkGroups.get(depBlock);
@@ -1364,7 +1368,7 @@ class ChunkGraph {
 Caller might not support runtime-dependent code generation (opt-out via optimization.usedExports: "global").`
 				);
 			}
-			return first(hashInfoItems);
+			return /** @type {T} */ (first(hashInfoItems));
 		} else {
 			const hashInfo = hashes.get(runtime);
 			if (!hashInfo) {
@@ -1576,6 +1580,10 @@ Caller might not support runtime-dependent code generation (opt-out via optimiza
 		if (cgm.graphHashesWithConnections === undefined) {
 			cgm.graphHashesWithConnections = new RuntimeSpecMap();
 		}
+		/**
+		 * @param {ConnectionState} state state
+		 * @returns {"F" | "T" | "O"} result
+		 */
 		const activeStateToString = state => {
 			if (state === false) return "F";
 			if (state === true) return "T";
@@ -1646,6 +1654,9 @@ Caller might not support runtime-dependent code generation (opt-out via optimiza
 					? Array.from(connectedModules).sort(([a], [b]) => (a < b ? -1 : 1))
 					: connectedModules;
 			const hash = createHash(this._hashFunction);
+			/**
+			 * @param {Module} module module
+			 */
 			const addModuleToHash = module => {
 				hash.update(
 					this._getModuleGraphHashBigInt(
@@ -1655,6 +1666,9 @@ Caller might not support runtime-dependent code generation (opt-out via optimiza
 					).toString(16)
 				);
 			};
+			/**
+			 * @param {Set<Module>} modules modules
+			 */
 			const addModulesToHash = modules => {
 				let xor = ZERO_BIG_INT;
 				for (const m of modules) {

package/lib/ChunkGroup.js

@@ -70,7 +70,7 @@ const sortOrigin = (a, b) => {
 class ChunkGroup {
 	/**
 	 * Creates an instance of ChunkGroup.
-	 * @param {string|ChunkGroupOptions=} options chunk group options passed to chunkGroup
+	 * @param {string | ChunkGroupOptions=} options chunk group options passed to chunkGroup
 	 */
 	constructor(options) {
 		if (typeof options === "string") {
@@ -80,7 +80,7 @@ class ChunkGroup {
 		}
 		/** @type {number} */
 		this.groupDebugId = debugId++;
-		this.options = options;
+		this.options = /** @type {ChunkGroupOptions} */ (options);
 		/** @type {SortableSet<ChunkGroup>} */
 		this._children = new SortableSet(undefined, sortById);
 		/** @type {SortableSet<ChunkGroup>} */
@@ -108,18 +108,18 @@ class ChunkGroup {
 	 * @returns {void}
 	 */
 	addOptions(options) {
-		for (const key of Object.keys(options)) {
-			if (
-				this.options[/** @type {keyof ChunkGroupOptions} */ (key)] === undefined
-			) {
-				this.options[key] =
-					options[/** @type {keyof ChunkGroupOptions} */ (key)];
-			} else if (
-				this.options[/** @type {keyof ChunkGroupOptions} */ (key)] !==
-				options[/** @type {keyof ChunkGroupOptions} */ (key)]
-			) {
+		for (const _key of Object.keys(options)) {
+			const key = /** @type {keyof ChunkGroupOptions} */ (_key);
+			if (this.options[key] === undefined) {
+				/** @type {TODO} */
+				(this.options)[key] = options[key];
+			} else if (this.options[key] !== options[key]) {
 				if (key.endsWith("Order")) {
-					this.options[key] = Math.max(this.options[key], options[key]);
+					/** @type {TODO} */
+					(this.options)[key] = Math.max(
+						/** @type {number} */ (this.options[key]),
+						/** @type {number} */ (options[key])
+					);
 				} else {
 					throw new Error(
 						`ChunkGroup.addOptions: No option merge strategy for ${key}`
@@ -219,7 +219,7 @@ class ChunkGroup {
 	/**
 	 * @param {Chunk} oldChunk chunk to be replaced
 	 * @param {Chunk} newChunk New chunk that will be replaced with
-	 * @returns {boolean} returns true if the replacement was successful
+	 * @returns {boolean | undefined} returns true if the replacement was successful
 	 */
 	replaceChunk(oldChunk, newChunk) {
 		const oldIdx = this.chunks.indexOf(oldChunk);

package/lib/CleanPlugin.js

@@ -15,6 +15,7 @@ const processAsyncTree = require("./util/processAsyncTree");
 /** @typedef {import("../declarations/WebpackOptions").CleanOptions} CleanOptions */
 /** @typedef {import("./Compiler")} Compiler */
 /** @typedef {import("./logging/Logger").Logger} Logger */
+/** @typedef {import("./util/fs").IStats} IStats */
 /** @typedef {import("./util/fs").OutputFileSystem} OutputFileSystem */
 /** @typedef {import("./util/fs").StatsCallback} StatsCallback */
 
@@ -88,8 +89,8 @@ const getDiffToFs = (fs, outputPath, currentAssets, callback) => {
 					}
 					return callback(err);
 				}
-				for (const entry of entries) {
-					const file = /** @type {string} */ (entry);
+				for (const entry of /** @type {string[]} */ (entries)) {
+					const file = entry;
 					const filename = directory ? `${directory}/${file}` : file;
 					if (!directories.has(filename) && !currentAssets.has(filename)) {
 						diff.add(filename);
@@ -196,7 +197,7 @@ const applyDiff = (fs, outputPath, dry, logger, diff, isKept, callback) => {
 					}
 					doStat(fs, path, (err, stats) => {
 						if (err) return handleError(err);
-						if (!stats.isDirectory()) {
+						if (!(/** @type {IStats} */ (stats).isDirectory())) {
 							push({
 								type: "unlink",
 								filename,
@@ -206,7 +207,7 @@ const applyDiff = (fs, outputPath, dry, logger, diff, isKept, callback) => {
 						}
 
 						/** @type {NonNullable<OutputFileSystem["readdir"]>} */
-						(fs.readdir)(path, (err, entries) => {
+						(fs.readdir)(path, (err, _entries) => {
 							if (err) return handleError(err);
 							/** @type {Job} */
 							const deleteJob = {
@@ -214,6 +215,7 @@ const applyDiff = (fs, outputPath, dry, logger, diff, isKept, callback) => {
 								filename,
 								parent
 							};
+							const entries = /** @type {string[]} */ (_entries);
 							if (entries.length === 0) {
 								push(deleteJob);
 							} else {
@@ -355,7 +357,7 @@ class CleanPlugin {
 			(compilation, callback) => {
 				const hooks = CleanPlugin.getCompilationHooks(compilation);
 				const logger = compilation.getLogger("webpack.CleanPlugin");
-				const fs = compiler.outputFileSystem;
+				const fs = /** @type {OutputFileSystem} */ (compiler.outputFileSystem);
 
 				if (!fs.readdir) {
 					return callback(