webpack 5.86.0 → 5.87.0

package/README.md

@@ -232,6 +232,7 @@ or are automatically applied via regex from your webpack configuration.
 |   <a href="https://github.com/webpack-contrib/polymer-webpack-loader"><img width="48" height="48" src="https://worldvectorlogo.com/logos/polymer.svg"></a>   | ![polymer-npm] | ![polymer-size] | Process HTML & CSS with preprocessor of choice and `require()` Web Components like first-class modules |
 | <a href="https://github.com/TheLarkInn/angular2-template-loader"><img width="48" height="48" src="https://worldvectorlogo.com/logos/angular-icon-1.svg"></a> | ![angular-npm] | ![angular-size] | Loads and compiles Angular 2 Components                                                                |
 |              <a href="https://github.com/riot/webpack-loader"><img width="48" height="48" src="https://worldvectorlogo.com/logos/riot.svg"></a>              |  ![riot-npm]   |  ![riot-size]   | Riot official webpack loader                                                                           |
+|          <a href="https://github.com/sveltejs/svelte-loader"><img width="48" height="48" src="https://worldvectorlogo.com/logos/svelte-1.svg"></a>           | ![svelte-npm]  | ![svelte-size]  | Official Svelte loader                                                                                 |
 
 [vue-npm]: https://img.shields.io/npm/v/vue-loader.svg
 [vue-size]: https://packagephobia.com/badge?p=vue-loader
@@ -241,6 +242,8 @@ or are automatically applied via regex from your webpack configuration.
 [angular-size]: https://packagephobia.com/badge?p=angular2-template-loader
 [riot-npm]: https://img.shields.io/npm/v/riot-tag-loader.svg
 [riot-size]: https://packagephobia.com/badge?p=riot-tag-loader
+[svelte-npm]: https://img.shields.io/npm/v/svelte-loader.svg
+[svelte-size]: https://packagephobia.com/badge?p=svelte-loader
 
 ### Performance
 
@@ -714,5 +717,5 @@ src="https://static.monei.net/monei-logo.svg" height="30" alt="MONEI"></a>
 [builds2-url]: https://dev.azure.com/webpack/webpack/_build/latest?definitionId=3
 [licenses-url]: https://app.fossa.io/projects/git%2Bhttps%3A%2F%2Fgithub.com%2Fwebpack%2Fwebpack?ref=badge_shield
 [licenses]: https://app.fossa.io/api/projects/git%2Bhttps%3A%2F%2Fgithub.com%2Fwebpack%2Fwebpack.svg?type=shield
-[cover]: https://img.shields.io/coveralls/webpack/webpack.svg
-[cover-url]: https://coveralls.io/r/webpack/webpack/
+[cover]: https://codecov.io/gh/webpack/webpack/branch/master/graph/badge.svg?token=mDP3mQJNnn
+[cover-url]: https://codecov.io/gh/webpack/webpack

package/lib/CaseSensitiveModulesWarning.js

@@ -42,7 +42,9 @@ const createModulesListMessage = (modules, moduleGraph) => {
 
 			if (validReasons.length > 0) {
 				message += `\n    Used by ${validReasons.length} module(s), i. e.`;
-				message += `\n    ${validReasons[0].identifier()}`;
+				message += `\n    ${
+					/** @type {Module[]} */ (validReasons)[0].identifier()
+				}`;
 			}
 			return message;
 		})

package/lib/ChunkGroup.js

@@ -28,6 +28,7 @@ const {
  * @typedef {Object} RawChunkGroupOptions
  * @property {number=} preloadOrder
  * @property {number=} prefetchOrder
+ * @property {("low" | "high" | "auto")=} fetchPriority
  */
 
 /** @typedef {RawChunkGroupOptions & { name?: string }} ChunkGroupOptions */

package/lib/Compiler.js

@@ -1073,7 +1073,9 @@ ${other}`);
 		childCompiler.root = this.root;
 		if (Array.isArray(plugins)) {
 			for (const plugin of plugins) {
-				plugin.apply(childCompiler);
+				if (plugin) {
+					plugin.apply(childCompiler);
+				}
 			}
 		}
 		for (const name in this.hooks) {

package/lib/ConcatenationScope.js

@@ -108,7 +108,7 @@ class ConcatenationScope {
 		module,
 		{ ids = undefined, call = false, directImport = false, asiSafe = false }
 	) {
-		const info = this._modulesMap.get(module);
+		const info = /** @type {ModuleInfo} */ (this._modulesMap.get(module));
 		const callFlag = call ? "_call" : "";
 		const directImportFlag = directImport ? "_directImport" : "";
 		const asiSafeFlag = asiSafe
@@ -133,7 +133,7 @@ class ConcatenationScope {
 
 	/**
 	 * @param {string} name the identifier
-	 * @returns {ModuleReferenceOptions & { index: number }} parsed options and index
+	 * @returns {ModuleReferenceOptions & { index: number } | null} parsed options and index
 	 */
 	static matchModuleReference(name) {
 		const match = MODULE_REFERENCE_REGEXP.exec(name);

package/lib/ConditionalInitFragment.js

@@ -14,6 +14,11 @@ const { mergeRuntime } = require("./util/runtime");
 /** @typedef {import("./Generator").GenerateContext} GenerateContext */
 /** @typedef {import("./util/runtime").RuntimeSpec} RuntimeSpec */
 
+/**
+ * @param {string} condition condition
+ * @param {string | Source} source source
+ * @returns {string | Source} wrapped source
+ */
 const wrapInCondition = (condition, source) => {
 	if (typeof source === "string") {
 		return Template.asString([
@@ -33,13 +38,14 @@ const wrapInCondition = (condition, source) => {
 
 /**
  * @typedef {GenerateContext} Context
+ * @extends {InitFragment<Context>}
  */
 class ConditionalInitFragment extends InitFragment {
 	/**
 	 * @param {string|Source} content the source code that will be included as initialization code
 	 * @param {number} stage category of initialization code (contribute to order)
 	 * @param {number} position position in the category (contribute to order)
-	 * @param {string} key unique key to avoid emitting the same initialization code twice
+	 * @param {string | undefined} key unique key to avoid emitting the same initialization code twice
 	 * @param {RuntimeSpec | boolean} runtimeCondition in which runtime this fragment should be executed
 	 * @param {string|Source=} endContent the source code that will be included at the end of the module
 	 */
@@ -89,6 +95,10 @@ class ConditionalInitFragment extends InitFragment {
 		return wrapInCondition(expr, this.endContent);
 	}
 
+	/**
+	 * @param {ConditionalInitFragment} other fragment to merge with
+	 * @returns {ConditionalInitFragment} merged fragment
+	 */
 	merge(other) {
 		if (this.runtimeCondition === true) return this;
 		if (other.runtimeCondition === true) return other;

package/lib/ConstPlugin.js

@@ -15,9 +15,14 @@ const ConstDependency = require("./dependencies/ConstDependency");
 const { evaluateToString } = require("./javascript/JavascriptParserHelpers");
 const { parseResource } = require("./util/identifier");
 
-/** @typedef {import("estree").Expression} ExpressionNode */
-/** @typedef {import("estree").Super} SuperNode */
+/** @typedef {import("estree").Expression} Expression */
+/** @typedef {import("estree").SourceLocation} SourceLocation */
+/** @typedef {import("estree").Statement} Statement */
+/** @typedef {import("estree").Super} Super */
 /** @typedef {import("./Compiler")} Compiler */
+/** @typedef {import("./javascript/BasicEvaluatedExpression")} BasicEvaluatedExpression */
+/** @typedef {import("./javascript/JavascriptParser")} JavascriptParser */
+/** @typedef {import("./javascript/JavascriptParser").Range} Range */
 
 const collectDeclaration = (declarations, pattern) => {
 	const stack = [pattern];
@@ -136,6 +141,9 @@ class ConstPlugin {
 					new CachedConstDependency.Template()
 				);
 
+				/**
+				 * @param {JavascriptParser} parser the parser
+				 */
 				const handler = parser => {
 					parser.hooks.statementIf.tap(PLUGIN_NAME, statement => {
 						if (parser.scope.isAsmJs) return;
@@ -143,8 +151,11 @@ class ConstPlugin {
 						const bool = param.asBool();
 						if (typeof bool === "boolean") {
 							if (!param.couldHaveSideEffects()) {
-								const dep = new ConstDependency(`${bool}`, param.range);
-								dep.loc = statement.loc;
+								const dep = new ConstDependency(
+									`${bool}`,
+									/** @type {Range} */ (param.range)
+								);
+								dep.loc = /** @type {SourceLocation} */ (statement.loc);
 								parser.state.module.addPresentationalDependency(dep);
 							} else {
 								parser.walkExpression(statement.test);
@@ -200,9 +211,9 @@ class ConstPlugin {
 								}
 								const dep = new ConstDependency(
 									replacement,
-									branchToRemove.range
+									/** @type {Range} */ (branchToRemove.range)
 								);
-								dep.loc = branchToRemove.loc;
+								dep.loc = /** @type {SourceLocation} */ (branchToRemove.loc);
 								parser.state.module.addPresentationalDependency(dep);
 							}
 							return bool;
@@ -216,8 +227,11 @@ class ConstPlugin {
 							const bool = param.asBool();
 							if (typeof bool === "boolean") {
 								if (!param.couldHaveSideEffects()) {
-									const dep = new ConstDependency(` ${bool}`, param.range);
-									dep.loc = expression.loc;
+									const dep = new ConstDependency(
+										` ${bool}`,
+										/** @type {Range} */ (param.range)
+									);
+									dep.loc = /** @type {SourceLocation} */ (expression.loc);
 									parser.state.module.addPresentationalDependency(dep);
 								} else {
 									parser.walkExpression(expression.test);
@@ -236,8 +250,11 @@ class ConstPlugin {
 								const branchToRemove = bool
 									? expression.alternate
 									: expression.consequent;
-								const dep = new ConstDependency("0", branchToRemove.range);
-								dep.loc = branchToRemove.loc;
+								const dep = new ConstDependency(
+									"0",
+									/** @type {Range} */ (branchToRemove.range)
+								);
+								dep.loc = /** @type {SourceLocation} */ (branchToRemove.loc);
 								parser.state.module.addPresentationalDependency(dep);
 								return bool;
 							}
@@ -313,8 +330,11 @@ class ConstPlugin {
 										//
 										//   returnfalse&&'foo'
 										//
-										const dep = new ConstDependency(` ${bool}`, param.range);
-										dep.loc = expression.loc;
+										const dep = new ConstDependency(
+											` ${bool}`,
+											/** @type {Range} */ (param.range)
+										);
+										dep.loc = /** @type {SourceLocation} */ (expression.loc);
 										parser.state.module.addPresentationalDependency(dep);
 									} else {
 										parser.walkExpression(expression.left);
@@ -322,9 +342,9 @@ class ConstPlugin {
 									if (!keepRight) {
 										const dep = new ConstDependency(
 											"0",
-											expression.right.range
+											/** @type {Range} */ (expression.right.range)
 										);
-										dep.loc = expression.loc;
+										dep.loc = /** @type {SourceLocation} */ (expression.loc);
 										parser.state.module.addPresentationalDependency(dep);
 									}
 									return keepRight;
@@ -363,15 +383,18 @@ class ConstPlugin {
 										//
 										//   returnnull??'foo'
 										//
-										const dep = new ConstDependency(" null", param.range);
-										dep.loc = expression.loc;
+										const dep = new ConstDependency(
+											" null",
+											/** @type {Range} */ (param.range)
+										);
+										dep.loc = /** @type {SourceLocation} */ (expression.loc);
 										parser.state.module.addPresentationalDependency(dep);
 									} else {
 										const dep = new ConstDependency(
 											"0",
-											expression.right.range
+											/** @type {Range} */ (expression.right.range)
 										);
-										dep.loc = expression.loc;
+										dep.loc = /** @type {SourceLocation} */ (expression.loc);
 										parser.state.module.addPresentationalDependency(dep);
 										parser.walkExpression(expression.left);
 									}
@@ -382,9 +405,9 @@ class ConstPlugin {
 						}
 					);
 					parser.hooks.optionalChaining.tap(PLUGIN_NAME, expr => {
-						/** @type {ExpressionNode[]} */
+						/** @type {Expression[]} */
 						const optionalExpressionsStack = [];
-						/** @type {ExpressionNode|SuperNode} */
+						/** @type {Expression | Super} */
 						let next = expr.expression;
 
 						while (
@@ -395,7 +418,7 @@ class ConstPlugin {
 								if (next.optional) {
 									// SuperNode can not be optional
 									optionalExpressionsStack.push(
-										/** @type {ExpressionNode} */ (next.object)
+										/** @type {Expression} */ (next.object)
 									);
 								}
 								next = next.object;
@@ -403,7 +426,7 @@ class ConstPlugin {
 								if (next.optional) {
 									// SuperNode can not be optional
 									optionalExpressionsStack.push(
-										/** @type {ExpressionNode} */ (next.callee)
+										/** @type {Expression} */ (next.callee)
 									);
 								}
 								next = next.callee;
@@ -412,7 +435,9 @@ class ConstPlugin {
 
 						while (optionalExpressionsStack.length) {
 							const expression = optionalExpressionsStack.pop();
-							const evaluated = parser.evaluateExpression(expression);
+							const evaluated = parser.evaluateExpression(
+								/** @type {Expression} */ (expression)
+							);
 
 							if (evaluated.asNullish()) {
 								// ------------------------------------------
@@ -427,8 +452,11 @@ class ConstPlugin {
 								//
 								// ------------------------------------------
 								//
-								const dep = new ConstDependency(" undefined", expr.range);
-								dep.loc = expr.loc;
+								const dep = new ConstDependency(
+									" undefined",
+									/** @type {Range} */ (expr.range)
+								);
+								dep.loc = /** @type {SourceLocation} */ (expr.loc);
 								parser.state.module.addPresentationalDependency(dep);
 								return true;
 							}
@@ -452,10 +480,10 @@ class ConstPlugin {
 								JSON.stringify(
 									cachedParseResource(parser.state.module.resource).query
 								),
-								expr.range,
+								/** @type {Range} */ (expr.range),
 								"__resourceQuery"
 							);
-							dep.loc = expr.loc;
+							dep.loc = /** @type {SourceLocation} */ (expr.loc);
 							parser.state.module.addPresentationalDependency(dep);
 							return true;
 						});
@@ -478,10 +506,10 @@ class ConstPlugin {
 								JSON.stringify(
 									cachedParseResource(parser.state.module.resource).fragment
 								),
-								expr.range,
+								/** @type {Range} */ (expr.range),
 								"__resourceFragment"
 							);
-							dep.loc = expr.loc;
+							dep.loc = /** @type {SourceLocation} */ (expr.loc);
 							parser.state.module.addPresentationalDependency(dep);
 							return true;
 						});

package/lib/FlagEntryExportAsUsedPlugin.js

@@ -12,6 +12,10 @@ const { getEntryRuntime } = require("./util/runtime");
 const PLUGIN_NAME = "FlagEntryExportAsUsedPlugin";
 
 class FlagEntryExportAsUsedPlugin {
+	/**
+	 * @param {boolean} nsObjectUsed true, if the ns object is used
+	 * @param {string} explanation explanation for the reason
+	 */
 	constructor(nsObjectUsed, explanation) {
 		this.nsObjectUsed = nsObjectUsed;
 		this.explanation = explanation;

package/lib/ModuleDependencyError.js

@@ -23,7 +23,7 @@ class ModuleDependencyError extends WebpackError {
 		this.name = "ModuleDependencyError";
 		this.details =
 			err && !(/** @type {any} */ (err).hideStack)
-				? err.stack.split("\n").slice(1).join("\n")
+				? /** @type {string} */ (err.stack).split("\n").slice(1).join("\n")
 				: undefined;
 		this.module = module;
 		this.loc = loc;
@@ -32,7 +32,9 @@ class ModuleDependencyError extends WebpackError {
 
 		if (err && /** @type {any} */ (err).hideStack) {
 			this.stack =
-				err.stack.split("\n").slice(1).join("\n") + "\n\n" + this.stack;
+				/** @type {string} */ (err.stack).split("\n").slice(1).join("\n") +
+				"\n\n" +
+				this.stack;
 		}
 	}
 }

package/lib/ModuleDependencyWarning.js

@@ -23,7 +23,7 @@ class ModuleDependencyWarning extends WebpackError {
 		this.name = "ModuleDependencyWarning";
 		this.details =
 			err && !(/** @type {any} */ (err).hideStack)
-				? err.stack.split("\n").slice(1).join("\n")
+				? /** @type {string} */ (err.stack).split("\n").slice(1).join("\n")
 				: undefined;
 		this.module = module;
 		this.loc = loc;
@@ -32,7 +32,9 @@ class ModuleDependencyWarning extends WebpackError {
 
 		if (err && /** @type {any} */ (err).hideStack) {
 			this.stack =
-				err.stack.split("\n").slice(1).join("\n") + "\n\n" + this.stack;
+				/** @type {string} */ (err.stack).split("\n").slice(1).join("\n") +
+				"\n\n" +
+				this.stack;
 		}
 	}
 }

package/lib/ModuleGraph.js

@@ -35,14 +35,15 @@ const getConnectionsByOriginModule = set => {
 	const map = new Map();
 	/** @type {Module | 0} */
 	let lastModule = 0;
-	/** @type {ModuleGraphConnection[]} */
+	/** @type {ModuleGraphConnection[] | undefined} */
 	let lastList = undefined;
 	for (const connection of set) {
 		const { originModule } = connection;
 		if (lastModule === originModule) {
-			lastList.push(connection);
+			/** @type {ModuleGraphConnection[]} */
+			(lastList).push(connection);
 		} else {
-			lastModule = originModule;
+			lastModule = /** @type {Module} */ (originModule);
 			const list = map.get(originModule);
 			if (list !== undefined) {
 				lastList = list;
@@ -65,12 +66,13 @@ const getConnectionsByModule = set => {
 	const map = new Map();
 	/** @type {Module | 0} */
 	let lastModule = 0;
-	/** @type {ModuleGraphConnection[]} */
+	/** @type {ModuleGraphConnection[] | undefined} */
 	let lastList = undefined;
 	for (const connection of set) {
 		const { module } = connection;
 		if (lastModule === module) {
-			lastList.push(connection);
+			/** @type {ModuleGraphConnection[]} */
+			(lastList).push(connection);
 		} else {
 			lastModule = module;
 			const list = map.get(module);
@@ -99,13 +101,13 @@ class ModuleGraphModule {
 		this.optimizationBailout = [];
 		/** @type {ExportsInfo} */
 		this.exports = new ExportsInfo();
-		/** @type {number} */
+		/** @type {number | null} */
 		this.preOrderIndex = null;
-		/** @type {number} */
+		/** @type {number | null} */
 		this.postOrderIndex = null;
-		/** @type {number} */
+		/** @type {number | null} */
 		this.depth = null;
-		/** @type {ModuleProfile} */
+		/** @type {ModuleProfile | undefined | null} */
 		this.profile = undefined;
 		/** @type {boolean} */
 		this.async = false;
@@ -116,20 +118,20 @@ class ModuleGraphModule {
 
 class ModuleGraph {
 	constructor() {
-		/** @type {WeakMap<Dependency, ModuleGraphConnection>} */
+		/** @type {WeakMap<Dependency, ModuleGraphConnection | null>} */
 		this._dependencyMap = new WeakMap();
 		/** @type {Map<Module, ModuleGraphModule>} */
 		this._moduleMap = new Map();
 		/** @type {WeakMap<any, Object>} */
 		this._metaMap = new WeakMap();
 
-		/** @type {WeakTupleMap<any[], any>} */
+		/** @type {WeakTupleMap<any[], any> | undefined} */
 		this._cache = undefined;
 
 		/** @type {Map<Module, WeakTupleMap<any, any>>} */
 		this._moduleMemCaches = undefined;
 
-		/** @type {string} */
+		/** @type {string | undefined} */
 		this._cacheStage = undefined;
 	}
 
@@ -221,7 +223,9 @@ class ModuleGraph {
 	 * @returns {void}
 	 */
 	updateModule(dependency, module) {
-		const connection = this.getConnection(dependency);
+		const connection =
+			/** @type {ModuleGraphConnection} */
+			(this.getConnection(dependency));
 		if (connection.module === module) return;
 		const newConnection = connection.clone();
 		newConnection.module = module;
@@ -375,7 +379,7 @@ class ModuleGraph {
 
 	/**
 	 * @param {Dependency} dependency the dependency to look for a referenced module
-	 * @returns {Module} the referenced module
+	 * @returns {Module | null} the referenced module
 	 */
 	getResolvedModule(dependency) {
 		const connection = this.getConnection(dependency);
@@ -398,7 +402,10 @@ class ModuleGraph {
 				) {
 					let foundConnection;
 					for (const connection of mgm._unassignedConnections) {
-						this._dependencyMap.set(connection.dependency, connection);
+						this._dependencyMap.set(
+							/** @type {Dependency} */ (connection.dependency),
+							connection
+						);
 						if (connection.dependency === dependency)
 							foundConnection = connection;
 					}
@@ -416,7 +423,7 @@ class ModuleGraph {
 
 	/**
 	 * @param {Dependency} dependency the dependency to look for a referenced module
-	 * @returns {Module} the referenced module
+	 * @returns {Module | null} the referenced module
 	 */
 	getModule(dependency) {
 		const connection = this.getConnection(dependency);
@@ -425,7 +432,7 @@ class ModuleGraph {
 
 	/**
 	 * @param {Dependency} dependency the dependency to look for a referencing module
-	 * @returns {Module} the referencing module
+	 * @returns {Module | null} the referencing module
 	 */
 	getOrigin(dependency) {
 		const connection = this.getConnection(dependency);
@@ -434,7 +441,7 @@ class ModuleGraph {
 
 	/**
 	 * @param {Dependency} dependency the dependency to look for a referencing module
-	 * @returns {Module} the original referencing module
+	 * @returns {Module | null} the original referencing module
 	 */
 	getResolvedOrigin(dependency) {
 		const connection = this.getConnection(dependency);
@@ -604,7 +611,7 @@ class ModuleGraph {
 
 	/**
 	 * @param {Module} module the module
-	 * @returns {number} the index of the module
+	 * @returns {number | null} the index of the module
 	 */
 	getPreOrderIndex(module) {
 		const mgm = this._getModuleGraphModule(module);
@@ -613,7 +620,7 @@ class ModuleGraph {
 
 	/**
 	 * @param {Module} module the module
-	 * @returns {number} the index of the module
+	 * @returns {number | null} the index of the module
 	 */
 	getPostOrderIndex(module) {
 		const mgm = this._getModuleGraphModule(module);
@@ -670,7 +677,7 @@ class ModuleGraph {
 
 	/**
 	 * @param {Module} module the module
-	 * @returns {number} the depth of the module
+	 * @returns {number | null} the depth of the module
 	 */
 	getDepth(module) {
 		const mgm = this._getModuleGraphModule(module);
@@ -727,14 +734,14 @@ class ModuleGraph {
 		let meta = this._metaMap.get(thing);
 		if (meta === undefined) {
 			meta = Object.create(null);
-			this._metaMap.set(thing, meta);
+			this._metaMap.set(thing, /** @type {Object} */ (meta));
 		}
-		return meta;
+		return /** @type {Object} */ (meta);
 	}
 
 	/**
 	 * @param {any} thing any thing
-	 * @returns {Object} metadata
+	 * @returns {Object | undefined} metadata
 	 */
 	getMetaIfExisting(thing) {
 		return this._metaMap.get(thing);

package/lib/ModuleGraphConnection.js

@@ -74,9 +74,9 @@ class ModuleGraphConnection {
 		this.weak = weak;
 		this.conditional = !!condition;
 		this._active = condition !== false;
-		/** @type {function(ModuleGraphConnection, RuntimeSpec): ConnectionState} */
+		/** @type {(function(ModuleGraphConnection, RuntimeSpec): ConnectionState) | undefined} */
 		this.condition = condition || undefined;
-		/** @type {Set<string>} */
+		/** @type {Set<string> | undefined} */
 		this.explanations = undefined;
 		if (explanation) {
 			this.explanations = new Set();
@@ -107,7 +107,9 @@ class ModuleGraphConnection {
 	 */
 	addCondition(condition) {
 		if (this.conditional) {
-			const old = this.condition;
+			const old =
+				/** @type {(function(ModuleGraphConnection, RuntimeSpec): ConnectionState)} */
+				(this.condition);
 			this.condition = (c, r) =>
 				intersectConnectionStates(old(c, r), condition(c, r));
 		} else if (this._active) {
@@ -143,7 +145,12 @@ class ModuleGraphConnection {
 	 */
 	isActive(runtime) {
 		if (!this.conditional) return this._active;
-		return this.condition(this, runtime) !== false;
+
+		return (
+			/** @type {(function(ModuleGraphConnection, RuntimeSpec): ConnectionState)} */ (
+				this.condition
+			)(this, runtime) !== false
+		);
 	}
 
 	/**
@@ -152,7 +159,11 @@ class ModuleGraphConnection {
 	 */
 	isTargetActive(runtime) {
 		if (!this.conditional) return this._active;
-		return this.condition(this, runtime) === true;
+		return (
+			/** @type {(function(ModuleGraphConnection, RuntimeSpec): ConnectionState)} */ (
+				this.condition
+			)(this, runtime) === true
+		);
 	}
 
 	/**
@@ -161,7 +172,9 @@ class ModuleGraphConnection {
 	 */
 	getActiveState(runtime) {
 		if (!this.conditional) return this._active;
-		return this.condition(this, runtime);
+		return /** @type {(function(ModuleGraphConnection, RuntimeSpec): ConnectionState)} */ (
+			this.condition
+		)(this, runtime);
 	}
 
 	/**

package/lib/ModuleInfoHeaderPlugin.js

@@ -15,10 +15,16 @@ const JavascriptModulesPlugin = require("./javascript/JavascriptModulesPlugin");
 /** @typedef {import("./ExportsInfo")} ExportsInfo */
 /** @typedef {import("./ExportsInfo").ExportInfo} ExportInfo */
 /** @typedef {import("./Module")} Module */
+/** @typedef {import("./Module").BuildMeta} BuildMeta */
 /** @typedef {import("./ModuleGraph")} ModuleGraph */
 /** @typedef {import("./ModuleTemplate")} ModuleTemplate */
 /** @typedef {import("./RequestShortener")} RequestShortener */
 
+/**
+ * @template T
+ * @param {Iterable<T>} iterable iterable
+ * @returns {string} joined with comma
+ */
 const joinIterableWithComma = iterable => {
 	// This is more performant than Array.from().join(", ")
 	// as it doesn't create an array
@@ -139,7 +145,7 @@ const printExportsInfoToSource = (
 	}
 };
 
-/** @type {WeakMap<RequestShortener, WeakMap<Module, { header: RawSource, full: WeakMap<Source, CachedSource> }>>} */
+/** @type {WeakMap<RequestShortener, WeakMap<Module, { header: RawSource | undefined, full: WeakMap<Source, CachedSource> }>>} */
 const caches = new WeakMap();
 
 class ModuleInfoHeaderPlugin {
@@ -197,7 +203,8 @@ class ModuleInfoHeaderPlugin {
 					}
 					source.add(header);
 					if (verbose) {
-						const exportsType = module.buildMeta.exportsType;
+						const exportsType = /** @type {BuildMeta} */ (module.buildMeta)
+							.exportsType;
 						source.add(
 							Template.toComment(
 								exportsType

package/lib/ModuleNotFoundError.js

@@ -43,7 +43,7 @@ const previouslyPolyfilledBuiltinModules = {
 
 class ModuleNotFoundError extends WebpackError {
 	/**
-	 * @param {Module} module module tied to dependency
+	 * @param {Module | null} module module tied to dependency
 	 * @param {Error&any} err error thrown
 	 * @param {DependencyLocation} loc location of dependency
 	 */
@@ -54,7 +54,10 @@ class ModuleNotFoundError extends WebpackError {
 		const match = err.message.match(/Can't resolve '([^']+)'/);
 		if (match) {
 			const request = match[1];
-			const alias = previouslyPolyfilledBuiltinModules[request];
+			const alias =
+				previouslyPolyfilledBuiltinModules[
+					/** @type {keyof previouslyPolyfilledBuiltinModules} */ (request)
+				];
 			if (alias) {
 				const pathIndex = alias.indexOf("/");
 				const dependency = pathIndex > 0 ? alias.slice(0, pathIndex) : alias;