webpack 5.8.0 → 5.9.0

package/lib/ConcurrentCompilationError.js

@@ -7,9 +7,7 @@
 
 const WebpackError = require("./WebpackError");
 
-module.exports = class ConcurrentCompilationError extends (
-	WebpackError
-) {
+module.exports = class ConcurrentCompilationError extends WebpackError {
 	constructor() {
 		super();
 

package/lib/ContextModuleFactory.js

@@ -26,9 +26,7 @@ const { join } = require("./util/fs");
 
 const EMPTY_RESOLVE_OPTIONS = {};
 
-module.exports = class ContextModuleFactory extends (
-	ModuleFactory
-) {
+module.exports = class ContextModuleFactory extends ModuleFactory {
 	/**
 	 * @param {ResolverFactory} resolverFactory resolverFactory
 	 */

package/lib/HarmonyLinkingError.js

@@ -6,9 +6,7 @@
 
 const WebpackError = require("./WebpackError");
 
-module.exports = class HarmonyLinkingError extends (
-	WebpackError
-) {
+module.exports = class HarmonyLinkingError extends WebpackError {
 	/** @param {string} message Error message */
 	constructor(message) {
 		super(message);

package/lib/HotModuleReplacementPlugin.js

@@ -12,6 +12,7 @@ const Compilation = require("./Compilation");
 const HotUpdateChunk = require("./HotUpdateChunk");
 const NormalModule = require("./NormalModule");
 const RuntimeGlobals = require("./RuntimeGlobals");
+const WebpackError = require("./WebpackError");
 const ConstDependency = require("./dependencies/ConstDependency");
 const ImportMetaHotAcceptDependency = require("./dependencies/ImportMetaHotAcceptDependency");
 const ImportMetaHotDeclineDependency = require("./dependencies/ImportMetaHotDeclineDependency");
@@ -22,15 +23,22 @@ const JavascriptParser = require("./javascript/JavascriptParser");
 const {
 	evaluateToIdentifier
 } = require("./javascript/JavascriptParserHelpers");
-const { find } = require("./util/SetHelpers");
+const { find, isSubset } = require("./util/SetHelpers");
 const TupleSet = require("./util/TupleSet");
 const { compareModulesById } = require("./util/comparators");
-const { getRuntimeKey, keyToRuntime } = require("./util/runtime");
+const {
+	getRuntimeKey,
+	keyToRuntime,
+	forEachRuntime,
+	mergeRuntimeOwned,
+	subtractRuntime
+} = require("./util/runtime");
 
 /** @typedef {import("./Chunk")} Chunk */
 /** @typedef {import("./Compilation").AssetInfo} AssetInfo */
 /** @typedef {import("./Compiler")} Compiler */
 /** @typedef {import("./Module")} Module */
+/** @typedef {import("./RuntimeModule")} RuntimeModule */
 
 /**
  * @typedef {Object} HMRJavascriptParserHooks
@@ -388,27 +396,58 @@ class HotModuleReplacementPlugin {
 							}
 							chunkModuleHashes[key] = hash;
 						}
-						const hotUpdateMainContent = {
-							c: [],
-							r: [],
-							m: undefined
-						};
+
+						/** @type {Map<string, { updatedChunkIds: Set<string|number>, removedChunkIds: Set<string|number>, removedModules: Set<Module>, filename: string, assetInfo: AssetInfo }>} */
+						const hotUpdateMainContentByRuntime = new Map();
+						let allOldRuntime;
+						for (const key of Object.keys(records.chunkRuntime)) {
+							const runtime = keyToRuntime(records.chunkRuntime[key]);
+							allOldRuntime = mergeRuntimeOwned(allOldRuntime, runtime);
+						}
+						forEachRuntime(allOldRuntime, runtime => {
+							const {
+								path: filename,
+								info: assetInfo
+							} = compilation.getPathWithInfo(
+								compilation.outputOptions.hotUpdateMainFilename,
+								{
+									hash: records.hash,
+									runtime
+								}
+							);
+							hotUpdateMainContentByRuntime.set(runtime, {
+								updatedChunkIds: new Set(),
+								removedChunkIds: new Set(),
+								removedModules: new Set(),
+								filename,
+								assetInfo
+							});
+						});
+						if (hotUpdateMainContentByRuntime.size === 0) return;
 
 						// Create a list of all active modules to verify which modules are removed completely
 						/** @type {Map<number|string, Module>} */
 						const allModules = new Map();
 						for (const module of compilation.modules) {
-							allModules.set(chunkGraph.getModuleId(module), module);
+							const id = chunkGraph.getModuleId(module);
+							allModules.set(id, module);
 						}
 
 						// List of completely removed modules
-						const allRemovedModules = new Set();
+						/** @type {Set<string | number>} */
+						const completelyRemovedModules = new Set();
 
 						for (const key of Object.keys(records.chunkHashs)) {
-							// Check which modules are completely removed
+							const oldRuntime = keyToRuntime(records.chunkRuntime[key]);
+							/** @type {Module[]} */
+							const remainingModules = [];
+							// Check which modules are removed
 							for (const id of records.chunkModuleIds[key]) {
-								if (!allModules.has(id)) {
-									allRemovedModules.add(id);
+								const module = allModules.get(id);
+								if (module === undefined) {
+									completelyRemovedModules.add(id);
+								} else {
+									remainingModules.push(module);
 								}
 							}
 
@@ -417,6 +456,7 @@ class HotModuleReplacementPlugin {
 							let newRuntimeModules;
 							let newFullHashModules;
 							let newRuntime;
+							let removedFromRuntime;
 							const currentChunk = find(
 								compilation.chunks,
 								chunk => `${chunk.id}` === key
@@ -438,18 +478,61 @@ class HotModuleReplacementPlugin {
 									Array.from(fullHashModules).filter(module =>
 										updatedModules.has(module, currentChunk)
 									);
+								removedFromRuntime = subtractRuntime(oldRuntime, newRuntime);
 							} else {
+								// chunk has completely removed
 								chunkId = `${+key}` === key ? +key : key;
-								hotUpdateMainContent.r.push(chunkId);
-								const runtime = keyToRuntime(records.chunkRuntime[key]);
-								for (const id of records.chunkModuleIds[key]) {
-									const module = allModules.get(id);
-									if (!module) continue;
-									const hash = chunkGraph.getModuleHash(module, runtime);
+								removedFromRuntime = oldRuntime;
+								newRuntime = oldRuntime;
+							}
+							if (removedFromRuntime) {
+								// chunk was removed from some runtimes
+								forEachRuntime(removedFromRuntime, runtime => {
+									hotUpdateMainContentByRuntime
+										.get(runtime)
+										.removedChunkIds.add(chunkId);
+								});
+								// dispose modules from the chunk in these runtimes
+								// where they are no longer in this runtime
+								for (const module of remainingModules) {
 									const moduleKey = `${key}|${module.identifier()}`;
-									if (hash !== records.chunkModuleHashes[moduleKey]) {
-										newModules = newModules || [];
-										newModules.push(module);
+									const oldHash = records.chunkModuleHashes[moduleKey];
+									const runtimes = chunkGraph.getModuleRuntimes(module);
+									if (oldRuntime === newRuntime && runtimes.has(newRuntime)) {
+										// Module is still in the same runtime combination
+										const hash = chunkGraph.getModuleHash(module, newRuntime);
+										if (hash !== oldHash) {
+											if (module.type === "runtime") {
+												newRuntimeModules = newRuntimeModules || [];
+												newRuntimeModules.push(
+													/** @type {RuntimeModule} */ (module)
+												);
+											} else {
+												newModules = newModules || [];
+												newModules.push(module);
+											}
+										}
+									} else {
+										// module is no longer in this runtime combination
+										// We (incorrectly) assume that it's not in an overlapping runtime combination
+										// and dispose it from the main runtimes the chunk was removed from
+										forEachRuntime(removedFromRuntime, runtime => {
+											// If the module is still used in this runtime, do not dispose it
+											// This could create a bad runtime state where the module is still loaded,
+											// but no chunk which contains it. This means we don't receive further HMR updates
+											// to this module and that's bad.
+											// TODO force load one of the chunks which contains the module
+											for (const moduleRuntime of runtimes) {
+												if (typeof moduleRuntime === "string") {
+													if (moduleRuntime === runtime) return;
+												} else if (moduleRuntime !== undefined) {
+													if (moduleRuntime.has(runtime)) return;
+												}
+											}
+											hotUpdateMainContentByRuntime
+												.get(runtime)
+												.removedModules.add(module);
+										});
 									}
 								}
 							}
@@ -516,24 +599,75 @@ class HotModuleReplacementPlugin {
 										compilation.hooks.chunkAsset.call(currentChunk, filename);
 									}
 								}
-								hotUpdateMainContent.c.push(chunkId);
+								forEachRuntime(newRuntime, runtime => {
+									hotUpdateMainContentByRuntime
+										.get(runtime)
+										.updatedChunkIds.add(chunkId);
+								});
 							}
 						}
-						hotUpdateMainContent.m = Array.from(allRemovedModules);
-						const source = new RawSource(JSON.stringify(hotUpdateMainContent));
-						const {
-							path: filename,
-							info: assetInfo
-						} = compilation.getPathWithInfo(
-							compilation.outputOptions.hotUpdateMainFilename,
-							{
-								hash: records.hash
-							}
+						const completelyRemovedModulesArray = Array.from(
+							completelyRemovedModules
 						);
-						compilation.emitAsset(filename, source, {
-							hotModuleReplacement: true,
-							...assetInfo
-						});
+						const hotUpdateMainContentByFilename = new Map();
+						for (const {
+							removedChunkIds,
+							removedModules,
+							updatedChunkIds,
+							filename,
+							assetInfo
+						} of hotUpdateMainContentByRuntime.values()) {
+							const old = hotUpdateMainContentByFilename.get(filename);
+							if (
+								old &&
+								(!isSubset(old.removedChunkIds, removedChunkIds) ||
+									!isSubset(old.removedModules, removedModules) ||
+									!isSubset(old.updatedChunkIds, updatedChunkIds))
+							) {
+								compilation.warnings.push(
+									new WebpackError(`HotModuleReplacementPlugin
+The configured output.hotUpdateMainFilename doesn't lead to unique filenames per runtime and HMR update differs between runtimes.
+This might lead to incorrect runtime behavior of the applied update.
+To fix this, make sure to include [runtime] in the output.hotUpdateMainFilename option, or use the default config.`)
+								);
+								for (const chunkId of removedChunkIds)
+									old.removedChunkIds.add(chunkId);
+								for (const chunkId of removedModules)
+									old.removedModules.add(chunkId);
+								for (const chunkId of updatedChunkIds)
+									old.updatedChunkIds.add(chunkId);
+								continue;
+							}
+							hotUpdateMainContentByFilename.set(filename, {
+								removedChunkIds,
+								removedModules,
+								updatedChunkIds,
+								assetInfo
+							});
+						}
+						for (const [
+							filename,
+							{ removedChunkIds, removedModules, updatedChunkIds, assetInfo }
+						] of hotUpdateMainContentByFilename) {
+							const hotUpdateMainJson = {
+								c: Array.from(updatedChunkIds),
+								r: Array.from(removedChunkIds),
+								m:
+									removedModules.size === 0
+										? completelyRemovedModulesArray
+										: completelyRemovedModulesArray.concat(
+												Array.from(removedModules, m =>
+													chunkGraph.getModuleId(m)
+												)
+										  )
+							};
+
+							const source = new RawSource(JSON.stringify(hotUpdateMainJson));
+							compilation.emitAsset(filename, source, {
+								hotModuleReplacement: true,
+								...assetInfo
+							});
+						}
 					}
 				);
 

package/lib/ModuleDependencyWarning.js

@@ -10,9 +10,7 @@ const WebpackError = require("./WebpackError");
 /** @typedef {import("./Dependency").DependencyLocation} DependencyLocation */
 /** @typedef {import("./Module")} Module */
 
-module.exports = class ModuleDependencyWarning extends (
-	WebpackError
-) {
+module.exports = class ModuleDependencyWarning extends WebpackError {
 	/**
 	 * @param {Module} module module tied to dependency
 	 * @param {Error} err error thrown

package/lib/NoModeWarning.js

@@ -7,9 +7,7 @@
 
 const WebpackError = require("./WebpackError");
 
-module.exports = class NoModeWarning extends (
-	WebpackError
-) {
+module.exports = class NoModeWarning extends WebpackError {
 	constructor(modules) {
 		super();
 

package/lib/NormalModule.js

@@ -26,6 +26,7 @@ const ModuleWarning = require("./ModuleWarning");
 const RuntimeGlobals = require("./RuntimeGlobals");
 const UnhandledSchemeError = require("./UnhandledSchemeError");
 const WebpackError = require("./WebpackError");
+const formatLocation = require("./formatLocation");
 const LazySet = require("./util/LazySet");
 const { getScheme } = require("./util/URLAbsoluteSpecifier");
 const {
@@ -248,6 +249,7 @@ class NormalModule extends Module {
 		this._lastSuccessfulBuildMeta = {};
 		this._forceBuild = true;
 		this._isEvaluatingSideEffects = false;
+		this._addedSideEffectsBailout = new WeakSet();
 	}
 
 	/**
@@ -877,6 +879,17 @@ class NormalModule extends Module {
 			for (const dep of this.dependencies) {
 				const state = dep.getModuleEvaluationSideEffectsState(moduleGraph);
 				if (state === true) {
+					if (!this._addedSideEffectsBailout.has(moduleGraph)) {
+						this._addedSideEffectsBailout.add(moduleGraph);
+						moduleGraph
+							.getOptimizationBailout(this)
+							.push(
+								() =>
+									`Dependency (${
+										dep.type
+									}) with side effects at ${formatLocation(dep.loc)}`
+							);
+					}
 					this._isEvaluatingSideEffects = false;
 					return true;
 				} else if (state !== ModuleGraphConnection.CIRCULAR_CONNECTION) {

package/lib/TemplatedPathPlugin.js

@@ -274,6 +274,14 @@ const replacePathVariables = (path, data, assetInfo) => {
 	if (data.url) {
 		replacements.set("url", replacer(data.url));
 	}
+	if (typeof data.runtime === "string") {
+		replacements.set(
+			"runtime",
+			replacer(() => prepareId(data.runtime))
+		);
+	} else {
+		replacements.set("runtime", replacer("_"));
+	}
 
 	if (typeof path === "function") {
 		path = path(data, assetInfo);

package/lib/config/defaults.js

@@ -642,7 +642,7 @@ const applyOutputDefaults = (
 	F(output, "pathinfo", () => development);
 	D(output, "sourceMapFilename", "[file].map[query]");
 	D(output, "hotUpdateChunkFilename", "[id].[fullhash].hot-update.js");
-	D(output, "hotUpdateMainFilename", "[fullhash].hot-update.json");
+	D(output, "hotUpdateMainFilename", "[runtime].[fullhash].hot-update.json");
 	D(output, "crossOriginLoading", false);
 	F(output, "scriptType", () => (output.module ? "module" : false));
 	D(

package/lib/container/ContainerEntryModuleFactory.js

@@ -12,9 +12,7 @@ const ContainerEntryModule = require("./ContainerEntryModule");
 /** @typedef {import("../ModuleFactory").ModuleFactoryResult} ModuleFactoryResult */
 /** @typedef {import("./ContainerEntryDependency")} ContainerEntryDependency */
 
-module.exports = class ContainerEntryModuleFactory extends (
-	ModuleFactory
-) {
+module.exports = class ContainerEntryModuleFactory extends ModuleFactory {
 	/**
 	 * @param {ModuleFactoryCreateData} data data object
 	 * @param {function(Error=, ModuleFactoryResult=): void} callback callback

package/lib/container/FallbackModuleFactory.js

@@ -12,9 +12,7 @@ const FallbackModule = require("./FallbackModule");
 /** @typedef {import("../ModuleFactory").ModuleFactoryResult} ModuleFactoryResult */
 /** @typedef {import("./FallbackDependency")} FallbackDependency */
 
-module.exports = class FallbackModuleFactory extends (
-	ModuleFactory
-) {
+module.exports = class FallbackModuleFactory extends ModuleFactory {
 	/**
 	 * @param {ModuleFactoryCreateData} data data object
 	 * @param {function(Error=, ModuleFactoryResult=): void} callback callback

package/lib/dependencies/HarmonyExportImportedSpecifierDependency.js

@@ -370,6 +370,14 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 		};
 	}
 
+	/**
+	 * @param {ModuleGraph} moduleGraph the module graph
+	 * @returns {ConnectionState} how this dependency connects the module to referencing modules
+	 */
+	getModuleEvaluationSideEffectsState(moduleGraph) {
+		return false;
+	}
+
 	/**
 	 * Returns list of exports referenced by this dependency
 	 * @param {ModuleGraph} moduleGraph module graph

package/lib/dependencies/HarmonyImportSpecifierDependency.js

@@ -88,6 +88,14 @@ class HarmonyImportSpecifierDependency extends HarmonyImportDependency {
 			this.checkUsedByExports(moduleGraph, runtime);
 	}
 
+	/**
+	 * @param {ModuleGraph} moduleGraph the module graph
+	 * @returns {ConnectionState} how this dependency connects the module to referencing modules
+	 */
+	getModuleEvaluationSideEffectsState(moduleGraph) {
+		return false;
+	}
+
 	checkUsedByExports(moduleGraph, runtime) {
 		if (this.usedByExports === false) return false;
 		if (this.usedByExports !== true && this.usedByExports !== undefined) {

package/lib/optimize/SideEffectsFlagPlugin.js

@@ -9,6 +9,7 @@ const glob2regexp = require("glob-to-regexp");
 const { STAGE_DEFAULT } = require("../OptimizationStages");
 const HarmonyExportImportedSpecifierDependency = require("../dependencies/HarmonyExportImportedSpecifierDependency");
 const HarmonyImportSpecifierDependency = require("../dependencies/HarmonyImportSpecifierDependency");
+const formatLocation = require("../formatLocation");
 
 /** @typedef {import("../Compiler")} Compiler */
 /** @typedef {import("../Dependency")} Dependency */
@@ -67,223 +68,242 @@ class SideEffectsFlagPlugin {
 			cache = new Map();
 			globToRegexpCache.set(compiler.root, cache);
 		}
-		compiler.hooks.normalModuleFactory.tap("SideEffectsFlagPlugin", nmf => {
-			nmf.hooks.module.tap("SideEffectsFlagPlugin", (module, data) => {
-				const resolveData = data.resourceResolveData;
-				if (
-					resolveData &&
-					resolveData.descriptionFileData &&
-					resolveData.relativePath
-				) {
-					const sideEffects = resolveData.descriptionFileData.sideEffects;
-					const hasSideEffects = SideEffectsFlagPlugin.moduleHasSideEffects(
-						resolveData.relativePath,
-						sideEffects,
-						cache
-					);
-					if (!hasSideEffects) {
-						if (module.factoryMeta === undefined) {
-							module.factoryMeta = {};
+		compiler.hooks.compilation.tap(
+			"SideEffectsFlagPlugin",
+			(compilation, { normalModuleFactory }) => {
+				const moduleGraph = compilation.moduleGraph;
+				normalModuleFactory.hooks.module.tap(
+					"SideEffectsFlagPlugin",
+					(module, data) => {
+						const resolveData = data.resourceResolveData;
+						if (
+							resolveData &&
+							resolveData.descriptionFileData &&
+							resolveData.relativePath
+						) {
+							const sideEffects = resolveData.descriptionFileData.sideEffects;
+							const hasSideEffects = SideEffectsFlagPlugin.moduleHasSideEffects(
+								resolveData.relativePath,
+								sideEffects,
+								cache
+							);
+							if (!hasSideEffects) {
+								if (module.factoryMeta === undefined) {
+									module.factoryMeta = {};
+								}
+								module.factoryMeta.sideEffectFree = true;
+							}
 						}
-						module.factoryMeta.sideEffectFree = true;
-					}
-				}
 
-				return module;
-			});
-			nmf.hooks.module.tap("SideEffectsFlagPlugin", (module, data) => {
-				if (data.settings.sideEffects === false) {
-					if (module.factoryMeta === undefined) {
-						module.factoryMeta = {};
-					}
-					module.factoryMeta.sideEffectFree = true;
-				} else if (data.settings.sideEffects === true) {
-					if (module.factoryMeta !== undefined) {
-						module.factoryMeta.sideEffectFree = false;
+						return module;
 					}
-				}
-				return module;
-			});
-			if (this._analyseSource) {
-				/**
-				 * @param {JavascriptParser} parser the parser
-				 * @returns {void}
-				 */
-				const parserHandler = parser => {
-					let hasSideEffects = false;
-					parser.hooks.program.tap("SideEffectsFlagPlugin", () => {
-						hasSideEffects = false;
-					});
-					parser.hooks.statement.tap(
-						{ name: "SideEffectsFlagPlugin", stage: -100 },
-						statement => {
-							if (hasSideEffects) return;
-							if (parser.scope.topLevelScope !== true) return;
-							switch (statement.type) {
-								case "ExpressionStatement":
-									if (
-										!parser.isPure(statement.expression, statement.range[0])
-									) {
-										hasSideEffects = true;
-									}
-									break;
-								case "IfStatement":
-								case "WhileStatement":
-								case "DoWhileStatement":
-									if (!parser.isPure(statement.test, statement.range[0])) {
-										hasSideEffects = true;
-									}
-									// statement hook will be called for child statements too
-									break;
-								case "ForStatement":
-									if (
-										!parser.isPure(statement.init, statement.range[0]) ||
-										!parser.isPure(
-											statement.test,
-											statement.init
-												? statement.init.range[1]
-												: statement.range[0]
-										) ||
-										!parser.isPure(
-											statement.update,
-											statement.test
-												? statement.test.range[1]
-												: statement.init
-												? statement.init.range[1]
-												: statement.range[0]
-										)
-									) {
-										hasSideEffects = true;
-									}
-									// statement hook will be called for child statements too
-									break;
-								case "SwitchStatement":
-									if (
-										!parser.isPure(statement.discriminant, statement.range[0])
-									) {
-										hasSideEffects = true;
-									}
-									// statement hook will be called for child statements too
-									break;
-								case "VariableDeclaration":
-								case "ClassDeclaration":
-								case "FunctionDeclaration":
-									if (!parser.isPure(statement, statement.range[0])) {
-										hasSideEffects = true;
-									}
-									break;
-								case "ExportDefaultDeclaration":
-									if (
-										!parser.isPure(statement.declaration, statement.range[0])
-									) {
-										hasSideEffects = true;
-									}
-									break;
-								case "ExportNamedDeclaration":
-									if (statement.source) {
-										hasSideEffects = true;
-									}
-									break;
-								case "LabeledStatement":
-								case "BlockStatement":
-									// statement hook will be called for child statements too
-									break;
-								case "EmptyStatement":
-									break;
-								case "ImportDeclaration":
-									// imports will be handled by the dependencies
-									break;
-								default:
-									hasSideEffects = true;
-									break;
+				);
+				normalModuleFactory.hooks.module.tap(
+					"SideEffectsFlagPlugin",
+					(module, data) => {
+						if (data.settings.sideEffects === false) {
+							if (module.factoryMeta === undefined) {
+								module.factoryMeta = {};
+							}
+							module.factoryMeta.sideEffectFree = true;
+						} else if (data.settings.sideEffects === true) {
+							if (module.factoryMeta !== undefined) {
+								module.factoryMeta.sideEffectFree = false;
 							}
 						}
-					);
-					parser.hooks.finish.tap("SideEffectsFlagPlugin", () => {
-						if (!hasSideEffects) {
-							parser.state.module.buildMeta.sideEffectFree = true;
-						}
-					});
-				};
-				for (const key of [
-					"javascript/auto",
-					"javascript/esm",
-					"javascript/dynamic"
-				]) {
-					nmf.hooks.parser.for(key).tap("SideEffectsFlagPlugin", parserHandler);
+						return module;
+					}
+				);
+				if (this._analyseSource) {
+					/**
+					 * @param {JavascriptParser} parser the parser
+					 * @returns {void}
+					 */
+					const parserHandler = parser => {
+						let sideEffectsStatement;
+						parser.hooks.program.tap("SideEffectsFlagPlugin", () => {
+							sideEffectsStatement = undefined;
+						});
+						parser.hooks.statement.tap(
+							{ name: "SideEffectsFlagPlugin", stage: -100 },
+							statement => {
+								if (sideEffectsStatement) return;
+								if (parser.scope.topLevelScope !== true) return;
+								switch (statement.type) {
+									case "ExpressionStatement":
+										if (
+											!parser.isPure(statement.expression, statement.range[0])
+										) {
+											sideEffectsStatement = statement;
+										}
+										break;
+									case "IfStatement":
+									case "WhileStatement":
+									case "DoWhileStatement":
+										if (!parser.isPure(statement.test, statement.range[0])) {
+											sideEffectsStatement = statement;
+										}
+										// statement hook will be called for child statements too
+										break;
+									case "ForStatement":
+										if (
+											!parser.isPure(statement.init, statement.range[0]) ||
+											!parser.isPure(
+												statement.test,
+												statement.init
+													? statement.init.range[1]
+													: statement.range[0]
+											) ||
+											!parser.isPure(
+												statement.update,
+												statement.test
+													? statement.test.range[1]
+													: statement.init
+													? statement.init.range[1]
+													: statement.range[0]
+											)
+										) {
+											sideEffectsStatement = statement;
+										}
+										// statement hook will be called for child statements too
+										break;
+									case "SwitchStatement":
+										if (
+											!parser.isPure(statement.discriminant, statement.range[0])
+										) {
+											sideEffectsStatement = statement;
+										}
+										// statement hook will be called for child statements too
+										break;
+									case "VariableDeclaration":
+									case "ClassDeclaration":
+									case "FunctionDeclaration":
+										if (!parser.isPure(statement, statement.range[0])) {
+											sideEffectsStatement = statement;
+										}
+										break;
+									case "ExportNamedDeclaration":
+									case "ExportDefaultDeclaration":
+										if (
+											!parser.isPure(statement.declaration, statement.range[0])
+										) {
+											sideEffectsStatement = statement;
+										}
+										break;
+									case "LabeledStatement":
+									case "BlockStatement":
+										// statement hook will be called for child statements too
+										break;
+									case "EmptyStatement":
+										break;
+									case "ExportAllDeclaration":
+									case "ImportDeclaration":
+										// imports will be handled by the dependencies
+										break;
+									default:
+										sideEffectsStatement = statement;
+										break;
+								}
+							}
+						);
+						parser.hooks.finish.tap("SideEffectsFlagPlugin", () => {
+							if (sideEffectsStatement === undefined) {
+								parser.state.module.buildMeta.sideEffectFree = true;
+							} else {
+								const { loc, type } = sideEffectsStatement;
+								moduleGraph
+									.getOptimizationBailout(parser.state.module)
+									.push(
+										() =>
+											`Statement (${type}) with side effects in source code at ${formatLocation(
+												loc
+											)}`
+									);
+							}
+						});
+					};
+					for (const key of [
+						"javascript/auto",
+						"javascript/esm",
+						"javascript/dynamic"
+					]) {
+						normalModuleFactory.hooks.parser
+							.for(key)
+							.tap("SideEffectsFlagPlugin", parserHandler);
+					}
 				}
-			}
-		});
-		compiler.hooks.compilation.tap("SideEffectsFlagPlugin", compilation => {
-			const moduleGraph = compilation.moduleGraph;
-			compilation.hooks.optimizeDependencies.tap(
-				{
-					name: "SideEffectsFlagPlugin",
-					stage: STAGE_DEFAULT
-				},
-				modules => {
-					const logger = compilation.getLogger("webpack.SideEffectsFlagPlugin");
+				compilation.hooks.optimizeDependencies.tap(
+					{
+						name: "SideEffectsFlagPlugin",
+						stage: STAGE_DEFAULT
+					},
+					modules => {
+						const logger = compilation.getLogger(
+							"webpack.SideEffectsFlagPlugin"
+						);
 
-					logger.time("update dependencies");
-					for (const module of modules) {
-						if (module.getSideEffectsConnectionState(moduleGraph) === false) {
-							const exportsInfo = moduleGraph.getExportsInfo(module);
-							for (const connection of moduleGraph.getIncomingConnections(
-								module
-							)) {
-								const dep = connection.dependency;
-								let isReexport;
-								if (
-									(isReexport =
-										dep instanceof HarmonyExportImportedSpecifierDependency) ||
-									(dep instanceof HarmonyImportSpecifierDependency &&
-										!dep.namespaceObjectAsContext)
-								) {
-									// TODO improve for export *
-									if (isReexport && dep.name) {
-										const exportInfo = moduleGraph.getExportInfo(
-											connection.originModule,
-											dep.name
-										);
-										exportInfo.moveTarget(
-											moduleGraph,
-											({ module }) =>
-												module.getSideEffectsConnectionState(moduleGraph) ===
-												false
-										);
-									}
-									// TODO improve for nested imports
-									const ids = dep.getIds(moduleGraph);
-									if (ids.length > 0) {
-										const exportInfo = exportsInfo.getExportInfo(ids[0]);
-										const target = exportInfo.moveTarget(
-											moduleGraph,
-											({ module }) =>
-												module.getSideEffectsConnectionState(moduleGraph) ===
-												false
-										);
-										if (!target) continue;
+						logger.time("update dependencies");
+						for (const module of modules) {
+							if (module.getSideEffectsConnectionState(moduleGraph) === false) {
+								const exportsInfo = moduleGraph.getExportsInfo(module);
+								for (const connection of moduleGraph.getIncomingConnections(
+									module
+								)) {
+									const dep = connection.dependency;
+									let isReexport;
+									if (
+										(isReexport =
+											dep instanceof
+											HarmonyExportImportedSpecifierDependency) ||
+										(dep instanceof HarmonyImportSpecifierDependency &&
+											!dep.namespaceObjectAsContext)
+									) {
+										// TODO improve for export *
+										if (isReexport && dep.name) {
+											const exportInfo = moduleGraph.getExportInfo(
+												connection.originModule,
+												dep.name
+											);
+											exportInfo.moveTarget(
+												moduleGraph,
+												({ module }) =>
+													module.getSideEffectsConnectionState(moduleGraph) ===
+													false
+											);
+										}
+										// TODO improve for nested imports
+										const ids = dep.getIds(moduleGraph);
+										if (ids.length > 0) {
+											const exportInfo = exportsInfo.getExportInfo(ids[0]);
+											const target = exportInfo.moveTarget(
+												moduleGraph,
+												({ module }) =>
+													module.getSideEffectsConnectionState(moduleGraph) ===
+													false
+											);
+											if (!target) continue;
 
-										moduleGraph.updateModule(dep, target.module);
-										moduleGraph.addExplanation(
-											dep,
-											"(skipped side-effect-free modules)"
-										);
-										dep.setIds(
-											moduleGraph,
-											target.export
-												? [...target.export, ...ids.slice(1)]
-												: ids.slice(1)
-										);
+											moduleGraph.updateModule(dep, target.module);
+											moduleGraph.addExplanation(
+												dep,
+												"(skipped side-effect-free modules)"
+											);
+											dep.setIds(
+												moduleGraph,
+												target.export
+													? [...target.export, ...ids.slice(1)]
+													: ids.slice(1)
+											);
+										}
 									}
 								}
 							}
 						}
+						logger.timeEnd("update dependencies");
 					}
-					logger.timeEnd("update dependencies");
-				}
-			);
-		});
+				);
+			}
+		);
 	}
 
 	static moduleHasSideEffects(moduleName, flagValue, cache) {

package/lib/performance/AssetsOverSizeLimitWarning.js

@@ -10,9 +10,7 @@ const WebpackError = require("../WebpackError");
 
 /** @typedef {import("./SizeLimitsPlugin").AssetDetails} AssetDetails */
 
-module.exports = class AssetsOverSizeLimitWarning extends (
-	WebpackError
-) {
+module.exports = class AssetsOverSizeLimitWarning extends WebpackError {
 	/**
 	 * @param {AssetDetails[]} assetsOverSizeLimit the assets
 	 * @param {number} assetLimit the size limit

package/lib/performance/EntrypointsOverSizeLimitWarning.js

@@ -10,9 +10,7 @@ const WebpackError = require("../WebpackError");
 
 /** @typedef {import("./SizeLimitsPlugin").EntrypointDetails} EntrypointDetails */
 
-module.exports = class EntrypointsOverSizeLimitWarning extends (
-	WebpackError
-) {
+module.exports = class EntrypointsOverSizeLimitWarning extends WebpackError {
 	/**
 	 * @param {EntrypointDetails[]} entrypoints the entrypoints
 	 * @param {number} entrypointLimit the size limit

package/lib/performance/NoAsyncChunksWarning.js

@@ -7,9 +7,7 @@
 
 const WebpackError = require("../WebpackError");
 
-module.exports = class NoAsyncChunksWarning extends (
-	WebpackError
-) {
+module.exports = class NoAsyncChunksWarning extends WebpackError {
 	constructor() {
 		super(
 			"webpack performance recommendations: \n" +

package/lib/runtime/GetMainFilenameRuntimeModule.js

@@ -26,12 +26,14 @@ class GetMainFilenameRuntimeModule extends RuntimeModule {
 	 * @returns {string} runtime code
 	 */
 	generate() {
-		const { global, filename, compilation } = this;
+		const { global, filename, compilation, chunk } = this;
 		const { runtimeTemplate } = compilation;
 		const url = compilation.getPath(JSON.stringify(filename), {
 			hash: `" + ${RuntimeGlobals.getFullHash}() + "`,
 			hashWithLength: length =>
-				`" + ${RuntimeGlobals.getFullHash}().slice(0, ${length}) + "`
+				`" + ${RuntimeGlobals.getFullHash}().slice(0, ${length}) + "`,
+			chunk,
+			runtime: chunk.runtime
 		});
 		return Template.asString([
 			`${global} = ${runtimeTemplate.returningFunction(url)};`

package/lib/util/runtime.js

@@ -485,6 +485,10 @@ class RuntimeSpecSet {
 		this._map.set(getRuntimeKey(runtime), runtime);
 	}
 
+	has(runtime) {
+		return this._map.has(getRuntimeKey(runtime));
+	}
+
 	[Symbol.iterator]() {
 		return this._map.values();
 	}

package/lib/wasm-sync/UnsupportedWebAssemblyFeatureError.js

@@ -6,9 +6,7 @@
 
 const WebpackError = require("../WebpackError");
 
-module.exports = class UnsupportedWebAssemblyFeatureError extends (
-	WebpackError
-) {
+module.exports = class UnsupportedWebAssemblyFeatureError extends WebpackError {
 	/** @param {string} message Error message */
 	constructor(message) {
 		super(message);

package/lib/wasm-sync/WebAssemblyInInitialChunkError.js

@@ -79,9 +79,7 @@ const getInitialModuleChains = (
 	return Array.from(results);
 };
 
-module.exports = class WebAssemblyInInitialChunkError extends (
-	WebpackError
-) {
+module.exports = class WebAssemblyInInitialChunkError extends WebpackError {
 	/**
 	 * @param {Module} module WASM module
 	 * @param {ModuleGraph} moduleGraph the module graph

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "webpack",
-  "version": "5.8.0",
+  "version": "5.9.0",
   "author": "Tobias Koppers @sokra",
   "description": "Packs CommonJs/AMD modules for the browser. Allows to split your codebase into multiple bundles, which can be loaded on demand. Support loaders to preprocess files, i.e. json, jsx, es7, css, less, ... and your custom stuff.",
   "license": "MIT",

package/types.d.ts

@@ -8060,6 +8060,7 @@ declare abstract class RuntimeSpecMap<T> {
 }
 declare abstract class RuntimeSpecSet {
 	add(runtime?: any): void;
+	has(runtime?: any): boolean;
 	[Symbol.iterator](): IterableIterator<string | SortableSet<string>>;
 	readonly size: number;
 }