webpack 5.66.0 → 5.67.0

package/lib/container/RemoteModule.js

@@ -67,12 +67,14 @@ class RemoteModule extends Module {
 	 * @returns {string | null} an identifier for library inclusion
 	 */
 	libIdent(options) {
-		return `webpack/container/remote/${this.request}`;
+		return `${this.layer ? `(${this.layer})/` : ""}webpack/container/remote/${
+			this.request
+		}`;
 	}
 
 	/**
 	 * @param {NeedBuildContext} context context info
-	 * @param {function(WebpackError=, boolean=): void} callback callback function, returns true, if the module needs a rebuild
+	 * @param {function((WebpackError | null)=, boolean=): void} callback callback function, returns true, if the module needs a rebuild
 	 * @returns {void}
 	 */
 	needBuild(context, callback) {

package/lib/css/CssExportsGenerator.js

@@ -0,0 +1,139 @@
+/*
+	MIT License http://www.opensource.org/licenses/mit-license.php
+	Author Sergey Melyukov @smelukov
+*/
+
+"use strict";
+
+const { ReplaceSource, RawSource, ConcatSource } = require("webpack-sources");
+const { UsageState } = require("../ExportsInfo");
+const Generator = require("../Generator");
+const RuntimeGlobals = require("../RuntimeGlobals");
+const Template = require("../Template");
+
+/** @typedef {import("webpack-sources").Source} Source */
+/** @typedef {import("../Dependency")} Dependency */
+/** @typedef {import("../Generator").GenerateContext} GenerateContext */
+/** @typedef {import("../Generator").UpdateHashContext} UpdateHashContext */
+/** @typedef {import("../Module").ConcatenationBailoutReasonContext} ConcatenationBailoutReasonContext */
+/** @typedef {import("../NormalModule")} NormalModule */
+/** @typedef {import("../util/Hash")} Hash */
+
+const TYPES = new Set(["javascript"]);
+
+class CssExportsGenerator extends Generator {
+	constructor() {
+		super();
+	}
+
+	// TODO add getConcatenationBailoutReason to allow concatenation
+	// but how to make it have a module id
+
+	/**
+	 * @param {NormalModule} module module for which the code should be generated
+	 * @param {GenerateContext} generateContext context for generate
+	 * @returns {Source} generated code
+	 */
+	generate(module, generateContext) {
+		const source = new ReplaceSource(new RawSource(""));
+		const initFragments = [];
+		const cssExports = new Map();
+
+		generateContext.runtimeRequirements.add(RuntimeGlobals.module);
+
+		const runtimeRequirements = new Set();
+
+		const templateContext = {
+			runtimeTemplate: generateContext.runtimeTemplate,
+			dependencyTemplates: generateContext.dependencyTemplates,
+			moduleGraph: generateContext.moduleGraph,
+			chunkGraph: generateContext.chunkGraph,
+			module,
+			runtime: generateContext.runtime,
+			runtimeRequirements: runtimeRequirements,
+			concatenationScope: generateContext.concatenationScope,
+			codeGenerationResults: generateContext.codeGenerationResults,
+			initFragments,
+			cssExports
+		};
+
+		const handleDependency = dependency => {
+			const constructor = /** @type {new (...args: any[]) => Dependency} */ (
+				dependency.constructor
+			);
+			const template = generateContext.dependencyTemplates.get(constructor);
+			if (!template) {
+				throw new Error(
+					"No template for dependency: " + dependency.constructor.name
+				);
+			}
+
+			template.apply(dependency, source, templateContext);
+		};
+		module.dependencies.forEach(handleDependency);
+
+		if (generateContext.concatenationScope) {
+			const source = new ConcatSource();
+			const usedIdentifiers = new Set();
+			for (const [k, v] of cssExports) {
+				let identifier = Template.toIdentifier(k);
+				let i = 0;
+				while (usedIdentifiers.has(identifier)) {
+					identifier = Template.toIdentifier(k + i);
+				}
+				usedIdentifiers.add(identifier);
+				generateContext.concatenationScope.registerExport(k, identifier);
+				source.add(
+					`${
+						generateContext.runtimeTemplate.supportsConst ? "const" : "var"
+					} ${identifier} = ${JSON.stringify(v)};\n`
+				);
+			}
+			return source;
+		} else {
+			const otherUsed =
+				generateContext.moduleGraph
+					.getExportsInfo(module)
+					.otherExportsInfo.getUsed(generateContext.runtime) !==
+				UsageState.Unused;
+			if (otherUsed) {
+				generateContext.runtimeRequirements.add(
+					RuntimeGlobals.makeNamespaceObject
+				);
+			}
+			return new RawSource(
+				`${otherUsed ? `${RuntimeGlobals.makeNamespaceObject}(` : ""}${
+					module.moduleArgument
+				}.exports = {\n${Array.from(
+					cssExports,
+					([k, v]) => `\t${JSON.stringify(k)}: ${JSON.stringify(v)}`
+				).join(",\n")}\n}${otherUsed ? ")" : ""};`
+			);
+		}
+	}
+
+	/**
+	 * @param {NormalModule} module fresh module
+	 * @returns {Set<string>} available types (do not mutate)
+	 */
+	getTypes(module) {
+		return TYPES;
+	}
+
+	/**
+	 * @param {NormalModule} module the module
+	 * @param {string=} type source type
+	 * @returns {number} estimate size of the module
+	 */
+	getSize(module, type) {
+		return 42;
+	}
+
+	/**
+	 * @param {Hash} hash hash that will be modified
+	 * @param {UpdateHashContext} updateHashContext context for updating hash
+	 */
+	updateHash(hash, { module }) {}
+}
+
+module.exports = CssExportsGenerator;

package/lib/css/CssGenerator.js

@@ -8,6 +8,7 @@
 const { ReplaceSource } = require("webpack-sources");
 const Generator = require("../Generator");
 const InitFragment = require("../InitFragment");
+const RuntimeGlobals = require("../RuntimeGlobals");
 
 /** @typedef {import("webpack-sources").Source} Source */
 /** @typedef {import("../Dependency")} Dependency */
@@ -34,6 +35,8 @@ class CssGenerator extends Generator {
 		const initFragments = [];
 		const cssExports = new Map();
 
+		generateContext.runtimeRequirements.add(RuntimeGlobals.hasCssModules);
+
 		const templateContext = {
 			runtimeTemplate: generateContext.runtimeTemplate,
 			dependencyTemplates: generateContext.dependencyTemplates,

package/lib/css/CssLoadingRuntimeModule.js

@@ -79,14 +79,6 @@ class CssLoadingRuntimeModule extends RuntimeModule {
 		const withHmr = _runtimeRequirements.has(
 			RuntimeGlobals.hmrDownloadUpdateHandlers
 		);
-
-		if (!withLoading && !withHmr) {
-			return null;
-		}
-
-		const { createStylesheet } =
-			CssLoadingRuntimeModule.getCompilationHooks(compilation);
-
 		const initialChunkIdsWithCss = new Set();
 		const initialChunkIdsWithoutCss = new Set();
 		for (const c of chunk.getAllInitialChunks()) {
@@ -96,6 +88,13 @@ class CssLoadingRuntimeModule extends RuntimeModule {
 			).add(c.id);
 		}
 
+		if (!withLoading && !withHmr && initialChunkIdsWithCss.size === 0) {
+			return null;
+		}
+
+		const { createStylesheet } =
+			CssLoadingRuntimeModule.getCompilationHooks(compilation);
+
 		const stateExpression = withHmr
 			? `${RuntimeGlobals.hmrRuntimeStatePrefix}_css`
 			: undefined;
@@ -107,7 +106,6 @@ class CssLoadingRuntimeModule extends RuntimeModule {
 				: "",
 			"link.setAttribute(loadingAttribute, 1);",
 			'link.rel = "stylesheet";',
-			withHmr ? 'if(hmr) link.media = "print and screen";' : "",
 			"link.href = url;",
 			crossOriginLoading
 				? Template.asString([
@@ -138,64 +136,74 @@ class CssLoadingRuntimeModule extends RuntimeModule {
 						runtimeTemplate.outputOptions.uniqueName
 				  )};`
 				: "// data-webpack is not used as build has no uniqueName",
-			`var loadCssChunkData = ${runtimeTemplate.basicFunction("chunkId, link", [
-				'var data, token = "", token2, exports = {}, exportsWithId = [], exportsWithDashes = [], i = 0, cc = 1;',
-				"try { if(!link) link = loadStylesheet(chunkId); data = link.sheet.cssRules; data = data[data.length - 1].style; } catch(e) { data = getComputedStyle(document.head); }",
-				`data = data.getPropertyValue(${
-					uniqueName
-						? runtimeTemplate.concatenation(
-								"--webpack-",
-								{ expr: "uniqueName" },
-								"-",
-								{ expr: "chunkId" }
-						  )
-						: runtimeTemplate.concatenation("--webpack-", { expr: "chunkId" })
-				});`,
-				"if(!data) return;",
-				"for(; cc; i++) {",
-				Template.indent([
-					"cc = data.charCodeAt(i);",
-					`if(cc == ${cc("(")}) { token2 = token; token = ""; }`,
-					`else if(cc == ${cc(
-						")"
-					)}) { exports[token2.replace(/^_/, "")] = token.replace(/^_/, ""); token = ""; }`,
-					`else if(cc == ${cc("/")} || cc == ${cc(
-						"%"
-					)}) { token = token.replace(/^_/, ""); exports[token] = token; exportsWithId.push(token); if(cc == ${cc(
-						"%"
-					)}) exportsWithDashes.push(token); token = ""; }`,
-					`else if(!cc || cc == ${cc(
-						","
-					)}) { token = token.replace(/^_/, ""); exportsWithId.forEach(${runtimeTemplate.expressionFunction(
-						`exports[x] = ${
-							uniqueName
-								? runtimeTemplate.concatenation(
-										{ expr: "uniqueName" },
-										"-",
-										{ expr: "token" },
-										"-",
-										{ expr: "exports[x]" }
-								  )
-								: runtimeTemplate.concatenation({ expr: "token" }, "-", {
-										expr: "exports[x]"
-								  })
-						}`,
-						"x"
-					)}); exportsWithDashes.forEach(${runtimeTemplate.expressionFunction(
-						`exports[x] = "--" + exports[x]`,
-						"x"
-					)}); ${RuntimeGlobals.makeNamespaceObject}(exports); ${
-						RuntimeGlobals.moduleFactories
-					}[token] = (${runtimeTemplate.basicFunction(
-						"exports, module",
-						`module.exports = exports;`
-					)}).bind(null, exports); token = ""; exports = {}; exportsWithId.length = 0; }`,
-					`else if(cc == ${cc("\\")}) { token += data[++i] }`,
-					`else { token += data[i]; }`
-				]),
-				"}",
-				"installedChunks[chunkId] = 0;"
-			])}`,
+			`var loadCssChunkData = ${runtimeTemplate.basicFunction(
+				"target, link, chunkId",
+				[
+					`var data, token = "", token2, exports = {}, exportsWithId = [], exportsWithDashes = [], ${
+						withHmr ? "moduleIds = [], " : ""
+					}i = 0, cc = 1;`,
+					"try { if(!link) link = loadStylesheet(chunkId); data = link.sheet.cssRules; data = data[data.length - 1].style; } catch(e) { data = getComputedStyle(document.head); }",
+					`data = data.getPropertyValue(${
+						uniqueName
+							? runtimeTemplate.concatenation(
+									"--webpack-",
+									{ expr: "uniqueName" },
+									"-",
+									{ expr: "chunkId" }
+							  )
+							: runtimeTemplate.concatenation("--webpack-", { expr: "chunkId" })
+					});`,
+					"if(!data) return [];",
+					"for(; cc; i++) {",
+					Template.indent([
+						"cc = data.charCodeAt(i);",
+						`if(cc == ${cc("(")}) { token2 = token; token = ""; }`,
+						`else if(cc == ${cc(
+							")"
+						)}) { exports[token2.replace(/^_/, "")] = token.replace(/^_/, ""); token = ""; }`,
+						`else if(cc == ${cc("/")} || cc == ${cc(
+							"%"
+						)}) { token = token.replace(/^_/, ""); exports[token] = token; exportsWithId.push(token); if(cc == ${cc(
+							"%"
+						)}) exportsWithDashes.push(token); token = ""; }`,
+						`else if(!cc || cc == ${cc(
+							","
+						)}) { token = token.replace(/^_/, ""); exportsWithId.forEach(${runtimeTemplate.expressionFunction(
+							`exports[x] = ${
+								uniqueName
+									? runtimeTemplate.concatenation(
+											{ expr: "uniqueName" },
+											"-",
+											{ expr: "token" },
+											"-",
+											{ expr: "exports[x]" }
+									  )
+									: runtimeTemplate.concatenation({ expr: "token" }, "-", {
+											expr: "exports[x]"
+									  })
+							}`,
+							"x"
+						)}); exportsWithDashes.forEach(${runtimeTemplate.expressionFunction(
+							`exports[x] = "--" + exports[x]`,
+							"x"
+						)}); ${
+							RuntimeGlobals.makeNamespaceObject
+						}(exports); target[token] = (${runtimeTemplate.basicFunction(
+							"exports, module",
+							`module.exports = exports;`
+						)}).bind(null, exports); ${
+							withHmr ? "moduleIds.push(token); " : ""
+						}token = ""; exports = {}; exportsWithId.length = 0; }`,
+						`else if(cc == ${cc("\\")}) { token += data[++i] }`,
+						`else { token += data[i]; }`
+					]),
+					"}",
+					`${
+						withHmr ? `if(target == ${RuntimeGlobals.moduleFactories}) ` : ""
+					}installedChunks[chunkId] = 0;`,
+					withHmr ? "return moduleIds;" : ""
+				]
+			)}`,
 			'var loadingAttribute = "data-webpack-loading";',
 			`var loadStylesheet = ${runtimeTemplate.basicFunction(
 				"chunkId, url, done" + (withHmr ? ", hmr" : ""),
@@ -206,14 +214,18 @@ class CssLoadingRuntimeModule extends RuntimeModule {
 					"for(var i = 0; i < links.length; i++) {",
 					Template.indent([
 						"var l = links[i];",
-						`if(l.getAttribute("href") == url${
+						`if(l.rel == "stylesheet" && (${
+							withHmr
+								? 'l.href.startsWith(url) || l.getAttribute("href").startsWith(url)'
+								: 'l.href == url || l.getAttribute("href") == url'
+						}${
 							uniqueName
 								? ' || l.getAttribute("data-webpack") == uniqueName + ":" + key'
 								: ""
-						}) { link = l; break; }`
+						})) { link = l; break; }`
 					]),
 					"}",
-					"if(!url) return link;",
+					"if(!done) return link;",
 					withHmr ? "}" : "",
 					"if(!link) {",
 					Template.indent([
@@ -239,18 +251,24 @@ class CssLoadingRuntimeModule extends RuntimeModule {
 						"link.onload = onLinkComplete.bind(null, link.onload);"
 					]),
 					"} else onLinkComplete(undefined, { type: 'load', target: link });", // We assume any existing stylesheet is render blocking
+					withHmr ? "hmr ? document.head.insertBefore(link, hmr) :" : "",
 					"needAttach && document.head.appendChild(link);",
 					"return link;"
 				]
 			)};`,
-			initialChunkIdsWithCss.size > 5
+			initialChunkIdsWithCss.size > 2
 				? `${JSON.stringify(
 						Array.from(initialChunkIdsWithCss)
-				  )}.forEach(loadCssChunkData);`
+				  )}.forEach(loadCssChunkData.bind(null, ${
+						RuntimeGlobals.moduleFactories
+				  }, 0));`
 				: initialChunkIdsWithCss.size > 0
 				? `${Array.from(
 						initialChunkIdsWithCss,
-						id => `loadCssChunkData(${JSON.stringify(id)});`
+						id =>
+							`loadCssChunkData(${
+								RuntimeGlobals.moduleFactories
+							}, 0, ${JSON.stringify(id)});`
 				  ).join("")}`
 				: "// no initial css",
 			"",
@@ -308,7 +326,7 @@ class CssLoadingRuntimeModule extends RuntimeModule {
 																	]),
 																	"} else {",
 																	Template.indent([
-																		"loadCssChunkData(chunkId, link);",
+																		`loadCssChunkData(${RuntimeGlobals.moduleFactories}, link, chunkId);`,
 																		"installedChunkData[0]();"
 																	]),
 																	"}"
@@ -336,17 +354,41 @@ class CssLoadingRuntimeModule extends RuntimeModule {
 						"var oldTags = [];",
 						"var newTags = [];",
 						`var applyHandler = ${runtimeTemplate.basicFunction("options", [
-							`return { dispose: ${runtimeTemplate.basicFunction("", [
+							`return { dispose: ${runtimeTemplate.basicFunction(
+								"",
+								[]
+							)}, apply: ${runtimeTemplate.basicFunction("", [
+								"var moduleIds = [];",
+								`newTags.forEach(${runtimeTemplate.expressionFunction(
+									"info[1].sheet.disabled = false",
+									"info"
+								)});`,
 								"while(oldTags.length) {",
 								Template.indent([
 									"var oldTag = oldTags.pop();",
 									"if(oldTag.parentNode) oldTag.parentNode.removeChild(oldTag);"
 								]),
-								"}"
-							])}, apply: ${runtimeTemplate.basicFunction("", [
-								'while(newTags.length) { var info = newTags.pop(); info[1].media = "all"; loadCssChunkData(info[0], info[1]); }'
+								"}",
+								"while(newTags.length) {",
+								Template.indent([
+									`var info = newTags.pop();`,
+									`var chunkModuleIds = loadCssChunkData(${RuntimeGlobals.moduleFactories}, info[1], info[0]);`,
+									`chunkModuleIds.forEach(${runtimeTemplate.expressionFunction(
+										"moduleIds.push(id)",
+										"id"
+									)});`
+								]),
+								"}",
+								"return moduleIds;"
 							])} };`
 						])}`,
+						`var cssTextKey = ${runtimeTemplate.returningFunction(
+							`Array.from(link.sheet.cssRules, ${runtimeTemplate.returningFunction(
+								"r.cssText",
+								"r"
+							)}).join()`,
+							"link"
+						)}`,
 						`${
 							RuntimeGlobals.hmrDownloadUpdateHandlers
 						}.css = ${runtimeTemplate.basicFunction(
@@ -354,14 +396,14 @@ class CssLoadingRuntimeModule extends RuntimeModule {
 							[
 								"applyHandlers.push(applyHandler);",
 								`chunkIds.forEach(${runtimeTemplate.basicFunction("chunkId", [
-									"var oldTag = loadStylesheet(chunkId);",
-									"if(!oldTag) return;",
 									`var filename = ${RuntimeGlobals.getChunkCssFilename}(chunkId);`,
 									`var url = ${RuntimeGlobals.publicPath} + filename;`,
+									"var oldTag = loadStylesheet(chunkId, url);",
+									"if(!oldTag) return;",
 									`promises.push(new Promise(${runtimeTemplate.basicFunction(
 										"resolve, reject",
 										[
-											`var link = loadStylesheet(chunkId, url, ${runtimeTemplate.basicFunction(
+											`var link = loadStylesheet(chunkId, url + (url.indexOf("?") < 0 ? "?" : "&") + "hmr=" + Date.now(), ${runtimeTemplate.basicFunction(
 												"event",
 												[
 													'if(event.type !== "load") {',
@@ -374,11 +416,23 @@ class CssLoadingRuntimeModule extends RuntimeModule {
 														"error.request = realSrc;",
 														"reject(error);"
 													]),
-													"} else resolve();"
+													"} else {",
+													Template.indent([
+														"try { if(cssTextKey(oldTag) == cssTextKey(link)) { if(link.parentNode) link.parentNode.removeChild(link); return resolve(); } } catch(e) {}",
+														"var factories = {};",
+														"loadCssChunkData(factories, link, chunkId);",
+														`Object.keys(factories).forEach(${runtimeTemplate.expressionFunction(
+															"updatedModulesList.push(id)",
+															"id"
+														)})`,
+														"link.sheet.disabled = true;",
+														"oldTags.push(oldTag);",
+														"newTags.push([chunkId, link]);",
+														"resolve();"
+													]),
+													"}"
 												]
-											)}, true);`,
-											"oldTags.push(oldTag);",
-											"newTags.push([chunkId, link]);"
+											)}, oldTag);`
 										]
 									)}));`
 								])});`

package/lib/css/CssModulesPlugin.js

@@ -19,10 +19,12 @@ const { compareModulesByIdentifier } = require("../util/comparators");
 const createSchemaValidation = require("../util/create-schema-validation");
 const createHash = require("../util/createHash");
 const memoize = require("../util/memoize");
+const CssExportsGenerator = require("./CssExportsGenerator");
 const CssGenerator = require("./CssGenerator");
 const CssParser = require("./CssParser");
 
 /** @typedef {import("webpack-sources").Source} Source */
+/** @typedef {import("../../declarations/WebpackOptions").CssExperimentOptions} CssExperimentOptions */
 /** @typedef {import("../Chunk")} Chunk */
 /** @typedef {import("../Compiler")} Compiler */
 /** @typedef {import("../Module")} Module */
@@ -70,6 +72,12 @@ const escapeCss = (str, omitOptionalUnderscore) => {
 const plugin = "CssModulesPlugin";
 
 class CssModulesPlugin {
+	/**
+	 * @param {CssExperimentOptions} options options
+	 */
+	constructor({ exportsOnly = false }) {
+		this._exportsOnly = exportsOnly;
+	}
 	/**
 	 * Apply the plugin
 	 * @param {Compiler} compiler the compiler instance
@@ -143,19 +151,25 @@ class CssModulesPlugin {
 					.for("css")
 					.tap(plugin, generatorOptions => {
 						validateGeneratorOptions(generatorOptions);
-						return new CssGenerator();
+						return this._exportsOnly
+							? new CssExportsGenerator()
+							: new CssGenerator();
 					});
 				normalModuleFactory.hooks.createGenerator
 					.for("css/global")
 					.tap(plugin, generatorOptions => {
 						validateGeneratorOptions(generatorOptions);
-						return new CssGenerator();
+						return this._exportsOnly
+							? new CssExportsGenerator()
+							: new CssGenerator();
 					});
 				normalModuleFactory.hooks.createGenerator
 					.for("css/module")
 					.tap(plugin, generatorOptions => {
 						validateGeneratorOptions(generatorOptions);
-						return new CssGenerator();
+						return this._exportsOnly
+							? new CssExportsGenerator()
+							: new CssGenerator();
 					});
 				const orderedCssModulesPerChunk = new WeakMap();
 				compilation.hooks.afterCodeGeneration.tap("CssModulesPlugin", () => {
@@ -238,6 +252,9 @@ class CssModulesPlugin {
 					const CssLoadingRuntimeModule = getCssLoadingRuntimeModule();
 					compilation.addRuntimeModule(chunk, new CssLoadingRuntimeModule(set));
 				};
+				compilation.hooks.runtimeRequirementInTree
+					.for(RuntimeGlobals.hasCssModules)
+					.tap(plugin, handler);
 				compilation.hooks.runtimeRequirementInTree
 					.for(RuntimeGlobals.ensureChunkHandlers)
 					.tap(plugin, handler);

package/lib/debug/ProfilingPlugin.js

@@ -123,9 +123,7 @@ class Profiler {
  * @returns {Trace} The trace object
  */
 const createTrace = (fs, outputPath) => {
-	const trace = new Tracer({
-		noStream: true
-	});
+	const trace = new Tracer();
 	const profiler = new Profiler(inspector);
 	if (/\/|\\/.test(outputPath)) {
 		const dirPath = dirname(fs, outputPath);
@@ -173,6 +171,7 @@ const createTrace = (fs, outputPath) => {
 		counter,
 		profiler,
 		end: callback => {
+			trace.push("]");
 			// Wait until the write stream finishes.
 			fsStream.on("close", () => {
 				callback();
@@ -242,10 +241,10 @@ class ProfilingPlugin {
 				stage: Infinity
 			},
 			(stats, callback) => {
+				if (compiler.watchMode) return callback();
 				tracer.profiler.stopProfiling().then(parsedResults => {
 					if (parsedResults === undefined) {
 						tracer.profiler.destroy();
-						tracer.trace.flush();
 						tracer.end(callback);
 						return;
 					}
@@ -293,7 +292,6 @@ class ProfilingPlugin {
 					});
 
 					tracer.profiler.destroy();
-					tracer.trace.flush();
 					tracer.end(callback);
 				});
 			}
@@ -346,11 +344,15 @@ const interceptAllJavascriptModulesPluginHooks = (compilation, tracer) => {
 
 const makeInterceptorFor = (instance, tracer) => hookName => ({
 	register: ({ name, type, context, fn }) => {
-		const newFn = makeNewProfiledTapFn(hookName, tracer, {
-			name,
-			type,
-			fn
-		});
+		const newFn =
+			// Don't tap our own hooks to ensure stream can close cleanly
+			name === pluginName
+				? fn
+				: makeNewProfiledTapFn(hookName, tracer, {
+						name,
+						type,
+						fn
+				  });
 		return {
 			name,
 			type,

package/lib/dependencies/CreateScriptUrlDependency.js

@@ -25,6 +25,18 @@ class CreateScriptUrlDependency extends NullDependency {
 	get type() {
 		return "create script url";
 	}
+
+	serialize(context) {
+		const { write } = context;
+		write(this.range);
+		super.serialize(context);
+	}
+
+	deserialize(context) {
+		const { read } = context;
+		this.range = read();
+		super.deserialize(context);
+	}
 }
 
 CreateScriptUrlDependency.Template = class CreateScriptUrlDependencyTemplate extends (

package/lib/dependencies/LoaderPlugin.js

@@ -16,7 +16,7 @@ const LoaderImportDependency = require("./LoaderImportDependency");
 
 /**
  * @callback LoadModuleCallback
- * @param {Error=} err error object
+ * @param {(Error | null)=} err error object
  * @param {string | Buffer=} source source code
  * @param {object=} map source map
  * @param {Module=} module loaded module if successful
@@ -24,7 +24,7 @@ const LoaderImportDependency = require("./LoaderImportDependency");
 
 /**
  * @callback ImportModuleCallback
- * @param {Error=} err error object
+ * @param {(Error | null)=} err error object
  * @param {any=} exports exports of the evaluated module
  */