webpack 5.52.1 → 5.53.0

package/lib/NodeStuffInWebError.js

@@ -0,0 +1,34 @@
+/*
+	MIT License http://www.opensource.org/licenses/mit-license.php
+	Author Ivan Kopeykin @vankop
+*/
+
+"use strict";
+
+const WebpackError = require("./WebpackError");
+const makeSerializable = require("./util/makeSerializable");
+
+/** @typedef {import("./Dependency").DependencyLocation} DependencyLocation */
+
+class NodeStuffInWebError extends WebpackError {
+	/**
+	 * @param {DependencyLocation} loc loc
+	 * @param {string} expression expression
+	 * @param {string} description description
+	 */
+	constructor(loc, expression, description) {
+		super(
+			`${JSON.stringify(
+				expression
+			)} has been used, it will be undefined in next major version.
+${description}`
+		);
+
+		this.name = "NodeStuffInWebError";
+		this.loc = loc;
+	}
+}
+
+makeSerializable(NodeStuffInWebError, "webpack/lib/NodeStuffInWebError");
+
+module.exports = NodeStuffInWebError;

package/lib/NodeStuffPlugin.js

@@ -5,6 +5,7 @@
 
 "use strict";
 
+const NodeStuffInWebError = require("./NodeStuffInWebError");
 const RuntimeGlobals = require("./RuntimeGlobals");
 const CachedConstDependency = require("./dependencies/CachedConstDependency");
 const ConstDependency = require("./dependencies/ConstDependency");
@@ -44,7 +45,8 @@ class NodeStuffPlugin {
 						localOptions = { ...localOptions, ...parserOptions.node };
 					}
 
-					if (localOptions.global) {
+					if (localOptions.global !== false) {
+						const withWarning = localOptions.global === "warn";
 						parser.hooks.expression
 							.for("global")
 							.tap("NodeStuffPlugin", expr => {
@@ -55,10 +57,21 @@ class NodeStuffPlugin {
 								);
 								dep.loc = expr.loc;
 								parser.state.module.addPresentationalDependency(dep);
+
+								// TODO webpack 6 remove
+								if (withWarning) {
+									parser.state.module.addWarning(
+										new NodeStuffInWebError(
+											dep.loc,
+											"global",
+											"The global namespace object is Node.js feature and doesn't present in browser."
+										)
+									);
+								}
 							});
 					}
 
-					const setModuleConstant = (expressionName, fn) => {
+					const setModuleConstant = (expressionName, fn, warning) => {
 						parser.hooks.expression
 							.for(expressionName)
 							.tap("NodeStuffPlugin", expr => {
@@ -69,22 +82,41 @@ class NodeStuffPlugin {
 								);
 								dep.loc = expr.loc;
 								parser.state.module.addPresentationalDependency(dep);
+
+								// TODO webpack 6 remove
+								if (warning) {
+									parser.state.module.addWarning(
+										new NodeStuffInWebError(dep.loc, expressionName, warning)
+									);
+								}
+
 								return true;
 							});
 					};
 
-					const setConstant = (expressionName, value) =>
-						setModuleConstant(expressionName, () => value);
+					const setConstant = (expressionName, value, warning) =>
+						setModuleConstant(expressionName, () => value, warning);
 
 					const context = compiler.context;
 					if (localOptions.__filename) {
-						if (localOptions.__filename === "mock") {
-							setConstant("__filename", "/index.js");
-						} else if (localOptions.__filename === true) {
-							setModuleConstant("__filename", module =>
-								relative(compiler.inputFileSystem, context, module.resource)
-							);
+						switch (localOptions.__filename) {
+							case "mock":
+								setConstant("__filename", "/index.js");
+								break;
+							case "warn-mock":
+								setConstant(
+									"__filename",
+									"/index.js",
+									"The __filename is Node.js feature and doesn't present in browser."
+								);
+								break;
+							case true:
+								setModuleConstant("__filename", module =>
+									relative(compiler.inputFileSystem, context, module.resource)
+								);
+								break;
 						}
+
 						parser.hooks.evaluateIdentifier
 							.for("__filename")
 							.tap("NodeStuffPlugin", expr => {
@@ -94,13 +126,24 @@ class NodeStuffPlugin {
 							});
 					}
 					if (localOptions.__dirname) {
-						if (localOptions.__dirname === "mock") {
-							setConstant("__dirname", "/");
-						} else if (localOptions.__dirname === true) {
-							setModuleConstant("__dirname", module =>
-								relative(compiler.inputFileSystem, context, module.context)
-							);
+						switch (localOptions.__dirname) {
+							case "mock":
+								setConstant("__dirname", "/");
+								break;
+							case "warn-mock":
+								setConstant(
+									"__dirname",
+									"/",
+									"The __dirname is Node.js feature and doesn't present in browser."
+								);
+								break;
+							case true:
+								setModuleConstant("__dirname", module =>
+									relative(compiler.inputFileSystem, context, module.context)
+								);
+								break;
 						}
+
 						parser.hooks.evaluateIdentifier
 							.for("__dirname")
 							.tap("NodeStuffPlugin", expr => {

package/lib/cache/PackFileCacheStrategy.js

@@ -118,6 +118,14 @@ class Pack {
 				this.requests.push(undefined);
 				this.requestsTimeout = undefined;
 			}, MAX_TIME_IN_FRESH_PACK);
+			if (this.requestsTimeout.unref) this.requestsTimeout.unref();
+		}
+	}
+
+	stopCapturingRequests() {
+		if (this.requestsTimeout !== undefined) {
+			clearTimeout(this.requestsTimeout);
+			this.requestsTimeout = undefined;
 		}
 	}
 
@@ -1232,6 +1240,7 @@ class PackFileCacheStrategy {
 		const reportProgress = ProgressPlugin.getReporter(this.compiler);
 		return (this.storePromise = packPromise
 			.then(pack => {
+				pack.stopCapturingRequests();
 				if (!pack.invalid) return;
 				this.packPromise = undefined;
 				this.logger.log(`Storing pack...`);

package/lib/config/defaults.js

@@ -211,7 +211,10 @@ const applyWebpackOptionsDefaults = options => {
 			: "var";
 	});
 
-	applyNodeDefaults(options.node, { targetProperties });
+	applyNodeDefaults(options.node, {
+		futureDefaults: options.experiments.futureDefaults,
+		targetProperties
+	});
 
 	F(options, "performance", () =>
 		production &&
@@ -262,6 +265,7 @@ const applyExperimentsDefaults = (experiments, { production, development }) => {
 	D(experiments, "layers", false);
 	D(experiments, "lazyCompilation", false);
 	D(experiments, "buildHttp", false);
+	D(experiments, "futureDefaults", false);
 
 	if (typeof experiments.buildHttp === "object") {
 		D(experiments.buildHttp, "frozen", production);
@@ -943,21 +947,26 @@ const applyLoaderDefaults = (loader, { targetProperties }) => {
  * @param {WebpackNode} node options
  * @param {Object} options options
  * @param {TargetProperties | false} options.targetProperties target properties
+ * @param {boolean} options.futureDefaults is future defaults enabled
  * @returns {void}
  */
-const applyNodeDefaults = (node, { targetProperties }) => {
+const applyNodeDefaults = (node, { futureDefaults, targetProperties }) => {
 	if (node === false) return;
+
 	F(node, "global", () => {
 		if (targetProperties && targetProperties.global) return false;
-		return true;
+		// TODO webpack 6 should always default to false
+		return futureDefaults ? "warn" : true;
 	});
 	F(node, "__filename", () => {
 		if (targetProperties && targetProperties.node) return "eval-only";
-		return "mock";
+		// TODO webpack 6 should always default to false
+		return futureDefaults ? "warn-mock" : "mock";
 	});
 	F(node, "__dirname", () => {
 		if (targetProperties && targetProperties.node) return "eval-only";
-		return "mock";
+		// TODO webpack 6 should always default to false
+		return futureDefaults ? "warn-mock" : "mock";
 	});
 };
 

package/lib/node/NodeTargetPlugin.js

@@ -41,6 +41,7 @@ const builtins = [
 	"repl",
 	"stream",
 	"stream/promises",
+	"stream/web",
 	"string_decoder",
 	"sys",
 	"timers",

package/lib/util/internalSerializables.js

@@ -189,6 +189,7 @@ module.exports = {
 	UnsupportedFeatureWarning: () => require("../UnsupportedFeatureWarning"),
 	"util/LazySet": () => require("../util/LazySet"),
 	UnhandledSchemeError: () => require("../UnhandledSchemeError"),
+	NodeStuffInWebError: () => require("../NodeStuffInWebError"),
 	WebpackError: () => require("../WebpackError"),
 
 	"util/registerExternalSerializer": () => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "webpack",
-  "version": "5.52.1",
+  "version": "5.53.0",
   "author": "Tobias Koppers @sokra",
   "description": "Packs CommonJs/AMD modules for the browser. Allows to split your codebase into multiple bundles, which can be loaded on demand. Support loaders to preprocess files, i.e. json, jsx, es7, css, less, ... and your custom stuff.",
   "license": "MIT",
@@ -39,7 +39,7 @@
     "@babel/core": "^7.11.1",
     "@babel/preset-react": "^7.10.4",
     "@types/es-module-lexer": "^0.4.1",
-    "@types/jest": "^26.0.24",
+    "@types/jest": "^27.0.1",
     "@types/node": "^15.0.1",
     "babel-loader": "^8.1.0",
     "benchmark": "^2.1.4",