webpack 5.51.1 → 5.53.0

package/lib/dependencies/LoaderPlugin.js

@@ -37,11 +37,9 @@ const LoaderImportDependency = require("./LoaderImportDependency");
 class LoaderPlugin {
 	/**
 	 * @param {Object} options options
-	 * @param {boolean=} options.enableExecuteModule execute module enabled
 	 */
-	constructor(options = {}) {
-		this._enableExecuteModule = !!options.enableExecuteModule;
-	}
+	constructor(options = {}) {}
+
 	/**
 	 * Apply the plugin
 	 * @param {Compiler} compiler the compiler instance
@@ -155,106 +153,104 @@ class LoaderPlugin {
 						);
 					};
 
-					if (this._enableExecuteModule) {
-						/**
-						 * @param {string} request the request string to load the module from
-						 * @param {ImportModuleOptions=} options options
-						 * @param {ImportModuleCallback=} callback callback returning the exports
-						 * @returns {void}
-						 */
-						const importModule = (request, options, callback) => {
-							const dep = new LoaderImportDependency(request);
-							dep.loc = {
-								name: request
-							};
-							const factory = compilation.dependencyFactories.get(
-								/** @type {DepConstructor} */ (dep.constructor)
+					/**
+					 * @param {string} request the request string to load the module from
+					 * @param {ImportModuleOptions=} options options
+					 * @param {ImportModuleCallback=} callback callback returning the exports
+					 * @returns {void}
+					 */
+					const importModule = (request, options, callback) => {
+						const dep = new LoaderImportDependency(request);
+						dep.loc = {
+							name: request
+						};
+						const factory = compilation.dependencyFactories.get(
+							/** @type {DepConstructor} */ (dep.constructor)
+						);
+						if (factory === undefined) {
+							return callback(
+								new Error(
+									`No module factory available for dependency type: ${dep.constructor.name}`
+								)
 							);
-							if (factory === undefined) {
-								return callback(
-									new Error(
-										`No module factory available for dependency type: ${dep.constructor.name}`
-									)
-								);
-							}
-							compilation.buildQueue.increaseParallelism();
-							compilation.handleModuleCreation(
-								{
-									factory,
-									dependencies: [dep],
-									originModule: loaderContext._module,
-									contextInfo: {
-										issuerLayer: options.layer
-									},
-									context: loaderContext.context,
-									connectOrigin: false
+						}
+						compilation.buildQueue.increaseParallelism();
+						compilation.handleModuleCreation(
+							{
+								factory,
+								dependencies: [dep],
+								originModule: loaderContext._module,
+								contextInfo: {
+									issuerLayer: options.layer
 								},
-								err => {
-									compilation.buildQueue.decreaseParallelism();
-									if (err) {
-										return callback(err);
-									}
-									const referencedModule = moduleGraph.getModule(dep);
-									if (!referencedModule) {
-										return callback(new Error("Cannot load the module"));
-									}
-									compilation.executeModule(
-										referencedModule,
-										{
-											entryOptions: {
-												publicPath: options.publicPath
-											}
-										},
-										(err, result) => {
-											if (err) return callback(err);
-											for (const d of result.fileDependencies) {
-												loaderContext.addDependency(d);
-											}
-											for (const d of result.contextDependencies) {
-												loaderContext.addContextDependency(d);
-											}
-											for (const d of result.missingDependencies) {
-												loaderContext.addMissingDependency(d);
-											}
-											for (const d of result.buildDependencies) {
-												loaderContext.addBuildDependency(d);
-											}
-											if (result.cacheable === false)
-												loaderContext.cacheable(false);
-											for (const [name, { source, info }] of result.assets) {
-												const { buildInfo } = loaderContext._module;
-												if (!buildInfo.assets) {
-													buildInfo.assets = Object.create(null);
-													buildInfo.assetsInfo = new Map();
-												}
-												buildInfo.assets[name] = source;
-												buildInfo.assetsInfo.set(name, info);
+								context: loaderContext.context,
+								connectOrigin: false
+							},
+							err => {
+								compilation.buildQueue.decreaseParallelism();
+								if (err) {
+									return callback(err);
+								}
+								const referencedModule = moduleGraph.getModule(dep);
+								if (!referencedModule) {
+									return callback(new Error("Cannot load the module"));
+								}
+								compilation.executeModule(
+									referencedModule,
+									{
+										entryOptions: {
+											publicPath: options.publicPath
+										}
+									},
+									(err, result) => {
+										if (err) return callback(err);
+										for (const d of result.fileDependencies) {
+											loaderContext.addDependency(d);
+										}
+										for (const d of result.contextDependencies) {
+											loaderContext.addContextDependency(d);
+										}
+										for (const d of result.missingDependencies) {
+											loaderContext.addMissingDependency(d);
+										}
+										for (const d of result.buildDependencies) {
+											loaderContext.addBuildDependency(d);
+										}
+										if (result.cacheable === false)
+											loaderContext.cacheable(false);
+										for (const [name, { source, info }] of result.assets) {
+											const { buildInfo } = loaderContext._module;
+											if (!buildInfo.assets) {
+												buildInfo.assets = Object.create(null);
+												buildInfo.assetsInfo = new Map();
 											}
-											callback(null, result.exports);
+											buildInfo.assets[name] = source;
+											buildInfo.assetsInfo.set(name, info);
 										}
-									);
-								}
-							);
-						};
+										callback(null, result.exports);
+									}
+								);
+							}
+						);
+					};
 
-						/**
-						 * @param {string} request the request string to load the module from
-						 * @param {ImportModuleOptions} options options
-						 * @param {ImportModuleCallback=} callback callback returning the exports
-						 * @returns {Promise<any> | void} exports
-						 */
-						loaderContext.importModule = (request, options, callback) => {
-							if (!callback) {
-								return new Promise((resolve, reject) => {
-									importModule(request, options || {}, (err, result) => {
-										if (err) reject(err);
-										else resolve(result);
-									});
+					/**
+					 * @param {string} request the request string to load the module from
+					 * @param {ImportModuleOptions} options options
+					 * @param {ImportModuleCallback=} callback callback returning the exports
+					 * @returns {Promise<any> | void} exports
+					 */
+					loaderContext.importModule = (request, options, callback) => {
+						if (!callback) {
+							return new Promise((resolve, reject) => {
+								importModule(request, options || {}, (err, result) => {
+									if (err) reject(err);
+									else resolve(result);
 								});
-							}
-							return importModule(request, options || {}, callback);
-						};
-					}
+							});
+						}
+						return importModule(request, options || {}, callback);
+					};
 				}
 			);
 		});

package/lib/node/NodeTargetPlugin.js

@@ -41,6 +41,7 @@ const builtins = [
 	"repl",
 	"stream",
 	"stream/promises",
+	"stream/web",
 	"string_decoder",
 	"sys",
 	"timers",

package/lib/optimize/MangleExportsPlugin.js

@@ -39,13 +39,28 @@ const comparator = compareSelect(e => e.name, compareStringsNumeric);
 /**
  * @param {boolean} deterministic use deterministic names
  * @param {ExportsInfo} exportsInfo exports info
+ * @param {boolean} isNamespace is namespace object
  * @returns {void}
  */
-const mangleExportsInfo = (deterministic, exportsInfo) => {
+const mangleExportsInfo = (deterministic, exportsInfo, isNamespace) => {
 	if (!canMangle(exportsInfo)) return;
 	const usedNames = new Set();
 	/** @type {ExportInfo[]} */
 	const mangleableExports = [];
+
+	// Avoid to renamed exports that are not provided when
+	// 1. it's not a namespace export: non-provided exports can be found in prototype chain
+	// 2. there are other provided exports and deterministic mode is chosen:
+	//    non-provided exports would break the determinism
+	let avoidMangleNonProvided = !isNamespace;
+	if (!avoidMangleNonProvided && deterministic) {
+		for (const exportInfo of exportsInfo.ownedExports) {
+			if (exportInfo.provided !== false) {
+				avoidMangleNonProvided = true;
+				break;
+			}
+		}
+	}
 	for (const exportInfo of exportsInfo.ownedExports) {
 		const name = exportInfo.name;
 		if (!exportInfo.hasUsedName()) {
@@ -59,7 +74,7 @@ const mangleExportsInfo = (deterministic, exportsInfo) => {
 					name.length === 2 &&
 					/^[a-zA-Z_$][a-zA-Z0-9_$]|^[1-9][0-9]/.test(name)) ||
 				// Don't rename exports that are not provided
-				exportInfo.provided !== true
+				(avoidMangleNonProvided && exportInfo.provided !== true)
 			) {
 				exportInfo.setUsedName(name);
 				usedNames.add(name);
@@ -73,7 +88,7 @@ const mangleExportsInfo = (deterministic, exportsInfo) => {
 				used === UsageState.OnlyPropertiesUsed ||
 				used === UsageState.Unused
 			) {
-				mangleExportsInfo(deterministic, exportInfo.exportsInfo);
+				mangleExportsInfo(deterministic, exportInfo.exportsInfo, false);
 			}
 		}
 	}
@@ -143,8 +158,10 @@ class MangleExportsPlugin {
 				"MangleExportsPlugin",
 				modules => {
 					for (const module of modules) {
+						const isNamespace =
+							module.buildMeta && module.buildMeta.exportsType === "namespace";
 						const exportsInfo = moduleGraph.getExportsInfo(module);
-						mangleExportsInfo(deterministic, exportsInfo);
+						mangleExportsInfo(deterministic, exportsInfo, isNamespace);
 					}
 				}
 			);

package/lib/optimize/SplitChunksPlugin.js

@@ -1073,7 +1073,7 @@ module.exports = class SplitChunksPlugin {
 												"SplitChunksPlugin\n" +
 													`Cache group "${cacheGroup.key}" conflicts with existing chunk.\n` +
 													`Both have the same name "${name}" and existing chunk is not a parent of the selected modules.\n` +
-													"Use a different name for the cache group or make sure that the existing chunk is a parent (e. g. via dependsOn).\n" +
+													"Use a different name for the cache group or make sure that the existing chunk is a parent (e. g. via dependOn).\n" +
 													'HINT: You can omit "name" to automatically create a name.\n' +
 													"BREAKING CHANGE: webpack < 5 used to allow to use an entrypoint as splitChunk. " +
 													"This is no longer allowed when the entrypoint is not a parent of the selected modules.\n" +

package/lib/runtime/GetChunkFilenameRuntimeModule.js

@@ -30,6 +30,7 @@ class GetChunkFilenameRuntimeModule extends RuntimeModule {
 		this.global = global;
 		this.getFilenameForChunk = getFilenameForChunk;
 		this.allChunks = allChunks;
+		this.dependentHash = true;
 	}
 
 	/**

package/lib/runtime/RelativeUrlRuntimeModule.js

@@ -30,7 +30,7 @@ class RelativeUrlRuntimeModule extends HelperRuntimeModule {
 				`values.toString = values.toJSON = ${runtimeTemplate.returningFunction(
 					"url"
 				)};`,
-				"for (var key in values) Object.defineProperty(this, key, Object.assign({ enumerable: true, configurable: true, value: values[key] }));"
+				"for (var key in values) Object.defineProperty(this, key, { enumerable: true, configurable: true, value: values[key] });"
 			]),
 			"};",
 			`${RuntimeGlobals.relativeUrl}.prototype = URL.prototype;`

package/lib/serialization/ObjectMiddleware.js

@@ -510,11 +510,11 @@ class ObjectMiddleware extends SerializerMiddleware {
 				} else if (SerializerMiddleware.isLazy(item, this)) {
 					throw new Error("Not implemented");
 				} else {
-					result.push(
-						SerializerMiddleware.serializeLazy(item, data =>
-							this.serialize([data], context)
-						)
+					const data = SerializerMiddleware.serializeLazy(item, data =>
+						this.serialize([data], context)
 					);
+					SerializerMiddleware.setLazySerializedValue(item, data);
+					result.push(data);
 				}
 			} else if (item === undefined) {
 				result.push(ESCAPE, ESCAPE_UNDEFINED);

package/lib/util/internalSerializables.js

@@ -164,6 +164,7 @@ module.exports = {
 	DllModule: () => require("../DllModule"),
 	ExternalModule: () => require("../ExternalModule"),
 	FileSystemInfo: () => require("../FileSystemInfo"),
+	InitFragment: () => require("../InitFragment"),
 	InvalidDependenciesModuleWarning: () =>
 		require("../InvalidDependenciesModuleWarning"),
 	Module: () => require("../Module"),
@@ -188,6 +189,7 @@ module.exports = {
 	UnsupportedFeatureWarning: () => require("../UnsupportedFeatureWarning"),
 	"util/LazySet": () => require("../util/LazySet"),
 	UnhandledSchemeError: () => require("../UnhandledSchemeError"),
+	NodeStuffInWebError: () => require("../NodeStuffInWebError"),
 	WebpackError: () => require("../WebpackError"),
 
 	"util/registerExternalSerializer": () => {

package/lib/util/propertyAccess.js

@@ -6,6 +6,59 @@
 "use strict";
 
 const SAFE_IDENTIFIER = /^[_a-zA-Z$][_a-zA-Z$0-9]*$/;
+const RESERVED_IDENTIFER = new Set([
+	"break",
+	"case",
+	"catch",
+	"class",
+	"const",
+	"continue",
+	"debugger",
+	"default",
+	"delete",
+	"do",
+	"else",
+	"export",
+	"extends",
+	"finally",
+	"for",
+	"function",
+	"if",
+	"import",
+	"in",
+	"instanceof",
+	"new",
+	"return",
+	"super",
+	"switch",
+	"this",
+	"throw",
+	"try",
+	"typeof",
+	"var",
+	"void",
+	"while",
+	"with",
+	"enum",
+	// strict mode
+	"implements",
+	"interface",
+	"let",
+	"package",
+	"private",
+	"protected",
+	"public",
+	"static",
+	"yield",
+	"yield",
+	// module code
+	"await",
+	// skip future reserved keywords defined under ES1 till ES3
+	// additional
+	"null",
+	"true",
+	"false"
+]);
 
 const propertyAccess = (properties, start = 0) => {
 	let str = "";
@@ -13,7 +66,7 @@ const propertyAccess = (properties, start = 0) => {
 		const p = properties[i];
 		if (`${+p}` === p) {
 			str += `[${p}]`;
-		} else if (SAFE_IDENTIFIER.test(p)) {
+		} else if (SAFE_IDENTIFIER.test(p) && !RESERVED_IDENTIFER.has(p)) {
 			str += `.${p}`;
 		} else {
 			str += `[${JSON.stringify(p)}]`;

package/lib/util/serialization.js

@@ -111,9 +111,13 @@ module.exports = {
 						);
 					};
 					context.writeSeparate = (value, options) => {
-						context.write(
-							SerializerMiddleware.createLazy(value, fileMiddleware, options)
+						const lazy = SerializerMiddleware.createLazy(
+							value,
+							fileMiddleware,
+							options
 						);
+						context.write(lazy);
+						return lazy;
 					};
 				}
 			}),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "webpack",
-  "version": "5.51.1",
+  "version": "5.53.0",
   "author": "Tobias Koppers @sokra",
   "description": "Packs CommonJs/AMD modules for the browser. Allows to split your codebase into multiple bundles, which can be loaded on demand. Support loaders to preprocess files, i.e. json, jsx, es7, css, less, ... and your custom stuff.",
   "license": "MIT",
@@ -39,7 +39,7 @@
     "@babel/core": "^7.11.1",
     "@babel/preset-react": "^7.10.4",
     "@types/es-module-lexer": "^0.4.1",
-    "@types/jest": "^26.0.24",
+    "@types/jest": "^27.0.1",
     "@types/node": "^15.0.1",
     "babel-loader": "^8.1.0",
     "benchmark": "^2.1.4",
@@ -58,7 +58,7 @@
     "eslint-plugin-jest": "^24.3.6",
     "eslint-plugin-jsdoc": "^33.0.0",
     "eslint-plugin-node": "^11.0.0",
-    "eslint-plugin-prettier": "^3.1.4",
+    "eslint-plugin-prettier": "^4.0.0",
     "file-loader": "^6.0.0",
     "fork-ts-checker-webpack-plugin": "^6.0.5",
     "husky": "^6.0.0",
@@ -66,6 +66,7 @@
     "istanbul": "^0.4.5",
     "jest": "^27.0.6",
     "jest-circus": "^27.0.6",
+    "jest-cli": "^27.0.6",
     "jest-diff": "^27.0.2",
     "jest-junit": "^12.0.0",
     "json-loader": "^0.5.7",