webpack 5.5.1 → 5.9.0

package/lib/optimize/SideEffectsFlagPlugin.js

@@ -9,6 +9,7 @@ const glob2regexp = require("glob-to-regexp");
 const { STAGE_DEFAULT } = require("../OptimizationStages");
 const HarmonyExportImportedSpecifierDependency = require("../dependencies/HarmonyExportImportedSpecifierDependency");
 const HarmonyImportSpecifierDependency = require("../dependencies/HarmonyImportSpecifierDependency");
+const formatLocation = require("../formatLocation");
 
 /** @typedef {import("../Compiler")} Compiler */
 /** @typedef {import("../Dependency")} Dependency */
@@ -67,223 +68,242 @@ class SideEffectsFlagPlugin {
 			cache = new Map();
 			globToRegexpCache.set(compiler.root, cache);
 		}
-		compiler.hooks.normalModuleFactory.tap("SideEffectsFlagPlugin", nmf => {
-			nmf.hooks.module.tap("SideEffectsFlagPlugin", (module, data) => {
-				const resolveData = data.resourceResolveData;
-				if (
-					resolveData &&
-					resolveData.descriptionFileData &&
-					resolveData.relativePath
-				) {
-					const sideEffects = resolveData.descriptionFileData.sideEffects;
-					const hasSideEffects = SideEffectsFlagPlugin.moduleHasSideEffects(
-						resolveData.relativePath,
-						sideEffects,
-						cache
-					);
-					if (!hasSideEffects) {
-						if (module.factoryMeta === undefined) {
-							module.factoryMeta = {};
+		compiler.hooks.compilation.tap(
+			"SideEffectsFlagPlugin",
+			(compilation, { normalModuleFactory }) => {
+				const moduleGraph = compilation.moduleGraph;
+				normalModuleFactory.hooks.module.tap(
+					"SideEffectsFlagPlugin",
+					(module, data) => {
+						const resolveData = data.resourceResolveData;
+						if (
+							resolveData &&
+							resolveData.descriptionFileData &&
+							resolveData.relativePath
+						) {
+							const sideEffects = resolveData.descriptionFileData.sideEffects;
+							const hasSideEffects = SideEffectsFlagPlugin.moduleHasSideEffects(
+								resolveData.relativePath,
+								sideEffects,
+								cache
+							);
+							if (!hasSideEffects) {
+								if (module.factoryMeta === undefined) {
+									module.factoryMeta = {};
+								}
+								module.factoryMeta.sideEffectFree = true;
+							}
 						}
-						module.factoryMeta.sideEffectFree = true;
-					}
-				}
 
-				return module;
-			});
-			nmf.hooks.module.tap("SideEffectsFlagPlugin", (module, data) => {
-				if (data.settings.sideEffects === false) {
-					if (module.factoryMeta === undefined) {
-						module.factoryMeta = {};
-					}
-					module.factoryMeta.sideEffectFree = true;
-				} else if (data.settings.sideEffects === true) {
-					if (module.factoryMeta !== undefined) {
-						module.factoryMeta.sideEffectFree = false;
+						return module;
 					}
-				}
-				return module;
-			});
-			if (this._analyseSource) {
-				/**
-				 * @param {JavascriptParser} parser the parser
-				 * @returns {void}
-				 */
-				const parserHandler = parser => {
-					let hasSideEffects = false;
-					parser.hooks.program.tap("SideEffectsFlagPlugin", () => {
-						hasSideEffects = false;
-					});
-					parser.hooks.statement.tap(
-						{ name: "SideEffectsFlagPlugin", stage: -100 },
-						statement => {
-							if (hasSideEffects) return;
-							if (parser.scope.topLevelScope !== true) return;
-							switch (statement.type) {
-								case "ExpressionStatement":
-									if (
-										!parser.isPure(statement.expression, statement.range[0])
-									) {
-										hasSideEffects = true;
-									}
-									break;
-								case "IfStatement":
-								case "WhileStatement":
-								case "DoWhileStatement":
-									if (!parser.isPure(statement.test, statement.range[0])) {
-										hasSideEffects = true;
-									}
-									// statement hook will be called for child statements too
-									break;
-								case "ForStatement":
-									if (
-										!parser.isPure(statement.init, statement.range[0]) ||
-										!parser.isPure(
-											statement.test,
-											statement.init
-												? statement.init.range[1]
-												: statement.range[0]
-										) ||
-										!parser.isPure(
-											statement.update,
-											statement.test
-												? statement.test.range[1]
-												: statement.init
-												? statement.init.range[1]
-												: statement.range[0]
-										)
-									) {
-										hasSideEffects = true;
-									}
-									// statement hook will be called for child statements too
-									break;
-								case "SwitchStatement":
-									if (
-										!parser.isPure(statement.discriminant, statement.range[0])
-									) {
-										hasSideEffects = true;
-									}
-									// statement hook will be called for child statements too
-									break;
-								case "VariableDeclaration":
-								case "ClassDeclaration":
-								case "FunctionDeclaration":
-									if (!parser.isPure(statement, statement.range[0])) {
-										hasSideEffects = true;
-									}
-									break;
-								case "ExportDefaultDeclaration":
-									if (
-										!parser.isPure(statement.declaration, statement.range[0])
-									) {
-										hasSideEffects = true;
-									}
-									break;
-								case "ExportNamedDeclaration":
-									if (statement.source) {
-										hasSideEffects = true;
-									}
-									break;
-								case "LabeledStatement":
-								case "BlockStatement":
-									// statement hook will be called for child statements too
-									break;
-								case "EmptyStatement":
-									break;
-								case "ImportDeclaration":
-									// imports will be handled by the dependencies
-									break;
-								default:
-									hasSideEffects = true;
-									break;
+				);
+				normalModuleFactory.hooks.module.tap(
+					"SideEffectsFlagPlugin",
+					(module, data) => {
+						if (data.settings.sideEffects === false) {
+							if (module.factoryMeta === undefined) {
+								module.factoryMeta = {};
+							}
+							module.factoryMeta.sideEffectFree = true;
+						} else if (data.settings.sideEffects === true) {
+							if (module.factoryMeta !== undefined) {
+								module.factoryMeta.sideEffectFree = false;
 							}
 						}
-					);
-					parser.hooks.finish.tap("SideEffectsFlagPlugin", () => {
-						if (!hasSideEffects) {
-							parser.state.module.buildMeta.sideEffectFree = true;
-						}
-					});
-				};
-				for (const key of [
-					"javascript/auto",
-					"javascript/esm",
-					"javascript/dynamic"
-				]) {
-					nmf.hooks.parser.for(key).tap("SideEffectsFlagPlugin", parserHandler);
+						return module;
+					}
+				);
+				if (this._analyseSource) {
+					/**
+					 * @param {JavascriptParser} parser the parser
+					 * @returns {void}
+					 */
+					const parserHandler = parser => {
+						let sideEffectsStatement;
+						parser.hooks.program.tap("SideEffectsFlagPlugin", () => {
+							sideEffectsStatement = undefined;
+						});
+						parser.hooks.statement.tap(
+							{ name: "SideEffectsFlagPlugin", stage: -100 },
+							statement => {
+								if (sideEffectsStatement) return;
+								if (parser.scope.topLevelScope !== true) return;
+								switch (statement.type) {
+									case "ExpressionStatement":
+										if (
+											!parser.isPure(statement.expression, statement.range[0])
+										) {
+											sideEffectsStatement = statement;
+										}
+										break;
+									case "IfStatement":
+									case "WhileStatement":
+									case "DoWhileStatement":
+										if (!parser.isPure(statement.test, statement.range[0])) {
+											sideEffectsStatement = statement;
+										}
+										// statement hook will be called for child statements too
+										break;
+									case "ForStatement":
+										if (
+											!parser.isPure(statement.init, statement.range[0]) ||
+											!parser.isPure(
+												statement.test,
+												statement.init
+													? statement.init.range[1]
+													: statement.range[0]
+											) ||
+											!parser.isPure(
+												statement.update,
+												statement.test
+													? statement.test.range[1]
+													: statement.init
+													? statement.init.range[1]
+													: statement.range[0]
+											)
+										) {
+											sideEffectsStatement = statement;
+										}
+										// statement hook will be called for child statements too
+										break;
+									case "SwitchStatement":
+										if (
+											!parser.isPure(statement.discriminant, statement.range[0])
+										) {
+											sideEffectsStatement = statement;
+										}
+										// statement hook will be called for child statements too
+										break;
+									case "VariableDeclaration":
+									case "ClassDeclaration":
+									case "FunctionDeclaration":
+										if (!parser.isPure(statement, statement.range[0])) {
+											sideEffectsStatement = statement;
+										}
+										break;
+									case "ExportNamedDeclaration":
+									case "ExportDefaultDeclaration":
+										if (
+											!parser.isPure(statement.declaration, statement.range[0])
+										) {
+											sideEffectsStatement = statement;
+										}
+										break;
+									case "LabeledStatement":
+									case "BlockStatement":
+										// statement hook will be called for child statements too
+										break;
+									case "EmptyStatement":
+										break;
+									case "ExportAllDeclaration":
+									case "ImportDeclaration":
+										// imports will be handled by the dependencies
+										break;
+									default:
+										sideEffectsStatement = statement;
+										break;
+								}
+							}
+						);
+						parser.hooks.finish.tap("SideEffectsFlagPlugin", () => {
+							if (sideEffectsStatement === undefined) {
+								parser.state.module.buildMeta.sideEffectFree = true;
+							} else {
+								const { loc, type } = sideEffectsStatement;
+								moduleGraph
+									.getOptimizationBailout(parser.state.module)
+									.push(
+										() =>
+											`Statement (${type}) with side effects in source code at ${formatLocation(
+												loc
+											)}`
+									);
+							}
+						});
+					};
+					for (const key of [
+						"javascript/auto",
+						"javascript/esm",
+						"javascript/dynamic"
+					]) {
+						normalModuleFactory.hooks.parser
+							.for(key)
+							.tap("SideEffectsFlagPlugin", parserHandler);
+					}
 				}
-			}
-		});
-		compiler.hooks.compilation.tap("SideEffectsFlagPlugin", compilation => {
-			const moduleGraph = compilation.moduleGraph;
-			compilation.hooks.optimizeDependencies.tap(
-				{
-					name: "SideEffectsFlagPlugin",
-					stage: STAGE_DEFAULT
-				},
-				modules => {
-					const logger = compilation.getLogger("webpack.SideEffectsFlagPlugin");
+				compilation.hooks.optimizeDependencies.tap(
+					{
+						name: "SideEffectsFlagPlugin",
+						stage: STAGE_DEFAULT
+					},
+					modules => {
+						const logger = compilation.getLogger(
+							"webpack.SideEffectsFlagPlugin"
+						);
 
-					logger.time("update dependencies");
-					for (const module of modules) {
-						if (module.getSideEffectsConnectionState(moduleGraph) === false) {
-							const exportsInfo = moduleGraph.getExportsInfo(module);
-							for (const connection of moduleGraph.getIncomingConnections(
-								module
-							)) {
-								const dep = connection.dependency;
-								let isReexport;
-								if (
-									(isReexport =
-										dep instanceof HarmonyExportImportedSpecifierDependency) ||
-									(dep instanceof HarmonyImportSpecifierDependency &&
-										!dep.namespaceObjectAsContext)
-								) {
-									// TODO improve for export *
-									if (isReexport && dep.name) {
-										const exportInfo = moduleGraph.getExportInfo(
-											connection.originModule,
-											dep.name
-										);
-										exportInfo.moveTarget(
-											moduleGraph,
-											({ module }) =>
-												module.getSideEffectsConnectionState(moduleGraph) ===
-												false
-										);
-									}
-									// TODO improve for nested imports
-									const ids = dep.getIds(moduleGraph);
-									if (ids.length > 0) {
-										const exportInfo = exportsInfo.getExportInfo(ids[0]);
-										const target = exportInfo.moveTarget(
-											moduleGraph,
-											({ module }) =>
-												module.getSideEffectsConnectionState(moduleGraph) ===
-												false
-										);
-										if (!target) continue;
+						logger.time("update dependencies");
+						for (const module of modules) {
+							if (module.getSideEffectsConnectionState(moduleGraph) === false) {
+								const exportsInfo = moduleGraph.getExportsInfo(module);
+								for (const connection of moduleGraph.getIncomingConnections(
+									module
+								)) {
+									const dep = connection.dependency;
+									let isReexport;
+									if (
+										(isReexport =
+											dep instanceof
+											HarmonyExportImportedSpecifierDependency) ||
+										(dep instanceof HarmonyImportSpecifierDependency &&
+											!dep.namespaceObjectAsContext)
+									) {
+										// TODO improve for export *
+										if (isReexport && dep.name) {
+											const exportInfo = moduleGraph.getExportInfo(
+												connection.originModule,
+												dep.name
+											);
+											exportInfo.moveTarget(
+												moduleGraph,
+												({ module }) =>
+													module.getSideEffectsConnectionState(moduleGraph) ===
+													false
+											);
+										}
+										// TODO improve for nested imports
+										const ids = dep.getIds(moduleGraph);
+										if (ids.length > 0) {
+											const exportInfo = exportsInfo.getExportInfo(ids[0]);
+											const target = exportInfo.moveTarget(
+												moduleGraph,
+												({ module }) =>
+													module.getSideEffectsConnectionState(moduleGraph) ===
+													false
+											);
+											if (!target) continue;
 
-										moduleGraph.updateModule(dep, target.module);
-										moduleGraph.addExplanation(
-											dep,
-											"(skipped side-effect-free modules)"
-										);
-										dep.setIds(
-											moduleGraph,
-											target.export
-												? [...target.export, ...ids.slice(1)]
-												: ids.slice(1)
-										);
+											moduleGraph.updateModule(dep, target.module);
+											moduleGraph.addExplanation(
+												dep,
+												"(skipped side-effect-free modules)"
+											);
+											dep.setIds(
+												moduleGraph,
+												target.export
+													? [...target.export, ...ids.slice(1)]
+													: ids.slice(1)
+											);
+										}
 									}
 								}
 							}
 						}
+						logger.timeEnd("update dependencies");
 					}
-					logger.timeEnd("update dependencies");
-				}
-			);
-		});
+				);
+			}
+		);
 	}
 
 	static moduleHasSideEffects(moduleName, flagValue, cache) {

package/lib/optimize/SplitChunksPlugin.js

@@ -26,7 +26,6 @@ const MinMaxSizeWarning = require("./MinMaxSizeWarning");
 /** @typedef {import("../../declarations/WebpackOptions").OptimizationSplitChunksOptions} OptimizationSplitChunksOptions */
 /** @typedef {import("../../declarations/WebpackOptions").OptimizationSplitChunksSizes} OptimizationSplitChunksSizes */
 /** @typedef {import("../../declarations/WebpackOptions").Output} OutputOptions */
-/** @typedef {import("../Chunk")} Chunk */
 /** @typedef {import("../ChunkGraph")} ChunkGraph */
 /** @typedef {import("../ChunkGroup")} ChunkGroup */
 /** @typedef {import("../Compilation").AssetInfo} AssetInfo */

package/lib/runtime/GetMainFilenameRuntimeModule.js

@@ -26,12 +26,14 @@ class GetMainFilenameRuntimeModule extends RuntimeModule {
 	 * @returns {string} runtime code
 	 */
 	generate() {
-		const { global, filename, compilation } = this;
+		const { global, filename, compilation, chunk } = this;
 		const { runtimeTemplate } = compilation;
 		const url = compilation.getPath(JSON.stringify(filename), {
 			hash: `" + ${RuntimeGlobals.getFullHash}() + "`,
 			hashWithLength: length =>
-				`" + ${RuntimeGlobals.getFullHash}().slice(0, ${length}) + "`
+				`" + ${RuntimeGlobals.getFullHash}().slice(0, ${length}) + "`,
+			chunk,
+			runtime: chunk.runtime
 		});
 		return Template.asString([
 			`${global} = ${runtimeTemplate.returningFunction(url)};`

package/lib/runtime/LoadScriptRuntimeModule.js

@@ -11,7 +11,6 @@ const Template = require("../Template");
 const HelperRuntimeModule = require("./HelperRuntimeModule");
 
 /** @typedef {import("../Chunk")} Chunk */
-/** @typedef {import("../Compilation")} Compilation */
 /** @typedef {import("../Compiler")} Compiler */
 
 /**

package/lib/serialization/FileMiddleware.js

@@ -233,7 +233,8 @@ class FileMiddleware extends SerializerMiddleware {
 	 * @param {Object} context context object
 	 * @returns {SerializedType|Promise<SerializedType>} serialized data
 	 */
-	serialize(data, { filename, extension = "" }) {
+	serialize(data, context) {
+		const { filename, extension = "" } = context;
 		return new Promise((resolve, reject) => {
 			mkdirp(this.fs, dirname(this.fs, filename), err => {
 				if (err) return reject(err);
@@ -301,7 +302,8 @@ class FileMiddleware extends SerializerMiddleware {
 	 * @param {Object} context context object
 	 * @returns {DeserializedType|Promise<DeserializedType>} deserialized data
 	 */
-	deserialize(data, { filename, extension = "" }) {
+	deserialize(data, context) {
+		const { filename, extension = "" } = context;
 		const readFile = name =>
 			new Promise((resolve, reject) => {
 				const file = name

package/lib/util/runtime.js

@@ -485,6 +485,10 @@ class RuntimeSpecSet {
 		this._map.set(getRuntimeKey(runtime), runtime);
 	}
 
+	has(runtime) {
+		return this._map.has(getRuntimeKey(runtime));
+	}
+
 	[Symbol.iterator]() {
 		return this._map.values();
 	}

package/lib/wasm-async/AsyncWebAssemblyModulesPlugin.js

@@ -17,7 +17,6 @@ const memorize = require("../util/memorize");
 /** @typedef {import("../Chunk")} Chunk */
 /** @typedef {import("../ChunkGraph")} ChunkGraph */
 /** @typedef {import("../CodeGenerationResults")} CodeGenerationResults */
-/** @typedef {import("../Compilation")} Compilation */
 /** @typedef {import("../Compiler")} Compiler */
 /** @typedef {import("../DependencyTemplates")} DependencyTemplates */
 /** @typedef {import("../Module")} Module */

package/lib/webpack.js

@@ -19,9 +19,7 @@ const NodeEnvironmentPlugin = require("./node/NodeEnvironmentPlugin");
 const validateSchema = require("./validateSchema");
 
 /** @typedef {import("../declarations/WebpackOptions").WebpackOptions} WebpackOptions */
-/** @typedef {import("./Compiler")} Compiler */
 /** @typedef {import("./Compiler").WatchOptions} WatchOptions */
-/** @typedef {import("./MultiCompiler")} MultiCompiler */
 /** @typedef {import("./MultiStats")} MultiStats */
 /** @typedef {import("./Stats")} Stats */
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "webpack",
-  "version": "5.5.1",
+  "version": "5.9.0",
   "author": "Tobias Koppers @sokra",
   "description": "Packs CommonJs/AMD modules for the browser. Allows to split your codebase into multiple bundles, which can be loaded on demand. Support loaders to preprocess files, i.e. json, jsx, es7, css, less, ... and your custom stuff.",
   "license": "MIT",
@@ -25,7 +25,7 @@
     "neo-async": "^2.6.2",
     "pkg-dir": "^4.2.0",
     "schema-utils": "^3.0.0",
-    "tapable": "^2.0.0",
+    "tapable": "^2.1.1",
     "terser-webpack-plugin": "^5.0.3",
     "watchpack": "^2.0.0",
     "webpack-sources": "^2.1.1"
@@ -38,8 +38,8 @@
   "devDependencies": {
     "@babel/core": "^7.11.1",
     "@babel/preset-react": "^7.10.4",
-    "@types/jest": "^25.2.3",
-    "@types/node": "^13.13.15",
+    "@types/jest": "^26.0.15",
+    "@types/node": "^14.14.10",
     "babel-loader": "^8.1.0",
     "benchmark": "^2.1.4",
     "bundle-loader": "^0.5.6",
@@ -52,10 +52,10 @@
     "date-fns": "^2.15.0",
     "es5-ext": "^0.10.53",
     "es6-promise-polyfill": "^1.2.0",
-    "eslint": "^6.8.0",
+    "eslint": "^7.14.0",
     "eslint-config-prettier": "^6.11.0",
-    "eslint-plugin-jest": "^23.20.0",
-    "eslint-plugin-jsdoc": "^22.0.0",
+    "eslint-plugin-jest": "^24.1.3",
+    "eslint-plugin-jsdoc": "^30.7.8",
     "eslint-plugin-node": "^11.0.0",
     "eslint-plugin-prettier": "^3.1.4",
     "file-loader": "^6.0.0",
@@ -63,9 +63,9 @@
     "husky": "^4.2.5",
     "is-ci": "^2.0.0",
     "istanbul": "^0.4.5",
-    "jest": "^25.1.0",
-    "jest-diff": "^25.1.0",
-    "jest-junit": "^11.1.0",
+    "jest": "^26.6.3",
+    "jest-diff": "^26.6.2",
+    "jest-junit": "^12.0.0",
     "json-loader": "^0.5.7",
     "json5": "^2.1.3",
     "less": "^3.12.2",
@@ -78,7 +78,7 @@
     "mini-css-extract-plugin": "^1.0.0",
     "mini-svg-data-uri": "^1.2.3",
     "open-cli": "^6.0.1",
-    "prettier": "^2.0.5",
+    "prettier": "^2.2.0",
     "pretty-format": "^26.3.0",
     "pug": "^3.0.0",
     "pug-loader": "^2.4.0",
@@ -90,9 +90,9 @@
     "simple-git": "^2.17.0",
     "strip-ansi": "^6.0.0",
     "style-loader": "^1.1.4",
-    "terser": "^4.8.0",
+    "terser": "^5.5.0",
     "toml": "^3.0.0",
-    "tooling": "webpack/tooling#v1.8.1",
+    "tooling": "webpack/tooling#v1.10.0",
     "ts-loader": "^8.0.2",
     "typescript": "^3.9.7",
     "url-loader": "^4.1.0",
@@ -100,7 +100,7 @@
     "webassembly-feature": "1.3.0",
     "xxhashjs": "^0.2.2",
     "yamljs": "^0.3.0",
-    "yarn-deduplicate": "^2.1.1"
+    "yarn-deduplicate": "^3.1.0"
   },
   "engines": {
     "node": ">=10.13.0"