webpack 5.45.0 → 5.47.1

package/lib/NormalModule.js

@@ -293,13 +293,9 @@ class NormalModule extends Module {
 	 */
 	identifier() {
 		if (this.layer === null) {
-			if (this.type === "javascript/auto") {
-				return this.request;
-			} else {
-				return `${this.type}|${this.request}`;
-			}
+			return this.request;
 		} else {
-			return `${this.type}|${this.request}|${this.layer}`;
+			return `${this.request}|${this.layer}`;
 		}
 	}
 
@@ -354,18 +350,20 @@ class NormalModule extends Module {
 		this.resource = m.resource;
 		this.matchResource = m.matchResource;
 		this.loaders = m.loaders;
-		this._sourceTypes = m._sourceTypes;
-		this._sourceSizes = m._sourceSizes;
 	}
 
 	/**
 	 * Assuming this module is in the cache. Remove internal references to allow freeing some memory.
 	 */
 	cleanupForCache() {
-		// Make sure to cache types and sizes before cleanup
-		if (this._sourceTypes === undefined) this.getSourceTypes();
-		for (const type of this._sourceTypes) {
-			this.size(type);
+		// Make sure to cache types and sizes before cleanup when this module has been built
+		// They are accessed by the stats and we don't want them to crash after cleanup
+		// TODO reconsider this for webpack 6
+		if (this.buildInfo) {
+			if (this._sourceTypes === undefined) this.getSourceTypes();
+			for (const type of this._sourceTypes) {
+				this.size(type);
+			}
 		}
 		super.cleanupForCache();
 		this.parser = undefined;

package/lib/NormalModuleFactory.js

@@ -20,7 +20,7 @@ const ModuleGraph = require("./ModuleGraph");
 const NormalModule = require("./NormalModule");
 const BasicEffectRulePlugin = require("./rules/BasicEffectRulePlugin");
 const BasicMatcherRulePlugin = require("./rules/BasicMatcherRulePlugin");
-const ObjectMatcherRulePlugin = require("./rules/ObjectMatcherRulePlugin");
+const DescriptionDataMatcherRulePlugin = require("./rules/DescriptionDataMatcherRulePlugin");
 const RuleSetCompiler = require("./rules/RuleSetCompiler");
 const UseEffectRulePlugin = require("./rules/UseEffectRulePlugin");
 const LazySet = require("./util/LazySet");
@@ -44,7 +44,6 @@ const { parseResource } = require("./util/identifier");
  * @property {ModuleFactoryCreateData["resolveOptions"]} resolveOptions
  * @property {string} context
  * @property {string} request
- * @property {Record<string, any> | undefined} assertions
  * @property {ModuleDependency[]} dependencies
  * @property {Object} createData
  * @property {LazySet<string>} fileDependencies
@@ -183,8 +182,7 @@ const ruleSetCompiler = new RuleSetCompiler([
 	new BasicMatcherRulePlugin("issuer"),
 	new BasicMatcherRulePlugin("compiler"),
 	new BasicMatcherRulePlugin("issuerLayer"),
-	new ObjectMatcherRulePlugin("assert", "assertions"),
-	new ObjectMatcherRulePlugin("descriptionData"),
+	new DescriptionDataMatcherRulePlugin(),
 	new BasicEffectRulePlugin("type"),
 	new BasicEffectRulePlugin("sideEffects"),
 	new BasicEffectRulePlugin("parser"),
@@ -341,7 +339,6 @@ class NormalModuleFactory extends ModuleFactory {
 					context,
 					dependencies,
 					request,
-					assertions,
 					resolveOptions,
 					fileDependencies,
 					missingDependencies,
@@ -450,7 +447,6 @@ class NormalModuleFactory extends ModuleFactory {
 						resourceQuery: resourceDataForRules.query,
 						resourceFragment: resourceDataForRules.fragment,
 						scheme,
-						assertions,
 						mimetype: matchResourceData ? "" : resourceData.data.mimetype || "",
 						dependency: dependencyType,
 						descriptionData: matchResourceData
@@ -698,7 +694,6 @@ class NormalModuleFactory extends ModuleFactory {
 		const resolveOptions = data.resolveOptions || EMPTY_RESOLVE_OPTIONS;
 		const dependency = dependencies[0];
 		const request = dependency.request;
-		const assertions = dependency.assertions;
 		const contextInfo = data.contextInfo;
 		const fileDependencies = new LazySet();
 		const missingDependencies = new LazySet();
@@ -709,7 +704,6 @@ class NormalModuleFactory extends ModuleFactory {
 			resolveOptions,
 			context,
 			request,
-			assertions,
 			dependencies,
 			fileDependencies,
 			missingDependencies,

package/lib/Template.js

@@ -350,7 +350,7 @@ class Template {
 
 	/**
 	 * @param {RuntimeModule[]} runtimeModules array of runtime modules in order
-	 * @param {RenderContext & { codeGenerationResults?: CodeGenerationResults, useStrict?: boolean }} renderContext render context
+	 * @param {RenderContext & { codeGenerationResults?: CodeGenerationResults }} renderContext render context
 	 * @returns {Source} rendered runtime modules in a Source object
 	 */
 	static renderRuntimeModules(runtimeModules, renderContext) {
@@ -382,12 +382,10 @@ class Template {
 					source.add("\n\n");
 				} else if (renderContext.runtimeTemplate.supportsArrowFunction()) {
 					source.add("(() => {\n");
-					if (renderContext.useStrict) source.add('\t"use strict";\n');
 					source.add(new PrefixSource("\t", runtimeSource));
 					source.add("\n})();\n\n");
 				} else {
 					source.add("!function() {\n");
-					if (renderContext.useStrict) source.add('\t"use strict";\n');
 					source.add(new PrefixSource("\t", runtimeSource));
 					source.add("\n}();\n\n");
 				}
@@ -406,7 +404,6 @@ class Template {
 			"/******/ ",
 			new ConcatSource(
 				"function(__webpack_require__) { // webpackRuntimeModules\n",
-				'"use strict";\n\n',
 				this.renderRuntimeModules(runtimeModules, renderContext),
 				"}\n"
 			)

package/lib/asset/AssetGenerator.js

@@ -141,7 +141,9 @@ class AssetGenerator extends Generator {
 								module.resourceResolveData &&
 								module.resourceResolveData.mimetype !== undefined
 							) {
-								mimeType = module.resourceResolveData.mimetype;
+								mimeType =
+									module.resourceResolveData.mimetype +
+									module.resourceResolveData.parameters;
 							} else if (ext) {
 								mimeType = mimeTypes.lookup(ext);
 							}
@@ -156,22 +158,33 @@ class AssetGenerator extends Generator {
 						}
 
 						let encodedContent;
-						switch (encoding) {
-							case "base64": {
-								encodedContent = originalSource.buffer().toString("base64");
-								break;
-							}
-							case false: {
-								const content = originalSource.source();
-								if (typeof content === "string") {
-									encodedContent = encodeURI(content);
-								} else {
-									encodedContent = encodeURI(content.toString("utf-8"));
+						if (
+							module.resourceResolveData &&
+							module.resourceResolveData.encoding === encoding
+						) {
+							encodedContent = module.resourceResolveData.encodedContent;
+						} else {
+							switch (encoding) {
+								case "base64": {
+									encodedContent = originalSource.buffer().toString("base64");
+									break;
+								}
+								case false: {
+									const content = originalSource.source();
+
+									if (typeof content !== "string") {
+										encodedContent = content.toString("utf-8");
+									}
+
+									encodedContent = encodeURIComponent(encodedContent).replace(
+										/[!'()*]/g,
+										character => "%" + character.codePointAt(0).toString(16)
+									);
+									break;
 								}
-								break;
+								default:
+									throw new Error(`Unsupported encoding '${encoding}'`);
 							}
-							default:
-								throw new Error(`Unsupported encoding '${encoding}'`);
 						}
 
 						encodedSource = `data:${mimeType}${
@@ -216,7 +229,7 @@ class AssetGenerator extends Generator {
 							}
 						);
 					let publicPath;
-					if (this.publicPath) {
+					if (this.publicPath !== undefined) {
 						const { path, info } =
 							runtimeTemplate.compilation.getAssetPathWithInfo(
 								this.publicPath,

package/lib/asset/AssetModulesPlugin.js

@@ -172,24 +172,29 @@ class AssetModulesPlugin {
 					);
 					if (modules) {
 						for (const module of modules) {
-							const codeGenResult = codeGenerationResults.get(
-								module,
-								chunk.runtime
-							);
-							result.push({
-								render: () => codeGenResult.sources.get(type),
-								filename:
-									module.buildInfo.filename ||
-									codeGenResult.data.get("filename"),
-								info:
-									module.buildInfo.assetInfo ||
-									codeGenResult.data.get("assetInfo"),
-								auxiliary: true,
-								identifier: `assetModule${chunkGraph.getModuleId(module)}`,
-								hash:
-									module.buildInfo.fullContentHash ||
-									codeGenResult.data.get("fullContentHash")
-							});
+							try {
+								const codeGenResult = codeGenerationResults.get(
+									module,
+									chunk.runtime
+								);
+								result.push({
+									render: () => codeGenResult.sources.get(type),
+									filename:
+										module.buildInfo.filename ||
+										codeGenResult.data.get("filename"),
+									info:
+										module.buildInfo.assetInfo ||
+										codeGenResult.data.get("assetInfo"),
+									auxiliary: true,
+									identifier: `assetModule${chunkGraph.getModuleId(module)}`,
+									hash:
+										module.buildInfo.fullContentHash ||
+										codeGenResult.data.get("fullContentHash")
+								});
+							} catch (e) {
+								e.message += `\nduring rendering of asset ${module.identifier()}`;
+								throw e;
+							}
 						}
 					}
 

package/lib/config/defaults.js

@@ -482,6 +482,18 @@ const applyModuleDefaults = (
 					or: ["text/javascript", "application/javascript"]
 				},
 				...esm
+			},
+			{
+				dependency: "url",
+				oneOf: [
+					{
+						scheme: /^data$/,
+						type: "asset/inline"
+					},
+					{
+						type: "asset/resource"
+					}
+				]
 			}
 		];
 		if (asyncWebAssembly) {
@@ -529,24 +541,6 @@ const applyModuleDefaults = (
 				...wasm
 			});
 		}
-		rules.push(
-			{
-				dependency: "url",
-				oneOf: [
-					{
-						scheme: /^data$/,
-						type: "asset/inline"
-					},
-					{
-						type: "asset/resource"
-					}
-				]
-			},
-			{
-				assert: { type: "json" },
-				type: "json"
-			}
-		);
 		return rules;
 	});
 };

package/lib/dependencies/AMDRequireDependency.js

@@ -123,10 +123,7 @@ AMDRequireDependency.Template = class AMDRequireDependencyTemplate extends (
 
 			source.replace(dep.outerRange[0], dep.arrayRange[0] - 1, startBlock);
 
-			source.insert(
-				dep.arrayRange[0] + 0.9,
-				"var __WEBPACK_AMD_REQUIRE_ARRAY__ = "
-			);
+			source.insert(dep.arrayRange[0], "var __WEBPACK_AMD_REQUIRE_ARRAY__ = ");
 
 			source.replace(dep.arrayRange[1], dep.functionRange[0] - 1, "; (");
 
@@ -160,10 +157,7 @@ AMDRequireDependency.Template = class AMDRequireDependencyTemplate extends (
 
 			source.replace(dep.outerRange[0], dep.arrayRange[0] - 1, startBlock);
 
-			source.insert(
-				dep.arrayRange[0] + 0.9,
-				"var __WEBPACK_AMD_REQUIRE_ARRAY__ = "
-			);
+			source.insert(dep.arrayRange[0], "var __WEBPACK_AMD_REQUIRE_ARRAY__ = ");
 
 			source.replace(dep.arrayRange[1], dep.functionRange[0] - 1, "; (");
 

package/lib/dependencies/HarmonyExportDependencyParserPlugin.js

@@ -12,8 +12,7 @@ const HarmonyExportHeaderDependency = require("./HarmonyExportHeaderDependency")
 const HarmonyExportImportedSpecifierDependency = require("./HarmonyExportImportedSpecifierDependency");
 const HarmonyExportSpecifierDependency = require("./HarmonyExportSpecifierDependency");
 const {
-	harmonySpecifierTag,
-	getAssertions
+	harmonySpecifierTag
 } = require("./HarmonyImportDependencyParserPlugin");
 const HarmonyImportSideEffectDependency = require("./HarmonyImportSideEffectDependency");
 
@@ -49,8 +48,7 @@ module.exports = class HarmonyExportDependencyParserPlugin {
 				parser.state.module.addPresentationalDependency(clearDep);
 				const sideEffectDep = new HarmonyImportSideEffectDependency(
 					source,
-					parser.state.lastHarmonyImportOrder,
-					getAssertions(statement)
+					parser.state.lastHarmonyImportOrder
 				);
 				sideEffectDep.loc = Object.create(statement.loc);
 				sideEffectDep.loc.index = -1;
@@ -129,8 +127,7 @@ module.exports = class HarmonyExportDependencyParserPlugin {
 						harmonyNamedExports,
 						null,
 						this.strictExportPresence,
-						null,
-						settings.assertions
+						null
 					);
 				} else {
 					dep = new HarmonyExportSpecifierDependency(id, name);

package/lib/dependencies/HarmonyExportImportedSpecifierDependency.js

@@ -159,7 +159,6 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 	 * @param {ReadonlyArray<HarmonyExportImportedSpecifierDependency> | Iterable<HarmonyExportImportedSpecifierDependency>} otherStarExports other star exports in the module before this import
 	 * @param {boolean} strictExportPresence when true, missing exports in the imported module lead to errors instead of warnings
 	 * @param {HarmonyStarExportsList} allStarExports all star exports in the module
-	 * @param {Record<string, any>=} assertions import assertions
 	 */
 	constructor(
 		request,
@@ -169,10 +168,9 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 		activeExports,
 		otherStarExports,
 		strictExportPresence,
-		allStarExports,
-		assertions
+		allStarExports
 	) {
-		super(request, sourceOrder, assertions);
+		super(request, sourceOrder);
 
 		this.ids = ids;
 		this.name = name;

package/lib/dependencies/HarmonyImportDependency.js

@@ -32,12 +32,10 @@ class HarmonyImportDependency extends ModuleDependency {
 	 *
 	 * @param {string} request request string
 	 * @param {number} sourceOrder source order
-	 * @param {Record<string, any>=} assertions import assertions
 	 */
-	constructor(request, sourceOrder, assertions) {
+	constructor(request, sourceOrder) {
 		super(request);
 		this.sourceOrder = sourceOrder;
-		this.assertions = assertions;
 	}
 
 	get category() {
@@ -203,14 +201,12 @@ class HarmonyImportDependency extends ModuleDependency {
 	serialize(context) {
 		const { write } = context;
 		write(this.sourceOrder);
-		write(this.assertions);
 		super.serialize(context);
 	}
 
 	deserialize(context) {
 		const { read } = context;
 		this.sourceOrder = read();
-		this.assertions = read();
 		super.deserialize(context);
 	}
 }

package/lib/dependencies/HarmonyImportDependencyParserPlugin.js

@@ -14,11 +14,7 @@ const HarmonyExports = require("./HarmonyExports");
 const HarmonyImportSideEffectDependency = require("./HarmonyImportSideEffectDependency");
 const HarmonyImportSpecifierDependency = require("./HarmonyImportSpecifierDependency");
 
-/** @typedef {import("estree").ExportAllDeclaration} ExportAllDeclaration */
-/** @typedef {import("estree").ExportNamedDeclaration} ExportNamedDeclaration */
 /** @typedef {import("estree").Identifier} Identifier */
-/** @typedef {import("estree").ImportDeclaration} ImportDeclaration */
-/** @typedef {import("estree").ImportExpression} ImportExpression */
 /** @typedef {import("../javascript/JavascriptParser")} JavascriptParser */
 /** @typedef {import("../optimize/InnerGraph").InnerGraph} InnerGraph */
 /** @typedef {import("../optimize/InnerGraph").TopLevelSymbol} TopLevelSymbol */
@@ -33,32 +29,8 @@ const harmonySpecifierTag = Symbol("harmony import");
  * @property {number} sourceOrder
  * @property {string} name
  * @property {boolean} await
- * @property {Record<string, any> | undefined} assertions
  */
 
-/**
- * @param {ImportDeclaration | ExportNamedDeclaration | ExportAllDeclaration | ImportExpression} node node with assertions
- * @returns {Record<string, any> | undefined} assertions
- */
-function getAssertions(node) {
-	// TODO remove cast when @types/estree has been updated to import assertions
-	const assertions = /** @type {{ assertions?: ImportAttributeNode[] }} */ (
-		node
-	).assertions;
-	if (assertions === undefined) {
-		return undefined;
-	}
-	const result = {};
-	for (const assertion of assertions) {
-		const key =
-			assertion.key.type === "Identifier"
-				? assertion.key.name
-				: assertion.key.value;
-		result[key] = assertion.value.value;
-	}
-	return result;
-}
-
 module.exports = class HarmonyImportDependencyParserPlugin {
 	constructor(options) {
 		this.strictExportPresence = options.strictExportPresence;
@@ -93,11 +65,9 @@ module.exports = class HarmonyImportDependencyParserPlugin {
 				clearDep.loc = statement.loc;
 				parser.state.module.addPresentationalDependency(clearDep);
 				parser.unsetAsiPosition(statement.range[1]);
-				const assertions = getAssertions(statement);
 				const sideEffectDep = new HarmonyImportSideEffectDependency(
 					source,
-					parser.state.lastHarmonyImportOrder,
-					assertions
+					parser.state.lastHarmonyImportOrder
 				);
 				sideEffectDep.loc = statement.loc;
 				parser.state.module.addDependency(sideEffectDep);
@@ -112,8 +82,7 @@ module.exports = class HarmonyImportDependencyParserPlugin {
 					name,
 					source,
 					ids,
-					sourceOrder: parser.state.lastHarmonyImportOrder,
-					assertions: getAssertions(statement)
+					sourceOrder: parser.state.lastHarmonyImportOrder
 				});
 				return true;
 			}
@@ -128,8 +97,7 @@ module.exports = class HarmonyImportDependencyParserPlugin {
 					settings.ids,
 					settings.name,
 					expr.range,
-					this.strictExportPresence,
-					settings.assertions
+					this.strictExportPresence
 				);
 				dep.shorthand = parser.scope.inShorthand;
 				dep.directImport = true;
@@ -150,8 +118,7 @@ module.exports = class HarmonyImportDependencyParserPlugin {
 					ids,
 					settings.name,
 					expr.range,
-					this.strictExportPresence,
-					settings.assertions
+					this.strictExportPresence
 				);
 				dep.asiSafe = !parser.isAsiPosition(expr.range[0]);
 				dep.loc = expr.loc;
@@ -171,8 +138,7 @@ module.exports = class HarmonyImportDependencyParserPlugin {
 					ids,
 					settings.name,
 					callee.range,
-					this.strictExportPresence,
-					settings.assertions
+					this.strictExportPresence
 				);
 				dep.directImport = members.length === 0;
 				dep.call = true;
@@ -240,4 +206,3 @@ module.exports = class HarmonyImportDependencyParserPlugin {
 };
 
 module.exports.harmonySpecifierTag = harmonySpecifierTag;
-module.exports.getAssertions = getAssertions;

package/lib/dependencies/HarmonyImportSideEffectDependency.js

@@ -20,8 +20,8 @@ const HarmonyImportDependency = require("./HarmonyImportDependency");
 /** @typedef {import("../util/runtime").RuntimeSpec} RuntimeSpec */
 
 class HarmonyImportSideEffectDependency extends HarmonyImportDependency {
-	constructor(request, sourceOrder, assertions) {
-		super(request, sourceOrder, assertions);
+	constructor(request, sourceOrder) {
+		super(request, sourceOrder);
 	}
 
 	get type() {

package/lib/dependencies/HarmonyImportSpecifierDependency.js

@@ -29,16 +29,8 @@ const HarmonyImportDependency = require("./HarmonyImportDependency");
 const idsSymbol = Symbol("HarmonyImportSpecifierDependency.ids");
 
 class HarmonyImportSpecifierDependency extends HarmonyImportDependency {
-	constructor(
-		request,
-		sourceOrder,
-		ids,
-		name,
-		range,
-		strictExportPresence,
-		assertions
-	) {
-		super(request, sourceOrder, assertions);
+	constructor(request, sourceOrder, ids, name, range, strictExportPresence) {
+		super(request, sourceOrder);
 		this.ids = ids;
 		this.name = name;
 		this.range = range;

package/lib/dependencies/ModuleDependency.js

@@ -22,20 +22,13 @@ class ModuleDependency extends Dependency {
 		this.request = request;
 		this.userRequest = request;
 		this.range = undefined;
-		// assertions must be serialized by subclasses that use it
-		/** @type {Record<string, any> | undefined} */
-		this.assertions = undefined;
 	}
 
 	/**
 	 * @returns {string | null} an identifier to merge equal requests
 	 */
 	getResourceIdentifier() {
-		let str = `module${this.request}`;
-		if (this.assertions !== undefined) {
-			str += JSON.stringify(this.assertions);
-		}
-		return str;
+		return `module${this.request}`;
 	}
 
 	/**