webpack 5.39.0 → 5.41.1

package/lib/serialization/BinaryMiddleware.js

@@ -165,12 +165,23 @@ class BinaryMiddleware extends SerializerMiddleware {
 		};
 		const flush = () => {
 			if (currentBuffer !== null) {
-				buffers.push(currentBuffer.slice(0, currentPosition));
+				buffers.push(
+					Buffer.from(
+						currentBuffer.buffer,
+						currentBuffer.byteOffset,
+						currentPosition
+					)
+				);
 				if (
 					!leftOverBuffer ||
 					leftOverBuffer.length < currentBuffer.length - currentPosition
-				)
-					leftOverBuffer = currentBuffer.slice(currentPosition);
+				) {
+					leftOverBuffer = Buffer.from(
+						currentBuffer.buffer,
+						currentBuffer.byteOffset + currentPosition,
+						currentBuffer.byteLength - currentPosition
+					);
+				}
 				currentBuffer = null;
 				buffersTotalLength += currentPosition;
 				currentPosition = 0;
@@ -554,10 +565,8 @@ class BinaryMiddleware extends SerializerMiddleware {
 			if (rem < n) {
 				return Buffer.concat([read(rem), read(n - rem)]);
 			}
-			const res = /** @type {Buffer} */ (currentBuffer).slice(
-				currentPosition,
-				currentPosition + n
-			);
+			const b = /** @type {Buffer} */ (currentBuffer);
+			const res = Buffer.from(b.buffer, b.byteOffset + currentPosition, n);
 			currentPosition += n;
 			checkOverflow();
 			return res;
@@ -579,10 +588,8 @@ class BinaryMiddleware extends SerializerMiddleware {
 			if (rem < n) {
 				n = rem;
 			}
-			const res = /** @type {Buffer} */ (currentBuffer).slice(
-				currentPosition,
-				currentPosition + n
-			);
+			const b = /** @type {Buffer} */ (currentBuffer);
+			const res = Buffer.from(b.buffer, b.byteOffset + currentPosition, n);
 			currentPosition += n;
 			checkOverflow();
 			return res;
@@ -735,7 +742,7 @@ class BinaryMiddleware extends SerializerMiddleware {
 				case STRING_HEADER:
 					return () => {
 						const len = readU32();
-						if (isInCurrentBuffer(len)) {
+						if (isInCurrentBuffer(len) && currentPosition + len < 0x7fffffff) {
 							result.push(
 								currentBuffer.toString(
 									undefined,
@@ -753,7 +760,7 @@ class BinaryMiddleware extends SerializerMiddleware {
 					return () => result.push("");
 				case SHORT_STRING_HEADER | 1:
 					return () => {
-						if (currentIsBuffer) {
+						if (currentIsBuffer && currentPosition < 0x7ffffffe) {
 							result.push(
 								currentBuffer.toString(
 									"latin1",
@@ -785,7 +792,10 @@ class BinaryMiddleware extends SerializerMiddleware {
 					} else if ((header & SHORT_STRING_HEADER) === SHORT_STRING_HEADER) {
 						const len = header & SHORT_STRING_LENGTH_MASK;
 						return () => {
-							if (isInCurrentBuffer(len)) {
+							if (
+								isInCurrentBuffer(len) &&
+								currentPosition + len < 0x7fffffff
+							) {
 								result.push(
 									currentBuffer.toString(
 										"latin1",

package/lib/serialization/FileMiddleware.js

@@ -280,8 +280,16 @@ const deserialize = async (middleware, name, readFile) => {
 	}
 	const sectionCount = readUInt32LE();
 	const lengths = [];
+	let lastLengthPositive = false;
 	for (let i = 0; i < sectionCount; i++) {
-		lengths.push(readInt32LE());
+		const value = readInt32LE();
+		const valuePositive = value >= 0;
+		if (lastLengthPositive && valuePositive) {
+			lengths[lengths.length - 1] += value;
+		} else {
+			lengths.push(value);
+			lastLengthPositive = valuePositive;
+		}
 	}
 	const result = [];
 	for (let length of lengths) {
@@ -307,13 +315,24 @@ const deserialize = async (middleware, name, readFile) => {
 			} else if (contentPosition !== 0) {
 				if (length <= contentItemLength - contentPosition) {
 					result.push(
-						contentItem.slice(contentPosition, contentPosition + length)
+						Buffer.from(
+							contentItem.buffer,
+							contentItem.byteOffset + contentPosition,
+							length
+						)
 					);
 					contentPosition += length;
 					length = 0;
 				} else {
-					result.push(contentItem.slice(contentPosition));
-					length -= contentItemLength - contentPosition;
+					const l = contentItemLength - contentPosition;
+					result.push(
+						Buffer.from(
+							contentItem.buffer,
+							contentItem.byteOffset + contentPosition,
+							l
+						)
+					);
+					length -= l;
 					contentPosition = contentItemLength;
 				}
 			} else {
@@ -322,7 +341,9 @@ const deserialize = async (middleware, name, readFile) => {
 					length -= contentItemLength;
 					contentPosition = contentItemLength;
 				} else {
-					result.push(contentItem.slice(0, length));
+					result.push(
+						Buffer.from(contentItem.buffer, contentItem.byteOffset, length)
+					);
 					contentPosition += length;
 					length = 0;
 				}
@@ -334,7 +355,9 @@ const deserialize = async (middleware, name, readFile) => {
 					length -= contentItemLength;
 					contentPosition = contentItemLength;
 				} else {
-					result.push(contentItem.slice(0, length));
+					result.push(
+						Buffer.from(contentItem.buffer, contentItem.byteOffset, length)
+					);
 					contentPosition += length;
 					length = 0;
 				}
@@ -462,6 +485,7 @@ class FileMiddleware extends SerializerMiddleware {
 							let readBuffer = currentBuffer;
 							let readOffset = currentBufferUsed;
 							let readLength = currentBuffer.length - currentBufferUsed;
+							// values passed to fs.read must be valid int32 values
 							if (readOffset > 0x7fffffff) {
 								readBuffer = currentBuffer.slice(readOffset);
 								readOffset = 0;

package/lib/serialization/PlainObjectSerializer.js

@@ -7,19 +7,21 @@
 const cache = new WeakMap();
 
 class ObjectStructure {
-	constructor(keys) {
-		this.keys = keys;
-		this.children = new Map();
+	constructor() {
+		this.keys = undefined;
+		this.children = undefined;
 	}
 
-	getKeys() {
+	getKeys(keys) {
+		if (this.keys === undefined) this.keys = keys;
 		return this.keys;
 	}
 
 	key(key) {
+		if (this.children === undefined) this.children = new Map();
 		const child = this.children.get(key);
 		if (child !== undefined) return child;
-		const newChild = new ObjectStructure(this.keys.concat(key));
+		const newChild = new ObjectStructure();
 		this.children.set(key, newChild);
 		return newChild;
 	}
@@ -28,20 +30,27 @@ class ObjectStructure {
 const getCachedKeys = (keys, cacheAssoc) => {
 	let root = cache.get(cacheAssoc);
 	if (root === undefined) {
-		root = new ObjectStructure([]);
+		root = new ObjectStructure();
 		cache.set(cacheAssoc, root);
 	}
 	let current = root;
 	for (const key of keys) {
 		current = current.key(key);
 	}
-	return current.getKeys();
+	return current.getKeys(keys);
 };
 
 class PlainObjectSerializer {
 	serialize(obj, { write }) {
 		const keys = Object.keys(obj);
-		if (keys.length > 1) {
+		if (keys.length > 128) {
+			// Objects with so many keys are unlikely to share structure
+			// with other objects
+			write(keys);
+			for (const key of keys) {
+				write(obj[key]);
+			}
+		} else if (keys.length > 1) {
 			write(getCachedKeys(keys, write));
 			for (const key of keys) {
 				write(obj[key]);

package/lib/serialization/Serializer.js

@@ -15,7 +15,7 @@ class Serializer {
 		const ctx = { ...context, ...this.context };
 		let current = obj;
 		for (const middleware of this.serializeMiddlewares) {
-			if (current instanceof Promise) {
+			if (current && typeof current.then === "function") {
 				current = current.then(
 					data => data && middleware.serialize(data, context)
 				);
@@ -35,7 +35,7 @@ class Serializer {
 		/** @type {any} */
 		let current = value;
 		for (const middleware of this.deserializeMiddlewares) {
-			if (current instanceof Promise) {
+			if (current && typeof current.then === "function") {
 				current = current.then(data => middleware.deserialize(data, context));
 			} else {
 				current = middleware.deserialize(current, ctx);

package/lib/serialization/SerializerMiddleware.js

@@ -100,9 +100,10 @@ class SerializerMiddleware {
 	static serializeLazy(lazy, serialize) {
 		const fn = memoize(() => {
 			const r = lazy();
-			if (r instanceof Promise) return r.then(data => data && serialize(data));
-			if (r) return serialize(r);
-			return null;
+			if (r && typeof r.then === "function") {
+				return r.then(data => data && serialize(data));
+			}
+			return serialize(r);
 		});
 		fn[LAZY_TARGET] = lazy[LAZY_TARGET];
 		/** @type {any} */ (fn).options = /** @type {any} */ (lazy).options;
@@ -118,7 +119,9 @@ class SerializerMiddleware {
 	static deserializeLazy(lazy, deserialize) {
 		const fn = memoize(() => {
 			const r = lazy();
-			if (r instanceof Promise) return r.then(data => deserialize(data));
+			if (r && typeof r.then === "function") {
+				return r.then(data => deserialize(data));
+			}
 			return deserialize(r);
 		});
 		fn[LAZY_TARGET] = lazy[LAZY_TARGET];
@@ -126,6 +129,25 @@ class SerializerMiddleware {
 		fn[LAZY_SERIALIZED_VALUE] = lazy;
 		return fn;
 	}
+
+	/**
+	 * @param {function(): Promise<any> | any} lazy lazy function
+	 * @returns {function(): Promise<any> | any} new lazy
+	 */
+	static unMemoizeLazy(lazy) {
+		if (!SerializerMiddleware.isLazy(lazy)) return lazy;
+		const fn = () => {
+			throw new Error(
+				"A lazy value that has been unmemorized can't be called again"
+			);
+		};
+		fn[LAZY_SERIALIZED_VALUE] = SerializerMiddleware.unMemoizeLazy(
+			lazy[LAZY_SERIALIZED_VALUE]
+		);
+		fn[LAZY_TARGET] = lazy[LAZY_TARGET];
+		fn.options = /** @type {any} */ (lazy).options;
+		return fn;
+	}
 }
 
 module.exports = SerializerMiddleware;

package/lib/util/ArrayQueue.js

@@ -27,6 +27,14 @@ class ArrayQueue {
 		return this._list.length + this._listReversed.length;
 	}
 
+	/**
+	 * Empties the queue.
+	 */
+	clear() {
+		this._list.length = 0;
+		this._listReversed.length = 0;
+	}
+
 	/**
 	 * Appends the specified element to this queue.
 	 * @param {T} item The element to add.

package/lib/util/AsyncQueue.js

@@ -359,6 +359,15 @@ class AsyncQueue {
 			inHandleResult--;
 		});
 	}
+
+	clear() {
+		this._entries.clear();
+		this._queued.clear();
+		this._activeTasks = 0;
+		this._willEnsureProcessing = false;
+		this._needProcessing = false;
+		this._stopped = false;
+	}
 }
 
 module.exports = AsyncQueue;

package/lib/util/LazySet.js

@@ -24,21 +24,17 @@ const merge = (targetSet, toMerge) => {
 /**
  * @template T
  * @param {Set<Iterable<T>>} targetSet set where iterables should be added
- * @param {Array<Iterable<T> | LazySet<T>>} toDeepMerge iterables or lazy set to be flattened
+ * @param {Array<LazySet<T>>} toDeepMerge lazy sets to be flattened
  * @returns {void}
  */
 const flatten = (targetSet, toDeepMerge) => {
 	for (const set of toDeepMerge) {
-		if (set instanceof LazySet) {
-			if (set._set.size > 0) targetSet.add(set._set);
-			if (set._needMerge) {
-				for (const mergedSet of set._toMerge) {
-					targetSet.add(mergedSet);
-				}
-				flatten(targetSet, set._toDeepMerge);
+		if (set._set.size > 0) targetSet.add(set._set);
+		if (set._needMerge) {
+			for (const mergedSet of set._toMerge) {
+				targetSet.add(mergedSet);
 			}
-		} else {
-			targetSet.add(set);
+			flatten(targetSet, set._toDeepMerge);
 		}
 	}
 };
@@ -58,7 +54,7 @@ class LazySet {
 		this._set = new Set(iterable);
 		/** @type {Set<Iterable<T>>} */
 		this._toMerge = new Set();
-		/** @type {Array<Iterable<T> | LazySet<T>>} */
+		/** @type {Array<LazySet<T>>} */
 		this._toDeepMerge = [];
 		this._needMerge = false;
 		this._deopt = false;
@@ -76,6 +72,14 @@ class LazySet {
 		this._needMerge = false;
 	}
 
+	_isEmpty() {
+		return (
+			this._set.size === 0 &&
+			this._toMerge.size === 0 &&
+			this._toDeepMerge.length === 0
+		);
+	}
+
 	get size() {
 		if (this._needMerge) this._merge();
 		return this._set.size;
@@ -101,13 +105,18 @@ class LazySet {
 				_set.add(item);
 			}
 		} else {
-			this._toDeepMerge.push(iterable);
-			this._needMerge = true;
-			// Avoid being too memory hungry
-			if (this._toDeepMerge.length > 100000) {
-				this._flatten();
-				if (this._toMerge.size > 100000) this._merge();
+			if (iterable instanceof LazySet) {
+				if (iterable._isEmpty()) return this;
+				this._toDeepMerge.push(iterable);
+				this._needMerge = true;
+				if (this._toDeepMerge.length > 100000) {
+					this._flatten();
+				}
+			} else {
+				this._toMerge.add(iterable);
+				this._needMerge = true;
 			}
+			if (this._toMerge.size > 100000) this._merge();
 		}
 		return this;
 	}

package/lib/wasm/EnableWasmLoadingPlugin.js

@@ -84,11 +84,20 @@ class EnableWasmLoadingPlugin {
 				case "async-node": {
 					// TODO webpack 6 remove ReadFileCompileWasmPlugin
 					const ReadFileCompileWasmPlugin = require("../node/ReadFileCompileWasmPlugin");
+					// @ts-expect-error typescript bug for duplicate require
 					const ReadFileCompileAsyncWasmPlugin = require("../node/ReadFileCompileAsyncWasmPlugin");
 					new ReadFileCompileWasmPlugin({
 						mangleImports: compiler.options.optimization.mangleWasmImports
 					}).apply(compiler);
-					new ReadFileCompileAsyncWasmPlugin().apply(compiler);
+					new ReadFileCompileAsyncWasmPlugin({ type }).apply(compiler);
+					break;
+				}
+				case "async-node-module": {
+					// @ts-expect-error typescript bug for duplicate require
+					const ReadFileCompileAsyncWasmPlugin = require("../node/ReadFileCompileAsyncWasmPlugin");
+					new ReadFileCompileAsyncWasmPlugin({ type, import: true }).apply(
+						compiler
+					);
 					break;
 				}
 				case "universal":

package/lib/wasm-sync/WasmChunkLoadingRuntimeModule.js

@@ -291,7 +291,7 @@ class WasmChunkLoadingRuntimeModule extends RuntimeModule {
 						"var promise;",
 						this.supportsStreaming
 							? Template.asString([
-									"if(importObject instanceof Promise && typeof WebAssembly.compileStreaming === 'function') {",
+									"if(importObject && typeof importObject.then === 'function' && typeof WebAssembly.compileStreaming === 'function') {",
 									Template.indent([
 										"promise = Promise.all([WebAssembly.compileStreaming(req), importObject]).then(function(items) {",
 										Template.indent([
@@ -309,7 +309,7 @@ class WasmChunkLoadingRuntimeModule extends RuntimeModule {
 									])
 							  ])
 							: Template.asString([
-									"if(importObject instanceof Promise) {",
+									"if(importObject && typeof importObject.then === 'function') {",
 									Template.indent([
 										"var bytesPromise = req.then(function(x) { return x.arrayBuffer(); });",
 										"promise = Promise.all([",

package/lib/wasm-sync/WebAssemblyModulesPlugin.js

@@ -16,7 +16,7 @@ const WebAssemblyInInitialChunkError = require("./WebAssemblyInInitialChunkError
 /** @typedef {import("../Compiler")} Compiler */
 /** @typedef {import("../Module")} Module */
 /** @typedef {import("../ModuleTemplate")} ModuleTemplate */
-/** @typedef {import("../ModuleTemplate").RenderContext} RenderContext */
+/** @typedef {import("../javascript/JavascriptModulesPlugin").RenderContext} RenderContext */
 
 const getWebAssemblyGenerator = memoize(() =>
 	require("./WebAssemblyGenerator")

package/package.json

@@ -1,12 +1,12 @@
 {
   "name": "webpack",
-  "version": "5.39.0",
+  "version": "5.41.1",
   "author": "Tobias Koppers @sokra",
   "description": "Packs CommonJs/AMD modules for the browser. Allows to split your codebase into multiple bundles, which can be loaded on demand. Support loaders to preprocess files, i.e. json, jsx, es7, css, less, ... and your custom stuff.",
   "license": "MIT",
   "dependencies": {
     "@types/eslint-scope": "^3.7.0",
-    "@types/estree": "^0.0.47",
+    "@types/estree": "^0.0.48",
     "@webassemblyjs/ast": "1.11.0",
     "@webassemblyjs/wasm-edit": "1.11.0",
     "@webassemblyjs/wasm-parser": "1.11.0",
@@ -14,7 +14,7 @@
     "browserslist": "^4.14.5",
     "chrome-trace-event": "^1.0.2",
     "enhanced-resolve": "^5.8.0",
-    "es-module-lexer": "^0.4.0",
+    "es-module-lexer": "^0.6.0",
     "eslint-scope": "5.1.1",
     "events": "^3.2.0",
     "glob-to-regexp": "^0.4.1",
@@ -25,7 +25,7 @@
     "neo-async": "^2.6.2",
     "schema-utils": "^3.0.0",
     "tapable": "^2.1.1",
-    "terser-webpack-plugin": "^5.1.1",
+    "terser-webpack-plugin": "^5.1.3",
     "watchpack": "^2.2.0",
     "webpack-sources": "^2.3.0"
   },
@@ -37,7 +37,7 @@
   "devDependencies": {
     "@babel/core": "^7.11.1",
     "@babel/preset-react": "^7.10.4",
-    "@types/es-module-lexer": "^0.3.0",
+    "@types/es-module-lexer": "^0.4.1",
     "@types/jest": "^26.0.15",
     "@types/node": "^15.0.1",
     "babel-loader": "^8.1.0",
@@ -64,7 +64,7 @@
     "is-ci": "^3.0.0",
     "istanbul": "^0.4.5",
     "jest": "^26.6.3",
-    "jest-diff": "^26.6.2",
+    "jest-diff": "^27.0.2",
     "jest-junit": "^12.0.0",
     "json-loader": "^0.5.7",
     "json5": "^2.1.3",
@@ -80,7 +80,7 @@
     "nyc": "^15.1.0",
     "open-cli": "^6.0.1",
     "prettier": "^2.2.0",
-    "pretty-format": "^26.3.0",
+    "pretty-format": "^27.0.2",
     "pug": "^3.0.0",
     "pug-loader": "^2.4.0",
     "raw-loader": "^4.0.1",
@@ -91,7 +91,7 @@
     "simple-git": "^2.17.0",
     "strip-ansi": "^6.0.0",
     "style-loader": "^2.0.0",
-    "terser": "^5.5.0",
+    "terser": "^5.7.0",
     "toml": "^3.0.0",
     "tooling": "webpack/tooling#v1.19.0",
     "ts-loader": "^8.0.2",
@@ -131,11 +131,11 @@
   ],
   "scripts": {
     "setup": "node ./setup/setup.js",
-    "test": "node --max-old-space-size=4096 --trace-deprecation node_modules/jest-cli/bin/jest",
+    "test": "node --max-old-space-size=4096 --experimental-vm-modules --trace-deprecation node_modules/jest-cli/bin/jest",
     "test:update-snapshots": "yarn jest -u",
-    "test:integration": "node --max-old-space-size=4096 --trace-deprecation node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/test/*.test.js\"",
-    "test:basic": "node --max-old-space-size=4096 --trace-deprecation node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/te{st/TestCasesNormal,st/StatsTestCases,st/ConfigTestCases}.test.js\"",
-    "test:unit": "node --max-old-space-size=4096 --trace-deprecation node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/test/*.unittest.js\"",
+    "test:integration": "node --max-old-space-size=4096 --experimental-vm-modules --trace-deprecation node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/test/*.test.js\"",
+    "test:basic": "node --max-old-space-size=4096 --experimental-vm-modules --trace-deprecation node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/te{st/TestCasesNormal,st/StatsTestCases,st/ConfigTestCases}.test.js\"",
+    "test:unit": "node --max-old-space-size=4096 --experimental-vm-modules --trace-deprecation node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/test/*.unittest.js\"",
     "travis:integration": "yarn cover:integration --ci $JEST",
     "travis:basic": "yarn cover:basic --ci $JEST",
     "travis:lintunit": "yarn lint && yarn cover:unit --ci $JEST",
@@ -162,13 +162,13 @@
     "pretty-lint": "yarn pretty-lint-base --check",
     "yarn-lint": "yarn-deduplicate --fail --list -s highest yarn.lock",
     "yarn-lint-fix": "yarn-deduplicate -s highest yarn.lock",
-    "benchmark": "node --max-old-space-size=4096 --trace-deprecation node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/test/*.benchmark.js\" --runInBand",
+    "benchmark": "node --max-old-space-size=4096 --experimental-vm-modules --trace-deprecation node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/test/*.benchmark.js\" --runInBand",
     "cover": "yarn cover:all && yarn cover:report",
     "cover:clean": "rimraf .nyc_output coverage",
-    "cover:all": "node --max-old-space-size=4096 node_modules/jest-cli/bin/jest --coverage",
-    "cover:basic": "node --max-old-space-size=4096 node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/te{st/TestCasesNormal,st/StatsTestCases,st/ConfigTestCases}.test.js\" --coverage",
-    "cover:integration": "node --max-old-space-size=4096 node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/test/*.test.js\" --coverage",
-    "cover:unit": "node --max-old-space-size=4096 node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/test/*.unittest.js\" --coverage",
+    "cover:all": "node --max-old-space-size=4096 --experimental-vm-modules node_modules/jest-cli/bin/jest --coverage",
+    "cover:basic": "node --max-old-space-size=4096 --experimental-vm-modules node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/te{st/TestCasesNormal,st/StatsTestCases,st/ConfigTestCases}.test.js\" --coverage",
+    "cover:integration": "node --max-old-space-size=4096 --experimental-vm-modules node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/test/*.test.js\" --coverage",
+    "cover:unit": "node --max-old-space-size=4096 --experimental-vm-modules node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/test/*.unittest.js\" --coverage",
     "cover:types": "node node_modules/tooling/type-coverage",
     "cover:merge": "nyc merge .nyc_output coverage/coverage-nyc.json && rimraf .nyc_output",
     "cover:report": "nyc report -t coverage"