webpack 5.37.0 → 5.37.1

package/lib/ModuleFilenameHelpers.js

@@ -12,14 +12,16 @@ const ModuleFilenameHelpers = exports;
 
 // TODO webpack 6: consider removing these
 ModuleFilenameHelpers.ALL_LOADERS_RESOURCE = "[all-loaders][resource]";
-ModuleFilenameHelpers.REGEXP_ALL_LOADERS_RESOURCE = /\[all-?loaders\]\[resource\]/gi;
+ModuleFilenameHelpers.REGEXP_ALL_LOADERS_RESOURCE =
+	/\[all-?loaders\]\[resource\]/gi;
 ModuleFilenameHelpers.LOADERS_RESOURCE = "[loaders][resource]";
 ModuleFilenameHelpers.REGEXP_LOADERS_RESOURCE = /\[loaders\]\[resource\]/gi;
 ModuleFilenameHelpers.RESOURCE = "[resource]";
 ModuleFilenameHelpers.REGEXP_RESOURCE = /\[resource\]/gi;
 ModuleFilenameHelpers.ABSOLUTE_RESOURCE_PATH = "[absolute-resource-path]";
 // cSpell:words olute
-ModuleFilenameHelpers.REGEXP_ABSOLUTE_RESOURCE_PATH = /\[abs(olute)?-?resource-?path\]/gi;
+ModuleFilenameHelpers.REGEXP_ABSOLUTE_RESOURCE_PATH =
+	/\[abs(olute)?-?resource-?path\]/gi;
 ModuleFilenameHelpers.RESOURCE_PATH = "[resource-path]";
 ModuleFilenameHelpers.REGEXP_RESOURCE_PATH = /\[resource-?path\]/gi;
 ModuleFilenameHelpers.ALL_LOADERS = "[all-loaders]";

package/lib/ModuleGraphConnection.js

@@ -183,5 +183,9 @@ class ModuleGraphConnection {
 
 module.exports = ModuleGraphConnection;
 module.exports.addConnectionStates = addConnectionStates;
-module.exports.TRANSITIVE_ONLY = /** @type {typeof TRANSITIVE_ONLY} */ (TRANSITIVE_ONLY);
-module.exports.CIRCULAR_CONNECTION = /** @type {typeof CIRCULAR_CONNECTION} */ (CIRCULAR_CONNECTION);
+module.exports.TRANSITIVE_ONLY = /** @type {typeof TRANSITIVE_ONLY} */ (
+	TRANSITIVE_ONLY
+);
+module.exports.CIRCULAR_CONNECTION = /** @type {typeof CIRCULAR_CONNECTION} */ (
+	CIRCULAR_CONNECTION
+);

package/lib/ModuleInfoHeaderPlugin.js

@@ -222,9 +222,8 @@ class ModuleInfoHeaderPlugin {
 								)}`
 							) + "\n"
 						);
-						const optimizationBailout = moduleGraph.getOptimizationBailout(
-							module
-						);
+						const optimizationBailout =
+							moduleGraph.getOptimizationBailout(module);
 						if (optimizationBailout) {
 							for (const text of optimizationBailout) {
 								let code;

package/lib/MultiCompiler.js

@@ -318,16 +318,17 @@ module.exports = class MultiCompiler {
 	 * @returns {SetupResult[]} result of setup
 	 */
 	_runGraph(setup, run, callback) {
-		/** @typedef {{ compiler: Compiler, result: Stats, state: "pending" | "blocked" | "queued" | "running" | "running-outdated" | "done", children: Node[], parents: Node[] }} Node */
+		/** @typedef {{ compiler: Compiler, result: Stats, state: "pending" | "blocked" | "queued" | "starting" | "running" | "running-outdated" | "done", children: Node[], parents: Node[] }} Node */
 
 		// State transitions for nodes:
 		// -> blocked (initial)
-		// blocked -> queued [add to queue] (when all parents done)
-		// queued -> running [running++] (when processing the queue)
+		// blocked -> starting [running++] (when all parents done)
+		// queued -> starting [running++] (when processing the queue)
+		// starting -> running (when run has been called)
 		// running -> done [running--] (when compilation is done)
 		// done -> pending (when invalidated from file change)
-		// pending -> blocked (when invalidated from aggregated changes)
-		// done -> blocked (when invalidated, from parent invalidation)
+		// pending -> blocked [add to queue] (when invalidated from aggregated changes)
+		// done -> blocked [add to queue] (when invalidated, from parent invalidation)
 		// running -> running-outdated (when invalidated, either from change or parent invalidation)
 		// running-outdated -> blocked [running--] (when compilation is done)
 
@@ -351,6 +352,7 @@ module.exports = class MultiCompiler {
 				parent.children.push(node);
 			}
 		}
+		/** @type {ArrayQueue<Node>} */
 		const queue = new ArrayQueue();
 		for (const node of nodes) {
 			if (node.parents.length === 0) {
@@ -388,13 +390,13 @@ module.exports = class MultiCompiler {
 			if (node.state === "running") {
 				node.state = "done";
 				for (const child of node.children) {
-					checkUnblocked(child);
+					if (child.state === "blocked") queue.enqueue(child);
 				}
 			} else if (node.state === "running-outdated") {
 				node.state = "blocked";
-				checkUnblocked(node);
+				queue.enqueue(node);
 			}
-			process.nextTick(processQueue);
+			processQueue();
 		};
 		/**
 		 * @param {Node} node node
@@ -433,20 +435,9 @@ module.exports = class MultiCompiler {
 			if (node.state === "pending") {
 				node.state = "blocked";
 			}
-			checkUnblocked(node);
-			processQueue();
-		};
-		/**
-		 * @param {Node} node node
-		 * @returns {void}
-		 */
-		const checkUnblocked = node => {
-			if (
-				node.state === "blocked" &&
-				node.parents.every(p => p.state === "done")
-			) {
-				node.state = "queued";
+			if (node.state === "blocked") {
 				queue.enqueue(node);
+				processQueue();
 			}
 		};
 
@@ -457,20 +448,33 @@ module.exports = class MultiCompiler {
 					node.compiler,
 					i,
 					nodeDone.bind(null, node),
-					() => node.state !== "done" && node.state !== "running",
+					() => node.state !== "starting" && node.state !== "running",
 					() => nodeChange(node),
 					() => nodeInvalid(node)
 				)
 			);
 		});
+		let processing = true;
 		const processQueue = () => {
+			if (processing) return;
+			processing = true;
+			process.nextTick(processQueueWorker);
+		};
+		const processQueueWorker = () => {
 			while (running < parallelism && queue.length > 0 && !errored) {
 				const node = queue.dequeue();
-				if (node.state !== "queued") continue;
-				running++;
-				node.state = "running";
-				run(node.compiler, nodeDone.bind(null, node));
+				if (
+					node.state === "queued" ||
+					(node.state === "blocked" &&
+						node.parents.every(p => p.state === "done"))
+				) {
+					running++;
+					node.state = "starting";
+					run(node.compiler, nodeDone.bind(null, node));
+					node.state = "running";
+				}
 			}
+			processing = false;
 			if (
 				!errored &&
 				running === 0 &&
@@ -489,7 +493,7 @@ module.exports = class MultiCompiler {
 				}
 			}
 		};
-		processQueue();
+		processQueueWorker();
 		return setupResults;
 	}
 

package/lib/NormalModule.js

@@ -276,6 +276,8 @@ class NormalModule extends Module {
 		this._source = null;
 		/** @private @type {Map<string, number> | undefined} **/
 		this._sourceSizes = undefined;
+		/** @private @type {Set<string>} */
+		this._sourceTypes = undefined;
 
 		// Cache
 		this._lastSuccessfulBuildMeta = {};
@@ -347,12 +349,19 @@ class NormalModule extends Module {
 		this.resource = m.resource;
 		this.matchResource = m.matchResource;
 		this.loaders = m.loaders;
+		this._sourceTypes = m._sourceTypes;
+		this._sourceSizes = m._sourceSizes;
 	}
 
 	/**
 	 * Assuming this module is in the cache. Remove internal references to allow freeing some memory.
 	 */
 	cleanupForCache() {
+		// Make sure to cache types and sizes before cleanup
+		if (this._sourceTypes === undefined) this.getSourceTypes();
+		for (const type of this._sourceTypes) {
+			this.size(type);
+		}
 		super.cleanupForCache();
 		this.parser = undefined;
 		this.parserOptions = undefined;
@@ -390,6 +399,7 @@ class NormalModule extends Module {
 			this.type,
 			this.generatorOptions
 		);
+		// we assume the generator behaves identically and keep cached sourceTypes/Sizes
 	}
 
 	/**
@@ -765,7 +775,11 @@ class NormalModule extends Module {
 			},
 			(err, result) => {
 				// Cleanup loaderContext to avoid leaking memory in ICs
-				loaderContext._compilation = loaderContext._compiler = loaderContext._module = loaderContext.fs = undefined;
+				loaderContext._compilation =
+					loaderContext._compiler =
+					loaderContext._module =
+					loaderContext.fs =
+						undefined;
 
 				if (!result) {
 					return processResult(
@@ -869,6 +883,7 @@ class NormalModule extends Module {
 		this._forceBuild = false;
 		this._source = null;
 		if (this._sourceSizes !== undefined) this._sourceSizes.clear();
+		this._sourceTypes = undefined;
 		this._ast = null;
 		this.error = null;
 		this.clearWarningsAndErrors();
@@ -958,7 +973,8 @@ class NormalModule extends Module {
 				checkDependencies(this.buildInfo.missingDependencies);
 				checkDependencies(this.buildInfo.contextDependencies);
 				if (nonAbsoluteDependencies !== undefined) {
-					const InvalidDependenciesModuleWarning = getInvalidDependenciesModuleWarning();
+					const InvalidDependenciesModuleWarning =
+						getInvalidDependenciesModuleWarning();
 					this.addWarning(
 						new InvalidDependenciesModuleWarning(this, nonAbsoluteDependencies)
 					);
@@ -1070,7 +1086,10 @@ class NormalModule extends Module {
 	 * @returns {Set<string>} types available (do not mutate)
 	 */
 	getSourceTypes() {
-		return this.generator.getTypes(this);
+		if (this._sourceTypes === undefined) {
+			this._sourceTypes = this.generator.getTypes(this);
+		}
+		return this._sourceTypes;
 	}
 
 	/**
@@ -1259,7 +1278,6 @@ class NormalModule extends Module {
 		const { write } = context;
 		// deserialize
 		write(this._source);
-		write(this._sourceSizes);
 		write(this.error);
 		write(this._lastSuccessfulBuildMeta);
 		write(this._forceBuild);
@@ -1291,7 +1309,6 @@ class NormalModule extends Module {
 	deserialize(context) {
 		const { read } = context;
 		this._source = read();
-		this._sourceSizes = read();
 		this.error = read();
 		this._lastSuccessfulBuildMeta = read();
 		this._forceBuild = read();

package/lib/RecordIdsPlugin.js

@@ -48,10 +48,11 @@ class RecordIdsPlugin {
 	apply(compiler) {
 		const portableIds = this.options.portableIds;
 
-		const makePathsRelative = identifierUtils.makePathsRelative.bindContextCache(
-			compiler.context,
-			compiler.root
-		);
+		const makePathsRelative =
+			identifierUtils.makePathsRelative.bindContextCache(
+				compiler.context,
+				compiler.root
+			);
 
 		/**
 		 * @param {Module} module the module

package/lib/ResolverFactory.js

@@ -42,9 +42,9 @@ const convertToResolveOptions = resolveOptionsWithDepType => {
 		...remaining,
 		plugins:
 			plugins &&
-			/** @type {ResolvePluginInstance[]} */ (plugins.filter(
-				item => item !== "..."
-			))
+			/** @type {ResolvePluginInstance[]} */ (
+				plugins.filter(item => item !== "...")
+			)
 	};
 
 	if (!partialOptions.fileSystem) {
@@ -53,7 +53,10 @@ const convertToResolveOptions = resolveOptionsWithDepType => {
 		);
 	}
 	// These weird types validate that we checked all non-optional properties
-	const options = /** @type {Partial<ResolveOptions> & Pick<ResolveOptions, "fileSystem">} */ (partialOptions);
+	const options =
+		/** @type {Partial<ResolveOptions> & Pick<ResolveOptions, "fileSystem">} */ (
+			partialOptions
+		);
 
 	return removeOperations(
 		resolveByProperty(options, "byDependency", dependencyType)
@@ -124,9 +127,9 @@ module.exports = class ResolverFactory {
 		const resolveOptions = convertToResolveOptions(
 			this.hooks.resolveOptions.for(type).call(resolveOptionsWithDepType)
 		);
-		const resolver = /** @type {ResolverWithOptions} */ (Factory.createResolver(
-			resolveOptions
-		));
+		const resolver = /** @type {ResolverWithOptions} */ (
+			Factory.createResolver(resolveOptions)
+		);
 		if (!resolver) {
 			throw new Error("No resolver created");
 		}

package/lib/SourceMapDevToolPlugin.js

@@ -430,19 +430,20 @@ class SourceMapDevToolPlugin {
 										currentSourceMappingURLComment !== false &&
 										/\.css($|\?)/i.test(file)
 									) {
-										currentSourceMappingURLComment = currentSourceMappingURLComment.replace(
-											/^\n\/\/(.*)$/,
-											"\n/*$1*/"
-										);
+										currentSourceMappingURLComment =
+											currentSourceMappingURLComment.replace(
+												/^\n\/\/(.*)$/,
+												"\n/*$1*/"
+											);
 									}
 									const sourceMapString = JSON.stringify(sourceMap);
 									if (sourceMapFilename) {
 										let filename = file;
 										const sourceMapContentHash =
 											usesContentHash &&
-											/** @type {string} */ (createHash("md4")
-												.update(sourceMapString)
-												.digest("hex"));
+											/** @type {string} */ (
+												createHash("md4").update(sourceMapString).digest("hex")
+											);
 										const pathParams = {
 											chunk,
 											filename: options.fileContext
@@ -454,13 +455,11 @@ class SourceMapDevToolPlugin {
 												: filename,
 											contentHash: sourceMapContentHash
 										};
-										const {
-											path: sourceMapFile,
-											info: sourceMapInfo
-										} = compilation.getPathWithInfo(
-											sourceMapFilename,
-											pathParams
-										);
+										const { path: sourceMapFile, info: sourceMapInfo } =
+											compilation.getPathWithInfo(
+												sourceMapFilename,
+												pathParams
+											);
 										const sourceMapUrl = options.publicPath
 											? options.publicPath + sourceMapFile
 											: relative(

package/lib/Template.js

@@ -413,5 +413,7 @@ class Template {
 }
 
 module.exports = Template;
-module.exports.NUMBER_OF_IDENTIFIER_START_CHARS = NUMBER_OF_IDENTIFIER_START_CHARS;
-module.exports.NUMBER_OF_IDENTIFIER_CONTINUATION_CHARS = NUMBER_OF_IDENTIFIER_CONTINUATION_CHARS;
+module.exports.NUMBER_OF_IDENTIFIER_START_CHARS =
+	NUMBER_OF_IDENTIFIER_START_CHARS;
+module.exports.NUMBER_OF_IDENTIFIER_CONTINUATION_CHARS =
+	NUMBER_OF_IDENTIFIER_CONTINUATION_CHARS;

package/lib/Watching.js

@@ -57,16 +57,53 @@ class Watching {
 		this._needRecords = true;
 		this.watcher = undefined;
 		this.pausedWatcher = undefined;
+		/** @type {Set<string>} */
+		this._collectedChangedFiles = undefined;
+		/** @type {Set<string>} */
+		this._collectedRemovedFiles = undefined;
 		this._done = this._done.bind(this);
 		process.nextTick(() => {
 			if (this._initial) this._invalidate();
 		});
 	}
 
-	_go() {
+	_mergeWithCollected(changedFiles, removedFiles) {
+		if (!changedFiles) return;
+		if (!this._collectedChangedFiles) {
+			this._collectedChangedFiles = new Set(changedFiles);
+			this._collectedRemovedFiles = new Set(removedFiles);
+		} else {
+			for (const file of changedFiles) {
+				this._collectedChangedFiles.add(file);
+				this._collectedRemovedFiles.delete(file);
+			}
+			for (const file of removedFiles) {
+				this._collectedChangedFiles.delete(file);
+				this._collectedRemovedFiles.add(file);
+			}
+		}
+	}
+
+	_go(fileTimeInfoEntries, contextTimeInfoEntries, changedFiles, removedFiles) {
 		this._initial = false;
 		this.startTime = Date.now();
 		this.running = true;
+		if (this.watcher) {
+			this.pausedWatcher = this.watcher;
+			this.watcher.pause();
+			this.watcher = null;
+		}
+		this._mergeWithCollected(
+			changedFiles ||
+				(this.pausedWatcher &&
+					this.pausedWatcher.getAggregatedChanges &&
+					this.pausedWatcher.getAggregatedChanges()),
+			(this.compiler.removedFiles =
+				removedFiles ||
+				(this.pausedWatcher &&
+					this.pausedWatcher.getAggregatedRemovals &&
+					this.pausedWatcher.getAggregatedRemovals()))
+		);
 		const run = () => {
 			if (this.compiler.idle) {
 				return this.compiler.cache.endIdle(err => {
@@ -83,6 +120,19 @@ class Watching {
 					run();
 				});
 			}
+
+			this.compiler.modifiedFiles = this._collectedChangedFiles;
+			this._collectedChangedFiles = undefined;
+			this.compiler.removedFiles = this._collectedRemovedFiles;
+			this._collectedRemovedFiles = undefined;
+
+			this.compiler.fileTimestamps =
+				fileTimeInfoEntries ||
+				(this.pausedWatcher && this.pausedWatcher.getFileTimeInfoEntries());
+			this.compiler.contextTimestamps =
+				contextTimeInfoEntries ||
+				(this.pausedWatcher && this.pausedWatcher.getContextTimeInfoEntries());
+
 			this.invalid = false;
 			this._invalidReported = false;
 			this.compiler.hooks.watchRun.callAsync(this.compiler, err => {
@@ -159,13 +209,16 @@ class Watching {
 
 		let stats = null;
 
-		const handleError = err => {
+		const handleError = (err, cbs) => {
 			this.compiler.hooks.failed.call(err);
 			this.compiler.cache.beginIdle();
 			this.compiler.idle = true;
 			this.handler(err, stats);
-			for (const cb of this.callbacks) cb();
-			this.callbacks.length = 0;
+			if (!cbs) {
+				cbs = this.callbacks;
+				this.callbacks = [];
+			}
+			for (const cb of cbs) cb(err);
 		};
 
 		if (
@@ -197,17 +250,19 @@ class Watching {
 		}
 		if (err) return handleError(err);
 
+		const cbs = this.callbacks;
+		this.callbacks = [];
 		logger.time("done hook");
 		this.compiler.hooks.done.callAsync(stats, err => {
 			logger.timeEnd("done hook");
-			if (err) return handleError(err);
+			if (err) return handleError(err, cbs);
 			this.handler(null, stats);
 			logger.time("storeBuildDependencies");
 			this.compiler.cache.storeBuildDependencies(
 				compilation.buildDependencies,
 				err => {
 					logger.timeEnd("storeBuildDependencies");
-					if (err) return handleError(err);
+					if (err) return handleError(err, cbs);
 					logger.time("beginIdle");
 					this.compiler.cache.beginIdle();
 					this.compiler.idle = true;
@@ -221,8 +276,7 @@ class Watching {
 							);
 						}
 					});
-					for (const cb of this.callbacks) cb();
-					this.callbacks.length = 0;
+					for (const cb of cbs) cb(null);
 					this.compiler.hooks.afterDone.call(stats);
 				}
 			);
@@ -250,8 +304,6 @@ class Watching {
 				changedFiles,
 				removedFiles
 			) => {
-				this.pausedWatcher = this.watcher;
-				this.watcher = null;
 				if (err) {
 					this.compiler.modifiedFiles = undefined;
 					this.compiler.removedFiles = undefined;
@@ -259,16 +311,12 @@ class Watching {
 					this.compiler.contextTimestamps = undefined;
 					return this.handler(err);
 				}
-				this.compiler.fileTimestamps = fileTimeInfoEntries;
-				this.compiler.contextTimestamps = contextTimeInfoEntries;
-				this.compiler.removedFiles = removedFiles;
-				this.compiler.modifiedFiles = changedFiles;
-				if (this.watcher) {
-					this.pausedWatcher = this.watcher;
-					this.watcher.pause();
-					this.watcher = null;
-				}
-				this._invalidate();
+				this._invalidate(
+					fileTimeInfoEntries,
+					contextTimeInfoEntries,
+					changedFiles,
+					removedFiles
+				);
 				this._onChange();
 			},
 			(fileName, changeTime) => {
@@ -293,33 +341,30 @@ class Watching {
 			this._invalidReported = true;
 			this.compiler.hooks.invalid.call(null, Date.now());
 		}
+		this._onChange();
 		this._invalidate();
 	}
 
-	_invalidate() {
-		if (this.suspended) return;
-		if (this._isBlocked()) {
-			this.blocked = true;
+	_invalidate(
+		fileTimeInfoEntries,
+		contextTimeInfoEntries,
+		changedFiles,
+		removedFiles
+	) {
+		if (this.suspended || (this._isBlocked() && (this.blocked = true))) {
+			this._mergeWithCollected(changedFiles, removedFiles);
 			return;
 		}
-		if (this.watcher) {
-			this.compiler.modifiedFiles =
-				this.watcher.getAggregatedChanges &&
-				this.watcher.getAggregatedChanges();
-			this.compiler.removedFiles =
-				this.watcher.getAggregatedRemovals &&
-				this.watcher.getAggregatedRemovals();
-			this.compiler.fileTimestamps = this.watcher.getFileTimeInfoEntries();
-			this.compiler.contextTimestamps = this.watcher.getContextTimeInfoEntries();
-			this.pausedWatcher = this.watcher;
-			this.watcher.pause();
-			this.watcher = null;
-		}
 
 		if (this.running) {
 			this.invalid = true;
 		} else {
-			this._go();
+			this._go(
+				fileTimeInfoEntries,
+				contextTimeInfoEntries,
+				changedFiles,
+				removedFiles
+			);
 		}
 	}
 
@@ -334,14 +379,6 @@ class Watching {
 		}
 	}
 
-	_checkUnblocked() {
-		if (this.blocked && !this._isBlocked()) {
-			this.blocked = false;
-			this._needWatcherInfo = true;
-			this._invalidate();
-		}
-	}
-
 	/**
 	 * @param {Callback<void>} callback signals when the watcher is closed
 	 * @returns {void}

package/lib/asset/AssetGenerator.js

@@ -170,9 +170,9 @@ class AssetGenerator extends Generator {
 						hash.update(runtimeTemplate.outputOptions.hashSalt);
 					}
 					hash.update(originalSource.buffer());
-					const fullHash = /** @type {string} */ (hash.digest(
-						runtimeTemplate.outputOptions.hashDigest
-					));
+					const fullHash = /** @type {string} */ (
+						hash.digest(runtimeTemplate.outputOptions.hashDigest)
+					);
 					const contentHash = fullHash.slice(
 						0,
 						runtimeTemplate.outputOptions.hashDigestLength
@@ -183,26 +183,9 @@ class AssetGenerator extends Generator {
 						module.matchResource || module.resource,
 						runtimeTemplate.compilation.compiler.root
 					).replace(/^\.\//, "");
-					let {
-						path: filename,
-						info: assetInfo
-					} = runtimeTemplate.compilation.getAssetPathWithInfo(
-						assetModuleFilename,
-						{
-							module,
-							runtime,
-							filename: sourceFilename,
-							chunkGraph,
-							contentHash
-						}
-					);
-					let publicPath;
-					if (this.publicPath) {
-						const {
-							path,
-							info
-						} = runtimeTemplate.compilation.getAssetPathWithInfo(
-							this.publicPath,
+					let { path: filename, info: assetInfo } =
+						runtimeTemplate.compilation.getAssetPathWithInfo(
+							assetModuleFilename,
 							{
 								module,
 								runtime,
@@ -211,6 +194,19 @@ class AssetGenerator extends Generator {
 								contentHash
 							}
 						);
+					let publicPath;
+					if (this.publicPath) {
+						const { path, info } =
+							runtimeTemplate.compilation.getAssetPathWithInfo(
+								this.publicPath,
+								{
+									module,
+									runtime,
+									filename: sourceFilename,
+									chunkGraph,
+									contentHash
+								}
+							);
 						publicPath = JSON.stringify(path);
 						assetInfo = mergeAssetInfo(assetInfo, info);
 					} else {