webpack 5.26.3 → 5.28.0

package/lib/MultiCompiler.js

@@ -457,7 +457,7 @@ module.exports = class MultiCompiler {
 					node.compiler,
 					i,
 					nodeDone.bind(null, node),
-					() => node.state !== "running",
+					() => node.state !== "done" && node.state !== "running",
 					() => nodeChange(node),
 					() => nodeInvalid(node)
 				)

package/lib/NormalModule.js

@@ -37,7 +37,7 @@ const {
 } = require("./util/comparators");
 const createHash = require("./util/createHash");
 const { join } = require("./util/fs");
-const { contextify } = require("./util/identifier");
+const { contextify, absolutify } = require("./util/identifier");
 const makeSerializable = require("./util/makeSerializable");
 const memoize = require("./util/memoize");
 
@@ -367,6 +367,7 @@ class NormalModule extends Module {
 	 * @param {NormalModuleFactory} normalModuleFactory the normal module factory handling the unsafe caching
 	 */
 	_restoreFromUnsafeCache(unsafeCacheData, normalModuleFactory) {
+		super._restoreFromUnsafeCache(unsafeCacheData, normalModuleFactory);
 		this.parserOptions = unsafeCacheData.parserOptions;
 		this.parser = normalModuleFactory.getParser(this.type, this.parserOptions);
 		this.generatorOptions = unsafeCacheData.generatorOptions;
@@ -441,6 +442,30 @@ class NormalModule extends Module {
 				}
 			};
 		};
+		const getAbsolutify = memoize(() =>
+			absolutify.bindCache(compilation.compiler.root)
+		);
+		const getAbsolutifyInContext = memoize(() =>
+			absolutify.bindContextCache(this.context, compilation.compiler.root)
+		);
+		const getContextify = memoize(() =>
+			contextify.bindCache(compilation.compiler.root)
+		);
+		const getContextifyInContext = memoize(() =>
+			contextify.bindContextCache(this.context, compilation.compiler.root)
+		);
+		const utils = {
+			absolutify: (context, request) => {
+				return context === this.context
+					? getAbsolutifyInContext()(request)
+					: getAbsolutify()(context, request);
+			},
+			contextify: (context, request) => {
+				return context === this.context
+					? getContextifyInContext()(request)
+					: getContextify()(context, request);
+			}
+		};
 		const loaderContext = {
 			version: 2,
 			getOptions: schema => {
@@ -553,6 +578,7 @@ class NormalModule extends Module {
 				}
 				this.buildInfo.buildDependencies.add(dep);
 			},
+			utils,
 			rootContext: options.context,
 			webpack: true,
 			sourceMap: !!this.useSourceMap,
@@ -693,7 +719,12 @@ class NormalModule extends Module {
 
 		const hooks = NormalModule.getCompilationHooks(compilation);
 
-		hooks.beforeLoaders.call(this.loaders, this, loaderContext);
+		try {
+			hooks.beforeLoaders.call(this.loaders, this, loaderContext);
+		} catch (err) {
+			processResult(err);
+			return;
+		}
 		runLoaders(
 			{
 				resource: this.resource,

package/lib/NormalModuleFactory.js

@@ -597,7 +597,7 @@ class NormalModuleFactory extends ModuleFactory {
 				}
 
 				// resource without scheme and without path
-				else if (/^($|\?|#)/.test(unresolvedResource)) {
+				else if (/^($|\?)/.test(unresolvedResource)) {
 					resourceData = {
 						resource: unresolvedResource,
 						data: {},

package/lib/RecordIdsPlugin.js

@@ -213,6 +213,7 @@ class RecordIdsPlugin {
 					}
 					if (records.chunks.bySource) {
 						for (const chunk of chunks) {
+							if (chunk.id !== null) continue;
 							const sources = getChunkSources(chunk);
 							for (const source of sources) {
 								const id = records.chunks.bySource[source];

package/lib/asset/AssetGenerator.js

@@ -15,6 +15,7 @@ const { makePathsRelative } = require("../util/identifier");
 
 /** @typedef {import("webpack-sources").Source} Source */
 /** @typedef {import("../../declarations/WebpackOptions").AssetGeneratorOptions} AssetGeneratorOptions */
+/** @typedef {import("../../declarations/WebpackOptions").RawPublicPath} RawPublicPath */
 /** @typedef {import("../Compilation")} Compilation */
 /** @typedef {import("../Compiler")} Compiler */
 /** @typedef {import("../Generator").GenerateContext} GenerateContext */
@@ -24,6 +25,55 @@ const { makePathsRelative } = require("../util/identifier");
 /** @typedef {import("../RuntimeTemplate")} RuntimeTemplate */
 /** @typedef {import("../util/Hash")} Hash */
 
+const mergeMaybeArrays = (a, b) => {
+	const set = new Set();
+	if (Array.isArray(a)) for (const item of a) set.add(item);
+	else set.add(a);
+	if (Array.isArray(b)) for (const item of b) set.add(item);
+	else set.add(b);
+	return Array.from(set);
+};
+
+const mergeAssetInfo = (a, b) => {
+	const result = { ...a, ...b };
+	for (const key of Object.keys(a)) {
+		if (key in b) {
+			if (a[key] === b[key]) continue;
+			switch (key) {
+				case "fullhash":
+				case "chunkhash":
+				case "modulehash":
+				case "contenthash":
+					result[key] = mergeMaybeArrays(a[key], b[key]);
+					break;
+				case "immutable":
+				case "development":
+				case "hotModuleReplacement":
+				case "javascriptModule	":
+					result[key] = a[key] || b[key];
+					break;
+				case "related":
+					result[key] = mergeRelatedInfo(a[key], b[key]);
+					break;
+				default:
+					throw new Error(`Can't handle conflicting asset info for ${key}`);
+			}
+		}
+	}
+	return result;
+};
+
+const mergeRelatedInfo = (a, b) => {
+	const result = { ...a, ...b };
+	for (const key of Object.keys(a)) {
+		if (key in b) {
+			if (a[key] === b[key]) continue;
+			result[key] = mergeMaybeArrays(a[key], b[key]);
+		}
+	}
+	return result;
+};
+
 const JS_TYPES = new Set(["javascript"]);
 const JS_AND_ASSET_TYPES = new Set(["javascript", "asset"]);
 
@@ -31,12 +81,14 @@ class AssetGenerator extends Generator {
 	/**
 	 * @param {AssetGeneratorOptions["dataUrl"]=} dataUrlOptions the options for the data url
 	 * @param {string=} filename override for output.assetModuleFilename
+	 * @param {RawPublicPath=} publicPath override for output.assetModulePublicPath
 	 * @param {boolean=} emit generate output asset
 	 */
-	constructor(dataUrlOptions, filename, emit) {
+	constructor(dataUrlOptions, filename, publicPath, emit) {
 		super();
 		this.dataUrlOptions = dataUrlOptions;
 		this.filename = filename;
+		this.publicPath = publicPath;
 		this.emit = emit;
 	}
 
@@ -131,9 +183,9 @@ class AssetGenerator extends Generator {
 						module.matchResource || module.resource,
 						runtimeTemplate.compilation.compiler.root
 					).replace(/^\.\//, "");
-					const {
+					let {
 						path: filename,
-						info
+						info: assetInfo
 					} = runtimeTemplate.compilation.getAssetPathWithInfo(
 						assetModuleFilename,
 						{
@@ -144,11 +196,33 @@ class AssetGenerator extends Generator {
 							contentHash
 						}
 					);
-					module.buildInfo.filename = filename;
-					module.buildInfo.assetInfo = {
+					let publicPath;
+					if (this.publicPath) {
+						const {
+							path,
+							info
+						} = runtimeTemplate.compilation.getAssetPathWithInfo(
+							this.publicPath,
+							{
+								module,
+								runtime,
+								filename: sourceFilename,
+								chunkGraph,
+								contentHash
+							}
+						);
+						publicPath = JSON.stringify(path);
+						assetInfo = mergeAssetInfo(assetInfo, info);
+					} else {
+						publicPath = RuntimeGlobals.publicPath;
+						runtimeRequirements.add(RuntimeGlobals.publicPath); // add __webpack_require__.p
+					}
+					assetInfo = {
 						sourceFilename,
-						...info
+						...assetInfo
 					};
+					module.buildInfo.filename = filename;
+					module.buildInfo.assetInfo = assetInfo;
 					if (getData) {
 						// Due to code generation caching module.buildInfo.XXX can't used to store such information
 						// It need to be stored in the code generation results instead, where it's cached too
@@ -156,15 +230,13 @@ class AssetGenerator extends Generator {
 						const data = getData();
 						data.set("fullContentHash", fullHash);
 						data.set("filename", filename);
-						data.set("assetInfo", info);
+						data.set("assetInfo", assetInfo);
 					}
 
-					runtimeRequirements.add(RuntimeGlobals.publicPath); // add __webpack_require__.p
-
 					return new RawSource(
-						`${RuntimeGlobals.module}.exports = ${
-							RuntimeGlobals.publicPath
-						} + ${JSON.stringify(filename)};`
+						`${
+							RuntimeGlobals.module
+						}.exports = ${publicPath} + ${JSON.stringify(filename)};`
 					);
 				}
 			}

package/lib/asset/AssetModulesPlugin.js

@@ -118,8 +118,10 @@ class AssetModulesPlugin {
 							}
 
 							let filename = undefined;
+							let publicPath = undefined;
 							if (type !== "asset/inline") {
 								filename = generatorOptions.filename;
+								publicPath = generatorOptions.publicPath;
 							}
 
 							const AssetGenerator = getAssetGenerator();
@@ -127,6 +129,7 @@ class AssetModulesPlugin {
 							return new AssetGenerator(
 								dataUrl,
 								filename,
+								publicPath,
 								generatorOptions.emit !== false
 							);
 						});

package/lib/dependencies/WorkerDependency.js

@@ -77,9 +77,9 @@ WorkerDependency.Template = class WorkerDependencyTemplate extends (
 		source.replace(
 			dep.range[0],
 			dep.range[1] - 1,
-			`new URL(/* worker import */ ${RuntimeGlobals.publicPath} + ${
+			`/* worker import */ ${RuntimeGlobals.publicPath} + ${
 				RuntimeGlobals.getChunkScriptFilename
-			}(${JSON.stringify(chunk.id)}), ${RuntimeGlobals.baseURI})`
+			}(${JSON.stringify(chunk.id)}), ${RuntimeGlobals.baseURI}`
 		);
 	}
 };

package/lib/dependencies/WorkerPlugin.js

@@ -294,7 +294,7 @@ class WorkerPlugin {
 							}
 						} else if (hasSpreadInOptions && insertType === "comma") {
 							const dep = new ConstDependency(
-								",type: undefined",
+								", type: undefined",
 								insertLocation
 							);
 							dep.loc = expr.loc;

package/lib/hmr/LazyCompilationPlugin.js

@@ -32,6 +32,13 @@ const { registerNotSerializable } = require("../util/serialization");
 /** @typedef {import("../util/Hash")} Hash */
 /** @typedef {import("../util/fs").InputFileSystem} InputFileSystem */
 
+const IGNORED_DEPENDENCY_TYPES = new Set([
+	"import.meta.webpackHot.accept",
+	"import.meta.webpackHot.decline",
+	"module.hot.accept",
+	"module.hot.decline"
+]);
+
 /**
  * @param {undefined|string|RegExp|Function} test test option
  * @param {Module} module the module
@@ -56,9 +63,9 @@ const checkTest = (test, module) => {
 const TYPES = new Set(["javascript"]);
 
 class LazyCompilationDependency extends Dependency {
-	constructor(originalModule) {
+	constructor(proxyModule) {
 		super();
-		this.originalModule = originalModule;
+		this.proxyModule = proxyModule;
 	}
 
 	get category() {
@@ -73,7 +80,7 @@ class LazyCompilationDependency extends Dependency {
 	 * @returns {string | null} an identifier to merge equal requests
 	 */
 	getResourceIdentifier() {
-		return this.originalModule.identifier();
+		return this.proxyModule.originalModule.identifier();
 	}
 }
 
@@ -116,6 +123,10 @@ class LazyCompilationProxyModule extends Module {
 	updateCacheModule(module) {
 		super.updateCacheModule(module);
 		const m = /** @type {LazyCompilationProxyModule} */ (module);
+		this.originalModule = m.originalModule;
+		this.request = m.request;
+		this.client = m.client;
+		this.data = m.data;
 		this.active = m.active;
 	}
 
@@ -154,7 +165,7 @@ class LazyCompilationProxyModule extends Module {
 		const dep = new CommonJsRequireDependency(this.client);
 		this.addDependency(dep);
 		if (this.active) {
-			const dep = new LazyCompilationDependency(this.originalModule);
+			const dep = new LazyCompilationDependency(this);
 			const block = new AsyncDependenciesBlock({});
 			block.addDependency(dep);
 			this.addBlock(block);
@@ -282,7 +293,7 @@ class LazyCompilationDependencyFactory extends ModuleFactory {
 		const dependency = /** @type {LazyCompilationDependency} */ (data
 			.dependencies[0]);
 		callback(null, {
-			module: dependency.originalModule
+			module: dependency.proxyModule.originalModule
 		});
 	}
 }
@@ -336,6 +347,7 @@ class LazyCompilationPlugin {
 						if (
 							resolveData.dependencies.every(
 								dep =>
+									IGNORED_DEPENDENCY_TYPES.has(dep.type) ||
 									(this.imports && dep.type === "import()") ||
 									(this.entries && dep.type === "entry")
 							) &&

package/lib/javascript/ArrayPushCallbackChunkFormatPlugin.js

@@ -10,7 +10,10 @@ const { RuntimeGlobals } = require("..");
 const HotUpdateChunk = require("../HotUpdateChunk");
 const Template = require("../Template");
 const { getCompilationHooks } = require("./JavascriptModulesPlugin");
-const { generateEntryStartup } = require("./StartupHelpers");
+const {
+	generateEntryStartup,
+	updateHashForEntryStartup
+} = require("./StartupHelpers");
 
 /** @typedef {import("../Compiler")} Compiler */
 
@@ -140,6 +143,10 @@ class ArrayPushCallbackChunkFormatPlugin {
 						hash.update(`${runtimeTemplate.outputOptions.chunkLoadingGlobal}`);
 						hash.update(`${runtimeTemplate.outputOptions.hotUpdateGlobal}`);
 						hash.update(`${runtimeTemplate.outputOptions.globalObject}`);
+						const entries = Array.from(
+							chunkGraph.getChunkEntryModulesWithChunkGroupIterable(chunk)
+						);
+						updateHashForEntryStartup(hash, chunkGraph, entries, chunk);
 					}
 				);
 			}

package/lib/javascript/CommonJsChunkFormatPlugin.js

@@ -12,7 +12,10 @@ const {
 	getChunkFilenameTemplate,
 	getCompilationHooks
 } = require("./JavascriptModulesPlugin");
-const { generateEntryStartup } = require("./StartupHelpers");
+const {
+	generateEntryStartup,
+	updateHashForEntryStartup
+} = require("./StartupHelpers");
 
 /** @typedef {import("../Compiler")} Compiler */
 
@@ -156,6 +159,10 @@ class CommonJsChunkFormatPlugin {
 						if (chunk.hasRuntime()) return;
 						hash.update("CommonJsChunkFormatPlugin");
 						hash.update("1");
+						const entries = Array.from(
+							chunkGraph.getChunkEntryModulesWithChunkGroupIterable(chunk)
+						);
+						updateHashForEntryStartup(hash, chunkGraph, entries, chunk);
 					}
 				);
 			}

package/lib/javascript/StartupHelpers.js

@@ -11,6 +11,7 @@ const Template = require("../Template");
 const { isSubset } = require("../util/SetHelpers");
 const { chunkHasJs } = require("./JavascriptModulesPlugin");
 
+/** @typedef {import("../util/Hash")} Hash */
 /** @typedef {import("../Chunk")} Chunk */
 /** @typedef {import("../Compilation")} Compilation */
 /** @typedef {import("../ChunkGraph")} ChunkGraph */
@@ -71,21 +72,24 @@ exports.generateEntryStartup = (
 		return `__webpack_exec__(${JSON.stringify(id)})`;
 	};
 	const outputCombination = (chunks, moduleIds, final) => {
-		const old = final ? "undefined" : "0";
-		const prefix = final ? EXPORT_PREFIX : "";
 		if (chunks.size === 0) {
-			runtime.push(`${prefix}(${moduleIds.map(runModule).join(", ")});`);
+			runtime.push(
+				`${final ? EXPORT_PREFIX : ""}(${moduleIds.map(runModule).join(", ")});`
+			);
 		} else {
 			const fn = runtimeTemplate.returningFunction(
 				moduleIds.map(runModule).join(", ")
 			);
 			runtime.push(
-				`${prefix}${
+				`${final && !passive ? EXPORT_PREFIX : ""}${
 					passive
 						? RuntimeGlobals.onChunksLoaded
 						: RuntimeGlobals.startupEntrypoint
-				}(${old}, ${JSON.stringify(Array.from(chunks, c => c.id))}, ${fn});`
+				}(0, ${JSON.stringify(Array.from(chunks, c => c.id))}, ${fn});`
 			);
+			if (final && passive) {
+				runtime.push(`${EXPORT_PREFIX}${RuntimeGlobals.onChunksLoaded}();`);
+			}
 		}
 	};
 
@@ -119,6 +123,23 @@ exports.generateEntryStartup = (
 	return Template.asString(runtime);
 };
 
+/**
+ * @param {Hash} hash the hash to update
+ * @param {ChunkGraph} chunkGraph chunkGraph
+ * @param {import("../ChunkGraph").EntryModuleWithChunkGroup[]} entries entries
+ * @param {Chunk} chunk chunk
+ * @returns {void}
+ */
+exports.updateHashForEntryStartup = (hash, chunkGraph, entries, chunk) => {
+	for (const [module, entrypoint] of entries) {
+		const runtimeChunk = entrypoint.getRuntimeChunk();
+		const moduleId = chunkGraph.getModuleId(module);
+		hash.update(`${moduleId}`);
+		for (const c of getAllChunks(entrypoint, chunk, runtimeChunk))
+			hash.update(`${c.id}`);
+	}
+};
+
 /**
  * @param {Chunk} chunk the chunk
  * @param {ChunkGraph} chunkGraph the chunk graph

package/lib/serialization/ObjectMiddleware.js

@@ -408,16 +408,13 @@ class ObjectMiddleware extends SerializerMiddleware {
 		};
 		this.extendContext(ctx);
 		const process = item => {
-			// check if we can emit a reference
-			const ref = referenceable.get(item);
-
-			if (ref !== undefined) {
-				result.push(ESCAPE, ref - currentPos);
-
-				return;
-			}
-
 			if (Buffer.isBuffer(item)) {
+				// check if we can emit a reference
+				const ref = referenceable.get(item);
+				if (ref !== undefined) {
+					result.push(ESCAPE, ref - currentPos);
+					return;
+				}
 				const alreadyUsedBuffer = dedupeBuffer(item);
 				if (alreadyUsedBuffer !== item) {
 					const ref = referenceable.get(alreadyUsedBuffer);
@@ -431,7 +428,19 @@ class ObjectMiddleware extends SerializerMiddleware {
 				addReferenceable(item);
 
 				result.push(item);
-			} else if (typeof item === "object" && item !== null) {
+			} else if (item === ESCAPE) {
+				result.push(ESCAPE, ESCAPE_ESCAPE_VALUE);
+			} else if (
+				typeof item === "object"
+				// We don't have to check for null as ESCAPE is null and this has been checked before
+			) {
+				// check if we can emit a reference
+				const ref = referenceable.get(item);
+				if (ref !== undefined) {
+					result.push(ESCAPE, ref - currentPos);
+					return;
+				}
+
 				if (cycleStack.has(item)) {
 					throw new Error(`Circular references can't be serialized`);
 				}
@@ -464,6 +473,12 @@ class ObjectMiddleware extends SerializerMiddleware {
 			} else if (typeof item === "string") {
 				if (item.length > 1) {
 					// short strings are shorter when not emitting a reference (this saves 1 byte per empty string)
+					// check if we can emit a reference
+					const ref = referenceable.get(item);
+					if (ref !== undefined) {
+						result.push(ESCAPE, ref - currentPos);
+						return;
+					}
 					addReferenceable(item);
 				}
 
@@ -476,8 +491,6 @@ class ObjectMiddleware extends SerializerMiddleware {
 				}
 
 				result.push(item);
-			} else if (item === ESCAPE) {
-				result.push(ESCAPE, ESCAPE_ESCAPE_VALUE);
 			} else if (typeof item === "function") {
 				if (!SerializerMiddleware.isLazy(item))
 					throw new Error("Unexpected function " + item);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "webpack",
-  "version": "5.26.3",
+  "version": "5.28.0",
   "author": "Tobias Koppers @sokra",
   "description": "Packs CommonJs/AMD modules for the browser. Allows to split your codebase into multiple bundles, which can be loaded on demand. Support loaders to preprocess files, i.e. json, jsx, es7, css, less, ... and your custom stuff.",
   "license": "MIT",

package/schemas/WebpackOptions.json

@@ -107,6 +107,9 @@
         },
         "filename": {
           "$ref": "#/definitions/FilenameTemplate"
+        },
+        "publicPath": {
+          "$ref": "#/definitions/RawPublicPath"
         }
       }
     },
@@ -178,6 +181,9 @@
         },
         "filename": {
           "$ref": "#/definitions/FilenameTemplate"
+        },
+        "publicPath": {
+          "$ref": "#/definitions/RawPublicPath"
         }
       }
     },
@@ -2912,11 +2918,19 @@
       "type": "boolean"
     },
     "PublicPath": {
-      "description": "The `publicPath` specifies the public URL address of the output files when referenced in a browser.",
+      "description": "The 'publicPath' specifies the public URL address of the output files when referenced in a browser.",
       "anyOf": [
         {
           "enum": ["auto"]
         },
+        {
+          "$ref": "#/definitions/RawPublicPath"
+        }
+      ]
+    },
+    "RawPublicPath": {
+      "description": "The 'publicPath' specifies the public URL address of the output files when referenced in a browser.",
+      "anyOf": [
         {
           "type": "string"
         },

package/types.d.ts

@@ -312,6 +312,11 @@ declare interface AssetResourceGeneratorOptions {
 	 * Specifies the filename template of output files on disk. You must **not** specify an absolute path here, but the path may contain folders separated by '/'! The specified path is joined with the value of the 'output.path' option to determine the location on disk.
 	 */
 	filename?: string | ((pathData: PathData, assetInfo?: AssetInfo) => string);
+
+	/**
+	 * The 'publicPath' specifies the public URL address of the output files when referenced in a browser.
+	 */
+	publicPath?: string | ((pathData: PathData, assetInfo?: AssetInfo) => string);
 }
 declare abstract class AsyncDependenciesBlock extends DependenciesBlock {
 	groupOptions: RawChunkGroupOptions & { name?: string } & {
@@ -7388,7 +7393,7 @@ declare interface Output {
 	pathinfo?: boolean | "verbose";
 
 	/**
-	 * The `publicPath` specifies the public URL address of the output files when referenced in a browser.
+	 * The 'publicPath' specifies the public URL address of the output files when referenced in a browser.
 	 */
 	publicPath?: string | ((pathData: PathData, assetInfo?: AssetInfo) => string);
 
@@ -7650,7 +7655,7 @@ declare interface OutputNormalized {
 	pathinfo?: boolean | "verbose";
 
 	/**
-	 * The `publicPath` specifies the public URL address of the output files when referenced in a browser.
+	 * The 'publicPath' specifies the public URL address of the output files when referenced in a browser.
 	 */
 	publicPath?: string | ((pathData: PathData, assetInfo?: AssetInfo) => string);