webpack 5.108.4 → 5.109.0

package/lib/APIPlugin.js

@@ -31,9 +31,22 @@ const GetFullHashRuntimeModule = require("./runtime/GetFullHashRuntimeModule");
 /** @typedef {import("./Dependency").DependencyLocation} DependencyLocation */
 /** @typedef {import("./Module").BuildInfo} BuildInfo */
 /** @typedef {import("./javascript/JavascriptModule").JavascriptModuleBuildInfo} JavascriptModuleBuildInfo */
+/** @typedef {import("./Compilation")} Compilation */
 /** @typedef {import("./javascript/JavascriptParser")} JavascriptParser */
 /** @typedef {import("./javascript/JavascriptParser").Range} Range */
 
+// Compilations where a module reassigns `__webpack_public_path__` at runtime.
+// A baked analyzable specifier can't reflect that, so those forms fall back.
+/** @type {WeakSet<Compilation>} */
+const runtimePublicPathOverride = new WeakSet();
+
+/**
+ * @param {Compilation} compilation compilation
+ * @returns {boolean} true when a module reassigns `__webpack_public_path__` at runtime
+ */
+const usesRuntimePublicPathOverride = (compilation) =>
+	runtimePublicPathOverride.has(compilation);
+
 /**
  * Returns the replacement definitions used for webpack API identifiers.
  * @returns {Record<string, { expr: string, req: string[] | null, type?: string, assign: boolean }>} replacements
@@ -225,27 +238,28 @@ class APIPlugin {
 						}
 					});
 
-					parser.hooks.preStatement.tap(PLUGIN_NAME, (statement) => {
-						if (parser.scope.topLevelScope === true) {
-							if (
-								statement.type === "FunctionDeclaration" &&
-								statement.id &&
-								statement.id.name === "module"
-							) {
-								/** @type {BuildInfo} */
-								(parser.state.module.buildInfo).moduleArgument =
-									"__webpack_module__";
-							} else if (
-								statement.type === "ClassDeclaration" &&
-								statement.id &&
-								statement.id.name === "module"
-							) {
-								/** @type {BuildInfo} */
-								(parser.state.module.buildInfo).moduleArgument =
-									"__webpack_module__";
-							}
+					/**
+					 * @param {import("estree").Statement | import("estree").ModuleDeclaration | import("estree").MaybeNamedFunctionDeclaration | import("estree").MaybeNamedClassDeclaration} statement statement
+					 */
+					const moduleDeclarationHandler = (statement) => {
+						if (
+							parser.scope.topLevelScope === true &&
+							(statement.type === "FunctionDeclaration" ||
+								statement.type === "ClassDeclaration") &&
+							statement.id &&
+							statement.id.name === "module"
+						) {
+							/** @type {BuildInfo} */
+							(parser.state.module.buildInfo).moduleArgument =
+								"__webpack_module__";
 						}
-					});
+					};
+					parser.hooks.preStatementByType
+						.for("FunctionDeclaration")
+						.tap(PLUGIN_NAME, moduleDeclarationHandler);
+					parser.hooks.preStatementByType
+						.for("ClassDeclaration")
+						.tap(PLUGIN_NAME, moduleDeclarationHandler);
 
 					for (const key of Object.keys(REPLACEMENTS)) {
 						const info = REPLACEMENTS[key];
@@ -260,9 +274,7 @@ class APIPlugin {
 									const warning = new WebpackError(
 										`${PLUGIN_NAME}\n__non_webpack_require__ is only allowed in target node`
 									);
-									warning.loc = /** @type {DependencyLocation} */ (
-										expression.loc
-									);
+									warning.loc = parser.getLocation(expression);
 									warning.module = parser.state.module;
 									compilation.warnings.push(warning);
 								}
@@ -273,9 +285,15 @@ class APIPlugin {
 						if (info.assign === false) {
 							parser.hooks.assign.for(key).tap(PLUGIN_NAME, (expr) => {
 								const err = new WebpackError(`${key} must not be assigned`);
-								err.loc = /** @type {DependencyLocation} */ (expr.loc);
+								err.loc = parser.getLocation(expr);
 								throw err;
 							});
+						} else if (key === "__webpack_public_path__") {
+							// Flag the runtime override (still let the default handler emit
+							// `__webpack_require__.p = …`); returning nothing keeps that path.
+							parser.hooks.assign.for(key).tap(PLUGIN_NAME, () => {
+								runtimePublicPathOverride.add(compilation);
+							});
 						}
 						if (info.type) {
 							parser.hooks.evaluateTypeof
@@ -291,7 +309,7 @@ class APIPlugin {
 								JSON.stringify(parser.state.module.layer),
 								/** @type {Range} */ (expr.range)
 							);
-							dep.loc = /** @type {DependencyLocation} */ (expr.loc);
+							dep.loc = parser.getLocation(expr);
 							parser.state.module.addPresentationalDependency(dep);
 							return true;
 						});
@@ -326,7 +344,7 @@ class APIPlugin {
 								const dep = new RuntimeRequirementsDependency([
 									RuntimeGlobals.moduleId
 								]);
-								dep.loc = /** @type {DependencyLocation} */ (expr.loc);
+								dep.loc = parser.getLocation(expr);
 								parser.state.module.addPresentationalDependency(dep);
 							} else {
 								const initDep = new ModuleInitFragmentDependency(
@@ -340,7 +358,7 @@ class APIPlugin {
 									/** @type {Range} */ (expr.range),
 									[]
 								);
-								dep.loc = /** @type {DependencyLocation} */ (expr.loc);
+								dep.loc = parser.getLocation(expr);
 								parser.state.module.addPresentationalDependency(dep);
 							}
 							return true;
@@ -357,7 +375,7 @@ class APIPlugin {
 								const dep = new RuntimeRequirementsDependency([
 									RuntimeGlobals.module
 								]);
-								dep.loc = /** @type {DependencyLocation} */ (expr.loc);
+								dep.loc = parser.getLocation(expr);
 								parser.state.module.addPresentationalDependency(dep);
 							} else {
 								const initDep = new ModuleInitFragmentDependency(
@@ -371,7 +389,7 @@ class APIPlugin {
 									/** @type {Range} */ (expr.range),
 									[]
 								);
-								dep.loc = /** @type {DependencyLocation} */ (expr.loc);
+								dep.loc = parser.getLocation(expr);
 								parser.state.module.addPresentationalDependency(dep);
 							}
 							return true;
@@ -396,3 +414,4 @@ class APIPlugin {
 }
 
 module.exports = APIPlugin;
+module.exports.usesRuntimePublicPathOverride = usesRuntimePublicPathOverride;

package/lib/CacheFacade.js

@@ -227,6 +227,14 @@ class CacheFacade {
 		this._hashFunction = hashFunction;
 	}
 
+	/**
+	 * Returns whether a cache backend is active.
+	 * @returns {boolean} true, when get or store can have an effect
+	 */
+	isEnabled() {
+		return this._cache.hooks.get.isUsed() || this._cache.hooks.store.isUsed();
+	}
+
 	/**
 	 * Returns child cache.
 	 * @param {string} name the child cache name#

package/lib/ChunkGroup.js

@@ -30,6 +30,7 @@ const {
  * @typedef {object} RawChunkGroupOptions
  * @property {number=} preloadOrder
  * @property {number=} prefetchOrder
+ * @property {number=} cssPreloadOrder preload only the chunk's CSS (`as="style"`), not its JS
  * @property {("low" | "high" | "auto")=} fetchPriority
  */
 

package/lib/CompatibilityPlugin.js

@@ -89,7 +89,7 @@ class CompatibilityPlugin {
 									"require",
 									/** @type {Range} */ (expr.callee.range)
 								);
-								dep.loc = /** @type {DependencyLocation} */ (expr.loc);
+								dep.loc = parser.getLocation(expr);
 								if (parser.state.current.dependencies.length > 0) {
 									const last =
 										/** @type {ContextDependency} */
@@ -122,31 +122,33 @@ class CompatibilityPlugin {
 				 */
 				const handler = (parser) => {
 					// Handle nested requires
-					parser.hooks.preStatement.tap(PLUGIN_NAME, (statement) => {
-						if (
-							statement.type === "FunctionDeclaration" &&
-							statement.id &&
-							statement.id.name === RuntimeGlobals.require
-						) {
-							const newName = `__nested_webpack_require_${
-								/** @type {Range} */
-								(statement.range)[0]
-							}__`;
-							parser.tagVariable(
-								statement.id.name,
-								nestedWebpackIdentifierTag,
-								{
-									name: newName,
-									declaration: {
-										updated: false,
-										loc: /** @type {DependencyLocation} */ (statement.id.loc),
-										range: /** @type {Range} */ (statement.id.range)
+					parser.hooks.preStatementByType
+						.for("FunctionDeclaration")
+						.tap(PLUGIN_NAME, (statement) => {
+							if (
+								statement.type === "FunctionDeclaration" &&
+								statement.id &&
+								statement.id.name === RuntimeGlobals.require
+							) {
+								const newName = `__nested_webpack_require_${
+									/** @type {Range} */
+									(statement.range)[0]
+								}__`;
+								parser.tagVariable(
+									statement.id.name,
+									nestedWebpackIdentifierTag,
+									{
+										name: newName,
+										declaration: {
+											updated: false,
+											loc: parser.getLocation(statement.id),
+											range: /** @type {Range} */ (statement.id.range)
+										}
 									}
-								}
-							);
-							return true;
-						}
-					});
+								);
+								return true;
+							}
+						});
 					parser.hooks.pattern
 						.for(RuntimeGlobals.require)
 						.tap(PLUGIN_NAME, (pattern) => {
@@ -157,7 +159,7 @@ class CompatibilityPlugin {
 								name: newName,
 								declaration: {
 									updated: false,
-									loc: /** @type {DependencyLocation} */ (pattern.loc),
+									loc: parser.getLocation(pattern),
 									range: /** @type {Range} */ (pattern.range)
 								}
 							});
@@ -173,7 +175,7 @@ class CompatibilityPlugin {
 								name: newName,
 								declaration: {
 									updated: false,
-									loc: /** @type {DependencyLocation} */ (pattern.loc),
+									loc: parser.getLocation(pattern),
 									range: /** @type {Range} */ (pattern.range)
 								}
 							});
@@ -218,7 +220,7 @@ class CompatibilityPlugin {
 								name,
 								/** @type {Range} */ (expr.range)
 							);
-							dep.loc = /** @type {DependencyLocation} */ (expr.loc);
+							dep.loc = parser.getLocation(expr);
 							parser.state.module.addPresentationalDependency(dep);
 							return true;
 						});
@@ -231,7 +233,7 @@ class CompatibilityPlugin {
 							if (parser.state.source.slice(0, 2).toString() !== "#!") return;
 							// this is a hashbang comment
 							const dep = new ConstDependency("//", 0);
-							dep.loc = /** @type {DependencyLocation} */ (c.loc);
+							dep.loc = parser.getLocation(c);
 							parser.state.module.addPresentationalDependency(dep);
 						}
 					});

package/lib/Compilation.js

@@ -251,6 +251,7 @@ const { isSourceEqual } = require("./util/source");
  * @typedef {object} ExecuteModuleResult
  * @property {ExecuteModuleExports} exports
  * @property {boolean} cacheable
+ * @property {string[]} notCacheableReasons reasons why the executed modules are not cacheable
  * @property {ExecuteModuleAssets} assets
  * @property {FileSystemDependencies} fileDependencies
  * @property {FileSystemDependencies} contextDependencies
@@ -4084,6 +4085,7 @@ Or do you want to use the entrypoints '${name}' and '${runtime}' independently o
 	 * @param {WebpackError[]} errors errors
 	 * @param {CodeGenerationResults} results results
 	 * @param {(err?: WebpackError | null, result?: boolean) => void} callback callback
+	 * @returns {void}
 	 */
 	_codeGenerationModule(
 		module,
@@ -4099,6 +4101,39 @@ Or do you want to use the entrypoints '${name}' and '${runtime}' independently o
 		callback
 	) {
 		let codeGenerated = false;
+		// without a cache backend, skip building the cache keys — the module
+		// identifier strings are large (concatenated modules join all inner ids)
+		if (!this._codeGenerationCache.isEnabled()) {
+			/** @type {CodeGenerationResult} */
+			let result;
+			try {
+				codeGenerated = true;
+				this.codeGeneratedModules.add(module);
+				result = module.codeGeneration({
+					chunkGraph,
+					moduleGraph,
+					dependencyTemplates,
+					runtimeTemplate,
+					runtime,
+					runtimes,
+					codeGenerationResults: results,
+					compilation: this
+				});
+			} catch (err) {
+				errors.push(
+					new CodeGenerationError(module, /** @type {Error} */ (err))
+				);
+				result = {
+					sources: new Map(),
+					runtimeRequirements: null,
+					data: undefined
+				};
+			}
+			for (const runtime of runtimes) {
+				results.add(module, runtime, result);
+			}
+			return callback(null, codeGenerated);
+		}
 		const cache = new MultiItemCache(
 			runtimes.map((runtime) =>
 				this._codeGenerationCache.getItemCache(
@@ -5990,6 +6025,8 @@ This prevents using hashes of each other and should be avoided.`);
 								const assets = new Map();
 
 								let cacheable = true;
+								/** @type {ExecuteModuleResult["notCacheableReasons"]} */
+								const notCacheableReasons = [];
 
 								/** @type {ExecuteModuleContext} */
 								const context = {
@@ -6025,11 +6062,18 @@ This prevents using hashes of each other and should be avoided.`);
 											missingDependencies,
 											buildDependencies
 										);
-										if (
-											/** @type {BuildInfo} */ (module.buildInfo).cacheable ===
-											false
-										) {
+										const buildInfo = /** @type {BuildInfo} */ (
+											module.buildInfo
+										);
+										if (buildInfo.cacheable === false) {
 											cacheable = false;
+											if (buildInfo.notCacheableReasons) {
+												for (const reason of buildInfo.notCacheableReasons) {
+													if (!notCacheableReasons.includes(reason)) {
+														notCacheableReasons.push(reason);
+													}
+												}
+											}
 										}
 										if (module.buildInfo && module.buildInfo.assets) {
 											const { assets: moduleAssets, assetsInfo } =
@@ -6181,6 +6225,7 @@ This prevents using hashes of each other and should be avoided.`);
 											exports,
 											assets,
 											cacheable,
+											notCacheableReasons,
 											fileDependencies,
 											contextDependencies,
 											missingDependencies,

package/lib/ConstPlugin.js

@@ -175,7 +175,7 @@ class ConstPlugin {
 									`${bool}`,
 									/** @type {Range} */ (param.range)
 								);
-								dep.loc = /** @type {SourceLocation} */ (statement.loc);
+								dep.loc = parser.getLocation(statement);
 								parser.state.module.addPresentationalDependency(dep);
 							} else {
 								parser.walkExpression(statement.test);
@@ -212,7 +212,7 @@ class ConstPlugin {
 										` ${bool}`,
 										/** @type {Range} */ (param.range)
 									);
-									dep.loc = /** @type {SourceLocation} */ (expression.loc);
+									dep.loc = parser.getLocation(expression);
 									parser.state.module.addPresentationalDependency(dep);
 								} else {
 									parser.walkExpression(expression.test);
@@ -235,7 +235,7 @@ class ConstPlugin {
 									"0",
 									/** @type {Range} */ (branchToRemove.range)
 								);
-								dep.loc = /** @type {SourceLocation} */ (branchToRemove.loc);
+								dep.loc = parser.getLocation(branchToRemove);
 								parser.state.module.addPresentationalDependency(dep);
 								return bool;
 							}
@@ -315,7 +315,7 @@ class ConstPlugin {
 											` ${bool}`,
 											/** @type {Range} */ (param.range)
 										);
-										dep.loc = /** @type {SourceLocation} */ (expression.loc);
+										dep.loc = parser.getLocation(expression);
 										parser.state.module.addPresentationalDependency(dep);
 									} else {
 										parser.walkExpression(expression.left);
@@ -325,7 +325,7 @@ class ConstPlugin {
 											"0",
 											/** @type {Range} */ (expression.right.range)
 										);
-										dep.loc = /** @type {SourceLocation} */ (expression.loc);
+										dep.loc = parser.getLocation(expression);
 										parser.state.module.addPresentationalDependency(dep);
 									}
 									return keepRight;
@@ -368,14 +368,14 @@ class ConstPlugin {
 											" null",
 											/** @type {Range} */ (param.range)
 										);
-										dep.loc = /** @type {SourceLocation} */ (expression.loc);
+										dep.loc = parser.getLocation(expression);
 										parser.state.module.addPresentationalDependency(dep);
 									} else {
 										const dep = new ConstDependency(
 											"0",
 											/** @type {Range} */ (expression.right.range)
 										);
-										dep.loc = /** @type {SourceLocation} */ (expression.loc);
+										dep.loc = parser.getLocation(expression);
 										parser.state.module.addPresentationalDependency(dep);
 										parser.walkExpression(expression.left);
 									}
@@ -437,7 +437,7 @@ class ConstPlugin {
 									" undefined",
 									/** @type {Range} */ (expr.range)
 								);
-								dep.loc = /** @type {SourceLocation} */ (expr.loc);
+								dep.loc = parser.getLocation(expr);
 								parser.state.module.addPresentationalDependency(dep);
 								return true;
 							}
@@ -464,7 +464,7 @@ class ConstPlugin {
 								/** @type {Range} */ (expr.range),
 								"__resourceQuery"
 							);
-							dep.loc = /** @type {SourceLocation} */ (expr.loc);
+							dep.loc = parser.getLocation(expr);
 							parser.state.module.addPresentationalDependency(dep);
 							return true;
 						});
@@ -490,7 +490,7 @@ class ConstPlugin {
 								/** @type {Range} */ (expr.range),
 								"__resourceFragment"
 							);
-							dep.loc = /** @type {SourceLocation} */ (expr.loc);
+							dep.loc = parser.getLocation(expr);
 							parser.state.module.addPresentationalDependency(dep);
 							return true;
 						});
@@ -562,7 +562,7 @@ class ConstPlugin {
 			`// removed by dead control flow\n${replacement}`,
 			/** @type {Range} */ (statement.range)
 		);
-		dep.loc = /** @type {SourceLocation} */ (statement.loc);
+		dep.loc = parser.getLocation(statement);
 		parser.state.module.addPresentationalDependency(dep);
 	}
 }