webpack 5.107.2 → 5.108.0

package/lib/dll/DllModule.js

@@ -28,8 +28,8 @@ const makeSerializable = require("../util/makeSerializable");
 /** @typedef {import("../Module").Sources} Sources */
 /** @typedef {import("../RequestShortener")} RequestShortener */
 /** @typedef {import("../ResolverFactory").ResolverWithOptions} ResolverWithOptions */
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext} ObjectDeserializerContext */
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext} ObjectSerializerContext */
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext<[string]>} ObjectDeserializerContext */
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext<[string]>} ObjectSerializerContext */
 /** @typedef {import("../util/Hash")} Hash */
 /** @typedef {import("../util/fs").InputFileSystem} InputFileSystem */
 
@@ -51,6 +51,7 @@ class DllModule extends Module {
 		// Info from Factory
 		/** @type {Dependency[]} */
 		this.dependencies = dependencies;
+		/** @type {string} */
 		this.name = name;
 	}
 

package/lib/dll/DllPlugin.js

@@ -11,6 +11,7 @@ const LibManifestPlugin = require("./LibManifestPlugin");
 
 /** @typedef {import("../../declarations/plugins/dll/DllPlugin").DllPluginOptions} DllPluginOptions */
 /** @typedef {import("../Compiler")} Compiler */
+/** @typedef {import("../Module").FactoryMeta} FactoryMeta */
 /** @typedef {import("./DllEntryPlugin").Entries} Entries */
 /** @typedef {import("./DllEntryPlugin").Options} Options */
 
@@ -68,6 +69,21 @@ class DllPlugin {
 		new LibManifestPlugin({ ...this.options, entryOnly }).apply(compiler);
 		if (!entryOnly) {
 			new FlagAllModulesAsUsedPlugin(PLUGIN_NAME).apply(compiler);
+			compiler.hooks.compilation.tap(
+				PLUGIN_NAME,
+				(_compilation, { normalModuleFactory }) => {
+					normalModuleFactory.hooks.module.tap(
+						{ name: PLUGIN_NAME, stage: 10 },
+						(module) => {
+							if (module.factoryMeta === undefined) {
+								module.factoryMeta = {};
+							}
+							module.factoryMeta.sideEffectFree = false;
+							return module;
+						}
+					);
+				}
+			);
 		}
 	}
 }

package/lib/dll/DllReferencePlugin.js

@@ -30,6 +30,7 @@ class DllReferencePlugin {
 	 * @param {DllReferencePluginOptions} options options object
 	 */
 	constructor(options) {
+		/** @type {DllReferencePluginOptions} */
 		this.options = options;
 	}
 
@@ -188,7 +189,9 @@ class DllManifestError extends WebpackError {
 	constructor(filename, message) {
 		super();
 
+		/** @type {string} */
 		this.name = "DllManifestError";
+		/** @type {string} */
 		this.message = `Dll manifest ${filename}\n${message}`;
 	}
 }

package/lib/dll/LibManifestPlugin.js

@@ -44,6 +44,7 @@ class LibManifestPlugin {
 	 * @param {LibManifestPluginOptions} options the options
 	 */
 	constructor(options) {
+		/** @type {LibManifestPluginOptions} */
 		this.options = options;
 	}
 

package/lib/electron/ElectronTargetPlugin.js

@@ -7,17 +7,22 @@
 
 const ExternalsPlugin = require("../ExternalsPlugin");
 
+/** @typedef {import("../../declarations/WebpackOptions").ExternalsType} ExternalsType */
 /** @typedef {import("../Compiler")} Compiler */
+/** @typedef {import("../Dependency")} Dependency */
 /** @typedef {"main" | "preload" | "renderer"} ElectronContext */
 
 class ElectronTargetPlugin {
 	/**
 	 * Creates an instance of ElectronTargetPlugin.
 	 * @param {ElectronContext=} context in main, preload or renderer context?
+	 * @param {ExternalsType=} type default external type
 	 */
-	constructor(context) {
+	constructor(context, type = "node-commonjs") {
 		/** @type {ElectronContext | undefined} */
 		this._context = context;
+		/** @type {ExternalsType} */
+		this.type = type;
 	}
 
 	/**
@@ -26,7 +31,20 @@ class ElectronTargetPlugin {
 	 * @returns {void}
 	 */
 	apply(compiler) {
-		new ExternalsPlugin("node-commonjs", [
+		/**
+		 * @param {Dependency} dependency the dependency
+		 * @returns {ExternalsType} the external type
+		 */
+		const externalType = (dependency) => {
+			// When `require` electron built-in modules with module output
+			// we should still emit `node-commonjs` for compatibility
+			if (dependency.category === "commonjs") {
+				return "node-commonjs";
+			}
+
+			return this.type;
+		};
+		new ExternalsPlugin(externalType, [
 			"clipboard",
 			"crash-reporter",
 			"electron",
@@ -38,7 +56,7 @@ class ElectronTargetPlugin {
 		]).apply(compiler);
 		switch (this._context) {
 			case "main":
-				new ExternalsPlugin("node-commonjs", [
+				new ExternalsPlugin(externalType, [
 					"app",
 					"auto-updater",
 					"browser-window",
@@ -58,7 +76,7 @@ class ElectronTargetPlugin {
 				break;
 			case "preload":
 			case "renderer":
-				new ExternalsPlugin("node-commonjs", [
+				new ExternalsPlugin(externalType, [
 					"desktop-capturer",
 					"ipc-renderer",
 					"remote",

package/lib/errors/ConcurrentCompilationError.js

@@ -13,6 +13,7 @@ class ConcurrentCompilationError extends WebpackError {
 			"You ran Webpack twice. Each instance only supports a single concurrent compilation at a time."
 		);
 
+		/** @type {string} */
 		this.name = "ConcurrentCompilationError";
 	}
 }

package/lib/errors/HookWebpackError.js

@@ -8,8 +8,8 @@
 const makeSerializable = require("../util/makeSerializable");
 const WebpackError = require("./WebpackError");
 
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext} ObjectDeserializerContext */
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext} ObjectSerializerContext */
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext<[Error, string]>} ObjectDeserializerContext */
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext<[Error, string]>} ObjectSerializerContext */
 
 /**
  * Defines the callback callback.
@@ -29,12 +29,16 @@ class HookWebpackError extends WebpackError {
 	constructor(error, hook) {
 		super(error ? error.message : undefined, error ? { cause: error } : {});
 
+		/** @type {string} */
 		this.hook = hook;
+		/** @type {Error} */
 		this.error = error;
 		/** @type {string} */
 		this.name = "HookWebpackError";
+		/** @type {boolean} */
 		this.hideStack = true;
 		this.stack += `\n-- inner error --\n${error ? error.stack : ""}`;
+		/** @type {string} */
 		this.details = `caused by plugins in ${hook}\n${error ? error.stack : ""}`;
 	}
 
@@ -43,11 +47,7 @@ class HookWebpackError extends WebpackError {
 	 * @param {ObjectSerializerContext} context context
 	 */
 	serialize(context) {
-		const { write } = context;
-
-		write(this.error);
-		write(this.hook);
-
+		context.write(this.error).write(this.hook);
 		super.serialize(context);
 	}
 
@@ -56,12 +56,10 @@ class HookWebpackError extends WebpackError {
 	 * @param {ObjectDeserializerContext} context context
 	 */
 	deserialize(context) {
-		const { read } = context;
-
-		this.error = read();
-		this.hook = read();
-
-		super.deserialize(context);
+		this.error = context.read();
+		const c1 = context.rest;
+		this.hook = c1.read();
+		super.deserialize(c1.rest);
 	}
 }
 

package/lib/errors/IgnoreErrorModuleFactory.js

@@ -22,6 +22,7 @@ class IgnoreErrorModuleFactory extends ModuleFactory {
 	constructor(normalModuleFactory) {
 		super();
 
+		/** @type {NormalModuleFactory} */
 		this.normalModuleFactory = normalModuleFactory;
 	}
 

package/lib/errors/InvalidDependenciesModuleWarning.js

@@ -32,7 +32,9 @@ ${depsList.slice(0, 3).join("\n")}${
 
 		/** @type {string} */
 		this.name = "InvalidDependenciesModuleWarning";
+		/** @type {string} */
 		this.details = depsList.slice(3).join("\n");
+		/** @type {Module} */
 		this.module = module;
 	}
 }

package/lib/errors/JSONParseError.js

@@ -4,8 +4,8 @@
 
 "use strict";
 
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext} ObjectDeserializerContext */
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext} ObjectSerializerContext */
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext<[Error, EXPECTED_ANY, string]>} ObjectDeserializerContext */
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext<[Error, EXPECTED_ANY, string]>} ObjectSerializerContext */
 
 const makeSerializable = require("../util/makeSerializable");
 
@@ -92,10 +92,8 @@ class JSONParseError extends SyntaxError {
 	 * Serializes this instance into the provided serializer context.
 	 * @param {ObjectSerializerContext} context context
 	 */
-	serialize({ write }) {
-		write(this.systemError);
-		write(this.raw);
-		write(this.txt);
+	serialize(context) {
+		context.write(this.systemError).write(this.raw).write(this.txt);
 	}
 
 	/**
@@ -104,8 +102,11 @@ class JSONParseError extends SyntaxError {
 	 * @returns {JSONParseError} DelegatedModule
 	 */
 	static deserialize(context) {
-		const { read } = context;
-		return new JSONParseError(read(), read(), read());
+		const systemError = context.read();
+		const c1 = context.rest;
+		const raw = c1.read();
+		const c2 = c1.rest;
+		return new JSONParseError(systemError, raw, c2.read());
 	}
 }
 

package/lib/errors/ModuleBuildError.js

@@ -9,11 +9,11 @@ const { cutOffLoaderExecution } = require("../ErrorHelpers");
 const makeSerializable = require("../util/makeSerializable");
 const WebpackError = require("./WebpackError");
 
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext} ObjectDeserializerContext */
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext} ObjectSerializerContext */
-
 /** @typedef {Error & { hideStack?: boolean }} ErrorWithHideStack */
 
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext<[string | ErrorWithHideStack]>} ObjectDeserializerContext */
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext<[string | ErrorWithHideStack]>} ObjectSerializerContext */
+
 class ModuleBuildError extends WebpackError {
 	/**
 	 * Creates an instance of ModuleBuildError.
@@ -32,7 +32,14 @@ class ModuleBuildError extends WebpackError {
 				const stack = cutOffLoaderExecution(err.stack);
 
 				if (!err.hideStack) {
-					message += stack;
+					// V8 prefixes `.stack` with "Name: message"; JSC and others emit
+					// frames only, which would drop the message. Lead with it then.
+					message +=
+						typeof err.message === "string" &&
+						err.message &&
+						!stack.includes(err.message)
+							? `${err.name ? `${err.name}: ` : ""}${err.message}`
+							: stack;
 				} else {
 					details = stack;
 
@@ -52,7 +59,9 @@ class ModuleBuildError extends WebpackError {
 
 		/** @type {string} */
 		this.name = "ModuleBuildError";
+		/** @type {string | undefined} */
 		this.details = details;
+		/** @type {string | ErrorWithHideStack} */
 		this.error = err;
 	}
 
@@ -61,10 +70,7 @@ class ModuleBuildError extends WebpackError {
 	 * @param {ObjectSerializerContext} context context
 	 */
 	serialize(context) {
-		const { write } = context;
-
-		write(this.error);
-
+		context.write(this.error);
 		super.serialize(context);
 	}
 
@@ -73,11 +79,8 @@ class ModuleBuildError extends WebpackError {
 	 * @param {ObjectDeserializerContext} context context
 	 */
 	deserialize(context) {
-		const { read } = context;
-
-		this.error = read();
-
-		super.deserialize(context);
+		this.error = context.read();
+		super.deserialize(context.rest);
 	}
 }
 

package/lib/errors/ModuleDependencyError.js

@@ -23,16 +23,23 @@ class ModuleDependencyError extends WebpackError {
 
 		/** @type {string} */
 		this.name = "ModuleDependencyError";
+		/** @type {string | undefined} */
 		this.details =
 			err && !err.hideStack
 				? /** @type {string} */ (err.stack).split("\n").slice(1).join("\n")
 				: undefined;
+		/** @type {Module} */
 		this.module = module;
+		/** @type {DependencyLocation} */
 		this.loc = loc;
-		/** error is not (de)serialized, so it might be undefined after deserialization */
+		/**
+		 * error is not (de)serialized, so it might be undefined after deserialization
+		 * @type {ErrorWithHideStack}
+		 */
 		this.error = err;
 
 		if (err && err.hideStack && err.stack) {
+			/** @type {string | undefined} */
 			this.stack = /** @type {string} */ `${err.stack
 				.split("\n")
 				.slice(1)

package/lib/errors/ModuleDependencyWarning.js

@@ -24,16 +24,23 @@ class ModuleDependencyWarning extends WebpackError {
 
 		/** @type {string} */
 		this.name = "ModuleDependencyWarning";
+		/** @type {string | undefined} */
 		this.details =
 			err && !err.hideStack
 				? /** @type {string} */ (err.stack).split("\n").slice(1).join("\n")
 				: undefined;
+		/** @type {Module} */
 		this.module = module;
+		/** @type {DependencyLocation} */
 		this.loc = loc;
-		/** error is not (de)serialized, so it might be undefined after deserialization */
+		/**
+		 * error is not (de)serialized, so it might be undefined after deserialization
+		 * @type {ErrorWithHideStack}
+		 */
 		this.error = err;
 
 		if (err && err.hideStack && err.stack) {
+			/** @type {string | undefined} */
 			this.stack = /** @type {string} */ `${err.stack
 				.split("\n")
 				.slice(1)

package/lib/errors/ModuleError.js

@@ -9,8 +9,8 @@ const { cleanUp } = require("../ErrorHelpers");
 const makeSerializable = require("../util/makeSerializable");
 const WebpackError = require("./WebpackError");
 
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext} ObjectDeserializerContext */
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext} ObjectSerializerContext */
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext<[Error]>} ObjectDeserializerContext */
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext<[Error]>} ObjectSerializerContext */
 
 class ModuleError extends WebpackError {
 	/**
@@ -46,10 +46,7 @@ class ModuleError extends WebpackError {
 	 * @param {ObjectSerializerContext} context context
 	 */
 	serialize(context) {
-		const { write } = context;
-
-		write(this.error);
-
+		context.write(this.error);
 		super.serialize(context);
 	}
 
@@ -58,11 +55,8 @@ class ModuleError extends WebpackError {
 	 * @param {ObjectDeserializerContext} context context
 	 */
 	deserialize(context) {
-		const { read } = context;
-
-		this.error = read();
-
-		super.deserialize(context);
+		this.error = context.read();
+		super.deserialize(context.rest);
 	}
 }
 

package/lib/errors/ModuleHashingError.js

@@ -20,9 +20,13 @@ class ModuleHashingError extends WebpackError {
 
 		/** @type {string} */
 		this.name = "ModuleHashingError";
+		/** @type {Error} */
 		this.error = error;
+		/** @type {string} */
 		this.message = error.message;
+		/** @type {string | undefined} */
 		this.details = error.stack;
+		/** @type {Module} */
 		this.module = module;
 	}
 }

package/lib/errors/ModuleNotFoundError.js

@@ -81,9 +81,12 @@ class ModuleNotFoundError extends WebpackError {
 
 		/** @type {string} */
 		this.name = "ModuleNotFoundError";
+		/** @type {string | undefined} */
 		this.details = err.details;
+		/** @type {Module | null} */
 		this.module = module;
 		this.error = err;
+		/** @type {DependencyLocation} */
 		this.loc = loc;
 	}
 }

package/lib/errors/ModuleParseError.js

@@ -10,8 +10,8 @@ const WebpackError = require("./WebpackError");
 
 /** @typedef {import("../Dependency").DependencyLocation} DependencyLocation */
 /** @typedef {import("../Dependency").SourcePosition} SourcePosition */
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext} ObjectDeserializerContext */
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext} ObjectSerializerContext */
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext<[Error]>} ObjectDeserializerContext */
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext<[Error]>} ObjectSerializerContext */
 
 const WASM_HEADER = Buffer.from([0x00, 0x61, 0x73, 0x6d]);
 
@@ -105,10 +105,7 @@ class ModuleParseError extends WebpackError {
 	 * @param {ObjectSerializerContext} context context
 	 */
 	serialize(context) {
-		const { write } = context;
-
-		write(this.error);
-
+		context.write(this.error);
 		super.serialize(context);
 	}
 
@@ -117,11 +114,8 @@ class ModuleParseError extends WebpackError {
 	 * @param {ObjectDeserializerContext} context context
 	 */
 	deserialize(context) {
-		const { read } = context;
-
-		this.error = read();
-
-		super.deserialize(context);
+		this.error = context.read();
+		super.deserialize(context.rest);
 	}
 }
 

package/lib/errors/ModuleRestoreError.js

@@ -38,7 +38,9 @@ class ModuleRestoreError extends WebpackError {
 		this.name = "ModuleRestoreError";
 		/** @type {string | undefined} */
 		this.details = details;
+		/** @type {Module} */
 		this.module = module;
+		/** @type {string | Error} */
 		this.error = err;
 	}
 }

package/lib/errors/ModuleStoreError.js

@@ -36,8 +36,11 @@ class ModuleStoreError extends WebpackError {
 
 		/** @type {string} */
 		this.name = "ModuleStoreError";
+		/** @type {string | undefined} */
 		this.details = /** @type {string | undefined} */ (details);
+		/** @type {Module} */
 		this.module = module;
+		/** @type {string | Error} */
 		this.error = err;
 	}
 }

package/lib/errors/ModuleWarning.js

@@ -9,8 +9,8 @@ const { cleanUp } = require("../ErrorHelpers");
 const makeSerializable = require("../util/makeSerializable");
 const WebpackError = require("./WebpackError");
 
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext} ObjectDeserializerContext */
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext} ObjectSerializerContext */
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext<[Error]>} ObjectDeserializerContext */
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext<[Error]>} ObjectSerializerContext */
 
 class ModuleWarning extends WebpackError {
 	/**
@@ -33,7 +33,9 @@ class ModuleWarning extends WebpackError {
 
 		/** @type {string} */
 		this.name = "ModuleWarning";
+		/** @type {Error} */
 		this.warning = warning;
+		/** @type {string | undefined} */
 		this.details =
 			warning && typeof warning === "object" && warning.stack
 				? cleanUp(warning.stack, this.message)
@@ -45,10 +47,7 @@ class ModuleWarning extends WebpackError {
 	 * @param {ObjectSerializerContext} context context
 	 */
 	serialize(context) {
-		const { write } = context;
-
-		write(this.warning);
-
+		context.write(this.warning);
 		super.serialize(context);
 	}
 
@@ -57,11 +56,8 @@ class ModuleWarning extends WebpackError {
 	 * @param {ObjectDeserializerContext} context context
 	 */
 	deserialize(context) {
-		const { read } = context;
-
-		this.warning = read();
-
-		super.deserialize(context);
+		this.warning = context.read();
+		super.deserialize(context.rest);
 	}
 }
 

package/lib/errors/NodeStuffInWebError.js

@@ -27,6 +27,7 @@ ${description}`
 
 		/** @type {string} */
 		this.name = "NodeStuffInWebError";
+		/** @type {DependencyLocation} */
 		this.loc = loc;
 	}
 }

package/lib/errors/NonErrorEmittedError.js

@@ -15,7 +15,9 @@ class NonErrorEmittedError extends WebpackError {
 	constructor(error) {
 		super();
 
+		/** @type {string} */
 		this.name = "NonErrorEmittedError";
+		/** @type {string} */
 		this.message = `(Emitted value instead of an instance of Error) ${error}`;
 	}
 }

package/lib/errors/UnhandledSchemeError.js

@@ -25,6 +25,7 @@ class UnhandledSchemeError extends WebpackError {
 				'\nWebpack supports "data:" and "file:" URIs by default.' +
 				`\nYou may need an additional plugin to handle "${scheme}:" URIs.`
 		);
+		/** @type {string} */
 		this.file = resource;
 		/** @type {string} */
 		this.name = "UnhandledSchemeError";

package/lib/esm/ModuleChunkLoadingPlugin.js

@@ -115,7 +115,6 @@ class ModuleChunkLoadingPlugin {
 				.tap(PLUGIN_NAME, (chunk, set) => {
 					if (!isEnabledForChunk(chunk)) return;
 					set.add(RuntimeGlobals.publicPath);
-					set.add(RuntimeGlobals.loadScript);
 					set.add(RuntimeGlobals.getChunkUpdateScriptFilename);
 					set.add(RuntimeGlobals.moduleCache);
 					set.add(RuntimeGlobals.hmrModuleData);