webpack 4.9.1 → 4.10.2

package/lib/ChunkGroup.js

@@ -259,7 +259,9 @@ class ChunkGroup {
 
 	setParents(newParents) {
 		this._parents.clear();
-		for (const p of newParents) this._parents.add(p);
+		for (const p of newParents) {
+			this._parents.add(p);
+		}
 	}
 
 	getNumberOfParents() {
@@ -418,7 +420,9 @@ class ChunkGroup {
 					if (key.endsWith("Order")) {
 						const name = key.substr(0, key.length - "Order".length);
 						let list = lists.get(name);
-						if (list === undefined) lists.set(name, (list = []));
+						if (list === undefined) {
+							lists.set(name, (list = []));
+						}
 						list.push({
 							order: childGroup.options[key],
 							group: childGroup
@@ -433,7 +437,9 @@ class ChunkGroup {
 				const cmp = b.order - a.order;
 				if (cmp !== 0) return cmp;
 				// TOOD webpack 5 remove this check of compareTo
-				if (a.group.compareTo) return a.group.compareTo(b.group);
+				if (a.group.compareTo) {
+					return a.group.compareTo(b.group);
+				}
 				return 0;
 			});
 			result[name] = list.map(i => i.group);
@@ -444,20 +450,22 @@ class ChunkGroup {
 	checkConstraints() {
 		const chunk = this;
 		for (const child of chunk._children) {
-			if (!child._parents.has(chunk))
+			if (!child._parents.has(chunk)) {
 				throw new Error(
 					`checkConstraints: child missing parent ${chunk.debugId} -> ${
 						child.debugId
 					}`
 				);
+			}
 		}
 		for (const parentChunk of chunk._parents) {
-			if (!parentChunk._children.has(chunk))
+			if (!parentChunk._children.has(chunk)) {
 				throw new Error(
 					`checkConstraints: parent missing child ${parentChunk.debugId} <- ${
 						chunk.debugId
 					}`
 				);
+			}
 		}
 	}
 }

package/lib/ChunkRenderError.js

@@ -1,32 +1,32 @@
-/*
-	MIT License http://www.opensource.org/licenses/mit-license.php
-	Author Tobias Koppers @sokra
-*/
-"use strict";
-
-const WebpackError = require("./WebpackError");
-
-/** @typedef {import("./Chunk")} Chunk */
-
-class ChunkRenderError extends WebpackError {
-	/**
-	 * Create a new ChunkRenderError
-	 * @param {Chunk} chunk A chunk
-	 * @param {string} file Related file
-	 * @param {Error} error Original error
-	 */
-	constructor(chunk, file, error) {
-		super();
-
-		this.name = "ChunkRenderError";
-		this.error = error;
-		this.message = error.message;
-		this.details = error.stack;
-		this.file = file;
-		this.chunk = chunk;
-
-		Error.captureStackTrace(this, this.constructor);
-	}
-}
-
-module.exports = ChunkRenderError;
+/*
+	MIT License http://www.opensource.org/licenses/mit-license.php
+	Author Tobias Koppers @sokra
+*/
+"use strict";
+
+const WebpackError = require("./WebpackError");
+
+/** @typedef {import("./Chunk")} Chunk */
+
+class ChunkRenderError extends WebpackError {
+	/**
+	 * Create a new ChunkRenderError
+	 * @param {Chunk} chunk A chunk
+	 * @param {string} file Related file
+	 * @param {Error} error Original error
+	 */
+	constructor(chunk, file, error) {
+		super();
+
+		this.name = "ChunkRenderError";
+		this.error = error;
+		this.message = error.message;
+		this.details = error.stack;
+		this.file = file;
+		this.chunk = chunk;
+
+		Error.captureStackTrace(this, this.constructor);
+	}
+}
+
+module.exports = ChunkRenderError;

package/lib/CompatibilityPlugin.js

@@ -1,63 +1,63 @@
-/*
-	MIT License http://www.opensource.org/licenses/mit-license.php
-	Author Tobias Koppers @sokra
-*/
-"use strict";
-
-const ConstDependency = require("./dependencies/ConstDependency");
-
-const NullFactory = require("./NullFactory");
-
-class CompatibilityPlugin {
-	apply(compiler) {
-		compiler.hooks.compilation.tap(
-			"CompatibilityPlugin",
-			(compilation, { normalModuleFactory }) => {
-				compilation.dependencyFactories.set(ConstDependency, new NullFactory());
-				compilation.dependencyTemplates.set(
-					ConstDependency,
-					new ConstDependency.Template()
-				);
-
-				normalModuleFactory.hooks.parser
-					.for("javascript/auto")
-					.tap("CompatibilityPlugin", (parser, parserOptions) => {
-						if (
-							typeof parserOptions.browserify !== "undefined" &&
-							!parserOptions.browserify
-						)
-							return;
-
-						parser.hooks.call
-							.for("require")
-							.tap("CompatibilityPlugin", expr => {
-								// support for browserify style require delegator: "require(o, !0)"
-								if (expr.arguments.length !== 2) return;
-								const second = parser.evaluateExpression(expr.arguments[1]);
-								if (!second.isBoolean()) return;
-								if (second.asBool() !== true) return;
-								const dep = new ConstDependency("require", expr.callee.range);
-								dep.loc = expr.loc;
-								if (parser.state.current.dependencies.length > 1) {
-									const last =
-										parser.state.current.dependencies[
-											parser.state.current.dependencies.length - 1
-										];
-									if (
-										last.critical &&
-										last.options &&
-										last.options.request === "." &&
-										last.userRequest === "." &&
-										last.options.recursive
-									)
-										parser.state.current.dependencies.pop();
-								}
-								parser.state.current.addDependency(dep);
-								return true;
-							});
-					});
-			}
-		);
-	}
-}
-module.exports = CompatibilityPlugin;
+/*
+	MIT License http://www.opensource.org/licenses/mit-license.php
+	Author Tobias Koppers @sokra
+*/
+"use strict";
+
+const ConstDependency = require("./dependencies/ConstDependency");
+
+const NullFactory = require("./NullFactory");
+
+class CompatibilityPlugin {
+	apply(compiler) {
+		compiler.hooks.compilation.tap(
+			"CompatibilityPlugin",
+			(compilation, { normalModuleFactory }) => {
+				compilation.dependencyFactories.set(ConstDependency, new NullFactory());
+				compilation.dependencyTemplates.set(
+					ConstDependency,
+					new ConstDependency.Template()
+				);
+
+				normalModuleFactory.hooks.parser
+					.for("javascript/auto")
+					.tap("CompatibilityPlugin", (parser, parserOptions) => {
+						if (
+							typeof parserOptions.browserify !== "undefined" &&
+							!parserOptions.browserify
+						)
+							return;
+
+						parser.hooks.call
+							.for("require")
+							.tap("CompatibilityPlugin", expr => {
+								// support for browserify style require delegator: "require(o, !0)"
+								if (expr.arguments.length !== 2) return;
+								const second = parser.evaluateExpression(expr.arguments[1]);
+								if (!second.isBoolean()) return;
+								if (second.asBool() !== true) return;
+								const dep = new ConstDependency("require", expr.callee.range);
+								dep.loc = expr.loc;
+								if (parser.state.current.dependencies.length > 1) {
+									const last =
+										parser.state.current.dependencies[
+											parser.state.current.dependencies.length - 1
+										];
+									if (
+										last.critical &&
+										last.options &&
+										last.options.request === "." &&
+										last.userRequest === "." &&
+										last.options.recursive
+									)
+										parser.state.current.dependencies.pop();
+								}
+								parser.state.current.addDependency(dep);
+								return true;
+							});
+					});
+			}
+		);
+	}
+}
+module.exports = CompatibilityPlugin;