webpack 4.39.1 → 4.39.2

package/README.md

@@ -14,6 +14,7 @@
 [![builds2][builds2]][builds2-url]
 [![coverage][cover]][cover-url]
 [![licenses][licenses]][licenses-url]
+[![PR's welcome][prs]][prs-url]
 
   <br>
   <a href="https://dependabot.com/compatibility-score.html?dependency-name=webpack&package-manager=npm_and_yarn&new-version=latest">
@@ -767,6 +768,9 @@ src="https://static.monei.net/monei-logo.svg" height="30" alt="MONEI"></a>
 [tests]: https://img.shields.io/travis/webpack/webpack/master.svg
 [tests-url]: https://travis-ci.org/webpack/webpack
 
+[prs]: https://img.shields.io/badge/PRs-welcome-brightgreen.svg
+[prs-url]: https://webpack.js.org/contribute/
+
 [builds-url]: https://ci.appveyor.com/project/sokra/webpack/branch/master
 [builds]: https://ci.appveyor.com/api/projects/status/github/webpack/webpack?svg=true
 

package/lib/BannerPlugin.js

@@ -81,7 +81,6 @@ class BannerPlugin {
 							continue;
 						}
 
-						let basename;
 						let query = "";
 						let filename = file;
 						const hash = compilation.hash;
@@ -94,11 +93,10 @@ class BannerPlugin {
 
 						const lastSlashIndex = filename.lastIndexOf("/");
 
-						if (lastSlashIndex === -1) {
-							basename = filename;
-						} else {
-							basename = filename.substr(lastSlashIndex + 1);
-						}
+						const basename =
+							lastSlashIndex === -1
+								? filename
+								: filename.substr(lastSlashIndex + 1);
 
 						const data = {
 							hash,

package/lib/ChunkGroup.js

@@ -70,12 +70,12 @@ class ChunkGroup {
 		this.chunks = [];
 		/** @type {OriginRecord[]} */
 		this.origins = [];
-		/** Indicies in top-down order */
+		/** Indices in top-down order */
 		/** @private @type {Map<Module, number>} */
-		this._moduleIndicies = new Map();
-		/** Indicies in bottom-up order */
+		this._moduleIndices = new Map();
+		/** Indices in bottom-up order */
 		/** @private @type {Map<Module, number>} */
-		this._moduleIndicies2 = new Map();
+		this._moduleIndices2 = new Map();
 	}
 
 	/**
@@ -174,7 +174,7 @@ class ChunkGroup {
 	/**
 	 * add a chunk into ChunkGroup. Is pushed on or prepended
 	 * @param {Chunk} chunk chunk being pushed into ChunkGroupS
-	 * @returns {boolean} returns true if chunk addition was ssuccesful.
+	 * @returns {boolean} returns true if chunk addition was successful.
 	 */
 	pushChunk(chunk) {
 		const oldIdx = this.chunks.indexOf(chunk);
@@ -187,8 +187,8 @@ class ChunkGroup {
 
 	/**
 	 * @param {Chunk} oldChunk chunk to be replaced
-	 * @param {Chunk} newChunk New chunkt that will be replaced
-	 * @returns {boolean} rerturns true for
+	 * @param {Chunk} newChunk New chunk that will be replaced with
+	 * @returns {boolean} returns true if the replacement was successful
 	 */
 	replaceChunk(oldChunk, newChunk) {
 		const oldIdx = this.chunks.indexOf(oldChunk);
@@ -369,7 +369,7 @@ class ChunkGroup {
 
 		/**
 		 * we need to iterate again over the children
-		 * to remove this from the childs parents.
+		 * to remove this from the child's parents.
 		 * This can not be done in the above loop
 		 * as it is not guaranteed that `this._parents` contains anything.
 		 */
@@ -460,7 +460,7 @@ class ChunkGroup {
 	 * @returns {void}
 	 */
 	setModuleIndex(module, index) {
-		this._moduleIndicies.set(module, index);
+		this._moduleIndices.set(module, index);
 	}
 
 	/**
@@ -469,7 +469,7 @@ class ChunkGroup {
 	 * @returns {number} index
 	 */
 	getModuleIndex(module) {
-		return this._moduleIndicies.get(module);
+		return this._moduleIndices.get(module);
 	}
 
 	/**
@@ -479,7 +479,7 @@ class ChunkGroup {
 	 * @returns {void}
 	 */
 	setModuleIndex2(module, index) {
-		this._moduleIndicies2.set(module, index);
+		this._moduleIndices2.set(module, index);
 	}
 
 	/**
@@ -488,7 +488,7 @@ class ChunkGroup {
 	 * @returns {number} index
 	 */
 	getModuleIndex2(module) {
-		return this._moduleIndicies2.get(module);
+		return this._moduleIndices2.get(module);
 	}
 
 	checkConstraints() {

package/lib/Entrypoint.js

@@ -52,8 +52,8 @@ class Entrypoint extends ChunkGroup {
 
 	/**
 	 * @param {Chunk} oldChunk chunk to be replaced
-	 * @param {Chunk} newChunk New chunkt that will be replaced
-	 * @returns {boolean} rerturns true for
+	 * @param {Chunk} newChunk New chunk that will be replaced with
+	 * @returns {boolean} returns true if the replacement was successful
 	 */
 	replaceChunk(oldChunk, newChunk) {
 		if (this.runtimeChunk === oldChunk) this.runtimeChunk = newChunk;

package/lib/debug/ProfilingPlugin.js

@@ -391,8 +391,8 @@ const makeNewProfiledTapFn = (hookName, tracer, { name, type, fn }) => {
 					id,
 					cat: defaultCategory
 				});
+				const callback = args.pop();
 				fn(...args, (...r) => {
-					const callback = args.pop();
 					tracer.trace.end({
 						name,
 						id,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "webpack",
-  "version": "4.39.1",
+  "version": "4.39.2",
   "author": "Tobias Koppers @sokra",
   "description": "Packs CommonJs/AMD modules for the browser. Allows to split your codebase into multiple bundles, which can be loaded on demand. Support loaders to preprocess files, i.e. json, jsx, es7, css, less, ... and your custom stuff.",
   "license": "MIT",