webpack 4.33.0 → 4.35.2

package/declarations/WebpackOptions.d.ts

@@ -558,6 +558,10 @@ export interface RuleSetRule {
 	 * Shortcut for use.query
 	 */
 	query?: RuleSetQuery;
+	/**
+	 * Match rules with custom resource name
+	 */
+	realResource?: RuleSetConditionOrConditionsAbsolute;
 	/**
 	 * Options for the resolver
 	 */
@@ -870,6 +874,10 @@ export interface OptimizationSplitChunksOptions {
 	 * Sets the name delimiter for created chunks
 	 */
 	automaticNameDelimiter?: string;
+	/**
+	 * Sets the max length for the name of a created chunk
+	 */
+	automaticNameMaxLength?: number;
 	/**
 	 * Assign modules to a cache group (modules from different cache groups are tried to keep in separate chunks)
 	 */
@@ -887,6 +895,10 @@ export interface OptimizationSplitChunksOptions {
 					 * Sets the name delimiter for created chunks
 					 */
 					automaticNameDelimiter?: string;
+					/**
+					 * Sets the max length for the name of a created chunk
+					 */
+					automaticNameMaxLength?: number;
 					/**
 					 * Sets the name prefix for created chunks
 					 */

package/hot/dev-server.js

@@ -40,10 +40,10 @@ if (module.hot) {
 						"warning",
 						"[HMR] Cannot apply update. Need to do a full reload!"
 					);
-					log("warning", "[HMR] " + (err.stack || err.message));
+					log("warning", "[HMR] " + log.formatError(err));
 					window.location.reload();
 				} else {
-					log("warning", "[HMR] Update failed: " + (err.stack || err.message));
+					log("warning", "[HMR] Update failed: " + log.formatError(err));
 				}
 			});
 	};

package/hot/log.js

@@ -45,3 +45,15 @@ module.exports.groupEnd = logGroup(groupEnd);
 module.exports.setLogLevel = function(level) {
 	logLevel = level;
 };
+
+module.exports.formatError = function(err) {
+	var message = err.message;
+	var stack = err.stack;
+	if (!stack) {
+		return message;
+	} else if (stack.indexOf(message) < 0) {
+		return message + "\n" + stack;
+	} else {
+		return stack;
+	}
+};

package/hot/only-dev-server.js

@@ -72,12 +72,9 @@ if (module.hot) {
 						"warning",
 						"[HMR] Cannot check for update. Need to do a full reload!"
 					);
-					log("warning", "[HMR] " + (err.stack || err.message));
+					log("warning", "[HMR] " + log.formatError(err));
 				} else {
-					log(
-						"warning",
-						"[HMR] Update check failed: " + (err.stack || err.message)
-					);
+					log("warning", "[HMR] Update check failed: " + log.formatError(err));
 				}
 			});
 	};

package/hot/poll.js

@@ -23,13 +23,10 @@ if (module.hot) {
 					var status = module.hot.status();
 					if (["abort", "fail"].indexOf(status) >= 0) {
 						log("warning", "[HMR] Cannot apply update.");
-						log("warning", "[HMR] " + (err.stack || err.message));
+						log("warning", "[HMR] " + log.formatError(err));
 						log("warning", "[HMR] You need to restart the application!");
 					} else {
-						log(
-							"warning",
-							"[HMR] Update failed: " + (err.stack || err.message)
-						);
+						log("warning", "[HMR] Update failed: " + log.formatError(err));
 					}
 				});
 		}

package/hot/signal.js

@@ -37,7 +37,7 @@ if (module.hot) {
 				var status = module.hot.status();
 				if (["abort", "fail"].indexOf(status) >= 0) {
 					log("warning", "[HMR] Cannot apply update.");
-					log("warning", "[HMR] " + (err.stack || err.message));
+					log("warning", "[HMR] " + log.formatError(err));
 					log("warning", "[HMR] You need to restart the application!");
 				} else {
 					log("warning", "[HMR] Update failed: " + (err.stack || err.message));

package/lib/ChunkGroup.js

@@ -496,18 +496,14 @@ class ChunkGroup {
 		for (const child of chunk._children) {
 			if (!child._parents.has(chunk)) {
 				throw new Error(
-					`checkConstraints: child missing parent ${chunk.debugId} -> ${
-						child.debugId
-					}`
+					`checkConstraints: child missing parent ${chunk.debugId} -> ${child.debugId}`
 				);
 			}
 		}
 		for (const parentChunk of chunk._parents) {
 			if (!parentChunk._children.has(chunk)) {
 				throw new Error(
-					`checkConstraints: parent missing child ${parentChunk.debugId} <- ${
-						chunk.debugId
-					}`
+					`checkConstraints: parent missing child ${parentChunk.debugId} <- ${chunk.debugId}`
 				);
 			}
 		}

package/lib/Compilation.js

@@ -694,9 +694,7 @@ class Compilation extends Tapable {
 				const factory = this.dependencyFactories.get(dep.constructor);
 				if (factory === undefined) {
 					throw new Error(
-						`No module factory available for dependency type: ${
-							dep.constructor.name
-						}`
+						`No module factory available for dependency type: ${dep.constructor.name}`
 					);
 				}
 				let innerMap = dependencies.get(factory);
@@ -958,9 +956,7 @@ class Compilation extends Tapable {
 		const moduleFactory = this.dependencyFactories.get(Dep);
 		if (!moduleFactory) {
 			throw new Error(
-				`No dependency factory available for this dependency type: ${
-					dependency.constructor.name
-				}`
+				`No dependency factory available for this dependency type: ${dependency.constructor.name}`
 			);
 		}
 

package/lib/MainTemplate.js

@@ -345,9 +345,7 @@ module.exports = class MainTemplate extends Tapable {
 			buf.push("");
 			buf.push("// Object.prototype.hasOwnProperty.call");
 			buf.push(
-				`${
-					this.requireFn
-				}.o = function(object, property) { return Object.prototype.hasOwnProperty.call(object, property); };`
+				`${this.requireFn}.o = function(object, property) { return Object.prototype.hasOwnProperty.call(object, property); };`
 			);
 
 			const publicPath = this.getPublicPath({

package/lib/ModuleParseError.js

@@ -13,11 +13,21 @@ class ModuleParseError extends WebpackError {
 	 * @param {Module} module the errored module
 	 * @param {string} source source code
 	 * @param {Error&any} err the parse error
+	 * @param {string[]} loaders the loaders used
 	 */
-	constructor(module, source, err) {
+	constructor(module, source, err, loaders) {
 		let message = "Module parse failed: " + err.message;
 		let loc = undefined;
-		message += "\nYou may need an appropriate loader to handle this file type.";
+		if (loaders.length >= 1) {
+			message += `\nFile was processed with these loaders:${loaders
+				.map(loader => `\n * ${loader}`)
+				.join("")}`;
+			message +=
+				"\nYou may need an additional loader to handle the result of these loaders.";
+		} else {
+			message +=
+				"\nYou may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders";
+		}
 		if (
 			err.loc &&
 			typeof err.loc === "object" &&
@@ -28,7 +38,7 @@ class ModuleParseError extends WebpackError {
 				// binary file
 				message += "\n(Source code omitted for this binary file)";
 			} else {
-				const sourceLines = source.split("\n");
+				const sourceLines = source.split(/\r?\n/);
 				const start = Math.max(0, lineNumber - 3);
 				const linesBefore = sourceLines.slice(start, lineNumber - 1);
 				const theLine = sourceLines[lineNumber - 1];

package/lib/MultiWatching.js

@@ -18,6 +18,18 @@ class MultiWatching {
 		}
 	}
 
+	suspend() {
+		for (const watching of this.watchings) {
+			watching.suspend();
+		}
+	}
+
+	resume() {
+		for (const watching of this.watchings) {
+			watching.resume();
+		}
+	}
+
 	close(callback) {
 		asyncLib.forEach(
 			this.watchings,

package/lib/NormalModule.js

@@ -348,7 +348,6 @@ class NormalModule extends Module {
 	markModuleAsErrored(error) {
 		// Restore build meta from successful build to keep importing state
 		this.buildMeta = Object.assign({}, this._lastSuccessfulBuildMeta);
-
 		this.error = error;
 		this.errors.push(this.error);
 		this._source = new RawSource(
@@ -445,7 +444,10 @@ class NormalModule extends Module {
 
 			const handleParseError = e => {
 				const source = this._source.source();
-				const error = new ModuleParseError(this, source, e);
+				const loaders = this.loaders.map(item =>
+					contextify(options.context, item.loader)
+				);
+				const error = new ModuleParseError(this, source, e, loaders);
 				this.markModuleAsErrored(error);
 				this._initBuildHash(compilation);
 				return callback();

package/lib/NormalModuleFactory.js

@@ -335,7 +335,11 @@ class NormalModuleFactory extends Tapable {
 						],
 						(err, results) => {
 							if (err) return callback(err);
-							loaders = results[0].concat(loaders, results[1], results[2]);
+							if (matchResource === undefined) {
+								loaders = results[0].concat(loaders, results[1], results[2]);
+							} else {
+								loaders = results[0].concat(results[1], loaders, results[2]);
+							}
 							process.nextTick(() => {
 								const type = settings.type;
 								const resolveOptions = settings.resolve;
@@ -435,9 +439,7 @@ class NormalModuleFactory extends Tapable {
 											err.message +
 											"\n" +
 											"BREAKING CHANGE: It's no longer allowed to omit the '-loader' suffix when using loaders.\n" +
-											`                 You need to specify '${
-												item.loader
-											}-loader' instead of '${item.loader}',\n` +
+											`                 You need to specify '${item.loader}-loader' instead of '${item.loader}',\n` +
 											"                 see https://webpack.js.org/migrate/3/#automatic-loader-module-name-extension-removed";
 									}
 									callback(err);

package/lib/OptionsDefaulter.js

@@ -4,8 +4,14 @@
 */
 "use strict";
 
-const getProperty = (obj, name) => {
-	name = name.split(".");
+/**
+ * Gets the value at path of object
+ * @param {object} obj - object to query
+ * @param {string} path - query path
+ * @returns {any} - if {@param path} requests element from array, then `undefined` will be returned
+ */
+const getProperty = (obj, path) => {
+	let name = path.split(".");
 	for (let i = 0; i < name.length - 1; i++) {
 		obj = obj[name[i]];
 		if (typeof obj !== "object" || !obj || Array.isArray(obj)) return;
@@ -13,8 +19,15 @@ const getProperty = (obj, name) => {
 	return obj[name.pop()];
 };
 
-const setProperty = (obj, name, value) => {
-	name = name.split(".");
+/**
+ * Sets the value at path of object. Stops execution, if {@param path} requests element from array to be set
+ * @param {object} obj - object to query
+ * @param {string} path - query path
+ * @param {any} value - value to be set
+ * @returns {void}
+ */
+const setProperty = (obj, path, value) => {
+	let name = path.split(".");
 	for (let i = 0; i < name.length - 1; i++) {
 		if (typeof obj[name[i]] !== "object" && obj[name[i]] !== undefined) return;
 		if (Array.isArray(obj[name[i]])) return;
@@ -24,21 +37,53 @@ const setProperty = (obj, name, value) => {
 	obj[name.pop()] = value;
 };
 
+/**
+ * @typedef {'call' | 'make' | 'append'} ConfigType
+ */
+/**
+ * @typedef {(options: object) => any} MakeConfigHandler
+ */
+/**
+ * @typedef {(value: any, options: object) => any} CallConfigHandler
+ */
+/**
+ * @typedef {any[]} AppendConfigValues
+ */
+
 class OptionsDefaulter {
 	constructor() {
+		/**
+		 * Stores default options settings or functions for computing them
+		 */
 		this.defaults = {};
+		/**
+		 * Stores configuration for options
+		 * @type {{[key: string]: ConfigType}}
+		 */
 		this.config = {};
 	}
 
+	/**
+	 * Enhancing {@param options} with default values
+	 * @param {object} options - provided options
+	 * @returns {object} - enhanced options
+	 * @throws {Error} - will throw error, if configuration value is other then `undefined` or {@link ConfigType}
+	 */
 	process(options) {
 		options = Object.assign({}, options);
 		for (let name in this.defaults) {
 			switch (this.config[name]) {
+				/**
+				 * If {@link ConfigType} doesn't specified and current value is `undefined`, then default value will be assigned
+				 */
 				case undefined:
 					if (getProperty(options, name) === undefined) {
 						setProperty(options, name, this.defaults[name]);
 					}
 					break;
+				/**
+				 * Assign result of {@link CallConfigHandler}
+				 */
 				case "call":
 					setProperty(
 						options,
@@ -46,11 +91,17 @@ class OptionsDefaulter {
 						this.defaults[name].call(this, getProperty(options, name), options)
 					);
 					break;
+				/**
+				 * Assign result of {@link MakeConfigHandler}, if current value is `undefined`
+				 */
 				case "make":
 					if (getProperty(options, name) === undefined) {
 						setProperty(options, name, this.defaults[name].call(this, options));
 					}
 					break;
+				/**
+				 * Adding {@link AppendConfigValues} at the end of the current array
+				 */
 				case "append": {
 					let oldValue = getProperty(options, name);
 					if (!Array.isArray(oldValue)) {
@@ -69,6 +120,13 @@ class OptionsDefaulter {
 		return options;
 	}
 
+	/**
+	 * Builds up default values
+	 * @param {string} name - option path
+	 * @param {ConfigType | any} config - if {@param def} is provided, then only {@link ConfigType} is allowed
+	 * @param {MakeConfigHandler | CallConfigHandler | AppendConfigValues} [def] - defaults
+	 * @returns {void}
+	 */
 	set(name, config, def) {
 		if (def !== undefined) {
 			this.defaults[name] = def;