webpack 4.3.0 → 4.4.0

package/bin/webpack.js

@@ -1,21 +1,80 @@
 #!/usr/bin/env node
+function runCommand(command, options) {
+	const cp = require("child_process");
+	return new Promise((resolve, reject) => {
+		const executedCommand = cp.spawn(command, options, {
+			stdio: "inherit"
+		});
+
+		executedCommand.on("error", error => {
+			reject(error);
+		});
+
+		executedCommand.on("exit", code => {
+			if (code === 0) {
+				resolve(true);
+			} else {
+				reject();
+			}
+		});
+	});
+}
 
 let webpackCliInstalled = false;
 try {
 	require.resolve("webpack-cli");
 	webpackCliInstalled = true;
-} catch (e) {
+} catch (err) {
 	webpackCliInstalled = false;
 }
 
-if (webpackCliInstalled) {
-	require("webpack-cli"); // eslint-disable-line node/no-missing-require, node/no-extraneous-require, node/no-unpublished-require
+if (!webpackCliInstalled) {
+	const path = require("path");
+	const fs = require("fs");
+	const readLine = require("readline");
+	const isYarn = fs.existsSync(path.resolve(process.cwd(), "yarn.lock"));
+
+	const packageManager = isYarn ? "yarn" : "npm";
+	const options = ["install", "-D", "webpack-cli"];
+
+	if (isYarn) {
+		options[0] = "add";
+	}
+
+	const commandToBeRun = `${packageManager} ${options.join(" ")}`;
+
+	const question = `Would you like to install webpack-cli? (That will run ${commandToBeRun}) `;
+
+	console.error("The CLI moved into a separate package: webpack-cli");
+	const questionInterface = readLine.createInterface({
+		input: process.stdin,
+		output: process.stdout
+	});
+	questionInterface.question(question, answer => {
+		questionInterface.close();
+		switch (answer.toLowerCase()) {
+			case "y":
+			case "yes":
+			case "1": {
+				runCommand(packageManager, options)
+					.then(result => {
+						return require("webpack-cli"); //eslint-disable-line
+					})
+					.catch(error => {
+						console.error(error);
+						process.exitCode = 1;
+					});
+				break;
+			}
+			default: {
+				console.error(
+					"It needs to be installed alongside webpack to use the CLI"
+				);
+				process.exitCode = 1;
+				break;
+			}
+		}
+	});
 } else {
-	console.error("The CLI moved into a separate package: webpack-cli.");
-	console.error(
-		"Please install 'webpack-cli' in addition to webpack itself to use the CLI."
-	);
-	console.error("-> When using npm: npm install webpack-cli -D");
-	console.error("-> When using yarn: yarn add webpack-cli -D");
-	process.exitCode = 1;
+	require("webpack-cli"); // eslint-disable-line
 }

package/lib/APIPlugin.js

@@ -52,11 +52,11 @@ class APIPlugin {
 									? ParserHelpers.toConstantDependency(
 											parser,
 											REPLACEMENTS[key]
-										)
+									  )
 									: ParserHelpers.toConstantDependencyWithWebpackRequire(
 											parser,
 											REPLACEMENTS[key]
-										)
+									  )
 							);
 						parser.hooks.evaluateTypeof
 							.for(key)

package/lib/AmdMainTemplatePlugin.js

@@ -36,17 +36,15 @@ class AmdMainTemplatePlugin {
 				});
 
 				return new ConcatSource(
-					`define(${JSON.stringify(name)}, ${externalsDepsArray}, function(${
-						externalsArguments
-					}) { return `,
+					`define(${JSON.stringify(
+						name
+					)}, ${externalsDepsArray}, function(${externalsArguments}) { return `,
 					source,
 					"});"
 				);
 			} else if (externalsArguments) {
 				return new ConcatSource(
-					`define(${externalsDepsArray}, function(${
-						externalsArguments
-					}) { return `,
+					`define(${externalsDepsArray}, function(${externalsArguments}) { return `,
 					source,
 					"});"
 				);

package/lib/AsyncDependencyToInitialChunkError.js

@@ -11,9 +11,7 @@ module.exports = class AsyncDependencyToInitialChunkError extends WebpackError {
 		super();
 
 		this.name = "AsyncDependencyToInitialChunkError";
-		this.message = `It's not allowed to load an initial chunk on demand. The chunk name "${
-			chunkName
-		}" is already used by an entrypoint.`;
+		this.message = `It's not allowed to load an initial chunk on demand. The chunk name "${chunkName}" is already used by an entrypoint.`;
 		this.module = module;
 		this.origin = module;
 		this.originLoc = loc;

package/lib/Compilation.js

@@ -158,8 +158,6 @@ class Compilation extends Tapable {
 			beforeChunkAssets: new SyncHook([]),
 			additionalChunkAssets: new SyncHook(["chunks"]),
 
-			records: new SyncHook(["compilation", "records"]),
-
 			additionalAssets: new AsyncSeriesHook([]),
 			optimizeChunkAssets: new AsyncSeriesHook(["chunks"]),
 			afterOptimizeChunkAssets: new SyncHook(["chunks"]),
@@ -253,6 +251,9 @@ class Compilation extends Tapable {
 		this.childrenCounters = {};
 		this.usedChunkIds = null;
 		this.usedModuleIds = null;
+		this.fileTimestamps = undefined;
+		this.contextTimestamps = undefined;
+		this.compilationDependencies = undefined;
 
 		this._buildingModules = new Map();
 		this._rebuildingModules = new Map();
@@ -277,6 +278,9 @@ class Compilation extends Tapable {
 		if (this.cache && this.cache[cacheName]) {
 			const cacheModule = this.cache[cacheName];
 
+			if (typeof cacheModule.updateCacheModule === "function")
+				cacheModule.updateCacheModule(module);
+
 			let rebuild = true;
 			if (this.fileTimestamps && this.contextTimestamps) {
 				rebuild = cacheModule.needRebuild(
@@ -624,12 +628,12 @@ class Compilation extends Tapable {
 		const errorAndCallback = this.bail
 			? err => {
 					callback(err);
-				}
+			  }
 			: err => {
 					err.dependencies = [dependency];
 					this.errors.push(err);
 					callback();
-				};
+			  };
 
 		if (
 			typeof dependency !== "object" ||

package/lib/Compiler.js

@@ -94,36 +94,36 @@ class Compiler extends Tapable {
 					this.resolverFactory.plugin("resolver normal", resolver => {
 						resolver.plugin(hook, fn);
 					});
-				}, "webpack: Using compiler.resolvers.normal is deprecated.\n" + 'Use compiler.resolverFactory.plugin("resolver normal", resolver => {\n  resolver.plugin(/* ... */);\n}); instead.'),
+				}, "webpack: Using compiler.resolvers.normal is deprecated.\n" + 'Use compiler.resolverFactory.plugin("resolver normal", resolver => {\n  resolver.plugin(/* … */);\n}); instead.'),
 				apply: util.deprecate((...args) => {
 					this.resolverFactory.plugin("resolver normal", resolver => {
 						resolver.apply(...args);
 					});
-				}, "webpack: Using compiler.resolvers.normal is deprecated.\n" + 'Use compiler.resolverFactory.plugin("resolver normal", resolver => {\n  resolver.apply(/* ... */);\n}); instead.')
+				}, "webpack: Using compiler.resolvers.normal is deprecated.\n" + 'Use compiler.resolverFactory.plugin("resolver normal", resolver => {\n  resolver.apply(/* … */);\n}); instead.')
 			},
 			loader: {
 				plugins: util.deprecate((hook, fn) => {
 					this.resolverFactory.plugin("resolver loader", resolver => {
 						resolver.plugin(hook, fn);
 					});
-				}, "webpack: Using compiler.resolvers.loader is deprecated.\n" + 'Use compiler.resolverFactory.plugin("resolver loader", resolver => {\n  resolver.plugin(/* ... */);\n}); instead.'),
+				}, "webpack: Using compiler.resolvers.loader is deprecated.\n" + 'Use compiler.resolverFactory.plugin("resolver loader", resolver => {\n  resolver.plugin(/* … */);\n}); instead.'),
 				apply: util.deprecate((...args) => {
 					this.resolverFactory.plugin("resolver loader", resolver => {
 						resolver.apply(...args);
 					});
-				}, "webpack: Using compiler.resolvers.loader is deprecated.\n" + 'Use compiler.resolverFactory.plugin("resolver loader", resolver => {\n  resolver.apply(/* ... */);\n}); instead.')
+				}, "webpack: Using compiler.resolvers.loader is deprecated.\n" + 'Use compiler.resolverFactory.plugin("resolver loader", resolver => {\n  resolver.apply(/* … */);\n}); instead.')
 			},
 			context: {
 				plugins: util.deprecate((hook, fn) => {
 					this.resolverFactory.plugin("resolver context", resolver => {
 						resolver.plugin(hook, fn);
 					});
-				}, "webpack: Using compiler.resolvers.context is deprecated.\n" + 'Use compiler.resolverFactory.plugin("resolver context", resolver => {\n  resolver.plugin(/* ... */);\n}); instead.'),
+				}, "webpack: Using compiler.resolvers.context is deprecated.\n" + 'Use compiler.resolverFactory.plugin("resolver context", resolver => {\n  resolver.plugin(/* … */);\n}); instead.'),
 				apply: util.deprecate((...args) => {
 					this.resolverFactory.plugin("resolver context", resolver => {
 						resolver.apply(...args);
 					});
-				}, "webpack: Using compiler.resolvers.context is deprecated.\n" + 'Use compiler.resolverFactory.plugin("resolver context", resolver => {\n  resolver.apply(/* ... */);\n}); instead.')
+				}, "webpack: Using compiler.resolvers.context is deprecated.\n" + 'Use compiler.resolverFactory.plugin("resolver context", resolver => {\n  resolver.apply(/* … */);\n}); instead.')
 			}
 		};
 
@@ -448,10 +448,7 @@ class Compiler extends Tapable {
 	}
 
 	createContextModuleFactory() {
-		const contextModuleFactory = new ContextModuleFactory(
-			this.resolverFactory,
-			this.inputFileSystem
-		);
+		const contextModuleFactory = new ContextModuleFactory(this.resolverFactory);
 		this.hooks.contextModuleFactory.call(contextModuleFactory);
 		return contextModuleFactory;
 	}

package/lib/ContextModule.js

@@ -43,6 +43,14 @@ class ContextModule extends Module {
 
 		if (typeof options.mode !== "string")
 			throw new Error("options.mode is a required option");
+
+		this._identifier = this._createIdentifier();
+	}
+
+	updateCacheModule(module) {
+		this.resolveDependencies = module.resolveDependencies;
+		this.options = module.options;
+		this.resolveOptions = module.resolveOptions;
 	}
 
 	prettyRegExp(regexString) {
@@ -63,7 +71,7 @@ class ContextModule extends Module {
 			.join("!");
 	}
 
-	identifier() {
+	_createIdentifier() {
 		let identifier = this.context;
 		if (this.options.resourceQuery)
 			identifier += ` ${this.options.resourceQuery}`;
@@ -80,6 +88,10 @@ class ContextModule extends Module {
 		return identifier;
 	}
 
+	identifier() {
+		return this._identifier;
+	}
+
 	readableIdentifier(requestShortener) {
 		let identifier = requestShortener.shorten(this.context);
 		if (this.options.resourceQuery)
@@ -281,9 +293,11 @@ class ContextModule extends Module {
 	getReturnModuleObjectSource(fakeMap, fakeMapDataExpression = "fakeMap[id]") {
 		if (typeof fakeMap === "number")
 			return `return ${this.getReturn(fakeMap)};`;
-		return `return ${fakeMapDataExpression} === 1 ? ${this.getReturn(1)} : ${
-			fakeMapDataExpression
-		} ? ${this.getReturn(2)} : ${this.getReturn(0)};`;
+		return `return ${fakeMapDataExpression} === 1 ? ${this.getReturn(
+			1
+		)} : ${fakeMapDataExpression} ? ${this.getReturn(2)} : ${this.getReturn(
+			0
+		)};`;
 	}
 
 	getSyncSource(dependencies, id) {
@@ -500,9 +514,7 @@ module.exports = webpackAsyncContext;`;
 
 		const chunksStartPosition = typeof fakeMap === "object" ? 2 : 1;
 		const requestPrefix = hasMultipleOrNoChunks
-			? `Promise.all(ids.slice(${
-					chunksStartPosition
-				}).map(__webpack_require__.e))`
+			? `Promise.all(ids.slice(${chunksStartPosition}).map(__webpack_require__.e))`
 			: `__webpack_require__.e(ids[${chunksStartPosition}])`;
 		const returnModuleObject = this.getReturnModuleObjectSource(
 			fakeMap,

package/lib/DefinePlugin.js

@@ -112,7 +112,7 @@ class DefinePlugin {
 										? ParserHelpers.toConstantDependencyWithWebpackRequire(
 												parser,
 												code
-											)
+										  )
 										: ParserHelpers.toConstantDependency(parser, code)
 								);
 						}
@@ -164,7 +164,7 @@ class DefinePlugin {
 									? ParserHelpers.toConstantDependencyWithWebpackRequire(
 											parser,
 											code
-										)
+									  )
 									: ParserHelpers.toConstantDependency(parser, code)
 							);
 						parser.hooks.typeof

package/lib/Dependency.js

@@ -1,52 +1,53 @@
-/*
-	MIT License http://www.opensource.org/licenses/mit-license.php
-	Author Tobias Koppers @sokra
-*/
-"use strict";
-const compareLocations = require("./compareLocations");
-
-class Dependency {
-	constructor() {
-		this.module = null;
-		this.weak = false;
-		this.optional = false;
-	}
-
-	getResourceIdentifier() {
-		return null;
-	}
-
-	// Returns the referenced module and export
-	getReference() {
-		if (!this.module) return null;
-		return {
-			module: this.module,
-			weak: this.weak,
-			importedNames: true // true: full object, false: only sideeffects/no export, array of strings: the exports with this names
-		};
-	}
-
-	// Returns the exported names
-	getExports() {
-		return null;
-	}
-
-	getWarnings() {
-		return null;
-	}
-
-	getErrors() {
-		return null;
-	}
-
-	updateHash(hash) {
-		hash.update((this.module && this.module.id) + "");
-	}
-
-	disconnect() {
-		this.module = null;
-	}
-}
-Dependency.compare = (a, b) => compareLocations(a.loc, b.loc);
-
-module.exports = Dependency;
+/*
+	MIT License http://www.opensource.org/licenses/mit-license.php
+	Author Tobias Koppers @sokra
+*/
+"use strict";
+const compareLocations = require("./compareLocations");
+
+class Dependency {
+	constructor() {
+		this.module = null;
+		this.weak = false;
+		this.optional = false;
+		this.loc = undefined;
+	}
+
+	getResourceIdentifier() {
+		return null;
+	}
+
+	// Returns the referenced module and export
+	getReference() {
+		if (!this.module) return null;
+		return {
+			module: this.module,
+			weak: this.weak,
+			importedNames: true // true: full object, false: only sideeffects/no export, array of strings: the exports with this names
+		};
+	}
+
+	// Returns the exported names
+	getExports() {
+		return null;
+	}
+
+	getWarnings() {
+		return null;
+	}
+
+	getErrors() {
+		return null;
+	}
+
+	updateHash(hash) {
+		hash.update((this.module && this.module.id) + "");
+	}
+
+	disconnect() {
+		this.module = null;
+	}
+}
+Dependency.compare = (a, b) => compareLocations(a.loc, b.loc);
+
+module.exports = Dependency;

package/lib/EnvironmentPlugin.js

@@ -42,9 +42,7 @@ class EnvironmentPlugin {
 			if (value === undefined) {
 				compiler.hooks.thisCompilation.tap("EnvironmentPlugin", compilation => {
 					const error = new Error(
-						`EnvironmentPlugin - ${
-							key
-						} environment variable is undefined.\n\n` +
+						`EnvironmentPlugin - ${key} environment variable is undefined.\n\n` +
 							"You can pass an object with default values to suppress this warning.\n" +
 							"See https://webpack.js.org/plugins/environment-plugin for example."
 					);

package/lib/ExternalModule.js

@@ -76,9 +76,9 @@ class ExternalModule extends Module {
 	}
 
 	checkExternalVariable(variableToCheck, request) {
-		return `if(typeof ${
-			variableToCheck
-		} === 'undefined') {${WebpackMissingModule.moduleCode(request)}}\n`;
+		return `if(typeof ${variableToCheck} === 'undefined') {${WebpackMissingModule.moduleCode(
+			request
+		)}}\n`;
 	}
 
 	getSourceForAmdOrUmdExternal(id, optional, request) {

package/lib/HotUpdateChunkTemplate.js

@@ -47,7 +47,7 @@ module.exports = class HotUpdateChunkTemplate extends Tapable {
 		hotUpdateChunk.removedModules = removedModules;
 		const modulesSource = Template.renderChunkModules(
 			hotUpdateChunk,
-			() => true,
+			m => typeof m.source === "function",
 			moduleTemplate,
 			dependencyTemplates
 		);

package/lib/JavascriptGenerator.js

@@ -83,9 +83,9 @@ class JavascriptGenerator {
 			 * we can not inject "foo" twice, therefore we just make two IIFEs like so:
 			 * (function(foo, bar, baz){
 			 *   (function(foo, some, more){
-			 *     ...
-			 *   }(...));
-			 * }(...));
+			 *     …
+			 *   }(…));
+			 * }(…));
 			 *
 			 * "splitVariablesInUniqueNamedChunks" splits the variables shown above up to this:
 			 * [[foo, bar, baz], [foo, some, more]]
@@ -177,8 +177,8 @@ class JavascriptGenerator {
 
 	/*
 	 * creates the start part of a IIFE around the module to inject a variable name
-	 * (function(...){   <- this part
-	 * }.call(...))
+	 * (function(…){   <- this part
+	 * }.call(…))
 	 */
 	variableInjectionFunctionWrapperStartCode(varNames) {
 		const args = varNames.join(", ");
@@ -194,8 +194,8 @@ class JavascriptGenerator {
 
 	/*
 	 * creates the end part of a IIFE around the module to inject a variable name
-	 * (function(...){
-	 * }.call(...))   <- this part
+	 * (function(…){
+	 * }.call(…))   <- this part
 	 */
 	variableInjectionFunctionWrapperEndCode(module, varExpressions, block) {
 		const firstParam = this.contextArgument(module, block);

package/lib/JavascriptModulesPlugin.js

@@ -32,18 +32,18 @@ class JavascriptModulesPlugin {
 					});
 				normalModuleFactory.hooks.createGenerator
 					.for("javascript/auto")
-					.tap("JavascriptModulesPlugin", options => {
-						return new JavascriptGenerator(options);
+					.tap("JavascriptModulesPlugin", () => {
+						return new JavascriptGenerator();
 					});
 				normalModuleFactory.hooks.createGenerator
 					.for("javascript/dynamic")
-					.tap("JavascriptModulesPlugin", options => {
-						return new JavascriptGenerator(options);
+					.tap("JavascriptModulesPlugin", () => {
+						return new JavascriptGenerator();
 					});
 				normalModuleFactory.hooks.createGenerator
 					.for("javascript/esm")
-					.tap("JavascriptModulesPlugin", options => {
-						return new JavascriptGenerator(options);
+					.tap("JavascriptModulesPlugin", () => {
+						return new JavascriptGenerator();
 					});
 				compilation.mainTemplate.hooks.renderManifest.tap(
 					"JavascriptModulesPlugin",

package/lib/MainTemplate.js

@@ -179,7 +179,7 @@ module.exports = class MainTemplate extends Tapable {
 									"if(threw) delete installedModules[moduleId];"
 								]),
 								"}"
-							]
+						  ]
 						: [
 								"// Execute the module function",
 								`modules[moduleId].call(module.exports, module, module.exports, ${this.renderRequireFunctionForModule(
@@ -187,7 +187,7 @@ module.exports = class MainTemplate extends Tapable {
 									chunk,
 									"moduleId"
 								)});`
-							]
+						  ]
 				),
 				"",
 				"// Flag the module as loaded",