webpack 4.28.3 → 4.29.2

package/README.md

@@ -43,6 +43,23 @@
   </p>
 </div>
 
+## Table of Contents
+
+1. [Install](#install)
+2. [Introduction](#introduction)
+3. [Concepts](#concepts)
+4. [Contributing](#contributing)
+5. [Support](#support)
+6. [Core Team](#core-team)
+7. [Sponsoring](#sponsoring)
+8. [Premium Partners](#premium-partners)
+9. [Other Backers and Sponsors](#other-backers-and-sponsors)
+10. [Gold Sponsors](#gold-sponsors)
+11. [Silver Sponsors](#silver-sponsors)
+12. [Bronze Sponsors](#bronze-sponsors)
+13. [Backers](#backers)
+14. [Special Thanks](#special-thanks-to)
+
 <h2 align="center">Install</h2>
 
 Install with npm:
@@ -329,7 +346,7 @@ If you create a loader or plugin, we would <3 for you to open source it, and put
 
 <h2 align="center">Support</h2>
 
-We consider webpack to be a low-level tool used not only individually but also layered beneath other awesome tools. Because of it's flexibility, webpack isn't always the _easiest_ entry-level solution, however we do believe it is the most powerful. That said, we're always looking for ways improve and simplify the tool without compromising functionality. If you have any ideas on ways to accomplish this, we're all ears!
+We consider webpack to be a low-level tool used not only individually but also layered beneath other awesome tools. Because of its flexibility, webpack isn't always the _easiest_ entry-level solution, however we do believe it is the most powerful. That said, we're always looking for ways improve and simplify the tool without compromising functionality. If you have any ideas on ways to accomplish this, we're all ears!
 
 If you're just getting started, take a look at [our new docs and concepts page](https://webpack.js.org/concepts/). This has a high level overview that is great for beginners!!
 
@@ -724,7 +741,7 @@ src="https://static.monei.net/monei-logo.svg" height="30" alt="MONEI"></a>
 <a href="https://opencollective.com/webpack/backer/99/website?requireActive=false" target="_blank"><img src="https://opencollective.com/webpack/backer/99/avatar.svg?requireActive=false"></a>
 <a href="https://opencollective.com/webpack/backer/100/website?requireActive=false" target="_blank"><img src="https://opencollective.com/webpack/backer/100/avatar.svg?requireActive=false"></a>
 
-<h2 align="center">Thanks to</h2>
+<h2 align="center">Special Thanks to</h2>
 <p align="center">(In chronological order)</p>
 
 * @google for [Google Web Toolkit (GWT)](http://www.gwtproject.org/), which aims to compile Java to JavaScript. It features a similar [Code Splitting](http://www.gwtproject.org/doc/latest/DevGuideCodeSplitting.html) as webpack.

package/bin/webpack.js

@@ -1,5 +1,6 @@
 #!/usr/bin/env node
 
+// @ts-ignore
 process.exitCode = 0;
 
 /**
@@ -164,5 +165,7 @@ if (installedClis.length === 0) {
 				" and "
 			)} together. To work with the "webpack" command you need only one CLI package, please remove one of them or use them directly via their binary.`
 	);
+
+	// @ts-ignore
 	process.exitCode = 1;
 }

package/declarations/WebpackOptions.d.ts

@@ -15,7 +15,7 @@ export type Entry = EntryDynamic | EntryStatic;
  * This interface was referenced by `WebpackOptions`'s JSON-Schema
  * via the `definition` "EntryDynamic".
  */
-export type EntryDynamic = (() => EntryStatic | Promise<EntryStatic>);
+export type EntryDynamic = () => EntryStatic | Promise<EntryStatic>;
 /**
  * This interface was referenced by `WebpackOptions`'s JSON-Schema
  * via the `definition` "EntryStatic".
@@ -1051,6 +1051,10 @@ export interface OutputOptions {
 	 * Specifies the name of each output file on disk. You must **not** specify an absolute path here! The `output.path` option determines the location on disk the files are written to, filename is used solely for naming the individual files.
 	 */
 	filename?: string | Function;
+	/**
+	 * Use the future version of asset emitting logic, which is allows freeing memory of assets after emitting. It could break plugins which assume that assets are still readable after emitting. Will be the new default in the next major version.
+	 */
+	futureEmitAssets?: boolean;
 	/**
 	 * An expression which is used to address the global object/scope in runtime code
 	 */

package/declarations/plugins/BannerPlugin.d.ts

@@ -11,15 +11,13 @@ export type BannerPluginArgument =
 /**
  * The banner as function, it will be wrapped in a comment
  */
-export type BannerFunction = (
-	data: {
-		hash: string;
-		chunk: import("../../lib/Chunk");
-		filename: string;
-		basename: string;
-		query: string;
-	}
-) => string;
+export type BannerFunction = (data: {
+	hash: string;
+	chunk: import("../../lib/Chunk");
+	filename: string;
+	basename: string;
+	query: string;
+}) => string;
 export type Rules = Rule[] | Rule;
 export type Rule = RegExp | string;
 

package/declarations/plugins/IgnorePlugin.d.ts

@@ -19,9 +19,9 @@ export type IgnorePluginOptions =
 			/**
 			 * A filter function for context
 			 */
-			checkContext?: ((context: string) => boolean);
+			checkContext?: (context: string) => boolean;
 			/**
 			 * A filter function for resource and context
 			 */
-			checkResource?: ((resource: string, context: string) => boolean);
+			checkResource?: (resource: string, context: string) => boolean;
 	  };

package/declarations/plugins/ProgressPlugin.d.ts

@@ -8,11 +8,11 @@ export type ProgressPluginArgument = ProgressPluginOptions | HandlerFunction;
 /**
  * Function that executes for every progress step
  */
-export type HandlerFunction = ((
+export type HandlerFunction = (
 	percentage: number,
 	msg: string,
 	...args: string[]
-) => void);
+) => void;
 
 export interface ProgressPluginOptions {
 	/**

package/lib/AmdMainTemplatePlugin.js

@@ -40,8 +40,8 @@ class AmdMainTemplatePlugin {
 		const onRenderWithEntry = (source, chunk, hash) => {
 			const externals = chunk.getModules().filter(m => m.external);
 			const externalsDepsArray = JSON.stringify(
-				externals.map(
-					m => (typeof m.request === "object" ? m.request.amd : m.request)
+				externals.map(m =>
+					typeof m.request === "object" ? m.request.amd : m.request
 				)
 			);
 			const externalsArguments = externals

package/lib/Compilation.js

@@ -491,6 +491,8 @@ class Compilation extends Tapable {
 		this._buildingModules = new Map();
 		/** @private @type {Map<Module, Callback[]>} */
 		this._rebuildingModules = new Map();
+		/** @type {Set<string>} */
+		this.emittedAssets = new Set();
 	}
 
 	getStats() {

package/lib/Compiler.js

@@ -7,6 +7,7 @@
 const parseJson = require("json-parse-better-errors");
 const asyncLib = require("neo-async");
 const path = require("path");
+const { Source } = require("webpack-sources");
 const util = require("util");
 const {
 	Tapable,
@@ -188,6 +189,11 @@ class Compiler extends Tapable {
 
 		/** @type {boolean} */
 		this.watchMode = false;
+
+		/** @private @type {WeakMap<Source, { sizeOnlySource: SizeOnlySource, writtenTo: Map<string, number> }>} */
+		this._assetEmittingSourceCache = new WeakMap();
+		/** @private @type {Map<string, number>} */
+		this._assetEmittingWrittenFiles = new Map();
 	}
 
 	watch(watchOptions, handler) {
@@ -207,6 +213,10 @@ class Compiler extends Tapable {
 		const finalCallback = (err, stats) => {
 			this.running = false;
 
+			if (err) {
+				this.hooks.failed.call(err);
+			}
+
 			if (callback !== undefined) return callback(err, stats);
 		};
 
@@ -308,8 +318,9 @@ class Compiler extends Tapable {
 		const emitFiles = err => {
 			if (err) return callback(err);
 
-			asyncLib.forEach(
+			asyncLib.forEachLimit(
 				compilation.assets,
+				15,
 				(source, file, callback) => {
 					let targetFile = file;
 					const queryStringIdx = targetFile.indexOf("?");
@@ -323,19 +334,86 @@ class Compiler extends Tapable {
 							outputPath,
 							targetFile
 						);
-						if (source.existsAt === targetPath) {
-							source.emitted = false;
-							return callback();
+						// TODO webpack 5 remove futureEmitAssets option and make it on by default
+						if (this.options.output.futureEmitAssets) {
+							// check if the target file has already been written by this Compiler
+							const targetFileGeneration = this._assetEmittingWrittenFiles.get(
+								targetPath
+							);
+
+							// create an cache entry for this Source if not already existing
+							let cacheEntry = this._assetEmittingSourceCache.get(source);
+							if (cacheEntry === undefined) {
+								cacheEntry = {
+									sizeOnlySource: undefined,
+									writtenTo: new Map()
+								};
+								this._assetEmittingSourceCache.set(source, cacheEntry);
+							}
+
+							// if the target file has already been written
+							if (targetFileGeneration !== undefined) {
+								// check if the Source has been written to this target file
+								const writtenGeneration = cacheEntry.writtenTo.get(targetPath);
+								if (writtenGeneration === targetFileGeneration) {
+									// if yes, we skip writing the file
+									// as it's already there
+									// (we assume one doesn't remove files while the Compiler is running)
+									return callback();
+								}
+							}
+
+							// get the binary (Buffer) content from the Source
+							/** @type {Buffer} */
+							let content;
+							if (typeof source.buffer === "function") {
+								content = source.buffer();
+							} else {
+								const bufferOrString = source.source();
+								if (Buffer.isBuffer(bufferOrString)) {
+									content = bufferOrString;
+								} else {
+									content = Buffer.from(bufferOrString, "utf8");
+								}
+							}
+
+							// Create a replacement resource which only allows to ask for size
+							// This allows to GC all memory allocated by the Source
+							// (expect when the Source is stored in any other cache)
+							cacheEntry.sizeOnlySource = new SizeOnlySource(content.length);
+							compilation.assets[file] = cacheEntry.sizeOnlySource;
+
+							// Write the file to output file system
+							this.outputFileSystem.writeFile(targetPath, content, err => {
+								if (err) return callback(err);
+
+								// information marker that the asset has been emitted
+								compilation.emittedAssets.add(file);
+
+								// cache the information that the Source has been written to that location
+								const newGeneration =
+									targetFileGeneration === undefined
+										? 1
+										: targetFileGeneration + 1;
+								cacheEntry.writtenTo.set(targetPath, newGeneration);
+								this._assetEmittingWrittenFiles.set(targetPath, newGeneration);
+								callback();
+							});
+						} else {
+							if (source.existsAt === targetPath) {
+								source.emitted = false;
+								return callback();
+							}
+							let content = source.source();
+
+							if (!Buffer.isBuffer(content)) {
+								content = Buffer.from(content, "utf8");
+							}
+
+							source.existsAt = targetPath;
+							source.emitted = true;
+							this.outputFileSystem.writeFile(targetPath, content, callback);
 						}
-						let content = source.source();
-
-						if (!Buffer.isBuffer(content)) {
-							content = Buffer.from(content, "utf8");
-						}
-
-						source.existsAt = targetPath;
-						source.emitted = true;
-						this.outputFileSystem.writeFile(targetPath, content, callback);
 					};
 
 					if (targetFile.match(/\/|\\/)) {
@@ -558,3 +636,48 @@ class Compiler extends Tapable {
 }
 
 module.exports = Compiler;
+
+class SizeOnlySource extends Source {
+	constructor(size) {
+		super();
+		this._size = size;
+	}
+
+	_error() {
+		return new Error(
+			"Content and Map of this Source is no longer available (only size() is supported)"
+		);
+	}
+
+	size() {
+		return this._size;
+	}
+
+	/**
+	 * @param {any} options options
+	 * @returns {string} the source
+	 */
+	source(options) {
+		throw this._error();
+	}
+
+	node() {
+		throw this._error();
+	}
+
+	listMap() {
+		throw this._error();
+	}
+
+	map() {
+		throw this._error();
+	}
+
+	listNode() {
+		throw this._error();
+	}
+
+	updateHash() {
+		throw this._error();
+	}
+}

package/lib/JsonGenerator.js

@@ -12,9 +12,8 @@ const stringifySafe = data => {
 		return undefined; // Invalid JSON
 	}
 
-	return stringified.replace(
-		/\u2028|\u2029/g,
-		str => (str === "\u2029" ? "\\u2029" : "\\u2028")
+	return stringified.replace(/\u2028|\u2029/g, str =>
+		str === "\u2029" ? "\\u2029" : "\\u2028"
 	); // invalid in JavaScript but valid JSON
 };
 

package/lib/Parser.js

@@ -6,7 +6,8 @@
 
 // Syntax: https://developer.mozilla.org/en/SpiderMonkey/Parser_API
 
-const acorn = require("acorn-dynamic-import").default;
+const acorn = require("acorn");
+const acornDynamicImport = require("acorn-dynamic-import").default;
 const { Tapable, SyncBailHook, HookMap } = require("tapable");
 const util = require("util");
 const vm = require("vm");
@@ -14,6 +15,8 @@ const BasicEvaluatedExpression = require("./BasicEvaluatedExpression");
 const StackedSetMap = require("./util/StackedSetMap");
 const TrackingSet = require("./util/TrackingSet");
 
+const acornParser = acorn.Parser.extend(acornDynamicImport);
+
 const joinRanges = (startRange, endRange) => {
 	if (!endRange) return startRange;
 	if (!startRange) return endRange;
@@ -25,10 +28,7 @@ const defaultParserOptions = {
 	locations: true,
 	ecmaVersion: 2019,
 	sourceType: "module",
-	onComment: null,
-	plugins: {
-		dynamicImport: true
-	}
+	onComment: null
 };
 
 // regexp to match at lease one "magic comment"
@@ -1335,8 +1335,8 @@ class Parser extends Tapable {
 			statement.kind === "const"
 				? this.hooks.varDeclarationConst
 				: statement.kind === "let"
-					? this.hooks.varDeclarationLet
-					: this.hooks.varDeclarationVar;
+				? this.hooks.varDeclarationLet
+				: this.hooks.varDeclarationVar;
 		for (const declarator of statement.declarations) {
 			switch (declarator.type) {
 				case "VariableDeclarator": {
@@ -2133,9 +2133,13 @@ class Parser extends Tapable {
 			sourceType: this.sourceType,
 			locations: false
 		});
+		// TODO(https://github.com/acornjs/acorn/issues/741)
+		// @ts-ignore
 		if (ast.body.length !== 1 || ast.body[0].type !== "ExpressionStatement") {
 			throw new Error("evaluate: Source is not a expression");
 		}
+		// TODO(https://github.com/acornjs/acorn/issues/741)
+		// @ts-ignore
 		return this.evaluateExpression(ast.body[0].expression);
 	}
 
@@ -2226,7 +2230,7 @@ class Parser extends Tapable {
 		let error;
 		let threw = false;
 		try {
-			ast = acorn.parse(code, parserOptions);
+			ast = acornParser.parse(code, parserOptions);
 		} catch (e) {
 			error = e;
 			threw = true;
@@ -2238,7 +2242,7 @@ class Parser extends Tapable {
 				parserOptions.onComment.length = 0;
 			}
 			try {
-				ast = acorn.parse(code, parserOptions);
+				ast = acornParser.parse(code, parserOptions);
 				threw = false;
 			} catch (e) {
 				threw = true;

package/lib/Stats.js

@@ -288,8 +288,8 @@ class Stats {
 					e.chunk.hasRuntime()
 						? " [entry]"
 						: e.chunk.canBeInitial()
-							? " [initial]"
-							: ""
+						? " [initial]"
+						: ""
 				}\n`;
 			}
 			if (e.file) {
@@ -400,7 +400,10 @@ class Stats {
 						size: compilation.assets[asset].size(),
 						chunks: [],
 						chunkNames: [],
-						emitted: compilation.assets[asset].emitted
+						// TODO webpack 5: remove .emitted
+						emitted:
+							compilation.assets[asset].emitted ||
+							compilation.emittedAssets.has(asset)
 					};
 
 					if (showPerformance) {

package/lib/UmdMainTemplatePlugin.js

@@ -236,12 +236,12 @@ class UmdMainTemplatePlugin {
 								  amdFactory +
 								  ");\n"
 							: this.names.amd && this.namedDefine === true
-								? "		define(" +
-								  libraryName(this.names.amd) +
-								  ", [], " +
-								  amdFactory +
-								  ");\n"
-								: "		define([], " + amdFactory + ");\n") +
+							? "		define(" +
+							  libraryName(this.names.amd) +
+							  ", [], " +
+							  amdFactory +
+							  ");\n"
+							: "		define([], " + amdFactory + ");\n") +
 						(this.names.root || this.names.commonjs
 							? getAuxilaryComment("commonjs") +
 							  "	else if(typeof exports === 'object')\n" +

package/lib/WatchIgnorePlugin.js

@@ -17,8 +17,8 @@ class IgnoringWatchFileSystem {
 
 	watch(files, dirs, missing, startTime, options, callback, callbackUndelayed) {
 		const ignored = path =>
-			this.paths.some(
-				p => (p instanceof RegExp ? p.test(path) : path.indexOf(p) === 0)
+			this.paths.some(p =>
+				p instanceof RegExp ? p.test(path) : path.indexOf(p) === 0
 			);
 
 		const notIgnored = path => !ignored(path);

package/lib/WebpackOptionsApply.js

@@ -260,10 +260,10 @@ class WebpackOptionsApply extends OptionsApply {
 					  "MappingURL=[url]\n//# source" +
 					  "MappingURL=[url]\n*/"
 					: legacy
-						? "\n/*\n//@ source" + "MappingURL=[url]\n*/"
-						: modern
-							? "\n//# source" + "MappingURL=[url]"
-							: null;
+					? "\n/*\n//@ source" + "MappingURL=[url]\n*/"
+					: modern
+					? "\n//# source" + "MappingURL=[url]"
+					: null;
 			const Plugin = evalWrapped
 				? EvalSourceMapDevToolPlugin
 				: SourceMapDevToolPlugin;
@@ -286,10 +286,10 @@ class WebpackOptionsApply extends OptionsApply {
 				legacy && modern
 					? "\n//@ sourceURL=[url]\n//# sourceURL=[url]"
 					: legacy
-						? "\n//@ sourceURL=[url]"
-						: modern
-							? "\n//# sourceURL=[url]"
-							: null;
+					? "\n//@ sourceURL=[url]"
+					: modern
+					? "\n//# sourceURL=[url]"
+					: null;
 			new EvalDevToolModulePlugin({
 				sourceUrlComment: comment,
 				moduleFilenameTemplate: options.output.devtoolModuleFilenameTemplate,
@@ -463,7 +463,7 @@ class WebpackOptionsApply extends OptionsApply {
 		if (options.optimization.minimize) {
 			for (const minimizer of options.optimization.minimizer) {
 				if (typeof minimizer === "function") {
-					minimizer.apply(compiler);
+					minimizer.call(compiler, compiler);
 				} else {
 					minimizer.apply(compiler);
 				}

package/lib/WebpackOptionsDefaulter.js

@@ -33,10 +33,8 @@ class WebpackOptionsDefaulter extends OptionsDefaulter {
 
 		this.set("entry", "./src");
 
-		this.set(
-			"devtool",
-			"make",
-			options => (options.mode === "development" ? "eval" : false)
+		this.set("devtool", "make", options =>
+			options.mode === "development" ? "eval" : false
 		);
 		this.set("cache", "make", options => options.mode === "development");
 
@@ -193,10 +191,8 @@ class WebpackOptionsDefaulter extends OptionsDefaulter {
 		});
 		this.set("performance.maxAssetSize", 250000);
 		this.set("performance.maxEntrypointSize", 250000);
-		this.set(
-			"performance.hints",
-			"make",
-			options => (isProductionLikeMode(options) ? "warning" : false)
+		this.set("performance.hints", "make", options =>
+			isProductionLikeMode(options) ? "warning" : false
 		);
 
 		this.set("optimization", "call", value => Object.assign({}, value));

package/lib/dependencies/AMDRequireDependenciesBlock.js

@@ -36,8 +36,12 @@ module.exports = class AMDRequireDependenciesBlock extends AsyncDependenciesBloc
 		} else {
 			this.range = expr.range;
 		}
-		const dep = new AMDRequireDependency(this);
+		const dep = this.newRequireDependency();
 		dep.loc = loc;
 		this.addDependency(dep);
 	}
+
+	newRequireDependency() {
+		return new AMDRequireDependency(this);
+	}
 };

package/lib/dependencies/HarmonyDetectionParserPlugin.js

@@ -13,9 +13,13 @@ module.exports = class HarmonyDetectionParserPlugin {
 			const isStrictHarmony = parser.state.module.type === "javascript/esm";
 			const isHarmony =
 				isStrictHarmony ||
-				ast.body.some(statement => {
-					return /^(Import|Export).*Declaration$/.test(statement.type);
-				});
+				ast.body.some(
+					statement =>
+						statement.type === "ImportDeclaration" ||
+						statement.type === "ExportDefaultDeclaration" ||
+						statement.type === "ExportNamedDeclaration" ||
+						statement.type === "ExportAllDeclaration"
+				);
 			if (isHarmony) {
 				const module = parser.state.module;
 				const compatDep = new HarmonyCompatibilityDependency(module);

package/lib/optimize/ConcatenatedModule.js

@@ -1096,7 +1096,7 @@ class ConcatenatedModule extends Module {
 
 		// add harmony compatibility flag (must be first because of possible circular dependencies)
 		const usedExports = this.rootModule.usedExports;
-		if (usedExports === true) {
+		if (usedExports === true || usedExports === null) {
 			result.add(
 				runtimeTemplate.defineEsModuleFlagStatement({
 					exportsArgument: this.exportsArgument

package/lib/optimize/SideEffectsFlagPlugin.js

@@ -123,7 +123,7 @@ class SideEffectsFlagPlugin {
 										dep,
 										reason.explanation
 											? reason.explanation +
-											  " (skipped side-effect-free modules)"
+													" (skipped side-effect-free modules)"
 											: "(skipped side-effect-free modules)"
 									);
 									// removing the currect reason, by not adding it to the newReasons array

package/lib/optimize/SplitChunksPlugin.js

@@ -534,8 +534,8 @@ module.exports = class SplitChunksPlugin {
 									cacheGroupSource.minSize !== undefined
 										? cacheGroupSource.minSize
 										: cacheGroupSource.enforce
-											? 0
-											: this.options.minSize,
+										? 0
+										: this.options.minSize,
 								minSizeForMaxSize:
 									cacheGroupSource.minSize !== undefined
 										? cacheGroupSource.minSize
@@ -544,26 +544,26 @@ module.exports = class SplitChunksPlugin {
 									cacheGroupSource.maxSize !== undefined
 										? cacheGroupSource.maxSize
 										: cacheGroupSource.enforce
-											? 0
-											: this.options.maxSize,
+										? 0
+										: this.options.maxSize,
 								minChunks:
 									cacheGroupSource.minChunks !== undefined
 										? cacheGroupSource.minChunks
 										: cacheGroupSource.enforce
-											? 1
-											: this.options.minChunks,
+										? 1
+										: this.options.minChunks,
 								maxAsyncRequests:
 									cacheGroupSource.maxAsyncRequests !== undefined
 										? cacheGroupSource.maxAsyncRequests
 										: cacheGroupSource.enforce
-											? Infinity
-											: this.options.maxAsyncRequests,
+										? Infinity
+										: this.options.maxAsyncRequests,
 								maxInitialRequests:
 									cacheGroupSource.maxInitialRequests !== undefined
 										? cacheGroupSource.maxInitialRequests
 										: cacheGroupSource.enforce
-											? Infinity
-											: this.options.maxInitialRequests,
+										? Infinity
+										: this.options.maxInitialRequests,
 								getName:
 									cacheGroupSource.getName !== undefined
 										? cacheGroupSource.getName
@@ -683,11 +683,11 @@ module.exports = class SplitChunksPlugin {
 								const maxRequests = chunk.isOnlyInitial()
 									? item.cacheGroup.maxInitialRequests
 									: chunk.canBeInitial()
-										? Math.min(
-												item.cacheGroup.maxInitialRequests,
-												item.cacheGroup.maxAsyncRequests
-										  )
-										: item.cacheGroup.maxAsyncRequests;
+									? Math.min(
+											item.cacheGroup.maxInitialRequests,
+											item.cacheGroup.maxAsyncRequests
+									  )
+									: item.cacheGroup.maxAsyncRequests;
 								return (
 									!isFinite(maxRequests) || getRequests(chunk) < maxRequests
 								);

package/lib/util/StackedSetMap.js

@@ -96,12 +96,10 @@ class StackedSetMap {
 
 	asPairArray() {
 		this._compress();
-		return Array.from(
-			this.map.entries(),
-			pair =>
-				/** @type {[TODO, TODO]} */ (pair[1] === UNDEFINED_MARKER
-					? [pair[0], undefined]
-					: pair)
+		return Array.from(this.map.entries(), pair =>
+			/** @type {[TODO, TODO]} */ (pair[1] === UNDEFINED_MARKER
+				? [pair[0], undefined]
+				: pair)
 		);
 	}
 

package/lib/util/deterministicGrouping.js

@@ -156,8 +156,8 @@ module.exports = ({ maxSize, minSize, items, getSize, getKey }) => {
 			// We hit an edgecase where the working set is already smaller than minSize
 			// We merge it with the smallest result node to keep minSize intact
 			if (result.length > 0) {
-				const smallestGroup = result.reduce(
-					(min, group) => (min.size > group.size ? group : min)
+				const smallestGroup = result.reduce((min, group) =>
+					min.size > group.size ? group : min
 				);
 				for (const node of initialGroup.nodes) smallestGroup.nodes.push(node);
 				smallestGroup.nodes.sort((a, b) => {

package/lib/util/identifier.js

@@ -36,11 +36,10 @@ const normalizePathSeparator = p => p.replace(/\\/g, "/");
 const _makePathsRelative = (context, identifier) => {
 	return identifier
 		.split(/([|! ])/)
-		.map(
-			str =>
-				looksLikeAbsolutePath(str)
-					? normalizePathSeparator(path.relative(context, str))
-					: str
+		.map(str =>
+			looksLikeAbsolutePath(str)
+				? normalizePathSeparator(path.relative(context, str))
+				: str
 		)
 		.join("");
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "webpack",
-  "version": "4.28.3",
+  "version": "4.29.2",
   "author": "Tobias Koppers @sokra",
   "description": "Packs CommonJs/AMD modules for the browser. Allows to split your codebase into multiple bundles, which can be loaded on demand. Support loaders to preprocess files, i.e. json, jsx, es7, css, less, ... and your custom stuff.",
   "license": "MIT",
@@ -9,8 +9,8 @@
     "@webassemblyjs/helper-module-context": "1.7.11",
     "@webassemblyjs/wasm-edit": "1.7.11",
     "@webassemblyjs/wasm-parser": "1.7.11",
-    "acorn": "^5.6.2",
-    "acorn-dynamic-import": "^3.0.0",
+    "acorn": "^6.0.5",
+    "acorn-dynamic-import": "^4.0.0",
     "ajv": "^6.1.0",
     "ajv-keywords": "^3.1.0",
     "chrome-trace-event": "^1.0.0",
@@ -24,62 +24,61 @@
     "mkdirp": "~0.5.0",
     "neo-async": "^2.5.0",
     "node-libs-browser": "^2.0.0",
-    "schema-utils": "^0.4.4",
+    "schema-utils": "^1.0.0",
     "tapable": "^1.1.0",
     "terser-webpack-plugin": "^1.1.0",
     "watchpack": "^1.5.0",
     "webpack-sources": "^1.3.0"
   },
   "devDependencies": {
-    "@types/node": "^9.6.4",
+    "@types/node": "^10.12.21",
     "@types/tapable": "^1.0.1",
     "@types/webpack-sources": "^0.1.4",
     "benchmark": "^2.1.1",
     "bundle-loader": "~0.5.0",
-    "codacy-coverage": "^2.0.1",
     "coffee-loader": "^0.9.0",
-    "coffeescript": "^1.10.0",
+    "coffeescript": "^2.3.2",
     "coveralls": "^3.0.2",
-    "css-loader": "^0.28.3",
+    "css-loader": "^2.1.0",
     "es6-promise-polyfill": "^1.1.1",
     "eslint": "^5.8.0",
-    "eslint-config-prettier": "^3.1.0",
-    "eslint-plugin-jest": "^21.26.2",
+    "eslint-config-prettier": "^4.0.0",
+    "eslint-plugin-jest": "^22.2.2",
     "eslint-plugin-node": "^8.0.0",
     "eslint-plugin-prettier": "^3.0.0",
-    "express": "~4.13.1",
-    "file-loader": "^1.1.6",
+    "express": "~4.16.4",
+    "file-loader": "^3.0.1",
     "glob": "^7.1.3",
     "husky": "^1.1.3",
     "i18n-webpack-plugin": "^1.0.0",
     "istanbul": "^0.4.5",
     "jade": "^1.11.0",
     "jade-loader": "~0.8.0",
-    "jest": "24.0.0-alpha.1",
-    "jest-junit": "^5.2.0",
+    "jest": "24.1.0",
+    "jest-junit": "^6.2.1",
     "json-loader": "^0.5.7",
     "json-schema-to-typescript": "^6.0.1",
-    "less": "^2.5.1",
+    "less": "^3.9.0",
     "less-loader": "^4.0.3",
     "lint-staged": "^8.0.4",
     "lodash": "^4.17.4",
     "prettier": "^1.14.3",
     "pug": "^2.0.3",
     "pug-loader": "^2.4.0",
-    "raw-loader": "~0.5.0",
-    "react": "^15.2.1",
-    "react-dom": "^15.2.1",
+    "raw-loader": "^1.0.0",
+    "react": "^16.8.0",
+    "react-dom": "^16.8.0",
     "rimraf": "^2.6.2",
     "script-loader": "~0.7.0",
     "simple-git": "^1.65.0",
-    "style-loader": "^0.19.1",
+    "style-loader": "^0.23.1",
     "typescript": "^3.0.0-rc",
-    "url-loader": "^0.6.2",
+    "url-loader": "^1.1.2",
     "val-loader": "^1.0.2",
-    "vm-browserify": "~0.0.0",
+    "vm-browserify": "~1.1.0",
     "wast-loader": "^1.5.5",
-    "webpack-dev-middleware": "^1.9.0",
-    "worker-loader": "^1.1.1",
+    "webpack-dev-middleware": "^3.5.1",
+    "worker-loader": "^2.0.0",
     "xxhashjs": "^0.2.1"
   },
   "engines": {
@@ -108,7 +107,7 @@
     "test": "node --max-old-space-size=4096 --trace-deprecation node_modules/jest-cli/bin/jest",
     "test:update-snapshots": "yarn jest -u",
     "test:integration": "node --max-old-space-size=4096 --trace-deprecation node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/test/*.test.js\"",
-    "test:basic": "node --max-old-space-size=4096 --trace-deprecation node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/test/{TestCasesNormal,StatsTestCases,ConfigTestCases}.test.js\"",
+    "test:basic": "node --max-old-space-size=4096 --trace-deprecation node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/te{st/TestCasesNormal,st/StatsTestCases,st/ConfigTestCases}.test.js\"",
     "test:unit": "node --max-old-space-size=4096 --trace-deprecation node_modules/jest-cli/bin/jest --testMatch \"<rootDir>/test/*.unittest.js\"",
     "travis:integration": "yarn cover:init && yarn cover:integration --ci $JEST",
     "travis:basic": "yarn test:basic --ci $JEST",

package/schemas/WebpackOptions.json

@@ -867,6 +867,10 @@
             }
           ]
         },
+        "futureEmitAssets": {
+          "description": "Use the future version of asset emitting logic, which is allows freeing memory of assets after emitting. It could break plugins which assume that assets are still readable after emitting. Will be the new default in the next major version.",
+          "type": "boolean"
+        },
         "globalObject": {
           "description": "An expression which is used to address the global object/scope in runtime code",
           "type": "string",