webpack 4.28.0 → 4.28.4

package/lib/Compiler.js

@@ -207,6 +207,10 @@ class Compiler extends Tapable {
 		const finalCallback = (err, stats) => {
 			this.running = false;
 
+			if (err) {
+				this.hooks.failed.call(err);
+			}
+
 			if (callback !== undefined) return callback(err, stats);
 		};
 

package/lib/IgnorePlugin.js

@@ -38,12 +38,15 @@ class IgnorePlugin {
 	 * @returns {TODO|null} returns result or null if result should be ignored
 	 */
 	checkIgnore(result) {
+		if (!result) return result;
+
 		if (
 			"checkResource" in this.options &&
+			this.options.checkResource &&
 			this.options.checkResource(result.request, result.context)
 		) {
 			// TODO webpack 5 remove checkContext, as checkResource already gets context
-			if ("checkContext" in this.options) {
+			if ("checkContext" in this.options && this.options.checkContext) {
 				if (this.options.checkContext(result.context)) {
 					return null;
 				}
@@ -54,9 +57,10 @@ class IgnorePlugin {
 
 		if (
 			"resourceRegExp" in this.options &&
+			this.options.resourceRegExp &&
 			this.options.resourceRegExp.test(result.request)
 		) {
-			if ("contextRegExp" in this.options) {
+			if ("contextRegExp" in this.options && this.options.contextRegExp) {
 				// if "contextRegExp" is given,
 				// both the "resourceRegExp" and "contextRegExp" have to match.
 				if (this.options.contextRegExp.test(result.context)) {

package/lib/WebpackOptionsApply.js

@@ -463,7 +463,7 @@ class WebpackOptionsApply extends OptionsApply {
 		if (options.optimization.minimize) {
 			for (const minimizer of options.optimization.minimizer) {
 				if (typeof minimizer === "function") {
-					minimizer.apply(compiler);
+					minimizer.call(compiler, compiler);
 				} else {
 					minimizer.apply(compiler);
 				}

package/lib/debug/ProfilingPlugin.js

@@ -1,4 +1,6 @@
 const fs = require("fs");
+const path = require("path");
+const mkdirp = require("mkdirp");
 const { Tracer } = require("chrome-trace-event");
 const validateOptions = require("schema-utils");
 const schema = require("../../schemas/plugins/debug/ProfilingPlugin.json");
@@ -93,6 +95,10 @@ const createTrace = outputPath => {
 		noStream: true
 	});
 	const profiler = new Profiler(inspector);
+	if (/\/|\\/.test(outputPath)) {
+		const dirPath = path.dirname(outputPath);
+		mkdirp.sync(dirPath);
+	}
 	const fsStream = fs.createWriteStream(outputPath);
 
 	let counter = 0;

package/lib/dependencies/AMDRequireDependenciesBlock.js

@@ -36,8 +36,12 @@ module.exports = class AMDRequireDependenciesBlock extends AsyncDependenciesBloc
 		} else {
 			this.range = expr.range;
 		}
-		const dep = new AMDRequireDependency(this);
+		const dep = this.newRequireDependency();
 		dep.loc = loc;
 		this.addDependency(dep);
 	}
+
+	newRequireDependency() {
+		return new AMDRequireDependency(this);
+	}
 };

package/lib/dependencies/HarmonyDetectionParserPlugin.js

@@ -13,9 +13,13 @@ module.exports = class HarmonyDetectionParserPlugin {
 			const isStrictHarmony = parser.state.module.type === "javascript/esm";
 			const isHarmony =
 				isStrictHarmony ||
-				ast.body.some(statement => {
-					return /^(Import|Export).*Declaration$/.test(statement.type);
-				});
+				ast.body.some(
+					statement =>
+						statement.type === "ImportDeclaration" ||
+						statement.type === "ExportDefaultDeclaration" ||
+						statement.type === "ExportNamedDeclaration" ||
+						statement.type === "ExportAllDeclaration"
+				);
 			if (isHarmony) {
 				const module = parser.state.module;
 				const compatDep = new HarmonyCompatibilityDependency(module);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "webpack",
-  "version": "4.28.0",
+  "version": "4.28.4",
   "author": "Tobias Koppers @sokra",
   "description": "Packs CommonJs/AMD modules for the browser. Allows to split your codebase into multiple bundles, which can be loaded on demand. Support loaders to preprocess files, i.e. json, jsx, es7, css, less, ... and your custom stuff.",
   "license": "MIT",