webpack 4.13.0 → 4.16.0

package/bin/webpack.js

@@ -159,8 +159,13 @@ if (installedClis.length === 0) {
 } else if (installedClis.length === 1) {
 	const path = require("path");
 	const pkgPath = require.resolve(`${installedClis[0].package}/package.json`);
-	const pkg = require(pkgPath); // eslint-disable-line
-	require(path.resolve(path.dirname(pkgPath), pkg.bin[installedClis[0].binName])); // eslint-disable-line
+	// eslint-disable-next-line node/no-missing-require
+	const pkg = require(pkgPath);
+	// eslint-disable-next-line node/no-missing-require
+	require(path.resolve(
+		path.dirname(pkgPath),
+		pkg.bin[installedClis[0].binName]
+	));
 } else {
 	console.warn(
 		`You have installed ${installedClis

package/hot/dev-server.js

@@ -40,10 +40,10 @@ if (module.hot) {
 						"warning",
 						"[HMR] Cannot apply update. Need to do a full reload!"
 					);
-					log("warning", "[HMR] " + err.stack || err.message);
+					log("warning", "[HMR] " + (err.stack || err.message));
 					window.location.reload();
 				} else {
-					log("warning", "[HMR] Update failed: " + err.stack || err.message);
+					log("warning", "[HMR] Update failed: " + (err.stack || err.message));
 				}
 			});
 	};

package/hot/only-dev-server.js

@@ -72,11 +72,11 @@ if (module.hot) {
 						"warning",
 						"[HMR] Cannot check for update. Need to do a full reload!"
 					);
-					log("warning", "[HMR] " + err.stack || err.message);
+					log("warning", "[HMR] " + (err.stack || err.message));
 				} else {
 					log(
 						"warning",
-						"[HMR] Update check failed: " + err.stack || err.message
+						"[HMR] Update check failed: " + (err.stack || err.message)
 					);
 				}
 			});

package/hot/poll.js

@@ -23,10 +23,13 @@ if (module.hot) {
 					var status = module.hot.status();
 					if (["abort", "fail"].indexOf(status) >= 0) {
 						log("warning", "[HMR] Cannot apply update.");
-						log("warning", "[HMR] " + err.stack || err.message);
+						log("warning", "[HMR] " + (err.stack || err.message));
 						log("warning", "[HMR] You need to restart the application!");
 					} else {
-						log("warning", "[HMR] Update failed: " + err.stack || err.message);
+						log(
+							"warning",
+							"[HMR] Update failed: " + (err.stack || err.message)
+						);
 					}
 				});
 		}

package/hot/signal.js

@@ -37,10 +37,10 @@ if (module.hot) {
 				var status = module.hot.status();
 				if (["abort", "fail"].indexOf(status) >= 0) {
 					log("warning", "[HMR] Cannot apply update.");
-					log("warning", "[HMR] " + err.stack || err.message);
+					log("warning", "[HMR] " + (err.stack || err.message));
 					log("warning", "[HMR] You need to restart the application!");
 				} else {
-					log("warning", "[HMR] Update failed: " + err.stack || err.message);
+					log("warning", "[HMR] Update failed: " + (err.stack || err.message));
 				}
 			});
 	};

package/lib/AsyncDependenciesBlock.js

@@ -3,9 +3,22 @@
 	Author Tobias Koppers @sokra
 */
 "use strict";
+
 const DependenciesBlock = require("./DependenciesBlock");
 
+/** @typedef {import("./ChunkGroup")} ChunkGroup */
+/** @typedef {import("./Module")} Module */
+/** @typedef {import("./Dependency").DependencyLocation} DependencyLocation */
+/** @typedef {import("./util/createHash").Hash} Hash */
+/** @typedef {TODO} GroupOptions */
+
 module.exports = class AsyncDependenciesBlock extends DependenciesBlock {
+	/**
+	 * @param {GroupOptions} groupOptions options for the group
+	 * @param {Module} module the Module object
+	 * @param {DependencyLocation=} loc the line of code
+	 * @param {TODO=} request the request
+	 */
 	constructor(groupOptions, module, loc, request) {
 		super();
 		if (typeof groupOptions === "string") {
@@ -14,28 +27,50 @@ module.exports = class AsyncDependenciesBlock extends DependenciesBlock {
 			groupOptions = { name: undefined };
 		}
 		this.groupOptions = groupOptions;
+		/** @type {ChunkGroup=} */
 		this.chunkGroup = undefined;
 		this.module = module;
 		this.loc = loc;
 		this.request = request;
+		/** @type {DependenciesBlock} */
+		this.parent = undefined;
 	}
 
+	/**
+	 * @returns {string} The name of the chunk
+	 */
 	get chunkName() {
 		return this.groupOptions.name;
 	}
 
+	/**
+	 * @param {string} value The new chunk name
+	 * @returns {void}
+	 */
 	set chunkName(value) {
 		this.groupOptions.name = value;
 	}
 
+	/**
+	 * @returns {never} this throws and should never be called
+	 */
 	get chunks() {
 		throw new Error("Moved to AsyncDependenciesBlock.chunkGroup");
 	}
 
+	/**
+	 * @param {never} value setter value
+	 * @returns {never} this is going to throw therefore we should throw type
+	 * assertions by returning never
+	 */
 	set chunks(value) {
 		throw new Error("Moved to AsyncDependenciesBlock.chunkGroup");
 	}
 
+	/**
+	 * @param {Hash} hash the hash used to track block changes, from "crypto" module
+	 * @returns {void}
+	 */
 	updateHash(hash) {
 		hash.update(JSON.stringify(this.groupOptions));
 		hash.update(
@@ -50,16 +85,25 @@ module.exports = class AsyncDependenciesBlock extends DependenciesBlock {
 		super.updateHash(hash);
 	}
 
+	/**
+	 * @returns {void}
+	 */
 	disconnect() {
 		this.chunkGroup = undefined;
 		super.disconnect();
 	}
 
+	/**
+	 * @returns {void}
+	 */
 	unseal() {
 		this.chunkGroup = undefined;
 		super.unseal();
 	}
 
+	/**
+	 * @returns {void}
+	 */
 	sortItems() {
 		super.sortItems();
 	}

package/lib/AutomaticPrefetchPlugin.js

@@ -8,7 +8,7 @@ const asyncLib = require("neo-async");
 const PrefetchDependency = require("./dependencies/PrefetchDependency");
 const NormalModule = require("./NormalModule");
 
-/** @typedef {import("./Compiler.js")} Compiler */
+/** @typedef {import("./Compiler")} Compiler */
 
 class AutomaticPrefetchPlugin {
 	/**
@@ -30,7 +30,7 @@ class AutomaticPrefetchPlugin {
 		compiler.hooks.afterCompile.tap("AutomaticPrefetchPlugin", compilation => {
 			lastModules = compilation.modules
 				.filter(m => m instanceof NormalModule)
-				.map(m => ({
+				.map((/** @type {NormalModule} */ m) => ({
 					context: m.context,
 					request: m.request
 				}));

package/lib/Chunk.js

@@ -13,10 +13,11 @@ const ERR_CHUNK_ENTRY = "Chunk.entry was removed. Use hasRuntime()";
 const ERR_CHUNK_INITIAL =
 	"Chunk.initial was removed. Use canBeInitial/isOnlyInitial()";
 
-/** @typedef {import("./Module.js")} Module */
+/** @typedef {import("./Module")} Module */
 /** @typedef {import("./ChunkGroup")} ChunkGroup */
-/** @typedef {import("./ModuleReason.js")} ModuleReason */
+/** @typedef {import("./ModuleReason")} ModuleReason */
 /** @typedef {import("webpack-sources").Source} Source */
+/** @typedef {import("./util/createHash").Hash} Hash */
 
 /**
  *  @typedef {Object} WithId an object who has an id property *
@@ -29,6 +30,12 @@ const ERR_CHUNK_INITIAL =
  * @param {Module} b module
  * @returns {-1|0|1} sort value
  */
+
+// TODO use @callback
+/** @typedef {(a: Module, b: Module) => -1|0|1} ModuleSortPredicate */
+/** @typedef {(m: Module) => boolean} ModuleFilterPredicate */
+/** @typedef {(c: Chunk) => boolean} ChunkFilterPredicate */
+
 const sortModuleById = (a, b) => {
 	if (a.id < b.id) return -1;
 	if (b.id < a.id) return 1;
@@ -114,9 +121,14 @@ class Chunk {
 		this.entryModule = undefined;
 		/** @private @type {SortableSet<Module>} */
 		this._modules = new SortableSet(undefined, sortByIdentifier);
+		/** @type {string?} */
+		this.filenameTemplate = undefined;
+
+		/** @private */
+		this._groups = new SortableSet(undefined, sortChunkGroupById);
 		/** @private @type {SortableSet<ChunkGroup>} */
 		this._groups = new SortableSet(undefined, sortChunkGroupById);
-		/** @type {Source[]} */
+		/** @type {string[]} */
 		this.files = [];
 		/** @type {boolean} */
 		this.rendered = false;
@@ -288,7 +300,7 @@ class Chunk {
 	}
 
 	/**
-	 * @returns {SortableSet} the chunkGroups that said chunk is referenced in
+	 * @returns {SortableSet<ChunkGroup>} the chunkGroups that said chunk is referenced in
 	 */
 	get groupsIterable() {
 		return this._groups;
@@ -305,7 +317,7 @@ class Chunk {
 		if (this._modules.size < otherChunk._modules.size) return 1;
 		const a = this._modules[Symbol.iterator]();
 		const b = otherChunk._modules[Symbol.iterator]();
-		// eslint-disable-next-line
+		// eslint-disable-next-line no-constant-condition
 		while (true) {
 			const aItem = a.next();
 			const bItem = b.next();
@@ -482,6 +494,11 @@ class Chunk {
 		return this.addMultiplierAndOverhead(this.modulesSize(), options);
 	}
 
+	/**
+	 * @param {Chunk} otherChunk the other chunk
+	 * @param {TODO} options the options for this function
+	 * @returns {number | false} the size, or false if it can't be integrated
+	 */
 	integratedSize(otherChunk, options) {
 		// Chunk if it's possible to integrate this chunk
 		if (!this.canBeIntegrated(otherChunk)) {
@@ -511,6 +528,9 @@ class Chunk {
 		this.sortModules();
 	}
 
+	/**
+	 * @returns {Set<Chunk>} a set of all the async chunks
+	 */
 	getAllAsyncChunks() {
 		const queue = new Set();
 		const chunks = new Set();
@@ -539,9 +559,23 @@ class Chunk {
 		return chunks;
 	}
 
+	/**
+	 * @typedef {Object} ChunkMaps
+	 * @property {Record<string|number, string>} hash
+	 * @property {Record<string|number, Record<string, string>>} contentHash
+	 * @property {Record<string|number, string>} name
+	 */
+
+	/**
+	 * @param {boolean} realHash should the full hash or the rendered hash be used
+	 * @returns {ChunkMaps} the chunk map information
+	 */
 	getChunkMaps(realHash) {
+		/** @type {Record<string|number, string>} */
 		const chunkHashMap = Object.create(null);
+		/** @type {Record<string|number, Record<string, string>>} */
 		const chunkContentHashMap = Object.create(null);
+		/** @type {Record<string|number, string>} */
 		const chunkNameMap = Object.create(null);
 
 		for (const chunk of this.getAllAsyncChunks()) {
@@ -564,6 +598,9 @@ class Chunk {
 		};
 	}
 
+	/**
+	 * @returns {Record<string, Set<TODO>[]>} a record object of names to lists of child ids(?)
+	 */
 	getChildIdsByOrders() {
 		const lists = new Map();
 		for (const group of this.groupsIterable) {
@@ -591,7 +628,7 @@ class Chunk {
 			list.sort((a, b) => {
 				const cmp = b.order - a.order;
 				if (cmp !== 0) return cmp;
-				// TOOD webpack 5 remove this check of compareTo
+				// TODO webpack 5 remove this check of compareTo
 				if (a.group.compareTo) {
 					return a.group.compareTo(b.group);
 				}
@@ -634,11 +671,24 @@ class Chunk {
 		return chunkMaps;
 	}
 
+	/**
+	 * @typedef {Object} ChunkModuleMaps
+	 * @property {Record<string|number, (string|number)[]>} id
+	 * @property {Record<string|number, string>} hash
+	 */
+
+	/**
+	 * @param {ModuleFilterPredicate} filterFn function used to filter modules
+	 * @returns {ChunkModuleMaps} module map information
+	 */
 	getChunkModuleMaps(filterFn) {
+		/** @type {Record<string|number, (string|number)[]>} */
 		const chunkModuleIdMap = Object.create(null);
+		/** @type {Record<string|number, string>} */
 		const chunkModuleHashMap = Object.create(null);
 
 		for (const chunk of this.getAllAsyncChunks()) {
+			/** @type {(string|number)[]} */
 			let array;
 			for (const module of chunk.modulesIterable) {
 				if (filterFn(module)) {

package/lib/ChunkGroup.js

@@ -407,7 +407,7 @@ class ChunkGroup {
 		if (this.chunks.length < otherGroup.chunks.length) return 1;
 		const a = this.chunks[Symbol.iterator]();
 		const b = otherGroup.chunks[Symbol.iterator]();
-		// eslint-disable-next-line
+		// eslint-disable-next-line no-constant-condition
 		while (true) {
 			const aItem = a.next();
 			const bItem = b.next();
@@ -442,7 +442,7 @@ class ChunkGroup {
 			list.sort((a, b) => {
 				const cmp = b.order - a.order;
 				if (cmp !== 0) return cmp;
-				// TOOD webpack 5 remove this check of compareTo
+				// TODO webpack 5 remove this check of compareTo
 				if (a.group.compareTo) {
 					return a.group.compareTo(b.group);
 				}

package/lib/ChunkTemplate.js

@@ -9,12 +9,12 @@ const { Tapable, SyncWaterfallHook, SyncHook } = require("tapable");
 /** @typedef {import("./ModuleTemplate")} ModuleTemplate */
 /** @typedef {import("./Chunk")} Chunk */
 /** @typedef {import("./Module")} Module} */
-/** @typedef {import("crypto").Hash} Hash */
+/** @typedef {import("./util/createHash").Hash} Hash} */
 
 /**
  * @typedef {Object} RenderManifestOptions
  * @property {Chunk} chunk the chunk used to render
- * @property {Hash} hash
+ * @property {string} hash
  * @property {string} fullHash
  * @property {TODO} outputOptions
  * @property {{javascript: ModuleTemplate, webassembly: ModuleTemplate}} moduleTemplates
@@ -26,6 +26,7 @@ module.exports = class ChunkTemplate extends Tapable {
 		super();
 		this.outputOptions = outputOptions || {};
 		this.hooks = {
+			/** @type {SyncWaterfallHook<TODO[], RenderManifestOptions>} */
 			renderManifest: new SyncWaterfallHook(["result", "options"]),
 			modules: new SyncWaterfallHook([
 				"source",
@@ -58,12 +59,23 @@ module.exports = class ChunkTemplate extends Tapable {
 		return result;
 	}
 
+	/**
+	 * Updates hash with information from this template
+	 * @param {Hash} hash the hash to update
+	 * @returns {void}
+	 */
 	updateHash(hash) {
 		hash.update("ChunkTemplate");
 		hash.update("2");
 		this.hooks.hash.call(hash);
 	}
 
+	/**
+	 * Updates hash with chunk-specific information from this template
+	 * @param {Hash} hash the hash to update
+	 * @param {Chunk} chunk the chunk
+	 * @returns {void}
+	 */
 	updateHashForChunk(hash, chunk) {
 		this.updateHash(hash);
 		this.hooks.hashForChunk.call(hash, chunk);

package/lib/CommentCompilationWarning.js

@@ -6,16 +6,16 @@
 
 const WebpackError = require("./WebpackError");
 
-/** @typedef {import("./Module.js")} Module */
+/** @typedef {import("./Module")} Module */
 
-/** @typedef {import("./Dependency.js").Loc} Loc */
+/** @typedef {import("./Dependency").DependencyLocation} DependencyLocation */
 
 class CommentCompilationWarning extends WebpackError {
 	/**
 	 *
 	 * @param {string} message warning message
 	 * @param {Module} module affected module
-	 * @param {Loc} loc affected lines of code
+	 * @param {DependencyLocation} loc affected lines of code
 	 */
 	constructor(message, module, loc) {
 		super(message);

package/lib/CompatibilityPlugin.js

@@ -8,7 +8,7 @@ const ConstDependency = require("./dependencies/ConstDependency");
 
 const NullFactory = require("./NullFactory");
 
-/** @typedef {import("./Compiler.js")} Compiler */
+/** @typedef {import("./Compiler")} Compiler */
 
 class CompatibilityPlugin {
 	/**