webpack-dev-server 5.2.1 → 5.2.2

package/client/index.js

@@ -164,7 +164,7 @@ if (parsedResourceQuery.overlay) {
     }, options.overlay);
     decodeOverlayOptions(options.overlay);
   }
-  enabledFeatures.Overlay = true;
+  enabledFeatures.Overlay = options.overlay !== false;
 }
 if (parsedResourceQuery.logging) {
   options.logging = parsedResourceQuery.logging;

package/client/modules/logger/index.js

@@ -143,8 +143,8 @@ var TIMERS_SYMBOL = (typeof Symbol !== "undefined" ? Symbol : function (i) { ret
 var TIMERS_AGGREGATES_SYMBOL = (typeof Symbol !== "undefined" ? Symbol : function (i) { return i; })("webpack logger aggregated times");
 var WebpackLogger = /*#__PURE__*/function () {
   /**
-   * @param {function(LogTypeEnum, EXPECTED_ANY[]=): void} log log function
-   * @param {function(string | function(): string): WebpackLogger} getChildLogger function to create child logger
+   * @param {(type: LogTypeEnum, args?: EXPECTED_ANY[]) => void} log log function
+   * @param {(name: string | (() => string)) => WebpackLogger} getChildLogger function to create child logger
    */
   function WebpackLogger(log, getChildLogger) {
     _classCallCheck(this, WebpackLogger);
@@ -472,13 +472,13 @@ var _require = __webpack_require__(/*! ./Logger */ "./node_modules/webpack/lib/l
 /** @typedef {import("../../declarations/WebpackOptions").FilterTypes} FilterTypes */
 /** @typedef {import("./Logger").LogTypeEnum} LogTypeEnum */
 
-/** @typedef {function(string): boolean} FilterFunction */
-/** @typedef {function(string, LogTypeEnum, EXPECTED_ANY[]=): void} LoggingFunction */
+/** @typedef {(item: string) => boolean} FilterFunction */
+/** @typedef {(value: string, type: LogTypeEnum, args?: EXPECTED_ANY[]) => void} LoggingFunction */
 
 /**
  * @typedef {object} LoggerConsole
- * @property {function(): void} clear
- * @property {function(): void} trace
+ * @property {() => void} clear
+ * @property {() => void} trace
  * @property {(...args: EXPECTED_ANY[]) => void} info
  * @property {(...args: EXPECTED_ANY[]) => void} log
  * @property {(...args: EXPECTED_ANY[]) => void} warn
@@ -555,7 +555,6 @@ module.exports = function (_ref) {
   typeof debug === "boolean" ? [function () {
     return debug;
   }] : /** @type {FilterItemTypes[]} */[].concat(debug).map(filterToFunction);
-  /** @type {number} */
   var loglevel = LogLevel["".concat(level)] || 0;
 
   /**

package/client/overlay.js

@@ -598,8 +598,9 @@ var createOverlay = function createOverlay(options) {
       if (!error && !message) {
         return;
       }
+
       // if error stack indicates a React error boundary caught the error, do not show overlay.
-      if (error.stack && error.stack.includes("invokeGuardedCallbackDev")) {
+      if (error && error.stack && error.stack.includes("invokeGuardedCallbackDev")) {
         return;
       }
       handleError(error, message);

package/lib/Server.js

@@ -1986,6 +1986,13 @@ class Server {
         const headers =
           /** @type {{ [key: string]: string | undefined }} */
           (req.headers);
+        const headerName = headers[":authority"] ? ":authority" : "host";
+
+        if (this.isValidHost(headers, headerName, false)) {
+          next();
+          return;
+        }
+
         if (
           headers["sec-fetch-mode"] === "no-cors" &&
           headers["sec-fetch-site"] === "cross-site"
@@ -3088,8 +3095,6 @@ class Server {
        */
       const allHeaders = [];
 
-      allHeaders.push({ key: "X_TEST", value: "TEST" });
-
       if (!Array.isArray(headers)) {
         // eslint-disable-next-line guard-for-in
         for (const name in headers) {
@@ -3125,17 +3130,14 @@ class Server {
     // always allow localhost host, for convenience
     // allow if value is in allowedHosts
     if (Array.isArray(allowedHosts) && allowedHosts.length > 0) {
-      for (let hostIdx = 0; hostIdx < allowedHosts.length; hostIdx++) {
-        /** @type {string} */
-        const allowedHost = allowedHosts[hostIdx];
-
+      for (const allowedHost of allowedHosts) {
         if (allowedHost === value) {
           return true;
         }
 
         // support "." as a subdomain wildcard
         // e.g. ".example.com" will allow "example.com", "www.example.com", "subdomain.example.com", etc
-        if (allowedHost[0] === ".") {
+        if (allowedHost.startsWith(".")) {
           // "example.com"  (value === allowedHost.substring(1))
           // "*.example.com"  (value.endsWith(allowedHost))
           if (
@@ -3171,9 +3173,10 @@ class Server {
    * @private
    * @param {{ [key: string]: string | undefined }} headers
    * @param {string} headerToCheck
+   * @param {boolean} validateHost
    * @returns {boolean}
    */
-  isValidHost(headers, headerToCheck) {
+  isValidHost(headers, headerToCheck, validateHost = true) {
     if (this.options.allowedHosts === "all") {
       return true;
     }
@@ -3215,19 +3218,15 @@ class Server {
     // For convenience, always allow localhost (hostname === 'localhost')
     // and its subdomains (hostname.endsWith(".localhost")).
     // allow hostname of listening address  (hostname === this.options.host)
-    const isValidHostname =
-      ipaddr.IPv4.isValid(hostname) ||
-      ipaddr.IPv6.isValid(hostname) ||
-      hostname === "localhost" ||
-      hostname.endsWith(".localhost") ||
-      hostname === this.options.host;
-
-    if (isValidHostname) {
-      return true;
-    }
-
-    // disallow
-    return false;
+    const isValidHostname = validateHost
+      ? ipaddr.IPv4.isValid(hostname) ||
+        ipaddr.IPv6.isValid(hostname) ||
+        hostname === "localhost" ||
+        hostname.endsWith(".localhost") ||
+        hostname === this.options.host
+      : false;
+
+    return isValidHostname;
   }
 
   /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "webpack-dev-server",
-  "version": "5.2.1",
+  "version": "5.2.2",
   "description": "Serves a webpack app. Updates the browser on changes.",
   "bin": "bin/webpack-dev-server.js",
   "main": "lib/Server.js",
@@ -62,7 +62,7 @@
     "connect-history-api-fallback": "^2.0.0",
     "express": "^4.21.2",
     "graceful-fs": "^4.2.6",
-    "http-proxy-middleware": "^2.0.7",
+    "http-proxy-middleware": "^2.0.9",
     "ipaddr.js": "^2.1.0",
     "launch-editor": "^2.6.1",
     "open": "^10.0.3",
@@ -93,7 +93,7 @@
     "@types/trusted-types": "^2.0.2",
     "acorn": "^8.14.0",
     "babel-jest": "^29.5.0",
-    "babel-loader": "^9.2.1",
+    "babel-loader": "^10.0.0",
     "body-parser": "^1.19.2",
     "connect": "^3.7.0",
     "core-js": "^3.38.1",
@@ -118,7 +118,7 @@
     "memfs": "^4.14.0",
     "npm-run-all": "^4.1.5",
     "prettier": "^3.2.4",
-    "puppeteer": "^23.6.1",
+    "puppeteer": "^24.10.0",
     "readable-stream": "^4.5.2",
     "require-from-string": "^2.0.2",
     "rimraf": "^5.0.5",

package/types/lib/Server.d.ts

@@ -1357,6 +1357,7 @@ declare class Server<
    * @private
    * @param {{ [key: string]: string | undefined }} headers
    * @param {string} headerToCheck
+   * @param {boolean} validateHost
    * @returns {boolean}
    */
   private isValidHost;