webpack-dev-server 3.7.0 → 3.7.1

package/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [3.7.1](https://github.com/webpack/webpack-dev-server/compare/v3.7.0...v3.7.1) (2019-06-07)
+
+
+### Bug Fixes
+
+* retry finding port when port is null and get ports in sequence ([#1993](https://github.com/webpack/webpack-dev-server/issues/1993)) ([bc57514](https://github.com/webpack/webpack-dev-server/commit/bc57514))
+
+
+
 ## [3.7.0](https://github.com/webpack/webpack-dev-server/compare/v3.5.1...v3.7.0) (2019-06-06)
 
 

package/lib/utils/createLogger.js

@@ -2,7 +2,7 @@
 
 const log = require('webpack-log');
 
-function createLogger(options) {
+function createLogger(options = {}) {
   let level = options.logLevel || 'info';
 
   if (options.noInfo === true) {

package/lib/utils/findPort.js

@@ -1,12 +1,26 @@
 'use strict';
 
-const { getPortPromise } = require('portfinder');
+const pRetry = require('p-retry');
+const portfinder = require('portfinder');
 const defaultPort = require('./defaultPort');
 const defaultTo = require('./defaultTo');
 const tryParseInt = require('./tryParseInt');
 
+function runPortFinder() {
+  return new Promise((resolve, reject) => {
+    portfinder.basePort = defaultPort;
+    portfinder.getPort((error, port) => {
+      if (error) {
+        return reject(error);
+      }
+
+      return resolve(port);
+    });
+  });
+}
+
 function findPort(port) {
-  if (typeof port !== 'undefined') {
+  if (port) {
     return Promise.resolve(port);
   }
 
@@ -19,10 +33,7 @@ function findPort(port) {
     3
   );
 
-  return getPortPromise({
-    port: defaultPort,
-    stopPort: defaultPort + defaultPortRetry,
-  });
+  return pRetry(runPortFinder, { retries: defaultPortRetry });
 }
 
 module.exports = findPort;

package/lib/utils/runOpen.js

@@ -11,7 +11,7 @@ function runOpen(uri, options, log) {
     openMessage += `: ${options.open}`;
   }
 
-  open(`${uri}${options.openPage || ''}`, openOptions).catch(() => {
+  return open(`${uri}${options.openPage || ''}`, openOptions).catch(() => {
     log.warn(
       `${openMessage}. If you are running in a headless environment, please do not use the --open flag`
     );

package/lib/utils/tryParseInt.js

@@ -2,9 +2,11 @@
 
 function tryParseInt(input) {
   const output = parseInt(input, 10);
+
   if (Number.isNaN(output)) {
     return null;
   }
+
   return output;
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "webpack-dev-server",
-  "version": "3.7.0",
+  "version": "3.7.1",
   "description": "Serves a webpack app. Updates the browser on changes.",
   "bin": "bin/webpack-dev-server.js",
   "main": "lib/Server.js",
@@ -24,12 +24,13 @@
     "test:watch": "npm run test:coverage --watch",
     "test": "npm run test:coverage",
     "pretest": "npm run lint",
-    "prepare": "rimraf ./ssl/*.pem && npm run -s transpile:index && npm run transpile:clients && npm run -s build:live && npm run -s build:index && npm run -s build:sockjs",
-    "transpile:index": "babel client-src/default --out-dir client --ignore \"./client-src/default/*.config.js\"",
-    "transpile:clients": "babel client-src/clients --out-dir client/clients",
-    "build:index": "webpack ./client-src/default/index.js -o client/index.bundle.js --color --config client-src/default/webpack.config.js",
-    "build:live": "webpack ./client-src/live/index.js -o client/live.bundle.js --color --config client-src/live/webpack.config.js",
-    "build:sockjs": "webpack ./client-src/sockjs/index.js -o client/sockjs.bundle.js --color --config client-src/sockjs/webpack.config.js",
+    "prepare": "rimraf ./ssl/*.pem && npm run build:client",
+    "build:client:default": "babel client-src/default --out-dir client --ignore \"./client-src/default/*.config.js\"",
+    "build:client:clients": "babel client-src/clients --out-dir client/clients",
+    "build:client:index": "webpack ./client-src/default/index.js -o client/index.bundle.js --color --config client-src/default/webpack.config.js",
+    "build:client:live": "webpack ./client-src/live/index.js -o client/live.bundle.js --color --config client-src/live/webpack.config.js",
+    "build:client:sockjs": "webpack ./client-src/sockjs/index.js -o client/sockjs.bundle.js --color --config client-src/sockjs/webpack.config.js",
+    "build:client": "rimraf ./client/* && npm-run-all -s -l -p \"build:client:**\"",
     "webpack-dev-server": "cd $INIT_CWD && node ../../../bin/webpack-dev-server.js",
     "release": "standard-version"
   },
@@ -50,6 +51,7 @@
     "killable": "^1.0.1",
     "loglevel": "^1.6.2",
     "opn": "^5.5.0",
+    "p-retry": "^3.0.1",
     "portfinder": "^1.0.20",
     "schema-utils": "^1.0.0",
     "selfsigned": "^1.10.4",
@@ -94,7 +96,7 @@
     "marked": "^0.6.2",
     "memfs": "^2.15.4",
     "npm-run-all": "^4.1.5",
-    "prettier": "^1.17.1",
+    "prettier": "^1.18.0",
     "puppeteer": "^1.17.0",
     "rimraf": "^2.6.3",
     "standard-version": "^6.0.1",
@@ -102,7 +104,7 @@
     "supertest": "^4.0.2",
     "url-loader": "^1.1.2",
     "webpack": "^4.33.0",
-    "webpack-cli": "^3.3.2",
+    "webpack-cli": "^3.3.3",
     "ws": "^6.2.1"
   },
   "peerDependencies": {