webext-storage 1.3.2 → 2.0.1

package/distribution/storage-item-map.js

@@ -11,12 +11,14 @@ export class StorageItemMap {
     has = async (secondaryKey) => {
         const rawStorageKey = this.getRawStorageKey(secondaryKey);
         const result = await chromeP.storage[this.areaName].get(rawStorageKey);
-        return Object.hasOwn(result, rawStorageKey);
+        // Do not use Object.hasOwn() due to https://github.com/RickyMarou/jest-webextension-mock/issues/20
+        return result[rawStorageKey] !== undefined;
     };
     get = async (secondaryKey) => {
         const rawStorageKey = this.getRawStorageKey(secondaryKey);
         const result = await chromeP.storage[this.areaName].get(rawStorageKey);
-        if (!Object.hasOwn(result, rawStorageKey)) {
+        // Do not use Object.hasOwn() due to https://github.com/RickyMarou/jest-webextension-mock/issues/20
+        if (result[rawStorageKey] === undefined) {
             return this.defaultValue;
         }
         // eslint-disable-next-line @typescript-eslint/no-unsafe-return -- Assumes the user never uses the Storage API directly for this key
@@ -24,7 +26,13 @@ export class StorageItemMap {
     };
     set = async (secondaryKey, value) => {
         const rawStorageKey = this.getRawStorageKey(secondaryKey);
-        await chromeP.storage[this.areaName].set({ [rawStorageKey]: value });
+        // eslint-disable-next-line unicorn/prefer-ternary -- ur rong
+        if (value === undefined) {
+            await chromeP.storage[this.areaName].remove(rawStorageKey);
+        }
+        else {
+            await chromeP.storage[this.areaName].set({ [rawStorageKey]: value });
+        }
     };
     remove = async (secondaryKey) => {
         const rawStorageKey = this.getRawStorageKey(secondaryKey);

package/distribution/storage-item.js

@@ -12,18 +12,26 @@ export class StorageItem {
     }
     get = async () => {
         const result = await chromeP.storage[this.area].get(this.key);
-        if (!Object.hasOwn(result, this.key)) {
+        // Do not use Object.hasOwn() due to https://github.com/RickyMarou/jest-webextension-mock/issues/20
+        if (result[this.key] === undefined) {
             return this.defaultValue;
         }
         // eslint-disable-next-line @typescript-eslint/no-unsafe-return -- Assumes the user never uses the Storage API directly
         return result[this.key];
     };
     set = async (value) => {
-        await chromeP.storage[this.area].set({ [this.key]: value });
+        // eslint-disable-next-line unicorn/prefer-ternary -- ur rong
+        if (value === undefined) {
+            await chromeP.storage[this.area].remove(this.key);
+        }
+        else {
+            await chromeP.storage[this.area].set({ [this.key]: value });
+        }
     };
     has = async () => {
         const result = await chromeP.storage[this.area].get(this.key);
-        return Object.hasOwn(result, this.key);
+        // Do not use Object.hasOwn() due to https://github.com/RickyMarou/jest-webextension-mock/issues/20
+        return result[this.key] !== undefined;
     };
     remove = async () => {
         await chromeP.storage[this.area].remove(this.key);

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "webext-storage",
-	"version": "1.3.2",
+	"version": "2.0.1",
 	"description": "A more usable typed storage API for Web Extensions",
 	"keywords": [
 		"browser",

package/readme.md

@@ -24,6 +24,7 @@ options.onChanged(newValue => {
 - `item.get()` returns the raw value instead of an object
 - Every `get` and `set` operation is type-safe
 - If you provide a `defaultValue`, the return type will not be ` | undefined`
+- Calling `.set(undefined)` will unset the value instead of the call being ignored
 - The `onChanged` example speaks for itself
 
 Now compare it to the native API: