webext-messenger 0.20.0 → 0.20.1

package/distribution/index.js

@@ -1,8 +1,4 @@
-// Imports must use the .js extension because of ESM requires it and TS refuses to rewrite .ts to .js
-// This works in TS even if the .js doesn't exist, but it breaks Parcel (the tests builder)
-// For this reason, there's an `alias` field in package.json to redirect these imports.
-// If you see "@parcel/resolver-default: Cannot load file './yourNewFile.js'" you need to add it to the `alias` list
-// 🥲
+// Imports must use the .js extension because ESM requires it and TS refuses to rewrite .ts to .js
 export * from "./receiver.js";
 export * from "./sender.js";
 export * from "./types.js";

package/distribution/receiver.js

@@ -43,11 +43,13 @@ action) {
             args,
             wasForwarded: trace.length > 1,
         });
-        if (!didUserRegisterMethods()) {
-            throw new MessengerError(`No handlers registered in ${getContextName()}`);
-        }
         const localHandler = handlers.get(type);
         if (!localHandler) {
+            if (!didUserRegisterMethods()) {
+                // TODO: Test the handling of __getTabData in contexts that have no registered methods
+                // https://github.com/pixiebrix/webext-messenger/pull/82
+                throw new MessengerError(`No handlers registered in ${getContextName()}`);
+            }
             throw new MessengerError(`No handler registered for ${type} in ${getContextName()}`);
         }
         handleMessage = async () => localHandler.apply(meta, args);

package/distribution/thisTarget.js

@@ -5,7 +5,9 @@ import { debug } from "./shared.js";
 // Soft warning: Race conditions are possible.
 // This CANNOT be awaited because waiting for it means "I will handle the message."
 // If a message is received before this is ready, it will just have to be ignored.
-let thisTarget;
+let thisTarget = isBackground()
+    ? { page: "background" }
+    : undefined;
 function compareTargets(to, thisTarget) {
     for (const [key, value] of Object.entries(to)) {
         if (thisTarget[key] === value) {
@@ -70,11 +72,10 @@ export function __getTabData() {
     return { tabId: this.trace[0]?.tab?.id, frameId: this.trace[0]?.frameId };
 }
 export function initPrivateApi() {
-    if (isBackground()) {
-        thisTarget = { page: "background" };
-    }
     if (isExtensionContext()) {
-        // Any context can handler this message
+        // Only `runtime` pages can handle this message but I can't remove it  because its listener
+        // also serves the purpose of throwing a specific error when no methods have been registered.
+        // https://github.com/pixiebrix/webext-messenger/pull/80
         registerMethods({ __getTabData });
     }
 }

package/distribution/types.d.ts

@@ -40,7 +40,9 @@ export declare type Message<LocalArguments extends Arguments = Arguments> = {
     /** If the message is being sent to an intermediary receiver, also set the options */
     options?: Options;
 };
-export declare type Sender = Runtime.MessageSender;
+export declare type Sender = Runtime.MessageSender & {
+    origin?: string;
+};
 export declare type MessengerMessage = Message & {
     /** Guarantees that a message is meant to be handled by this library */
     __webextMessenger: true;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "webext-messenger",
-  "version": "0.20.0",
+  "version": "0.20.1",
   "description": "Browser Extension component messaging framework",
   "keywords": [],
   "repository": "pixiebrix/webext-messenger",