webext-messenger 0.18.1 → 0.19.1

package/distribution/sender.d.ts

@@ -1,6 +1,7 @@
 import { PublicMethod, PublicMethodWithTarget, Options, Target, PageTarget } from "./types.js";
 import { SetReturnType } from "type-fest";
-export declare const errorNonExistingTarget = "Could not establish connection. Receiving end does not exist.";
+export declare const errorTargetClosedEarly = "The target was closed before receiving a response";
+export declare const errorTabDoesntExist = "The tab doesn't exist";
 declare function messenger<Type extends keyof MessengerMethods, Method extends MessengerMethods[Type]>(type: Type, options: {
     isNotification: true;
 }, target: Target | PageTarget, ...args: Parameters<Method>): void;

package/distribution/sender.js

@@ -1,8 +1,13 @@
 import pRetry from "p-retry";
 import { isBackground } from "webext-detect-page";
+import { doesTabExist } from "webext-tools";
 import { deserializeError } from "serialize-error";
 import { isObject, MessengerError, __webextMessenger, handlers, debug, warn, } from "./shared.js";
-export const errorNonExistingTarget = "Could not establish connection. Receiving end does not exist.";
+const _errorNonExistingTarget = "Could not establish connection. Receiving end does not exist.";
+// https://github.com/mozilla/webextension-polyfill/issues/384
+const _errorTargetClosedEarly = "A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received";
+export const errorTargetClosedEarly = "The target was closed before receiving a response";
+export const errorTabDoesntExist = "The tab doesn't exist";
 function isMessengerResponse(response) {
     return isObject(response) && response["__webextMessenger"] === true;
 }
@@ -35,11 +40,19 @@ async function manageMessage(type, target, sendMessage) {
         minTimeout: 100,
         factor: 1.3,
         maxRetryTime: 4000,
-        onFailedAttempt(error) {
+        async onFailedAttempt(error) {
+            if (error.message === _errorTargetClosedEarly) {
+                throw new Error(errorTargetClosedEarly);
+            }
             if (
             // Don't retry sending to the background page unless it really hasn't loaded yet
             (target.page !== "background" && error instanceof MessengerError) ||
-                String(error.message).startsWith(errorNonExistingTarget)) {
+                String(error.message).startsWith(_errorNonExistingTarget)) {
+                if (browser.tabs &&
+                    typeof target.tabId === "number" &&
+                    !(await doesTabExist(target.tabId))) {
+                    throw new Error(errorTabDoesntExist);
+                }
                 debug(type, "will retry. Attempt", error.attemptNumber);
             }
             else {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "webext-messenger",
-  "version": "0.18.1",
+  "version": "0.19.1",
   "description": "Browser Extension component messaging framework",
   "keywords": [],
   "repository": "pixiebrix/webext-messenger",
@@ -78,7 +78,8 @@
     "overrides": [
       {
         "files": [
-          "*.test.ts"
+          "*.test.ts",
+          "testingApi.ts"
         ],
         "rules": {
           "@typescript-eslint/no-explicit-any": "off",
@@ -97,35 +98,36 @@
     ]
   },
   "dependencies": {
-    "p-retry": "^5.1.0",
-    "serialize-error": "^10.0.0",
-    "type-fest": "^2.12.1",
-    "webext-detect-page": "^4.0.1"
+    "p-retry": "^5.1.1",
+    "serialize-error": "^11.0.0",
+    "type-fest": "^2.13.0",
+    "webext-detect-page": "^4.0.1",
+    "webext-tools": "^1.1.0"
   },
   "devDependencies": {
-    "@parcel/config-webextension": "^2.4.0",
-    "@sindresorhus/tsconfig": "^2.0.0",
-    "@types/chrome": "^0.0.180",
+    "@parcel/config-webextension": "^2.6.0",
+    "@sindresorhus/tsconfig": "^3.0.1",
+    "@types/chrome": "^0.0.188",
     "@types/tape": "^4.13.2",
-    "@types/webextension-polyfill": "^0.8.3",
-    "@typescript-eslint/eslint-plugin": "^5.17.0",
-    "@typescript-eslint/parser": "^5.17.0",
+    "@types/webextension-polyfill": "^0.9.0",
+    "@typescript-eslint/eslint-plugin": "^5.27.0",
+    "@typescript-eslint/parser": "^5.27.0",
     "buffer": "^6.0.3",
-    "eslint": "^8.12.0",
+    "eslint": "^8.17.0",
     "eslint-config-prettier": "^8.5.0",
-    "eslint-config-xo": "^0.40.0",
-    "eslint-config-xo-typescript": "^0.50.0",
-    "eslint-plugin-import": "^2.25.4",
-    "eslint-plugin-unicorn": "^41.0.1",
+    "eslint-config-xo": "^0.41.0",
+    "eslint-config-xo-typescript": "^0.51.1",
+    "eslint-plugin-import": "^2.26.0",
+    "eslint-plugin-unicorn": "^42.0.0",
     "events": "^3.3.0",
     "npm-run-all": "^4.1.5",
-    "parcel": "^2.4.0",
+    "parcel": "^2.6.0",
     "path-browserify": "^1.0.1",
     "process": "^0.11.10",
     "stream-browserify": "^3.0.0",
-    "tape": "^5.5.2",
-    "typescript": "^4.6.3",
-    "webext-content-scripts": "^1.0.1",
+    "tape": "^5.5.3",
+    "typescript": "^4.7.3",
+    "webext-content-scripts": "^1.0.2",
     "webextension-polyfill": "^0.9.0"
   },
   "alias": {

package/readme.md

@@ -14,3 +14,7 @@ npm install webext-messenger
 ```js
 import messenger from "webext-messenger";
 ```
+
+## Context
+
+- [Initial considerations for this library](https://github.com/pixiebrix/webext-messenger/issues/1)