wdio-mediawiki 6.3.2 → 6.3.3

package/Api.js

@@ -62,7 +62,7 @@ class Api {
 	 * Do a request with custom parameters to the API. If you
 	 * use this function maybe something is missing in core?
 	 *
-	 * @param params
+	 * @param {Object} params
 	 * @return {Promise<Object>} The JSON response from the API
 	 * @throws {Error} If the request fails
 	 */

package/PrometheusFileReporter.js

@@ -111,7 +111,9 @@ class PrometheusFileReporter extends WDIOReporter {
 		const testDurationInSeconds = ( test.end - test.start ) / 1000;
 		const myTest = this.testMetrics[ test.uid ];
 		myTest.passed++;
-		myTest.testDurationSecondsMax = Math.max( myTest.testDurationSecondsMax, testDurationInSeconds );
+		myTest.testDurationSecondsMax = Math.max(
+			myTest.testDurationSecondsMax, testDurationInSeconds
+		);
 		myTest.testDurationSecondsSum += testDurationInSeconds;
 		myTest.testDurationSecondsCount += 1;
 		this.spec.passed++;
@@ -121,7 +123,9 @@ class PrometheusFileReporter extends WDIOReporter {
 		const testDurationInSeconds = ( test.end - test.start ) / 1000;
 		const myTest = this.testMetrics[ test.uid ];
 		myTest.failed++;
-		myTest.testDurationSecondsMax = Math.max( myTest.testDurationSecondsMax, testDurationInSeconds );
+		myTest.testDurationSecondsMax = Math.max(
+			myTest.testDurationSecondsMax, testDurationInSeconds
+		);
 		myTest.testDurationSecondsSum += testDurationInSeconds;
 		myTest.testDurationSecondsCount += 1;
 		this.spec.failed++;
@@ -164,6 +168,7 @@ class PrometheusFileReporter extends WDIOReporter {
 		specMetrics.labels = labels;
 		specMetrics.tests = Object.values( this.testMetrics );
 		const outputPath = path.join( this.outputDir, 'specs-' + workerId + '.json' );
+		// eslint-disable-next-line security/detect-non-literal-fs-filename
 		writeFileSync( outputPath, JSON.stringify( specMetrics ), { encoding: 'utf-8' } );
 	}
 }
@@ -181,11 +186,13 @@ function writeAllProjectMetrics( metricsDir, fileName ) {
 	};
 	const tests = [];
 
+	// eslint-disable-next-line security/detect-non-literal-fs-filename
 	for ( const file of readdirSync( metricsDir ) ) {
 		if ( !file.startsWith( 'specs-' ) || !file.endsWith( '.json' ) ) {
 			continue;
 		}
 		const filePath = path.join( metricsDir, file );
+		// eslint-disable-next-line security/detect-non-literal-fs-filename
 		const data = JSON.parse( readFileSync( filePath, 'utf-8' ) );
 
 		// We have read the raw data, renmove it since we only need the .prom
@@ -298,6 +305,7 @@ function writeAllProjectMetrics( metricsDir, fileName ) {
 	// Only write the file if we have any tests https://phabricator.wikimedia.org/T407831
 	if ( projectMetrics.totalTests > 0 ) {
 		const projectName = projectMetrics.labels.project;
+		// eslint-disable-next-line security/detect-non-literal-fs-filename
 		writeFileSync( path.join( metricsDir, `${ projectName }-${ fileName }.prom` ), `${ lines.join( '\n' ) }\n`, 'utf-8' );
 	}
 }

package/Util.js

@@ -42,7 +42,7 @@ export async function isTargetNotWikitext( target ) {
 				action: 'query', prop: 'info', titles: target_,
 				format: 'json', formatversion: 2
 			} ).then( ( result ) => {
-				// Finally, return whether said page is wikitext (or would be, if it doesn't yet exist)
+				// Finally, check if the page is wikitext (or would be, if it doesn't yet exist)
 				done( result.query.pages[ 0 ].contentmodel !== 'wikitext' );
 			} );
 		} );

package/api/Cookies.js

@@ -10,7 +10,7 @@ export class Cookies {
 	/**
 	 * Add cookies from Set-Cookie header lines.
 	 *
-	 * @param {Iterable<string>} setCookies - Iterable of `Set-Cookie` header lines.
+	 * @param {string[]} setCookies `Set-Cookie` header lines.
 	 */
 	getCookiesFromHeaders( setCookies ) {
 		for ( const line of setCookies ) {

package/index.js

@@ -190,8 +190,8 @@ export function setDisplay( instances ) {
  * NodeJS instances.
  *
  * @param {number} instances The number of parallel Xvfb servers to launch.
- * @param width The screen width
- * @param height The screen height
+ * @param {number} width The screen width
+ * @param {number} height The screen height
  * @return {object[]} An array of Xvfb child processes.
  */
 export function startXvfb( instances, width, height ) {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "wdio-mediawiki",
-	"version": "6.3.2",
+	"version": "6.3.3",
 	"type": "module",
 	"main": "index.js",
 	"description": "WebdriverIO plugin for testing a MediaWiki site.",

package/wdio-defaults.conf.js

@@ -51,6 +51,8 @@ export const config = {
 	// ============
 
 	maxInstances: process.env.CI ? 6 : 1,
+	// Make sure wdio do not try to start XVFB (we do that ourselves when needed)
+	autoXvfb: false,
 	capabilities: [ {
 		// ======
 		// Custom conf keys for MediaWiki
@@ -110,9 +112,11 @@ export const config = {
 	// By default we do not record videos and you can turn it on in CI
 	// Make sure to add it to true and change useBrowserHeadless to false
 	recordVideo: false,
-	// If you do not want to use browser headless, you need to export DISPLAY
-	// and have a display for the tests to work
-	useBrowserHeadless: Boolean( process.env.CI ),
+	// Always use headless in CI (if you do not override it),
+	// DISPLAY= forces headless and DISPLAY=<anything> forces non headless.
+	// When DISPLAY is not set locally, defaults to headless.
+	useBrowserHeadless: Boolean( process.env.CI ) ||
+		!process.env.DISPLAY,
 	// Only take screenshots on test failures. Setting this to false will take screenshots
 	// independently if a test works or fail
 	screenshotsOnFailureOnly: true,
@@ -150,7 +154,7 @@ export const config = {
 	 * Gets executed once before all workers get launched.
 	 *
 	 * @param {Object} wdioConfig wdio configuration object
-	 * @param capabilities
+	 * @param {Object[]} capabilities
 	 */
 	onPrepare: function ( wdioConfig, capabilities ) {
 		console.log( `Run test targeting ${ wdioConfig.baseUrl }` );