wave-agent-sdk 0.4.0 → 0.5.0

package/src/managers/subagentManager.ts

@@ -1,4 +1,5 @@
 import { randomUUID } from "crypto";
+import type { MemoryRuleManager } from "./MemoryRuleManager.js";
 import type { SubagentConfiguration } from "../utils/subagentParser.js";
 import type {
   Message,
@@ -20,6 +21,7 @@ import {
   addConsolidatedAbortListener,
   createAbortPromise,
 } from "../utils/abortUtils.js";
+import { BackgroundTaskManager } from "./backgroundTaskManager.js";
 
 export interface SubagentManagerCallbacks {
   // Granular subagent message callbacks (015-subagent-message-callbacks)
@@ -60,6 +62,7 @@ export interface SubagentInstance {
   status: "initializing" | "active" | "completed" | "error" | "aborted";
   messages: Message[];
   subagentType: string; // Store the subagent type for hook context
+  backgroundTaskId?: string; // ID of the background task if transitioned
 }
 
 export interface SubagentManagerOptions {
@@ -74,6 +77,8 @@ export interface SubagentManagerOptions {
   getLanguage: () => string | undefined;
   hookManager?: HookManager;
   onUsageAdded?: (usage: Usage) => void;
+  backgroundTaskManager?: BackgroundTaskManager;
+  memoryRuleManager?: MemoryRuleManager;
 }
 
 export class SubagentManager {
@@ -91,6 +96,8 @@ export class SubagentManager {
   private getLanguage: () => string | undefined;
   private hookManager?: HookManager;
   private onUsageAdded?: (usage: Usage) => void;
+  private backgroundTaskManager?: BackgroundTaskManager;
+  private memoryRuleManager?: MemoryRuleManager;
 
   constructor(options: SubagentManagerOptions) {
     this.workdir = options.workdir;
@@ -104,6 +111,8 @@ export class SubagentManager {
     this.getLanguage = options.getLanguage;
     this.hookManager = options.hookManager;
     this.onUsageAdded = options.onUsageAdded;
+    this.backgroundTaskManager = options.backgroundTaskManager;
+    this.memoryRuleManager = options.memoryRuleManager;
   }
 
   /**
@@ -158,6 +167,7 @@ export class SubagentManager {
       prompt: string;
       subagent_type: string;
     },
+    runInBackground?: boolean,
   ): Promise<SubagentInstance> {
     if (!this.parentToolManager) {
       throw new Error(
@@ -176,6 +186,7 @@ export class SubagentManager {
       logger: this.logger,
       sessionType: "subagent",
       subagentType: parameters.subagent_type,
+      memoryRuleManager: this.memoryRuleManager,
     });
 
     // Use the parent tool manager directly - tool restrictions will be handled by allowedTools parameter
@@ -241,6 +252,7 @@ export class SubagentManager {
       configuration,
       "active",
       parameters,
+      runInBackground,
     );
 
     return instance;
@@ -256,6 +268,7 @@ export class SubagentManager {
     instance: SubagentInstance,
     prompt: string,
     abortSignal?: AbortSignal,
+    runInBackground?: boolean,
   ): Promise<string> {
     try {
       // Check if already aborted before starting
@@ -269,24 +282,125 @@ export class SubagentManager {
         status: "active",
       });
 
-      // Set up consolidated abort handler to prevent listener accumulation
-      let abortCleanup: (() => void) | undefined;
-      if (abortSignal) {
-        abortCleanup = addConsolidatedAbortListener(abortSignal, [
-          () => {
-            // Update status to aborted
+      if (runInBackground && this.backgroundTaskManager) {
+        const taskId = this.backgroundTaskManager.generateId();
+        const startTime = Date.now();
+
+        this.backgroundTaskManager.addTask({
+          id: taskId,
+          type: "subagent",
+          status: "running",
+          startTime,
+          description: instance.configuration.description,
+          stdout: "",
+          stderr: "",
+        });
+
+        instance.backgroundTaskId = taskId;
+
+        // Execute in background
+        (async () => {
+          try {
+            const result = await this.internalExecute(
+              instance,
+              prompt,
+              abortSignal,
+            );
+            const task = this.backgroundTaskManager?.getTask(taskId);
+            if (task) {
+              task.status = "completed";
+              task.stdout = result;
+              task.endTime = Date.now();
+              task.runtime = task.endTime - startTime;
+            }
+          } catch (error) {
+            const task = this.backgroundTaskManager?.getTask(taskId);
+            if (task) {
+              task.status = "failed";
+              task.stderr =
+                error instanceof Error ? error.message : String(error);
+              task.endTime = Date.now();
+              task.runtime = task.endTime - startTime;
+            }
+          }
+        })();
+
+        return taskId;
+      }
+
+      return await this.internalExecute(instance, prompt, abortSignal);
+    } catch (error) {
+      this.updateInstanceStatus(instance.subagentId, "error");
+      this.parentMessageManager.updateSubagentBlock(instance.subagentId, {
+        status: "error",
+      });
+      throw error;
+    }
+  }
+
+  async backgroundInstance(subagentId: string): Promise<string> {
+    const instance = this.instances.get(subagentId);
+    if (!instance) {
+      throw new Error(`Subagent instance ${subagentId} not found`);
+    }
+
+    if (!this.backgroundTaskManager) {
+      throw new Error("BackgroundTaskManager not available");
+    }
+
+    const taskId = this.backgroundTaskManager.generateId();
+    const startTime = Date.now();
+
+    this.backgroundTaskManager.addTask({
+      id: taskId,
+      type: "subagent",
+      status: "running",
+      startTime,
+      description: instance.configuration.description,
+      stdout: "",
+      stderr: "",
+    });
+
+    instance.backgroundTaskId = taskId;
+
+    // Update parent message manager to reflect background status
+    this.parentMessageManager.updateSubagentBlock(subagentId, {
+      runInBackground: true,
+    });
+
+    return taskId;
+  }
+
+  private async internalExecute(
+    instance: SubagentInstance,
+    prompt: string,
+    abortSignal?: AbortSignal,
+  ): Promise<string> {
+    // Set up consolidated abort handler to prevent listener accumulation
+    let abortCleanup: (() => void) | undefined;
+    if (abortSignal) {
+      abortCleanup = addConsolidatedAbortListener(abortSignal, [
+        () => {
+          // Update status to aborted
+          // Only update status if it's NOT a background task
+          if (!instance.backgroundTaskId) {
             this.updateInstanceStatus(instance.subagentId, "aborted");
             this.parentMessageManager.updateSubagentBlock(instance.subagentId, {
               status: "aborted",
             });
-          },
-          () => {
-            // Abort the AI execution
+          }
+        },
+        () => {
+          // Abort the AI execution
+          // Only abort if it's NOT a background task
+          if (!instance.backgroundTaskId) {
             instance.aiManager.abortAIMessage();
-          },
-        ]);
-      }
+          }
+        },
+      ]);
+    }
 
+    try {
       // Add the user's prompt as a message
       instance.messageManager.addUserMessage({ content: prompt });
 
@@ -326,21 +440,16 @@ export class SubagentManager {
         model: resolvedModel,
       });
 
-      try {
-        // If we have an abort signal, race against it using utilities to prevent listener accumulation
-        if (abortSignal) {
-          await Promise.race([
-            executeAI,
-            createAbortPromise(abortSignal, "Task was aborted"),
-          ]);
-        } else {
-          await executeAI;
-        }
-      } finally {
-        // Clean up abort listeners to prevent memory leaks
-        if (abortCleanup) {
-          abortCleanup();
-        }
+      // If we have an abort signal, race against it using utilities to prevent listener accumulation
+      // BUT: If this is a background task, we DON'T want to race against the abort signal
+      // because the abort signal (Esc) should only stop the tool watching the task, not the task itself.
+      if (abortSignal && !instance.backgroundTaskId) {
+        await Promise.race([
+          executeAI,
+          createAbortPromise(abortSignal, "Task was aborted"),
+        ]);
+      } else {
+        await executeAI;
       }
 
       // Get the latest messages to extract the response
@@ -365,13 +474,43 @@ export class SubagentManager {
         status: "completed",
       });
 
+      // If this was transitioned to background, update the background task
+      if (instance.backgroundTaskId && this.backgroundTaskManager) {
+        const task = this.backgroundTaskManager.getTask(
+          instance.backgroundTaskId,
+        );
+        if (task) {
+          task.status = "completed";
+          task.stdout = response || "Task completed with no text response";
+          task.endTime = Date.now();
+          if (task.startTime) {
+            task.runtime = task.endTime - task.startTime;
+          }
+        }
+      }
+
       return response || "Task completed with no text response";
     } catch (error) {
-      this.updateInstanceStatus(instance.subagentId, "error");
-      this.parentMessageManager.updateSubagentBlock(instance.subagentId, {
-        status: "error",
-      });
+      // If this was transitioned to background, update the background task with error
+      if (instance.backgroundTaskId && this.backgroundTaskManager) {
+        const task = this.backgroundTaskManager.getTask(
+          instance.backgroundTaskId,
+        );
+        if (task) {
+          task.status = "failed";
+          task.stderr = error instanceof Error ? error.message : String(error);
+          task.endTime = Date.now();
+          if (task.startTime) {
+            task.runtime = task.endTime - task.startTime;
+          }
+        }
+      }
       throw error;
+    } finally {
+      // Clean up abort listeners to prevent memory leaks
+      if (abortCleanup) {
+        abortCleanup();
+      }
     }
   }
 
@@ -462,6 +601,7 @@ export class SubagentManager {
           logger: this.logger,
           sessionType: "subagent",
           subagentType: configuration.name, // Use configuration name for restored sessions
+          memoryRuleManager: this.memoryRuleManager,
         });
 
         // Use the parent tool manager

package/src/managers/toolManager.ts

@@ -1,5 +1,7 @@
 import type { ToolContext, ToolPlugin, ToolResult } from "../tools/types.js";
-import { bashTool, bashOutputTool, killBashTool } from "../tools/bashTool.js";
+import { bashTool } from "../tools/bashTool.js";
+import { taskOutputTool } from "../tools/taskOutputTool.js";
+import { taskStopTool } from "../tools/taskStopTool.js";
 import { deleteFileTool } from "../tools/deleteFileTool.js";
 import { editTool } from "../tools/editTool.js";
 import { multiEditTool } from "../tools/multiEditTool.js";
@@ -33,10 +35,14 @@ export interface ToolManagerOptions {
   mcpManager: McpManager;
   lspManager?: ILspManager;
   logger?: Logger;
-  /** Optional permission manager for handling tool permission checks */
+  /** Permission manager for handling tool permission checks */
   permissionManager?: PermissionManager;
+  /** Foreground task manager for backgrounding tasks */
+  foregroundTaskManager?: import("../types/processes.js").IForegroundTaskManager;
   /** Reversion manager for file snapshots */
   reversionManager?: ReversionManager;
+  /** Background task manager for background execution */
+  backgroundTaskManager?: import("./backgroundTaskManager.js").BackgroundTaskManager;
   /** Permission mode for tool execution (defaults to "default") */
   permissionMode?: PermissionMode;
   /** Custom permission callback for tool usage */
@@ -55,7 +61,9 @@ class ToolManager {
   private lspManager?: ILspManager;
   private logger?: Logger;
   private permissionManager?: PermissionManager;
+  private foregroundTaskManager?: import("../types/processes.js").IForegroundTaskManager;
   private reversionManager?: ReversionManager;
+  private backgroundTaskManager?: import("./backgroundTaskManager.js").BackgroundTaskManager;
   private permissionMode?: PermissionMode;
   private canUseToolCallback?: PermissionCallback;
 
@@ -64,7 +72,9 @@ class ToolManager {
     this.lspManager = options.lspManager;
     this.logger = options.logger;
     this.permissionManager = options.permissionManager;
+    this.foregroundTaskManager = options.foregroundTaskManager;
     this.reversionManager = options.reversionManager;
+    this.backgroundTaskManager = options.backgroundTaskManager;
     // Store CLI permission mode, let PermissionManager resolve effective mode
     this.permissionMode = options.permissionMode;
     this.canUseToolCallback = options.canUseToolCallback;
@@ -106,8 +116,8 @@ class ToolManager {
   }): void {
     const builtInTools = [
       bashTool,
-      bashOutputTool,
-      killBashTool,
+      taskOutputTool,
+      taskStopTool,
       deleteFileTool,
       editTool,
       multiEditTool,
@@ -168,6 +178,8 @@ class ToolManager {
       canUseToolCallback: this.canUseToolCallback,
       permissionManager: this.permissionManager,
       reversionManager: this.reversionManager,
+      backgroundTaskManager: this.backgroundTaskManager,
+      foregroundTaskManager: this.foregroundTaskManager,
       mcpManager: this.mcpManager,
       lspManager: this.lspManager,
     };

package/src/services/GitService.ts

@@ -43,7 +43,9 @@ export class GitService {
 
     try {
       const refArgs = ref ? `-b "${ref}"` : "--depth 1";
-      await execAsync(`LC_ALL=C git clone ${refArgs} "${url}" "${targetPath}"`);
+      await execAsync(`git clone ${refArgs} "${url}" "${targetPath}"`, {
+        env: { ...process.env, LC_ALL: "C" },
+      });
     } catch (error) {
       throw this.handleGitError(urlOrRepo, error);
     }
@@ -59,7 +61,9 @@ export class GitService {
       );
     }
     try {
-      await execAsync(`LC_ALL=C git -C "${targetPath}" pull`);
+      await execAsync(`git -C "${targetPath}" pull`, {
+        env: { ...process.env, LC_ALL: "C" },
+      });
     } catch (error) {
       throw this.handleGitError(targetPath, error);
     }

package/src/services/MarketplaceService.ts

@@ -346,7 +346,10 @@ export class MarketplaceService {
   /**
    * Installs a plugin from a marketplace
    */
-  async installPlugin(pluginAtMarketplace: string): Promise<InstalledPlugin> {
+  async installPlugin(
+    pluginAtMarketplace: string,
+    projectPath?: string,
+  ): Promise<InstalledPlugin> {
     const [pluginName, marketplaceName] = pluginAtMarketplace.split("@");
     if (!pluginName || !marketplaceName) {
       throw new Error("Invalid plugin format. Use name@marketplace");
@@ -432,7 +435,10 @@ export class MarketplaceService {
 
       const installedRegistry = await this.getInstalledPlugins();
       const existingIndex = installedRegistry.plugins.findIndex(
-        (p) => p.name === pluginName && p.marketplace === marketplaceName,
+        (p) =>
+          p.name === pluginName &&
+          p.marketplace === marketplaceName &&
+          p.projectPath === projectPath,
       );
 
       const installedPlugin: InstalledPlugin = {
@@ -440,6 +446,7 @@ export class MarketplaceService {
         marketplace: marketplaceName,
         version,
         cachePath,
+        projectPath,
       };
 
       if (existingIndex >= 0) {
@@ -467,7 +474,10 @@ export class MarketplaceService {
   /**
    * Uninstalls a plugin
    */
-  async uninstallPlugin(pluginAtMarketplace: string): Promise<void> {
+  async uninstallPlugin(
+    pluginAtMarketplace: string,
+    projectPath?: string,
+  ): Promise<void> {
     const [pluginName, marketplaceName] = pluginAtMarketplace.split("@");
     if (!pluginName || !marketplaceName) {
       throw new Error("Invalid plugin format. Use name@marketplace");
@@ -475,25 +485,33 @@ export class MarketplaceService {
 
     const installedRegistry = await this.getInstalledPlugins();
     const pluginIndex = installedRegistry.plugins.findIndex(
-      (p) => p.name === pluginName && p.marketplace === marketplaceName,
+      (p) =>
+        p.name === pluginName &&
+        p.marketplace === marketplaceName &&
+        p.projectPath === projectPath,
     );
 
     if (pluginIndex === -1) {
       throw new Error(
-        `Plugin ${pluginName}@${marketplaceName} is not installed`,
+        `Plugin ${pluginName}@${marketplaceName} is not installed${projectPath ? ` for project ${projectPath}` : ""}`,
       );
     }
 
-    const plugin = installedRegistry.plugins[pluginIndex];
-
-    // Remove cached files
-    if (existsSync(plugin.cachePath)) {
-      await fs.rm(plugin.cachePath, { recursive: true, force: true });
-    }
+    const pluginToRemove = installedRegistry.plugins[pluginIndex];
 
-    // Remove from registry
+    // Remove from registry first
     installedRegistry.plugins.splice(pluginIndex, 1);
     await this.saveInstalledPlugins(installedRegistry);
+
+    // Check if any other project is still using this same cache path
+    const isStillReferenced = installedRegistry.plugins.some(
+      (p) => p.cachePath === pluginToRemove.cachePath,
+    );
+
+    // Only remove cached files if no other references exist
+    if (!isStillReferenced && existsSync(pluginToRemove.cachePath)) {
+      await fs.rm(pluginToRemove.cachePath, { recursive: true, force: true });
+    }
   }
 
   /**

package/src/services/MemoryRuleService.ts

@@ -1,4 +1,5 @@
 import { minimatch } from "minimatch";
+import * as path from "node:path";
 import { parseFrontmatter } from "../utils/markdownParser.js";
 import type { MemoryRule, MemoryRuleMetadata } from "../types/memoryRule.js";
 
@@ -45,15 +46,26 @@ export class MemoryRuleService {
   /**
    * Determines if a rule matches any of the given file paths using minimatch.
    */
-  isRuleActive(rule: MemoryRule, filesInContext: string[]): boolean {
+  isRuleActive(
+    rule: MemoryRule,
+    filesInContext: string[],
+    workdir?: string,
+  ): boolean {
     if (!rule.metadata.paths || rule.metadata.paths.length === 0) {
       return true;
     }
 
-    return filesInContext.some((filePath) =>
-      rule.metadata.paths!.some((pattern) =>
-        minimatch(filePath, pattern, { dot: true }),
-      ),
-    );
+    return filesInContext.some((filePath) => {
+      // Normalize path relative to workdir if it's an absolute path
+      let normalizedPath = filePath;
+      if (workdir && path.isAbsolute(filePath)) {
+        normalizedPath = path.relative(workdir, filePath);
+      }
+
+      return rule.metadata.paths!.some((pattern) => {
+        const isMatch = minimatch(normalizedPath, pattern, { dot: true });
+        return isMatch;
+      });
+    });
   }
 }

package/src/services/memory.ts

@@ -142,7 +142,7 @@ export const readMemoryFile = async (workdir: string): Promise<string> => {
       return "";
     }
     logger.error("Failed to read memory file", { memoryFilePath, error });
-    throw error;
+    return "";
   }
 };