wave-agent-sdk 0.18.3 → 0.18.5

package/src/utils/worktreeUtils.ts

@@ -3,7 +3,7 @@
  * Used by EnterWorktree and ExitWorktree tools.
  */
 
-import { execSync } from "node:child_process";
+import { execFileSync } from "node:child_process";
 import * as path from "node:path";
 import * as fs from "node:fs";
 import { getGitMainRepoRoot, getDefaultRemoteBranch } from "./gitUtils.js";
@@ -81,7 +81,7 @@ export function generateWorktreeName(): string {
  * Get the current HEAD commit SHA.
  */
 export function getHeadCommit(cwd: string): string {
-  return execSync(`git -C "${cwd}" rev-parse HEAD`, {
+  return execFileSync("git", ["-C", cwd, "rev-parse", "HEAD"], {
     encoding: "utf8",
     stdio: ["ignore", "pipe", "ignore"],
   }).trim();
@@ -125,8 +125,9 @@ export function createWorktree(name: string, cwd: string): WorktreeInfo {
 
   try {
     // Create worktree and branch
-    execSync(
-      `git worktree add -b ${branchName} "${worktreePath}" ${baseBranch}`,
+    execFileSync(
+      "git",
+      ["worktree", "add", "-b", branchName, worktreePath, baseBranch],
       {
         cwd: repoRoot,
         stdio: ["ignore", "pipe", "pipe"],
@@ -151,7 +152,7 @@ export function createWorktree(name: string, cwd: string): WorktreeInfo {
     if (stderr.includes("already exists")) {
       // Branch exists but worktree doesn't — attach to existing branch
       try {
-        execSync(`git worktree add "${worktreePath}" ${branchName}`, {
+        execFileSync("git", ["worktree", "add", worktreePath, branchName], {
           cwd: repoRoot,
           stdio: ["ignore", "pipe", "pipe"],
           env: {
@@ -181,7 +182,7 @@ export function createWorktree(name: string, cwd: string): WorktreeInfo {
       // Base branch not fetched yet — try fetching then retrying
       const branchNameOnly = baseBranch.split("/").pop()!;
       try {
-        execSync(`git fetch origin ${branchNameOnly}`, {
+        execFileSync("git", ["fetch", "origin", branchNameOnly], {
           cwd: repoRoot,
           stdio: ["ignore", "pipe", "pipe"],
           env: {
@@ -190,8 +191,9 @@ export function createWorktree(name: string, cwd: string): WorktreeInfo {
             GIT_ASKPASS: "",
           },
         });
-        execSync(
-          `git worktree add -b ${branchName} "${worktreePath}" ${baseBranch}`,
+        execFileSync(
+          "git",
+          ["worktree", "add", "-b", branchName, worktreePath, baseBranch],
           {
             cwd: repoRoot,
             stdio: ["ignore", "pipe", "pipe"],
@@ -213,15 +215,19 @@ export function createWorktree(name: string, cwd: string): WorktreeInfo {
       } catch {
         // Fetch or retry failed — fall back to HEAD
         try {
-          execSync(`git worktree add -b ${branchName} "${worktreePath}" HEAD`, {
-            cwd: repoRoot,
-            stdio: ["ignore", "pipe", "pipe"],
-            env: {
-              ...process.env,
-              GIT_TERMINAL_PROMPT: "0",
-              GIT_ASKPASS: "",
+          execFileSync(
+            "git",
+            ["worktree", "add", "-b", branchName, worktreePath, "HEAD"],
+            {
+              cwd: repoRoot,
+              stdio: ["ignore", "pipe", "pipe"],
+              env: {
+                ...process.env,
+                GIT_TERMINAL_PROMPT: "0",
+                GIT_ASKPASS: "",
+              },
             },
-          });
+          );
           return {
             name,
             path: worktreePath,
@@ -253,24 +259,28 @@ export function removeWorktree(info: WorktreeInfo): void {
     // Get current branch in worktree before removing
     let currentBranch: string | undefined;
     try {
-      currentBranch = execSync(`git rev-parse --abbrev-ref HEAD`, {
-        cwd: info.path,
-        encoding: "utf8",
-        stdio: ["ignore", "pipe", "ignore"],
-      }).trim();
+      currentBranch = execFileSync(
+        "git",
+        ["rev-parse", "--abbrev-ref", "HEAD"],
+        {
+          cwd: info.path,
+          encoding: "utf8",
+          stdio: ["ignore", "pipe", "ignore"],
+        },
+      ).trim();
     } catch {
       // Ignore errors
     }
 
     // Remove worktree
-    execSync(`git worktree remove --force "${info.path}"`, {
+    execFileSync("git", ["worktree", "remove", "--force", info.path], {
       cwd: repoRoot,
       stdio: ["ignore", "pipe", "pipe"],
     });
 
     // Delete worktree branch
     try {
-      execSync(`git branch -D ${info.branch}`, {
+      execFileSync("git", ["branch", "-D", info.branch], {
         cwd: repoRoot,
         stdio: ["ignore", "pipe", "pipe"],
       });
@@ -293,7 +303,7 @@ export function removeWorktree(info: WorktreeInfo): void {
         currentBranch !== "master"
       ) {
         try {
-          execSync(`git branch -D ${currentBranch}`, {
+          execFileSync("git", ["branch", "-D", currentBranch], {
             cwd: repoRoot,
             stdio: ["ignore", "pipe", "pipe"],
           });
@@ -320,8 +330,9 @@ export function countWorktreeChanges(
   originalHeadCommit: string | undefined,
 ): { changedFiles: number; commits: number } | null {
   try {
-    const statusOutput = execSync(
-      `git -C "${worktreePath}" status --porcelain`,
+    const statusOutput = execFileSync(
+      "git",
+      ["-C", worktreePath, "status", "--porcelain"],
       {
         encoding: "utf8",
         stdio: ["ignore", "pipe", "ignore"],
@@ -335,8 +346,15 @@ export function countWorktreeChanges(
       return null;
     }
 
-    const revListOutput = execSync(
-      `git -C "${worktreePath}" rev-list --count ${originalHeadCommit}..HEAD`,
+    const revListOutput = execFileSync(
+      "git",
+      [
+        "-C",
+        worktreePath,
+        "rev-list",
+        "--count",
+        `${originalHeadCommit}..HEAD`,
+      ],
       {
         encoding: "utf8",
         stdio: ["ignore", "pipe", "ignore"],

package/builtin/skills/settings/MEMORY_RULES.md

@@ -1,60 +0,0 @@
-# Wave Memory Rules Configuration
-
-Memory rules allow you to provide context-specific instructions and guidelines to the agent. This document explains how to create and manage memory rules in Wave.
-
-## What are Memory Rules?
-
-Memory rules are Markdown files that contain instructions for the agent. They are used to:
-- Enforce coding styles and conventions.
-- Provide project-specific context (e.g., "always use pnpm").
-- Define architectural patterns and best practices.
-- Share common knowledge across the team.
-
-## Creating Memory Rules
-
-Wave looks for memory rules in the following locations:
-
-1.  **User Scope**: `~/.wave/rules/*.md` (Global memory rules)
-2.  **Project Scope**: `.wave/rules/*.md` (Project-specific memory rules)
-3.  **Project Root**: `AGENTS.md` (Legacy project-level memory rules)
-
-### File Structure
-
-A memory rule file is a standard Markdown file. It can optionally include YAML frontmatter to scope the rules to specific file paths.
-
-```markdown
----
-paths:
-  - "src/api/**/*.ts"
-  - "src/services/**/*.ts"
----
-
-# API and Service Guidelines
-
-- Always use `async/await` for asynchronous operations.
-- Use `Zod` for input validation.
-- Follow the repository pattern for data access.
-```
-
-### YAML Frontmatter Fields
-
-- `paths`: (Optional) A list of glob patterns. The rules in this file will only be active when the agent is working with files that match these patterns. If omitted, the rules are always active.
-
-## How Memory Rules are Loaded
-
-Wave automatically discovers and loads all `.md` files in the `.wave/rules/` directory and its immediate subdirectories.
-
-- **Path-Specific Activation**: If a memory rule has a `paths` field, it is only included in the agent's context if *any* file currently being read or modified matches the glob patterns.
-- **Union of Rules**: If multiple files are in context, Wave activates the union of all matching memory rules.
-- **Priority**: Project-level memory rules take priority over user-level memory rules if there is a conflict.
-
-## Best Practices
-
-- **Keep rules focused**: Create separate files for different topics (e.g., `testing.md`, `ui-components.md`).
-- **Use clear instructions**: Write rules in a way that is easy for the agent to understand and follow.
-- **Leverage path scoping**: Use the `paths` field to keep the agent's context window clean and relevant.
-- **Share rules with your team**: Commit `.wave/rules/` to your git repository to ensure everyone on the team has the same context.
-
-## Auto-Memory
-
-In addition to manual memory rules, Wave also has an **auto-memory** feature that automatically remembers important information across sessions. This is stored in `~/.wave/projects/<project-id>/memory/MEMORY.md`. You can disable this feature in `settings.json` by setting `"autoMemoryEnabled": false`.