wave-agent-sdk 0.14.4 → 0.15.1

package/src/types/agent.ts

@@ -98,6 +98,5 @@ export interface AgentCallbacks
   onConfiguredModelsChange?: (models: string[]) => void;
   onLoadingChange?: (loading: boolean) => void;
   onCommandRunningChange?: (running: boolean) => void;
-  onWorkdirChange?: (newCwd: string) => void;
   onQueuedMessagesChange?: (messages: QueuedMessage[]) => void;
 }

package/src/types/hooks.ts

@@ -21,7 +21,6 @@ export type HookEvent =
   | "SubagentStop"
   | "PermissionRequest"
   | "WorktreeCreate"
-  | "CwdChanged"
   | "SessionStart"
   | "SessionEnd";
 
@@ -110,7 +109,6 @@ export function isValidHookEvent(event: string): event is HookEvent {
     "SubagentStop",
     "PermissionRequest",
     "WorktreeCreate",
-    "CwdChanged",
     "SessionStart",
     "SessionEnd",
   ].includes(event);
@@ -169,7 +167,7 @@ export interface HookJsonInput {
   session_id: string; // Format: "wave_session_{uuid}_{shortId}"
   transcript_path: string; // Format: "~/.wave/sessions/session_{shortId}.json"
   cwd: string; // Absolute path to current working directory
-  hook_event_name: HookEvent; // "PreToolUse" | "PostToolUse" | "UserPromptSubmit" | "Stop" | "SubagentStop" | "PermissionRequest" | "WorktreeCreate" | "CwdChanged" | "SessionStart"
+  hook_event_name: HookEvent; // "PreToolUse" | "PostToolUse" | "UserPromptSubmit" | "Stop" | "SubagentStop" | "PermissionRequest" | "WorktreeCreate" | "SessionStart"
 
   // Optional fields based on event type
   tool_name?: string; // Present for PreToolUse, PostToolUse, PermissionRequest
@@ -178,8 +176,6 @@ export interface HookJsonInput {
   user_prompt?: string; // Present for UserPromptSubmit only
   subagent_type?: string; // Present when hook is executed by a subagent
   name?: string; // Present for WorktreeCreate events
-  old_cwd?: string; // Present for CwdChanged events
-  new_cwd?: string; // Present for CwdChanged events
   source?: SessionStartSource; // Present for SessionStart events
   agent_type?: string; // Present for SessionStart events
   end_source?: SessionEndSource; // Present for SessionEnd events
@@ -196,8 +192,6 @@ export interface ExtendedHookExecutionContext extends HookExecutionContext {
   userPrompt?: string; // User prompt text (UserPromptSubmit only)
   subagentType?: string; // Subagent type when hook is executed by a subagent
   worktreeName?: string; // Worktree name (WorktreeCreate only)
-  oldCwd?: string; // Previous working directory (CwdChanged only)
-  newCwd?: string; // New working directory (CwdChanged only)
   source?: SessionStartSource; // Session start source (SessionStart only)
   agentType?: string; // Agent type identifier (SessionStart only)
   endSource?: SessionEndSource; // Session end source (SessionEnd only)

package/src/types/messaging.ts

@@ -14,6 +14,7 @@ export interface Message {
   id: string; // Unique identifier for the message
   role: "user" | "assistant";
   blocks: MessageBlock[];
+  timestamp: string; // ISO 8601 timestamp, assigned at creation
   usage?: Usage; // Usage data for this message's AI operation (assistant messages only)
   additionalFields?: Record<string, unknown>; // Additional metadata from AI responses
   isMeta?: boolean; // Whether the message is a meta message (hidden from UI)

package/src/types/session.ts

@@ -5,14 +5,6 @@
  * SIMPLIFIED: Removed unused interfaces to focus on core functionality
  */
 
-import type { Message } from "./messaging.js";
-
-// Enhanced message interface for JSONL storage (extends existing Message)
-export interface SessionMessage extends Message {
-  timestamp: string; // ISO 8601 - added for JSONL format
-  // Inherits: role: "user" | "assistant", blocks: MessageBlock[], usage?, additionalFields?
-}
-
 // Session filename structure for simple filename-based metadata
 export interface SessionFilename {
   sessionId: string;

package/src/utils/editUtils.ts

@@ -1,7 +1,6 @@
 /**
  * Utility functions for file editing tools
  */
-import { formatLineNumberPrefix } from "./stringUtils.js";
 
 /**
  * Escape regular expression special characters
@@ -11,77 +10,8 @@ export function escapeRegExp(string: string): string {
 }
 
 /**
- * Analyze why an edit failed by finding the best partial match and highlighting mismatches.
+ * Returns a generic error message when old_string is not found.
  */
-export function analyzeEditMismatch(
-  content: string,
-  searchString: string,
-): string {
-  const contentLines = content.split("\n");
-  const searchLines = searchString.split("\n");
-
-  if (searchLines.length === 0 || contentLines.length === 0) {
-    return "old_string not found in file (empty search or content)";
-  }
-
-  let bestMatchIndex = -1;
-  let bestMatchScore = -1;
-
-  // Sliding window to find the best partial match
-  for (let i = 0; i <= contentLines.length - searchLines.length; i++) {
-    let currentScore = 0;
-    for (let j = 0; j < searchLines.length; j++) {
-      if (contentLines[i + j] === searchLines[j]) {
-        currentScore++;
-      }
-    }
-
-    // Heuristic: prioritize matches where first or last lines match
-    if (contentLines[i] === searchLines[0]) currentScore += 0.5;
-    if (
-      contentLines[i + searchLines.length - 1] ===
-      searchLines[searchLines.length - 1]
-    )
-      currentScore += 0.5;
-
-    // Also consider trimmed matches to catch indentation issues
-    for (let j = 0; j < searchLines.length; j++) {
-      if (
-        contentLines[i + j].trim() === searchLines[j].trim() &&
-        contentLines[i + j] !== searchLines[j]
-      ) {
-        currentScore += 0.1;
-      }
-    }
-
-    if (currentScore > bestMatchScore) {
-      bestMatchScore = currentScore;
-      bestMatchIndex = i;
-    }
-  }
-
-  // If no decent match found (score <= 0), return generic message
-  if (bestMatchScore <= 0) {
-    return "old_string not found in file (no similar block found)";
-  }
-
-  // Generate detailed report
-  const reportLines: string[] = [
-    `old_string not found in file. Best partial match found at line ${bestMatchIndex + 1}:`,
-  ];
-
-  for (let j = 0; j < searchLines.length; j++) {
-    const lineNum = bestMatchIndex + j + 1;
-    const actualLine = contentLines[bestMatchIndex + j];
-    const expectedLine = searchLines[j];
-
-    if (actualLine === expectedLine) {
-      reportLines.push(`${formatLineNumberPrefix(lineNum)}${actualLine}`);
-    } else {
-      reportLines.push(`${formatLineNumberPrefix(lineNum)}- ${expectedLine}`);
-      reportLines.push(`${formatLineNumberPrefix(lineNum)}+ ${actualLine}`);
-    }
-  }
-
-  return reportLines.join("\n");
+export function analyzeEditMismatch(): string {
+  return "old_string not found in file";
 }

package/src/utils/markdownParser.ts

@@ -1,7 +1,13 @@
-import { readFileSync } from "fs";
+import { readFileSync, writeFileSync, mkdirSync } from "fs";
 import { exec } from "child_process";
 import { promisify } from "util";
+import { join } from "path";
+import { tmpdir } from "os";
 import type { CustomSlashCommandConfig } from "../types/index.js";
+import {
+  SKILL_BASH_MAX_OUTPUT_CHARS,
+  PREVIEW_SIZE_BYTES,
+} from "../constants/toolLimits.js";
 
 const execAsync = promisify(exec);
 
@@ -138,17 +144,52 @@ export interface BashCommandResult {
   exitCode: number;
 }
 
+/**
+ * Block syntax pattern: ```! command ```
+ */
+const BLOCK_BASH_REGEX = /```!\s*\n?([\s\S]*?)\n?```/g;
+
+/**
+ * Inline syntax pattern: !`command`
+ */
+const INLINE_BASH_REGEX = /!`([^`]+)`/g;
+
 export function parseBashCommands(content: string): {
   commands: string[];
   processedContent: string;
 } {
-  const bashCommandRegex = /!`([^`]+)`/g;
+  // Performance gate: skip expensive regex if no bash pattern exists
+  // Covers the common case where 93% of skills have no bash substitution
+  if (!content.includes("!`") && !content.includes("```!")) {
+    return { commands: [], processedContent: content };
+  }
+
   const commands: string[] = [];
-  let match;
 
-  // Extract all bash commands
-  while ((match = bashCommandRegex.exec(content)) !== null) {
-    commands.push(match[1]);
+  // Extract block commands
+  let blockMatch;
+  const blockRegex = new RegExp(
+    BLOCK_BASH_REGEX.source,
+    BLOCK_BASH_REGEX.flags,
+  );
+  while ((blockMatch = blockRegex.exec(content)) !== null) {
+    const cmd = blockMatch[1].trim();
+    if (cmd) {
+      commands.push(cmd);
+    }
+  }
+
+  // Extract inline commands
+  let inlineMatch;
+  const inlineRegex = new RegExp(
+    INLINE_BASH_REGEX.source,
+    INLINE_BASH_REGEX.flags,
+  );
+  while ((inlineMatch = inlineRegex.exec(content)) !== null) {
+    const cmd = inlineMatch[1].trim();
+    if (cmd) {
+      commands.push(cmd);
+    }
   }
 
   // For now, return the content as-is. The actual command execution
@@ -160,22 +201,55 @@ export function parseBashCommands(content: string): {
 }
 
 /**
- * Replace bash command placeholders with their outputs
+ * Truncate output if it exceeds the size limit.
+ * Writes to a temp file and returns a preview + file path if truncated.
+ */
+export function truncateOutput(output: string): string {
+  if (output.length <= SKILL_BASH_MAX_OUTPUT_CHARS) {
+    return output;
+  }
+
+  const preview = output.slice(0, PREVIEW_SIZE_BYTES);
+  const tempDir = join(tmpdir(), "wave-skill-bash");
+  mkdirSync(tempDir, { recursive: true });
+
+  const tempFile = join(
+    tempDir,
+    `output-${Date.now()}-${Math.random().toString(36).slice(2, 8)}.txt`,
+  );
+  writeFileSync(tempFile, output, "utf-8");
+
+  return `${preview}\n\n[Output truncated (${output.length} chars). Full output saved to: ${tempFile}]`;
+}
+
+/**
+ * Replace bash command placeholders with their outputs.
+ * Uses function replacer to avoid $$, $&, $' corruption in shell output.
+ * Handles both inline (!`cmd`) and block (```! cmd ```) syntax.
  */
 export function replaceBashCommandsWithOutput(
   content: string,
   results: BashCommandResult[],
 ): string {
-  const bashCommandRegex = /!`([^`]+)`/g;
   let processedContent = content;
   let commandIndex = 0;
 
-  processedContent = processedContent.replace(bashCommandRegex, (match) => {
+  // Replace block syntax first: ```! command ```
+  processedContent = processedContent.replace(BLOCK_BASH_REGEX, () => {
+    if (commandIndex < results.length) {
+      const result = results[commandIndex++];
+      return truncateOutput(result.output);
+    }
+    return "";
+  });
+
+  // Replace inline syntax: !`command`
+  processedContent = processedContent.replace(INLINE_BASH_REGEX, () => {
     if (commandIndex < results.length) {
       const result = results[commandIndex++];
-      return result.output;
+      return truncateOutput(result.output);
     }
-    return match;
+    return "";
   });
 
   return processedContent;

package/src/utils/messageOperations.ts

@@ -160,6 +160,7 @@ export const addUserMessageToMessages = ({
     id: id || generateMessageId(),
     role: "user",
     blocks,
+    timestamp: new Date().toISOString(),
     ...(isMeta !== undefined && { isMeta }),
   };
   return [...messages, userMessage];
@@ -231,6 +232,7 @@ export const addAssistantMessageToMessages = (
     id: generateMessageId(),
     role: "assistant",
     blocks,
+    timestamp: new Date().toISOString(),
     usage, // Include usage data if provided
     ...(additionalFields ? { additionalFields: { ...additionalFields } } : {}),
   };
@@ -407,6 +409,7 @@ export const addErrorBlockToMessage = ({
           content: error,
         },
       ],
+      timestamp: new Date().toISOString(),
     });
   }
 
@@ -430,6 +433,7 @@ export const addBangMessage = ({
         exitCode: null,
       },
     ],
+    timestamp: new Date().toISOString(),
   };
 
   return [...messages, outputMessage];
@@ -620,6 +624,7 @@ export const addNotificationMessageToMessages = ({
     id: generateMessageId(),
     role: "user",
     blocks: [block],
+    timestamp: new Date().toISOString(),
   };
 
   return [...messages, notificationMessage];

package/src/utils/openaiClient.ts

@@ -177,28 +177,17 @@ export class OpenAIClient {
       error.body = errorBody;
 
       if (response.status === 429 && attempt < maxRetries) {
-        const responseHeaders: Record<string, string> = {};
-        response.headers.forEach((value, key) => {
-          responseHeaders[key] = value;
-        });
         logger.warn("OpenAI API 429 Too Many Requests, retrying...", {
           attempt: attempt + 1,
           status: response.status,
-          responseHeaders,
         });
         lastError = error;
         continue;
       }
 
-      const responseHeaders: Record<string, string> = {};
-      response.headers.forEach((value, key) => {
-        responseHeaders[key] = value;
-      });
       logger.error("OpenAI API Error:", {
         status: response.status,
         statusText: response.statusText,
-        requestHeaders: headers,
-        responseHeaders,
         errorBody,
       });
       throw error;