wave-agent-sdk 0.0.7 → 0.0.10

package/src/tools/bashTool.ts

@@ -1,4 +1,7 @@
 import { spawn, ChildProcess } from "child_process";
+import { logger } from "../utils/globalLogger.js";
+import { stripAnsiColors } from "../utils/stringUtils.js";
+import { handleLargeOutput } from "../utils/largeOutputHandler.js";
 import type { ToolPlugin, ToolResult, ToolContext } from "./types.js";
 
 /**
@@ -44,6 +47,7 @@ export const bashTool: ToolPlugin = {
   ): Promise<ToolResult> => {
     const command = args.command as string;
     const runInBackground = args.run_in_background as boolean | undefined;
+    const description = args.description as string | undefined;
     // Set default timeout: 60s for foreground, no timeout for background
     const timeout =
       (args.timeout as number | undefined) ??
@@ -69,6 +73,45 @@ export const bashTool: ToolPlugin = {
       };
     }
 
+    // Permission check after validation but before real operation
+    if (
+      context.permissionManager &&
+      context.permissionMode &&
+      context.permissionMode !== "bypassPermissions"
+    ) {
+      if (context.permissionManager.isRestrictedTool("Bash")) {
+        try {
+          const permissionContext = context.permissionManager.createContext(
+            "Bash",
+            context.permissionMode,
+            context.canUseToolCallback,
+            {
+              command,
+              description,
+              run_in_background: runInBackground,
+              timeout,
+            },
+          );
+          const permissionResult =
+            await context.permissionManager.checkPermission(permissionContext);
+
+          if (permissionResult.behavior === "deny") {
+            return {
+              success: false,
+              content: "",
+              error: `Bash operation denied by user, reason: ${permissionResult.message || "No reason provided"}`,
+            };
+          }
+        } catch {
+          return {
+            success: false,
+            content: "",
+            error: "Permission check failed",
+          };
+        }
+      }
+    }
+
     if (runInBackground) {
       // Background execution
       const backgroundBashManager = context?.backgroundBashManager;
@@ -133,8 +176,8 @@ export const bashTool: ToolPlugin = {
                 if (child.pid && !child.killed) {
                   try {
                     process.kill(-child.pid, "SIGKILL");
-                  } catch {
-                    // logger.error("Failed to force kill process:", killError);
+                  } catch (killError) {
+                    logger.error("Failed to force kill process:", killError);
                   }
                 }
               }, 1000);
@@ -147,8 +190,8 @@ export const bashTool: ToolPlugin = {
                     child.kill("SIGKILL");
                   }
                 }, 1000);
-              } catch {
-                // logger.error("Failed to kill child process:", directKillError);
+              } catch (directKillError) {
+                logger.error("Failed to kill child process:", directKillError);
               }
             }
           }
@@ -167,18 +210,21 @@ export const bashTool: ToolPlugin = {
           handleAbort();
           return;
         }
-        context.abortSignal.addEventListener("abort", () => handleAbort());
+        // Use { once: true } to prevent listener accumulation on signal reuse
+        context.abortSignal.addEventListener("abort", () => handleAbort(), {
+          once: true,
+        });
       }
 
       child.stdout?.on("data", (data) => {
         if (!isAborted) {
-          outputBuffer += data.toString();
+          outputBuffer += stripAnsiColors(data.toString());
         }
       });
 
       child.stderr?.on("data", (data) => {
         if (!isAborted) {
-          errorBuffer += data.toString();
+          errorBuffer += stripAnsiColors(data.toString());
         }
       });
 
@@ -192,15 +238,32 @@ export const bashTool: ToolPlugin = {
           const combinedOutput =
             outputBuffer + (errorBuffer ? "\n" + errorBuffer : "");
 
-          resolve({
-            success: exitCode === 0,
-            content:
-              combinedOutput || `Command executed with exit code: ${exitCode}`,
-            error:
-              exitCode !== 0
-                ? `Command failed with exit code: ${exitCode}`
-                : undefined,
-          });
+          // Handle large output by writing to temp file if needed
+          const finalOutput =
+            combinedOutput || `Command executed with exit code: ${exitCode}`;
+          handleLargeOutput(finalOutput)
+            .then(({ content, filePath }) => {
+              resolve({
+                success: exitCode === 0,
+                content,
+                filePath,
+                error:
+                  exitCode !== 0
+                    ? `Command failed with exit code: ${exitCode}`
+                    : undefined,
+              });
+            })
+            .catch((error) => {
+              logger.warn(`Error handling large output: ${error}`);
+              resolve({
+                success: exitCode === 0,
+                content: finalOutput,
+                error:
+                  exitCode !== 0
+                    ? `Command failed with exit code: ${exitCode}`
+                    : undefined,
+              });
+            });
         }
       });
 
@@ -219,9 +282,15 @@ export const bashTool: ToolPlugin = {
     });
   },
   formatCompactParams: (params: Record<string, unknown>) => {
+    const description = params.description as string;
     const command = params.command as string;
     const runInBackground = params.run_in_background as boolean;
-    return `${command}${runInBackground ? " background" : ""}`;
+
+    if (description) {
+      return description;
+    }
+
+    return `${command}${runInBackground ? " (background)" : ""}`;
   },
 };
 
@@ -298,15 +367,20 @@ export const bashOutputTool: ToolPlugin = {
 
     let content = "";
     if (output.stdout) {
-      content += output.stdout;
+      content += stripAnsiColors(output.stdout);
     }
     if (output.stderr) {
-      content += (content ? "\n" : "") + output.stderr;
+      content += (content ? "\n" : "") + stripAnsiColors(output.stderr);
     }
 
+    const finalContent = content || "No output available";
+    const { content: processedContent, filePath } =
+      await handleLargeOutput(finalContent);
+
     return {
       success: true,
-      content: content || "No output available",
+      content: processedContent,
+      filePath,
       shortResult: `${bashId}: ${output.status}${shell.exitCode !== undefined ? ` (${shell.exitCode})` : ""}`,
       error: undefined,
     };

package/src/tools/deleteFileTool.ts

@@ -1,4 +1,5 @@
 import { unlink } from "fs/promises";
+import { logger } from "../utils/globalLogger.js";
 import type { ToolPlugin, ToolResult, ToolContext } from "./types.js";
 import { resolvePath, getDisplayPath } from "../utils/path.js";
 
@@ -45,10 +46,46 @@ export const deleteFileTool: ToolPlugin = {
     try {
       const filePath = resolvePath(targetFile, context.workdir);
 
+      // Permission check after validation but before real operation
+      if (
+        context.permissionManager &&
+        context.permissionMode &&
+        context.permissionMode !== "bypassPermissions"
+      ) {
+        if (context.permissionManager.isRestrictedTool("Delete")) {
+          try {
+            const permissionContext = context.permissionManager.createContext(
+              "Delete",
+              context.permissionMode,
+              context.canUseToolCallback,
+              { target_file: targetFile },
+            );
+            const permissionResult =
+              await context.permissionManager.checkPermission(
+                permissionContext,
+              );
+
+            if (permissionResult.behavior === "deny") {
+              return {
+                success: false,
+                content: "",
+                error: `Delete operation denied by user, reason: ${permissionResult.message || "No reason provided"}`,
+              };
+            }
+          } catch {
+            return {
+              success: false,
+              content: "",
+              error: "Permission check failed",
+            };
+          }
+        }
+      }
+
       // Delete file
       await unlink(filePath);
 
-      // logger.debug(`Successfully deleted file: ${filePath}`);
+      logger.debug(`Successfully deleted file: ${filePath}`);
 
       return {
         success: true,

package/src/tools/editTool.ts

@@ -1,7 +1,7 @@
 import { readFile, writeFile } from "fs/promises";
+import { logger } from "../utils/globalLogger.js";
 import type { ToolPlugin, ToolResult, ToolContext } from "./types.js";
 import { resolvePath, getDisplayPath } from "../utils/path.js";
-import { diffLines } from "diff";
 
 /**
  * Format compact parameter display
@@ -142,6 +142,47 @@ export const editTool: ToolPlugin = {
         replacementCount = 1;
       }
 
+      // Permission check after validation but before real operation
+      if (
+        context.permissionManager &&
+        context.permissionMode &&
+        context.permissionMode !== "bypassPermissions"
+      ) {
+        if (context.permissionManager.isRestrictedTool("Edit")) {
+          try {
+            const permissionContext = context.permissionManager.createContext(
+              "Edit",
+              context.permissionMode,
+              context.canUseToolCallback,
+              {
+                file_path: filePath,
+                old_string: oldString,
+                new_string: newString,
+                replace_all: replaceAll,
+              },
+            );
+            const permissionResult =
+              await context.permissionManager.checkPermission(
+                permissionContext,
+              );
+
+            if (permissionResult.behavior === "deny") {
+              return {
+                success: false,
+                content: "",
+                error: `Edit operation denied by user, reason: ${permissionResult.message || "No reason provided"}`,
+              };
+            }
+          } catch {
+            return {
+              success: false,
+              content: "",
+              error: "Permission check failed",
+            };
+          }
+        }
+      }
+
       // Write file
       try {
         await writeFile(resolvedPath, newContent, "utf-8");
@@ -153,28 +194,22 @@ export const editTool: ToolPlugin = {
         };
       }
 
-      // Generate diff information
-      const diffResult = diffLines(originalContent, newContent);
-
       const shortResult = replaceAll
         ? `Replaced ${replacementCount} instances`
         : "Text replaced successfully";
 
-      // logger.debug(`Edit tool: ${shortResult}`);
+      logger.debug(`Edit tool: ${shortResult}`);
 
       return {
         success: true,
         content: shortResult,
         shortResult,
         filePath: resolvedPath,
-        originalContent,
-        newContent,
-        diffResult,
       };
     } catch (error) {
       const errorMessage =
         error instanceof Error ? error.message : String(error);
-      // logger.error(`Edit tool error: ${errorMessage}`);
+      logger.error(`Edit tool error: ${errorMessage}`);
       return {
         success: false,
         content: "",