warscript 0.0.1-dev.ed60fea → 0.0.1-dev.f48f7bb

package/engine/internal/item/ability.lua

@@ -14,6 +14,8 @@ local ____math = require("math")
 local MINIMUM_POSITIVE_NORMALIZED_FLOAT = ____math.MINIMUM_POSITIVE_NORMALIZED_FLOAT
 local ____timer = require("core.types.timer")
 local Timer = ____timer.Timer
+local ____ignore_2Devents_2Ditems = require("engine.internal.unit.ignore-events-items")
+local ignoreEventsItems = ____ignore_2Devents_2Ditems.ignoreEventsItems
 local isItemOwned = IsItemOwned
 local isItemPowerup = IsItemPowerup
 local getItemX = GetItemX
@@ -86,6 +88,10 @@ ____exports.abilityActionDummy = dummy
 ---
 -- @internal For use by internal systems only.
 ____exports.doAbilityAction = function(handle, action, ...)
+    local isAlreadyIgnoredInEvents = ignoreEventsItems[handle] ~= nil
+    if not isAlreadyIgnoredInEvents then
+        ignoreEventsItems[handle] = true
+    end
     local isOwned = isItemOwned(handle)
     local isPowerup
     local x
@@ -107,6 +113,9 @@ ____exports.doAbilityAction = function(handle, action, ...)
             setItemBooleanField(handle, ITEM_BF_USE_AUTOMATICALLY_WHEN_ACQUIRED, true)
         end
     end
+    if not isAlreadyIgnoredInEvents then
+        ignoreEventsItems[handle] = nil
+    end
     return result
 end
 ---
@@ -119,6 +128,10 @@ ____exports.doAbilityActionForceDummy = function(handle, owner, action, ...)
     if slot == nil then
         return ____exports.doAbilityAction(handle, action, ...)
     end
+    local isAlreadyIgnoredInEvents = ignoreEventsItems[handle] ~= nil
+    if not isAlreadyIgnoredInEvents then
+        ignoreEventsItems[handle] = true
+    end
     local isPowerup
     if isItemPowerup(handle) then
         setItemBooleanField(handle, ITEM_BF_USE_AUTOMATICALLY_WHEN_ACQUIRED, false)
@@ -133,6 +146,9 @@ ____exports.doAbilityActionForceDummy = function(handle, owner, action, ...)
     if isPowerup then
         setItemBooleanField(handle, ITEM_BF_USE_AUTOMATICALLY_WHEN_ACQUIRED, true)
     end
+    if not isAlreadyIgnoredInEvents then
+        ignoreEventsItems[handle] = nil
+    end
     return result
 end
 return ____exports

package/engine/internal/unit/ignore-events-items.d.ts

@@ -0,0 +1,2 @@
+/** @noSelfInFile */
+export {};

package/engine/internal/unit/ignore-events-items.lua

@@ -0,0 +1,5 @@
+local ____exports = {}
+---
+-- @internal For use by internal systems only.
+____exports.ignoreEventsItems = {}
+return ____exports

package/engine/internal/unit/item.lua

@@ -9,15 +9,36 @@ local ____unit = require("engine.internal.unit")
 local Unit = ____unit.Unit
 local ____utility = require("engine.internal.utility")
 local findUnitItemSlot = ____utility.findUnitItemSlot
+local ____blank = require("engine.object-data.entry.item-type.blank")
+local BlankItemType = ____blank.BlankItemType
+local ____arrays = require("utility.arrays")
+local array = ____arrays.array
+local ____ignore_2Devents_2Ditems = require("engine.internal.unit.ignore-events-items")
+local ignoreEventsItems = ____ignore_2Devents_2Ditems.ignoreEventsItems
 local rawset = _G.rawset
 local ____type = _G.type
 local isItemPowerup = IsItemPowerup
 local setItemBooleanField = BlzSetItemBooleanField
 local unitAddItem = UnitAddItem
-local unitDropItemSlot = UnitDropItemSlot
 local unitInventorySize = UnitInventorySize
 local unitItemInSlot = UnitItemInSlot
+local unitRemoveItem = UnitRemoveItem
 local unitRemoveItemFromSlot = UnitRemoveItemFromSlot
+local FILLER_ITEM_TYPE_ID = compiletime(function()
+    local itemType = BlankItemType:create()
+    itemType.name = "[Warscript/Dummy] Slot Filler"
+    return itemType.id
+end)
+local fillerItems = array(
+    6,
+    function()
+        local item = CreateItem(FILLER_ITEM_TYPE_ID, 0, 0)
+        SetItemVisible(item, false)
+        ignoreEventsItems[item] = true
+        return item
+    end
+)
+local unitsWithFillerItems = {}
 local handleByUnitItems = setmetatable({}, {__mode = "k"})
 local function unitItemsNext(handle, index)
     local slot = index & 7
@@ -47,8 +68,19 @@ function UnitItems.prototype.__newindex(self, slot, item)
         if isPowerup then
             setItemBooleanField(itemHandle, ITEM_BF_USE_AUTOMATICALLY_WHEN_ACQUIRED, false)
         end
+        for previousSlot = 0, slot - 2 do
+            if unitItemInSlot(handle, previousSlot) == nil then
+                unitAddItem(handle, fillerItems[previousSlot + 1])
+                unitsWithFillerItems[handle] = true
+            end
+        end
         unitAddItem(handle, itemHandle)
-        unitDropItemSlot(handle, itemHandle, slot - 1)
+        if unitsWithFillerItems[handle] ~= nil then
+            for previousSlot = 0, slot - 2 do
+                unitRemoveItem(handle, fillerItems[previousSlot + 1])
+            end
+            unitsWithFillerItems[handle] = nil
+        end
         if isPowerup then
             setItemBooleanField(itemHandle, ITEM_BF_USE_AUTOMATICALLY_WHEN_ACQUIRED, true)
         end
@@ -67,6 +99,18 @@ function UnitItems.prototype.__ipairs(self)
     local handle = handleByUnitItems[self]
     return unitItemsNext, handle, unitInventorySize(handle) << 3
 end
+Unit.itemPickedUpEvent:addListener(
+    4,
+    function(unit)
+        local handle = unit.handle
+        if unitsWithFillerItems[handle] ~= nil then
+            for previousSlot = 1, 6 do
+                unitRemoveItem(handle, fillerItems[previousSlot])
+            end
+            unitsWithFillerItems[handle] = nil
+        end
+    end
+)
 __TS__ObjectDefineProperty(
     Unit.prototype,
     "items",

package/engine/internal/unit.lua

@@ -51,6 +51,8 @@ local ____arrays = require("utility.arrays")
 local forEach = ____arrays.forEach
 local ____math = require("math")
 local min = ____math.min
+local ____ignore_2Devents_2Ditems = require("engine.internal.unit.ignore-events-items")
+local ignoreEventsItems = ____ignore_2Devents_2Ditems.ignoreEventsItems
 local match = string.match
 local ____tostring = _G.tostring
 local setUnitAnimation = SetUnitAnimation
@@ -2518,8 +2520,9 @@ Unit.itemDroppedEvent = __TS__New(
     EVENT_PLAYER_UNIT_DROP_ITEM,
     function()
         local unit = getTriggerUnit()
-        if getUnitTypeId(unit) ~= dummyUnitId then
-            return ____exports.Unit:of(unit), Item:of(getManipulatedItem())
+        local item = getManipulatedItem()
+        if getUnitTypeId(unit) ~= dummyUnitId and not (ignoreEventsItems[item] ~= nil) then
+            return ____exports.Unit:of(unit), Item:of(item)
         end
         return IgnoreEvent
     end
@@ -2529,8 +2532,9 @@ Unit.itemPickedUpEvent = __TS__New(
     EVENT_PLAYER_UNIT_PICKUP_ITEM,
     function()
         local unit = getTriggerUnit()
-        if getUnitTypeId(unit) ~= dummyUnitId then
-            return ____exports.Unit:of(unit), Item:of(getManipulatedItem())
+        local item = getManipulatedItem()
+        if getUnitTypeId(unit) ~= dummyUnitId and not (ignoreEventsItems[item] ~= nil) then
+            return ____exports.Unit:of(unit), Item:of(item)
         end
         return IgnoreEvent
     end
@@ -2540,8 +2544,9 @@ Unit.itemUsedEvent = __TS__New(
     EVENT_PLAYER_UNIT_USE_ITEM,
     function()
         local unit = getTriggerUnit()
-        if getUnitTypeId(unit) ~= dummyUnitId then
-            return ____exports.Unit:of(unit), Item:of(getManipulatedItem())
+        local item = getManipulatedItem()
+        if getUnitTypeId(unit) ~= dummyUnitId and not (ignoreEventsItems[item] ~= nil) then
+            return ____exports.Unit:of(unit), Item:of(item)
         end
         return IgnoreEvent
     end

package/package.json

@@ -1,7 +1,7 @@
 {
     "$schema": "https://json.schemastore.org/package",
     "name": "warscript",
-    "version": "0.0.1-dev.ed60fea",
+    "version": "0.0.1-dev.f48f7bb",
     "description": "A typescript library for Warcraft III using Warpack.",
     "keywords": [
         "warcraft",