warscript 0.0.1-dev.e561d29 → 0.0.1-dev.e5e97e8

package/decl/native.d.ts

@@ -5259,8 +5259,8 @@ declare function BlzRemoveAbilityStringLevelArrayField(
     level: number,
     value: string,
 ): boolean
-declare function BlzGetItemAbilityByIndex(whichItem: jitem, index: number): jability | null
-declare function BlzGetItemAbility(whichItem: jitem, abilCode: number): jability | null
+declare function BlzGetItemAbilityByIndex(whichItem: jitem, index: number): jability | undefined
+declare function BlzGetItemAbility(whichItem: jitem, abilCode: number): jability | undefined
 declare function BlzItemAddAbility(whichItem: jitem, abilCode: number): boolean
 declare function BlzGetItemBooleanField(whichItem: jitem, whichField: jitembooleanfield): boolean
 declare function BlzGetItemIntegerField(whichItem: jitem, whichField: jitemintegerfield): number

package/engine/behavior.d.ts

@@ -1,5 +1,6 @@
 /** @noSelfInFile */
 import { AbstractDestroyable, Destructor } from "../destroyable";
+import { Event } from "../event";
 export type BehaviorConstructor<T extends Behavior<AnyNotNil>, Parameters extends any[] = any[]> = OmitConstructor<typeof Behavior<any>> & (abstract new (...parameters: Parameters) => T);
 declare const enum BehaviorPropertyKey {
     PREVIOUS_BEHAVIOR = 0,
@@ -13,6 +14,8 @@ export declare abstract class Behavior<T extends AnyNotNil, PeriodicActionParame
     private [BehaviorPropertyKey.TIMER]?;
     protected constructor(object: T);
     protected onDestroy(): Destructor;
+    protected registerEvent<K extends string, Args extends any[]>(this: Behavior<any, PeriodicActionParameters> & Record<K, (this: this, ...args: Args) => unknown>, event: Event<[...Args]>, listener: K): void;
+    protected deregisterEvent(event: Event<any>): boolean;
     protected onPeriod(...parameters: PeriodicActionParameters): void;
     protected startPeriodicAction(interval: number, ...parameters: PeriodicActionParameters): void;
     protected stopPeriodicAction(): void;

package/engine/behavior.lua

@@ -2,6 +2,7 @@ local ____lualib = require("lualib_bundle")
 local __TS__InstanceOf = ____lualib.__TS__InstanceOf
 local __TS__Class = ____lualib.__TS__Class
 local __TS__ClassExtends = ____lualib.__TS__ClassExtends
+local __TS__New = ____lualib.__TS__New
 local ____exports = {}
 local ____destroyable = require("destroyable")
 local AbstractDestroyable = ____destroyable.AbstractDestroyable
@@ -9,6 +10,13 @@ local ____timer = require("core.types.timer")
 local Timer = ____timer.Timer
 local ____functions = require("utility.functions")
 local increment = ____functions.increment
+local ____linked_2Dset = require("utility.linked-set")
+local LinkedSet = ____linked_2Dset.LinkedSet
+local ____lua_2Dmaps = require("utility.lua-maps")
+local getOrPut = ____lua_2Dmaps.getOrPut
+local mutableLuaMap = ____lua_2Dmaps.mutableLuaMap
+local ____lua_2Dsets = require("utility.lua-sets")
+local mutableLuaSet = ____lua_2Dsets.mutableLuaSet
 local safeCall = warpack.safeCall
 local firstBehaviorByObject = {}
 local lastBehaviorByObject = {}
@@ -47,6 +55,9 @@ local function reduceBehaviors(behaviorConstructor, object, operation, initial,
     end
     return accumulator
 end
+local behaviorsByEvent = {}
+local listenerByBehaviorByEvent = {}
+local eventsByBehavior = {}
 ____exports.Behavior = __TS__Class()
 local Behavior = ____exports.Behavior
 Behavior.name = "Behavior"
@@ -69,6 +80,20 @@ function Behavior.prototype.onDestroy(self)
     if ____opt_0 ~= nil then
         ____opt_0:destroy()
     end
+    local events = eventsByBehavior[self]
+    if events ~= nil then
+        for event in pairs(events) do
+            local ____opt_2 = behaviorsByEvent[event]
+            if ____opt_2 ~= nil then
+                ____opt_2:remove(self)
+            end
+            local ____opt_4 = listenerByBehaviorByEvent[event]
+            if ____opt_4 ~= nil then
+                ____opt_4[self] = nil
+            end
+        end
+        eventsByBehavior[self] = nil
+    end
     local previousBehavior = self[0]
     local nextBehavior = self[1]
     if previousBehavior ~= nil then
@@ -83,6 +108,34 @@ function Behavior.prototype.onDestroy(self)
     end
     return AbstractDestroyable.prototype.onDestroy(self)
 end
+function Behavior.prototype.registerEvent(self, event, listener)
+    local listenerByBehavior = getOrPut(listenerByBehaviorByEvent, event, mutableLuaMap)
+    listenerByBehavior[self] = listener
+    getOrPut(eventsByBehavior, self, mutableLuaSet)[event] = true
+    local behaviors = behaviorsByEvent[event]
+    if behaviors == nil then
+        event:addListener(function(...)
+            local behaviors = behaviorsByEvent[event]
+            if behaviors ~= nil then
+                for behavior in pairs(behaviors) do
+                    safeCall(behavior[listenerByBehavior[behavior]], behavior, ...)
+                end
+            end
+        end)
+        behaviors = __TS__New(LinkedSet)
+        behaviorsByEvent[event] = behaviors
+    end
+    behaviors:add(self)
+end
+function Behavior.prototype.deregisterEvent(self, event)
+    local behaviors = behaviorsByEvent[event]
+    if behaviors ~= nil and behaviors:remove(self) then
+        eventsByBehavior[self][event] = nil
+        listenerByBehaviorByEvent[event][self] = nil
+        return true
+    end
+    return false
+end
 function Behavior.prototype.onPeriod(self, ...)
 end
 function Behavior.prototype.startPeriodicAction(self, interval, ...)

package/engine/behaviour/ability/remove-buffs.d.ts

@@ -14,3 +14,12 @@ export declare class RemoveBuffsSelfAbilityBehavior extends AbilityBehavior {
     constructor(ability: Ability, polarity?: AbilityDependentValue<BuffPolarity> | undefined, resistanceType?: AbilityDependentValue<BuffResistanceType> | undefined, includeExpirationTimers?: AbilityDependentValue<boolean> | undefined, includeAuras?: AbilityDependentValue<boolean> | undefined, autoDispel?: AbilityDependentValue<boolean> | undefined);
     onImpact(caster: Unit): void;
 }
+export declare class RemoveBuffsTargetAbilityBehavior extends AbilityBehavior {
+    private readonly polarity?;
+    private readonly resistanceType?;
+    private readonly includeExpirationTimers?;
+    private readonly includeAuras?;
+    private readonly autoDispel?;
+    constructor(ability: Ability, polarity?: AbilityDependentValue<BuffPolarity> | undefined, resistanceType?: AbilityDependentValue<BuffResistanceType> | undefined, includeExpirationTimers?: AbilityDependentValue<boolean> | undefined, includeAuras?: AbilityDependentValue<boolean> | undefined, autoDispel?: AbilityDependentValue<boolean> | undefined);
+    onUnitTargetImpact(_: Unit, target: Unit): void;
+}

package/engine/behaviour/ability/remove-buffs.lua

@@ -25,4 +25,25 @@ function RemoveBuffsSelfAbilityBehavior.prototype.onImpact(self, caster)
         self:resolveCurrentAbilityDependentValue(self.autoDispel)
     )
 end
+____exports.RemoveBuffsTargetAbilityBehavior = __TS__Class()
+local RemoveBuffsTargetAbilityBehavior = ____exports.RemoveBuffsTargetAbilityBehavior
+RemoveBuffsTargetAbilityBehavior.name = "RemoveBuffsTargetAbilityBehavior"
+__TS__ClassExtends(RemoveBuffsTargetAbilityBehavior, AbilityBehavior)
+function RemoveBuffsTargetAbilityBehavior.prototype.____constructor(self, ability, polarity, resistanceType, includeExpirationTimers, includeAuras, autoDispel)
+    AbilityBehavior.prototype.____constructor(self, ability)
+    self.polarity = polarity
+    self.resistanceType = resistanceType
+    self.includeExpirationTimers = includeExpirationTimers
+    self.includeAuras = includeAuras
+    self.autoDispel = autoDispel
+end
+function RemoveBuffsTargetAbilityBehavior.prototype.onUnitTargetImpact(self, _, target)
+    target:removeBuffs(
+        self:resolveCurrentAbilityDependentValue(self.polarity),
+        self:resolveCurrentAbilityDependentValue(self.resistanceType),
+        self:resolveCurrentAbilityDependentValue(self.includeExpirationTimers),
+        self:resolveCurrentAbilityDependentValue(self.includeAuras),
+        self:resolveCurrentAbilityDependentValue(self.autoDispel)
+    )
+end
 return ____exports

package/engine/behaviour/ability/restore-mana.d.ts

@@ -8,7 +8,7 @@ export declare class RestoreManaSelfAbilityBehavior extends AbilityBehavior {
     constructor(ability: Ability, mana: AbilityDependentValue<number>);
     onImpact(caster: Unit): void;
 }
-export declare class RestoreManaAbilityBehavior extends AbilityBehavior {
+export declare class RestoreManaTargetAbilityBehavior extends AbilityBehavior {
     private readonly mana;
     constructor(ability: Ability, mana: AbilityDependentValue<number>);
     onUnitTargetImpact(caster: Unit, target: Unit): void;

package/engine/behaviour/ability/restore-mana.lua

@@ -15,15 +15,15 @@ end
 function RestoreManaSelfAbilityBehavior.prototype.onImpact(self, caster)
     caster.mana = caster.mana + self:resolveCurrentAbilityDependentValue(self.mana)
 end
-____exports.RestoreManaAbilityBehavior = __TS__Class()
-local RestoreManaAbilityBehavior = ____exports.RestoreManaAbilityBehavior
-RestoreManaAbilityBehavior.name = "RestoreManaAbilityBehavior"
-__TS__ClassExtends(RestoreManaAbilityBehavior, AbilityBehavior)
-function RestoreManaAbilityBehavior.prototype.____constructor(self, ability, mana)
+____exports.RestoreManaTargetAbilityBehavior = __TS__Class()
+local RestoreManaTargetAbilityBehavior = ____exports.RestoreManaTargetAbilityBehavior
+RestoreManaTargetAbilityBehavior.name = "RestoreManaTargetAbilityBehavior"
+__TS__ClassExtends(RestoreManaTargetAbilityBehavior, AbilityBehavior)
+function RestoreManaTargetAbilityBehavior.prototype.____constructor(self, ability, mana)
     AbilityBehavior.prototype.____constructor(self, ability)
     self.mana = mana
 end
-function RestoreManaAbilityBehavior.prototype.onUnitTargetImpact(self, caster, target)
+function RestoreManaTargetAbilityBehavior.prototype.onUnitTargetImpact(self, caster, target)
     target.mana = target.mana + self:resolveCurrentAbilityDependentValue(self.mana)
 end
 return ____exports

package/engine/behaviour/unit/stun-immunity.d.ts

@@ -8,6 +8,7 @@ export type StunImmunityUnitBehaviourParameters = {
     buffTypeIds?: LuaSet<BuffTypeId>;
     textTagPreset?: TextTagPreset;
     textTagText?: string;
+    additionalAction?: (this: void, unit: Unit) => void;
 };
 export declare class StunImmunityUnitBehavior extends UnitBehavior {
     readonly parameters: Readonly<StunImmunityUnitBehaviourParameters>;
@@ -17,4 +18,5 @@ export declare class StunImmunityUnitBehavior extends UnitBehavior {
     onDamageReceived(): void;
     onTargetingAbilityChannelingStart(): void;
     onTargetingAbilityImpact(): void;
+    protected onEffect(): void;
 }

package/engine/behaviour/unit/stun-immunity.lua

@@ -48,8 +48,15 @@ local function process(behavior)
     for buffTypeId in pairs(behavior.parameters.buffTypeIds or DEFAULT_BUFF_TYPE_IDS) do
         hasRemovedBuffs = hasRemovedBuffs or behavior.unit:removeBuff(buffTypeId)
     end
-    if hasRemovedBuffs and behavior.parameters.textTagText ~= nil then
-        TextTag:flash(TextTag.MISS, behavior.parameters.textTagText, behavior.unit.x, behavior.unit.y)
+    if hasRemovedBuffs then
+        behavior.onEffect(behavior)
+        if behavior.parameters.textTagText ~= nil then
+            TextTag:flash(TextTag.MISS, behavior.parameters.textTagText, behavior.unit.x, behavior.unit.y)
+        end
+        local ____opt_0 = behavior.parameters.additionalAction
+        if ____opt_0 ~= nil then
+            ____opt_0(behavior.unit)
+        end
     end
 end
 ____exports.StunImmunityUnitBehavior = __TS__Class()
@@ -79,5 +86,7 @@ end
 function StunImmunityUnitBehavior.prototype.onTargetingAbilityImpact(self)
     process(self)
 end
+function StunImmunityUnitBehavior.prototype.onEffect(self)
+end
 StunImmunityUnitBehavior.defaultParameters = {buffTypeIds = DEFAULT_BUFF_TYPE_IDS, textTagPreset = TextTag.MISS, textTagText = nil}
 return ____exports

package/engine/behaviour/unit.d.ts

@@ -11,13 +11,18 @@ import { Destructor } from "../../destroyable";
 import type { Widget } from "../../core/types/widget";
 import { Destructable } from "../../core/types/destructable";
 import type { Buff } from "../buff";
+import { UnitBonusType } from "../internal/unit/bonus";
+import { Player } from "../../core/types/player";
 export type UnitBehaviorConstructor<Args extends any[]> = new (unit: Unit, ...args: Args) => UnitBehavior;
 export declare abstract class UnitBehavior<PeriodicActionParameters extends any[] = any[]> extends Behavior<Unit, PeriodicActionParameters> {
+    readonly sourceAbilityBehavior?: AbilityBehavior;
+    private _bonusIdByBonusType?;
     constructor(unit: Unit);
     protected onDestroy(): Destructor;
-    readonly sourceAbilityBehavior?: AbilityBehavior;
     get unit(): Unit;
-    registerInRangeUnitEvent<T extends string, Args extends any[]>(this: UnitBehavior<PeriodicActionParameters> & Record<T, (this: this, ...args: Args) => unknown>, event: Event<[...Args]>, extractUnit: (...args: Args) => Unit | undefined, range: number, listener: T): void;
+    protected getUnitBonus(bonusType: UnitBonusType): number;
+    protected addOrUpdateOrRemoveUnitBonus(bonusType: UnitBonusType, value: number): void;
+    protected registerInRangeUnitEvent<T extends string, Args extends any[]>(this: UnitBehavior<PeriodicActionParameters> & Record<T, (this: this, ...args: Args) => unknown>, event: Event<[...Args]>, extractUnit: (...args: Args) => Unit | undefined, range: number, listener: T): void;
     onImmediateOrder(orderId: number): void;
     onTargetOrder(orderId: number, target: Widget): void;
     onPointOrder(orderId: number, x: number, y: number): void;
@@ -51,4 +56,5 @@ export declare abstract class UnitBehavior<PeriodicActionParameters extends any[
     onItemChargesChanged(item: Item): void;
     onKill(target: Unit): void;
     onDeath(source: Unit | undefined): void;
+    onOwnerChange(previousOwner: Player): void;
 }

package/engine/behaviour/unit.lua

@@ -17,6 +17,11 @@ local getOrPut = ____lua_2Dmaps.getOrPut
 local mutableLuaMap = ____lua_2Dmaps.mutableLuaMap
 local ____lua_2Dsets = require("utility.lua-sets")
 local mutableLuaSet = ____lua_2Dsets.mutableLuaSet
+local ____bonus = require("engine.internal.unit.bonus")
+local addOrUpdateOrRemoveUnitBonus = ____bonus.addOrUpdateOrRemoveUnitBonus
+local getUnitBonus = ____bonus.getUnitBonus
+local removeUnitBonus = ____bonus.removeUnitBonus
+local safeCall = warpack.safeCall
 local behaviorsByEvent = {}
 local rangeByBehaviorByEvent = {}
 local listenerByBehaviorByEvent = {}
@@ -47,8 +52,26 @@ function UnitBehavior.prototype.onDestroy(self)
         end
         eventsByBehavior[self] = nil
     end
+    if self._bonusIdByBonusType ~= nil then
+        for bonusType, bonusId in pairs(self._bonusIdByBonusType) do
+            removeUnitBonus(self.object, bonusType, bonusId)
+        end
+    end
     return Behavior.prototype.onDestroy(self)
 end
+function UnitBehavior.prototype.getUnitBonus(self, bonusType)
+    local ____opt_6 = self._bonusIdByBonusType
+    local bonusId = ____opt_6 and ____opt_6[bonusType]
+    return bonusId == nil and 0 or getUnitBonus(self.object, bonusType, bonusId)
+end
+function UnitBehavior.prototype.addOrUpdateOrRemoveUnitBonus(self, bonusType, value)
+    local bonusIdByBonusType = self._bonusIdByBonusType
+    if bonusIdByBonusType == nil then
+        bonusIdByBonusType = {}
+        self._bonusIdByBonusType = bonusIdByBonusType
+    end
+    bonusIdByBonusType[bonusType] = addOrUpdateOrRemoveUnitBonus(self.object, bonusType, bonusIdByBonusType[bonusType], value)
+end
 function UnitBehavior.prototype.registerInRangeUnitEvent(self, event, extractUnit, range, listener)
     local rangeByBehavior = getOrPut(rangeByBehaviorByEvent, event, mutableLuaMap)
     rangeByBehavior[self] = range
@@ -65,8 +88,7 @@ function UnitBehavior.prototype.registerInRangeUnitEvent(self, event, extractUni
                     for behavior in pairs(behaviors) do
                         local range = rangeByBehavior[behavior]
                         if range ~= nil and unit:getCollisionDistanceTo(behavior.unit) <= range then
-                            local ____self_6 = behavior
-                            ____self_6[listenerByBehavior[behavior]](____self_6, ...)
+                            safeCall(behavior[listenerByBehavior[behavior]], behavior, ...)
                         end
                     end
                 end
@@ -143,6 +165,8 @@ function UnitBehavior.prototype.onKill(self, target)
 end
 function UnitBehavior.prototype.onDeath(self, source)
 end
+function UnitBehavior.prototype.onOwnerChange(self, previousOwner)
+end
 __TS__SetDescriptor(
     UnitBehavior.prototype,
     "unit",
@@ -254,6 +278,9 @@ __TS__SetDescriptor(
     Unit.itemChargesChangedEvent:addListener(function(unit, item)
         ____exports.UnitBehavior:forAll(unit, "onItemChargesChanged", item)
     end)
+    Unit.onOwnerChange:addListener(function(unit, previousOwner)
+        ____exports.UnitBehavior:forAll(unit, "onOwnerChange", previousOwner)
+    end)
 end)(UnitBehavior)
 Unit.destroyEvent:addListener(function(unit)
     ____exports.UnitBehavior:forAll(unit, "destroy")

package/engine/buff.d.ts

@@ -201,11 +201,8 @@ export declare class Buff<AdditionalParameters extends Prohibit<Record<string, a
     private readonly _spellStealPriority?;
     private readonly _learnLevelMinimum?;
     private readonly [BuffPropertyKey.MISS_PROBABILITY]?;
-    private _bonusIdByBonusType?;
     private readonly _abilityTypeIds?;
     private _behaviors?;
-    private getUnitBonus;
-    private addOrUpdateOrRemoveUnitBonus;
     constructor(target: Unit, ...parameters: BuffConstructorParameters<AdditionalParameters>);
     get level(): number;
     get remainingDamageOverDuration(): number;

package/engine/buff.lua

@@ -28,9 +28,6 @@ local ____math = require("math")
 local max = ____math.max
 local min = ____math.min
 local ____bonus = require("engine.internal.unit.bonus")
-local addOrUpdateOrRemoveUnitBonus = ____bonus.addOrUpdateOrRemoveUnitBonus
-local getUnitBonus = ____bonus.getUnitBonus
-local removeUnitBonus = ____bonus.removeUnitBonus
 local UnitBonusType = ____bonus.UnitBonusType
 local ____area_2Ddamage = require("engine.internal.mechanics.area-damage")
 local damageArea = ____area_2Ddamage.damageArea
@@ -509,63 +506,50 @@ function Buff.prototype.____constructor(self, _unit, typeIdOrTypeIds, polarityOr
     self[100] = 1
     Event.invoke(buffCreatedEvent, self)
 end
-function Buff.prototype.getUnitBonus(self, bonusType)
-    local ____opt_38 = self._bonusIdByBonusType
-    local bonusId = ____opt_38 and ____opt_38[bonusType]
-    return bonusId == nil and 0 or getUnitBonus(self._unit, bonusType, bonusId)
-end
-function Buff.prototype.addOrUpdateOrRemoveUnitBonus(self, bonusType, value)
-    local bonusIdByBonusType = self._bonusIdByBonusType
-    if bonusIdByBonusType == nil then
-        bonusIdByBonusType = {}
-        self._bonusIdByBonusType = bonusIdByBonusType
-    end
-    bonusIdByBonusType[bonusType] = addOrUpdateOrRemoveUnitBonus(self._unit, bonusType, bonusIdByBonusType[bonusType], value)
-end
 function Buff.prototype.flashEffect(self, widgetOrXOrParametersOrDuration, yOrParametersOrDuration, parametersOrDuration)
     if type(widgetOrXOrParametersOrDuration) == "number" and type(yOrParametersOrDuration) == "number" then
         Effect:flash(self[105], widgetOrXOrParametersOrDuration, yOrParametersOrDuration, parametersOrDuration)
     else
         local isWidgetProvided = __TS__InstanceOf(widgetOrXOrParametersOrDuration, Unit) or __TS__InstanceOf(widgetOrXOrParametersOrDuration, Item) or __TS__InstanceOf(widgetOrXOrParametersOrDuration, Destructable)
-        local ____Effect_42 = Effect
-        local ____Effect_flash_43 = Effect.flash
-        local ____array_41 = __TS__SparseArrayNew(
+        local ____Effect_40 = Effect
+        local ____Effect_flash_41 = Effect.flash
+        local ____array_39 = __TS__SparseArrayNew(
             self[105],
             isWidgetProvided and widgetOrXOrParametersOrDuration or self._unit,
             stringValueByBuffTypeIdByFieldId[fourCC("feft")][self.typeId] or "origin"
         )
-        local ____isWidgetProvided_40
+        local ____isWidgetProvided_38
         if isWidgetProvided then
-            ____isWidgetProvided_40 = yOrParametersOrDuration
+            ____isWidgetProvided_38 = yOrParametersOrDuration
         else
-            ____isWidgetProvided_40 = widgetOrXOrParametersOrDuration
+            ____isWidgetProvided_38 = widgetOrXOrParametersOrDuration
         end
-        __TS__SparseArrayPush(____array_41, ____isWidgetProvided_40)
-        ____Effect_flash_43(
-            ____Effect_42,
-            __TS__SparseArraySpread(____array_41)
+        __TS__SparseArrayPush(____array_39, ____isWidgetProvided_38)
+        ____Effect_flash_41(
+            ____Effect_40,
+            __TS__SparseArraySpread(____array_39)
         )
     end
 end
 function Buff.prototype.flashSpecialEffect(self, widgetOrDuration, duration)
     local isWidgetProvided = type(widgetOrDuration) == "table"
-    local ____Effect_46 = Effect
-    local ____Effect_flash_47 = Effect.flash
-    local ____array_45 = __TS__SparseArrayNew(
+    local ____Effect_44 = Effect
+    local ____Effect_flash_45 = Effect.flash
+    local ____array_43 = __TS__SparseArrayNew(
         self[106],
         isWidgetProvided and widgetOrDuration or self._unit,
         stringValueByBuffTypeIdByFieldId[fourCC("fspt")][self.typeId] or "origin"
     )
-    local ____isWidgetProvided_44
+    local ____isWidgetProvided_42
     if isWidgetProvided then
-        ____isWidgetProvided_44 = duration
+        ____isWidgetProvided_42 = duration
     else
-        ____isWidgetProvided_44 = widgetOrDuration
+        ____isWidgetProvided_42 = widgetOrDuration
     end
-    __TS__SparseArrayPush(____array_45, ____isWidgetProvided_44)
-    ____Effect_flash_47(
-        ____Effect_46,
-        __TS__SparseArraySpread(____array_45)
+    __TS__SparseArrayPush(____array_43, ____isWidgetProvided_42)
+    ____Effect_flash_45(
+        ____Effect_44,
+        __TS__SparseArraySpread(____array_43)
     )
 end
 function Buff.prototype.onCreate(self)
@@ -604,7 +588,7 @@ function Buff.prototype.onDestroy(self)
     end
     if self[136] then
         if self[137] then
-            unit:decrementStunCounter()
+            unit:decrementForceStunCounter()
         end
         unit:decrementStunCounter()
     end
@@ -616,11 +600,6 @@ function Buff.prototype.onDestroy(self)
             unit:removeAbility(abilityTypeId)
         end
     end
-    if self._bonusIdByBonusType ~= nil then
-        for bonusType, bonusId in pairs(self._bonusIdByBonusType) do
-            removeUnitBonus(unit, bonusType, bonusId)
-        end
-    end
     Event.invoke(buffBeingDestroyedEvent, self)
     self[100] = 3
     return UnitBehavior.prototype.onDestroy(self)
@@ -650,8 +629,8 @@ function Buff.apply(self, ...)
     end
 end
 function Buff.getByTypeId(self, unit, typeId)
-    local ____opt_48 = buffByTypeIdByUnit[unit]
-    local buff = ____opt_48 and ____opt_48[typeId]
+    local ____opt_46 = buffByTypeIdByUnit[unit]
+    local buff = ____opt_46 and ____opt_46[typeId]
     if __TS__InstanceOf(buff, self) then
         return buff
     end
@@ -809,8 +788,8 @@ __TS__SetDescriptor(
                 return
             end
             self[112] = damageInterval
-            local ____opt_50 = self._timer
-            local elapsed = ____opt_50 and ____opt_50.elapsed or 0
+            local ____opt_48 = self._timer
+            local elapsed = ____opt_48 and ____opt_48.elapsed or 0
             local timer = self[114]
             if timer == nil then
                 timer = Timer:create()
@@ -889,8 +868,8 @@ __TS__SetDescriptor(
                 return
             end
             self[117] = healingInterval
-            local ____opt_52 = self._timer
-            local elapsed = ____opt_52 and ____opt_52.elapsed or 0
+            local ____opt_50 = self._timer
+            local elapsed = ____opt_50 and ____opt_50.elapsed or 0
             local timer = self[119]
             if timer == nil then
                 timer = Timer:create()
@@ -976,11 +955,11 @@ __TS__SetDescriptor(
     "turnsIntoGhost",
     {
         get = function(self)
-            local ____self__135_54 = self[135]
-            if ____self__135_54 == nil then
-                ____self__135_54 = false
+            local ____self__135_52 = self[135]
+            if ____self__135_52 == nil then
+                ____self__135_52 = false
             end
-            return ____self__135_54
+            return ____self__135_52
         end,
         set = function(self, turnsIntoGhost)
             if not turnsIntoGhost and self[135] then
@@ -999,22 +978,22 @@ __TS__SetDescriptor(
     "stuns",
     {
         get = function(self)
-            local ____self__136_55 = self[136]
-            if ____self__136_55 == nil then
-                ____self__136_55 = false
+            local ____self__136_53 = self[136]
+            if ____self__136_53 == nil then
+                ____self__136_53 = false
             end
-            return ____self__136_55
+            return ____self__136_53
         end,
         set = function(self, stuns)
             if not stuns and self[136] then
                 if self[137] then
-                    self.object:decrementStunCounter()
+                    self.object:decrementForceStunCounter()
                 end
                 self.object:decrementStunCounter()
                 self[136] = nil
             elseif stuns and not self[136] then
                 if self[137] then
-                    self.object:incrementStunCounter()
+                    self.object:incrementForceStunCounter()
                 end
                 self.object:incrementStunCounter()
                 self[136] = true
@@ -1028,21 +1007,21 @@ __TS__SetDescriptor(
     "ignoresStunImmunity",
     {
         get = function(self)
-            local ____self__137_56 = self[137]
-            if ____self__137_56 == nil then
-                ____self__137_56 = false
+            local ____self__137_54 = self[137]
+            if ____self__137_54 == nil then
+                ____self__137_54 = false
             end
-            return ____self__137_56
+            return ____self__137_54
         end,
         set = function(self, ignoresStunImmunity)
             if not ignoresStunImmunity and self[137] then
                 if self[136] then
-                    self.object:decrementStunCounter()
+                    self.object:decrementForceStunCounter()
                 end
                 self[137] = nil
             elseif ignoresStunImmunity and not self[137] then
                 if self[136] then
-                    self.object:incrementStunCounter()
+                    self.object:incrementForceStunCounter()
                 end
                 self[137] = true
             end
@@ -1055,11 +1034,11 @@ __TS__SetDescriptor(
     "disablesAutoAttack",
     {
         get = function(self)
-            local ____self__138_57 = self[138]
-            if ____self__138_57 == nil then
-                ____self__138_57 = false
+            local ____self__138_55 = self[138]
+            if ____self__138_55 == nil then
+                ____self__138_55 = false
             end
-            return ____self__138_57
+            return ____self__138_55
         end,
         set = function(self, disablesAutoAttack)
             if not disablesAutoAttack and self[138] then
@@ -1078,11 +1057,11 @@ __TS__SetDescriptor(
     "providesInvulnerability",
     {
         get = function(self)
-            local ____self__139_58 = self[139]
-            if ____self__139_58 == nil then
-                ____self__139_58 = false
+            local ____self__139_56 = self[139]
+            if ____self__139_56 == nil then
+                ____self__139_56 = false
             end
-            return ____self__139_58
+            return ____self__139_56
         end,
         set = function(self, providesInvulnerability)
             if not providesInvulnerability and self[139] then
@@ -1101,11 +1080,11 @@ __TS__SetDescriptor(
     "killsOnExpiration",
     {
         get = function(self)
-            local ____self__140_59 = self[140]
-            if ____self__140_59 == nil then
-                ____self__140_59 = false
+            local ____self__140_57 = self[140]
+            if ____self__140_57 == nil then
+                ____self__140_57 = false
             end
-            return ____self__140_59
+            return ____self__140_57
         end,
         set = function(self, killsOnExpiration)
             if not killsOnExpiration and self[140] then
@@ -1122,11 +1101,11 @@ __TS__SetDescriptor(
     "explodesOnExpiration",
     {
         get = function(self)
-            local ____self__141_60 = self[141]
-            if ____self__141_60 == nil then
-                ____self__141_60 = false
+            local ____self__141_58 = self[141]
+            if ____self__141_58 == nil then
+                ____self__141_58 = false
             end
-            return ____self__141_60
+            return ____self__141_58
         end,
         set = function(self, killsOnExpiration)
             if not killsOnExpiration and self[141] then
@@ -1254,13 +1233,13 @@ __TS__SetDescriptor(
     "remainingDuration",
     {
         get = function(self)
-            local ____opt_61 = self._timer
-            return ____opt_61 and ____opt_61.remaining or 0
+            local ____opt_59 = self._timer
+            return ____opt_59 and ____opt_59.remaining or 0
         end,
         set = function(self, remainingDuration)
-            local ____remainingDuration_65 = remainingDuration
-            local ____opt_63 = self._timer
-            local remainingDurationDelta = ____remainingDuration_65 - (____opt_63 and ____opt_63.remaining or 0)
+            local ____remainingDuration_63 = remainingDuration
+            local ____opt_61 = self._timer
+            local remainingDurationDelta = ____remainingDuration_63 - (____opt_61 and ____opt_61.remaining or 0)
             if remainingDurationDelta ~= 0 then
                 self[103] = self[103] + remainingDurationDelta
                 if remainingDuration <= 0 then

package/engine/internal/ability.d.ts

@@ -1,5 +1,5 @@
 /** @noSelfInFile */
-import { Handle } from "../../core/types/handle";
+import { Handle, HandleDestructor } from "../../core/types/handle";
 import { Event } from "../../event";
 import type { Item } from "../../core/types/item";
 import type { Unit } from "./unit";
@@ -67,6 +67,7 @@ export declare class UnitAbility extends Ability {
     get cooldownRemaining(): number;
     set cooldownRemaining(cooldownRemaining: number);
     interruptCast(): void;
+    protected onDestroy(): HandleDestructor;
     static get onCreate(): Event<[UnitAbility]>;
     static get onDestroy(): Event<[UnitAbility]>;
 }
@@ -93,6 +94,7 @@ export declare class ItemAbility extends Ability {
     get cooldownRemaining(): number;
     set cooldownRemaining(cooldownRemaining: number);
     interruptCast(): void;
+    protected onDestroy(): HandleDestructor;
     static get onCreate(): Event<[ItemAbility]>;
     static get onDestroy(): Event<[ItemAbility]>;
 }