warscript 0.0.1-dev.e4a5fce → 0.0.1-dev.e6c3dde

package/engine/behaviour/ability/apply-buff.d.ts

@@ -33,4 +33,9 @@ export declare class ApplyBuffTargetAreaAbilityBehavior<T extends BuffConstructo
     onPointTargetImpact(caster: Unit, x: number, y: number): void;
     onWidgetTargetImpact(caster: Unit, target: Widget): void;
 }
+export declare class ApplyBuffChannelingTargetAbilityBehavior<T extends BuffConstructor = typeof Buff> extends ApplyBuffAbilityBehavior<T> {
+    private buff?;
+    onUnitTargetChannelingStart(caster: Unit, target: Unit): void;
+    onStop(): void;
+}
 export {};

package/engine/behaviour/ability/apply-buff.lua

@@ -123,4 +123,36 @@ function ApplyBuffTargetAreaAbilityBehavior.prototype.onWidgetTargetImpact(self,
         self.applyBuff(unit)
     end
 end
+local behaviorByBuff = {}
+____exports.ApplyBuffChannelingTargetAbilityBehavior = __TS__Class()
+local ApplyBuffChannelingTargetAbilityBehavior = ____exports.ApplyBuffChannelingTargetAbilityBehavior
+ApplyBuffChannelingTargetAbilityBehavior.name = "ApplyBuffChannelingTargetAbilityBehavior"
+__TS__ClassExtends(ApplyBuffChannelingTargetAbilityBehavior, ____exports.ApplyBuffAbilityBehavior)
+function ApplyBuffChannelingTargetAbilityBehavior.prototype.onUnitTargetChannelingStart(self, caster, target)
+    local previousBuff = self.buff
+    if previousBuff ~= nil then
+        behaviorByBuff[previousBuff] = nil
+        previousBuff:destroy()
+    end
+    local buff = self.applyBuff(target)
+    if buff ~= nil then
+        behaviorByBuff[buff] = self
+    end
+    self.buff = buff
+end
+function ApplyBuffChannelingTargetAbilityBehavior.prototype.onStop(self)
+    local buff = self.buff
+    if buff ~= nil then
+        behaviorByBuff[buff] = nil
+        buff:destroy()
+        self.buff = nil
+    end
+end
+Buff.beingDestroyedEvent:addListener(function(buff)
+    local behavior = behaviorByBuff[buff]
+    if behavior ~= nil then
+        behaviorByBuff[buff] = nil
+        behavior.ability:interruptCast()
+    end
+end)
 return ____exports

package/engine/behaviour/ability/apply-unit-behavior.lua

@@ -41,6 +41,7 @@ function ApplyUnitBehaviorAbilityBehavior.prototype.onUnitGainAbility(self, unit
         ____opt_0:destroy()
     end
     self.unitBehavior = __TS__New(self.unitBehaviorConstructor, unit)
+    self.unitBehavior.sourceAbilityBehavior = self
     self:update()
 end
 function ApplyUnitBehaviorAbilityBehavior.prototype.onUnitLoseAbility(self)

package/engine/behaviour/ability/damage.d.ts

@@ -4,23 +4,29 @@ import { Ability } from "../../internal/ability";
 import { Unit } from "../../internal/unit";
 import { AbilityDependentValue } from "../../object-field/ability";
 import { Widget } from "../../../core/types/widget";
-import { AttackType, DamageType, WeaponType } from "../../internal/unit+damage";
+import { DamageType, WeaponType } from "../../internal/unit+damage";
+import { CombatClassifications } from "../../object-data/auxiliary/combat-classification";
+import { AttackType } from "../../object-data/auxiliary/attack-type";
 export type DamageAbilityBehaviorParameters = {
     damagePerStrength?: AbilityDependentValue<number>;
     damagePerAgility?: AbilityDependentValue<number>;
     damagePerIntelligence?: AbilityDependentValue<number>;
-    attackType?: AttackType;
+    attackType?: AbilityDependentValue<AttackType>;
     damageType?: DamageType;
     weaponType?: WeaponType;
+    metadata?: AbilityDependentValue<string | number | boolean>;
 };
 export type DamageAreaAbilityBehaviorParameters = DamageAbilityBehaviorParameters & {
     maximumDamage?: AbilityDependentValue<number>;
+    areaOfEffect?: AbilityDependentValue<number>;
+    allowedTargetCombatClassifications?: AbilityDependentValue<CombatClassifications>;
 };
-declare abstract class DamageAbilityBehavior<T extends DamageAbilityBehaviorParameters = DamageAbilityBehaviorParameters> extends AbilityBehavior {
+export declare abstract class DamageAbilityBehavior<T extends DamageAbilityBehaviorParameters = DamageAbilityBehaviorParameters> extends AbilityBehavior {
     protected readonly damage: AbilityDependentValue<number>;
     protected readonly parameters?: T | undefined;
     protected constructor(ability: Ability, damage: AbilityDependentValue<number>, parameters?: T | undefined);
     protected calculateDamage(caster: Unit): number;
+    protected damageTarget(caster: Unit, target: Widget, damage?: number): void;
 }
 export declare class DamageSelfAbilityBehavior extends DamageAbilityBehavior {
     constructor(ability: Ability, damage: AbilityDependentValue<number>, parameters?: DamageAbilityBehaviorParameters);

package/engine/behaviour/ability/damage.lua

@@ -9,7 +9,8 @@ local Unit = ____unit.Unit
 local ____ability = require("engine.standard.fields.ability")
 local ALLOWED_TARGETS_ABILITY_COMBAT_CLASSIFICATIONS_LEVEL_FIELD = ____ability.ALLOWED_TARGETS_ABILITY_COMBAT_CLASSIFICATIONS_LEVEL_FIELD
 local AREA_OF_EFFECT_ABILITY_FLOAT_LEVEL_FIELD = ____ability.AREA_OF_EFFECT_ABILITY_FLOAT_LEVEL_FIELD
-local DamageAbilityBehavior = __TS__Class()
+____exports.DamageAbilityBehavior = __TS__Class()
+local DamageAbilityBehavior = ____exports.DamageAbilityBehavior
 DamageAbilityBehavior.name = "DamageAbilityBehavior"
 __TS__ClassExtends(DamageAbilityBehavior, AbilityBehavior)
 function DamageAbilityBehavior.prototype.____constructor(self, ability, damage, parameters)
@@ -34,58 +35,53 @@ function DamageAbilityBehavior.prototype.calculateDamage(self, caster)
     end
     return damage
 end
-____exports.DamageSelfAbilityBehavior = __TS__Class()
-local DamageSelfAbilityBehavior = ____exports.DamageSelfAbilityBehavior
-DamageSelfAbilityBehavior.name = "DamageSelfAbilityBehavior"
-__TS__ClassExtends(DamageSelfAbilityBehavior, DamageAbilityBehavior)
-function DamageSelfAbilityBehavior.prototype.____constructor(self, ability, damage, parameters)
-    DamageAbilityBehavior.prototype.____constructor(self, ability, damage, parameters)
-end
-function DamageSelfAbilityBehavior.prototype.onImpact(self, caster)
+function DamageAbilityBehavior.prototype.damageTarget(self, caster, target, damage)
     local parameters = self.parameters
     caster:damageTarget(
-        caster,
-        self:calculateDamage(caster),
+        target,
+        damage or self:calculateDamage(caster),
         nil,
         nil,
-        parameters and parameters.attackType,
+        self:resolveCurrentAbilityDependentValue(parameters and parameters.attackType),
         parameters and parameters.damageType,
-        parameters and parameters.weaponType
+        parameters and parameters.weaponType,
+        self:resolveCurrentAbilityDependentValue(parameters and parameters.metadata)
     )
 end
+____exports.DamageSelfAbilityBehavior = __TS__Class()
+local DamageSelfAbilityBehavior = ____exports.DamageSelfAbilityBehavior
+DamageSelfAbilityBehavior.name = "DamageSelfAbilityBehavior"
+__TS__ClassExtends(DamageSelfAbilityBehavior, ____exports.DamageAbilityBehavior)
+function DamageSelfAbilityBehavior.prototype.____constructor(self, ability, damage, parameters)
+    DamageSelfAbilityBehavior.____super.prototype.____constructor(self, ability, damage, parameters)
+end
+function DamageSelfAbilityBehavior.prototype.onImpact(self, caster)
+    self:damageTarget(caster, caster)
+end
 ____exports.DamageTargetAbilityBehavior = __TS__Class()
 local DamageTargetAbilityBehavior = ____exports.DamageTargetAbilityBehavior
 DamageTargetAbilityBehavior.name = "DamageTargetAbilityBehavior"
-__TS__ClassExtends(DamageTargetAbilityBehavior, DamageAbilityBehavior)
+__TS__ClassExtends(DamageTargetAbilityBehavior, ____exports.DamageAbilityBehavior)
 function DamageTargetAbilityBehavior.prototype.____constructor(self, ability, damage, parameters)
-    DamageAbilityBehavior.prototype.____constructor(self, ability, damage, parameters)
+    DamageTargetAbilityBehavior.____super.prototype.____constructor(self, ability, damage, parameters)
 end
 function DamageTargetAbilityBehavior.prototype.onWidgetTargetImpact(self, caster, target)
-    local parameters = self.parameters
-    caster:damageTarget(
-        target,
-        self:calculateDamage(caster),
-        nil,
-        nil,
-        parameters and parameters.attackType,
-        parameters and parameters.damageType,
-        parameters and parameters.weaponType
-    )
+    self:damageTarget(caster, target)
 end
 local DamageAreaAbilityBehavior = __TS__Class()
 DamageAreaAbilityBehavior.name = "DamageAreaAbilityBehavior"
-__TS__ClassExtends(DamageAreaAbilityBehavior, DamageAbilityBehavior)
+__TS__ClassExtends(DamageAreaAbilityBehavior, ____exports.DamageAbilityBehavior)
 function DamageAreaAbilityBehavior.prototype.____constructor(self, ability, damage, parameters)
-    DamageAbilityBehavior.prototype.____constructor(self, ability, damage, parameters)
+    DamageAreaAbilityBehavior.____super.prototype.____constructor(self, ability, damage, parameters)
 end
 function DamageAreaAbilityBehavior.prototype.damageArea(self, caster, x, y)
     local parameters = self.parameters
     local targets = Unit.getAllowedTargetsInCollisionRange(
         caster,
-        self:resolveCurrentAbilityDependentValue(ALLOWED_TARGETS_ABILITY_COMBAT_CLASSIFICATIONS_LEVEL_FIELD),
+        self:resolveCurrentAbilityDependentValue(parameters and parameters.allowedTargetCombatClassifications or ALLOWED_TARGETS_ABILITY_COMBAT_CLASSIFICATIONS_LEVEL_FIELD),
         x,
         y,
-        self:resolveCurrentAbilityDependentValue(AREA_OF_EFFECT_ABILITY_FLOAT_LEVEL_FIELD)
+        self:resolveCurrentAbilityDependentValue(parameters and parameters.areaOfEffect or AREA_OF_EFFECT_ABILITY_FLOAT_LEVEL_FIELD)
     )
     local damage = self:calculateDamage(caster)
     local maximumDamage = self:resolveCurrentAbilityDependentValue(parameters and parameters.maximumDamage or 0)
@@ -93,15 +89,7 @@ function DamageAreaAbilityBehavior.prototype.damageArea(self, caster, x, y)
         damage = maximumDamage / #targets
     end
     for ____, target in ipairs(targets) do
-        caster:damageTarget(
-            target,
-            damage,
-            nil,
-            nil,
-            parameters and parameters.attackType,
-            parameters and parameters.damageType,
-            parameters and parameters.weaponType
-        )
+        self:damageTarget(caster, target, damage)
     end
 end
 ____exports.DamageSelfAreaAbilityBehavior = __TS__Class()

package/engine/behaviour/ability/emulate-impact.lua

@@ -1,30 +1,42 @@
 local ____lualib = require("lualib_bundle")
 local __TS__Class = ____lualib.__TS__Class
 local __TS__ClassExtends = ____lualib.__TS__ClassExtends
+local __TS__InstanceOf = ____lualib.__TS__InstanceOf
 local ____exports = {}
 local ____ability = require("engine.behaviour.ability")
 local AbilityBehavior = ____ability.AbilityBehavior
+local ____unit = require("engine.internal.unit")
+local Unit = ____unit.Unit
 local ____ability = require("engine.standard.fields.ability")
 local COOLDOWN_ABILITY_FLOAT_LEVEL_FIELD = ____ability.COOLDOWN_ABILITY_FLOAT_LEVEL_FIELD
 local MANA_COST_ABILITY_INTEGER_LEVEL_FIELD = ____ability.MANA_COST_ABILITY_INTEGER_LEVEL_FIELD
+local ____math = require("math")
+local max = ____math.max
+local MINIMUM_POSITIVE_NORMALIZED_FLOAT = ____math.MINIMUM_POSITIVE_NORMALIZED_FLOAT
+local ____sound = require("core.types.sound")
+local Sound3D = ____sound.Sound3D
+local SoundSettings = ____sound.SoundSettings
+local ____ability = require("engine.internal.ability")
+local UnitAbility = ____ability.UnitAbility
+local ____event = require("event")
+local Event = ____event.Event
 ____exports.EmulateImpactAbilityBehavior = __TS__Class()
 local EmulateImpactAbilityBehavior = ____exports.EmulateImpactAbilityBehavior
 EmulateImpactAbilityBehavior.name = "EmulateImpactAbilityBehavior"
 __TS__ClassExtends(EmulateImpactAbilityBehavior, AbilityBehavior)
 function EmulateImpactAbilityBehavior.prototype.emulateImpact(self, caster)
-    local abilityTypeId = self.ability.typeId
     local manaCost = self:resolveCurrentAbilityDependentValue(MANA_COST_ABILITY_INTEGER_LEVEL_FIELD)
     local cooldown = self:resolveCurrentAbilityDependentValue(COOLDOWN_ABILITY_FLOAT_LEVEL_FIELD)
-    if caster:getAbilityRemainingCooldown(abilityTypeId) ~= 0 or caster.mana < manaCost then
+    if self.ability.cooldownRemaining ~= 0 or caster.mana < manaCost or __TS__InstanceOf(self.ability, UnitAbility) and self.ability.isDisabled then
         return
     end
     caster.mana = caster.mana - manaCost
-    if cooldown == 0 then
-        caster:interruptCast(self.ability.typeId)
-    else
-        caster:startAbilityCooldown(self.ability.typeId, cooldown)
-    end
+    self.ability.cooldownRemaining = max(cooldown, MINIMUM_POSITIVE_NORMALIZED_FLOAT)
     self:flashCasterEffect(caster)
-    AbilityBehavior:forAll(self.ability, "onImpact", caster)
+    local soundPresetId = self.ability:getField(ABILITY_SF_EFFECT_SOUND)
+    if soundPresetId ~= "" then
+        Sound3D:playFromLabel(soundPresetId, SoundSettings.Ability, caster)
+    end
+    Event.invoke(Unit.abilityImpactEvent, caster, self.ability)
 end
 return ____exports

package/engine/behaviour/ability/on-command-impact.lua

@@ -2,6 +2,8 @@ local ____lualib = require("lualib_bundle")
 local __TS__Class = ____lualib.__TS__Class
 local __TS__ClassExtends = ____lualib.__TS__ClassExtends
 local ____exports = {}
+local ____unit = require("engine.internal.unit")
+local Unit = ____unit.Unit
 local ____emulate_2Dimpact = require("engine.behaviour.ability.emulate-impact")
 local EmulateImpactAbilityBehavior = ____emulate_2Dimpact.EmulateImpactAbilityBehavior
 ____exports.OnCommandImpactAbilityBehavior = __TS__Class()
@@ -15,4 +17,9 @@ end
 function OnCommandImpactAbilityBehavior.prototype.onCommand(self, caster)
     self:emulateImpact(caster)
 end
+Unit.itemUseOrderEvent:addListener(function(unit, item)
+    for ____, ability in ipairs(item.abilities) do
+        ____exports.OnCommandImpactAbilityBehavior:forAll(ability, "onCommand", unit)
+    end
+end)
 return ____exports

package/engine/behaviour/ability.d.ts

@@ -7,7 +7,8 @@ import { Widget } from "../../core/types/widget";
 import { Item } from "../internal/item";
 import { Destructable } from "../../core/types/destructable";
 import { EffectParameters } from "../../core/types/effect";
-import { AbilityDependentValue } from "../object-field/ability";
+import { AbilityDependentValue, ReadonlySubscribableAbilityDependentValue, SubscribableAbilityDependentValue } from "../object-field/ability";
+import { Destructor } from "../../destroyable";
 export type AbilityBehaviorConstructor<Args extends any[]> = new (ability: Ability, ...args: Args) => AbilityBehavior;
 export type AbilityBehaviorParameters = {
     isExclusiveOnImpactHandler?: boolean;
@@ -17,17 +18,25 @@ export declare abstract class AbilityBehavior<Parameters extends {
     missileParameters?: any[];
 } = {}> extends Behavior<Ability, NonNullable<Parameters["periodicActionParameters"]>> {
     constructor(ability: Ability, parameters?: AbilityBehaviorParameters);
+    protected onDestroy(): Destructor;
+    protected subscribe<T extends boolean | number | string>(value: SubscribableAbilityDependentValue<T>): void;
     protected registerCommandEvent(orderTypeStringId?: string): void;
     get ability(): Ability;
+    get unit(): Unit | undefined;
     protected resolveCurrentAbilityDependentValue<T extends boolean | number | string>(value: AbilityDependentValue<T>): T;
     protected resolveCurrentAbilityDependentValue<T extends boolean | number | string>(value?: AbilityDependentValue<T>): T | undefined;
-    protected flashCasterEffect(widget: Widget): void;
+    protected flashCasterEffect(widget: Widget, ...parametersOrDuration: [parameters?: EffectParameters] | [duration?: number, parameters?: EffectParameters]): void;
+    protected flashTargetEffect(widget: Widget, ...parametersOrDuration: [parameters?: EffectParameters] | [duration?: number, parameters?: EffectParameters]): void;
     protected flashAreaEffect(x: number, y: number, ...parametersOrDuration: [parameters?: EffectParameters] | [duration?: number, parameters?: EffectParameters]): void;
     protected flashEffect(x: number, y: number, ...parametersOrDuration: [parameters?: EffectParameters] | [duration?: number, parameters?: EffectParameters]): void;
-    protected flashSpecialEffect(...args: [...pointOrWidget: [x: number, y: number] | [widget: Widget], duration?: number]): void;
+    protected flashSpecialEffect(...args: [
+        ...pointOrWidget: [x: number, y: number] | [widget: Widget],
+        ...parametersOrDuration: [parameters?: EffectParameters] | [duration?: number, parameters?: EffectParameters]
+    ]): void;
     private static MissileLaunchConfig;
     private get missileLaunchConfig();
     protected onCreate(): void;
+    onValueChange(_value: ReadonlySubscribableAbilityDependentValue<string | number | boolean>): void;
     onMissileArrival(...parameters: NonNullable<Parameters["missileParameters"]>): void;
     onUnitGainAbility(_unit: Unit): void;
     onUnitLoseAbility(_unit: Unit): void;

package/engine/behaviour/ability.lua

@@ -1,10 +1,10 @@
 local ____lualib = require("lualib_bundle")
 local __TS__Class = ____lualib.__TS__Class
 local __TS__ClassExtends = ____lualib.__TS__ClassExtends
+local __TS__InstanceOf = ____lualib.__TS__InstanceOf
 local __TS__New = ____lualib.__TS__New
 local __TS__SetDescriptor = ____lualib.__TS__SetDescriptor
 local ____exports = {}
-local createUnitEventListener
 local ____behavior = require("engine.behavior")
 local Behavior = ____behavior.Behavior
 local ____unit = require("engine.unit")
@@ -23,24 +23,21 @@ local MISSILE_MODEL_PATHS_ABILITY_STRING_ARRAY_FIELD = ____ability.MISSILE_MODEL
 local MISSILE_SPEED_ABILITY_INTEGER_FIELD = ____ability.MISSILE_SPEED_ABILITY_INTEGER_FIELD
 local SPECIAL_EFFECT_ATTACHMENT_POINT_STRING_FIELD = ____ability.SPECIAL_EFFECT_ATTACHMENT_POINT_STRING_FIELD
 local SPECIAL_EFFECT_MODEL_PATHS_ABILITY_STRING_ARRAY_FIELD = ____ability.SPECIAL_EFFECT_MODEL_PATHS_ABILITY_STRING_ARRAY_FIELD
+local TARGET_EFFECT_FIRST_ATTACHMENT_POINT_STRING_FIELD = ____ability.TARGET_EFFECT_FIRST_ATTACHMENT_POINT_STRING_FIELD
+local TARGET_EFFECT_MODEL_PATHS_ABILITY_STRING_ARRAY_FIELD = ____ability.TARGET_EFFECT_MODEL_PATHS_ABILITY_STRING_ARRAY_FIELD
 local ____ability = require("engine.object-field.ability")
+local AbilityField = ____ability.AbilityField
+local AbilityLevelField = ____ability.AbilityLevelField
 local resolveCurrentAbilityDependentValue = ____ability.resolveCurrentAbilityDependentValue
-local ____timer = require("core.types.timer")
-local Timer = ____timer.Timer
 local createBehaviorFunctionsByAbilityTypeId = {}
 local exclusiveOnImpactHandlerAbilityBehaviorByAbility = setmetatable({}, {__mode = "k"})
-local function createZeroTimerUnitEventListener(key)
-    local unitEventListener = createUnitEventListener(key)
-    return function(unit, ability, ...)
-        Timer:run(unitEventListener, unit, ability, ...)
-    end
-end
-createUnitEventListener = function(key)
+local function createUnitEventListener(key)
     return function(unit, ability, ...)
         ____exports.AbilityBehavior:forAll(ability, key, unit, ...)
     end
 end
 local registeredCommandEventIds = {}
+local subscribedValuesByAbilityBehavior = {}
 local ____class_2 = __TS__Class()
 ____class_2.name = ""
 function ____class_2.prototype.____constructor(self, abilityBehavior)
@@ -81,6 +78,20 @@ function AbilityBehavior.prototype.____constructor(self, ability, parameters)
     end
     self:onCreate()
 end
+function AbilityBehavior.prototype.onDestroy(self)
+    subscribedValuesByAbilityBehavior[self] = nil
+    return Behavior.prototype.onDestroy(self)
+end
+function AbilityBehavior.prototype.subscribe(self, value)
+    if __TS__InstanceOf(value, AbilityField) or __TS__InstanceOf(value, AbilityLevelField) then
+        local subscribedValues = subscribedValuesByAbilityBehavior[self]
+        if subscribedValues == nil then
+            subscribedValues = {}
+            subscribedValuesByAbilityBehavior[self] = subscribedValues
+        end
+        subscribedValues[value] = true
+    end
+end
 function AbilityBehavior.prototype.registerCommandEvent(self, orderTypeStringId)
     if orderTypeStringId == nil then
         orderTypeStringId = self.ability.orderTypeStringId
@@ -94,12 +105,22 @@ end
 function AbilityBehavior.prototype.resolveCurrentAbilityDependentValue(self, value)
     return resolveCurrentAbilityDependentValue(self.ability, value)
 end
-function AbilityBehavior.prototype.flashCasterEffect(self, widget)
+function AbilityBehavior.prototype.flashCasterEffect(self, widget, ...)
     local attachmentPoint = CASTER_EFFECT_FIRST_ATTACHMENT_POINT_STRING_FIELD:getValue(self.ability)
     Effect:flash(
         CASTER_EFFECT_MODEL_PATHS_ABILITY_STRING_ARRAY_FIELD:getValue(self.ability, 0),
         widget,
-        attachmentPoint ~= "" and attachmentPoint or "origin"
+        attachmentPoint ~= "" and attachmentPoint or "origin",
+        ...
+    )
+end
+function AbilityBehavior.prototype.flashTargetEffect(self, widget, ...)
+    local attachmentPoint = TARGET_EFFECT_FIRST_ATTACHMENT_POINT_STRING_FIELD:getValue(self.ability)
+    Effect:flash(
+        TARGET_EFFECT_MODEL_PATHS_ABILITY_STRING_ARRAY_FIELD:getValue(self.ability, 0),
+        widget,
+        attachmentPoint ~= "" and attachmentPoint or "origin",
+        ...
     )
 end
 function AbilityBehavior.prototype.flashAreaEffect(self, x, y, ...)
@@ -118,25 +139,30 @@ function AbilityBehavior.prototype.flashEffect(self, x, y, ...)
         ...
     )
 end
-function AbilityBehavior.prototype.flashSpecialEffect(self, xOrWidget, yOrDuration, duration)
+function AbilityBehavior.prototype.flashSpecialEffect(self, xOrWidget, yOrParametersOrDuration, durationOrParameters, parameters)
     if type(xOrWidget) == "number" then
         Effect:flash(
             SPECIAL_EFFECT_MODEL_PATHS_ABILITY_STRING_ARRAY_FIELD:getValue(self.ability, 0),
             xOrWidget,
-            yOrDuration,
-            duration
+            yOrParametersOrDuration,
+            durationOrParameters,
+            parameters
         )
     else
+        local attachmentPoint = SPECIAL_EFFECT_ATTACHMENT_POINT_STRING_FIELD:getValue(self.ability)
         Effect:flash(
             SPECIAL_EFFECT_MODEL_PATHS_ABILITY_STRING_ARRAY_FIELD:getValue(self.ability, 0),
             xOrWidget,
-            SPECIAL_EFFECT_ATTACHMENT_POINT_STRING_FIELD:getValue(self.ability),
-            yOrDuration
+            attachmentPoint ~= "" and attachmentPoint or "origin",
+            yOrParametersOrDuration,
+            durationOrParameters
         )
     end
 end
 function AbilityBehavior.prototype.onCreate(self)
 end
+function AbilityBehavior.prototype.onValueChange(self, _value)
+end
 function AbilityBehavior.prototype.onMissileArrival(self, ...)
 end
 function AbilityBehavior.prototype.onUnitGainAbility(self, _unit)
@@ -204,6 +230,18 @@ __TS__SetDescriptor(
     end},
     true
 )
+__TS__SetDescriptor(
+    AbilityBehavior.prototype,
+    "unit",
+    {get = function(self)
+        local owner = self.object.owner
+        if __TS__InstanceOf(owner, Unit) then
+            return owner
+        end
+        return owner.owner
+    end},
+    true
+)
 AbilityBehavior.MissileLaunchConfig = ____class_2
 __TS__SetDescriptor(
     AbilityBehavior.prototype,
@@ -227,16 +265,28 @@ __TS__SetDescriptor(
     Unit.abilityDestructibleTargetChannelingStartEvent:addListener(createUnitEventListener("onDestructibleTargetChannelingStart"))
     Unit.abilityPointTargetChannelingStartEvent:addListener(createUnitEventListener("onPointTargetChannelingStart"))
     Unit.abilityNoTargetChannelingStartEvent:addListener(createUnitEventListener("onNoTargetChannelingStart"))
-    Unit.abilityChannelingStartEvent:addListener(createZeroTimerUnitEventListener("onImpact"))
-    Unit.abilityWidgetTargetChannelingStartEvent:addListener(createZeroTimerUnitEventListener("onWidgetTargetImpact"))
-    Unit.abilityUnitTargetChannelingStartEvent:addListener(createZeroTimerUnitEventListener("onUnitTargetImpact"))
-    Unit.abilityItemTargetChannelingStartEvent:addListener(createZeroTimerUnitEventListener("onItemTargetImpact"))
-    Unit.abilityDestructibleTargetChannelingStartEvent:addListener(createZeroTimerUnitEventListener("onDestructibleTargetImpact"))
-    Unit.abilityPointTargetChannelingStartEvent:addListener(createZeroTimerUnitEventListener("onPointTargetImpact"))
-    Unit.abilityNoTargetChannelingStartEvent:addListener(createZeroTimerUnitEventListener("onNoTargetImpact"))
+    Unit.abilityImpactEvent:addListener(createUnitEventListener("onImpact"))
+    Unit.abilityWidgetTargetImpactEvent:addListener(createUnitEventListener("onWidgetTargetImpact"))
+    Unit.abilityUnitTargetImpactEvent:addListener(createUnitEventListener("onUnitTargetImpact"))
+    Unit.abilityItemTargetImpactEvent:addListener(createUnitEventListener("onItemTargetImpact"))
+    Unit.abilityDestructibleTargetImpactEvent:addListener(createUnitEventListener("onDestructibleTargetImpact"))
+    Unit.abilityPointTargetImpactEvent:addListener(createUnitEventListener("onPointTargetImpact"))
+    Unit.abilityNoTargetImpactEvent:addListener(createUnitEventListener("onNoTargetImpact"))
     Unit.abilityChannelingFinishEvent:addListener(createUnitEventListener("onChannelingFinish"))
     Unit.abilityStopEvent:addListener(createUnitEventListener("onStop"))
 end)(AbilityBehavior)
+local function checkBehaviorOnValueChange(behavior, field)
+    local subscribedValues = subscribedValuesByAbilityBehavior[behavior]
+    if subscribedValues ~= nil and subscribedValues[field] ~= nil then
+        behavior:onValueChange(field)
+    end
+end
+AbilityField.valueChangeEvent:addListener(function(ability, field)
+    ____exports.AbilityBehavior:forAll(ability, checkBehaviorOnValueChange, field)
+end)
+AbilityLevelField.valueChangeEvent:addListener(function(ability, field)
+    ____exports.AbilityBehavior:forAll(ability, checkBehaviorOnValueChange, field)
+end)
 Ability.onCreate:addListener(function(ability)
     local createBehaviorFunctions = createBehaviorFunctionsByAbilityTypeId[ability.typeId]
     if createBehaviorFunctions ~= nil then

package/engine/behaviour/unit/stun-immunity.d.ts

@@ -10,9 +10,11 @@ export type StunImmunityUnitBehaviourParameters = {
     textTagText?: string;
 };
 export declare class StunImmunityUnitBehavior extends UnitBehavior {
-    private readonly parameters;
+    readonly parameters: Readonly<StunImmunityUnitBehaviourParameters>;
     static defaultParameters: StunImmunityUnitBehaviourParameters;
-    constructor(unit: Unit, parameters?: StunImmunityUnitBehaviourParameters);
+    constructor(unit: Unit, parameters?: Readonly<StunImmunityUnitBehaviourParameters>);
     protected onDestroy(): Destructor;
-    private onBuffsCheck;
+    onDamageReceived(): void;
+    onTargetingAbilityChannelingStart(): void;
+    onTargetingAbilityImpact(): void;
 }

package/engine/behaviour/unit/stun-immunity.lua

@@ -12,31 +12,46 @@ local flatMapToLuaSet = ____arrays.flatMapToLuaSet
 local map = ____arrays.map
 local ____text_2Dtag = require("engine.text-tag")
 local TextTag = ____text_2Dtag.TextTag
+local ____timer = require("core.types.timer")
+local Timer = ____timer.Timer
 local DEFAULT_BUFF_TYPE_IDS = postcompile(function()
     return flatMapToLuaSet(
         AbilityType:getAllByBaseIds(map({
-            "Aslo",
-            "AHtc",
-            "Aens",
-            "Aprg",
-            "Apg2",
-            "AOeq",
-            "SNeq",
-            "Aweb",
-            "Afra",
-            "Afrb",
-            "Afrc",
-            "Afr2",
-            "Acri",
-            "Scri",
-            "AUfn",
-            "Aspo",
-            "AEer",
-            "ACwb"
+            "AHtb",
+            "AHbh",
+            "AOws",
+            "AOw2",
+            "AUim",
+            "Acyc",
+            "ANfb",
+            "ANsb",
+            "ANcs",
+            "ANc1",
+            "ANc2",
+            "ANc3",
+            "ACbh",
+            "ANbh",
+            "SCc1",
+            "ACcy",
+            "ANb2",
+            "Awrs",
+            "Awrh",
+            "Awrg",
+            "ACtb",
+            "ACcb"
         }, fourCC)),
         function(abilityType) return __TS__ArrayFlat(abilityType.buffTypeIds) end
     )
 end)
+local function process(behavior)
+    local hasRemovedBuffs = false
+    for buffTypeId in pairs(behavior.parameters.buffTypeIds or DEFAULT_BUFF_TYPE_IDS) do
+        hasRemovedBuffs = hasRemovedBuffs or behavior.unit:removeBuff(buffTypeId)
+    end
+    if hasRemovedBuffs and behavior.parameters.textTagText ~= nil then
+        TextTag:flash(TextTag.MISS, behavior.parameters.textTagText, behavior.unit.x, behavior.unit.y)
+    end
+end
 ____exports.StunImmunityUnitBehavior = __TS__Class()
 local StunImmunityUnitBehavior = ____exports.StunImmunityUnitBehavior
 StunImmunityUnitBehavior.name = "StunImmunityUnitBehavior"
@@ -48,20 +63,21 @@ function StunImmunityUnitBehavior.prototype.____constructor(self, unit, paramete
     UnitBehavior.prototype.____constructor(self, unit)
     self.parameters = parameters
     unit:decrementStunCounter()
-    self:onBuffsCheck()
+    process(self)
 end
 function StunImmunityUnitBehavior.prototype.onDestroy(self)
     self.unit:incrementStunCounter()
     return UnitBehavior.prototype.onDestroy(self)
 end
-function StunImmunityUnitBehavior.prototype.onBuffsCheck(self)
-    local hasRemovedBuffs = false
-    for buffTypeId in pairs(self.parameters.buffTypeIds or DEFAULT_BUFF_TYPE_IDS) do
-        hasRemovedBuffs = hasRemovedBuffs or self.unit:removeBuff(buffTypeId)
-    end
-    if hasRemovedBuffs and self.parameters.textTagText ~= nil then
-        TextTag:flash(TextTag.MISS, self.parameters.textTagText, self.unit.x, self.unit.y)
-    end
+function StunImmunityUnitBehavior.prototype.onDamageReceived(self)
+    process(self)
+    Timer:run(process, self)
+end
+function StunImmunityUnitBehavior.prototype.onTargetingAbilityChannelingStart(self)
+    process(self)
+end
+function StunImmunityUnitBehavior.prototype.onTargetingAbilityImpact(self)
+    process(self)
 end
 StunImmunityUnitBehavior.defaultParameters = {buffTypeIds = DEFAULT_BUFF_TYPE_IDS, textTagPreset = TextTag.MISS, textTagText = nil}
 return ____exports

package/engine/behaviour/unit.d.ts

@@ -5,22 +5,50 @@ import { DamageEvent, DamagingEvent, Unit } from "../internal/unit";
 import "../internal/unit+ability";
 import "../internal/unit-missile-launch";
 import { Item } from "../internal/item";
+import type { AbilityBehavior } from "./ability";
+import { Event } from "../../event";
+import { Destructor } from "../../destroyable";
+import type { Widget } from "../../core/types/widget";
+import { Destructable } from "../../core/types/destructable";
+import type { Buff } from "../buff";
 export type UnitBehaviorConstructor<Args extends any[]> = new (unit: Unit, ...args: Args) => UnitBehavior;
 export declare abstract class UnitBehavior<PeriodicActionParameters extends any[] = any[]> extends Behavior<Unit, PeriodicActionParameters> {
     constructor(unit: Unit);
+    protected onDestroy(): Destructor;
+    readonly sourceAbilityBehavior?: AbilityBehavior;
     get unit(): Unit;
+    registerInRangeUnitEvent<T extends string, Args extends any[]>(this: UnitBehavior<PeriodicActionParameters> & Record<T, (this: this, unit: Unit, ...args: Args) => unknown>, event: Event<[Unit, ...Args]>, range: number, listener: T): void;
+    onImmediateOrder(orderId: number): void;
+    onTargetOrder(orderId: number, target: Widget): void;
+    onPointOrder(orderId: number, x: number, y: number): void;
     onAutoAttackStart(target: Unit): void;
     onAutoAttackFinish(target: Unit): void;
+    onTargetingAutoAttackStart(source: Unit): void;
+    onTargetingAutoAttackFinish(source: Unit): void;
     onDamageDealing(target: Unit, event: DamagingEvent): void;
     onDamageDealt(target: Unit, event: DamageEvent): void;
     onDamageReceiving(source: Unit | undefined, event: DamagingEvent): void;
     onDamageReceived(source: Unit | undefined, event: DamageEvent): void;
     onAbilityGained(ability: Ability): void;
     onAbilityLost(ability: Ability): void;
+    onAbilityChannelingStart(ability: Ability): void;
+    onAbilityImpact(ability: Ability): void;
+    onAbilityWidgetTargetImpact(ability: Ability, target: Widget): void;
+    onAbilityUnitTargetImpact(ability: Ability, target: Unit): void;
+    onAbilityItemTargetImpact(ability: Ability, target: Item): void;
+    onAbilityDestructibleTargetImpact(ability: Ability, target: Destructable): void;
+    onAbilityPointTargetImpact(ability: Ability, x: number, y: number): void;
+    onAbilityNoTargetImpact(ability: Ability): void;
+    onAbilityChannelingFinish(ability: Ability): void;
+    onAbilityStop(ability: Ability): void;
+    onTargetingAbilityChannelingStart(ability: Ability, source: Unit): void;
+    onTargetingAbilityImpact(ability: Ability, source: Unit): void;
+    onBuffGained(buff: Buff): void;
     onItemDropped(item: Item): void;
     onItemPickedUp(item: Item): void;
     onItemUsed(item: Item): void;
     onItemStacked(item: Item): void;
+    onItemChargesChanged(item: Item): void;
     onKill(target: Unit): void;
     onDeath(source: Unit | undefined): void;
 }