warscript 0.0.1-dev.c60b168 → 0.0.1-dev.c677d41

package/engine/behaviour/unit.lua

@@ -21,36 +21,56 @@ local ____bonus = require("engine.internal.unit.bonus")
 local addOrUpdateOrRemoveUnitBonus = ____bonus.addOrUpdateOrRemoveUnitBonus
 local getUnitBonus = ____bonus.getUnitBonus
 local removeUnitBonus = ____bonus.removeUnitBonus
+local ____linked_2Dmap = require("utility.linked-map")
+local LinkedMap = ____linked_2Dmap.LinkedMap
 local safeCall = warpack.safeCall
-local behaviorsByEvent = {}
-local rangeByBehaviorByEvent = {}
-local listenerByBehaviorByEvent = {}
-local eventsByBehavior = {}
+local createBehaviorFunctionsByUnitTypeId = {}
+local behaviorsByOwningPlayerEvent = {}
+local listenerByBehaviorByOwningPlayerEvent = {}
+local owningPlayerEventsByBehavior = {}
+local behaviorsByInRangeUnitEvent = {}
+local rangeByBehaviorByInRangeUnitEvent = {}
+local listenerByBehaviorByInRangeUnitEvent = {}
+local inRangeUnitEventsByBehavior = {}
 ____exports.UnitBehavior = __TS__Class()
 local UnitBehavior = ____exports.UnitBehavior
 UnitBehavior.name = "UnitBehavior"
 __TS__ClassExtends(UnitBehavior, Behavior)
-function UnitBehavior.prototype.____constructor(self, unit)
-    Behavior.prototype.____constructor(self, unit)
+function UnitBehavior.prototype.____constructor(self, unit, priority)
+    Behavior.prototype.____constructor(self, unit, priority)
 end
 function UnitBehavior.prototype.onDestroy(self)
-    local events = eventsByBehavior[self]
-    if events ~= nil then
-        for event in pairs(events) do
-            local ____opt_0 = behaviorsByEvent[event]
+    local owningPlayerEvents = owningPlayerEventsByBehavior[self]
+    if owningPlayerEvents ~= nil then
+        for event in pairs(owningPlayerEvents) do
+            local ____opt_0 = behaviorsByOwningPlayerEvent[event]
             if ____opt_0 ~= nil then
                 ____opt_0:remove(self)
             end
-            local ____opt_2 = rangeByBehaviorByEvent[event]
+            local ____opt_2 = listenerByBehaviorByOwningPlayerEvent[event]
             if ____opt_2 ~= nil then
                 ____opt_2[self] = nil
             end
-            local ____opt_4 = listenerByBehaviorByEvent[event]
+        end
+        owningPlayerEventsByBehavior[self] = nil
+    end
+    local inRangeUnitEvents = inRangeUnitEventsByBehavior[self]
+    if inRangeUnitEvents ~= nil then
+        for event in pairs(inRangeUnitEvents) do
+            local ____opt_4 = behaviorsByInRangeUnitEvent[event]
             if ____opt_4 ~= nil then
-                ____opt_4[self] = nil
+                ____opt_4:remove(self)
+            end
+            local ____opt_6 = rangeByBehaviorByInRangeUnitEvent[event]
+            if ____opt_6 ~= nil then
+                ____opt_6[self] = nil
+            end
+            local ____opt_8 = listenerByBehaviorByInRangeUnitEvent[event]
+            if ____opt_8 ~= nil then
+                ____opt_8[self] = nil
             end
         end
-        eventsByBehavior[self] = nil
+        inRangeUnitEventsByBehavior[self] = nil
     end
     if self._bonusIdByBonusType ~= nil then
         for bonusType, bonusId in pairs(self._bonusIdByBonusType) do
@@ -60,28 +80,60 @@ function UnitBehavior.prototype.onDestroy(self)
     return Behavior.prototype.onDestroy(self)
 end
 function UnitBehavior.prototype.getUnitBonus(self, bonusType)
-    local ____opt_6 = self._bonusIdByBonusType
-    local bonusId = ____opt_6 and ____opt_6[bonusType]
+    local ____opt_10 = self._bonusIdByBonusType
+    local bonusId = ____opt_10 and ____opt_10:get(bonusType)
     return bonusId == nil and 0 or getUnitBonus(self.object, bonusType, bonusId)
 end
 function UnitBehavior.prototype.addOrUpdateOrRemoveUnitBonus(self, bonusType, value)
     local bonusIdByBonusType = self._bonusIdByBonusType
     if bonusIdByBonusType == nil then
-        bonusIdByBonusType = {}
+        bonusIdByBonusType = __TS__New(LinkedMap)
         self._bonusIdByBonusType = bonusIdByBonusType
     end
-    bonusIdByBonusType[bonusType] = addOrUpdateOrRemoveUnitBonus(self.object, bonusType, bonusIdByBonusType[bonusType], value)
+    bonusIdByBonusType:put(
+        bonusType,
+        addOrUpdateOrRemoveUnitBonus(
+            self.object,
+            bonusType,
+            bonusIdByBonusType:get(bonusType),
+            value
+        )
+    )
+end
+function UnitBehavior.prototype.registerOwningPlayerEvent(self, event, extractPlayer, listener)
+    local listenerByBehavior = getOrPut(listenerByBehaviorByOwningPlayerEvent, event, mutableLuaMap)
+    listenerByBehavior[self] = listener
+    getOrPut(inRangeUnitEventsByBehavior, self, mutableLuaSet)[event] = true
+    local behaviors = behaviorsByOwningPlayerEvent[event]
+    if behaviors == nil then
+        event:addListener(function(...)
+            local behaviors = behaviorsByOwningPlayerEvent[event]
+            if behaviors ~= nil then
+                local player = extractPlayer(...)
+                if player ~= nil then
+                    for behavior in pairs(behaviors) do
+                        if behavior.unit.owner == player then
+                            safeCall(behavior[listenerByBehavior[behavior]], behavior, ...)
+                        end
+                    end
+                end
+            end
+        end)
+        behaviors = __TS__New(LinkedSet)
+        behaviorsByOwningPlayerEvent[event] = behaviors
+    end
+    behaviors:add(self)
 end
 function UnitBehavior.prototype.registerInRangeUnitEvent(self, event, extractUnit, range, listener)
-    local rangeByBehavior = getOrPut(rangeByBehaviorByEvent, event, mutableLuaMap)
+    local rangeByBehavior = getOrPut(rangeByBehaviorByInRangeUnitEvent, event, mutableLuaMap)
     rangeByBehavior[self] = range
-    local listenerByBehavior = getOrPut(listenerByBehaviorByEvent, event, mutableLuaMap)
+    local listenerByBehavior = getOrPut(listenerByBehaviorByInRangeUnitEvent, event, mutableLuaMap)
     listenerByBehavior[self] = listener
-    getOrPut(eventsByBehavior, self, mutableLuaSet)[event] = true
-    local behaviors = behaviorsByEvent[event]
+    getOrPut(inRangeUnitEventsByBehavior, self, mutableLuaSet)[event] = true
+    local behaviors = behaviorsByInRangeUnitEvent[event]
     if behaviors == nil then
         event:addListener(function(...)
-            local behaviors = behaviorsByEvent[event]
+            local behaviors = behaviorsByInRangeUnitEvent[event]
             if behaviors ~= nil then
                 local unit = extractUnit(...)
                 if unit ~= nil then
@@ -95,7 +147,7 @@ function UnitBehavior.prototype.registerInRangeUnitEvent(self, event, extractUni
             end
         end)
         behaviors = __TS__New(LinkedSet)
-        behaviorsByEvent[event] = behaviors
+        behaviorsByInRangeUnitEvent[event] = behaviors
     end
     behaviors:add(self)
 end
@@ -151,6 +203,8 @@ function UnitBehavior.prototype.onTargetingAbilityImpact(self, ability, source)
 end
 function UnitBehavior.prototype.onBuffGained(self, buff)
 end
+function UnitBehavior.prototype.onBuffLost(self, buff)
+end
 function UnitBehavior.prototype.onItemDropped(self, item)
 end
 function UnitBehavior.prototype.onItemPickedUp(self, item)
@@ -165,6 +219,23 @@ function UnitBehavior.prototype.onKill(self, target)
 end
 function UnitBehavior.prototype.onDeath(self, source)
 end
+function UnitBehavior.prototype.onOwnerChange(self, previousOwner)
+end
+function UnitBehavior.bindUnitType(self, unitTypeId, ...)
+    local args = {...}
+    local createBehaviorFunctions = createBehaviorFunctionsByUnitTypeId[unitTypeId]
+    if createBehaviorFunctions == nil then
+        createBehaviorFunctions = {}
+        createBehaviorFunctionsByUnitTypeId[unitTypeId] = createBehaviorFunctions
+    end
+    createBehaviorFunctions[#createBehaviorFunctions + 1] = function(unit)
+        return __TS__New(
+            self,
+            unit,
+            table.unpack(args)
+        )
+    end
+end
 __TS__SetDescriptor(
     UnitBehavior.prototype,
     "unit",
@@ -276,7 +347,18 @@ __TS__SetDescriptor(
     Unit.itemChargesChangedEvent:addListener(function(unit, item)
         ____exports.UnitBehavior:forAll(unit, "onItemChargesChanged", item)
     end)
+    Unit.onOwnerChange:addListener(function(unit, previousOwner)
+        ____exports.UnitBehavior:forAll(unit, "onOwnerChange", previousOwner)
+    end)
 end)(UnitBehavior)
+Unit.onCreate:addListener(function(unit)
+    local createBehaviorFunctions = createBehaviorFunctionsByUnitTypeId[unit.typeId]
+    if createBehaviorFunctions ~= nil then
+        for ____, createBehavior in ipairs(createBehaviorFunctions) do
+            createBehavior(unit)
+        end
+    end
+end)
 Unit.destroyEvent:addListener(function(unit)
     ____exports.UnitBehavior:forAll(unit, "destroy")
 end)

package/engine/buff.d.ts

@@ -13,6 +13,7 @@ import { UnitBehavior } from "./behaviour/unit";
 import type { Widget } from "../core/types/widget";
 import { Destructor } from "../destroyable";
 import { Event } from "../event";
+import { AbilityBehavior } from "./behaviour/ability";
 export type BuffConstructor<T extends Buff<any> = Buff<any>, Args extends any[] = any> = OmitConstructor<typeof Buff<any>> & (new (...args: Args) => T);
 type EnumParameterValueType<T extends number> = T | AbilityEnumLevelField<T>;
 type NumberParameterValueType = number | AbilityNumberField | AbilityNumberLevelField;
@@ -30,8 +31,10 @@ export type BuffParameters<T extends Buff<any> = Buff> = Buff extends T ? {
     source?: Unit;
     behaviorConstructors?: (new (unit: Unit) => UnitBehavior)[];
     abilityTypeIds?: Record<AbilityTypeId, {
-        [numberField: (AbilityNumberField | AbilityNumberLevelField) & symbol]: NumberParameterValueType;
-    } & {
+        readonly fields?: [
+            AbilityNumberField | AbilityNumberLevelField,
+            NumberParameterValueType
+        ][];
         /** Default `true`. */
         readonly isButtonVisible?: boolean;
         /** Default is the level of the source ability or 0 if it is absent. */
@@ -56,6 +59,7 @@ export type BuffParameters<T extends Buff<any> = Buff> = Buff extends T ? {
     armorIncreaseFactor?: NumberParameterValueType;
     attackSpeedIncreaseFactor?: NumberParameterValueType;
     movementSpeedIncreaseFactor?: NumberParameterValueType;
+    manaRegenerationRateIncreaseFactor?: NumberParameterValueType;
     evasionProbability?: NumberParameterValueType;
     missProbability?: NumberParameterValueType;
     damageFactor?: NumberParameterValueType;
@@ -79,6 +83,7 @@ export type BuffParameters<T extends Buff<any> = Buff> = Buff extends T ? {
     healingOnExpiration?: NumberParameterValueType;
     killsOnExpiration?: BooleanParameterValueType;
     explodesOnExpiration?: BooleanParameterValueType;
+    abilityCooldownFactor?: NumberParameterValueType;
     uniqueGroup?: BuffUniqueGroup;
 } : BuffParameters & (T extends Buff<infer AdditionalParameters> ? AdditionalParameters : object);
 declare const enum BuffPropertyKey {
@@ -124,7 +129,9 @@ declare const enum BuffPropertyKey {
     PROVIDES_INVULNERABILITY = 139,
     KILLS_ON_EXPIRATION = 140,
     EXPLODES_ON_EXPIRATION = 141,
-    MISS_PROBABILITY = 142
+    MISS_PROBABILITY = 142,
+    ABILITY_COOLDOWN_FACTOR = 143,
+    ABILITY_COOLDOWN_MODIFIER = 144
 }
 export declare const enum BuffTypeIdSelectionPolicy {
     LEAST_DURATION = 0
@@ -138,7 +145,7 @@ export type BuffConstructorParameters<AdditionalParameters extends BuffAdditiona
     polarity: BuffPolarityParameterType,
     resistanceType: BuffResistanceTypeParameterType,
     ...abilityOrParameters: [
-        ability?: Ability,
+        ability?: Ability | AbilityBehavior,
         parameters?: BuffParameters & Omit<AdditionalParameters, keyof BuffParameters>
     ] | [parameters?: BuffParameters & Omit<AdditionalParameters, keyof BuffParameters>]
 ];
@@ -187,6 +194,8 @@ export declare class Buff<AdditionalParameters extends Prohibit<Record<string, a
     private [BuffPropertyKey.PROVIDES_INVULNERABILITY]?;
     private [BuffPropertyKey.KILLS_ON_EXPIRATION]?;
     private [BuffPropertyKey.EXPLODES_ON_EXPIRATION]?;
+    private [BuffPropertyKey.ABILITY_COOLDOWN_FACTOR]?;
+    private [BuffPropertyKey.ABILITY_COOLDOWN_MODIFIER]?;
     protected static readonly defaultParameters: BuffParameters;
     get source(): Unit;
     readonly typeId: ApplicableBuffTypeId;
@@ -259,9 +268,15 @@ export declare class Buff<AdditionalParameters extends Prohibit<Record<string, a
     set movementSpeedIncreaseFactor(movementSpeedIncreaseFactor: number);
     get evasionProbability(): number;
     set evasionProbability(evasionProbability: number);
+    get manaRegenerationRateIncreaseFactor(): number;
+    set manaRegenerationRateIncreaseFactor(manaRegenerationRateIncreaseFactor: number);
     get duration(): number;
     get remainingDuration(): number;
     set remainingDuration(remainingDuration: number);
+    get abilityCooldownFactor(): number;
+    set abilityCooldownFactor(abilityCooldownFactor: number);
+    onAbilityGained(ability: Ability): void;
+    onAbilityLost(ability: Ability): void;
     flashEffect(...parameters: [
         ...widgetOrXY: [] | [Widget] | [x: number, x: number],
         ...parametersOrDuration: [] | [EffectParameters] | [number]

package/engine/buff.lua

@@ -16,6 +16,7 @@ local internalApplyBuff = ____applicable.internalApplyBuff
 local removeBuff = ____applicable.removeBuff
 local ____ability = require("engine.internal.ability")
 local Ability = ____ability.Ability
+local UnitAbility = ____ability.UnitAbility
 local ____ability = require("engine.object-field.ability")
 local AbilityBooleanField = ____ability.AbilityBooleanField
 local AbilityNumberField = ____ability.AbilityNumberField
@@ -41,6 +42,7 @@ local BuffType = ____buff_2Dtype.BuffType
 local ____unit = require("engine.behaviour.unit")
 local UnitBehavior = ____unit.UnitBehavior
 local ____arrays = require("utility.arrays")
+local emptyArray = ____arrays.emptyArray
 local forEach = ____arrays.forEach
 local ____event = require("event")
 local Event = ____event.Event
@@ -50,6 +52,12 @@ local ____item = require("engine.internal.item")
 local Item = ____item.Item
 local ____destructable = require("core.types.destructable")
 local Destructable = ____destructable.Destructable
+local ____ability = require("engine.standard.fields.ability")
+local COOLDOWN_ABILITY_FLOAT_LEVEL_FIELD = ____ability.COOLDOWN_ABILITY_FLOAT_LEVEL_FIELD
+local ____ability = require("engine.behaviour.ability")
+local AbilityBehavior = ____ability.AbilityBehavior
+local ____records = require("utility.records")
+local sortedKeysUnnested = ____records.sortedKeysUnnested
 local getUnitAbility = BlzGetUnitAbility
 local stringValueByBuffTypeIdByFieldId = postcompile(function()
     local stringValueByBuffTypeIdByFieldId = {}
@@ -98,6 +106,7 @@ local buffParametersKeys = {
     armorIncreaseFactor = true,
     attackSpeedIncreaseFactor = true,
     movementSpeedIncreaseFactor = true,
+    manaRegenerationRateIncreaseFactor = true,
     evasionProbability = true,
     missProbability = true,
     damageFactor = true,
@@ -121,7 +130,8 @@ local buffParametersKeys = {
     damageOnExpiration = true,
     healingOnExpiration = true,
     killsOnExpiration = true,
-    explodesOnExpiration = true
+    explodesOnExpiration = true,
+    abilityCooldownFactor = true
 }
 local function resolveEnumValue(ability, level, value)
     if value == nil or type(value) == "number" then
@@ -184,6 +194,7 @@ local buffNumberParameters = {
     "durationIncreaseOnAutoAttack",
     "attackSpeedIncreaseFactor",
     "movementSpeedIncreaseFactor",
+    "manaRegenerationRateIncreaseFactor",
     "evasionProbability",
     "armorIncrease",
     "damageFactor",
@@ -198,7 +209,8 @@ local buffNumberParameters = {
     "healingPerInterval",
     "healingOverDuration",
     "damageOnExpiration",
-    "healingOnExpiration"
+    "healingOnExpiration",
+    "abilityCooldownFactor"
 }
 local unsuccessfulApplicationMarker = {}
 local function selectBuffTypeIdWithLeastDuration(buffTypeIds, unit)
@@ -317,33 +329,38 @@ function Buff.prototype.____constructor(self, _unit, typeIdOrTypeIds, polarityOr
     local polarity
     local resistanceType
     local ability
+    local abilityBehavior
     if type(typeIdOrTypeIds) ~= "number" then
         typeId = selectBuffTypeIdWithLeastDuration(typeIdOrTypeIds, _unit)
         polarity = resistanceTypeOrPolarity
         resistanceType = abilityOrParametersOrResistanceType
-        if __TS__InstanceOf(parametersOrAbility, Ability) or parametersOrAbility == nil then
+        if __TS__InstanceOf(parametersOrAbility, AbilityBehavior) then
+            abilityBehavior = parametersOrAbility
+            ability = abilityBehavior.ability
+        elseif __TS__InstanceOf(parametersOrAbility, Ability) then
             ability = parametersOrAbility
-        else
-            ability = nil
+        elseif parametersOrAbility ~= nil then
             parameters = parametersOrAbility
         end
     else
         typeId = typeIdOrTypeIds
         polarity = polarityOrTypeIdSelectionPolicy
         resistanceType = resistanceTypeOrPolarity
-        if __TS__InstanceOf(abilityOrParametersOrResistanceType, Ability) or abilityOrParametersOrResistanceType == nil then
+        if __TS__InstanceOf(abilityOrParametersOrResistanceType, AbilityBehavior) then
+            abilityBehavior = abilityOrParametersOrResistanceType
+            ability = abilityBehavior.ability
+            parameters = parametersOrAbility
+        elseif __TS__InstanceOf(abilityOrParametersOrResistanceType, Ability) then
             ability = abilityOrParametersOrResistanceType
             parameters = parametersOrAbility
-        else
-            ability = nil
+        elseif abilityOrParametersOrResistanceType ~= nil then
             parameters = abilityOrParametersOrResistanceType
+        else
+            parameters = parametersOrAbility
         end
     end
+    self.sourceAbilityBehavior = abilityBehavior
     self.typeId = typeId
-    if not (__TS__InstanceOf(ability, Ability) or ability == nil) then
-        parameters = ability
-        ability = nil
-    end
     local defaultParameters = self.constructor.defaultParameters
     local level = parameters and parameters.level or defaultParameters.level
     local spellStealPriority = parameters and parameters.spellStealPriority or defaultParameters.spellStealPriority
@@ -454,24 +471,22 @@ function Buff.prototype.____constructor(self, _unit, typeIdOrTypeIds, polarityOr
                 abilityTypeIds = {}
                 self._abilityTypeIds = abilityTypeIds
             end
-            for abilityTypeId, abilityParameters in pairs(parametersAbilityTypeIds) do
+            for ____, abilityTypeId in ipairs(sortedKeysUnnested(parametersAbilityTypeIds)) do
+                local abilityParameters = parametersAbilityTypeIds[abilityTypeId]
                 local addedAbility = _unit:addAbility(abilityTypeId)
                 if addedAbility ~= nil then
                     _unit:makeAbilityPermanent(abilityTypeId, true)
                     _unit:setAbilityLevel(abilityTypeId, 1 + (abilityParameters.level or ability and ability.level or 0))
-                    for abilityParameterKey, abilityParameterValue in pairs(abilityParameters) do
-                        if abilityParameterKey == "isButtonVisible" then
-                            if not resolveBooleanValue(ability, level, abilityParameterValue) then
-                                _unit:hideAbility(abilityTypeId, true)
-                            end
-                        elseif abilityParameterKey ~= "level" then
-                            abilityParameterKey:setValue(
-                                addedAbility,
-                                resolveNumberValue(ability, level, abilityParameterValue)
-                            )
-                        end
+                    if abilityParameters.isButtonVisible == false then
+                        _unit:hideAbility(abilityTypeId, true)
+                    end
+                    for ____, field in ipairs(abilityParameters.fields or emptyArray()) do
+                        field[1]:setValue(
+                            addedAbility,
+                            resolveNumberValue(ability, level, field[2])
+                        )
                     end
-                    abilityTypeIds[abilityTypeId] = true
+                    abilityTypeIds[#abilityTypeIds + 1] = abilityTypeId
                 end
             end
             local behaviorConstructors = parameters and parameters.behaviorConstructors or defaultParameters.behaviorConstructors
@@ -483,18 +498,20 @@ function Buff.prototype.____constructor(self, _unit, typeIdOrTypeIds, polarityOr
                 self._behaviors = behaviors
             end
         end
-        local additionalParameters = {}
-        for key, value in pairs(parameters) do
-            if not buffParametersKeys[key] then
-                if ability then
-                    additionalParameters[key] = resolveCurrentAbilityDependentValue(ability, value)
-                else
-                    additionalParameters[key] = value
+        if parameters ~= nil then
+            local additionalParameters = {}
+            for ____, key in ipairs(sortedKeysUnnested(parameters)) do
+                if not buffParametersKeys[key] then
+                    if ability then
+                        additionalParameters[key] = resolveCurrentAbilityDependentValue(ability, parameters[key])
+                    else
+                        additionalParameters[key] = parameters[key]
+                    end
                 end
             end
-        end
-        if (next(additionalParameters)) ~= nil then
-            self.parameters = additionalParameters
+            if (next(additionalParameters)) ~= nil then
+                self.parameters = additionalParameters
+            end
         end
     end
     if duration ~= nil and duration > 0 then
@@ -506,6 +523,22 @@ function Buff.prototype.____constructor(self, _unit, typeIdOrTypeIds, polarityOr
     self[100] = 1
     Event.invoke(buffCreatedEvent, self)
 end
+function Buff.prototype.onAbilityGained(self, ability)
+    if __TS__InstanceOf(ability, UnitAbility) then
+        local abilityCooldownModifier = self[144]
+        if abilityCooldownModifier then
+            COOLDOWN_ABILITY_FLOAT_LEVEL_FIELD:applyModifier(ability, abilityCooldownModifier)
+        end
+    end
+end
+function Buff.prototype.onAbilityLost(self, ability)
+    if __TS__InstanceOf(ability, UnitAbility) then
+        local abilityCooldownModifier = self[144]
+        if abilityCooldownModifier then
+            COOLDOWN_ABILITY_FLOAT_LEVEL_FIELD:removeModifier(ability, abilityCooldownModifier)
+        end
+    end
+end
 function Buff.prototype.flashEffect(self, widgetOrXOrParametersOrDuration, yOrParametersOrDuration, parametersOrDuration)
     if type(widgetOrXOrParametersOrDuration) == "number" and type(yOrParametersOrDuration) == "number" then
         Effect:flash(self[105], widgetOrXOrParametersOrDuration, yOrParametersOrDuration, parametersOrDuration)
@@ -580,6 +613,12 @@ function Buff.prototype.onDestroy(self)
             behavior:destroy()
         end
     end
+    local previousAbilityCooldownModifier = self[144]
+    if previousAbilityCooldownModifier then
+        for ____, ability in ipairs(self._unit.abilities) do
+            COOLDOWN_ABILITY_FLOAT_LEVEL_FIELD:removeModifier(ability, previousAbilityCooldownModifier)
+        end
+    end
     if self[139] then
         unit:decrementInvulnerabilityCounter()
     end
@@ -588,7 +627,7 @@ function Buff.prototype.onDestroy(self)
     end
     if self[136] then
         if self[137] then
-            unit:decrementStunCounter()
+            unit:decrementForceStunCounter()
         end
         unit:decrementStunCounter()
     end
@@ -596,7 +635,7 @@ function Buff.prototype.onDestroy(self)
         unit:decrementGhostCounter()
     end
     if self._abilityTypeIds ~= nil then
-        for abilityTypeId in pairs(self._abilityTypeIds) do
+        for ____, abilityTypeId in ipairs(self._abilityTypeIds) do
             unit:removeAbility(abilityTypeId)
         end
     end
@@ -987,13 +1026,13 @@ __TS__SetDescriptor(
         set = function(self, stuns)
             if not stuns and self[136] then
                 if self[137] then
-                    self.object:decrementStunCounter()
+                    self.object:decrementForceStunCounter()
                 end
                 self.object:decrementStunCounter()
                 self[136] = nil
             elseif stuns and not self[136] then
                 if self[137] then
-                    self.object:incrementStunCounter()
+                    self.object:incrementForceStunCounter()
                 end
                 self.object:incrementStunCounter()
                 self[136] = true
@@ -1016,12 +1055,12 @@ __TS__SetDescriptor(
         set = function(self, ignoresStunImmunity)
             if not ignoresStunImmunity and self[137] then
                 if self[136] then
-                    self.object:decrementStunCounter()
+                    self.object:decrementForceStunCounter()
                 end
                 self[137] = nil
             elseif ignoresStunImmunity and not self[137] then
                 if self[136] then
-                    self.object:incrementStunCounter()
+                    self.object:incrementForceStunCounter()
                 end
                 self[137] = true
             end
@@ -1220,6 +1259,19 @@ __TS__SetDescriptor(
     },
     true
 )
+__TS__SetDescriptor(
+    Buff.prototype,
+    "manaRegenerationRateIncreaseFactor",
+    {
+        get = function(self)
+            return self:getUnitBonus(UnitBonusType.MANA_REGENERATION_RATE_FACTOR)
+        end,
+        set = function(self, manaRegenerationRateIncreaseFactor)
+            self:addOrUpdateOrRemoveUnitBonus(UnitBonusType.MANA_REGENERATION_RATE_FACTOR, manaRegenerationRateIncreaseFactor)
+        end
+    },
+    true
+)
 __TS__SetDescriptor(
     Buff.prototype,
     "duration",
@@ -1269,6 +1321,32 @@ __TS__SetDescriptor(
     },
     true
 )
+__TS__SetDescriptor(
+    Buff.prototype,
+    "abilityCooldownFactor",
+    {
+        get = function(self)
+            return self[143] or 1
+        end,
+        set = function(self, abilityCooldownFactor)
+            local previousAbilityCooldownModifier = self[144]
+            if previousAbilityCooldownModifier then
+                for ____, ability in ipairs(self._unit.abilities) do
+                    COOLDOWN_ABILITY_FLOAT_LEVEL_FIELD:removeModifier(ability, previousAbilityCooldownModifier)
+                end
+            end
+            local function modifier(ability, level, cooldown)
+                return cooldown * abilityCooldownFactor
+            end
+            for ____, ability in ipairs(self._unit.abilities) do
+                COOLDOWN_ABILITY_FLOAT_LEVEL_FIELD:applyModifier(ability, modifier)
+            end
+            self[144] = modifier
+            self[143] = abilityCooldownFactor
+        end
+    },
+    true
+)
 Buff.createdEvent = buffCreatedEvent
 Buff.beingDestroyedEvent = buffBeingDestroyedEvent;
 (function(self)
@@ -1327,5 +1405,8 @@ Buff.beingDestroyedEvent = buffBeingDestroyedEvent;
     buffCreatedEvent:addListener(function(buff)
         UnitBehavior:forAll(buff.unit, "onBuffGained", buff)
     end)
+    buffBeingDestroyedEvent:addListener(function(buff)
+        UnitBehavior:forAll(buff.unit, "onBuffLost", buff)
+    end)
 end)(Buff)
 return ____exports

package/engine/internal/ability.lua

@@ -13,7 +13,6 @@ local ____ability = require("engine.internal.item.ability")
 local abilityActionDummy = ____ability.abilityActionDummy
 local doAbilityAction = ____ability.doAbilityAction
 local doAbilityActionForceDummy = ____ability.doAbilityActionForceDummy
-local doUnitAbilityAction = ____ability.doUnitAbilityAction
 local startItemCooldown = ____ability.startItemCooldown
 local getUnitAbilityLevel = GetUnitAbilityLevel
 local setUnitAbilityLevel = SetUnitAbilityLevel
@@ -40,8 +39,6 @@ local getItemBooleanField = BlzGetItemBooleanField
 local setItemBooleanField = BlzSetItemBooleanField
 local unitHideAbility = BlzUnitHideAbility
 local unitDisableAbility = BlzUnitDisableAbility
-local unitRemoveAbility = UnitRemoveAbility
-local itemRemoveAbility = BlzItemRemoveAbility
 local match = string.match
 local ____type = _G.type
 local ____tostring = _G.tostring
@@ -429,7 +426,9 @@ function UnitAbility.prototype.interruptCast(self)
     self.owner:interruptCast(self.typeId)
 end
 function UnitAbility.prototype.onDestroy(self)
-    doUnitAbilityAction(self.owner.handle, self.typeId, unitRemoveAbility, self.typeId)
+    if self.owner.state ~= 2 then
+        self.owner:removeAbility(self.typeId)
+    end
     return UnitAbility.____super.prototype.onDestroy(self)
 end
 __TS__SetDescriptor(
@@ -525,7 +524,9 @@ function ItemAbility.prototype.interruptCast(self)
     end
 end
 function ItemAbility.prototype.onDestroy(self)
-    doAbilityAction(self.owner.handle, itemRemoveAbility, self.typeId)
+    if self.owner.state ~= 2 then
+        self.owner:removeAbility(self.typeId)
+    end
     return ItemAbility.____super.prototype.onDestroy(self)
 end
 __TS__SetDescriptor(