warscript 0.0.1-dev.87b6c38 → 0.0.1-dev.8895725

package/core/types/frame.lua

@@ -24,11 +24,23 @@ local frameCoordinatesToWorld = ____playerCamera.frameCoordinatesToWorld
 local worldCoordinatesToFrame = ____playerCamera.worldCoordinatesToFrame
 local ____get_2Dterrain_2Dz = require("engine.internal.misc.get-terrain-z")
 local getTerrainZ = ____get_2Dterrain_2Dz.getTerrainZ
+local ____lua_2Dsets = require("utility.lua-sets")
+local mutableLuaSet = ____lua_2Dsets.mutableLuaSet
+local ____socket = require("net.socket")
+local Socket = ____socket.Socket
+local ____lua_2Dmaps = require("utility.lua-maps")
+local getOrPut = ____lua_2Dmaps.getOrPut
+local luaMapInvert = ____lua_2Dmaps.luaMapInvert
+local luaMapOf = ____lua_2Dmaps.luaMapOf
+local mutableLuaMap = ____lua_2Dmaps.mutableLuaMap
 local frameClick = BlzFrameClick
 local frameGetEnable = BlzFrameGetEnable
 local frameIsVisible = BlzFrameIsVisible
 local frameSetEnable = BlzFrameSetEnable
 local frameSetScale = BlzFrameSetScale
+local getHandleId = GetHandleId
+local getOriginFrame = BlzGetOriginFrame
+local location = Location
 local ____rawget = _G.rawget
 local rawset = _G.rawset
 local invoke = Event.invoke
@@ -130,6 +142,30 @@ do
     FramePoint.BOTTOM_RIGHT = FRAMEPOINT_BOTTOMRIGHT
 end
 local tooltipByFrame = setmetatable({}, {__mode = "k"})
+local keyByAsyncInitOriginFrameType = luaMapOf(ORIGIN_FRAME_PORTRAIT_HP_TEXT, "hp", ORIGIN_FRAME_PORTRAIT_MANA_TEXT, "mana")
+local asyncInitOriginFrameTypeByKey = luaMapInvert(keyByAsyncInitOriginFrameType)
+local seenAsyncInitOriginFrameTypes = mutableLuaSet()
+local seenAsyncInitOriginFrameTypesSocket = __TS__New(Socket)
+local seenPlayersByAsyncInitOriginFrameType = mutableLuaMap()
+seenAsyncInitOriginFrameTypesSocket.onMessage:addListener(function(player, key)
+    local asyncInitOriginFrameType = asyncInitOriginFrameTypeByKey[key]
+    if asyncInitOriginFrameType ~= nil then
+        getOrPut(seenPlayersByAsyncInitOriginFrameType, asyncInitOriginFrameType, mutableLuaSet)[player] = true
+    end
+end)
+local function haveAllPlayersSeenAsyncInitOriginFrameType(frame)
+    local players = seenPlayersByAsyncInitOriginFrameType[frame]
+    if players == nil then
+        return false
+    end
+    for ____, player in ipairs(Player.all) do
+        if player.isUser and player.isPlaying and not (players[player] ~= nil) then
+            return false
+        end
+    end
+    keyByAsyncInitOriginFrameType[frame] = nil
+    return true
+end
 ____exports.Frame = __TS__Class()
 local Frame = ____exports.Frame
 Frame.name = "Frame"
@@ -308,7 +344,17 @@ function Frame.byOrigin(self, frameType, index)
     if index == nil then
         index = 0
     end
-    return self:of(BlzGetOriginFrame(frameType, index))
+    local frame = getOriginFrame(frameType, index)
+    local asyncInitOriginFrameTypeKey = keyByAsyncInitOriginFrameType[frameType]
+    if index == 0 and asyncInitOriginFrameTypeKey ~= nil and not haveAllPlayersSeenAsyncInitOriginFrameType(frameType) then
+        if getHandleId(frame) == 0 or seenAsyncInitOriginFrameTypes[frameType] ~= nil then
+            location(0, 0)
+        else
+            seenAsyncInitOriginFrameTypes[frameType] = true
+            seenAsyncInitOriginFrameTypesSocket:send(asyncInitOriginFrameTypeKey)
+        end
+    end
+    return self:of(frame)
 end
 Frame.GAME_UI = ____exports.Frame:byOrigin(ORIGIN_FRAME_GAME_UI)
 Frame.CONSOLE_UI = ____exports.Frame:byOrigin(ORIGIN_FRAME_SIMPLE_UI_PARENT)

package/core/types/handle.lua

@@ -15,6 +15,8 @@ local ____exception = require("exception")
 local IllegalStateException = ____exception.IllegalStateException
 local ____attributes = require("attributes")
 local AttributesHolder = ____attributes.AttributesHolder
+local ____preconditions = require("utility.preconditions")
+local checkNotNull = ____preconditions.checkNotNull
 local getHandleId = GetHandleId
 local onCreateEventByHandleConstructor = {}
 local onDestroyEventByHandleConstructor = {}
@@ -66,17 +68,12 @@ function Handle.prototype.onDestroy(self, ...)
     return nil
 end
 function Handle.prototype.destroy(self, ...)
+    if self[0] == 2 or self[0] == 3 then
+        return nil
+    end
     local clazz = self.constructor
     local id = getHandleId(self.handle)
-    if not clazz.memoized[id] then
-        error(
-            __TS__New(
-                IllegalStateException,
-                "Double-destroy run for handle " .. tostring(id)
-            ),
-            0
-        )
-    end
+    checkNotNull(clazz.memoized[id])
     self[0] = 2
     if self.onDestroyEvent then
         Event.invoke(self.onDestroyEvent)

package/core/types/item.d.ts

@@ -1,4 +1,5 @@
 /** @noSelfInFile */
 import { Item } from "../../engine/internal/item";
 import "../../engine/internal/item+owner";
+import "../../engine/internal/item/fields";
 export { Item };

package/core/types/item.lua

@@ -2,5 +2,6 @@ local ____exports = {}
 local ____item = require("engine.internal.item")
 local Item = ____item.Item
 require("engine.internal.item+owner")
+require("engine.internal.item.fields")
 ____exports.Item = Item
 return ____exports

package/core/types/player.d.ts

@@ -28,6 +28,7 @@ export declare class Player extends Handle<jplayer> {
     static readonly neutralExtra: Player;
     private static events;
     readonly id: number;
+    readonly slotState: jplayerslotstate;
     constructor(handle: jplayer);
     onDestroy(): HandleDestructor;
     toString(): string;
@@ -45,7 +46,6 @@ export declare class Player extends Handle<jplayer> {
     get isUser(): boolean;
     get isPlaying(): boolean;
     get controller(): jmapcontrol;
-    get slotState(): jplayerslotstate;
     clearSelection(): void;
     selectSingle(unit: Unit): void;
     select(unit: Unit): void;

package/core/types/player.lua

@@ -56,6 +56,7 @@ Player.name = "Player"
 __TS__ClassExtends(Player, Handle)
 function Player.prototype.____constructor(self, handle)
     Handle.prototype.____constructor(self, handle)
+    self.slotState = GetPlayerSlotState(self.handle)
     self.id = GetPlayerId(handle)
 end
 function Player.prototype.onDestroy(self)
@@ -364,7 +365,7 @@ __TS__SetDescriptor(
     Player.prototype,
     "isUser",
     {get = function(self)
-        return GetPlayerController(self.handle) == MAP_CONTROL_USER
+        return self.controller == MAP_CONTROL_USER
     end},
     true
 )
@@ -372,7 +373,7 @@ __TS__SetDescriptor(
     Player.prototype,
     "isPlaying",
     {get = function(self)
-        return GetPlayerSlotState(self.handle) == PLAYER_SLOT_STATE_PLAYING
+        return self.slotState == PLAYER_SLOT_STATE_PLAYING
     end},
     true
 )
@@ -380,15 +381,9 @@ __TS__SetDescriptor(
     Player.prototype,
     "controller",
     {get = function(self)
-        return GetPlayerController(self.handle)
-    end},
-    true
-)
-__TS__SetDescriptor(
-    Player.prototype,
-    "slotState",
-    {get = function(self)
-        return GetPlayerSlotState(self.handle)
+        local controller = GetPlayerController(self.handle)
+        rawset(self, "controller", controller)
+        return controller
     end},
     true
 )
@@ -490,4 +485,10 @@ __TS__ObjectDefineProperty(
     end}
 )
 Player.colorChangedEvent = playerColorChangedEvent
+____exports.Player.onLeave:addListener(
+    999999,
+    function(player)
+        rawset(player, "slotState", PLAYER_SLOT_STATE_LEFT)
+    end
+)
 return ____exports

package/core/types/sound.lua

@@ -22,7 +22,7 @@ local setSoundPlayPosition = SetSoundPlayPosition
 local stopSound = StopSound
 local attachSoundToUnit = AttachSoundToUnit
 local killSoundWhenDone = KillSoundWhenDone
-____exports.SoundChannel = SoundChannel or ({})
+____exports.SoundChannel = ____exports.SoundChannel or ({})
 ____exports.SoundChannel.General = 0
 ____exports.SoundChannel[____exports.SoundChannel.General] = "General"
 ____exports.SoundChannel.UnitSelection = 1

package/destroyable.d.ts

@@ -10,6 +10,7 @@ export interface Destroyable {
     destroy(): void;
 }
 export declare abstract class AbstractDestroyable implements Destroyable {
+    get isDestroyed(): boolean;
     /**
      * An overriding function should always call the super one at the end of it,
      * in the following manner: `return super.onDestroy()`.

package/destroyable.lua

@@ -1,6 +1,7 @@
 local ____lualib = require("lualib_bundle")
 local __TS__Class = ____lualib.__TS__Class
 local __TS__New = ____lualib.__TS__New
+local __TS__SetDescriptor = ____lualib.__TS__SetDescriptor
 local ____exports = {}
 local ____exception = require("exception")
 local IllegalStateException = ____exception.IllegalStateException
@@ -28,4 +29,12 @@ function AbstractDestroyable.prototype.destroy(self)
     end
     return true
 end
+__TS__SetDescriptor(
+    AbstractDestroyable.prototype,
+    "isDestroyed",
+    {get = function(self)
+        return stateByDestroyable[self] ~= nil
+    end},
+    true
+)
 return ____exports

package/engine/behavior.d.ts

@@ -18,9 +18,11 @@ export declare abstract class Behavior<T extends AnyNotNil, PeriodicActionParame
     private [BehaviorPropertyKey.PREVIOUS_BEHAVIOR]?;
     private [BehaviorPropertyKey.NEXT_BEHAVIOR]?;
     private [BehaviorPropertyKey.TIMER]?;
-    protected constructor(object: T, priority?: BehaviorPriority);
+    constructor(object: T, priority?: BehaviorPriority);
     protected onDestroy(): Destructor;
-    protected registerEvent<K extends string, Args extends any[]>(this: Behavior<any, PeriodicActionParameters> & Record<K, (this: this, ...args: Args) => unknown>, event: Event<[...Args]>, listener: K): void;
+    protected registerGlobalEvent<K extends string, Args extends any[]>(this: Behavior<any, PeriodicActionParameters> & Record<K, (this: this, ...args: Args) => unknown>, event: Event<[...Args]>, listener: K): void;
+    protected deregisterGlobalEvent(event: Event<any>): boolean;
+    protected registerEvent<K extends string, Args extends any[]>(this: Behavior<any, PeriodicActionParameters> & Record<K, (this: this, ...args: Args) => unknown>, event: Event<[...Args]>, extractObject: (...args: Args) => T | undefined, listener: K): void;
     protected deregisterEvent(event: Event<any>): boolean;
     protected onPeriod(...parameters: PeriodicActionParameters): void;
     protected startPeriodicAction(interval: number, ...parameters: PeriodicActionParameters): void;

package/engine/behavior.lua

@@ -57,9 +57,17 @@ local function reduceBehaviors(behaviorConstructor, object, operation, initial,
     end
     return accumulator
 end
+local behaviorsByGlobalEvent = {}
+local listenerByBehaviorByGlobalEvent = {}
+local globalEventsByBehavior = {}
 local behaviorsByEvent = {}
 local listenerByBehaviorByEvent = {}
 local eventsByBehavior = {}
+local function safeCallBehaviorListener(behavior, behaviors, listenerByBehavior, ...)
+    if behaviors[behavior] ~= nil then
+        safeCall(behavior[listenerByBehavior[behavior]], behavior, ...)
+    end
+end
 ____exports.Behavior = __TS__Class()
 local Behavior = ____exports.Behavior
 Behavior.name = "Behavior"
@@ -87,18 +95,32 @@ function Behavior.prototype.onDestroy(self)
     if ____opt_0 ~= nil then
         ____opt_0:destroy()
     end
-    local events = eventsByBehavior[self]
-    if events ~= nil then
-        for event in pairs(events) do
-            local ____opt_2 = behaviorsByEvent[event]
+    local globalEvents = globalEventsByBehavior[self]
+    if globalEvents ~= nil then
+        for event in pairs(globalEvents) do
+            local ____opt_2 = behaviorsByGlobalEvent[event]
             if ____opt_2 ~= nil then
                 ____opt_2:remove(self)
             end
-            local ____opt_4 = listenerByBehaviorByEvent[event]
+            local ____opt_4 = listenerByBehaviorByGlobalEvent[event]
             if ____opt_4 ~= nil then
                 ____opt_4[self] = nil
             end
         end
+        globalEventsByBehavior[self] = nil
+    end
+    local events = eventsByBehavior[self]
+    if events ~= nil then
+        for event in pairs(events) do
+            local ____opt_6 = behaviorsByEvent[event]
+            if ____opt_6 ~= nil then
+                ____opt_6[self] = nil
+            end
+            local ____opt_8 = listenerByBehaviorByEvent[event]
+            if ____opt_8 ~= nil then
+                ____opt_8[self] = nil
+            end
+        end
         eventsByBehavior[self] = nil
     end
     local previousBehavior = self[0]
@@ -115,7 +137,35 @@ function Behavior.prototype.onDestroy(self)
     end
     return AbstractDestroyable.prototype.onDestroy(self)
 end
-function Behavior.prototype.registerEvent(self, event, listener)
+function Behavior.prototype.registerGlobalEvent(self, event, listener)
+    local listenerByBehavior = getOrPut(listenerByBehaviorByGlobalEvent, event, mutableLuaMap)
+    listenerByBehavior[self] = listener
+    getOrPut(globalEventsByBehavior, self, mutableLuaSet)[event] = true
+    local behaviors = behaviorsByGlobalEvent[event]
+    if behaviors == nil then
+        event:addListener(function(...)
+            local behaviors = behaviorsByGlobalEvent[event]
+            if behaviors ~= nil then
+                for behavior in pairs(behaviors) do
+                    safeCall(behavior[listenerByBehavior[behavior]], behavior, ...)
+                end
+            end
+        end)
+        behaviors = __TS__New(LinkedSet)
+        behaviorsByGlobalEvent[event] = behaviors
+    end
+    behaviors:add(self)
+end
+function Behavior.prototype.deregisterGlobalEvent(self, event)
+    local behaviors = behaviorsByGlobalEvent[event]
+    if behaviors ~= nil and behaviors:remove(self) then
+        globalEventsByBehavior[self][event] = nil
+        listenerByBehaviorByGlobalEvent[event][self] = nil
+        return true
+    end
+    return false
+end
+function Behavior.prototype.registerEvent(self, event, extractObject, listener)
     local listenerByBehavior = getOrPut(listenerByBehaviorByEvent, event, mutableLuaMap)
     listenerByBehavior[self] = listener
     getOrPut(eventsByBehavior, self, mutableLuaSet)[event] = true
@@ -124,19 +174,27 @@ function Behavior.prototype.registerEvent(self, event, listener)
         event:addListener(function(...)
             local behaviors = behaviorsByEvent[event]
             if behaviors ~= nil then
-                for behavior in pairs(behaviors) do
-                    safeCall(behavior[listenerByBehavior[behavior]], behavior, ...)
+                local object = extractObject(...)
+                if object ~= nil then
+                    ____exports.Behavior:forAll(
+                        object,
+                        safeCallBehaviorListener,
+                        behaviors,
+                        listenerByBehavior,
+                        ...
+                    )
                 end
             end
         end)
-        behaviors = __TS__New(LinkedSet)
+        behaviors = {}
         behaviorsByEvent[event] = behaviors
     end
-    behaviors:add(self)
+    behaviors[self] = true
 end
 function Behavior.prototype.deregisterEvent(self, event)
     local behaviors = behaviorsByEvent[event]
-    if behaviors ~= nil and behaviors:remove(self) then
+    if behaviors ~= nil and behaviors[self] ~= nil then
+        behaviors[self] = nil
         eventsByBehavior[self][event] = nil
         listenerByBehaviorByEvent[event][self] = nil
         return true

package/engine/behaviour/ability/damage.d.ts

@@ -25,8 +25,11 @@ export declare abstract class DamageAbilityBehavior<T extends DamageAbilityBehav
     protected readonly damage: AbilityDependentValue<number>;
     protected readonly parameters?: T | undefined;
     protected constructor(ability: Ability, damage: AbilityDependentValue<number>, parameters?: T | undefined);
+    protected precalculatedDamage?: number;
     protected calculateDamage(caster: Unit): number;
     protected damageTarget(caster: Unit, target: Widget, damage?: number): void;
+    onChannelingStart(caster: Unit): void;
+    onStop(): void;
 }
 export declare class DamageSelfAbilityBehavior extends DamageAbilityBehavior {
     constructor(ability: Ability, damage: AbilityDependentValue<number>, parameters?: DamageAbilityBehaviorParameters);

package/engine/behaviour/ability/damage.lua

@@ -39,7 +39,7 @@ function DamageAbilityBehavior.prototype.damageTarget(self, caster, target, dama
     local parameters = self.parameters
     caster:damageTarget(
         target,
-        damage or self:calculateDamage(caster),
+        damage or self.precalculatedDamage or self:calculateDamage(caster),
         nil,
         nil,
         self:resolveCurrentAbilityDependentValue(parameters and parameters.attackType),
@@ -48,6 +48,12 @@ function DamageAbilityBehavior.prototype.damageTarget(self, caster, target, dama
         self:resolveCurrentAbilityDependentValue(parameters and parameters.metadata)
     )
 end
+function DamageAbilityBehavior.prototype.onChannelingStart(self, caster)
+    self.precalculatedDamage = self:calculateDamage(caster)
+end
+function DamageAbilityBehavior.prototype.onStop(self)
+    self.precalculatedDamage = nil
+end
 ____exports.DamageSelfAbilityBehavior = __TS__Class()
 local DamageSelfAbilityBehavior = ____exports.DamageSelfAbilityBehavior
 DamageSelfAbilityBehavior.name = "DamageSelfAbilityBehavior"
@@ -83,7 +89,7 @@ function DamageAreaAbilityBehavior.prototype.damageArea(self, caster, x, y)
         y,
         self:resolveCurrentAbilityDependentValue(parameters and parameters.areaOfEffect or AREA_OF_EFFECT_ABILITY_FLOAT_LEVEL_FIELD)
     )
-    local damage = self:calculateDamage(caster)
+    local damage = self.precalculatedDamage or self:calculateDamage(caster)
     local maximumDamage = self:resolveCurrentAbilityDependentValue(parameters and parameters.maximumDamage or 0)
     if maximumDamage ~= 0 and damage > maximumDamage then
         damage = maximumDamage / #targets

package/engine/behaviour/ability/emulate-impact.lua

@@ -10,9 +10,6 @@ local Unit = ____unit.Unit
 local ____ability = require("engine.standard.fields.ability")
 local COOLDOWN_ABILITY_FLOAT_LEVEL_FIELD = ____ability.COOLDOWN_ABILITY_FLOAT_LEVEL_FIELD
 local MANA_COST_ABILITY_INTEGER_LEVEL_FIELD = ____ability.MANA_COST_ABILITY_INTEGER_LEVEL_FIELD
-local ____math = require("math")
-local max = ____math.max
-local MINIMUM_POSITIVE_NORMALIZED_FLOAT = ____math.MINIMUM_POSITIVE_NORMALIZED_FLOAT
 local ____sound = require("core.types.sound")
 local Sound3D = ____sound.Sound3D
 local SoundSettings = ____sound.SoundSettings
@@ -31,7 +28,11 @@ function EmulateImpactAbilityBehavior.prototype.emulateImpact(self, caster)
         return false
     end
     caster.mana = caster.mana - manaCost
-    self.ability.cooldownRemaining = max(cooldown, MINIMUM_POSITIVE_NORMALIZED_FLOAT)
+    if cooldown == 0 then
+        self.ability:interruptCast()
+    else
+        self.ability.cooldownRemaining = cooldown
+    end
     self:flashCasterEffect(caster)
     local soundPresetId = self.ability:getField(ABILITY_SF_EFFECT_SOUND)
     if soundPresetId ~= "" then

package/engine/behaviour/ability.d.ts

@@ -26,16 +26,20 @@ export declare abstract class AbilityBehavior<Parameters extends {
     get unit(): Unit | undefined;
     protected resolveCurrentAbilityDependentValue<T extends boolean | number | string>(value: AbilityDependentValue<T>): T;
     protected resolveCurrentAbilityDependentValue<T extends boolean | number | string>(value?: AbilityDependentValue<T>): T | undefined;
-    protected flashCasterEffect(widget: Widget, ...parametersOrDuration: [parameters?: EffectParameters] | [duration?: number, parameters?: EffectParameters]): void;
-    protected flashTargetEffect(widget: Widget, ...parametersOrDuration: [parameters?: EffectParameters] | [duration?: number, parameters?: EffectParameters]): void;
-    protected flashAreaEffect(x: number, y: number, ...parametersOrDuration: [parameters?: EffectParameters] | [duration?: number, parameters?: EffectParameters]): void;
-    protected flashEffect(x: number, y: number, ...parametersOrDuration: [parameters?: EffectParameters] | [duration?: number, parameters?: EffectParameters]): void;
-    protected flashSpecialEffect(...args: [
+    flashCasterEffect(widget: Widget, ...parametersOrDuration: [parameters?: EffectParameters] | [duration?: number, parameters?: EffectParameters]): void;
+    flashTargetEffect(widget: Widget, ...parametersOrDuration: [parameters?: EffectParameters] | [duration?: number, parameters?: EffectParameters]): void;
+    flashAreaEffect(x: number, y: number, ...parametersOrDuration: [parameters?: EffectParameters] | [duration?: number, parameters?: EffectParameters]): void;
+    flashEffect(x: number, y: number, ...parametersOrDuration: [parameters?: EffectParameters] | [duration?: number, parameters?: EffectParameters]): void;
+    flashSpecialEffect(...args: [
         ...pointOrWidget: [x: number, y: number] | [widget: Widget],
         ...parametersOrDuration: [parameters?: EffectParameters] | [duration?: number, parameters?: EffectParameters]
     ]): void;
     private static MissileLaunchConfig;
     private get missileLaunchConfig();
+    protected launchMissile(source: Unit, ...args: [
+        ...pointOrWidget: [x: number, y: number] | [widget: Unit /** TODO: support Widget */],
+        ...parameters: NonNullable<Parameters["missileParameters"]>
+    ]): void;
     protected onCreate(): void;
     onValueChange(_value: ReadonlySubscribableAbilityDependentValue<string | number | boolean>): void;
     onMissileArrival(...parameters: NonNullable<Parameters["missileParameters"]>): void;

package/engine/behaviour/ability.lua

@@ -30,7 +30,14 @@ local ____ability = require("engine.object-field.ability")
 local AbilityField = ____ability.AbilityField
 local AbilityLevelField = ____ability.AbilityLevelField
 local resolveCurrentAbilityDependentValue = ____ability.resolveCurrentAbilityDependentValue
+local ____missile = require("core.types.missile")
+local Missile = ____missile.Missile
 local createBehaviorFunctionsByAbilityTypeId = {}
+local function invokeOnMissileArrival(_missile, success, abilityBehavior, ...)
+    if success then
+        abilityBehavior:onMissileArrival(...)
+    end
+end
 local exclusiveOnImpactHandlerAbilityBehaviorByAbility = setmetatable({}, {__mode = "k"})
 local function createUnitEventListener(key)
     return function(unit, ability, ...)
@@ -160,6 +167,28 @@ function AbilityBehavior.prototype.flashSpecialEffect(self, xOrWidget, yOrParame
         )
     end
 end
+function AbilityBehavior.prototype.launchMissile(self, source, xOrWidget, yOrParameter, ...)
+    if type(xOrWidget) ~= "number" then
+        Missile:launch(
+            self.missileLaunchConfig,
+            source,
+            xOrWidget,
+            invokeOnMissileArrival,
+            self,
+            yOrParameter,
+            ...
+        )
+    else
+        Missile:launch(
+            self.missileLaunchConfig,
+            source,
+            vec2(xOrWidget, yOrParameter),
+            invokeOnMissileArrival,
+            self,
+            ...
+        )
+    end
+end
 function AbilityBehavior.prototype.onCreate(self)
 end
 function AbilityBehavior.prototype.onValueChange(self, _value)

package/engine/behaviour/unit/stun-immunity.d.ts

@@ -7,7 +7,7 @@ import { Destructor } from "../../../destroyable";
 import { BehaviorPriority } from "../../behavior";
 export type StunImmunityUnitBehaviorParameters = {
     readonly priority?: BehaviorPriority;
-    buffTypeIds?: LuaSet<BuffTypeId>;
+    buffTypeIds?: readonly BuffTypeId[];
     textTagPreset?: TextTagPreset;
     textTagText?: string;
     additionalAction?: (this: void, unit: Unit) => void;

package/engine/behaviour/unit/stun-immunity.lua

@@ -8,14 +8,15 @@ local UnitBehavior = ____unit.UnitBehavior
 local ____ability_2Dtype = require("engine.object-data.entry.ability-type")
 local AbilityType = ____ability_2Dtype.AbilityType
 local ____arrays = require("utility.arrays")
-local flatMapToLuaSet = ____arrays.flatMapToLuaSet
+local distinct = ____arrays.distinct
+local flatMap = ____arrays.flatMap
 local map = ____arrays.map
 local ____text_2Dtag = require("engine.text-tag")
 local TextTag = ____text_2Dtag.TextTag
 local ____timer = require("core.types.timer")
 local Timer = ____timer.Timer
 local DEFAULT_BUFF_TYPE_IDS = postcompile(function()
-    return flatMapToLuaSet(
+    return distinct(flatMap(
         AbilityType:getAllByBaseIds(map({
             "AHtb",
             "AHbh",
@@ -41,11 +42,11 @@ local DEFAULT_BUFF_TYPE_IDS = postcompile(function()
             "ACcb"
         }, fourCC)),
         function(abilityType) return __TS__ArrayFlat(abilityType.buffTypeIds) end
-    )
+    ))
 end)
 local function process(behavior)
     local hasRemovedBuffs = false
-    for buffTypeId in pairs(behavior.parameters.buffTypeIds or DEFAULT_BUFF_TYPE_IDS) do
+    for ____, buffTypeId in ipairs(behavior.parameters.buffTypeIds or DEFAULT_BUFF_TYPE_IDS) do
         hasRemovedBuffs = hasRemovedBuffs or behavior.unit:removeBuff(buffTypeId)
     end
     if hasRemovedBuffs then

package/engine/behaviour/unit.lua

@@ -21,6 +21,8 @@ local ____bonus = require("engine.internal.unit.bonus")
 local addOrUpdateOrRemoveUnitBonus = ____bonus.addOrUpdateOrRemoveUnitBonus
 local getUnitBonus = ____bonus.getUnitBonus
 local removeUnitBonus = ____bonus.removeUnitBonus
+local ____linked_2Dmap = require("utility.linked-map")
+local LinkedMap = ____linked_2Dmap.LinkedMap
 local safeCall = warpack.safeCall
 local createBehaviorFunctionsByUnitTypeId = {}
 local behaviorsByOwningPlayerEvent = {}
@@ -79,16 +81,24 @@ function UnitBehavior.prototype.onDestroy(self)
 end
 function UnitBehavior.prototype.getUnitBonus(self, bonusType)
     local ____opt_10 = self._bonusIdByBonusType
-    local bonusId = ____opt_10 and ____opt_10[bonusType]
+    local bonusId = ____opt_10 and ____opt_10:get(bonusType)
     return bonusId == nil and 0 or getUnitBonus(self.object, bonusType, bonusId)
 end
 function UnitBehavior.prototype.addOrUpdateOrRemoveUnitBonus(self, bonusType, value)
     local bonusIdByBonusType = self._bonusIdByBonusType
     if bonusIdByBonusType == nil then
-        bonusIdByBonusType = {}
+        bonusIdByBonusType = __TS__New(LinkedMap)
         self._bonusIdByBonusType = bonusIdByBonusType
     end
-    bonusIdByBonusType[bonusType] = addOrUpdateOrRemoveUnitBonus(self.object, bonusType, bonusIdByBonusType[bonusType], value)
+    bonusIdByBonusType:put(
+        bonusType,
+        addOrUpdateOrRemoveUnitBonus(
+            self.object,
+            bonusType,
+            bonusIdByBonusType:get(bonusType),
+            value
+        )
+    )
 end
 function UnitBehavior.prototype.registerOwningPlayerEvent(self, event, extractPlayer, listener)
     local listenerByBehavior = getOrPut(listenerByBehaviorByOwningPlayerEvent, event, mutableLuaMap)