warscript 0.0.1-dev.748f04c → 0.0.1-dev.75f6e33

package/core/types/sound.d.ts

@@ -64,7 +64,7 @@ export declare class Sound extends Handle<jsound, [fadeOut?: boolean]> {
 export declare class Sound3D extends Sound {
     static playAtPosition(fileName: string, preset: Sound3DPreset, x?: number, y?: number, z?: number): void;
     static playOnUnit(fileName: string, preset: Sound3DPreset, unit: Unit): void;
-    static playFromLabel(label: string, preset: Sound3DPreset, unit: Unit): void;
+    static playFromLabel(label: string, preset: Sound3DPreset, ...positionOrUnit: [Unit] | [number, number, number?]): void;
     static createAtPosition(fileName: string, preset: Sound3DPreset, x?: number, y?: number, z?: number): Sound3D;
     static createOnUnit(fileName: string, preset: Sound3DPreset, unit: Unit): Sound3D;
 }

package/core/types/sound.lua

@@ -249,9 +249,13 @@ function Sound3D.playOnUnit(self, fileName, preset, unit)
     startSound(sound)
     killSoundWhenDone(sound)
 end
-function Sound3D.playFromLabel(self, label, preset, unit)
+function Sound3D.playFromLabel(self, label, preset, unitOrX, y, z)
     local sound = createPreset3DSoundFromLabel(label, preset)
-    attachSoundToUnit(sound, unit.handle)
+    if type(unitOrX) ~= "number" then
+        attachSoundToUnit(sound, unitOrX.handle)
+    else
+        setSoundPosition(sound, unitOrX, y or 0, z or 0)
+    end
     startSound(sound)
     killSoundWhenDone(sound)
 end

package/core/util.lua

@@ -1,3 +1,5 @@
+local ____lualib = require("lualib_bundle")
+local __TS__StringPadEnd = ____lualib.__TS__StringPadEnd
 local ____exports = {}
 local ns = {}
 do
@@ -14,7 +16,10 @@ do
         if type(id) == "number" then
             return id
         else
-            local numid = string.unpack(">I4", id)
+            local numid = string.unpack(
+                ">I4",
+                __TS__StringPadEnd(id, 4, "\0")
+            )
             return numid
         end
     end

package/engine/object-data/entry/ability-type/blank-configurable.lua

@@ -23,9 +23,6 @@ local ALLOWED_TARGETS_ABILITY_COMBAT_CLASSIFICATIONS_LEVEL_FIELD = ____ability.A
 local AREA_OF_EFFECT_ABILITY_FLOAT_LEVEL_FIELD = ____ability.AREA_OF_EFFECT_ABILITY_FLOAT_LEVEL_FIELD
 local ____linked_2Dset = require("utility.linked-set")
 local LinkedSet = ____linked_2Dset.LinkedSet
-local ____sound = require("core.types.sound")
-local Sound3D = ____sound.Sound3D
-local SoundPreset = ____sound.SoundPreset
 local isChannelingAbilityTypeIds = {}
 local usesAttackAnimationByAbilityTypeId = {}
 ____exports.BlankConfigurableAbilityType = __TS__Class()
@@ -230,12 +227,6 @@ for abilityTypeId, usesAttackAnimation in pairs(postcompile(function()
     end
     return usesAttackAnimationByAbilityTypeId
 end)) do
-    Unit.abilityCastingFinishEvent[abilityTypeId]:addListener(function(caster, ability)
-        local effectSound = ability:getField(ABILITY_SF_EFFECT_SOUND)
-        if effectSound ~= "" then
-            Sound3D:playFromLabel(effectSound, SoundPreset.Ability, caster)
-        end
-    end)
     if usesAttackAnimation then
         Unit.abilityCastingStartEvent[abilityTypeId]:addListener(
             4,

package/engine/object-data/entry/ability-type.d.ts

@@ -115,6 +115,8 @@ export declare abstract class AbilityType extends ObjectDataEntry<AbilityTypeId>
     set casterEffectSoundPresetId(casterEffectSoundPresetId: SoundPresetId | undefined);
     get casterEffectLoopingSoundPresetId(): SoundPresetId;
     set casterEffectLoopingSoundPresetId(casterEffectLoopingSoundPresetId: SoundPresetId);
+    get targetEffectSoundPresetId(): SoundPresetId | undefined;
+    set targetEffectSoundPresetId(targetEffectSoundPresetId: SoundPresetId | undefined);
     get allowedTargetCombatClassifications(): CombatClassifications[];
     set allowedTargetCombatClassifications(allowedTargetCombatClassifications: ObjectDataEntryLevelFieldValueSupplier<CombatClassifications>);
     get areaOfEffect(): number[];

package/engine/object-data/entry/ability-type.lua

@@ -2,6 +2,7 @@ local ____lualib = require("lualib_bundle")
 local __TS__Class = ____lualib.__TS__Class
 local __TS__ClassExtends = ____lualib.__TS__ClassExtends
 local __TS__SetDescriptor = ____lualib.__TS__SetDescriptor
+local __TS__InstanceOf = ____lualib.__TS__InstanceOf
 local ____exports = {}
 local ____unit = require("engine.internal.unit")
 local Unit = ____unit.Unit
@@ -33,11 +34,15 @@ local ____object_2Ddata_2Dentry_2Did_2Dgenerator = require("engine.object-data.u
 local abilityTypeIdGenerator = ____object_2Ddata_2Dentry_2Did_2Dgenerator.abilityTypeIdGenerator
 local ____upgrade = require("engine.object-data.entry.upgrade")
 local Upgrade = ____upgrade.Upgrade
+local ____sound = require("core.types.sound")
+local Sound3D = ____sound.Sound3D
+local SoundPreset = ____sound.SoundPreset
 local castAnimationFQNByAbilityTypeId = {}
 local isButtonVisibleFalseAbilityTypes = {}
 local casterCastingEffectPresetsByAbilityTypeId = {}
 local casterChannelingEffectPresetsByAbilityTypeId = {}
 local targetCastingEffectPresetsByAbilityTypeId = {}
+local targetEffectSoundPresetByAbilityTypeId = {}
 ____exports.AbilityType = __TS__Class()
 local AbilityType = ____exports.AbilityType
 AbilityType.name = "AbilityType"
@@ -743,6 +748,19 @@ __TS__SetDescriptor(
     },
     true
 )
+__TS__SetDescriptor(
+    AbilityType.prototype,
+    "targetEffectSoundPresetId",
+    {
+        get = function(self)
+            return targetEffectSoundPresetByAbilityTypeId[self.id]
+        end,
+        set = function(self, targetEffectSoundPresetId)
+            targetEffectSoundPresetByAbilityTypeId[self.id] = targetEffectSoundPresetId
+        end
+    },
+    true
+)
 __TS__SetDescriptor(
     AbilityType.prototype,
     "allowedTargetCombatClassifications",
@@ -967,6 +985,26 @@ for abilityTypeId, animationFQN in pairs(postcompile(function() return castAnima
         end
     )
 end
+for abilityTypeId, soundPresetId in pairs(postcompile(function() return targetEffectSoundPresetByAbilityTypeId end)) do
+    if soundPresetId ~= nil then
+        Unit.abilityWidgetTargetChannelingStartEvent[abilityTypeId]:addListener(
+            4,
+            function(caster, ability, target)
+                if __TS__InstanceOf(target, Unit) then
+                    Sound3D:playFromLabel(soundPresetId, SoundPreset.Ability, target)
+                else
+                    Sound3D:playFromLabel(soundPresetId, SoundPreset.Ability, target.x, target.y)
+                end
+            end
+        )
+        Unit.abilityPointTargetChannelingStartEvent[abilityTypeId]:addListener(
+            4,
+            function(caster, ability, x, y)
+                Sound3D:playFromLabel(soundPresetId, SoundPreset.Ability, x, y)
+            end
+        )
+    end
+end
 local casterCastingEffectModelPathsByAbilityTypeId = postcompile(function()
     return mapValues(
         casterCastingEffectPresetsByAbilityTypeId,

package/engine/object-data/entry/unit-type.lua

@@ -810,7 +810,7 @@ __TS__SetDescriptor(
         set = function(self, modelPath)
             self:setStringField("umdl", modelPath)
             if not self.isPortraitModelPathSet and WarscriptConfig.AUTOMATICALLY_SET_UNIT_TYPE_PORTRAIT_MODEL_PATH then
-                self:setStringField("upor", modelPath)
+                self:setStringField("upor", "")
             end
         end
     },
@@ -826,7 +826,7 @@ __TS__SetDescriptor(
         set = function(self, modelPathSD)
             self:setStringField("umdl:sd", modelPathSD)
             if not self.isPortraitModelPathSet and WarscriptConfig.AUTOMATICALLY_SET_UNIT_TYPE_PORTRAIT_MODEL_PATH then
-                self:setStringField("upor:sd", modelPathSD)
+                self:setStringField("upor:sd", "")
             end
         end
     },
@@ -842,7 +842,7 @@ __TS__SetDescriptor(
         set = function(self, modelPathHD)
             self:setStringField("umdl:hd", modelPathHD)
             if not self.isPortraitModelPathSet and WarscriptConfig.AUTOMATICALLY_SET_UNIT_TYPE_PORTRAIT_MODEL_PATH then
-                self:setStringField("upor:hd", modelPathHD)
+                self:setStringField("upor:hd", "")
             end
         end
     },

package/objutil/unit.lua

@@ -596,7 +596,7 @@ __TS__SetDescriptor(
         set = function(self, v)
             self:setStringField("umdl", v)
             if WarscriptConfig.AUTOMATICALLY_SET_UNIT_TYPE_PORTRAIT_MODEL_PATH then
-                self:setStringField("upor", v)
+                self:setStringField("upor", "")
             end
         end
     },
@@ -612,7 +612,7 @@ __TS__SetDescriptor(
         set = function(self, v)
             self.object:setField("umdl:hd", v)
             if WarscriptConfig.AUTOMATICALLY_SET_UNIT_TYPE_PORTRAIT_MODEL_PATH then
-                self.object:setField("upor:hd", v)
+                self.object:setField("upor:hd", "")
             end
         end
     },

package/package.json

@@ -1,7 +1,7 @@
 {
     "$schema": "https://json.schemastore.org/package",
     "name": "warscript",
-    "version": "0.0.1-dev.748f04c",
+    "version": "0.0.1-dev.75f6e33",
     "description": "A typescript library for Warcraft III using Warpack.",
     "keywords": [
         "warcraft",
@@ -24,7 +24,7 @@
         "@warscript/language-extensions": "^0.0.1",
         "@warscript/tstl-plugin": "^0.0.4",
         "lua-types": "^2.13.1",
-        "warpack": "0.0.1-dev.9029fc3"
+        "warpack": "0.0.1-dev.519fc14"
     },
     "devDependencies": {
         "@typescript-eslint/eslint-plugin": "^8.13.0",