warscript 0.0.1-dev.7278154 → 0.0.1-dev.73fbafc

package/attributes.d.ts

@@ -13,5 +13,6 @@ export declare namespace Attribute {
 export declare class AttributesHolder {
     readonly get: (<T>(attribute: Attribute<T>) => T | undefined) & LuaExtension<"TableGetMethod">;
     readonly set: (<T>(attribute: Attribute<T>, value: T | undefined) => void) & LuaExtension<"TableSetMethod">;
+    getOrPut<T>(attribute: Attribute<T>, defaultValue: () => T): T;
 }
 export {};

package/attributes.lua

@@ -20,4 +20,13 @@ local AttributesHolder = ____exports.AttributesHolder
 AttributesHolder.name = "AttributesHolder"
 function AttributesHolder.prototype.____constructor(self)
 end
+function AttributesHolder.prototype.getOrPut(self, attribute, defaultValue)
+    local value = self[attribute]
+    if value ~= nil then
+        return value
+    end
+    value = defaultValue()
+    self[attribute] = value
+    return value
+end
 return ____exports

package/core/types/frame.lua

@@ -19,13 +19,16 @@ local ____frame_2Dcoordinates = require("engine.internal.misc.frame-coordinates"
 local FRAME_MAX_Y = ____frame_2Dcoordinates.FRAME_MAX_Y
 local FRAME_MIN_Y = ____frame_2Dcoordinates.FRAME_MIN_Y
 local getFrameMinXMaxX = ____frame_2Dcoordinates.getFrameMinXMaxX
+local ____playerCamera = require("core.types.playerCamera")
+local frameCoordinatesToWorld = ____playerCamera.frameCoordinatesToWorld
+local worldCoordinatesToFrame = ____playerCamera.worldCoordinatesToFrame
+local ____get_2Dterrain_2Dz = require("engine.internal.misc.get-terrain-z")
+local getTerrainZ = ____get_2Dterrain_2Dz.getTerrainZ
 local frameClick = BlzFrameClick
 local frameGetEnable = BlzFrameGetEnable
 local frameIsVisible = BlzFrameIsVisible
 local frameSetEnable = BlzFrameSetEnable
 local frameSetScale = BlzFrameSetScale
-local getCameraTargetPositionX = GetCameraTargetPositionX
-local getCameraTargetPositionY = GetCameraTargetPositionY
 local ____rawget = _G.rawget
 local rawset = _G.rawset
 local invoke = Event.invoke
@@ -936,16 +939,19 @@ __TS__ObjectDefineProperty(
         local event = __TS__New(Event)
         local syncX = 0
         local syncY = 0
-        local syncCamX = getCameraTargetPositionX()
-        local syncCamY = getCameraTargetPositionY()
+        local syncFrameX = 0
+        local syncFrameY = 0
         local lastX = syncX
         local lastY = syncY
         self.onMouseMove:addListener(function(player, x, y)
             if player.isLocal then
                 syncX = x
                 syncY = y
-                syncCamX = getCameraTargetPositionX()
-                syncCamY = getCameraTargetPositionY()
+                syncFrameX, syncFrameY = worldCoordinatesToFrame(
+                    x,
+                    y,
+                    getTerrainZ(x, y)
+                )
                 lastX = x
                 lastY = y
                 invoke(event, x, y)
@@ -955,9 +961,8 @@ __TS__ObjectDefineProperty(
             if syncX == 0 and syncY == 0 then
                 return
             end
-            local x = syncX + (getCameraTargetPositionX() - syncCamX)
-            local y = syncY + (getCameraTargetPositionY() - syncCamY)
-            if x ~= lastX or y ~= lastY then
+            local x, y, ____, isDefinite = frameCoordinatesToWorld(syncFrameX, syncFrameY)
+            if isDefinite and (x ~= lastX or y ~= lastY) then
                 lastX = x
                 lastY = y
                 invoke(event, x, y)

package/core/types/playerCamera.lua

@@ -13,6 +13,8 @@ local ____frame_2Dcoordinates = require("engine.internal.misc.frame-coordinates"
 local FRAME_MAX_Y = ____frame_2Dcoordinates.FRAME_MAX_Y
 local FRAME_MIN_Y = ____frame_2Dcoordinates.FRAME_MIN_Y
 local getFrameMinXMaxX = ____frame_2Dcoordinates.getFrameMinXMaxX
+local ____get_2Dterrain_2Dz = require("engine.internal.misc.get-terrain-z")
+local getTerrainZ = ____get_2Dterrain_2Dz.getTerrainZ
 local getHandleId = GetHandleId
 local setCameraField = SetCameraField
 local getCameraField = GetCameraField
@@ -26,6 +28,7 @@ local resetToGameCamera = ResetToGameCamera
 local cos = math.cos
 local deg = math.deg
 local sin = math.sin
+local sqrt = math.sqrt
 local memoized = {}
 ____exports.PlayerCamera = __TS__Class()
 local PlayerCamera = ____exports.PlayerCamera
@@ -233,4 +236,45 @@ ____exports.worldCoordinatesToFrame = function(x, y, z)
     local frameY = 0.42625 - yCenterScreenShift + (cameraAngleOfAttackSinRotationCos * dx + cameraAngleOfAttackSinRotationSin * dy - cameraAngleOfAttackCos * dz) / xPrime
     return frameX, frameY, xPrime < 0 and frameX >= frameMinX and frameX <= frameMaxX and frameY >= FRAME_MIN_Y and frameY <= FRAME_MAX_Y
 end
+---
+-- @internal For use by internal systems only.
+____exports.frameCoordinatesToWorld = function(x, y)
+    if not isCameraViewPrecalculated then
+        precalculateCameraView()
+    end
+    local a = (x - 0.4) * scaleFactor
+    local b = (0.42625 - yCenterScreenShift - y) * scaleFactor
+    local nx = 1 / sqrt(1 + a * a + b * b)
+    local ny = sqrt(1 - (1 + b * b) * nx * nx)
+    local nz = sqrt(1 - nx * nx - ny * ny)
+    if a > 0 then
+        ny = -ny
+    end
+    if b < 0 then
+        nz = -nz
+    end
+    local nxPrime = cameraAngleOfAttackCosRotationCos * nx - cameraRotationSin * ny + cameraAngleOfAttackSinRotationCos * nz
+    local nyPrime = cameraAngleOfAttackCosRotationSin * nx + cameraRotationCos * ny + cameraAngleOfAttackSinRotationSin * nz
+    local nzPrime = -cameraAngleOfAttackSin * nx + cameraAngleOfAttackCos * nz
+    local zGuess = getTerrainZ(cameraEyeX, cameraEyeY)
+    local xGuess = cameraEyeX + nxPrime * (cameraEyeZ - zGuess) / nzPrime
+    local yGuess = cameraEyeY + nyPrime * (cameraEyeZ - zGuess) / nzPrime
+    local zWorld = getTerrainZ(xGuess, yGuess)
+    local deltaZ = zWorld - zGuess
+    zGuess = zWorld
+    local zWorldOld = zWorld
+    local deltaZOld = deltaZ
+    local i = 0
+    while (deltaZ > 1 or deltaZ < -1) and i < 50 do
+        xGuess = cameraEyeX + nxPrime * (cameraEyeZ - zGuess) / nzPrime
+        yGuess = cameraEyeY + nyPrime * (cameraEyeZ - zGuess) / nzPrime
+        zWorld = getTerrainZ(xGuess, yGuess)
+        deltaZ = zWorld - zGuess
+        zGuess = (deltaZOld * zWorld - deltaZ * zWorldOld) / (deltaZOld - deltaZ)
+        zWorldOld = zWorld
+        deltaZOld = deltaZ
+        i = i + 1
+    end
+    return xGuess, yGuess, zWorld, i < 50
+end
 return ____exports

package/core/types/tileCell.d.ts

@@ -5,6 +5,15 @@ export declare class TileCell implements Readonly<Vec2> {
     readonly y: number;
     readonly z: undefined;
     protected constructor(id: number, x: number, y: number, z: undefined);
+    get up(): TileCell;
+    get down(): TileCell;
+    get left(): TileCell;
+    get right(): TileCell;
+    get terrainTypeId(): number;
+    set terrainTypeId(terrainTypeId: number);
+    get terrainVariance(): number;
+    set terrainVariance(terrainVariance: number);
+    randomizeTerrainVariance(): void;
     isInRangeOf(x: number, y: number, range: number): boolean;
     isInRangeOf(tileCell: TileCell, range: number): boolean;
     static getInRect(minX: number, minY: number, maxX: number, maxY: number): TileCell[];

package/core/types/tileCell.lua

@@ -1,7 +1,11 @@
 local ____lualib = require("lualib_bundle")
 local __TS__Class = ____lualib.__TS__Class
 local __TS__New = ____lualib.__TS__New
+local __TS__SetDescriptor = ____lualib.__TS__SetDescriptor
 local ____exports = {}
+local getTerrainType = GetTerrainType
+local setTerrainType = SetTerrainType
+local getTerrainVariance = GetTerrainVariance
 local abs = math.abs
 local ____type = math.type
 local ult = math.ult
@@ -16,6 +20,18 @@ function TileCell.prototype.____constructor(self, id, x, y, z)
     self.z = z
     tileCellById[id] = self
 end
+function TileCell.prototype.randomizeTerrainVariance(self)
+    local x = self.x
+    local y = self.y
+    setTerrainType(
+        x,
+        y,
+        getTerrainType(x, y),
+        -1,
+        1,
+        1
+    )
+end
 function TileCell.prototype.isInRangeOf(self, x, y, range)
     if range == nil then
         range = y
@@ -97,4 +113,80 @@ function TileCell.of(x, y)
         nil
     )
 end
+__TS__SetDescriptor(
+    TileCell.prototype,
+    "up",
+    {get = function(self)
+        return ____exports.TileCell.of(self.x, self.y + 128)
+    end},
+    true
+)
+__TS__SetDescriptor(
+    TileCell.prototype,
+    "down",
+    {get = function(self)
+        return ____exports.TileCell.of(self.x, self.y - 128)
+    end},
+    true
+)
+__TS__SetDescriptor(
+    TileCell.prototype,
+    "left",
+    {get = function(self)
+        return ____exports.TileCell.of(self.x - 128, self.y)
+    end},
+    true
+)
+__TS__SetDescriptor(
+    TileCell.prototype,
+    "right",
+    {get = function(self)
+        return ____exports.TileCell.of(self.x + 128, self.y)
+    end},
+    true
+)
+__TS__SetDescriptor(
+    TileCell.prototype,
+    "terrainTypeId",
+    {
+        get = function(self)
+            return getTerrainType(self.x, self.y)
+        end,
+        set = function(self, terrainTypeId)
+            local x = self.x
+            local y = self.y
+            setTerrainType(
+                x,
+                y,
+                terrainTypeId,
+                getTerrainVariance(x, y),
+                1,
+                1
+            )
+        end
+    },
+    true
+)
+__TS__SetDescriptor(
+    TileCell.prototype,
+    "terrainVariance",
+    {
+        get = function(self)
+            return getTerrainVariance(self.x, self.y)
+        end,
+        set = function(self, terrainVariance)
+            local x = self.x
+            local y = self.y
+            setTerrainType(
+                x,
+                y,
+                getTerrainType(x, y),
+                terrainVariance,
+                1,
+                1
+            )
+        end
+    },
+    true
+)
 return ____exports

package/core/types/timer.d.ts

@@ -1,6 +1,7 @@
 /** @noSelfInFile */
 import { Event } from "../../event";
 import { AbstractDestroyable, Destructor } from "../../destroyable";
+import { CallbackId } from "../../utility/callback-array";
 declare const enum TimerPropertyKey {
     HANDLE = 0,
     DESTROY_ON_EXPIRATION = 1,
@@ -22,8 +23,8 @@ export declare class Timer extends AbstractDestroyable {
     pause(): void;
     resume(): void;
     static create(): Timer;
-    static run<T, K extends KeysOfType<T, (this: T, ...args: any) => any>>(object: T, key: K, ...parameters: T[K] extends (this: T, ...args: any) => any ? Parameters<T[K]> : never): void;
-    static run<Args extends any[]>(callback: (this: void, ...args: Args) => void, ...args: Args): void;
+    static run<T, K extends KeysOfType<T, (this: T, ...args: any) => any>>(object: T, key: K, ...parameters: T[K] extends (this: T, ...args: any) => any ? Parameters<T[K]> : never): CallbackId;
+    static run<Args extends any[]>(callback: (this: void, ...args: Args) => void, ...args: Args): CallbackId;
     static simple<Args extends any[]>(timeout: number, callback: (...args: Args) => void, ...args: Args): Timer;
     static periodic<Args extends any[]>(period: number, callback: (this: void, timer: Timer, ...args: Args) => void, ...args: Args): Timer;
     static counted(period: number, count: number, callback: (this: void, timer: Timer) => void): Timer;

package/core/types/timer.lua

@@ -15,6 +15,7 @@ local AbstractDestroyable = ____destroyable.AbstractDestroyable
 local ____callback_2Darray = require("utility.callback-array")
 local addCallback = ____callback_2Darray.addCallback
 local callbackArray = ____callback_2Darray.callbackArray
+local consumeCallback = ____callback_2Darray.consumeCallback
 local consumeCallbacks = ____callback_2Darray.consumeCallbacks
 local createTimer = CreateTimer
 local timerStart = TimerStart
@@ -55,6 +56,11 @@ local function timerSafeCall()
 end
 local zeroTimerScheduled = false
 local zeroTimerCallbacks = callbackArray()
+---
+-- @internal For use by internal systems only.
+____exports.consumeZeroTimerCallback = function(id)
+    consumeCallback(zeroTimerCallbacks, id)
+end
 local function invokeZeroTimerCallbacks()
     zeroTimerScheduled = false
     consumeCallbacks(zeroTimerCallbacks)
@@ -98,9 +104,9 @@ function Timer.run(self, objectOrCallback, keyOrFirstArg, ...)
         ____exports.Timer:simple(0, invokeZeroTimerCallbacks)
     end
     if ____type(objectOrCallback) == "function" then
-        addCallback(zeroTimerCallbacks, objectOrCallback, keyOrFirstArg, ...)
+        return addCallback(zeroTimerCallbacks, objectOrCallback, keyOrFirstArg, ...)
     else
-        addCallback(zeroTimerCallbacks, objectOrCallback[keyOrFirstArg], objectOrCallback, ...)
+        return addCallback(zeroTimerCallbacks, objectOrCallback[keyOrFirstArg], objectOrCallback, ...)
     end
 end
 function Timer.simple(self, timeout, callback, ...)

package/decl/native.d.ts

@@ -5259,8 +5259,8 @@ declare function BlzRemoveAbilityStringLevelArrayField(
     level: number,
     value: string,
 ): boolean
-declare function BlzGetItemAbilityByIndex(whichItem: jitem, index: number): jability | null
-declare function BlzGetItemAbility(whichItem: jitem, abilCode: number): jability | null
+declare function BlzGetItemAbilityByIndex(whichItem: jitem, index: number): jability | undefined
+declare function BlzGetItemAbility(whichItem: jitem, abilCode: number): jability | undefined
 declare function BlzItemAddAbility(whichItem: jitem, abilCode: number): boolean
 declare function BlzGetItemBooleanField(whichItem: jitem, whichField: jitembooleanfield): boolean
 declare function BlzGetItemIntegerField(whichItem: jitem, whichField: jitemintegerfield): number

package/engine/behavior.d.ts

@@ -15,6 +15,7 @@ export declare abstract class Behavior<T extends AnyNotNil, PeriodicActionParame
     protected constructor(object: T);
     protected onDestroy(): Destructor;
     protected registerEvent<K extends string, Args extends any[]>(this: Behavior<any, PeriodicActionParameters> & Record<K, (this: this, ...args: Args) => unknown>, event: Event<[...Args]>, listener: K): void;
+    protected deregisterEvent(event: Event<any>): boolean;
     protected onPeriod(...parameters: PeriodicActionParameters): void;
     protected startPeriodicAction(interval: number, ...parameters: PeriodicActionParameters): void;
     protected stopPeriodicAction(): void;

package/engine/behavior.lua

@@ -127,6 +127,15 @@ function Behavior.prototype.registerEvent(self, event, listener)
     end
     behaviors:add(self)
 end
+function Behavior.prototype.deregisterEvent(self, event)
+    local behaviors = behaviorsByEvent[event]
+    if behaviors ~= nil and behaviors:remove(self) then
+        eventsByBehavior[self][event] = nil
+        listenerByBehaviorByEvent[event][self] = nil
+        return true
+    end
+    return false
+end
 function Behavior.prototype.onPeriod(self, ...)
 end
 function Behavior.prototype.startPeriodicAction(self, interval, ...)

package/engine/behaviour/ability/remove-buffs.d.ts

@@ -14,3 +14,12 @@ export declare class RemoveBuffsSelfAbilityBehavior extends AbilityBehavior {
     constructor(ability: Ability, polarity?: AbilityDependentValue<BuffPolarity> | undefined, resistanceType?: AbilityDependentValue<BuffResistanceType> | undefined, includeExpirationTimers?: AbilityDependentValue<boolean> | undefined, includeAuras?: AbilityDependentValue<boolean> | undefined, autoDispel?: AbilityDependentValue<boolean> | undefined);
     onImpact(caster: Unit): void;
 }
+export declare class RemoveBuffsTargetAbilityBehavior extends AbilityBehavior {
+    private readonly polarity?;
+    private readonly resistanceType?;
+    private readonly includeExpirationTimers?;
+    private readonly includeAuras?;
+    private readonly autoDispel?;
+    constructor(ability: Ability, polarity?: AbilityDependentValue<BuffPolarity> | undefined, resistanceType?: AbilityDependentValue<BuffResistanceType> | undefined, includeExpirationTimers?: AbilityDependentValue<boolean> | undefined, includeAuras?: AbilityDependentValue<boolean> | undefined, autoDispel?: AbilityDependentValue<boolean> | undefined);
+    onUnitTargetImpact(_: Unit, target: Unit): void;
+}

package/engine/behaviour/ability/remove-buffs.lua

@@ -25,4 +25,25 @@ function RemoveBuffsSelfAbilityBehavior.prototype.onImpact(self, caster)
         self:resolveCurrentAbilityDependentValue(self.autoDispel)
     )
 end
+____exports.RemoveBuffsTargetAbilityBehavior = __TS__Class()
+local RemoveBuffsTargetAbilityBehavior = ____exports.RemoveBuffsTargetAbilityBehavior
+RemoveBuffsTargetAbilityBehavior.name = "RemoveBuffsTargetAbilityBehavior"
+__TS__ClassExtends(RemoveBuffsTargetAbilityBehavior, AbilityBehavior)
+function RemoveBuffsTargetAbilityBehavior.prototype.____constructor(self, ability, polarity, resistanceType, includeExpirationTimers, includeAuras, autoDispel)
+    AbilityBehavior.prototype.____constructor(self, ability)
+    self.polarity = polarity
+    self.resistanceType = resistanceType
+    self.includeExpirationTimers = includeExpirationTimers
+    self.includeAuras = includeAuras
+    self.autoDispel = autoDispel
+end
+function RemoveBuffsTargetAbilityBehavior.prototype.onUnitTargetImpact(self, _, target)
+    target:removeBuffs(
+        self:resolveCurrentAbilityDependentValue(self.polarity),
+        self:resolveCurrentAbilityDependentValue(self.resistanceType),
+        self:resolveCurrentAbilityDependentValue(self.includeExpirationTimers),
+        self:resolveCurrentAbilityDependentValue(self.includeAuras),
+        self:resolveCurrentAbilityDependentValue(self.autoDispel)
+    )
+end
 return ____exports

package/engine/behaviour/unit/stun-immunity.d.ts

@@ -8,6 +8,7 @@ export type StunImmunityUnitBehaviourParameters = {
     buffTypeIds?: LuaSet<BuffTypeId>;
     textTagPreset?: TextTagPreset;
     textTagText?: string;
+    additionalAction?: (this: void, unit: Unit) => void;
 };
 export declare class StunImmunityUnitBehavior extends UnitBehavior {
     readonly parameters: Readonly<StunImmunityUnitBehaviourParameters>;
@@ -17,4 +18,5 @@ export declare class StunImmunityUnitBehavior extends UnitBehavior {
     onDamageReceived(): void;
     onTargetingAbilityChannelingStart(): void;
     onTargetingAbilityImpact(): void;
+    protected onEffect(): void;
 }

package/engine/behaviour/unit/stun-immunity.lua

@@ -48,8 +48,15 @@ local function process(behavior)
     for buffTypeId in pairs(behavior.parameters.buffTypeIds or DEFAULT_BUFF_TYPE_IDS) do
         hasRemovedBuffs = hasRemovedBuffs or behavior.unit:removeBuff(buffTypeId)
     end
-    if hasRemovedBuffs and behavior.parameters.textTagText ~= nil then
-        TextTag:flash(TextTag.MISS, behavior.parameters.textTagText, behavior.unit.x, behavior.unit.y)
+    if hasRemovedBuffs then
+        behavior.onEffect(behavior)
+        if behavior.parameters.textTagText ~= nil then
+            TextTag:flash(TextTag.MISS, behavior.parameters.textTagText, behavior.unit.x, behavior.unit.y)
+        end
+        local ____opt_0 = behavior.parameters.additionalAction
+        if ____opt_0 ~= nil then
+            ____opt_0(behavior.unit)
+        end
     end
 end
 ____exports.StunImmunityUnitBehavior = __TS__Class()
@@ -79,5 +86,7 @@ end
 function StunImmunityUnitBehavior.prototype.onTargetingAbilityImpact(self)
     process(self)
 end
+function StunImmunityUnitBehavior.prototype.onEffect(self)
+end
 StunImmunityUnitBehavior.defaultParameters = {buffTypeIds = DEFAULT_BUFF_TYPE_IDS, textTagPreset = TextTag.MISS, textTagText = nil}
 return ____exports

package/engine/behaviour/unit.d.ts

@@ -12,6 +12,7 @@ import type { Widget } from "../../core/types/widget";
 import { Destructable } from "../../core/types/destructable";
 import type { Buff } from "../buff";
 import { UnitBonusType } from "../internal/unit/bonus";
+import { Player } from "../../core/types/player";
 export type UnitBehaviorConstructor<Args extends any[]> = new (unit: Unit, ...args: Args) => UnitBehavior;
 export declare abstract class UnitBehavior<PeriodicActionParameters extends any[] = any[]> extends Behavior<Unit, PeriodicActionParameters> {
     readonly sourceAbilityBehavior?: AbilityBehavior;
@@ -55,4 +56,5 @@ export declare abstract class UnitBehavior<PeriodicActionParameters extends any[
     onItemChargesChanged(item: Item): void;
     onKill(target: Unit): void;
     onDeath(source: Unit | undefined): void;
+    onOwnerChange(previousOwner: Player): void;
 }

package/engine/behaviour/unit.lua

@@ -165,6 +165,8 @@ function UnitBehavior.prototype.onKill(self, target)
 end
 function UnitBehavior.prototype.onDeath(self, source)
 end
+function UnitBehavior.prototype.onOwnerChange(self, previousOwner)
+end
 __TS__SetDescriptor(
     UnitBehavior.prototype,
     "unit",
@@ -276,6 +278,9 @@ __TS__SetDescriptor(
     Unit.itemChargesChangedEvent:addListener(function(unit, item)
         ____exports.UnitBehavior:forAll(unit, "onItemChargesChanged", item)
     end)
+    Unit.onOwnerChange:addListener(function(unit, previousOwner)
+        ____exports.UnitBehavior:forAll(unit, "onOwnerChange", previousOwner)
+    end)
 end)(UnitBehavior)
 Unit.destroyEvent:addListener(function(unit)
     ____exports.UnitBehavior:forAll(unit, "destroy")

package/engine/internal/ability.lua

@@ -13,7 +13,6 @@ local ____ability = require("engine.internal.item.ability")
 local abilityActionDummy = ____ability.abilityActionDummy
 local doAbilityAction = ____ability.doAbilityAction
 local doAbilityActionForceDummy = ____ability.doAbilityActionForceDummy
-local doUnitAbilityAction = ____ability.doUnitAbilityAction
 local startItemCooldown = ____ability.startItemCooldown
 local getUnitAbilityLevel = GetUnitAbilityLevel
 local setUnitAbilityLevel = SetUnitAbilityLevel
@@ -40,8 +39,6 @@ local getItemBooleanField = BlzGetItemBooleanField
 local setItemBooleanField = BlzSetItemBooleanField
 local unitHideAbility = BlzUnitHideAbility
 local unitDisableAbility = BlzUnitDisableAbility
-local unitRemoveAbility = UnitRemoveAbility
-local itemRemoveAbility = BlzItemRemoveAbility
 local match = string.match
 local ____type = _G.type
 local ____tostring = _G.tostring
@@ -429,7 +426,9 @@ function UnitAbility.prototype.interruptCast(self)
     self.owner:interruptCast(self.typeId)
 end
 function UnitAbility.prototype.onDestroy(self)
-    doUnitAbilityAction(self.owner.handle, self.typeId, unitRemoveAbility, self.typeId)
+    if self.owner.state ~= 2 then
+        self.owner:removeAbility(self.typeId)
+    end
     return UnitAbility.____super.prototype.onDestroy(self)
 end
 __TS__SetDescriptor(
@@ -525,7 +524,9 @@ function ItemAbility.prototype.interruptCast(self)
     end
 end
 function ItemAbility.prototype.onDestroy(self)
-    doAbilityAction(self.owner.handle, itemRemoveAbility, self.typeId)
+    if self.owner.state ~= 2 then
+        self.owner:removeAbility(self.typeId)
+    end
     return ItemAbility.____super.prototype.onDestroy(self)
 end
 __TS__SetDescriptor(

package/engine/internal/item.d.ts

@@ -8,12 +8,10 @@ import { AbilityTypeId } from "../object-data/entry/ability-type";
 import type { ItemTypeId } from "../object-data/entry/item-type";
 type DefenseType = 0 | 1 | 2 | 3 | 4 | 5;
 declare const enum ItemPropertyKey {
-    ABILITIES = 100,
-    LUA_INDEX_BY_ABILITY_TYPE_ID = 101
+    ABILITIES = 100
 }
 export declare class Item extends Handle<jitem> {
     private readonly [ItemPropertyKey.ABILITIES];
-    private readonly [ItemPropertyKey.LUA_INDEX_BY_ABILITY_TYPE_ID];
     constructor(handle: jitem);
     protected onDestroy(): HandleDestructor;
     static create<T extends Item>(this: typeof Item & (new (handle: jitem) => T), id: number, x: number, y: number, skinId?: number): T;
@@ -30,22 +28,22 @@ export declare class Item extends Handle<jitem> {
     get extendedTooltip(): string;
     set iconPath(v: string);
     get iconPath(): string;
-    set dropOnDeath(v: boolean);
-    get dropOnDeath(): boolean;
-    set droppable(v: boolean);
-    get droppable(): boolean;
-    set pawnable(v: boolean);
-    get pawnable(): boolean;
-    set perishable(v: boolean);
-    get perishable(): boolean;
-    set powerup(v: boolean);
-    get powerup(): boolean;
+    set dropsOnDeath(dropsOnDeath: boolean);
+    get dropsOnDeath(): boolean;
+    set canBeDropped(canBeDropped: boolean);
+    get canBeDropped(): boolean;
+    set canBeSold(canBeSold: boolean);
+    get canBeSold(): boolean;
+    set perishes(perishes: boolean);
+    get perishes(): boolean;
+    set isPowerUp(isPowerUp: boolean);
+    get isPowerUp(): boolean;
     get isAlive(): boolean;
     get isDead(): boolean;
     set isInvulnerable(isInvulnerable: boolean);
     get isInvulnerable(): boolean;
-    set usable(v: boolean);
-    get usable(): boolean;
+    set isActivelyUsed(isActivelyUsed: boolean);
+    get isActivelyUsed(): boolean;
     set visible(v: boolean);
     get visible(): boolean;
     set level(v: number);