warscript 0.0.1-dev.6fc443a → 0.0.1-dev.702d52d

package/destroyable.d.ts

@@ -10,6 +10,7 @@ export interface Destroyable {
     destroy(): void;
 }
 export declare abstract class AbstractDestroyable implements Destroyable {
+    get isDestroyed(): boolean;
     /**
      * An overriding function should always call the super one at the end of it,
      * in the following manner: `return super.onDestroy()`.

package/destroyable.lua

@@ -1,6 +1,7 @@
 local ____lualib = require("lualib_bundle")
 local __TS__Class = ____lualib.__TS__Class
 local __TS__New = ____lualib.__TS__New
+local __TS__SetDescriptor = ____lualib.__TS__SetDescriptor
 local ____exports = {}
 local ____exception = require("exception")
 local IllegalStateException = ____exception.IllegalStateException
@@ -28,4 +29,12 @@ function AbstractDestroyable.prototype.destroy(self)
     end
     return true
 end
+__TS__SetDescriptor(
+    AbstractDestroyable.prototype,
+    "isDestroyed",
+    {get = function(self)
+        return stateByDestroyable[self] ~= nil
+    end},
+    true
+)
 return ____exports

package/engine/behavior.d.ts

@@ -18,9 +18,11 @@ export declare abstract class Behavior<T extends AnyNotNil, PeriodicActionParame
     private [BehaviorPropertyKey.PREVIOUS_BEHAVIOR]?;
     private [BehaviorPropertyKey.NEXT_BEHAVIOR]?;
     private [BehaviorPropertyKey.TIMER]?;
-    protected constructor(object: T, priority?: BehaviorPriority);
+    constructor(object: T, priority?: BehaviorPriority);
     protected onDestroy(): Destructor;
-    protected registerEvent<K extends string, Args extends any[]>(this: Behavior<any, PeriodicActionParameters> & Record<K, (this: this, ...args: Args) => unknown>, event: Event<[...Args]>, listener: K): void;
+    protected registerGlobalEvent<K extends string, Args extends any[]>(this: Behavior<any, PeriodicActionParameters> & Record<K, (this: this, ...args: Args) => unknown>, event: Event<[...Args]>, listener: K): void;
+    protected deregisterGlobalEvent(event: Event<any>): boolean;
+    protected registerEvent<K extends string, Args extends any[]>(this: Behavior<any, PeriodicActionParameters> & Record<K, (this: this, ...args: Args) => unknown>, event: Event<[...Args]>, extractObject: (...args: Args) => T | undefined, listener: K): void;
     protected deregisterEvent(event: Event<any>): boolean;
     protected onPeriod(...parameters: PeriodicActionParameters): void;
     protected startPeriodicAction(interval: number, ...parameters: PeriodicActionParameters): void;

package/engine/behavior.lua

@@ -57,9 +57,17 @@ local function reduceBehaviors(behaviorConstructor, object, operation, initial,
     end
     return accumulator
 end
+local behaviorsByGlobalEvent = {}
+local listenerByBehaviorByGlobalEvent = {}
+local globalEventsByBehavior = {}
 local behaviorsByEvent = {}
 local listenerByBehaviorByEvent = {}
 local eventsByBehavior = {}
+local function safeCallBehaviorListener(behavior, behaviors, listenerByBehavior, ...)
+    if behaviors[behavior] ~= nil then
+        safeCall(behavior[listenerByBehavior[behavior]], behavior, ...)
+    end
+end
 ____exports.Behavior = __TS__Class()
 local Behavior = ____exports.Behavior
 Behavior.name = "Behavior"
@@ -87,18 +95,32 @@ function Behavior.prototype.onDestroy(self)
     if ____opt_0 ~= nil then
         ____opt_0:destroy()
     end
-    local events = eventsByBehavior[self]
-    if events ~= nil then
-        for event in pairs(events) do
-            local ____opt_2 = behaviorsByEvent[event]
+    local globalEvents = globalEventsByBehavior[self]
+    if globalEvents ~= nil then
+        for event in pairs(globalEvents) do
+            local ____opt_2 = behaviorsByGlobalEvent[event]
             if ____opt_2 ~= nil then
                 ____opt_2:remove(self)
             end
-            local ____opt_4 = listenerByBehaviorByEvent[event]
+            local ____opt_4 = listenerByBehaviorByGlobalEvent[event]
             if ____opt_4 ~= nil then
                 ____opt_4[self] = nil
             end
         end
+        globalEventsByBehavior[self] = nil
+    end
+    local events = eventsByBehavior[self]
+    if events ~= nil then
+        for event in pairs(events) do
+            local ____opt_6 = behaviorsByEvent[event]
+            if ____opt_6 ~= nil then
+                ____opt_6[self] = nil
+            end
+            local ____opt_8 = listenerByBehaviorByEvent[event]
+            if ____opt_8 ~= nil then
+                ____opt_8[self] = nil
+            end
+        end
         eventsByBehavior[self] = nil
     end
     local previousBehavior = self[0]
@@ -115,7 +137,35 @@ function Behavior.prototype.onDestroy(self)
     end
     return AbstractDestroyable.prototype.onDestroy(self)
 end
-function Behavior.prototype.registerEvent(self, event, listener)
+function Behavior.prototype.registerGlobalEvent(self, event, listener)
+    local listenerByBehavior = getOrPut(listenerByBehaviorByGlobalEvent, event, mutableLuaMap)
+    listenerByBehavior[self] = listener
+    getOrPut(globalEventsByBehavior, self, mutableLuaSet)[event] = true
+    local behaviors = behaviorsByGlobalEvent[event]
+    if behaviors == nil then
+        event:addListener(function(...)
+            local behaviors = behaviorsByGlobalEvent[event]
+            if behaviors ~= nil then
+                for behavior in pairs(behaviors) do
+                    safeCall(behavior[listenerByBehavior[behavior]], behavior, ...)
+                end
+            end
+        end)
+        behaviors = __TS__New(LinkedSet)
+        behaviorsByGlobalEvent[event] = behaviors
+    end
+    behaviors:add(self)
+end
+function Behavior.prototype.deregisterGlobalEvent(self, event)
+    local behaviors = behaviorsByGlobalEvent[event]
+    if behaviors ~= nil and behaviors:remove(self) then
+        globalEventsByBehavior[self][event] = nil
+        listenerByBehaviorByGlobalEvent[event][self] = nil
+        return true
+    end
+    return false
+end
+function Behavior.prototype.registerEvent(self, event, extractObject, listener)
     local listenerByBehavior = getOrPut(listenerByBehaviorByEvent, event, mutableLuaMap)
     listenerByBehavior[self] = listener
     getOrPut(eventsByBehavior, self, mutableLuaSet)[event] = true
@@ -124,19 +174,27 @@ function Behavior.prototype.registerEvent(self, event, listener)
         event:addListener(function(...)
             local behaviors = behaviorsByEvent[event]
             if behaviors ~= nil then
-                for behavior in pairs(behaviors) do
-                    safeCall(behavior[listenerByBehavior[behavior]], behavior, ...)
+                local object = extractObject(...)
+                if object ~= nil then
+                    ____exports.Behavior:forAll(
+                        object,
+                        safeCallBehaviorListener,
+                        behaviors,
+                        listenerByBehavior,
+                        ...
+                    )
                 end
             end
         end)
-        behaviors = __TS__New(LinkedSet)
+        behaviors = {}
         behaviorsByEvent[event] = behaviors
     end
-    behaviors:add(self)
+    behaviors[self] = true
 end
 function Behavior.prototype.deregisterEvent(self, event)
     local behaviors = behaviorsByEvent[event]
-    if behaviors ~= nil and behaviors:remove(self) then
+    if behaviors ~= nil and behaviors[self] ~= nil then
+        behaviors[self] = nil
         eventsByBehavior[self][event] = nil
         listenerByBehaviorByEvent[event][self] = nil
         return true

package/engine/behaviour/ability/apply-buff.lua

@@ -27,7 +27,7 @@ function ApplyBuffAbilityBehavior.prototype.____constructor(self, ability, const
                 constructorOrTypeIdOrTypeIds,
                 typeIdOrTypeIdsOrPolarityOrTypeIdSelectionPolicy,
                 polarityOrTypeIdSelectionPolicyOrResistanceType,
-                ability,
+                self,
                 resistanceTypeOrPolarityOrParameters
             )
         end
@@ -39,7 +39,7 @@ function ApplyBuffAbilityBehavior.prototype.____constructor(self, ability, const
                 typeIdOrTypeIdsOrPolarityOrTypeIdSelectionPolicy,
                 polarityOrTypeIdSelectionPolicyOrResistanceType,
                 resistanceTypeOrPolarityOrParameters,
-                ability,
+                self,
                 parametersOrResistanceType
             )
         end
@@ -50,7 +50,7 @@ function ApplyBuffAbilityBehavior.prototype.____constructor(self, ability, const
                 typeIdOrTypeIdsOrPolarityOrTypeIdSelectionPolicy,
                 polarityOrTypeIdSelectionPolicyOrResistanceType,
                 resistanceTypeOrPolarityOrParameters,
-                ability,
+                self,
                 parametersOrResistanceType
             )
         end
@@ -62,7 +62,7 @@ function ApplyBuffAbilityBehavior.prototype.____constructor(self, ability, const
                 polarityOrTypeIdSelectionPolicyOrResistanceType,
                 resistanceTypeOrPolarityOrParameters,
                 parametersOrResistanceType,
-                ability,
+                self,
                 parameters
             )
         end

package/engine/behaviour/ability.d.ts

@@ -1,6 +1,7 @@
 /** @noSelfInFile */
 import { Behavior } from "../behavior";
-import { Unit } from "../unit";
+import { Unit } from "../internal/unit";
+import "../internal/unit/ability";
 import { Ability } from "../internal/ability";
 import { AbilityTypeId } from "../object-data/entry/ability-type";
 import { Widget } from "../../core/types/widget";

package/engine/behaviour/ability.lua

@@ -7,8 +7,9 @@ local __TS__SetDescriptor = ____lualib.__TS__SetDescriptor
 local ____exports = {}
 local ____behavior = require("engine.behavior")
 local Behavior = ____behavior.Behavior
-local ____unit = require("engine.unit")
+local ____unit = require("engine.internal.unit")
 local Unit = ____unit.Unit
+require("engine.internal.unit.ability")
 local ____ability = require("engine.internal.ability")
 local Ability = ____ability.Ability
 local ____effect = require("core.types.effect")

package/engine/behaviour/unit/stun-immunity.d.ts

@@ -7,7 +7,7 @@ import { Destructor } from "../../../destroyable";
 import { BehaviorPriority } from "../../behavior";
 export type StunImmunityUnitBehaviorParameters = {
     readonly priority?: BehaviorPriority;
-    buffTypeIds?: LuaSet<BuffTypeId>;
+    buffTypeIds?: readonly BuffTypeId[];
     textTagPreset?: TextTagPreset;
     textTagText?: string;
     additionalAction?: (this: void, unit: Unit) => void;

package/engine/behaviour/unit/stun-immunity.lua

@@ -8,14 +8,15 @@ local UnitBehavior = ____unit.UnitBehavior
 local ____ability_2Dtype = require("engine.object-data.entry.ability-type")
 local AbilityType = ____ability_2Dtype.AbilityType
 local ____arrays = require("utility.arrays")
-local flatMapToLuaSet = ____arrays.flatMapToLuaSet
+local distinct = ____arrays.distinct
+local flatMap = ____arrays.flatMap
 local map = ____arrays.map
 local ____text_2Dtag = require("engine.text-tag")
 local TextTag = ____text_2Dtag.TextTag
 local ____timer = require("core.types.timer")
 local Timer = ____timer.Timer
 local DEFAULT_BUFF_TYPE_IDS = postcompile(function()
-    return flatMapToLuaSet(
+    return distinct(flatMap(
         AbilityType:getAllByBaseIds(map({
             "AHtb",
             "AHbh",
@@ -41,11 +42,11 @@ local DEFAULT_BUFF_TYPE_IDS = postcompile(function()
             "ACcb"
         }, fourCC)),
         function(abilityType) return __TS__ArrayFlat(abilityType.buffTypeIds) end
-    )
+    ))
 end)
 local function process(behavior)
     local hasRemovedBuffs = false
-    for buffTypeId in pairs(behavior.parameters.buffTypeIds or DEFAULT_BUFF_TYPE_IDS) do
+    for ____, buffTypeId in ipairs(behavior.parameters.buffTypeIds or DEFAULT_BUFF_TYPE_IDS) do
         hasRemovedBuffs = hasRemovedBuffs or behavior.unit:removeBuff(buffTypeId)
     end
     if hasRemovedBuffs then

package/engine/behaviour/unit.d.ts

@@ -51,6 +51,7 @@ export declare abstract class UnitBehavior<PeriodicActionParameters extends any[
     onTargetingAbilityChannelingStart(ability: Ability, source: Unit): void;
     onTargetingAbilityImpact(ability: Ability, source: Unit): void;
     onBuffGained(buff: Buff): void;
+    onBuffLost(buff: Buff): void;
     onItemDropped(item: Item): void;
     onItemPickedUp(item: Item): void;
     onItemUsed(item: Item): void;

package/engine/behaviour/unit.lua

@@ -21,6 +21,8 @@ local ____bonus = require("engine.internal.unit.bonus")
 local addOrUpdateOrRemoveUnitBonus = ____bonus.addOrUpdateOrRemoveUnitBonus
 local getUnitBonus = ____bonus.getUnitBonus
 local removeUnitBonus = ____bonus.removeUnitBonus
+local ____linked_2Dmap = require("utility.linked-map")
+local LinkedMap = ____linked_2Dmap.LinkedMap
 local safeCall = warpack.safeCall
 local createBehaviorFunctionsByUnitTypeId = {}
 local behaviorsByOwningPlayerEvent = {}
@@ -79,16 +81,24 @@ function UnitBehavior.prototype.onDestroy(self)
 end
 function UnitBehavior.prototype.getUnitBonus(self, bonusType)
     local ____opt_10 = self._bonusIdByBonusType
-    local bonusId = ____opt_10 and ____opt_10[bonusType]
+    local bonusId = ____opt_10 and ____opt_10:get(bonusType)
     return bonusId == nil and 0 or getUnitBonus(self.object, bonusType, bonusId)
 end
 function UnitBehavior.prototype.addOrUpdateOrRemoveUnitBonus(self, bonusType, value)
     local bonusIdByBonusType = self._bonusIdByBonusType
     if bonusIdByBonusType == nil then
-        bonusIdByBonusType = {}
+        bonusIdByBonusType = __TS__New(LinkedMap)
         self._bonusIdByBonusType = bonusIdByBonusType
     end
-    bonusIdByBonusType[bonusType] = addOrUpdateOrRemoveUnitBonus(self.object, bonusType, bonusIdByBonusType[bonusType], value)
+    bonusIdByBonusType:put(
+        bonusType,
+        addOrUpdateOrRemoveUnitBonus(
+            self.object,
+            bonusType,
+            bonusIdByBonusType:get(bonusType),
+            value
+        )
+    )
 end
 function UnitBehavior.prototype.registerOwningPlayerEvent(self, event, extractPlayer, listener)
     local listenerByBehavior = getOrPut(listenerByBehaviorByOwningPlayerEvent, event, mutableLuaMap)
@@ -193,6 +203,8 @@ function UnitBehavior.prototype.onTargetingAbilityImpact(self, ability, source)
 end
 function UnitBehavior.prototype.onBuffGained(self, buff)
 end
+function UnitBehavior.prototype.onBuffLost(self, buff)
+end
 function UnitBehavior.prototype.onItemDropped(self, item)
 end
 function UnitBehavior.prototype.onItemPickedUp(self, item)

package/engine/buff.d.ts

@@ -13,6 +13,7 @@ import { UnitBehavior } from "./behaviour/unit";
 import type { Widget } from "../core/types/widget";
 import { Destructor } from "../destroyable";
 import { Event } from "../event";
+import { AbilityBehavior } from "./behaviour/ability";
 export type BuffConstructor<T extends Buff<any> = Buff<any>, Args extends any[] = any> = OmitConstructor<typeof Buff<any>> & (new (...args: Args) => T);
 type EnumParameterValueType<T extends number> = T | AbilityEnumLevelField<T>;
 type NumberParameterValueType = number | AbilityNumberField | AbilityNumberLevelField;
@@ -30,8 +31,10 @@ export type BuffParameters<T extends Buff<any> = Buff> = Buff extends T ? {
     source?: Unit;
     behaviorConstructors?: (new (unit: Unit) => UnitBehavior)[];
     abilityTypeIds?: Record<AbilityTypeId, {
-        [numberField: (AbilityNumberField | AbilityNumberLevelField) & symbol]: NumberParameterValueType;
-    } & {
+        readonly fields?: [
+            AbilityNumberField | AbilityNumberLevelField,
+            NumberParameterValueType
+        ][];
         /** Default `true`. */
         readonly isButtonVisible?: boolean;
         /** Default is the level of the source ability or 0 if it is absent. */
@@ -56,6 +59,7 @@ export type BuffParameters<T extends Buff<any> = Buff> = Buff extends T ? {
     armorIncreaseFactor?: NumberParameterValueType;
     attackSpeedIncreaseFactor?: NumberParameterValueType;
     movementSpeedIncreaseFactor?: NumberParameterValueType;
+    manaRegenerationRateIncreaseFactor?: NumberParameterValueType;
     evasionProbability?: NumberParameterValueType;
     missProbability?: NumberParameterValueType;
     damageFactor?: NumberParameterValueType;
@@ -141,7 +145,7 @@ export type BuffConstructorParameters<AdditionalParameters extends BuffAdditiona
     polarity: BuffPolarityParameterType,
     resistanceType: BuffResistanceTypeParameterType,
     ...abilityOrParameters: [
-        ability?: Ability,
+        ability?: Ability | AbilityBehavior,
         parameters?: BuffParameters & Omit<AdditionalParameters, keyof BuffParameters>
     ] | [parameters?: BuffParameters & Omit<AdditionalParameters, keyof BuffParameters>]
 ];
@@ -264,6 +268,8 @@ export declare class Buff<AdditionalParameters extends Prohibit<Record<string, a
     set movementSpeedIncreaseFactor(movementSpeedIncreaseFactor: number);
     get evasionProbability(): number;
     set evasionProbability(evasionProbability: number);
+    get manaRegenerationRateIncreaseFactor(): number;
+    set manaRegenerationRateIncreaseFactor(manaRegenerationRateIncreaseFactor: number);
     get duration(): number;
     get remainingDuration(): number;
     set remainingDuration(remainingDuration: number);

package/engine/buff.lua

@@ -42,6 +42,7 @@ local BuffType = ____buff_2Dtype.BuffType
 local ____unit = require("engine.behaviour.unit")
 local UnitBehavior = ____unit.UnitBehavior
 local ____arrays = require("utility.arrays")
+local emptyArray = ____arrays.emptyArray
 local forEach = ____arrays.forEach
 local ____event = require("event")
 local Event = ____event.Event
@@ -53,6 +54,10 @@ local ____destructable = require("core.types.destructable")
 local Destructable = ____destructable.Destructable
 local ____ability = require("engine.standard.fields.ability")
 local COOLDOWN_ABILITY_FLOAT_LEVEL_FIELD = ____ability.COOLDOWN_ABILITY_FLOAT_LEVEL_FIELD
+local ____ability = require("engine.behaviour.ability")
+local AbilityBehavior = ____ability.AbilityBehavior
+local ____records = require("utility.records")
+local sortedKeysUnnested = ____records.sortedKeysUnnested
 local getUnitAbility = BlzGetUnitAbility
 local stringValueByBuffTypeIdByFieldId = postcompile(function()
     local stringValueByBuffTypeIdByFieldId = {}
@@ -101,6 +106,7 @@ local buffParametersKeys = {
     armorIncreaseFactor = true,
     attackSpeedIncreaseFactor = true,
     movementSpeedIncreaseFactor = true,
+    manaRegenerationRateIncreaseFactor = true,
     evasionProbability = true,
     missProbability = true,
     damageFactor = true,
@@ -188,6 +194,7 @@ local buffNumberParameters = {
     "durationIncreaseOnAutoAttack",
     "attackSpeedIncreaseFactor",
     "movementSpeedIncreaseFactor",
+    "manaRegenerationRateIncreaseFactor",
     "evasionProbability",
     "armorIncrease",
     "damageFactor",
@@ -322,33 +329,38 @@ function Buff.prototype.____constructor(self, _unit, typeIdOrTypeIds, polarityOr
     local polarity
     local resistanceType
     local ability
+    local abilityBehavior
     if type(typeIdOrTypeIds) ~= "number" then
         typeId = selectBuffTypeIdWithLeastDuration(typeIdOrTypeIds, _unit)
         polarity = resistanceTypeOrPolarity
         resistanceType = abilityOrParametersOrResistanceType
-        if __TS__InstanceOf(parametersOrAbility, Ability) or parametersOrAbility == nil then
+        if __TS__InstanceOf(parametersOrAbility, AbilityBehavior) then
+            abilityBehavior = parametersOrAbility
+            ability = abilityBehavior.ability
+        elseif __TS__InstanceOf(parametersOrAbility, Ability) then
             ability = parametersOrAbility
-        else
-            ability = nil
+        elseif parametersOrAbility ~= nil then
             parameters = parametersOrAbility
         end
     else
         typeId = typeIdOrTypeIds
         polarity = polarityOrTypeIdSelectionPolicy
         resistanceType = resistanceTypeOrPolarity
-        if __TS__InstanceOf(abilityOrParametersOrResistanceType, Ability) or abilityOrParametersOrResistanceType == nil then
+        if __TS__InstanceOf(abilityOrParametersOrResistanceType, AbilityBehavior) then
+            abilityBehavior = abilityOrParametersOrResistanceType
+            ability = abilityBehavior.ability
+            parameters = parametersOrAbility
+        elseif __TS__InstanceOf(abilityOrParametersOrResistanceType, Ability) then
             ability = abilityOrParametersOrResistanceType
             parameters = parametersOrAbility
-        else
-            ability = nil
+        elseif abilityOrParametersOrResistanceType ~= nil then
             parameters = abilityOrParametersOrResistanceType
+        else
+            parameters = parametersOrAbility
         end
     end
+    self.sourceAbilityBehavior = abilityBehavior
     self.typeId = typeId
-    if not (__TS__InstanceOf(ability, Ability) or ability == nil) then
-        parameters = ability
-        ability = nil
-    end
     local defaultParameters = self.constructor.defaultParameters
     local level = parameters and parameters.level or defaultParameters.level
     local spellStealPriority = parameters and parameters.spellStealPriority or defaultParameters.spellStealPriority
@@ -459,24 +471,22 @@ function Buff.prototype.____constructor(self, _unit, typeIdOrTypeIds, polarityOr
                 abilityTypeIds = {}
                 self._abilityTypeIds = abilityTypeIds
             end
-            for abilityTypeId, abilityParameters in pairs(parametersAbilityTypeIds) do
+            for ____, abilityTypeId in ipairs(sortedKeysUnnested(parametersAbilityTypeIds)) do
+                local abilityParameters = parametersAbilityTypeIds[abilityTypeId]
                 local addedAbility = _unit:addAbility(abilityTypeId)
                 if addedAbility ~= nil then
                     _unit:makeAbilityPermanent(abilityTypeId, true)
                     _unit:setAbilityLevel(abilityTypeId, 1 + (abilityParameters.level or ability and ability.level or 0))
-                    for abilityParameterKey, abilityParameterValue in pairs(abilityParameters) do
-                        if abilityParameterKey == "isButtonVisible" then
-                            if not resolveBooleanValue(ability, level, abilityParameterValue) then
-                                _unit:hideAbility(abilityTypeId, true)
-                            end
-                        elseif abilityParameterKey ~= "level" then
-                            abilityParameterKey:setValue(
-                                addedAbility,
-                                resolveNumberValue(ability, level, abilityParameterValue)
-                            )
-                        end
+                    if abilityParameters.isButtonVisible == false then
+                        _unit:hideAbility(abilityTypeId, true)
+                    end
+                    for ____, field in ipairs(abilityParameters.fields or emptyArray()) do
+                        field[1]:setValue(
+                            addedAbility,
+                            resolveNumberValue(ability, level, field[2])
+                        )
                     end
-                    abilityTypeIds[abilityTypeId] = true
+                    abilityTypeIds[#abilityTypeIds + 1] = abilityTypeId
                 end
             end
             local behaviorConstructors = parameters and parameters.behaviorConstructors or defaultParameters.behaviorConstructors
@@ -488,18 +498,20 @@ function Buff.prototype.____constructor(self, _unit, typeIdOrTypeIds, polarityOr
                 self._behaviors = behaviors
             end
         end
-        local additionalParameters = {}
-        for key, value in pairs(parameters) do
-            if not buffParametersKeys[key] then
-                if ability then
-                    additionalParameters[key] = resolveCurrentAbilityDependentValue(ability, value)
-                else
-                    additionalParameters[key] = value
+        if parameters ~= nil then
+            local additionalParameters = {}
+            for ____, key in ipairs(sortedKeysUnnested(parameters)) do
+                if not buffParametersKeys[key] then
+                    if ability then
+                        additionalParameters[key] = resolveCurrentAbilityDependentValue(ability, parameters[key])
+                    else
+                        additionalParameters[key] = parameters[key]
+                    end
                 end
             end
-        end
-        if (next(additionalParameters)) ~= nil then
-            self.parameters = additionalParameters
+            if (next(additionalParameters)) ~= nil then
+                self.parameters = additionalParameters
+            end
         end
     end
     if duration ~= nil and duration > 0 then
@@ -623,7 +635,7 @@ function Buff.prototype.onDestroy(self)
         unit:decrementGhostCounter()
     end
     if self._abilityTypeIds ~= nil then
-        for abilityTypeId in pairs(self._abilityTypeIds) do
+        for ____, abilityTypeId in ipairs(self._abilityTypeIds) do
             unit:removeAbility(abilityTypeId)
         end
     end
@@ -1247,6 +1259,19 @@ __TS__SetDescriptor(
     },
     true
 )
+__TS__SetDescriptor(
+    Buff.prototype,
+    "manaRegenerationRateIncreaseFactor",
+    {
+        get = function(self)
+            return self:getUnitBonus(UnitBonusType.MANA_REGENERATION_RATE_FACTOR)
+        end,
+        set = function(self, manaRegenerationRateIncreaseFactor)
+            self:addOrUpdateOrRemoveUnitBonus(UnitBonusType.MANA_REGENERATION_RATE_FACTOR, manaRegenerationRateIncreaseFactor)
+        end
+    },
+    true
+)
 __TS__SetDescriptor(
     Buff.prototype,
     "duration",
@@ -1380,5 +1405,8 @@ Buff.beingDestroyedEvent = buffBeingDestroyedEvent;
     buffCreatedEvent:addListener(function(buff)
         UnitBehavior:forAll(buff.unit, "onBuffGained", buff)
     end)
+    buffBeingDestroyedEvent:addListener(function(buff)
+        UnitBehavior:forAll(buff.unit, "onBuffLost", buff)
+    end)
 end)(Buff)
 return ____exports

package/engine/internal/mechanics/cast-ability.lua

@@ -74,9 +74,12 @@ ____exports.castAbility = function(nativeUnit, abilityTypeId, prepareAbility, ..
         unitRemoveAbility(nativeUnit, INVENTORY_ABILITY_TYPE_ID)
         if latestInventoryAbilityTypeId ~= 0 then
             unitAddAbility(nativeUnit, latestInventoryAbilityTypeId)
-            for slot, nativeItem in pairs(nativeItemBySlot) do
-                unitAddItem(nativeUnit, nativeItem)
-                unitDropItemSlot(nativeUnit, nativeItem, slot)
+            for slot = 0, inventorySize - 1 do
+                local nativeItem = nativeItemBySlot[slot]
+                if nativeItem ~= nil then
+                    unitAddItem(nativeUnit, nativeItem)
+                    unitDropItemSlot(nativeUnit, nativeItem, slot)
+                end
             end
         end
     end

package/engine/internal/object-data/mana-regeneration-rate-increase-factor.d.ts

@@ -0,0 +1,2 @@
+/** @noSelfInFile */
+export {};

package/engine/internal/object-data/mana-regeneration-rate-increase-factor.lua

@@ -0,0 +1,16 @@
+local ____exports = {}
+local ____mana_2Dregeneration = require("engine.object-data.entry.ability-type.mana-regeneration")
+local ManaRegenerationAbilityType = ____mana_2Dregeneration.ManaRegenerationAbilityType
+---
+-- @internal For use by internal systems.
+____exports.MANA_REGENERATION_RATE_INCREASE_FACTOR_DUMMY_ABILITY_TYPE_ID = compiletime(function()
+    local abilityType = ManaRegenerationAbilityType:create()
+    abilityType.isInternal = true
+    abilityType.isButtonVisible = false
+    abilityType.manaRegenerationRateIncreaseFactor = 4
+    return abilityType.id
+end)
+---
+-- @internal For use by internal systems.
+____exports.MANA_REGENERATION_RATE_INCREASE_FACTOR_ABILITY_FIELD = ABILITY_RLF_MANA_REGENERATION_BONUS_AS_FRACTION_OF_NORMAL
+return ____exports

package/engine/internal/unit/attributes.d.ts

@@ -0,0 +1,17 @@
+/** @noSelfInFile */
+declare module "../unit" {
+    interface Unit {
+        strengthBase: number;
+    }
+}
+declare module "../unit" {
+    interface Unit {
+        agilityBase: number;
+    }
+}
+declare module "../unit" {
+    interface Unit {
+        intelligenceBase: number;
+    }
+}
+export {};

package/engine/internal/unit/attributes.lua

@@ -0,0 +1,46 @@
+local ____lualib = require("lualib_bundle")
+local __TS__ObjectDefineProperty = ____lualib.__TS__ObjectDefineProperty
+local ____exports = {}
+local ____unit = require("engine.internal.unit")
+local Unit = ____unit.Unit
+local ____unit = require("engine.standard.fields.unit")
+local AGILITY_UNIT_FIELD = ____unit.AGILITY_UNIT_FIELD
+local INTELLIGENCE_UNIT_FIELD = ____unit.INTELLIGENCE_UNIT_FIELD
+local STRENGTH_UNIT_FIELD = ____unit.STRENGTH_UNIT_FIELD
+__TS__ObjectDefineProperty(
+    Unit.prototype,
+    "strengthBase",
+    {
+        get = function(self)
+            return STRENGTH_UNIT_FIELD:getValue(self)
+        end,
+        set = function(self, value)
+            STRENGTH_UNIT_FIELD:setValue(self, value)
+        end
+    }
+)
+__TS__ObjectDefineProperty(
+    Unit.prototype,
+    "agilityBase",
+    {
+        get = function(self)
+            return AGILITY_UNIT_FIELD:getValue(self)
+        end,
+        set = function(self, value)
+            AGILITY_UNIT_FIELD:setValue(self, value)
+        end
+    }
+)
+__TS__ObjectDefineProperty(
+    Unit.prototype,
+    "intelligenceBase",
+    {
+        get = function(self)
+            return INTELLIGENCE_UNIT_FIELD:getValue(self)
+        end,
+        set = function(self, value)
+            INTELLIGENCE_UNIT_FIELD:setValue(self, value)
+        end
+    }
+)
+return ____exports