vzcode 2.18.0 → 2.22.0

package/src/client/CodeEditor/getOrCreateEditor.tsx

@@ -67,8 +67,10 @@ import {
 } from '@valtown/codemirror-ts';
 import { getFileExtension } from '../utils/fileExtension';
 import { SparklesSVG } from '../Icons/SparklesSVG';
+import { MINIMAL_EXTENSIONS } from '../featureFlags';
 
 const DEBUG = false;
+const enableToDoPlugin = true;
 
 // Define a StateField to store the file name.
 // This should be defined at the module level if it's to be imported by other modules.
@@ -136,6 +138,7 @@ const languageExtensions = {
   html: () => html(htmlConfig),
   css,
   md: markdown,
+  prompt: markdown,
   svelte,
 };
 
@@ -186,7 +189,7 @@ export const getOrCreateEditor = async ({
   esLintSource,
   rainbowBracketsEnabled = true,
   setIsAIChatOpen,
-  handleSendMessage,
+  setAIChatMessage,
 }: {
   // TODO pass this in from the outside
   paneId?: PaneId;
@@ -223,7 +226,7 @@ export const getOrCreateEditor = async ({
   ) => Promise<readonly Diagnostic[]>;
   rainbowBracketsEnabled?: boolean; // New parameter type
   setIsAIChatOpen: (isAIChatOpen: boolean) => void;
-  handleSendMessage: any; // TODO fix types
+  setAIChatMessage: (message: string) => void;
 }): Promise<ExtendedEditorCacheValue> => {
   // Cache hit
 
@@ -253,8 +256,10 @@ export const getOrCreateEditor = async ({
   // Create a compartment for rainbow brackets so that it can be enabled/disabled dynamically.
   const rainbowBracketsCompartment = new Compartment();
 
+  // Create a compartment for language so that it can be changed dynamically.
+  const languageCompartment = new Compartment();
+
   // The CodeMirror extensions to use.
-  // const extensions = [autocompletion(), html(htmlConfig)]
   const extensions = [];
 
   // Initialize the fileNameStateField with the actual file name
@@ -273,26 +278,29 @@ export const getOrCreateEditor = async ({
       }),
     );
 
-    // Deals with broadcasting changes in cursor location and selection.
-    if (localPresence) {
-      extensions.push(
-        json1PresenceBroadcast({
-          path: textPath,
-          localPresence,
-          usernameRef,
-        }),
-      );
-    }
+    // Only add presence extensions if MINIMAL_EXTENSIONS is false
+    if (!MINIMAL_EXTENSIONS) {
+      // Deals with broadcasting changes in cursor location and selection.
+      if (localPresence) {
+        extensions.push(
+          json1PresenceBroadcast({
+            path: textPath,
+            localPresence,
+            usernameRef,
+          }),
+        );
+      }
 
-    // Deals with receiving the broadcast from other clients and displaying them.
-    if (docPresence) {
-      extensions.push(
-        json1PresenceDisplay({
-          path: textPath,
-          docPresence,
-          enableAutoFollowRef,
-        }),
-      );
+      // Deals with receiving the broadcast from other clients and displaying them.
+      if (docPresence) {
+        extensions.push(
+          json1PresenceDisplay({
+            path: textPath,
+            docPresence,
+            enableAutoFollowRef,
+          }),
+        );
+      }
     }
   } else {
     // If the ShareDB document is not provided,
@@ -300,44 +308,7 @@ export const getOrCreateEditor = async ({
     extensions.push(EditorView.editable.of(false));
   }
 
-  extensions.push(colorsInTextPlugin);
-
-  // This is the "basic setup" for CodeMirror,
-  // which actually adds a ton on functionality.
-  // TODO vet this functionality, and determine how much
-  // we want to replace with
-  // https://github.com/vizhub-core/vzcode/issues/134
-  extensions.push(basicSetup);
-
-  if (esLintSource) {
-    extensions.push(lintGutter()); // Show lint icons in the gutter
-    extensions.push(
-      linter(esLintSource, {
-        // You can configure linter options here, e.g., delay
-        delay: 750,
-      }),
-    );
-  }
-
-  // This supports dynamic changing of the theme.
-  extensions.push(
-    themeCompartment.of(themeOptionsByLabel[theme].value),
-  );
-
-  // Adds compartment for rainbow brackets with initial toggle state.
-  extensions.push(
-    rainbowBracketsCompartment.of(
-      rainbowBracketsEnabled ? rainbowBrackets() : [],
-    ),
-  );
-
-  // TODO handle dynamic changing of the file extension.
-  // TODO handle dynamic file extensions by making
-  // the CodeMirror language extension dynamic
-  // using a Compartment.
-  const languageCompartment = new Compartment();
-  // See https://github.com/vizhub-core/vzcode/issues/55
-
+  // Add language extension (needed for both minimal and full modes)
   const languageExtension =
     getLanguageExtension(fileExtension);
   if (languageExtension) {
@@ -345,232 +316,275 @@ export const getOrCreateEditor = async ({
       languageCompartment.of(languageExtension),
     );
   } else {
-    // Not sure if this case even works.
-    // TODO manually test this case by creating a file
-    // that has no extension, opening it up,
-    // and then adding an extension.
-    // console.warn(
-    //   `No language extension for file extension: ${fileExtension}`,
-    // );
-    // We still need to push the compartment,
-    // otherwise the compartment won't work when
-    // a file extension _is_ added later on.
     extensions.push(languageCompartment.of([]));
   }
 
-  // Enable line wrapping for Markdown files
-  if (fileExtension === 'md') {
-    extensions.push(EditorView.lineWrapping);
-  }
+  // If MINIMAL_EXTENSIONS is true, only include the JSON1 OT extension and essential functionality
+  if (MINIMAL_EXTENSIONS) {
+    // Only the most basic extensions are added
+    // The JSON1 OT extension and language extension are already added above
+  } else {
+    // Full feature set - include all extensions
+    extensions.push(colorsInTextPlugin);
+
+    // This is the "basic setup" for CodeMirror,
+    // which actually adds a ton on functionality.
+    // TODO vet this functionality, and determine how much
+    // we want to replace with
+    // https://github.com/vizhub-core/vzcode/issues/134
+    extensions.push(basicSetup);
+
+    if (esLintSource) {
+      extensions.push(lintGutter()); // Show lint icons in the gutter
+      extensions.push(
+        linter(esLintSource, {
+          // You can configure linter options here, e.g., delay
+          delay: 750,
+        }),
+      );
+    }
 
-  // Add interactive widgets.
-  // Includes the Alt+drag functionality for numbers.
-  // Calls `onInteract` when one of those widgets is interacted with.
-  // This can be used to trigger a transition to throttled mode
-  // for hot reloading.
-  // TODO consider leveraging the new `dragEnd` event handler.
-  // and removing the `onInteract` callback, replacing it with
-  // `onInteractStart` and `onInteractEnd`.
-  // That may be tricky for one-off interactions though, like
-  // the boolean checkboxes. The color pickers are also tricky,
-  // as they would also need to be able to handle `onInteractEnd`.
-  // See https://github.com/replit/codemirror-interact/issues/14
-  extensions.push(
-    widgets({ onInteract, customInteractRules }),
-  );
+    // This supports dynamic changing of the theme.
+    extensions.push(
+      themeCompartment.of(themeOptionsByLabel[theme].value),
+    );
 
-  // TODO fix the bugginess in this one where
-  // the highlight persists after the mouse leaves.
-  // extensions.push(highlightWidgets);
-
-  extensions.push(rotationIndicator);
-
-  // extensions.push(
-  //   AIAssistCodeMirrorKeyMap({
-  //     shareDBDoc,
-  //     fileId,
-  //     tabList,
-  //     aiAssistEndpoint,
-  //     aiAssistOptions,
-  //   }),
-  // );
-
-  // Add the extension that provides indentation markers.
-  extensions.push(
-    indentationMarkers({
-      // thickness: 2,
-      colors: {
-        light: '#4d586b',
-        dark: '#4d586b',
-        activeLight: '#8e949f',
-        activeDark: '#8e949f',
-      },
-    }),
-  );
+    // Adds compartment for rainbow brackets with initial toggle state.
+    extensions.push(
+      rainbowBracketsCompartment.of(
+        rainbowBracketsEnabled ? rainbowBrackets() : [],
+      ),
+    );
 
-  if (name.endsWith('ts') || name.endsWith('tsx')) {
-    // Initialize worker if needed
-    const tsWorker = await initializeWorker();
+    // Enable line wrapping for Markdown files
+    if (
+      fileExtension === 'md' ||
+      fileExtension === 'prompt'
+    ) {
+      extensions.push(EditorView.lineWrapping);
+    }
 
+    // Add interactive widgets.
+    // Includes the Alt+drag functionality for numbers.
+    // Calls `onInteract` when one of those widgets is interacted with.
+    // This can be used to trigger a transition to throttled mode
+    // for hot reloading.
+    // TODO consider leveraging the new `dragEnd` event handler.
+    // and removing the `onInteract` callback, replacing it with
+    // `onInteractStart` and `onInteractEnd`.
+    // That may be tricky for one-off interactions though, like
+    // the boolean checkboxes. The color pickers are also tricky,
+    // as they would also need to be able to handle `onInteractEnd`.
+    // See https://github.com/replit/codemirror-interact/issues/14
     extensions.push(
-      ...[
-        tsFacetWorker.of({ worker: tsWorker, path: name }),
-        tsSyncWorker(),
-        tsLinterWorker(),
-        autocompletion({
-          override: [tsAutocompleteWorker()],
-        }),
-        tsHoverWorker(),
-      ],
+      widgets({ onInteract, customInteractRules }),
     );
-  }
 
-  // Show the minimap
-  // See https://github.com/replit/codemirror-minimap#usage
-  // This extension has poor performance, so it's disabled for now.
-  // extensions.push(
-  //   showMinimap.compute(['doc'], () => ({
-  //     create: () => ({
-  //       dom: document.createElement('div'),
-  //     }),
-  //     // Without this, performance is terrible.
-  //     displayText: 'blocks',
-  //   })),
-  // );
-
-  // VSCode keybindings
-  // See https://github.com/replit/codemirror-vscode-keymap#usage
-  // extensions.push(keymap.of(vscodeKeymap));
-  extensions.push(
-    keymap.of(
-      vscodeKeymap.map((binding) => {
-        // Here we override the Shift+Enter behavior specifically,
-        // as that can be used to trigger a manual save/Prettier,
-        // and the default behavior from the keymap interferes.
-        if (binding.key === 'Enter') {
-          delete binding.shift;
-        }
-        return binding;
-      }),
-    ),
-  );
+    // TODO fix the bugginess in this one where
+    // the highlight persists after the mouse leaves.
+    // extensions.push(highlightWidgets);
 
-  // Adds copilot completions
-  DEBUG &&
-    console.log(
-      '[getOrCreateEditor] aiCopilotEndpoint: ',
-      aiCopilotEndpoint,
+    extensions.push(rotationIndicator);
+
+    // extensions.push(
+    //   AIAssistCodeMirrorKeyMap({
+    //     shareDBDoc,
+    //     fileId,
+    //     tabList,
+    //     aiAssistEndpoint,
+    //     aiAssistOptions,
+    //   }),
+    // );
+
+    // Add the extension that provides indentation markers.
+    extensions.push(
+      indentationMarkers({
+        // thickness: 2,
+        colors: {
+          light: '#4d586b',
+          dark: '#4d586b',
+          activeLight: '#8e949f',
+          activeDark: '#8e949f',
+        },
+      }),
     );
-  if (aiCopilotEndpoint) {
-    extensions.push(copilot({ aiCopilotEndpoint }));
-  }
 
-  // const { setIsAIChatOpen } = useContext(VZCodeContext);
+    if (name.endsWith('ts') || name.endsWith('tsx')) {
+      // Initialize worker if needed
+      const tsWorker = await initializeWorker();
 
-  // Widget appears after instances of "todo" in code editor, allowing AI to implement todo tasks when clicked
-  function createToDoPlugin() {
-    // setIsAIChatOpen: (open: boolean) => void,
-    class ToDoWidget extends WidgetType {
-      constructor() {
-        super();
-      }
+      extensions.push(
+        ...[
+          tsFacetWorker.of({
+            worker: tsWorker,
+            path: name,
+          }),
+          tsSyncWorker(),
+          tsLinterWorker(),
+          autocompletion({
+            override: [tsAutocompleteWorker()],
+          }),
+          tsHoverWorker(),
+        ],
+      );
+    }
 
-      eq(_other: ToDoWidget) {
-        return false;
-      }
+    // Show the minimap
+    // See https://github.com/replit/codemirror-minimap#usage
+    // This extension has poor performance, so it's disabled for now.
+    // extensions.push(
+    //   showMinimap.compute(['doc'], () => ({
+    //     create: () => ({
+    //       dom: document.createElement('div'),
+    //     }),
+    //     // Without this, performance is terrible.
+    //     displayText: 'blocks',
+    //   })),
+    // );
 
-      toDOM() {
-        const wrap = document.createElement('i');
-        wrap.style.display = 'inline-flex'; // prevent block expansion
-        wrap.style.alignItems = 'center';
-        wrap.style.justifyContent = 'center';
-        wrap.className = 'icon-button icon-button-dark';
-        const reactContainer =
-          document.createElement('div');
-        wrap.appendChild(reactContainer);
-
-        const root = createRoot(reactContainer);
-        root.render(
-          <div
-            onClick={() => {
-              setIsAIChatOpen(true);
-              // setAIChatMessage('Implement the TODO');
-              handleSendMessage('Implement the TODO');
-            }}
-          >
-            <SparklesSVG width={14} height={14} />
-          </div>,
-        );
-        return wrap;
-      }
+    // VSCode keybindings
+    // See https://github.com/replit/codemirror-vscode-keymap#usage
+    // extensions.push(keymap.of(vscodeKeymap));
+    extensions.push(
+      keymap.of(
+        vscodeKeymap.map((binding) => {
+          // Here we override the Shift+Enter behavior specifically,
+          // as that can be used to trigger a manual save/Prettier,
+          // and the default behavior from the keymap interferes.
+          if (binding.key === 'Enter') {
+            delete binding.shift;
+          }
+          return binding;
+        }),
+      ),
+    );
 
-      ignoreEvent() {
-        return false;
-      }
+    // Adds copilot completions
+    DEBUG &&
+      console.log(
+        '[getOrCreateEditor] aiCopilotEndpoint: ',
+        aiCopilotEndpoint,
+      );
+    if (aiCopilotEndpoint) {
+      extensions.push(copilot({ aiCopilotEndpoint }));
     }
 
-    function toDoWidgets(editor: EditorView) {
-      const { state } = editor;
-      const tree = syntaxTree(state);
-      const findToDo = new RegExpCursor(state.doc, 'todo', {
-        ignoreCase: true,
-      });
-      const widgets: Range<Decoration>[] = [];
-
-      while (!findToDo.next().done) {
-        const { from, to } = findToDo.value;
-        const node = tree.resolve(from);
-        let inComment = false;
-
-        // Walk up the parents until we hit the root, looking for a comment node
-        for (let cur: any = node; cur; cur = cur.parent) {
-          if (
-            cur.type.is('Comment') || // grammars that group comments
-            cur.type.is('comment') || // generic lowercase group
-            /Comment$/.test(cur.type.name) // fallback for e.g. LineComment
-          ) {
-            inComment = true;
-            break;
-          }
+    // const { setIsAIChatOpen } = useContext(VZCodeContext);
+
+    // Widget appears after instances of "todo" in code editor, allowing AI to implement todo tasks when clicked
+    function createToDoPlugin() {
+      // setIsAIChatOpen: (open: boolean) => void,
+      class ToDoWidget extends WidgetType {
+        constructor() {
+          super();
         }
-        if (!inComment) continue; // skip non-comment TODOs
 
-        const deco = Decoration.widget({
-          widget: new ToDoWidget(),
-          side: 1,
-        }).range(to);
-        widgets.push(deco);
-      }
-      return Decoration.set(widgets);
-    }
+        eq(_other: ToDoWidget) {
+          return false;
+        }
 
-    const todoPlugin = ViewPlugin.fromClass(
-      class {
-        decorations: DecorationSet;
+        toDOM() {
+          const wrap = document.createElement('i');
+          wrap.style.display = 'inline-flex'; // prevent block expansion
+          wrap.style.alignItems = 'center';
+          wrap.style.justifyContent = 'center';
+          wrap.className = 'icon-button icon-button-dark';
+          wrap.style.cursor = 'pointer';
+
+          // Handle click directly on the wrapper element
+          wrap.addEventListener('click', (e) => {
+            e.preventDefault();
+            e.stopPropagation();
+            setAIChatMessage('Implement the TODO');
+            setIsAIChatOpen(true);
+          });
+
+          const reactContainer =
+            document.createElement('div');
+          wrap.appendChild(reactContainer);
+
+          const root = createRoot(reactContainer);
+          root.render(
+            <SparklesSVG width={14} height={14} />,
+          );
+
+          return wrap;
+        }
 
-        constructor(view: EditorView) {
-          this.decorations = toDoWidgets(view);
+        ignoreEvent() {
+          return false;
         }
+      }
+
+      function toDoWidgets(editor: EditorView) {
+        const { state } = editor;
+        const tree = syntaxTree(state);
+        const findToDo = new RegExpCursor(
+          state.doc,
+          'todo',
+          {
+            ignoreCase: true,
+          },
+        );
+        const widgets: Range<Decoration>[] = [];
+
+        while (!findToDo.next().done) {
+          const { from, to } = findToDo.value;
+          const node = tree.resolve(from);
+          let inComment = false;
+
+          // Walk up the parents until we hit the root, looking for a comment node
+          for (let cur: any = node; cur; cur = cur.parent) {
+            if (
+              cur.type.is('Comment') || // grammars that group comments
+              cur.type.is('comment') || // generic lowercase group
+              /Comment$/.test(cur.type.name) // fallback for e.g. LineComment
+            ) {
+              inComment = true;
+              break;
+            }
+          }
+          if (!inComment) continue; // skip non-comment TODOs
 
-        update(update: ViewUpdate) {
-          if (
-            update.docChanged ||
-            update.viewportChanged ||
-            syntaxTree(update.startState) !==
-              syntaxTree(update.state)
-          )
-            this.decorations = toDoWidgets(update.view);
+          const deco = Decoration.widget({
+            widget: new ToDoWidget(),
+            side: 1,
+          }).range(to);
+          widgets.push(deco);
         }
-      },
-      {
-        decorations: (v) => v.decorations,
-      },
-    );
+        return Decoration.set(widgets);
+      }
 
-    return todoPlugin;
-  }
+      const todoPlugin = ViewPlugin.fromClass(
+        class {
+          decorations: DecorationSet;
+
+          constructor(view: EditorView) {
+            this.decorations = toDoWidgets(view);
+          }
 
-  extensions.push(createToDoPlugin());
+          update(update: ViewUpdate) {
+            if (
+              update.docChanged ||
+              update.viewportChanged ||
+              syntaxTree(update.startState) !==
+                syntaxTree(update.state)
+            )
+              this.decorations = toDoWidgets(update.view);
+          }
+        },
+        {
+          decorations: (v) => v.decorations,
+        },
+      );
+
+      return todoPlugin;
+    }
+
+    if (enableToDoPlugin) {
+      extensions.push(createToDoPlugin());
+    }
+  }
 
   const editor = new EditorView({
     state: EditorState.create({

package/src/client/CodeEditor/index.tsx

@@ -43,7 +43,7 @@ export const CodeEditor = ({
     codeEditorRef,
     enableAutoFollow,
     setIsAIChatOpen,
-    handleSendMessage,
+    setAIChatMessage,
   } = useContext(VZCodeContext);
 
   // Set `doc.data.isInteracting` to `true` when the user is interacting
@@ -117,7 +117,7 @@ export const CodeEditor = ({
         aiCopilotEndpoint,
         esLintSource,
         setIsAIChatOpen,
-        handleSendMessage,
+        setAIChatMessage,
       });
 
       if (isMounted) {
@@ -142,7 +142,7 @@ export const CodeEditor = ({
     aiCopilotEndpoint,
     esLintSource,
     setIsAIChatOpen,
-    handleSendMessage,
+    setAIChatMessage,
   ]);
 
   // Every time the active file switches from one file to another,

package/src/client/VZRight.tsx

@@ -92,6 +92,10 @@ export const VZRight = () => {
         enableHotReloading: isInteracting,
         enableSourcemap: true,
         vizId: 'example-viz',
+
+        // Don't clear the console here in VZCode, since
+        // we often want to see debug logs across multiple runs.
+        clearConsole: false,
       });
       isFirstRunRef.current = false;
     }

package/src/client/VZSidebar/AIChat/ChatInput.tsx

@@ -168,7 +168,7 @@ const ChatInputComponent = ({
       <Form.Group className="ai-chat-input-group">
         <Form.Control
           as="textarea"
-          rows={5}
+          rows={10}
           value={aiChatMessage}
           onChange={handleChange}
           onKeyDown={handleKeyDown}