vydanne 0.8.0 → 0.9.0

package/README.md

@@ -224,7 +224,7 @@ Two details worth knowing:
 
 | Command | In plain English |
 |---|---|
-| `preflight` | **Run this first.** Checks the listing is complete, nothing is over a character limit, no locale mentions the other app store — and that the screenshots on the store are your *current* ones, not a stale set. Green means submittable. |
+| `preflight` | **Run this first.** Checks the listing is complete, nothing is over a character limit, no locale mentions the other app store — and that the screenshots on the store are your *current* ones, not a stale set. It also asserts the fields no local file drives and that no diff can therefore see: copyright, the App Review contact, the age rating, the primary category and the content-rights declaration. Those are each set by their own command, so a listing that never ran one had them EMPTY while this printed green. Green means submittable. |
 | `prepare` | Starts the next release: creates the App Store version you're preparing and attaches your newest build to it. **Needed before `fill` on an app that already has a version on sale** — until a draft exists there is nothing for the listing text to go into. Reuses the draft if it's already there, so it's safe to re-run. It does *not* submit. |
 | `push` | **The whole release, one command**: runs `prepare` → `fill` → `previews` → `age-rating` → `review-contact` → `accessibility` → `preflight`, in that order, stopping at the first failure. Dry run without `--apply`, like everything else. Ends at a green preflight — it never submits. |
 | `diff` | Shows exactly what's different between your files and what's live. Nothing is changed — a safe preview. |

package/bin/vydanne.mjs

@@ -128,6 +128,10 @@ usage: vydanne <command> [--apply] [--config vydanne.config.mjs]
                   skipped); every skip is reported again at the end, so green still means green.
                   Ends at a green preflight — Add to Review + Submit stay yours, in the web UI.
 ✎ fill            metadata + screenshots + previews (native; iOS & macOS separate)
+✎ appinfo         App Store category + the content-rights answer — the two app-level facts that
+                  block Add for Review and belong to no single release. 'categories' takes Apple's
+                  ids (GAMES, GAMES_PUZZLE — not display names); 'contentRights: false' for an app
+                  showing no third-party content. Set once; re-running is a no-op.
 ✎ age-rating      set the age rating (AppInfo declaration)
 ✎ review-contact  App Review contact from the gitignored files
 ✎ accessibility   Accessibility Nutrition Labels (draft; VYDANNE_A11Y_PUBLISH=1 to publish once live)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vydanne",
-  "version": "0.8.0",
+  "version": "0.9.0",
   "description": "App Store Connect + Google Play submission prep — the companion to zdymak (media). Native Node (no fastlane/Ruby/Python): localized listings, screenshot/preview/icon upload, ratings, review contact, accessibility & privacy labels, IAP, export docs, build upload to TestFlight / a Play closed track, a diff of local-vs-store, and a preflight verifier that encodes the store gotchas. Never submits for review. iOS/macOS via the ASC REST API; Android via the Play Developer Edits API (--store google).",
   "keywords": [
     "app-store-connect",

package/src/commands/preflight.mjs

@@ -16,6 +16,27 @@ export async function run(config, client) {
   // the README listed them among the limits "checked before upload". Read-only, so `allowLive` is
   // right: on an app with nothing in preparation the live record is the only one to measure.
   const info = await client.appInfo({ allowLive: true });
+
+  // ── The fields no LOCAL file drives ─────────────────────────────────────────────────────────────
+  //
+  // Everything else here compares local metadata against the store, which is the right question for
+  // anything `fill` uploads and the wrong one for the half-dozen fields set by their own standalone
+  // command. Those are invisible to a local-vs-remote diff: there is nothing local to differ from, so
+  // a field that was NEVER SET reads exactly like one that matches.
+  //
+  // Reported from the field: a listing reached PREPARE_FOR_SUBMISSION with an empty copyright and no
+  // App Review contact at all, while this command printed "no blockers". `prepare` sets the first and
+  // `review-contact` the second; neither is part of `fill`, and neither had ever been run. Preflight
+  // was not wrong so much as asked the wrong question — so it now also asks whether the listing is
+  // SUBMITTABLE, which only the store can answer.
+  const rights = client.app?.attributes?.contentRightsDeclaration;
+  if (!rights) problems.push("content rights not declared — `vydanne appinfo --apply`");
+  if (info) {
+    if (!info.attributes.appStoreAgeRating) problems.push("age rating not declared — `vydanne age-rating --apply`");
+    const primary = (await client.get(`/v1/appInfos/${info.id}/primaryCategory`)).json?.data?.id;
+    if (!primary) problems.push("primary category not set — `vydanne appinfo --apply`");
+  }
+
   if (info) {
     const infoLocs = (await client.get(`/v1/appInfos/${info.id}/appInfoLocalizations?limit=200`)).json.data || [];
     for (const il of infoLocs) {
@@ -37,6 +58,23 @@ export async function run(config, client) {
       continue;
     }
     console.log(`  ${platform}: version ${v.attributes.versionString} (${v.attributes.appStoreState})`);
+
+    // Required, and set by `prepare` from <metadataDir>/copyright.txt — not by `fill`.
+    if (!v.attributes.copyright) {
+      problems.push(`${platform}: copyright EMPTY — set ${config.metadataDir}/copyright.txt, then \`vydanne prepare --apply\``);
+    }
+
+    // The App Review contact. Apple will not take a submission without one, and it is per-VERSION, so
+    // a contact set on a previous version does not carry forward on its own.
+    const detail = (await client.get(`/v1/appStoreVersions/${v.id}/appStoreReviewDetail`)).json?.data?.attributes;
+    const CONTACT = ["contactFirstName", "contactLastName", "contactPhone", "contactEmail"];
+    const missing = detail ? CONTACT.filter((f) => !detail[f]) : CONTACT;
+    if (missing.length) {
+      problems.push(`${platform}: App Review contact ${detail ? `missing ${missing.join(", ")}` : "not set"} — \`vydanne review-contact --apply\``);
+    } else if (detail.demoAccountRequired && !detail.demoAccountName) {
+      // The rejection `review-contact` exists to avoid, arriving by the door of nobody running it.
+      problems.push(`${platform}: demoAccountRequired is true but no demo account is set — Apple rejects this`);
+    }
     const locs = await client.versionLocalizations(v.id);
     const ascLocales = [...new Set([config.primaryLocale, ...Object.values(res.supported)])];