vydanne 0.4.0 → 0.4.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vydanne",
-  "version": "0.4.0",
+  "version": "0.4.2",
   "description": "App Store Connect + Google Play submission prep — the companion to zdymak (media). Native Node (no fastlane/Ruby/Python): localized listings, screenshot/preview/icon upload, ratings, review contact, accessibility & privacy labels, IAP, export docs, a diff of local-vs-store, and a preflight verifier that encodes the store gotchas. iOS/macOS via the ASC REST API; Android via the Play Developer Edits API (--store google).",
   "keywords": [
     "app-store-connect",

package/src/client.mjs

@@ -3,7 +3,12 @@ import { makeToken } from "./jwt.mjs";
 const API = "https://api.appstoreconnect.apple.com";
 const IRIS = "https://appstoreconnect.apple.com/iris";
 const DEAD_VERSION = ["READY_FOR_SALE", "REMOVED_FROM_SALE", "REPLACED_WITH_NEW_VERSION"];
-const DEAD_INFO = ["READY_FOR_SALE", "REPLACED_WITH_NEW_VERSION", "REMOVED_FROM_SALE"];
+// READY_FOR_DISTRIBUTION is Apple's newer name for the LIVE app-info (they're migrating the
+// state vocabulary; versions still report appStoreState=READY_FOR_SALE). Without it here,
+// appInfo() treats the live record as editable and every name/subtitle PATCH comes back
+// ENTITY_ERROR.ATTRIBUTE.INVALID.INVALID_STATE — which fails the whole locale in `fill`,
+// release notes included, on any app that already has a version on sale.
+const DEAD_INFO = ["READY_FOR_SALE", "READY_FOR_DISTRIBUTION", "REPLACED_WITH_NEW_VERSION", "REMOVED_FROM_SALE"];
 
 // Thin ASC REST client. Encodes the gotchas: `iris` host (App Privacy 401s the JWT), version + app-info
 // fetched from the FULL list (get_edit filters out READY_FOR_REVIEW), and individual localization reads

package/src/play/commands/prerelease.mjs

@@ -46,10 +46,22 @@ export async function run(config, client) {
 
   const editId = await client.newEdit();
   try {
-    const bundle = await client.uploadBundle(editId, aab);
-    const versionCode = bundle.versionCode;
-    if (!versionCode) throw new Error(`upload returned no versionCode: ${JSON.stringify(bundle).slice(0, 200)}`);
-    console.log(green(`  uploaded versionCode ${versionCode}`));
+    // Upload, or REUSE. Play rejects a versionCode it already holds, which is the right answer for an
+    // accidental re-upload but wrong for the common case of promoting a build you already pushed to one
+    // testing track onto another. The API names the code in its refusal, so take it and carry on — the
+    // bytes are already up there, and a bundle is immutable, so reusing it can't diverge from the file.
+    let versionCode;
+    try {
+      const bundle = await client.uploadBundle(editId, aab);
+      versionCode = bundle.versionCode;
+      if (!versionCode) throw new Error(`upload returned no versionCode: ${JSON.stringify(bundle).slice(0, 200)}`);
+      console.log(green(`  uploaded versionCode ${versionCode}`));
+    } catch (e) {
+      const used = /Version code (\d+) has already been used/.exec(e.message);
+      if (!used) throw e;
+      versionCode = Number(used[1]);
+      console.log(yellow(`  versionCode ${versionCode} already uploaded — reusing that bundle`));
+    }
 
     const releaseNotes = readNotes(g.metadataDir, versionCode, g.defaultLocale);
     if (releaseNotes.length) {