vydanne 0.14.0 → 0.14.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vydanne",
-  "version": "0.14.0",
+  "version": "0.14.1",
   "description": "App Store Connect + Google Play submission prep — the companion to zdymak (media). Native Node (no fastlane/Ruby/Python): localized listings, screenshot/preview/icon upload, ratings, review contact, accessibility & privacy labels, IAP, export docs, build upload to TestFlight / a Play closed track, a diff of local-vs-store, and a preflight verifier that encodes the store gotchas. Never submits for review. iOS/macOS via the ASC REST API; Android via the Play Developer Edits API (--store google).",
   "keywords": [
     "app-store-connect",

package/src/commands/prepare.mjs

@@ -54,10 +54,19 @@ async function versionsFor(client, platform) {
   return json.data || [];
 }
 
-/** The newest build, together with the marketing version its archive declares. */
-async function newestBuildWithVersion(client) {
+/**
+ * The newest build FOR THIS PLATFORM, together with the marketing version its archive declares.
+ *
+ * Filtered by platform, which it was not: an app shipping on iOS and the Mac App Store uploads a build
+ * to each, and the unfiltered query returned whichever went up last. Preparing MAC_OS then tried to
+ * attach an iOS build and Apple answered 409 — so the Mac version was left holding nothing, or an older
+ * build, purely because the iOS one was newer. The 409 made it visible; a same-platform mix-up would
+ * not have been.
+ */
+async function newestBuildWithVersion(client, platform) {
   const { json } = await client.get(
     `/v1/builds?filter[app]=${client.appId}&sort=-uploadedDate&limit=1` +
+      (platform ? `&filter[preReleaseVersion.platform]=${platform}` : "") +
       `&fields[builds]=version,processingState&include=preReleaseVersion` +
       `&fields[preReleaseVersions]=version`,
   );
@@ -218,7 +227,7 @@ export async function run(config, client) {
 async function prepareOne(config, client, platform) {
   console.log(green(`prepare → App Store version (${platform})`));
 
-  const { build, marketing } = await newestBuildWithVersion(client);
+  const { build, marketing } = await newestBuildWithVersion(client, platform);
   const target = process.env.VYDANNE_VERSION || marketing;
 
   if (!target) {

package/src/commands/withdraw.mjs

@@ -56,7 +56,12 @@ export async function run(config, client) {
     console.log("  no versions on this app");
     return true;
   }
-  const version = mine[0];
+  // Pick the version that is ACTUALLY in review, not merely the first one Apple returned. An app on two
+  // platforms has two 1.2 records, and `mine[0]` was whichever came back first: with iOS
+  // WAITING_FOR_REVIEW and macOS PREPARE_FOR_SUBMISSION, this reported "not submitted — nothing to
+  // withdraw" and exited 0, never looking at the submission it was asked to cancel. Silence is the worst
+  // possible answer here, because the operator walks away believing the withdrawal happened.
+  const version = mine.find((v) => WITHDRAWABLE[v.attributes.appStoreState]) || mine[0];
   const state = version.attributes.appStoreState;
   const label = `${version.attributes.versionString} (${state})`;