vuetify 2.6.0-beta.0 → 2.6.3

package/src/locale/it.ts

@@ -22,8 +22,8 @@ export default {
     itemsPerPageAll: 'Tutti',
     nextPage: 'Pagina seguente',
     prevPage: 'Pagina precedente',
-    firstPage: 'Pagina prima',
-    lastPage: 'Pagina ultima',
+    firstPage: 'Prima pagina',
+    lastPage: 'Ultima pagina',
     pageText: '{0}-{1} di {2}',
   },
   datePicker: {
@@ -38,15 +38,15 @@ export default {
     prev: 'Vista precedente',
     next: 'Prossima vista',
     ariaLabel: {
-      delimiter: 'Carousel slide {0} of {1}',
+      delimiter: 'Carousel slide {0} di {1}',
     },
   },
   calendar: {
     moreEvents: '{0} di più',
   },
   fileInput: {
-    counter: '{0} files',
-    counterSize: '{0} files ({1} in totale)',
+    counter: '{0} file',
+    counterSize: '{0} file ({1} in totale)',
   },
   timePicker: {
     am: 'AM',
@@ -63,7 +63,7 @@ export default {
   },
   rating: {
     ariaLabel: {
-      icon: 'Rating {0} of {1}',
+      icon: 'Valutazione {0} di {1}',
     },
   },
 }

package/src/mixins/activatable/__tests__/__snapshots__/activatable.spec.ts.snap

@@ -2,8 +2,7 @@
 
 exports[`activatable.ts should render activator slot with hover 1`] = `
 <div>
-  <button role="button"
-          aria-haspopup="true"
+  <button aria-haspopup="true"
           aria-expanded="false"
   >
   </button>

package/src/mixins/activatable/index.ts

@@ -30,6 +30,10 @@ export default baseMixins.extend({
     },
     disabled: Boolean,
     internalActivator: Boolean,
+    openOnClick: {
+      type: Boolean,
+      default: true,
+    },
     openOnHover: Boolean,
     openOnFocus: Boolean,
   },
@@ -89,7 +93,7 @@ export default baseMixins.extend({
     },
     genActivatorAttributes () {
       return {
-        role: 'button',
+        role: (this.openOnClick && !this.openOnHover) ? 'button' : undefined,
         'aria-haspopup': true,
         'aria-expanded': String(this.isActive),
       }
@@ -108,7 +112,7 @@ export default baseMixins.extend({
           this.getActivator(e)
           this.runDelay('close')
         }
-      } else {
+      } else if (this.openOnClick) {
         listeners.click = (e: MouseEvent) => {
           const activator = this.getActivator(e)
           if (activator) activator.focus()

package/src/mixins/detachable/index.ts

@@ -25,6 +25,14 @@ function validateAttachTarget (val: any) {
   return val.nodeType === Node.ELEMENT_NODE
 }
 
+function removeActivator (activator: VNode[]) {
+  activator.forEach(node => {
+    node.elm &&
+    node.elm.parentNode &&
+    node.elm.parentNode.removeChild(node.elm)
+  })
+}
+
 /* @vue/component */
 export default mixins<options &
   /* eslint-disable indent */
@@ -87,24 +95,33 @@ export default mixins<options &
   },
 
   beforeDestroy () {
-    // IE11 Fix
-    try {
-      if (
-        this.$refs.content &&
-        this.$refs.content.parentNode
-      ) {
-        this.$refs.content.parentNode.removeChild(this.$refs.content)
-      }
+    if (
+      this.$refs.content &&
+      this.$refs.content.parentNode
+    ) {
+      this.$refs.content.parentNode.removeChild(this.$refs.content)
+    }
+  },
 
-      if (this.activatorNode) {
-        const activator = Array.isArray(this.activatorNode) ? this.activatorNode : [this.activatorNode]
-        activator.forEach(node => {
-          node.elm &&
-            node.elm.parentNode &&
-            node.elm.parentNode.removeChild(node.elm)
+  destroyed () {
+    if (this.activatorNode) {
+      const activator = Array.isArray(this.activatorNode) ? this.activatorNode : [this.activatorNode]
+      if (this.$el.isConnected) {
+        // Component has been destroyed but the element still exists, we must be in a transition
+        // Wait for the transition to finish before cleaning up the detached activator
+        const observer = new MutationObserver(list => {
+          if (
+            list.some(record => Array.from(record.removedNodes).includes(this.$el))
+          ) {
+            observer.disconnect()
+            removeActivator(activator)
+          }
         })
+        observer.observe(this.$el.parentNode!, { subtree: false, childList: true })
+      } else {
+        removeActivator(activator)
       }
-    } catch (e) { console.log(e) } /* eslint-disable-line no-console */
+    }
   },
 
   methods: {

package/src/mixins/intersectable/index.ts

@@ -11,19 +11,28 @@ export default function intersectable (options: { onVisible: string[] }) {
   return Vue.extend({
     name: 'intersectable',
 
+    data: () => ({
+      isIntersecting: false,
+    }),
+
     mounted () {
       Intersect.inserted(this.$el as HTMLElement, {
         name: 'intersect',
         value: this.onObserve,
-      })
+      }, this.$vnode)
     },
 
     destroyed () {
-      Intersect.unbind(this.$el as HTMLElement)
+      Intersect.unbind(this.$el as HTMLElement, {
+        name: 'intersect',
+        value: this.onObserve,
+      }, this.$vnode)
     },
 
     methods: {
       onObserve (entries: IntersectionObserverEntry[], observer: IntersectionObserver, isIntersecting: boolean) {
+        this.isIntersecting = isIntersecting
+
         if (!isIntersecting) return
 
         for (let i = 0, length = options.onVisible.length; i < length; i++) {

package/src/mixins/menuable/index.ts

@@ -78,7 +78,6 @@ export default baseMixins.extend<options>().extend({
       default: 0,
     },
     offsetOverflow: Boolean,
-    openOnClick: Boolean,
     positionX: {
       type: Number,
       default: null,
@@ -140,7 +139,8 @@ export default baseMixins.extend<options>().extend({
       const activatorLeft = (this.attach !== false ? a.offsetLeft : a.left) || 0
       const minWidth = Math.max(a.width, c.width)
       let left = 0
-      left += this.left ? activatorLeft - (minWidth - a.width) : activatorLeft
+      left += activatorLeft
+      if (this.left || (this.$vuetify.rtl && !this.right)) left -= (minWidth - a.width)
       if (this.offsetX) {
         const maxWidth = isNaN(Number(this.maxWidth))
           ? a.width
@@ -298,13 +298,15 @@ export default baseMixins.extend<options>().extend({
 
       const onClick = listeners.click
 
-      listeners.click = (e: MouseEvent & KeyboardEvent & FocusEvent) => {
-        if (this.openOnClick) {
-          onClick && onClick(e)
-        }
+      if (onClick) {
+        listeners.click = (e: MouseEvent & KeyboardEvent & FocusEvent) => {
+          if (this.openOnClick) {
+            onClick && onClick(e)
+          }
 
-        this.absoluteX = e.clientX
-        this.absoluteY = e.clientY
+          this.absoluteX = e.clientX
+          this.absoluteY = e.clientY
+        }
       }
 
       return listeners

package/src/mixins/overlayable/index.ts

@@ -156,20 +156,32 @@ export default Vue.extend<Vue & Toggleable & Stackable & options>().extend({
       if (!el || el.nodeType !== Node.ELEMENT_NODE) return false
 
       const style = window.getComputedStyle(el)
-      return ['auto', 'scroll'].includes(style.overflowY!) && el.scrollHeight > el.clientHeight
+      return ((['auto', 'scroll'].includes(style.overflowY!) || el.tagName === 'SELECT') && el.scrollHeight > el.clientHeight) ||
+      ((['auto', 'scroll'].includes(style.overflowX!)) && el.scrollWidth > el.clientWidth)
     },
-    shouldScroll (el: Element, delta: number): boolean {
+    shouldScroll (el: Element, e: WheelEvent): boolean {
       if (el.hasAttribute('data-app')) return false
 
-      const alreadyAtTop = el.scrollTop === 0
-      const alreadyAtBottom = el.scrollTop + el.clientHeight === el.scrollHeight
+      const dir = e.shiftKey || e.deltaX ? 'x' : 'y'
+      const delta = dir === 'y' ? e.deltaY : e.deltaX || e.deltaY
+
+      let alreadyAtStart: boolean
+      let alreadyAtEnd: boolean
+      if (dir === 'y') {
+        alreadyAtStart = el.scrollTop === 0
+        alreadyAtEnd = el.scrollTop + el.clientHeight === el.scrollHeight
+      } else {
+        alreadyAtStart = el.scrollLeft === 0
+        alreadyAtEnd = el.scrollLeft + el.clientWidth === el.scrollWidth
+      }
+
       const scrollingUp = delta < 0
       const scrollingDown = delta > 0
 
-      if (!alreadyAtTop && scrollingUp) return true
-      if (!alreadyAtBottom && scrollingDown) return true
-      if ((alreadyAtTop || alreadyAtBottom)) {
-        return this.shouldScroll(el.parentNode as Element, delta)
+      if (!alreadyAtStart && scrollingUp) return true
+      if (!alreadyAtEnd && scrollingDown) return true
+      if ((alreadyAtStart || alreadyAtEnd)) {
+        return this.shouldScroll(el.parentNode as Element, e)
       }
 
       return false
@@ -185,14 +197,13 @@ export default Vue.extend<Vue & Toggleable & Stackable & options>().extend({
     },
     checkPath (e: WheelEvent) {
       const path = composedPath(e)
-      const delta = e.deltaY
 
       if (e.type === 'keydown' && path[0] === document.body) {
         const dialog = this.$refs.dialog
         // getSelection returns null in firefox in some edge cases, can be ignored
         const selected = window.getSelection()!.anchorNode as Element
         if (dialog && this.hasScrollbar(dialog) && this.isInside(selected, dialog)) {
-          return !this.shouldScroll(dialog, delta)
+          return !this.shouldScroll(dialog, e)
         }
         return true
       }
@@ -204,7 +215,7 @@ export default Vue.extend<Vue & Toggleable & Stackable & options>().extend({
         if (el === document.documentElement) return true
         if (el === this.$refs.content) return true
 
-        if (this.hasScrollbar(el as Element)) return !this.shouldScroll(el as Element, delta)
+        if (this.hasScrollbar(el as Element)) return !this.shouldScroll(el as Element, e)
       }
 
       return true

package/src/mixins/routable/__tests__/routable.spec.ts

@@ -1,12 +1,50 @@
 import Routable from '../'
-import { mount } from '@vue/test-utils'
+import { createLocalVue, mount, Wrapper } from '@vue/test-utils'
+import Router from 'vue-router'
+import Vue, { VNode } from 'vue'
 
 describe('routable.ts', () => {
+  let mountFunction: (options?: object) => Wrapper<Vue>
+  let router: Router
+  let localVue: typeof Vue
+
+  beforeEach(() => {
+    router = new Router()
+    localVue = createLocalVue()
+    localVue.use(Router)
+
+    mountFunction = (options = {}) => {
+      return mount({
+        mixins: [Routable],
+        props: {
+          activeClass: {
+            default: 'active',
+          },
+          exactActiveClass: {
+            default: 'exact-active',
+          },
+        },
+        render (h): VNode {
+          const { tag, data } = this.generateRouteLink()
+
+          data.attrs = {
+            ...data.attrs,
+          }
+          data.on = {
+            ...data.on,
+          }
+
+          return h(tag, data, this.$slots.default)
+        },
+      }, {
+        localVue,
+        router,
+        ...options,
+      })
+    }
+  })
   it('should generate exact route link with to="/" and undefined exact', async () => {
-    const wrapper = mount({
-      mixins: [Routable],
-      render: h => h('div'),
-    }, {
+    const wrapper = mountFunction({
       propsData: {
         to: '/',
       },
@@ -14,4 +52,43 @@ describe('routable.ts', () => {
 
     expect(wrapper.vm.generateRouteLink().data.props.exact).toBe(true)
   })
+
+  it('should reflect the link state to isActive', async () => {
+    const wrapper = mountFunction({
+      propsData: {
+        to: '/',
+      },
+    })
+    await wrapper.vm.$nextTick()
+    expect(wrapper.vm.isActive).toBe(true)
+
+    // Simulate route changing
+    wrapper.vm.$router.push('/foo')
+
+    await wrapper.vm.$nextTick()
+    await wrapper.vm.$nextTick()
+    expect(wrapper.vm.isActive).toBe(false)
+
+    wrapper.vm.$router.push('/')
+    await wrapper.vm.$nextTick()
+    await wrapper.vm.$nextTick()
+    expect(wrapper.vm.isActive).toBe(true)
+  })
+
+  it('should reflect the link state to isActive if not exact', async () => {
+    const wrapper = mountFunction({
+      propsData: {
+        to: '/foo',
+      },
+    })
+    await wrapper.vm.$nextTick()
+    expect(wrapper.vm.isActive).toBe(false)
+
+    // Simulate route changing
+    wrapper.vm.$router.push('/foo')
+
+    await wrapper.vm.$nextTick()
+    await wrapper.vm.$nextTick()
+    expect(wrapper.vm.isActive).toBe(true)
+  })
 })

package/src/mixins/routable/index.ts

@@ -75,10 +75,11 @@ export default Vue.extend({
     $route: 'onRouteChange',
   },
 
+  mounted () {
+    this.onRouteChange()
+  },
+
   methods: {
-    click (e: MouseEvent): void {
-      this.$emit('click', e)
-    },
     generateRouteLink () {
       let exact = this.exact
       let tag
@@ -96,7 +97,7 @@ export default Vue.extend({
         }],
         [this.to ? 'nativeOn' : 'on']: {
           ...this.$listeners,
-          click: this.click,
+          ...('click' in this ? { click: (this as any).click } : undefined), // #14447
         },
         ref: 'link',
       }
@@ -139,17 +140,20 @@ export default Vue.extend({
     },
     onRouteChange () {
       if (!this.to || !this.$refs.link || !this.$route) return
-      const activeClass = `${this.activeClass} ${this.proxyClass || ''}`.trim()
+      const activeClass = `${this.activeClass || ''} ${this.proxyClass || ''}`.trim()
+      const exactActiveClass = `${this.exactActiveClass || ''} ${this.proxyClass || ''}`.trim() || activeClass
 
-      const path = `_vnode.data.class.${activeClass}`
+      const path = '_vnode.data.class.' + (this.exact ? exactActiveClass : activeClass)
 
       this.$nextTick(() => {
         /* istanbul ignore else */
-        if (getObjectValueByPath(this.$refs.link, path)) {
+        if (!getObjectValueByPath(this.$refs.link, path) === this.isActive) {
           this.toggle()
         }
       })
     },
-    toggle: () => { /* noop */ },
+    toggle () {
+      this.isActive = !this.isActive
+    },
   },
 })

package/src/services/application/index.ts

@@ -36,7 +36,7 @@ export class Application extends Service implements IApplication {
     location: TargetProp,
     size: number
   ) {
-    this.application[location] = { [uid]: size }
+    this.application[location][uid] = size
 
     this.update(location)
   }