vsn 0.1.53 → 0.1.54

package/README.md

@@ -1,4 +1,4 @@
-[![npm version](https://badge.fury.io/js/vsn.svg)](https://badge.fury.io/js/vsn) [![Build Status](https://travis-ci.org/malero/vsn.svg?branch=master)](https://travis-ci.org/malero/vsn) [![codecov](https://codecov.io/gh/malero/vsn/branch/master/graph/badge.svg)](https://codecov.io/gh/malero/vsn) [![npm](https://img.shields.io/npm/dw/vsn.svg)]()
+[![npm version](https://badge.fury.io/js/vsn.svg)](https://badge.fury.io/js/vsn) [![Build Status](https://travis-ci.org/malero/vsn.svg?branch=master)](https://travis-ci.org/malero/vsn) [![codecov](https://codecov.io/gh/malero/vsn/branch/master/graph/badge.svg)](https://codecov.io/gh/malero/vsn) [![npm](https://img.shields.io/npm/dw/vsn.svg)]() [![gzip bundle size](http://img.badgesize.io/https://unpkg.com/vsn@latest/dist/?compression=gzip&style=flat-square)](https://unpkg.com/vsn)
 
 # VisionJS Framework
 
@@ -12,4 +12,4 @@ Use NPM to install VisionJS with the following command:
 
 ## Usage
 
-Please visit the [docs](https://vsnjs.org) for more information.
+Please visit the [docs](https://www.vsnjs.org) for more information.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vsn",
-  "version": "0.1.53",
+  "version": "0.1.54",
   "description": "SEO Friendly Javascript/Typescript Framework",
   "keywords": [
     "framework",

package/src/Tag.ts

@@ -250,6 +250,9 @@ export class Tag extends DOMObject {
         if (!!this._scope)
             return this._scope;
 
+        if (this.uniqueScope)
+            return this.createScope();
+
         if (!!this._parentTag)
             return this._parentTag.scope;
 
@@ -432,7 +435,6 @@ export class Tag extends DOMObject {
 
         if (requiresScope && !this.uniqueScope) {
             this._uniqueScope = true;
-            this._scope = new Scope();
         }
 
         this._state = TagState.AttributesBuilt;
@@ -569,17 +571,21 @@ export class Tag extends DOMObject {
         }
     }
 
-    public createScope() {
+    public createScope(force: boolean = false): Scope {
         // Standard attribute requires a unique scope
         // @todo: Does this cause any issues with attribute bindings on the parent scope prior to having its own scope? hmm...
-        if (!this.uniqueScope) {
+        if ((!this.uniqueScope && force) || this.uniqueScope) {
             this._uniqueScope = true;
             this._scope = new Scope();
 
             if (this.parentTag) {
                 this.scope.parentScope = this.parentTag.scope;
             }
+
+            return this._scope;
         }
+
+        return null;
     }
 
     async watchAttribute(attributeName: string) {
@@ -589,7 +595,7 @@ export class Tag extends DOMObject {
             }
         }
 
-        this.createScope();
+        this.createScope(true);
 
         const standardAttribute = new StandardAttribute(this, attributeName);
         this.attributes.push(standardAttribute);
@@ -605,7 +611,7 @@ export class Tag extends DOMObject {
             }
         }
 
-        this.createScope();
+        this.createScope(true);
 
         const styleAttribute = new StyleAttribute(this, 'style');
         this.attributes.push(styleAttribute);

package/src/attributes/ScopeAttribute.ts

@@ -10,18 +10,24 @@ export class ScopeAttribute extends Attribute {
     protected tree: Tree;
 
     public async compile() {
-        this.tree = new Tree(this.getAttributeValue());
-        await this.tree.prepare(this.tag.scope, this.tag.dom, this.tag);
+        const code = this.getAttributeValue();
+        if (code) {
+            this.tree = new Tree(code);
+            await this.tree.prepare(this.tag.scope, this.tag.dom, this.tag);
+        }
         await super.compile();
     }
 
     public async extract() {
-        const value = await this.tree.evaluate(this.tag.scope, this.tag.dom, this.tag);
-        if (!(value instanceof Scope)) {
-            throw new Error(`Scope value must be an object, got ${typeof value}`);
-        }
-        for (const key of value.data.keys) {
-            this.tag.scope.set(key, value.data[key]);
+        if (this.tree) {
+            const value = await this.tree.evaluate(this.tag.scope, this.tag.dom, this.tag);
+            if (!(value instanceof Scope)) {
+                throw new Error(`vsn-scope value must be an object, got ${typeof value}`);
+            }
+            for (const key of value.data.keys) {
+                this.tag.scope.set(key, value.data[key]);
+            }
         }
+        await super.extract();
     }
 }

package/test/attributes/ScopeAttribute.spec.ts

@@ -20,4 +20,16 @@ describe('ScopeAttribute', () => {
             done();
         });
     });
+
+    it("vsn-scope should allow empty value to create a scope", (done) => {
+        document.body.innerHTML = `
+            <div vsn-scope></div>
+        `;
+        const dom = new DOM(document);
+        dom.once('built', async () => {
+            const element = (await dom.exec('?(div)'))[0];
+            expect(element.uniqueScope).toBe(true);
+            done();
+        });
+    });
 });